From: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org> To: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>, Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> Cc: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Rafael J. Wysocki" <rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Bin Liu <b-liu-l0cyMroinI0@public.gmane.org>, Heikki Krogerus <heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, Andy Shevchenko <andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>, Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Subject: Re: MUSB peripheral DMA regression caused by driver core runtime PM change Date: Fri, 23 Oct 2015 15:50:21 +0300 [thread overview] Message-ID: <562A2D0D.3060104@ti.com> (raw) In-Reply-To: <20151022230133.GV3078-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> On 10/23/2015 02:01 AM, Tony Lindgren wrote: > * Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> [151022 11:03]: >> * Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> [151021 16:44]: >>> Hi all, >>> >>> I noticed a regresssino in v4.3-rc series to day with MUSB gadgets >>> and DMA. Doing a git bisect between v4.2..v4.3-rc1 on it pointed to: >>> >>> ddef08dd00f5 ("Driver core: wakeup the parent device before trying probe") >>> >>> With the commit above reverted things work fine with DMA and USB gadgets. >>> >>> This is on omap3 with CONFIG_USB_INVENTRA_DMA selected. Selecting >>> CONFIG_MUSB_PIO_ONLY still works even without reverting ddef08dd00f5. >>> >>> Anybody got ideas what might be wrong? Some wrong runtime PM usage >>> under drivers/usb/musb? >> >> Here's some more debug info on where things are different initializing >> the USB gadgets. I added some printks and diffed the dmesg output. The >> added calls from commit ddef08dd00f5 start with dd: > > Well turns out the problem actually happens earlier. We end up calling > omap2430_runtime_resume with NULL struct musb while EPROBE_DEFER > probing. > > No ideas yet how it should be fixed though. > I'm not sure, but below diff might help diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index 70f2b8a..aba8ca7 100644 --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c @@ -391,6 +391,8 @@ static int omap2430_musb_init(struct musb *musb) } musb->isr = omap2430_musb_interrupt; + pm_runtime_enable(glue->dev); + status = pm_runtime_get_sync(dev); if (status < 0) { dev_err(dev, "pm_runtime_get_sync FAILED %d\n", status); @@ -626,8 +628,6 @@ static int omap2430_probe(struct platform_device *pdev) goto err2; } - pm_runtime_enable(&pdev->dev);
WARNING: multiple messages have this Message-ID (diff)
From: grygorii.strashko@ti.com (Grygorii Strashko) To: linux-arm-kernel@lists.infradead.org Subject: MUSB peripheral DMA regression caused by driver core runtime PM change Date: Fri, 23 Oct 2015 15:50:21 +0300 [thread overview] Message-ID: <562A2D0D.3060104@ti.com> (raw) In-Reply-To: <20151022230133.GV3078@atomide.com> On 10/23/2015 02:01 AM, Tony Lindgren wrote: > * Tony Lindgren <tony@atomide.com> [151022 11:03]: >> * Tony Lindgren <tony@atomide.com> [151021 16:44]: >>> Hi all, >>> >>> I noticed a regresssino in v4.3-rc series to day with MUSB gadgets >>> and DMA. Doing a git bisect between v4.2..v4.3-rc1 on it pointed to: >>> >>> ddef08dd00f5 ("Driver core: wakeup the parent device before trying probe") >>> >>> With the commit above reverted things work fine with DMA and USB gadgets. >>> >>> This is on omap3 with CONFIG_USB_INVENTRA_DMA selected. Selecting >>> CONFIG_MUSB_PIO_ONLY still works even without reverting ddef08dd00f5. >>> >>> Anybody got ideas what might be wrong? Some wrong runtime PM usage >>> under drivers/usb/musb? >> >> Here's some more debug info on where things are different initializing >> the USB gadgets. I added some printks and diffed the dmesg output. The >> added calls from commit ddef08dd00f5 start with dd: > > Well turns out the problem actually happens earlier. We end up calling > omap2430_runtime_resume with NULL struct musb while EPROBE_DEFER > probing. > > No ideas yet how it should be fixed though. > I'm not sure, but below diff might help diff --git a/drivers/usb/musb/omap2430.c b/drivers/usb/musb/omap2430.c index 70f2b8a..aba8ca7 100644 --- a/drivers/usb/musb/omap2430.c +++ b/drivers/usb/musb/omap2430.c @@ -391,6 +391,8 @@ static int omap2430_musb_init(struct musb *musb) } musb->isr = omap2430_musb_interrupt; + pm_runtime_enable(glue->dev); + status = pm_runtime_get_sync(dev); if (status < 0) { dev_err(dev, "pm_runtime_get_sync FAILED %d\n", status); @@ -626,8 +628,6 @@ static int omap2430_probe(struct platform_device *pdev) goto err2; } - pm_runtime_enable(&pdev->dev); - ret = platform_device_add(musb); if (ret) { dev_err(&pdev->dev, "failed to register musb device\n"); -- regards, -grygorii
next prev parent reply other threads:[~2015-10-23 12:50 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-10-21 23:41 MUSB peripheral DMA regression caused by driver core runtime PM change Tony Lindgren 2015-10-21 23:41 ` Tony Lindgren [not found] ` <20151021234134.GQ3078-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2015-10-22 18:02 ` Tony Lindgren 2015-10-22 18:02 ` Tony Lindgren [not found] ` <20151022180216.GT3078-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2015-10-22 23:01 ` Tony Lindgren 2015-10-22 23:01 ` Tony Lindgren [not found] ` <20151022230133.GV3078-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2015-10-23 12:50 ` Grygorii Strashko [this message] 2015-10-23 12:50 ` Grygorii Strashko [not found] ` <562A2D0D.3060104-l0cyMroinI0@public.gmane.org> 2015-10-23 16:43 ` Tony Lindgren 2015-10-23 16:43 ` Tony Lindgren [not found] ` <20151023163957.GW3078-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2015-10-23 16:48 ` Felipe Balbi 2015-10-23 16:48 ` Felipe Balbi [not found] ` <877fmdcyzi.fsf-HgARHv6XitJaoMGHk7MhZQC/G2K4zDHf@public.gmane.org> 2015-10-23 17:58 ` Grygorii Strashko 2015-10-23 17:58 ` Grygorii Strashko [not found] ` <562A7549.3070400-l0cyMroinI0@public.gmane.org> 2015-10-23 18:27 ` Alan Stern 2015-10-23 18:27 ` Alan Stern [not found] ` <Pine.LNX.4.44L0.1510231406200.1644-100000-IYeN2dnnYyZXsRXLowluHWD2FQJk+8+b@public.gmane.org> 2015-10-23 19:20 ` Tony Lindgren 2015-10-23 19:20 ` Tony Lindgren 2015-10-23 20:33 ` Alan Stern 2015-10-23 20:33 ` Alan Stern 2015-10-23 20:36 ` Tony Lindgren 2015-10-23 20:36 ` Tony Lindgren 2015-10-28 17:14 ` Tony Lindgren 2015-10-28 17:14 ` Tony Lindgren [not found] ` <20151028171441.GE3078-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org> 2015-10-28 17:16 ` Felipe Balbi 2015-10-28 17:16 ` Felipe Balbi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=562A2D0D.3060104@ti.com \ --to=grygorii.strashko-l0cymroini0@public.gmane.org \ --cc=andriy.shevchenko-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \ --cc=b-liu-l0cyMroinI0@public.gmane.org \ --cc=balbi-l0cyMroinI0@public.gmane.org \ --cc=heikki.krogerus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \ --cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=rafael.j.wysocki-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.