* hid-sony appears to be broken for some (new?) DualShock 4 controllers
@ 2015-10-24 1:20 Chris
0 siblings, 0 replies; only message in thread
From: Chris @ 2015-10-24 1:20 UTC (permalink / raw)
To: linux-kernel
I have a brand new DualShock 4 and the descriptor is a different size
than what the hid-sony driver expects. This causes the controller to not
work at all over wireless except for the trackpad. On USB it sort of
works but the motion sense does not. This affects kernels starting at
3.15 all the way to the current 4.3rc6.
In sony_report_fixup() it looks for a size of 467 for USB or 357 for
Bluetooth but my controller's descriptor size is 499 USB and 365 BT.
I changed the sizes and the controller seems to be fully functional now.
Is the descriptor size check actually even necessary? Don't all DS4's
require the modified descriptor table regardless? I don't know.
These are the changes I made against 4.3rc6:
---
diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c
index 661f94f..d93a6a8 100644
--- a/drivers/hid/hid-sony.c
+++ b/drivers/hid/hid-sony.c
@@ -1137,11 +1137,11 @@ static __u8 *sony_report_fixup(struct hid_device
*hdev, __u8 *rdesc,
* the gyroscope values to corresponding axes so we need a
* modified one.
*/
- if ((sc->quirks & DUALSHOCK4_CONTROLLER_USB) && *rsize == 467) {
+ if ((sc->quirks & DUALSHOCK4_CONTROLLER_USB) && (*rsize == 467
|| *rsize == 499)) {
hid_info(hdev, "Using modified Dualshock 4 report
descriptor with gyroscope axes\n");
rdesc = dualshock4_usb_rdesc;
*rsize = sizeof(dualshock4_usb_rdesc);
- } else if ((sc->quirks & DUALSHOCK4_CONTROLLER_BT) && *rsize ==
357) {
+ } else if ((sc->quirks & DUALSHOCK4_CONTROLLER_BT) && (*rsize ==
357 || *rsize == 365)) {
hid_info(hdev, "Using modified Dualshock 4 Bluetooth
report descriptor\n");
rdesc = dualshock4_bt_rdesc;
*rsize = sizeof(dualshock4_bt_rdesc);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-10-24 1:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-24 1:20 hid-sony appears to be broken for some (new?) DualShock 4 controllers Chris
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.