* [PATCH] iio:ad7793: Fix ad7785 product ID
@ 2015-10-12 12:56 Lars-Peter Clausen
2015-10-25 13:40 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2015-10-12 12:56 UTC (permalink / raw)
To: Jonathan Cameron, Hartmut Knaack, Peter Meerwald
Cc: linux-iio, Lars-Peter Clausen
While the datasheet for the AD7785 lists 0xXB as the product ID the actual
product ID is 0xX3.
Fix the product ID otherwise the driver will reject the device due to non
matching IDs.
Fixes: e786cc26dcc5 ("staging:iio:ad7793: Implement stricter id checking")
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/iio/adc/ad7793.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
index b84922a..710aee8 100644
--- a/drivers/iio/adc/ad7793.c
+++ b/drivers/iio/adc/ad7793.c
@@ -101,7 +101,7 @@
#define AD7795_CH_AIN1M_AIN1M 8 /* AIN1(-) - AIN1(-) */
/* ID Register Bit Designations (AD7793_REG_ID) */
-#define AD7785_ID 0xB
+#define AD7785_ID 0x3
#define AD7792_ID 0xA
#define AD7793_ID 0xB
#define AD7794_ID 0xF
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] iio:ad7793: Fix ad7785 product ID
2015-10-12 12:56 [PATCH] iio:ad7793: Fix ad7785 product ID Lars-Peter Clausen
@ 2015-10-25 13:40 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2015-10-25 13:40 UTC (permalink / raw)
To: Lars-Peter Clausen, Hartmut Knaack, Peter Meerwald; +Cc: linux-iio
On 12/10/15 13:56, Lars-Peter Clausen wrote:
> While the datasheet for the AD7785 lists 0xXB as the product ID the actual
> product ID is 0xX3.
>
> Fix the product ID otherwise the driver will reject the device due to non
> matching IDs.
>
> Fixes: e786cc26dcc5 ("staging:iio:ad7793: Implement stricter id checking")
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Applied to the fixes-togreg branch of iio.git and marked for stable.
> ---
> drivers/iio/adc/ad7793.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
> index b84922a..710aee8 100644
> --- a/drivers/iio/adc/ad7793.c
> +++ b/drivers/iio/adc/ad7793.c
> @@ -101,7 +101,7 @@
> #define AD7795_CH_AIN1M_AIN1M 8 /* AIN1(-) - AIN1(-) */
>
> /* ID Register Bit Designations (AD7793_REG_ID) */
> -#define AD7785_ID 0xB
> +#define AD7785_ID 0x3
> #define AD7792_ID 0xA
> #define AD7793_ID 0xB
> #define AD7794_ID 0xF
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-25 13:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-12 12:56 [PATCH] iio:ad7793: Fix ad7785 product ID Lars-Peter Clausen
2015-10-25 13:40 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.