* [PATCH] staging: ft1000: Remove boolean comparisons
@ 2015-10-18 20:58 Luis de Bethencourt
2015-10-25 2:20 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Luis de Bethencourt @ 2015-10-18 20:58 UTC (permalink / raw)
To: linux-kernel
Cc: marek.belisko, gregkh, devel, gulsah.1004, joe,
daniele.alessandrelli, mahfouz.saif.elyazal, rickard_strandqvist,
Luis de Bethencourt
Boolean tests do not need explicit comparison to true or false.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 4 ++--
drivers/staging/ft1000/ft1000-usb/ft1000_hw.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
index eecfa37..dfb5da93 100644
--- a/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
+++ b/drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c
@@ -1531,7 +1531,7 @@ static int ft1000_copy_up_pkt(struct net_device *dev)
tempword = ft1000_read_reg(dev, FT1000_REG_DFIFO);
*pbuffer++ = (u8) (tempword >> 8);
*pbuffer++ = (u8)tempword;
- if (ft1000_chkcard(dev) == false) {
+ if (!ft1000_chkcard(dev)) {
kfree_skb(skb);
return FAILURE;
}
@@ -1822,7 +1822,7 @@ static irqreturn_t ft1000_interrupt(int irq, void *dev_id)
return IRQ_HANDLED;
}
- if (ft1000_chkcard(dev) == false) {
+ if (!ft1000_chkcard(dev)) {
ft1000_disable_interrupts(dev);
return IRQ_HANDLED;
}
diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
index 9ea32ce..22582be 100644
--- a/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
+++ b/drivers/staging/ft1000/ft1000-usb/ft1000_hw.c
@@ -1465,7 +1465,7 @@ int ft1000_poll(void *dev_id)
u16 modulo;
u16 portid;
- if (ft1000_chkcard(dev) == FALSE) {
+ if (!ft1000_chkcard(dev)) {
pr_debug("failed\n");
return -1;
}
--
2.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: ft1000: Remove boolean comparisons
2015-10-18 20:58 [PATCH] staging: ft1000: Remove boolean comparisons Luis de Bethencourt
@ 2015-10-25 2:20 ` Greg KH
2015-10-26 6:06 ` Luis de Bethencourt
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2015-10-25 2:20 UTC (permalink / raw)
To: Luis de Bethencourt
Cc: linux-kernel, marek.belisko, devel, gulsah.1004, joe,
daniele.alessandrelli, mahfouz.saif.elyazal, rickard_strandqvist
On Sun, Oct 18, 2015 at 09:58:15PM +0100, Luis de Bethencourt wrote:
> Boolean tests do not need explicit comparison to true or false.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 4 ++--
> drivers/staging/ft1000/ft1000-usb/ft1000_hw.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
This driver just got deleted from the tree, sorry :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: ft1000: Remove boolean comparisons
2015-10-25 2:20 ` Greg KH
@ 2015-10-26 6:06 ` Luis de Bethencourt
0 siblings, 0 replies; 3+ messages in thread
From: Luis de Bethencourt @ 2015-10-26 6:06 UTC (permalink / raw)
To: Greg KH
Cc: linux-kernel, marek.belisko, devel, gulsah.1004, joe,
daniele.alessandrelli, mahfouz.saif.elyazal, rickard_strandqvist
On 25/10/15 02:20, Greg KH wrote:
> On Sun, Oct 18, 2015 at 09:58:15PM +0100, Luis de Bethencourt wrote:
>> Boolean tests do not need explicit comparison to true or false.
>>
>> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
>> ---
>> drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 4 ++--
>> drivers/staging/ft1000/ft1000-usb/ft1000_hw.c | 2 +-
>> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> This driver just got deleted from the tree, sorry :(
>
Hi Greg,
No problem. I see the commit that removed this driver [0] mentions the radio
technology service has been discontinued.
Great to see drivers removed when they become obsolete instead of zombily
maintained.
Thanks for the review,
Luis
[0] https://git.kernel.org/cgit/linux/kernel/git/gregkh/staging.git/commit/?h=staging-testing&id=6512edec48b2ccfe9bb969ce26ebbbcd49de6c4b
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-26 6:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-18 20:58 [PATCH] staging: ft1000: Remove boolean comparisons Luis de Bethencourt
2015-10-25 2:20 ` Greg KH
2015-10-26 6:06 ` Luis de Bethencourt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.