* [PATCH] Staging: android: uapi: fixed comment block coding style error in ion.h
@ 2015-10-25 22:16 Dzonatans Melgalvis
2015-10-26 21:41 ` Laura Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Dzonatans Melgalvis @ 2015-10-25 22:16 UTC (permalink / raw)
To: gregkh; +Cc: arve, riandrews, devel, linux-kernel, Dzonatans Melgalvis
Fixed checkpatch.pl warning about comment block coding style.
Signed-off-by: Dzonatans Melgalvis <dz.melgalvis@gmail.com>
---
drivers/staging/android/uapi/ion.h | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
index 68a14b4..11df59f 100644
--- a/drivers/staging/android/uapi/ion.h
+++ b/drivers/staging/android/uapi/ion.h
@@ -56,13 +56,15 @@ enum ion_heap_type {
* allocation flags - the lower 16 bits are used by core ion, the upper 16
* bits are reserved for use by the heaps themselves.
*/
-#define ION_FLAG_CACHED 1 /* mappings of this buffer should be
- cached, ion will do cache
- maintenance when the buffer is
- mapped for dma */
+#define ION_FLAG_CACHED 1 /* mappings of this buffer should be
+ * cached, ion will do cache
+ * maintenance when the buffer is
+ * mapped for dma
+ */
#define ION_FLAG_CACHED_NEEDS_SYNC 2 /* mappings of this buffer will created
- at mmap time, if this is set
- caches must be managed manually */
+ * at mmap time, if this is set
+ * caches must be managed manually
+ */
/**
* DOC: Ion Userspace API
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: android: uapi: fixed comment block coding style error in ion.h
2015-10-25 22:16 [PATCH] Staging: android: uapi: fixed comment block coding style error in ion.h Dzonatans Melgalvis
@ 2015-10-26 21:41 ` Laura Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Laura Abbott @ 2015-10-26 21:41 UTC (permalink / raw)
To: Dzonatans Melgalvis, gregkh; +Cc: arve, riandrews, devel, linux-kernel
On 10/25/15 3:16 PM, Dzonatans Melgalvis wrote:
> Fixed checkpatch.pl warning about comment block coding style.
>
The right aligned comments aren't great style.
How about moving the comments (with the correct style) right
above the macro they are describing.
> Signed-off-by: Dzonatans Melgalvis <dz.melgalvis@gmail.com>
> ---
> drivers/staging/android/uapi/ion.h | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 68a14b4..11df59f 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -56,13 +56,15 @@ enum ion_heap_type {
> * allocation flags - the lower 16 bits are used by core ion, the upper 16
> * bits are reserved for use by the heaps themselves.
> */
> -#define ION_FLAG_CACHED 1 /* mappings of this buffer should be
> - cached, ion will do cache
> - maintenance when the buffer is
> - mapped for dma */
> +#define ION_FLAG_CACHED 1 /* mappings of this buffer should be
> + * cached, ion will do cache
> + * maintenance when the buffer is
> + * mapped for dma
> + */
> #define ION_FLAG_CACHED_NEEDS_SYNC 2 /* mappings of this buffer will created
> - at mmap time, if this is set
> - caches must be managed manually */
> + * at mmap time, if this is set
> + * caches must be managed manually
> + */
>
> /**
> * DOC: Ion Userspace API
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-26 21:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-25 22:16 [PATCH] Staging: android: uapi: fixed comment block coding style error in ion.h Dzonatans Melgalvis
2015-10-26 21:41 ` Laura Abbott
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.