* [Buildroot] [PATCH v5 1/1] yad: new package
@ 2015-10-23 23:10 James Knight
2015-10-27 14:41 ` Vicente Olivert Riera
0 siblings, 1 reply; 4+ messages in thread
From: James Knight @ 2015-10-23 23:10 UTC (permalink / raw)
To: buildroot
Signed-off-by: James Knight <james.knight@rockwellcollins.com>
---
Changes v4 -> v5:
- Increment to version 0.31.2.
- Cleanup yad menu option to be visible after Xorg/MMU is selected.
Changes v3 -> v4:
- Add missing libglib2 dependencies (pointed out by Vicente Olivert
Riera).
- Cleanup YAD help description to maximize the 72-character limit
space (suggested by Vicente Olivert Riera).
Changes v2 -> v3:
- Increment to version 0.31.1 (removed need for HTML patch introduced
in v2 change; suggested by Vicente Olivert Riera).
Changes v1 -> v2:
- Increment to version 0.29.0 (with updated hash and patch fix).
- Removed complex gtk library selection. Defaults to libgtk3, if
available; elsewise, uses libgtk2 (suggested from comments by
Baruch Siach, Thomas Petazzoni and Peter Korsgaard).
---
package/Config.in | 1 +
package/yad/Config.in | 17 +++++++++++++++++
package/yad/yad.hash | 2 ++
package/yad/yad.mk | 24 ++++++++++++++++++++++++
4 files changed, 44 insertions(+)
create mode 100644 package/yad/Config.in
create mode 100644 package/yad/yad.hash
create mode 100644 package/yad/yad.mk
diff --git a/package/Config.in b/package/Config.in
index 2f74439..5971ffa 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -293,6 +293,7 @@ comment "X applications"
source "package/xscreensaver/Config.in"
source "package/xterm/Config.in"
source "package/xvkbd/Config.in"
+ source "package/yad/Config.in"
comment "X libraries and helper libraries"
source "package/libsexy/Config.in"
diff --git a/package/yad/Config.in b/package/yad/Config.in
new file mode 100644
index 0000000..9b16729
--- /dev/null
+++ b/package/yad/Config.in
@@ -0,0 +1,17 @@
+config BR2_PACKAGE_YAD
+ bool "yad"
+ depends on BR2_PACKAGE_XORG7
+ depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3
+ depends on BR2_USE_WCHAR # libglib2
+ depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
+ depends on BR2_USE_MMU # libglib2
+ select BR2_PACKAGE_LIBGLIB2
+ help
+ YAD (yet another dialog) is a tool for create graphical dialogs from
+ shell scripts.
+
+ http://sourceforge.net/projects/yad-dialog/
+
+comment "yad needs libgtk2 or libgtk3"
+ depends on BR2_PACKAGE_XORG7 && BR2_USE_MMU
+ depends on !BR2_PACKAGE_LIBGTK2 && !BR2_PACKAGE_LIBGTK3
diff --git a/package/yad/yad.hash b/package/yad/yad.hash
new file mode 100644
index 0000000..4e88ab0
--- /dev/null
+++ b/package/yad/yad.hash
@@ -0,0 +1,2 @@
+# Locally computed
+sha256 c91d6a9eb36abdb502d2d8ada0ec29c266b94a6628f723adeca436bee0b6c55c yad-0.31.2.tar.xz
diff --git a/package/yad/yad.mk b/package/yad/yad.mk
new file mode 100644
index 0000000..57262e8
--- /dev/null
+++ b/package/yad/yad.mk
@@ -0,0 +1,24 @@
+################################################################################
+#
+# yad
+#
+################################################################################
+
+YAD_VERSION = 0.31.2
+YAD_SOURCE = yad-$(YAD_VERSION).tar.xz
+YAD_SITE = http://sourceforge.net/projects/yad-dialog/files
+YAD_LICENSE = GPLv3
+YAD_LICENSE_FILES = COPYING
+YAD_DEPENDENCIES = host-intltool host-pkgconf libglib2
+
+YAD_CONF_OPTS = --enable-html=no
+
+ifeq ($(BR2_PACKAGE_LIBGTK3),y)
+YAD_DEPENDENCIES += libgtk3
+YAD_CONF_OPTS += --with-gtk=gtk3
+else
+YAD_DEPENDENCIES += libgtk2
+YAD_CONF_OPTS += --with-gtk=gtk2
+endif
+
+$(eval $(autotools-package))
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v5 1/1] yad: new package
2015-10-23 23:10 [Buildroot] [PATCH v5 1/1] yad: new package James Knight
@ 2015-10-27 14:41 ` Vicente Olivert Riera
2015-10-28 21:34 ` James Knight
0 siblings, 1 reply; 4+ messages in thread
From: Vicente Olivert Riera @ 2015-10-27 14:41 UTC (permalink / raw)
To: buildroot
Dear James Knight,
On 10/24/2015 12:10 AM, James Knight wrote:
> Signed-off-by: James Knight <james.knight@rockwellcollins.com>
[snip]
> diff --git a/package/yad/Config.in b/package/yad/Config.in
> new file mode 100644
> index 0000000..9b16729
> --- /dev/null
> +++ b/package/yad/Config.in
> @@ -0,0 +1,17 @@
> +config BR2_PACKAGE_YAD
> + bool "yad"
> + depends on BR2_PACKAGE_XORG7
> + depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3
> + depends on BR2_USE_WCHAR # libglib2
> + depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
> + depends on BR2_USE_MMU # libglib2
> + select BR2_PACKAGE_LIBGLIB2
> + help
> + YAD (yet another dialog) is a tool for create graphical dialogs from
That line exceeds the 72 characters limit considering 8-characters-wide
tabs.
Apart from that minor detail, which I guess after 5 versions of your
patch the maintainer will not mind to fix it for you, your patch looks
good to me.
Reviewed-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Tested-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Build test for MIPS architecture:
$ file output/target/usr/bin/yad
output/target/usr/bin/yad: ELF 32-bit LSB executable, MIPS, MIPS32 rel2
version 1 (SYSV), dynamically linked (uses shared libs), for GNU/Linux
2.6.32, with unknown capability 0xf41 = 0x756e6700, with unknown
capability 0x70100 = 0x1040000, stripped
Regards,
Vincent.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v5 1/1] yad: new package
2015-10-27 14:41 ` Vicente Olivert Riera
@ 2015-10-28 21:34 ` James Knight
2015-10-29 9:09 ` Vicente Olivert Riera
0 siblings, 1 reply; 4+ messages in thread
From: James Knight @ 2015-10-28 21:34 UTC (permalink / raw)
To: buildroot
Vincent,
First off, thanks for reviewing/testing (as always).
On Tue, Oct 27, 2015 at 10:41 AM, Vicente Olivert Riera
<Vincent.Riera@imgtec.com> wrote:
>> + help
>> + YAD (yet another dialog) is a tool for create graphical dialogs from
>
> That line exceeds the 72 characters limit considering 8-characters-wide
> tabs.
Sorry, I'm confused. I only moved the word "from" into the lined based
off your previous suggestion:
On Wed, Oct 7, 2015 at 6:08 AM, Vicente Olivert Riera
<Vincent.Riera@imgtec.com> wrote:
>> + select BR2_PACKAGE_LIBGLIB2
>> + help
>> + YAD (yet another dialog) is a tool for create graphical dialogs
>> + from shell scripts.
>
> The word "from" still fits in the first line as it will not exceed the
> 72 characters limit.
Am I missing something?
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH v5 1/1] yad: new package
2015-10-28 21:34 ` James Knight
@ 2015-10-29 9:09 ` Vicente Olivert Riera
0 siblings, 0 replies; 4+ messages in thread
From: Vicente Olivert Riera @ 2015-10-29 9:09 UTC (permalink / raw)
To: buildroot
Dear James Knight,
On 10/28/2015 09:34 PM, James Knight wrote:
> Vincent,
>
> First off, thanks for reviewing/testing (as always).
>
> On Tue, Oct 27, 2015 at 10:41 AM, Vicente Olivert Riera
> <Vincent.Riera@imgtec.com> wrote:
>>> + help
>>> + YAD (yet another dialog) is a tool for create graphical dialogs from
>>
>> That line exceeds the 72 characters limit considering 8-characters-wide
>> tabs.
>
> Sorry, I'm confused. I only moved the word "from" into the lined based
> off your previous suggestion:
You are totally right and I apologize for that. This is totally my
fault. It seems that in the Buildroot project tabs are considered as 8
characters wide. I didn't know that when I made that suggestion to you,
but in my defense I have to say that is not documented anywhere.
Regards,
Vincent.
> On Wed, Oct 7, 2015 at 6:08 AM, Vicente Olivert Riera
> <Vincent.Riera@imgtec.com> wrote:
>>> + select BR2_PACKAGE_LIBGLIB2
>>> + help
>>> + YAD (yet another dialog) is a tool for create graphical dialogs
>>> + from shell scripts.
>>
>> The word "from" still fits in the first line as it will not exceed the
>> 72 characters limit.
>
> Am I missing something?
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-29 9:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-23 23:10 [Buildroot] [PATCH v5 1/1] yad: new package James Knight
2015-10-27 14:41 ` Vicente Olivert Riera
2015-10-28 21:34 ` James Knight
2015-10-29 9:09 ` Vicente Olivert Riera
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.