* [Qemu-devel] [PATCH] backends: remove empty trace-events file
@ 2017-06-29 16:20 Daniel P. Berrange
2017-06-29 16:26 ` Eric Blake
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Daniel P. Berrange @ 2017-06-29 16:20 UTC (permalink / raw)
To: qemu-devel
Cc: Marc-André Lureau, Stefan Hajnoczi, qemu-trivial,
Daniel P. Berrange
The content of the backends/trace-events file was entirely
removed in
commit 6b10e573d15ef82dbc5c5b3726028e6642e134f6
Author: Marc-André Lureau <marcandre.lureau@redhat.com>
Date: Mon May 29 12:39:42 2017 +0400
char: move char devices to chardev/
Leaving the empty file around, causes tracetool to generate
an empty .dtrace file which makes the dtrace compiler throw
a syntax error.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
---
Makefile.objs | 1 -
backends/trace-events | 0
2 files changed, 1 deletion(-)
delete mode 100644 backends/trace-events
diff --git a/Makefile.objs b/Makefile.objs
index b2e6322..8004d6d 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -122,7 +122,6 @@ trace-events-subdirs += crypto
trace-events-subdirs += io
trace-events-subdirs += migration
trace-events-subdirs += block
-trace-events-subdirs += backends
trace-events-subdirs += chardev
trace-events-subdirs += hw/block
trace-events-subdirs += hw/block/dataplane
diff --git a/backends/trace-events b/backends/trace-events
deleted file mode 100644
index e69de29..0000000
--
2.9.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] backends: remove empty trace-events file
2017-06-29 16:20 [Qemu-devel] [PATCH] backends: remove empty trace-events file Daniel P. Berrange
@ 2017-06-29 16:26 ` Eric Blake
2017-06-29 16:30 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2017-07-06 8:32 ` [Qemu-devel] " Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2017-06-29 16:26 UTC (permalink / raw)
To: Daniel P. Berrange, qemu-devel
Cc: qemu-trivial, Marc-André Lureau, Stefan Hajnoczi
[-- Attachment #1: Type: text/plain, Size: 877 bytes --]
On 06/29/2017 11:20 AM, Daniel P. Berrange wrote:
> The content of the backends/trace-events file was entirely
> removed in
>
> commit 6b10e573d15ef82dbc5c5b3726028e6642e134f6
> Author: Marc-André Lureau <marcandre.lureau@redhat.com>
> Date: Mon May 29 12:39:42 2017 +0400
>
> char: move char devices to chardev/
>
> Leaving the empty file around, causes tracetool to generate
> an empty .dtrace file which makes the dtrace compiler throw
> a syntax error.
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> Makefile.objs | 1 -
> backends/trace-events | 0
> 2 files changed, 1 deletion(-)
> delete mode 100644 backends/trace-events
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] backends: remove empty trace-events file
2017-06-29 16:20 [Qemu-devel] [PATCH] backends: remove empty trace-events file Daniel P. Berrange
2017-06-29 16:26 ` Eric Blake
@ 2017-06-29 16:30 ` Philippe Mathieu-Daudé
2017-07-06 8:32 ` [Qemu-devel] " Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-06-29 16:30 UTC (permalink / raw)
To: Daniel P. Berrange, qemu-devel
Cc: qemu-trivial, Marc-André Lureau, Stefan Hajnoczi
On 06/29/2017 01:20 PM, Daniel P. Berrange wrote:
> The content of the backends/trace-events file was entirely
> removed in
>
> commit 6b10e573d15ef82dbc5c5b3726028e6642e134f6
> Author: Marc-André Lureau <marcandre.lureau@redhat.com>
> Date: Mon May 29 12:39:42 2017 +0400
>
> char: move char devices to chardev/
>
> Leaving the empty file around, causes tracetool to generate
> an empty .dtrace file which makes the dtrace compiler throw
> a syntax error.
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> Makefile.objs | 1 -
> backends/trace-events | 0
> 2 files changed, 1 deletion(-)
> delete mode 100644 backends/trace-events
>
> diff --git a/Makefile.objs b/Makefile.objs
> index b2e6322..8004d6d 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -122,7 +122,6 @@ trace-events-subdirs += crypto
> trace-events-subdirs += io
> trace-events-subdirs += migration
> trace-events-subdirs += block
> -trace-events-subdirs += backends
> trace-events-subdirs += chardev
> trace-events-subdirs += hw/block
> trace-events-subdirs += hw/block/dataplane
> diff --git a/backends/trace-events b/backends/trace-events
> deleted file mode 100644
> index e69de29..0000000
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] backends: remove empty trace-events file
2017-06-29 16:20 [Qemu-devel] [PATCH] backends: remove empty trace-events file Daniel P. Berrange
2017-06-29 16:26 ` Eric Blake
2017-06-29 16:30 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
@ 2017-07-06 8:32 ` Stefan Hajnoczi
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2017-07-06 8:32 UTC (permalink / raw)
To: Daniel P. Berrange
Cc: qemu-devel, qemu-trivial, Marc-André Lureau, Stefan Hajnoczi
[-- Attachment #1: Type: text/plain, Size: 814 bytes --]
On Thu, Jun 29, 2017 at 05:20:46PM +0100, Daniel P. Berrange wrote:
> The content of the backends/trace-events file was entirely
> removed in
>
> commit 6b10e573d15ef82dbc5c5b3726028e6642e134f6
> Author: Marc-André Lureau <marcandre.lureau@redhat.com>
> Date: Mon May 29 12:39:42 2017 +0400
>
> char: move char devices to chardev/
>
> Leaving the empty file around, causes tracetool to generate
> an empty .dtrace file which makes the dtrace compiler throw
> a syntax error.
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> Makefile.objs | 1 -
> backends/trace-events | 0
> 2 files changed, 1 deletion(-)
> delete mode 100644 backends/trace-events
Thanks, applied to my tracing tree:
https://github.com/stefanha/qemu/commits/tracing
Stefan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-07-06 8:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-06-29 16:20 [Qemu-devel] [PATCH] backends: remove empty trace-events file Daniel P. Berrange
2017-06-29 16:26 ` Eric Blake
2017-06-29 16:30 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2017-07-06 8:32 ` [Qemu-devel] " Stefan Hajnoczi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.