[PATCH] xen: fix the check of e_pfn in xen_find_pfn_range

[PATCH] xen: fix the check of e_pfn in xen_find_pfn_range

[Konrad Rzeszutek Wilk]

From: Zhenzhong Duan <zhenzhong.duan@oracle.com>

On some NUMA system, after dom0 up, we see below warning even if there are
enough pfn ranges that could be used for remapping:
"Unable to find available pfn range, not remapping identity pages"

Fix it to avoid getting a memory region of zero size in xen_find_pfn_range.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 arch/x86/xen/setup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index 387b60d..d1fac0e 100644
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -212,7 +212,7 @@ static unsigned long __init xen_find_pfn_range(unsigned long *min_pfn)
 		e_pfn = PFN_DOWN(entry->addr + entry->size);
 
 		/* We only care about E820 after this */
-		if (e_pfn < *min_pfn)
+		if (e_pfn <= *min_pfn)
 			continue;
 
 		s_pfn = PFN_UP(entry->addr);
-- 
2.1.0

Re: [PATCH] xen: fix the check of e_pfn in xen_find_pfn_range

[David Vrabel]

On 27/10/15 19:19, Konrad Rzeszutek Wilk wrote:
> From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
> 
> On some NUMA system, after dom0 up, we see below warning even if there are
> enough pfn ranges that could be used for remapping:
> "Unable to find available pfn range, not remapping identity pages"
> 
> Fix it to avoid getting a memory region of zero size in xen_find_pfn_range.

Applied to for-linus-4.4, thanks.

David

Re: [PATCH] xen: fix the check of e_pfn in xen_find_pfn_range

[Zhenzhong Duan]

Hi David

Konrad just ping me on this patch. I originally think I missed to cc you 
but I does.
Could you ack or nak it?

thanks
zduan

在 2015/9/2 19:04, Juergen Gross 写道:
> On 09/02/2015 12:51 PM, Zhenzhong Duan wrote:
>> On some numa system, after dom0 up, we see below warning even if 
>> there are
>> enough pfn ranges could be used for remapping.
>> "Unable to find available pfn range, not remapping identity pages"
>>
>> Fix it to avoid getting a memory region of zero size in 
>> xen_find_pfn_range.
>>
>> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
>
>> ---
>>   arch/x86/xen/setup.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
>> index a3a7546..c11f6b2 100644
>> --- a/arch/x86/xen/setup.c
>> +++ b/arch/x86/xen/setup.c
>> @@ -178,7 +178,7 @@ static unsigned long __init xen_find_pfn_range(
>>           e_pfn = PFN_DOWN(entry->addr + entry->size);
>>
>>           /* We only care about E820 after this */
>> -        if (e_pfn < *min_pfn)
>> +        if (e_pfn <= *min_pfn)
>>               continue;
>>
>>           s_pfn = PFN_UP(entry->addr);
>

Re: [PATCH] xen: fix the check of e_pfn in xen_find_pfn_range

[Juergen Gross]

On 09/02/2015 12:51 PM, Zhenzhong Duan wrote:
> On some numa system, after dom0 up, we see below warning even if there are
> enough pfn ranges could be used for remapping.
> "Unable to find available pfn range, not remapping identity pages"
>
> Fix it to avoid getting a memory region of zero size in xen_find_pfn_range.
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>

Reviewed-by: Juergen Gross <jgross@suse.com>

> ---
>   arch/x86/xen/setup.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
> index a3a7546..c11f6b2 100644
> --- a/arch/x86/xen/setup.c
> +++ b/arch/x86/xen/setup.c
> @@ -178,7 +178,7 @@ static unsigned long __init xen_find_pfn_range(
>           e_pfn = PFN_DOWN(entry->addr + entry->size);
>
>           /* We only care about E820 after this */
> -        if (e_pfn < *min_pfn)
> +        if (e_pfn <= *min_pfn)
>               continue;
>
>           s_pfn = PFN_UP(entry->addr);

[PATCH] xen: fix the check of e_pfn in xen_find_pfn_range

[Zhenzhong Duan]

On some numa system, after dom0 up, we see below warning even if there are
enough pfn ranges could be used for remapping.
"Unable to find available pfn range, not remapping identity pages"

Fix it to avoid getting a memory region of zero size in xen_find_pfn_range.

Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
---
  arch/x86/xen/setup.c |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/xen/setup.c b/arch/x86/xen/setup.c
index a3a7546..c11f6b2 100644
--- a/arch/x86/xen/setup.c
+++ b/arch/x86/xen/setup.c
@@ -178,7 +178,7 @@ static unsigned long __init xen_find_pfn_range(
  		e_pfn = PFN_DOWN(entry->addr + entry->size);
  
  		/* We only care about E820 after this */
-		if (e_pfn < *min_pfn)
+		if (e_pfn <= *min_pfn)
  			continue;
  
  		s_pfn = PFN_UP(entry->addr);
-- 
1.7.3