All of lore.kernel.org
 help / color / mirror / Atom feed
* [patch] nvme: lightnvm: clean up a data type
@ 2015-11-03 22:37 ` Dan Carpenter
  0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2015-11-03 22:37 UTC (permalink / raw)
  To: kernel-janitors

"nlb_pr_rq" can't be more than u32 because "len" is a u32.  Later we
truncate it to u32 anyway when we calculate min_t().

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
index 133c839..e0b7b95 100644
--- a/drivers/nvme/host/lightnvm.c
+++ b/drivers/nvme/host/lightnvm.c
@@ -282,7 +282,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,
 	struct nvme_dev *dev = ns->dev;
 	struct nvme_nvm_command c = {};
 	u32 len = queue_max_hw_sectors(q) << 9;
-	u64 nlb_pr_rq = len / sizeof(u64);
+	u32 nlb_pr_rq = len / sizeof(u64);
 	u64 cmd_slba = slba;
 	void *entries;
 	int ret = 0;
@@ -294,7 +294,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,
 		return -ENOMEM;
 
 	while (nlb) {
-		u32 cmd_nlb = min_t(u32, nlb_pr_rq, nlb);
+		u32 cmd_nlb = min(nlb_pr_rq, nlb);
 
 		c.l2p.slba = cpu_to_le64(cmd_slba);
 		c.l2p.nlb = cpu_to_le32(cmd_nlb);

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [patch] nvme: lightnvm: clean up a data type
@ 2015-11-03 22:37 ` Dan Carpenter
  0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2015-11-03 22:37 UTC (permalink / raw)


"nlb_pr_rq" can't be more than u32 because "len" is a u32.  Later we
truncate it to u32 anyway when we calculate min_t().

Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>

diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
index 133c839..e0b7b95 100644
--- a/drivers/nvme/host/lightnvm.c
+++ b/drivers/nvme/host/lightnvm.c
@@ -282,7 +282,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,
 	struct nvme_dev *dev = ns->dev;
 	struct nvme_nvm_command c = {};
 	u32 len = queue_max_hw_sectors(q) << 9;
-	u64 nlb_pr_rq = len / sizeof(u64);
+	u32 nlb_pr_rq = len / sizeof(u64);
 	u64 cmd_slba = slba;
 	void *entries;
 	int ret = 0;
@@ -294,7 +294,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,
 		return -ENOMEM;
 
 	while (nlb) {
-		u32 cmd_nlb = min_t(u32, nlb_pr_rq, nlb);
+		u32 cmd_nlb = min(nlb_pr_rq, nlb);
 
 		c.l2p.slba = cpu_to_le64(cmd_slba);
 		c.l2p.nlb = cpu_to_le32(cmd_nlb);

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* RE: [patch] nvme: lightnvm: clean up a data type
  2015-11-03 22:37 ` Dan Carpenter
@ 2015-11-03 22:45   ` Busch, Keith
  -1 siblings, 0 replies; 8+ messages in thread
From: Busch, Keith @ 2015-11-03 22:45 UTC (permalink / raw)
  To: kernel-janitors

Looks right to me. Adding Matias for the last word.

On Tue, Nov 3, 2015, Dan Carpentar wrote:
> "nlb_pr_rq" can't be more than u32 because "len" is a u32.  Later we
> truncate it to u32 anyway when we calculate min_t().
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
> index 133c839..e0b7b95 100644
> --- a/drivers/nvme/host/lightnvm.c
> +++ b/drivers/nvme/host/lightnvm.c
> @@ -282,7 +282,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,
>  	struct nvme_dev *dev = ns->dev;
>  	struct nvme_nvm_command c = {};
>  	u32 len = queue_max_hw_sectors(q) << 9;
> -	u64 nlb_pr_rq = len / sizeof(u64);
> +	u32 nlb_pr_rq = len / sizeof(u64);
>  	u64 cmd_slba = slba;
>  	void *entries;
>  	int ret = 0;
> @@ -294,7 +294,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,
>  		return -ENOMEM;
> 
>  	while (nlb) {
> -		u32 cmd_nlb = min_t(u32, nlb_pr_rq, nlb);
> +		u32 cmd_nlb = min(nlb_pr_rq, nlb);
> 
>  		c.l2p.slba = cpu_to_le64(cmd_slba);
>  		c.l2p.nlb = cpu_to_le32(cmd_nlb);

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [patch] nvme: lightnvm: clean up a data type
@ 2015-11-03 22:45   ` Busch, Keith
  0 siblings, 0 replies; 8+ messages in thread
From: Busch, Keith @ 2015-11-03 22:45 UTC (permalink / raw)


Looks right to me. Adding Matias for the last word.

On Tue, Nov 3, 2015, Dan Carpentar wrote:
> "nlb_pr_rq" can't be more than u32 because "len" is a u32.  Later we
> truncate it to u32 anyway when we calculate min_t().
> 
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> 
> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
> index 133c839..e0b7b95 100644
> --- a/drivers/nvme/host/lightnvm.c
> +++ b/drivers/nvme/host/lightnvm.c
> @@ -282,7 +282,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,
>  	struct nvme_dev *dev = ns->dev;
>  	struct nvme_nvm_command c = {};
>  	u32 len = queue_max_hw_sectors(q) << 9;
> -	u64 nlb_pr_rq = len / sizeof(u64);
> +	u32 nlb_pr_rq = len / sizeof(u64);
>  	u64 cmd_slba = slba;
>  	void *entries;
>  	int ret = 0;
> @@ -294,7 +294,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,
>  		return -ENOMEM;
> 
>  	while (nlb) {
> -		u32 cmd_nlb = min_t(u32, nlb_pr_rq, nlb);
> +		u32 cmd_nlb = min(nlb_pr_rq, nlb);
> 
>  		c.l2p.slba = cpu_to_le64(cmd_slba);
>  		c.l2p.nlb = cpu_to_le32(cmd_nlb);

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [patch] nvme: lightnvm: clean up a data type
  2015-11-03 22:37 ` Dan Carpenter
@ 2015-11-03 23:02   ` Jens Axboe
  -1 siblings, 0 replies; 8+ messages in thread
From: Jens Axboe @ 2015-11-03 23:02 UTC (permalink / raw)
  To: kernel-janitors

On 11/03/2015 03:37 PM, Dan Carpenter wrote:
> "nlb_pr_rq" can't be more than u32 because "len" is a u32.  Later we
> truncate it to u32 anyway when we calculate min_t().

Thanks Dan, applied.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [patch] nvme: lightnvm: clean up a data type
@ 2015-11-03 23:02   ` Jens Axboe
  0 siblings, 0 replies; 8+ messages in thread
From: Jens Axboe @ 2015-11-03 23:02 UTC (permalink / raw)


On 11/03/2015 03:37 PM, Dan Carpenter wrote:
> "nlb_pr_rq" can't be more than u32 because "len" is a u32.  Later we
> truncate it to u32 anyway when we calculate min_t().

Thanks Dan, applied.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [patch] nvme: lightnvm: clean up a data type
  2015-11-03 22:45   ` Busch, Keith
@ 2015-11-04  2:27     ` Matias Bjorling
  -1 siblings, 0 replies; 8+ messages in thread
From: Matias Bjorling @ 2015-11-04  2:27 UTC (permalink / raw)
  To: kernel-janitors

On 11/03/2015 11:45 PM, Busch, Keith wrote:
> Looks right to me. Adding Matias for the last word.

Thanks Keith and Dan. Looks good to me as well.

> 
> On Tue, Nov 3, 2015, Dan Carpentar wrote:
>> "nlb_pr_rq" can't be more than u32 because "len" is a u32.  Later we
>> truncate it to u32 anyway when we calculate min_t().
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
>> index 133c839..e0b7b95 100644
>> --- a/drivers/nvme/host/lightnvm.c
>> +++ b/drivers/nvme/host/lightnvm.c
>> @@ -282,7 +282,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,
>>  	struct nvme_dev *dev = ns->dev;
>>  	struct nvme_nvm_command c = {};
>>  	u32 len = queue_max_hw_sectors(q) << 9;
>> -	u64 nlb_pr_rq = len / sizeof(u64);
>> +	u32 nlb_pr_rq = len / sizeof(u64);
>>  	u64 cmd_slba = slba;
>>  	void *entries;
>>  	int ret = 0;
>> @@ -294,7 +294,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,
>>  		return -ENOMEM;
>>
>>  	while (nlb) {
>> -		u32 cmd_nlb = min_t(u32, nlb_pr_rq, nlb);
>> +		u32 cmd_nlb = min(nlb_pr_rq, nlb);
>>
>>  		c.l2p.slba = cpu_to_le64(cmd_slba);
>>  		c.l2p.nlb = cpu_to_le32(cmd_nlb);


^ permalink raw reply	[flat|nested] 8+ messages in thread
* [patch] nvme: lightnvm: clean up a data type
@ 2015-11-04  2:27     ` Matias Bjorling
  0 siblings, 0 replies; 8+ messages in thread
From: Matias Bjorling @ 2015-11-04  2:27 UTC (permalink / raw)


On 11/03/2015 11:45 PM, Busch, Keith wrote:
> Looks right to me. Adding Matias for the last word.

Thanks Keith and Dan. Looks good to me as well.

> 
> On Tue, Nov 3, 2015, Dan Carpentar wrote:
>> "nlb_pr_rq" can't be more than u32 because "len" is a u32.  Later we
>> truncate it to u32 anyway when we calculate min_t().
>>
>> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>>
>> diff --git a/drivers/nvme/host/lightnvm.c b/drivers/nvme/host/lightnvm.c
>> index 133c839..e0b7b95 100644
>> --- a/drivers/nvme/host/lightnvm.c
>> +++ b/drivers/nvme/host/lightnvm.c
>> @@ -282,7 +282,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,
>>  	struct nvme_dev *dev = ns->dev;
>>  	struct nvme_nvm_command c = {};
>>  	u32 len = queue_max_hw_sectors(q) << 9;
>> -	u64 nlb_pr_rq = len / sizeof(u64);
>> +	u32 nlb_pr_rq = len / sizeof(u64);
>>  	u64 cmd_slba = slba;
>>  	void *entries;
>>  	int ret = 0;
>> @@ -294,7 +294,7 @@ static int nvme_nvm_get_l2p_tbl(struct request_queue *q, u64 slba, u32 nlb,
>>  		return -ENOMEM;
>>
>>  	while (nlb) {
>> -		u32 cmd_nlb = min_t(u32, nlb_pr_rq, nlb);
>> +		u32 cmd_nlb = min(nlb_pr_rq, nlb);
>>
>>  		c.l2p.slba = cpu_to_le64(cmd_slba);
>>  		c.l2p.nlb = cpu_to_le32(cmd_nlb);

^ permalink raw reply	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-11-04  2:27 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-03 22:37 [patch] nvme: lightnvm: clean up a data type Dan Carpenter
2015-11-03 22:37 ` Dan Carpenter
2015-11-03 22:45 ` Busch, Keith
2015-11-03 22:45   ` Busch, Keith
2015-11-04  2:27   ` Matias Bjorling
2015-11-04  2:27     ` Matias Bjorling
2015-11-03 23:02 ` Jens Axboe
2015-11-03 23:02   ` Jens Axboe

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.