Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288

From: Zain <zain.wang@rock-chips.com>
To: Caesar Wang <caesar.upstream@gmail.com>, mark.rutland@arm.com
Cc: zhengsq@rock-chips.com, hl@rock-chips.com,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	mturquette@baylibre.com, heiko@sntech.de, pawel.moll@arm.com,
	ijc+devicetree@hellion.org.uk, robh+dt@kernel.org,
	galak@codeaurora.org, linux@arm.linux.org.uk,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-rockchip@lists.infradead.org, eddie.cai@rock-chips.com,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288
Date: Fri, 6 Nov 2015 17:50:15 +0800	[thread overview]
Message-ID: <563C77D7.4010701@rock-chips.com> (raw)
In-Reply-To: <563C09D3.1050508@gmail.com>

Hi:

On 2015年11月06日 10:00, Caesar Wang wrote:
> the subject should be add the node/info for crypto...
ok! done!
>
> 在 2015年11月06日 09:17, Zain Wang 写道:
>> Add Crypto drivers for rk3288 including crypto controller and dma clk.
>>
>> Signed-off-by: Zain Wang <zain.wang@rock-chips.com>
>> ---
>>
>> Changed in v2:
>> - None
>>
>> Changed in v1:
>> - remove the _crypto suffix
>> - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288"
>>
>>   arch/arm/boot/dts/rk3288.dtsi | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/rk3288.dtsi
>> b/arch/arm/boot/dts/rk3288.dtsi
>> index 6a79c9c..7b7914e 100644
>> --- a/arch/arm/boot/dts/rk3288.dtsi
>> +++ b/arch/arm/boot/dts/rk3288.dtsi
>> @@ -170,6 +170,21 @@
>>           };
>>       };
>>   +    crypto: cypto-controller@ff8a0000 {
>> +        compatible = "rockchip,rk3288-crypto";
>> +        reg = <0xff8a0000 0x4000>;
>> +        interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>;
>> +        clocks = <&cru ACLK_CRYPTO>,
>> +             <&cru HCLK_CRYPTO>,
>> +             <&cru SCLK_CRYPTO>,
>> +             <&cru ACLK_DMAC1>;
>> +        clock-names = "aclk",
>> +                  "hclk",
>> +                  "sclk",
>> +                  "apb_pclk";
>
> I guess  you can do this:
>
> clocks = <&cru ACLK_CRYPTO>, <&cru HCLK_CRYPTO>,  <&cru SCLK_CRYPTO>, 
> <&cru ACLK_DMAC1>;
>
> clock-names = "aclk", "hclk",  "sclk", "apb_pclk";
ok! done!
>
>
>> +        status = "okay";
>> +    };
>> +
>>       reserved-memory {
>>           #address-cells = <1>;
>>           #size-cells = <1>;
>
>