From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org> To: Zain Wang <zain.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Cc: mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org, hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, eddie.cai-TNX95d0MmH7DzftRWevZcw@public.gmane.org, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org Subject: Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288 Date: Fri, 06 Nov 2015 11:12:55 +0100 [thread overview] Message-ID: <4509145.eZ7GP0e6gb@phil> (raw) In-Reply-To: <1446772644-2352-4-git-send-email-zain.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Am Freitag, 6. November 2015, 09:17:23 schrieb Zain Wang: > Add Crypto drivers for rk3288 including crypto controller and dma clk. > > Signed-off-by: Zain Wang <zain.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> > --- > > Changed in v2: > - None > > Changed in v1: > - remove the _crypto suffix > - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288" > > arch/arm/boot/dts/rk3288.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > index 6a79c9c..7b7914e 100644 > --- a/arch/arm/boot/dts/rk3288.dtsi > +++ b/arch/arm/boot/dts/rk3288.dtsi > @@ -170,6 +170,21 @@ > }; > }; > > + crypto: cypto-controller@ff8a0000 { > + compatible = "rockchip,rk3288-crypto"; > + reg = <0xff8a0000 0x4000>; > + interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cru ACLK_CRYPTO>, > + <&cru HCLK_CRYPTO>, > + <&cru SCLK_CRYPTO>, > + <&cru ACLK_DMAC1>; > + clock-names = "aclk", > + "hclk", > + "sclk", > + "apb_pclk"; > + status = "okay"; > + }; > + please move that whole node to the right location. Entries are sorted by register address (the ff8a0000 should then of course be below i2s@ff890000 and above vop@ff930000) > reserved-memory { > #address-cells = <1>; > #size-cells = <1>; >
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de> To: Zain Wang <zain.wang@rock-chips.com> Cc: zhengsq@rock-chips.com, hl@rock-chips.com, herbert@gondor.apana.org.au, davem@davemloft.net, mturquette@baylibre.com, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, robh+dt@kernel.org, galak@codeaurora.org, linux@arm.linux.org.uk, mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, eddie.cai@rock-chips.com Subject: Re: [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288 Date: Fri, 06 Nov 2015 11:12:55 +0100 [thread overview] Message-ID: <4509145.eZ7GP0e6gb@phil> (raw) In-Reply-To: <1446772644-2352-4-git-send-email-zain.wang@rock-chips.com> Am Freitag, 6. November 2015, 09:17:23 schrieb Zain Wang: > Add Crypto drivers for rk3288 including crypto controller and dma clk. > > Signed-off-by: Zain Wang <zain.wang@rock-chips.com> > --- > > Changed in v2: > - None > > Changed in v1: > - remove the _crypto suffix > - use "rockchip,rk3288-crypto" instead of "rockchip,rk3288" > > arch/arm/boot/dts/rk3288.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > index 6a79c9c..7b7914e 100644 > --- a/arch/arm/boot/dts/rk3288.dtsi > +++ b/arch/arm/boot/dts/rk3288.dtsi > @@ -170,6 +170,21 @@ > }; > }; > > + crypto: cypto-controller@ff8a0000 { > + compatible = "rockchip,rk3288-crypto"; > + reg = <0xff8a0000 0x4000>; > + interrupts = <GIC_SPI 48 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cru ACLK_CRYPTO>, > + <&cru HCLK_CRYPTO>, > + <&cru SCLK_CRYPTO>, > + <&cru ACLK_DMAC1>; > + clock-names = "aclk", > + "hclk", > + "sclk", > + "apb_pclk"; > + status = "okay"; > + }; > + please move that whole node to the right location. Entries are sorted by register address (the ff8a0000 should then of course be below i2s@ff890000 and above vop@ff930000) > reserved-memory { > #address-cells = <1>; > #size-cells = <1>; >
next prev parent reply other threads:[~2015-11-06 10:12 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-06 1:17 [PATCH v2 0/4] Crypto: add crypto accelerator support for rk3288 Zain Wang 2015-11-06 1:17 ` [PATCH v2 1/4] Crypto: Crypto driver support aes/des/des3 " Zain Wang 2015-11-06 1:54 ` Caesar Wang 2015-11-06 9:51 ` Zain 2015-11-07 4:40 ` Sandy Harris 2015-11-09 0:53 ` Zain [not found] ` <1446772644-2352-2-git-send-email-zain.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> 2015-11-07 23:19 ` Heiko Stuebner 2015-11-07 23:19 ` Heiko Stuebner 2015-11-09 3:46 ` Zain [not found] ` <1446772644-2352-1-git-send-email-zain.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> 2015-11-06 1:17 ` [PATCH v2 2/4] clk: rockchip: set an id for crypto clk Zain Wang 2015-11-06 1:17 ` Zain Wang 2015-11-06 1:17 ` [PATCH v2 3/4] ARM: dts: rockchip: Add Crypto drivers for rk3288 Zain Wang 2015-11-06 1:17 ` Zain Wang 2015-11-06 2:00 ` Caesar Wang 2015-11-06 9:50 ` Zain [not found] ` <1446772644-2352-4-git-send-email-zain.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org> 2015-11-06 10:12 ` Heiko Stuebner [this message] 2015-11-06 10:12 ` Heiko Stuebner 2015-11-06 10:27 ` Zain 2015-11-06 10:27 ` Zain 2015-11-06 1:17 ` [PATCH v2 4/4] crypto: rockchip/crypto - add DT bindings documentation Zain Wang 2015-11-06 2:27 ` Rob Herring 2015-11-06 9:00 ` Heiko Stuebner 2015-11-06 9:36 ` Zain 2015-11-06 9:36 ` Zain 2015-11-06 1:36 ` [PATCH v2 0/4] Crypto: add crypto accelerator support for rk3288 Caesar Wang [not found] ` <563C0430.9000607-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2015-11-06 9:53 ` Zain 2015-11-06 9:53 ` Zain
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4509145.eZ7GP0e6gb@phil \ --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \ --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \ --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=eddie.cai-TNX95d0MmH7DzftRWevZcw@public.gmane.org \ --cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \ --cc=herbert-lOAM2aK0SrRLBo1qDEOMRrpzq4S04n8Q@public.gmane.org \ --cc=hl-TNX95d0MmH7DzftRWevZcw@public.gmane.org \ --cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \ --cc=linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \ --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \ --cc=mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org \ --cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ --cc=zain.wang-TNX95d0MmH7DzftRWevZcw@public.gmane.org \ --cc=zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.