* [PATCH 2/4] ARM: dts: kirkwood: add Linksys EA3500
[not found] <1446675888-24495-1-git-send-email-luka.perkov@sartura.hr>
@ 2015-11-04 22:25 ` Luka Perkov
2015-11-04 22:25 ` Luka Perkov
2015-11-04 22:25 ` Luka Perkov
2 siblings, 0 replies; 20+ messages in thread
From: Luka Perkov @ 2015-11-04 22:25 UTC (permalink / raw)
To: linux-arm-kernel, devicetree; +Cc: gregory.clement, andrew, Luka Perkov, jason
Based on dts files from OpenWrt.
Signed-off-by: Luka Perkov <luka.perkov@sartura.hr>
---
.../devicetree/bindings/arm/marvell,kirkwood.txt | 1 +
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/kirkwood-ea3500.dts | 149 +++++++++++++++++++++
3 files changed, 151 insertions(+)
create mode 100644 arch/arm/boot/dts/kirkwood-ea3500.dts
diff --git a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
index 7a99d4a..ed381a3 100644
--- a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
+++ b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
@@ -50,6 +50,7 @@ board. Currently known boards are:
"lacie,netspace_mini_v2"
"lacie,netspace_v2"
"linksys,ea4500"
+"linksys,ea3500"
"marvell,db-88f6281-bp"
"marvell,db-88f6282-bp"
"marvell,mv88f6281gtw-ge"
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index a16c04b..ebe5b73 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -168,6 +168,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \
kirkwood-ds411.dtb \
kirkwood-ds411j.dtb \
kirkwood-ds411slim.dtb \
+ kirkwood-ea3500.dtb \
kirkwood-ea4500.dtb \
kirkwood-goflexnet.dtb \
kirkwood-guruplug-server-plus.dtb \
diff --git a/arch/arm/boot/dts/kirkwood-ea3500.dts b/arch/arm/boot/dts/kirkwood-ea3500.dts
new file mode 100644
index 0000000..3a064f6
--- /dev/null
+++ b/arch/arm/boot/dts/kirkwood-ea3500.dts
@@ -0,0 +1,149 @@
+/*
+ * kirkwood-ea3500.dts - Device Tree file for Linksys EA3500
+ *
+ * (c) 2013 Jonas Gorski <jogo@openwrt.org>
+ * (c) 2013 Deutsche Telekom Innovation Laboratories
+ * (c) 2014 Luka Perkov <luka.perkov@sartura.hr>
+ * (c) 2014 Dan Walters <dan@walters.io>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+/dts-v1/;
+
+#include "kirkwood.dtsi"
+#include "kirkwood-6282.dtsi"
+
+/ {
+ model = "Linksys EA3500";
+ compatible = "linksys,ea3500", "marvell,kirkwood-88f6282", "marvell,kirkwood";
+
+ memory {
+ device_type = "memory";
+ reg = <0x00000000 0x4000000>;
+ };
+
+ chosen {
+ bootargs = "console=ttyS0,115200n8 earlyprintk";
+ };
+
+ mbus {
+ pcie-controller {
+ status = "okay";
+
+ pcie@1,0 {
+ status = "okay";
+ };
+
+ pcie@2,0 {
+ status = "okay";
+ };
+ };
+ };
+
+ ocp@f1000000 {
+ pinctrl: pin-controller@10000 {
+ pmx_led_green_power: pmx-led-green-power {
+ marvell,pins = "mpp7";
+ marvell,function = "gpo";
+ };
+ pmx_btn_wps: pmx-btn-wps {
+ marvell,pins = "mpp47";
+ marvell,function = "gpio";
+ };
+ pmx_btn_reset: pmx-btn-reset {
+ marvell,pins = "mpp48";
+ marvell,function = "gpio";
+ };
+ };
+
+ rtc@10300 {
+ status = "disabled";
+ };
+
+ serial@12000 {
+ status = "okay";
+ };
+
+ };
+
+ gpio_keys {
+ compatible = "gpio-keys";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pinctrl-0 = < &pmx_btn_wps &pmx_btn_reset >;
+ pinctrl-names = "default";
+
+ button@15 {
+ label = "WPS Button";
+ linux,code = <KEY_WPS_BUTTON>;
+ gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
+ };
+
+ button@16 {
+ label = "Reset Button";
+ linux,code = <KEY_RESTART>;
+ gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
+ };
+ };
+
+ gpio-leds {
+ compatible = "gpio-leds";
+ pinctrl-0 = < &pmx_led_green_power >;
+ pinctrl-names = "default";
+
+ green-power {
+ label = "ea3500:green:power";
+ gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>;
+ };
+ };
+};
+
+&nand {
+ status = "okay";
+ pinctrl-0 = <&pmx_nand>;
+ pinctrl-names = "default";
+
+ partition@0 {
+ label = "u-boot";
+ reg = <0x0000000 0x80000>;
+ read-only;
+ };
+
+ partition@80000 {
+ label = "u-boot environment";
+ reg = <0x80000 0x20000>;
+ };
+
+ partition@200000 {
+ label = "kernel";
+ reg = <0x200000 0x200000>;
+ };
+
+ partition@400000 {
+ label = "root";
+ reg = <0x400000 0x1200000>;
+ };
+};
+
+&mdio {
+ status = "okay";
+};
+
+ð0 {
+ status = "okay";
+ ethernet0-port@0 {
+ speed = <1000>;
+ duplex = <1>;
+ };
+};
+
+ð1 {
+ status = "okay";
+ ethernet1-port@0 {
+ speed = <1000>;
+ duplex = <1>;
+ };
+};
--
2.6.2
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 2/4] ARM: dts: kirkwood: add Linksys EA3500
@ 2015-11-04 22:25 ` Luka Perkov
0 siblings, 0 replies; 20+ messages in thread
From: Luka Perkov @ 2015-11-04 22:25 UTC (permalink / raw)
To: linux-arm-kernel
Based on dts files from OpenWrt.
Signed-off-by: Luka Perkov <luka.perkov@sartura.hr>
---
.../devicetree/bindings/arm/marvell,kirkwood.txt | 1 +
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/kirkwood-ea3500.dts | 149 +++++++++++++++++++++
3 files changed, 151 insertions(+)
create mode 100644 arch/arm/boot/dts/kirkwood-ea3500.dts
diff --git a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
index 7a99d4a..ed381a3 100644
--- a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
+++ b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
@@ -50,6 +50,7 @@ board. Currently known boards are:
"lacie,netspace_mini_v2"
"lacie,netspace_v2"
"linksys,ea4500"
+"linksys,ea3500"
"marvell,db-88f6281-bp"
"marvell,db-88f6282-bp"
"marvell,mv88f6281gtw-ge"
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index a16c04b..ebe5b73 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -168,6 +168,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \
kirkwood-ds411.dtb \
kirkwood-ds411j.dtb \
kirkwood-ds411slim.dtb \
+ kirkwood-ea3500.dtb \
kirkwood-ea4500.dtb \
kirkwood-goflexnet.dtb \
kirkwood-guruplug-server-plus.dtb \
diff --git a/arch/arm/boot/dts/kirkwood-ea3500.dts b/arch/arm/boot/dts/kirkwood-ea3500.dts
new file mode 100644
index 0000000..3a064f6
--- /dev/null
+++ b/arch/arm/boot/dts/kirkwood-ea3500.dts
@@ -0,0 +1,149 @@
+/*
+ * kirkwood-ea3500.dts - Device Tree file for Linksys EA3500
+ *
+ * (c) 2013 Jonas Gorski <jogo@openwrt.org>
+ * (c) 2013 Deutsche Telekom Innovation Laboratories
+ * (c) 2014 Luka Perkov <luka.perkov@sartura.hr>
+ * (c) 2014 Dan Walters <dan@walters.io>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2. This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+/dts-v1/;
+
+#include "kirkwood.dtsi"
+#include "kirkwood-6282.dtsi"
+
+/ {
+ model = "Linksys EA3500";
+ compatible = "linksys,ea3500", "marvell,kirkwood-88f6282", "marvell,kirkwood";
+
+ memory {
+ device_type = "memory";
+ reg = <0x00000000 0x4000000>;
+ };
+
+ chosen {
+ bootargs = "console=ttyS0,115200n8 earlyprintk";
+ };
+
+ mbus {
+ pcie-controller {
+ status = "okay";
+
+ pcie at 1,0 {
+ status = "okay";
+ };
+
+ pcie at 2,0 {
+ status = "okay";
+ };
+ };
+ };
+
+ ocp at f1000000 {
+ pinctrl: pin-controller at 10000 {
+ pmx_led_green_power: pmx-led-green-power {
+ marvell,pins = "mpp7";
+ marvell,function = "gpo";
+ };
+ pmx_btn_wps: pmx-btn-wps {
+ marvell,pins = "mpp47";
+ marvell,function = "gpio";
+ };
+ pmx_btn_reset: pmx-btn-reset {
+ marvell,pins = "mpp48";
+ marvell,function = "gpio";
+ };
+ };
+
+ rtc at 10300 {
+ status = "disabled";
+ };
+
+ serial at 12000 {
+ status = "okay";
+ };
+
+ };
+
+ gpio_keys {
+ compatible = "gpio-keys";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pinctrl-0 = < &pmx_btn_wps &pmx_btn_reset >;
+ pinctrl-names = "default";
+
+ button at 15 {
+ label = "WPS Button";
+ linux,code = <KEY_WPS_BUTTON>;
+ gpios = <&gpio1 15 GPIO_ACTIVE_LOW>;
+ };
+
+ button at 16 {
+ label = "Reset Button";
+ linux,code = <KEY_RESTART>;
+ gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
+ };
+ };
+
+ gpio-leds {
+ compatible = "gpio-leds";
+ pinctrl-0 = < &pmx_led_green_power >;
+ pinctrl-names = "default";
+
+ green-power {
+ label = "ea3500:green:power";
+ gpios = <&gpio0 7 GPIO_ACTIVE_HIGH>;
+ };
+ };
+};
+
+&nand {
+ status = "okay";
+ pinctrl-0 = <&pmx_nand>;
+ pinctrl-names = "default";
+
+ partition at 0 {
+ label = "u-boot";
+ reg = <0x0000000 0x80000>;
+ read-only;
+ };
+
+ partition at 80000 {
+ label = "u-boot environment";
+ reg = <0x80000 0x20000>;
+ };
+
+ partition at 200000 {
+ label = "kernel";
+ reg = <0x200000 0x200000>;
+ };
+
+ partition at 400000 {
+ label = "root";
+ reg = <0x400000 0x1200000>;
+ };
+};
+
+&mdio {
+ status = "okay";
+};
+
+ð0 {
+ status = "okay";
+ ethernet0-port at 0 {
+ speed = <1000>;
+ duplex = <1>;
+ };
+};
+
+ð1 {
+ status = "okay";
+ ethernet1-port at 0 {
+ speed = <1000>;
+ duplex = <1>;
+ };
+};
--
2.6.2
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 3/4] ARM: dts: kirkwood: add Seagate GoFlex Home
[not found] <1446675888-24495-1-git-send-email-luka.perkov@sartura.hr>
@ 2015-11-04 22:25 ` Luka Perkov
2015-11-04 22:25 ` Luka Perkov
2015-11-04 22:25 ` Luka Perkov
2 siblings, 0 replies; 20+ messages in thread
From: Luka Perkov @ 2015-11-04 22:25 UTC (permalink / raw)
To: linux-arm-kernel, devicetree; +Cc: gregory.clement, andrew, Luka Perkov, jason
Based on dts files from OpenWrt.
Signed-off-by: Luka Perkov <luka.perkov@sartura.hr>
---
.../devicetree/bindings/arm/marvell,kirkwood.txt | 1 +
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/kirkwood-goflexhome.dts | 127 +++++++++++++++++++++
3 files changed, 129 insertions(+)
create mode 100644 arch/arm/boot/dts/kirkwood-goflexhome.dts
diff --git a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
index ed381a3..37bd190 100644
--- a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
+++ b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
@@ -72,6 +72,7 @@ board. Currently known boards are:
"raidsonic,ib-nas6220-b"
"raidsonic,ib-nas62x0"
"seagate,dockstar"
+"seagate,goflexhome"
"seagate,goflexnet"
"synology,ds109"
"synology,ds110jv10"
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index ebe5b73..1d6fb0d 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -170,6 +170,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \
kirkwood-ds411slim.dtb \
kirkwood-ea3500.dtb \
kirkwood-ea4500.dtb \
+ kirkwood-goflexhome.dtb \
kirkwood-goflexnet.dtb \
kirkwood-guruplug-server-plus.dtb \
kirkwood-ib62x0.dtb \
diff --git a/arch/arm/boot/dts/kirkwood-goflexhome.dts b/arch/arm/boot/dts/kirkwood-goflexhome.dts
new file mode 100644
index 0000000..5f933d4
--- /dev/null
+++ b/arch/arm/boot/dts/kirkwood-goflexhome.dts
@@ -0,0 +1,127 @@
+/dts-v1/;
+
+#include "kirkwood.dtsi"
+#include "kirkwood-6281.dtsi"
+
+/ {
+ model = "Seagate GoFlex Home";
+ compatible = "seagate,goflexhome", "marvell,kirkwood-88f6281", "marvell,kirkwood";
+
+ memory {
+ device_type = "memory";
+ reg = <0x00000000 0x8000000>;
+ };
+
+ chosen {
+ bootargs = "console=ttyS0,115200n8 earlyprintk root=/dev/sda1 rootdelay=10";
+ stdout-path = &uart0;
+ };
+
+ ocp@f1000000 {
+ pinctrl: pin-controller@10000 {
+ pmx_usb_power_enable: pmx-usb-power-enable {
+ marvell,pins = "mpp29";
+ marvell,function = "gpio";
+ };
+ pmx_led_white: pmx-led-white {
+ marvell,pins = "mpp40";
+ marvell,function = "gpio";
+ };
+ pmx_led_green: pmx-led_green {
+ marvell,pins = "mpp46";
+ marvell,function = "gpio";
+ };
+ pmx_led_orange: pmx-led-orange {
+ marvell,pins = "mpp47";
+ marvell,function = "gpio";
+ };
+ };
+ serial@12000 {
+ status = "ok";
+ };
+
+ sata@80000 {
+ status = "okay";
+ nr-ports = <2>;
+ };
+
+ };
+ gpio-leds {
+ compatible = "gpio-leds";
+
+ health {
+ label = "status:green:health";
+ gpios = <&gpio1 14 1>;
+ linux,default-trigger = "default-on";
+ };
+ fault {
+ label = "status:orange:fault";
+ gpios = <&gpio1 15 1>;
+ };
+ misc {
+ label = "status:white:misc";
+ gpios = <&gpio1 8 1>;
+ linux,default-trigger = "ide-disk";
+ };
+ };
+ regulators {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pinctrl-0 = <&pmx_usb_power_enable>;
+ pinctrl-names = "default";
+
+ usb_power: regulator@1 {
+ compatible = "regulator-fixed";
+ reg = <1>;
+ regulator-name = "USB Power";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ enable-active-high;
+ regulator-always-on;
+ regulator-boot-on;
+ gpio = <&gpio0 29 GPIO_ACTIVE_HIGH>;
+ };
+ };
+};
+
+&nand {
+ chip-delay = <40>;
+ status = "okay";
+
+ partition@0 {
+ label = "u-boot";
+ reg = <0x0000000 0x100000>;
+ read-only;
+ };
+
+ partition@100000 {
+ label = "uImage";
+ reg = <0x0100000 0x400000>;
+ };
+
+ partition@500000 {
+ label = "pogoplug";
+ reg = <0x0500000 0x2000000>;
+ };
+
+ partition@2500000 {
+ label = "root";
+ reg = <0x02500000 0xd800000>;
+ };
+};
+
+&mdio {
+ status = "okay";
+
+ ethphy0: ethernet-phy@0 {
+ reg = <0>;
+ };
+};
+
+ð0 {
+ status = "okay";
+ ethernet0-port@0 {
+ phy-handle = <ðphy0>;
+ };
+};
--
2.6.2
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 3/4] ARM: dts: kirkwood: add Seagate GoFlex Home
@ 2015-11-04 22:25 ` Luka Perkov
0 siblings, 0 replies; 20+ messages in thread
From: Luka Perkov @ 2015-11-04 22:25 UTC (permalink / raw)
To: linux-arm-kernel
Based on dts files from OpenWrt.
Signed-off-by: Luka Perkov <luka.perkov@sartura.hr>
---
.../devicetree/bindings/arm/marvell,kirkwood.txt | 1 +
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/kirkwood-goflexhome.dts | 127 +++++++++++++++++++++
3 files changed, 129 insertions(+)
create mode 100644 arch/arm/boot/dts/kirkwood-goflexhome.dts
diff --git a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
index ed381a3..37bd190 100644
--- a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
+++ b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
@@ -72,6 +72,7 @@ board. Currently known boards are:
"raidsonic,ib-nas6220-b"
"raidsonic,ib-nas62x0"
"seagate,dockstar"
+"seagate,goflexhome"
"seagate,goflexnet"
"synology,ds109"
"synology,ds110jv10"
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index ebe5b73..1d6fb0d 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -170,6 +170,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \
kirkwood-ds411slim.dtb \
kirkwood-ea3500.dtb \
kirkwood-ea4500.dtb \
+ kirkwood-goflexhome.dtb \
kirkwood-goflexnet.dtb \
kirkwood-guruplug-server-plus.dtb \
kirkwood-ib62x0.dtb \
diff --git a/arch/arm/boot/dts/kirkwood-goflexhome.dts b/arch/arm/boot/dts/kirkwood-goflexhome.dts
new file mode 100644
index 0000000..5f933d4
--- /dev/null
+++ b/arch/arm/boot/dts/kirkwood-goflexhome.dts
@@ -0,0 +1,127 @@
+/dts-v1/;
+
+#include "kirkwood.dtsi"
+#include "kirkwood-6281.dtsi"
+
+/ {
+ model = "Seagate GoFlex Home";
+ compatible = "seagate,goflexhome", "marvell,kirkwood-88f6281", "marvell,kirkwood";
+
+ memory {
+ device_type = "memory";
+ reg = <0x00000000 0x8000000>;
+ };
+
+ chosen {
+ bootargs = "console=ttyS0,115200n8 earlyprintk root=/dev/sda1 rootdelay=10";
+ stdout-path = &uart0;
+ };
+
+ ocp at f1000000 {
+ pinctrl: pin-controller at 10000 {
+ pmx_usb_power_enable: pmx-usb-power-enable {
+ marvell,pins = "mpp29";
+ marvell,function = "gpio";
+ };
+ pmx_led_white: pmx-led-white {
+ marvell,pins = "mpp40";
+ marvell,function = "gpio";
+ };
+ pmx_led_green: pmx-led_green {
+ marvell,pins = "mpp46";
+ marvell,function = "gpio";
+ };
+ pmx_led_orange: pmx-led-orange {
+ marvell,pins = "mpp47";
+ marvell,function = "gpio";
+ };
+ };
+ serial at 12000 {
+ status = "ok";
+ };
+
+ sata at 80000 {
+ status = "okay";
+ nr-ports = <2>;
+ };
+
+ };
+ gpio-leds {
+ compatible = "gpio-leds";
+
+ health {
+ label = "status:green:health";
+ gpios = <&gpio1 14 1>;
+ linux,default-trigger = "default-on";
+ };
+ fault {
+ label = "status:orange:fault";
+ gpios = <&gpio1 15 1>;
+ };
+ misc {
+ label = "status:white:misc";
+ gpios = <&gpio1 8 1>;
+ linux,default-trigger = "ide-disk";
+ };
+ };
+ regulators {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pinctrl-0 = <&pmx_usb_power_enable>;
+ pinctrl-names = "default";
+
+ usb_power: regulator at 1 {
+ compatible = "regulator-fixed";
+ reg = <1>;
+ regulator-name = "USB Power";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ enable-active-high;
+ regulator-always-on;
+ regulator-boot-on;
+ gpio = <&gpio0 29 GPIO_ACTIVE_HIGH>;
+ };
+ };
+};
+
+&nand {
+ chip-delay = <40>;
+ status = "okay";
+
+ partition at 0 {
+ label = "u-boot";
+ reg = <0x0000000 0x100000>;
+ read-only;
+ };
+
+ partition at 100000 {
+ label = "uImage";
+ reg = <0x0100000 0x400000>;
+ };
+
+ partition at 500000 {
+ label = "pogoplug";
+ reg = <0x0500000 0x2000000>;
+ };
+
+ partition at 2500000 {
+ label = "root";
+ reg = <0x02500000 0xd800000>;
+ };
+};
+
+&mdio {
+ status = "okay";
+
+ ethphy0: ethernet-phy at 0 {
+ reg = <0>;
+ };
+};
+
+ð0 {
+ status = "okay";
+ ethernet0-port at 0 {
+ phy-handle = <ðphy0>;
+ };
+};
--
2.6.2
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 4/4] ARM: dts: kirkwood: add ZyXEL NSA310s
[not found] <1446675888-24495-1-git-send-email-luka.perkov@sartura.hr>
@ 2015-11-04 22:25 ` Luka Perkov
2015-11-04 22:25 ` Luka Perkov
2015-11-04 22:25 ` Luka Perkov
2 siblings, 0 replies; 20+ messages in thread
From: Luka Perkov @ 2015-11-04 22:25 UTC (permalink / raw)
To: linux-arm-kernel, devicetree
Cc: gregory.clement, andrew, Luka Perkov, jason, Tony Dinh
Based on dts files from OpenWrt.
Signed-off-by: Luka Perkov <luka.perkov@sartura.hr>
Signed-off-by: Tony Dinh <mibodhi@gmail.com>
---
.../devicetree/bindings/arm/marvell,kirkwood.txt | 1 +
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/kirkwood-nsa310s.dts | 282 +++++++++++++++++++++
3 files changed, 284 insertions(+)
create mode 100644 arch/arm/boot/dts/kirkwood-nsa310s.dts
diff --git a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
index 37bd190..8a1a7f7 100644
--- a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
+++ b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
@@ -101,3 +101,4 @@ board. Currently known boards are:
"usi,topkick-1281P2"
"zyxel,nsa310"
"zyxel,nsa310a"
+"zyxel,nsa310s"
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 1d6fb0d..b2ea55f 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -196,6 +196,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \
kirkwood-ns2mini.dtb \
kirkwood-nsa310.dtb \
kirkwood-nsa310a.dtb \
+ kirkwood-nsa310s.dtb \
kirkwood-openblocks_a6.dtb \
kirkwood-openblocks_a7.dtb \
kirkwood-openrd-base.dtb \
diff --git a/arch/arm/boot/dts/kirkwood-nsa310s.dts b/arch/arm/boot/dts/kirkwood-nsa310s.dts
new file mode 100644
index 0000000..afc8ecf
--- /dev/null
+++ b/arch/arm/boot/dts/kirkwood-nsa310s.dts
@@ -0,0 +1,282 @@
+/dts-v1/;
+
+#include "kirkwood.dtsi"
+#include "kirkwood-6281.dtsi"
+
+/ {
+ model = "ZyXEL NSA310S";
+ compatible = "zyxel,nsa310s", "marvell,kirkwood-88f6702", "marvell,kirkwood";
+
+ memory {
+ device_type = "memory";
+ reg = <0x00000000 0x10000000>;
+ };
+
+ chosen {
+ bootargs = "console=ttyS0,115200n8 earlyprintk";
+ stdout-path = &uart0;
+ };
+
+ mbus {
+ pcie-controller {
+ status = "okay";
+
+ pcie@1,0 {
+ status = "okay";
+ };
+ };
+ };
+
+ ocp@f1000000 {
+ pinctrl: pin-controller@10000 {
+ pinctrl-names = "default";
+
+ pmx_sata0: pmx-sata0 {
+ marvell,pins;
+ marvell,function = "sata0";
+ };
+ pmx_sata1: pmx-sata1 {
+ marvell,pins;
+ marvell,function = "sata1";
+ };
+ pmx_usb_power: pmx-usb-power {
+ marvell,pins = "mpp21";
+ marvell,function = "gpio";
+ };
+ pmx_pwr_off: pmx-pwr-off {
+ marvell,pins = "mpp27";
+ marvell,function = "gpio";
+ };
+ pmx_btn_reset: pmx-btn-reset {
+ marvell,pins = "mpp24";
+ marvell,function = "gpio";
+ };
+ pmx_btn_copy: pmx-btn-copy {
+ marvell,pins = "mpp25";
+ marvell,function = "gpio";
+ };
+ pmx_btn_power: pmx-btn-power {
+ marvell,pins = "mpp26";
+ marvell,function = "gpio";
+ };
+ pmx_led_hdd2_green: pmx-led-hdd2-green {
+ marvell,pins = "mpp34";
+ marvell,function = "gpio";
+ };
+ pmx_led_hdd2_red: pmx-led-hdd2-red {
+ marvell,pins = "mpp12";
+ marvell,function = "gpio";
+ };
+ pmx_led_usb_green: pmx-led-usb-green {
+ marvell,pins = "mpp15";
+ marvell,function = "gpio";
+ };
+ pmx_led_copy_green: pmx-led-copy-green {
+ marvell,pins = "mpp22";
+ marvell,function = "gpio";
+ };
+ pmx_led_copy_red: pmx-led-copy-red {
+ marvell,pins = "mpp23";
+ marvell,function = "gpio";
+ };
+ pmx_led_sys_green: pmx-led-sys-green {
+ marvell,pins = "mpp28";
+ marvell,function = "gpio";
+ };
+ pmx_led_sys_orange: pmx-led-sys-orange {
+ marvell,pins = "mpp29";
+ marvell,function = "gpio";
+ };
+ pmx_led_hdd1_green: pmx-led-hdd1-green {
+ marvell,pins = "mpp16";
+ marvell,function = "gpio";
+ };
+ pmx_led_hdd1_red: pmx-led-hdd1-red {
+ marvell,pins = "mpp13";
+ marvell,function = "gpio";
+ };
+ pmx_pwr_sata1: pmx-pwr-sata1 {
+ marvell,pins = "mpp33";
+ marvell,function = "gpio";
+ };
+ };
+
+ serial@12000 {
+ status = "okay";
+ };
+
+ sata@80000 {
+ status = "okay";
+ nr-ports = <2>;
+ };
+
+ rtc@10300 {
+ status = "disabled";
+ };
+
+ i2c@11000 {
+ status = "okay";
+ };
+ };
+
+ regulators {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pmx_usb_power &pmx_pwr_sata1>;
+
+ usb0_power: regulator@1 {
+ compatible = "regulator-fixed";
+ reg = <1>;
+ regulator-name = "USB Power";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ regulator-boot-on;
+ enable-active-high;
+ gpio = <&gpio0 21 GPIO_ACTIVE_HIGH>;
+ };
+
+ sata1_power: regulator@2 {
+ compatible = "regulator-fixed";
+ reg = <2>;
+ regulator-name = "SATA1 Power";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ regulator-boot-on;
+ enable-active-high;
+ gpio = <&gpio1 1 GPIO_ACTIVE_HIGH>;
+ };
+ };
+
+
+ gpio_keys {
+ compatible = "gpio-keys";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pinctrl-0 = <&pmx_btn_reset &pmx_btn_copy &pmx_btn_power>;
+ pinctrl-names = "default";
+
+ button@1 {
+ label = "Power Button";
+ linux,code = <KEY_POWER>;
+ gpios = <&gpio0 26 GPIO_ACTIVE_HIGH>;
+ };
+ button@2 {
+ label = "Copy Button";
+ linux,code = <KEY_COPY>;
+ gpios = <&gpio0 25 GPIO_ACTIVE_LOW>;
+ };
+ button@3 {
+ label = "Reset Button";
+ linux,code = <KEY_RESTART>;
+ gpios = <&gpio0 24 GPIO_ACTIVE_LOW>;
+ };
+ };
+
+ gpio-leds {
+ compatible = "gpio-leds";
+ pinctrl-0 = <&pmx_led_hdd2_green &pmx_led_hdd2_red
+ &pmx_led_usb_green
+ &pmx_led_sys_green &pmx_led_sys_orange
+ &pmx_led_copy_green &pmx_led_copy_red
+ &pmx_led_hdd1_green &pmx_led_hdd1_red>;
+ pinctrl-names = "default";
+
+ green-sys {
+ label = "nsa310s:green:sys";
+ gpios = <&gpio0 28 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "timer";
+ };
+ orange-sys {
+ label = "nsa310s:orange:sys";
+ gpios = <&gpio0 29 GPIO_ACTIVE_HIGH>;
+ };
+ green-hdd1 {
+ label = "nsa310s:green:hdd1";
+ gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
+ };
+ red-hdd1 {
+ label = "nsa310s:red:hdd1";
+ gpios = <&gpio0 13 GPIO_ACTIVE_HIGH>;
+ };
+ green-hdd2 {
+ label = "nsa310s:green:hdd2";
+ gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
+ };
+ red-hdd2 {
+ label = "nsa310s:red:hdd2";
+ gpios = <&gpio0 12 GPIO_ACTIVE_HIGH>;
+ };
+ green-usb {
+ label = "nsa310s:green:usb";
+ gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>;
+ };
+ green-copy {
+ label = "nsa310s:green:copy";
+ gpios = <&gpio0 22 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "ide-disk";
+ };
+ red-copy {
+ label = "nsa310s:red:copy";
+ gpios = <&gpio0 23 GPIO_ACTIVE_HIGH>;
+ };
+ };
+
+ gpio_poweroff {
+ compatible = "gpio-poweroff";
+ pinctrl-0 = <&pmx_pwr_off>;
+ pinctrl-names = "default";
+ gpios = <&gpio0 27 GPIO_ACTIVE_HIGH>;
+ };
+};
+
+&nand {
+ status = "okay";
+ chip-delay = <35>;
+
+ partition@0 {
+ label = "u-boot";
+ reg = <0x0000000 0xe0000>;
+ };
+
+ partition@e0000 {
+ label = "u-boot environment";
+ reg = <0xe0000 0x100000>;
+ };
+
+ partition@100000 {
+ label = "second stage u-boot";
+ reg = <0x100000 0x200000>;
+ };
+
+ partition@200000 {
+ label = "root";
+ reg = <0x200000 0xfe00000>;
+ };
+};
+
+&mdio {
+ status = "okay";
+ ethphy0: ethernet-phy@1 {
+ reg = <1>;
+ marvell,reg-init = <0x1 0x16 0x0 0x3>,
+ <0x1 0x10 0x0 0x1017>,
+ <0x1 0x11 0x0 0x4408>,
+ <0x1 0x16 0x0 0x0>,
+ <0x1 0x4 0x0 0x1e1>,
+ <0x1 0x9 0x0 0x300>,
+ <0x1 0x10 0x0 0x3860>,
+ <0x1 0x0 0x0 0x9140>;
+ };
+};
+
+ð0 {
+ status = "okay";
+
+ ethernet0-port@0 {
+ phy-handle = <ðphy0>;
+ };
+};
--
2.6.2
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 4/4] ARM: dts: kirkwood: add ZyXEL NSA310s
@ 2015-11-04 22:25 ` Luka Perkov
0 siblings, 0 replies; 20+ messages in thread
From: Luka Perkov @ 2015-11-04 22:25 UTC (permalink / raw)
To: linux-arm-kernel
Based on dts files from OpenWrt.
Signed-off-by: Luka Perkov <luka.perkov@sartura.hr>
Signed-off-by: Tony Dinh <mibodhi@gmail.com>
---
.../devicetree/bindings/arm/marvell,kirkwood.txt | 1 +
arch/arm/boot/dts/Makefile | 1 +
arch/arm/boot/dts/kirkwood-nsa310s.dts | 282 +++++++++++++++++++++
3 files changed, 284 insertions(+)
create mode 100644 arch/arm/boot/dts/kirkwood-nsa310s.dts
diff --git a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
index 37bd190..8a1a7f7 100644
--- a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
+++ b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
@@ -101,3 +101,4 @@ board. Currently known boards are:
"usi,topkick-1281P2"
"zyxel,nsa310"
"zyxel,nsa310a"
+"zyxel,nsa310s"
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 1d6fb0d..b2ea55f 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -196,6 +196,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \
kirkwood-ns2mini.dtb \
kirkwood-nsa310.dtb \
kirkwood-nsa310a.dtb \
+ kirkwood-nsa310s.dtb \
kirkwood-openblocks_a6.dtb \
kirkwood-openblocks_a7.dtb \
kirkwood-openrd-base.dtb \
diff --git a/arch/arm/boot/dts/kirkwood-nsa310s.dts b/arch/arm/boot/dts/kirkwood-nsa310s.dts
new file mode 100644
index 0000000..afc8ecf
--- /dev/null
+++ b/arch/arm/boot/dts/kirkwood-nsa310s.dts
@@ -0,0 +1,282 @@
+/dts-v1/;
+
+#include "kirkwood.dtsi"
+#include "kirkwood-6281.dtsi"
+
+/ {
+ model = "ZyXEL NSA310S";
+ compatible = "zyxel,nsa310s", "marvell,kirkwood-88f6702", "marvell,kirkwood";
+
+ memory {
+ device_type = "memory";
+ reg = <0x00000000 0x10000000>;
+ };
+
+ chosen {
+ bootargs = "console=ttyS0,115200n8 earlyprintk";
+ stdout-path = &uart0;
+ };
+
+ mbus {
+ pcie-controller {
+ status = "okay";
+
+ pcie at 1,0 {
+ status = "okay";
+ };
+ };
+ };
+
+ ocp at f1000000 {
+ pinctrl: pin-controller at 10000 {
+ pinctrl-names = "default";
+
+ pmx_sata0: pmx-sata0 {
+ marvell,pins;
+ marvell,function = "sata0";
+ };
+ pmx_sata1: pmx-sata1 {
+ marvell,pins;
+ marvell,function = "sata1";
+ };
+ pmx_usb_power: pmx-usb-power {
+ marvell,pins = "mpp21";
+ marvell,function = "gpio";
+ };
+ pmx_pwr_off: pmx-pwr-off {
+ marvell,pins = "mpp27";
+ marvell,function = "gpio";
+ };
+ pmx_btn_reset: pmx-btn-reset {
+ marvell,pins = "mpp24";
+ marvell,function = "gpio";
+ };
+ pmx_btn_copy: pmx-btn-copy {
+ marvell,pins = "mpp25";
+ marvell,function = "gpio";
+ };
+ pmx_btn_power: pmx-btn-power {
+ marvell,pins = "mpp26";
+ marvell,function = "gpio";
+ };
+ pmx_led_hdd2_green: pmx-led-hdd2-green {
+ marvell,pins = "mpp34";
+ marvell,function = "gpio";
+ };
+ pmx_led_hdd2_red: pmx-led-hdd2-red {
+ marvell,pins = "mpp12";
+ marvell,function = "gpio";
+ };
+ pmx_led_usb_green: pmx-led-usb-green {
+ marvell,pins = "mpp15";
+ marvell,function = "gpio";
+ };
+ pmx_led_copy_green: pmx-led-copy-green {
+ marvell,pins = "mpp22";
+ marvell,function = "gpio";
+ };
+ pmx_led_copy_red: pmx-led-copy-red {
+ marvell,pins = "mpp23";
+ marvell,function = "gpio";
+ };
+ pmx_led_sys_green: pmx-led-sys-green {
+ marvell,pins = "mpp28";
+ marvell,function = "gpio";
+ };
+ pmx_led_sys_orange: pmx-led-sys-orange {
+ marvell,pins = "mpp29";
+ marvell,function = "gpio";
+ };
+ pmx_led_hdd1_green: pmx-led-hdd1-green {
+ marvell,pins = "mpp16";
+ marvell,function = "gpio";
+ };
+ pmx_led_hdd1_red: pmx-led-hdd1-red {
+ marvell,pins = "mpp13";
+ marvell,function = "gpio";
+ };
+ pmx_pwr_sata1: pmx-pwr-sata1 {
+ marvell,pins = "mpp33";
+ marvell,function = "gpio";
+ };
+ };
+
+ serial at 12000 {
+ status = "okay";
+ };
+
+ sata at 80000 {
+ status = "okay";
+ nr-ports = <2>;
+ };
+
+ rtc at 10300 {
+ status = "disabled";
+ };
+
+ i2c at 11000 {
+ status = "okay";
+ };
+ };
+
+ regulators {
+ compatible = "simple-bus";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pmx_usb_power &pmx_pwr_sata1>;
+
+ usb0_power: regulator at 1 {
+ compatible = "regulator-fixed";
+ reg = <1>;
+ regulator-name = "USB Power";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ regulator-boot-on;
+ enable-active-high;
+ gpio = <&gpio0 21 GPIO_ACTIVE_HIGH>;
+ };
+
+ sata1_power: regulator at 2 {
+ compatible = "regulator-fixed";
+ reg = <2>;
+ regulator-name = "SATA1 Power";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ regulator-always-on;
+ regulator-boot-on;
+ enable-active-high;
+ gpio = <&gpio1 1 GPIO_ACTIVE_HIGH>;
+ };
+ };
+
+
+ gpio_keys {
+ compatible = "gpio-keys";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ pinctrl-0 = <&pmx_btn_reset &pmx_btn_copy &pmx_btn_power>;
+ pinctrl-names = "default";
+
+ button at 1 {
+ label = "Power Button";
+ linux,code = <KEY_POWER>;
+ gpios = <&gpio0 26 GPIO_ACTIVE_HIGH>;
+ };
+ button at 2 {
+ label = "Copy Button";
+ linux,code = <KEY_COPY>;
+ gpios = <&gpio0 25 GPIO_ACTIVE_LOW>;
+ };
+ button at 3 {
+ label = "Reset Button";
+ linux,code = <KEY_RESTART>;
+ gpios = <&gpio0 24 GPIO_ACTIVE_LOW>;
+ };
+ };
+
+ gpio-leds {
+ compatible = "gpio-leds";
+ pinctrl-0 = <&pmx_led_hdd2_green &pmx_led_hdd2_red
+ &pmx_led_usb_green
+ &pmx_led_sys_green &pmx_led_sys_orange
+ &pmx_led_copy_green &pmx_led_copy_red
+ &pmx_led_hdd1_green &pmx_led_hdd1_red>;
+ pinctrl-names = "default";
+
+ green-sys {
+ label = "nsa310s:green:sys";
+ gpios = <&gpio0 28 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "timer";
+ };
+ orange-sys {
+ label = "nsa310s:orange:sys";
+ gpios = <&gpio0 29 GPIO_ACTIVE_HIGH>;
+ };
+ green-hdd1 {
+ label = "nsa310s:green:hdd1";
+ gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
+ };
+ red-hdd1 {
+ label = "nsa310s:red:hdd1";
+ gpios = <&gpio0 13 GPIO_ACTIVE_HIGH>;
+ };
+ green-hdd2 {
+ label = "nsa310s:green:hdd2";
+ gpios = <&gpio1 2 GPIO_ACTIVE_HIGH>;
+ };
+ red-hdd2 {
+ label = "nsa310s:red:hdd2";
+ gpios = <&gpio0 12 GPIO_ACTIVE_HIGH>;
+ };
+ green-usb {
+ label = "nsa310s:green:usb";
+ gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>;
+ };
+ green-copy {
+ label = "nsa310s:green:copy";
+ gpios = <&gpio0 22 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "ide-disk";
+ };
+ red-copy {
+ label = "nsa310s:red:copy";
+ gpios = <&gpio0 23 GPIO_ACTIVE_HIGH>;
+ };
+ };
+
+ gpio_poweroff {
+ compatible = "gpio-poweroff";
+ pinctrl-0 = <&pmx_pwr_off>;
+ pinctrl-names = "default";
+ gpios = <&gpio0 27 GPIO_ACTIVE_HIGH>;
+ };
+};
+
+&nand {
+ status = "okay";
+ chip-delay = <35>;
+
+ partition at 0 {
+ label = "u-boot";
+ reg = <0x0000000 0xe0000>;
+ };
+
+ partition at e0000 {
+ label = "u-boot environment";
+ reg = <0xe0000 0x100000>;
+ };
+
+ partition at 100000 {
+ label = "second stage u-boot";
+ reg = <0x100000 0x200000>;
+ };
+
+ partition at 200000 {
+ label = "root";
+ reg = <0x200000 0xfe00000>;
+ };
+};
+
+&mdio {
+ status = "okay";
+ ethphy0: ethernet-phy at 1 {
+ reg = <1>;
+ marvell,reg-init = <0x1 0x16 0x0 0x3>,
+ <0x1 0x10 0x0 0x1017>,
+ <0x1 0x11 0x0 0x4408>,
+ <0x1 0x16 0x0 0x0>,
+ <0x1 0x4 0x0 0x1e1>,
+ <0x1 0x9 0x0 0x300>,
+ <0x1 0x10 0x0 0x3860>,
+ <0x1 0x0 0x0 0x9140>;
+ };
+};
+
+ð0 {
+ status = "okay";
+
+ ethernet0-port at 0 {
+ phy-handle = <ðphy0>;
+ };
+};
--
2.6.2
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 2/4] ARM: dts: kirkwood: add Linksys EA3500
2015-11-04 22:25 ` Luka Perkov
@ 2015-11-04 23:38 ` Andrew Lunn
-1 siblings, 0 replies; 20+ messages in thread
From: Andrew Lunn @ 2015-11-04 23:38 UTC (permalink / raw)
To: Luka Perkov
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, jason-NLaQJdtUoK4Be96aLqz0jA,
gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
Hi Luka
> "lacie,netspace_mini_v2"
> "lacie,netspace_v2"
> "linksys,ea4500"
> +"linksys,ea3500"
Other way around please, to keep the sorted order.
> + chosen {
> + bootargs = "console=ttyS0,115200n8 earlyprintk";
stdout = ...
> +&nand {
> + status = "okay";
> + pinctrl-0 = <&pmx_nand>;
> + pinctrl-names = "default";
> +
> + partition@0 {
> + label = "u-boot";
> + reg = <0x0000000 0x80000>;
> + read-only;
> + };
> +
> + partition@80000 {
> + label = "u-boot environment";
> + reg = <0x80000 0x20000>;
> + };
Same hole?
> + partition@200000 {
> + label = "kernel";
> + reg = <0x200000 0x200000>;
> + };
> +
> + partition@400000 {
> + label = "root";
> + reg = <0x400000 0x1200000>;
> + };
> +};
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 2/4] ARM: dts: kirkwood: add Linksys EA3500
@ 2015-11-04 23:38 ` Andrew Lunn
0 siblings, 0 replies; 20+ messages in thread
From: Andrew Lunn @ 2015-11-04 23:38 UTC (permalink / raw)
To: linux-arm-kernel
Hi Luka
> "lacie,netspace_mini_v2"
> "lacie,netspace_v2"
> "linksys,ea4500"
> +"linksys,ea3500"
Other way around please, to keep the sorted order.
> + chosen {
> + bootargs = "console=ttyS0,115200n8 earlyprintk";
stdout = ...
> +&nand {
> + status = "okay";
> + pinctrl-0 = <&pmx_nand>;
> + pinctrl-names = "default";
> +
> + partition at 0 {
> + label = "u-boot";
> + reg = <0x0000000 0x80000>;
> + read-only;
> + };
> +
> + partition at 80000 {
> + label = "u-boot environment";
> + reg = <0x80000 0x20000>;
> + };
Same hole?
> + partition at 200000 {
> + label = "kernel";
> + reg = <0x200000 0x200000>;
> + };
> +
> + partition at 400000 {
> + label = "root";
> + reg = <0x400000 0x1200000>;
> + };
> +};
Andrew
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 3/4] ARM: dts: kirkwood: add Seagate GoFlex Home
2015-11-04 22:25 ` Luka Perkov
@ 2015-11-05 0:23 ` Andrew Lunn
-1 siblings, 0 replies; 20+ messages in thread
From: Andrew Lunn @ 2015-11-05 0:23 UTC (permalink / raw)
To: Luka Perkov
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, jason-NLaQJdtUoK4Be96aLqz0jA,
gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
> + chosen {
> + bootargs = "console=ttyS0,115200n8 earlyprintk root=/dev/sda1 rootdelay=10";
It is not normal to specify the root device. Is this really required?
And rootdelay is also unusual.
> + stdout-path = &uart0;
> + };
> +
> + ocp@f1000000 {
> + pinctrl: pin-controller@10000 {
> + pmx_usb_power_enable: pmx-usb-power-enable {
> + marvell,pins = "mpp29";
> + marvell,function = "gpio";
> + };
> + pmx_led_white: pmx-led-white {
> + marvell,pins = "mpp40";
> + marvell,function = "gpio";
> + };
> + pmx_led_green: pmx-led_green {
> + marvell,pins = "mpp46";
That last _ should be -..
> + marvell,function = "gpio";
> + };
> + pmx_led_orange: pmx-led-orange {
> + marvell,pins = "mpp47";
> + marvell,function = "gpio";
> + };
> + };
> + serial@12000 {
> + status = "ok";
> + };
> +
> + sata@80000 {
> + status = "okay";
> + nr-ports = <2>;
> + };
> +
> + };
> + gpio-leds {
> + compatible = "gpio-leds";
> +
> + health {
> + label = "status:green:health";
This does not fit the naming convention. status should be the machine
name.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 3/4] ARM: dts: kirkwood: add Seagate GoFlex Home
@ 2015-11-05 0:23 ` Andrew Lunn
0 siblings, 0 replies; 20+ messages in thread
From: Andrew Lunn @ 2015-11-05 0:23 UTC (permalink / raw)
To: linux-arm-kernel
> + chosen {
> + bootargs = "console=ttyS0,115200n8 earlyprintk root=/dev/sda1 rootdelay=10";
It is not normal to specify the root device. Is this really required?
And rootdelay is also unusual.
> + stdout-path = &uart0;
> + };
> +
> + ocp at f1000000 {
> + pinctrl: pin-controller at 10000 {
> + pmx_usb_power_enable: pmx-usb-power-enable {
> + marvell,pins = "mpp29";
> + marvell,function = "gpio";
> + };
> + pmx_led_white: pmx-led-white {
> + marvell,pins = "mpp40";
> + marvell,function = "gpio";
> + };
> + pmx_led_green: pmx-led_green {
> + marvell,pins = "mpp46";
That last _ should be -..
> + marvell,function = "gpio";
> + };
> + pmx_led_orange: pmx-led-orange {
> + marvell,pins = "mpp47";
> + marvell,function = "gpio";
> + };
> + };
> + serial at 12000 {
> + status = "ok";
> + };
> +
> + sata at 80000 {
> + status = "okay";
> + nr-ports = <2>;
> + };
> +
> + };
> + gpio-leds {
> + compatible = "gpio-leds";
> +
> + health {
> + label = "status:green:health";
This does not fit the naming convention. status should be the machine
name.
Andrew
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 2/4] ARM: dts: kirkwood: add Linksys EA3500
2015-11-04 22:25 ` Luka Perkov
@ 2015-11-05 0:27 ` Andrew Lunn
-1 siblings, 0 replies; 20+ messages in thread
From: Andrew Lunn @ 2015-11-05 0:27 UTC (permalink / raw)
To: Luka Perkov
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, jason-NLaQJdtUoK4Be96aLqz0jA,
gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8
On Wed, Nov 04, 2015 at 10:25:07PM +0000, Luka Perkov wrote:
> Based on dts files from OpenWrt.
Hi Luka
Thanks for spending the time to submit these upstream.
It looks like a lot of the same comments apply to these files, so i
won't keep repeat them.
One thing i did notice is that turning off the internal RTC is common,
but there is no i2c RTC. Is this correct? Do these devices not have an
RTC?
Thanks
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 2/4] ARM: dts: kirkwood: add Linksys EA3500
@ 2015-11-05 0:27 ` Andrew Lunn
0 siblings, 0 replies; 20+ messages in thread
From: Andrew Lunn @ 2015-11-05 0:27 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Nov 04, 2015 at 10:25:07PM +0000, Luka Perkov wrote:
> Based on dts files from OpenWrt.
Hi Luka
Thanks for spending the time to submit these upstream.
It looks like a lot of the same comments apply to these files, so i
won't keep repeat them.
One thing i did notice is that turning off the internal RTC is common,
but there is no i2c RTC. Is this correct? Do these devices not have an
RTC?
Thanks
Andrew
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 3/4] ARM: dts: kirkwood: add Seagate GoFlex Home
2015-11-04 22:25 ` Luka Perkov
@ 2015-11-05 9:20 ` Simon Guinot
-1 siblings, 0 replies; 20+ messages in thread
From: Simon Guinot @ 2015-11-05 9:20 UTC (permalink / raw)
To: Luka Perkov
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
andrew-g2DYL2Zd6BY, jason-NLaQJdtUoK4Be96aLqz0jA,
Vincent Donnefort, Yoann Sculo
[-- Attachment #1: Type: text/plain, Size: 4894 bytes --]
Hi Luka,
On Wed, Nov 04, 2015 at 10:25:08PM +0000, Luka Perkov wrote:
> Based on dts files from OpenWrt.
>
> Signed-off-by: Luka Perkov <luka.perkov-RnoqsreqS2Fd2+I6+x7OVA@public.gmane.org>
> ---
> .../devicetree/bindings/arm/marvell,kirkwood.txt | 1 +
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/kirkwood-goflexhome.dts | 127 +++++++++++++++++++++
> 3 files changed, 129 insertions(+)
> create mode 100644 arch/arm/boot/dts/kirkwood-goflexhome.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
> index ed381a3..37bd190 100644
> --- a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
> +++ b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
> @@ -72,6 +72,7 @@ board. Currently known boards are:
> "raidsonic,ib-nas6220-b"
> "raidsonic,ib-nas62x0"
> "seagate,dockstar"
> +"seagate,goflexhome"
> "seagate,goflexnet"
> "synology,ds109"
> "synology,ds110jv10"
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index ebe5b73..1d6fb0d 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -170,6 +170,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \
> kirkwood-ds411slim.dtb \
> kirkwood-ea3500.dtb \
> kirkwood-ea4500.dtb \
> + kirkwood-goflexhome.dtb \
> kirkwood-goflexnet.dtb \
> kirkwood-guruplug-server-plus.dtb \
> kirkwood-ib62x0.dtb \
> diff --git a/arch/arm/boot/dts/kirkwood-goflexhome.dts b/arch/arm/boot/dts/kirkwood-goflexhome.dts
> new file mode 100644
> index 0000000..5f933d4
> --- /dev/null
> +++ b/arch/arm/boot/dts/kirkwood-goflexhome.dts
> @@ -0,0 +1,127 @@
> +/dts-v1/;
> +
> +#include "kirkwood.dtsi"
> +#include "kirkwood-6281.dtsi"
> +
> +/ {
> + model = "Seagate GoFlex Home";
> + compatible = "seagate,goflexhome", "marvell,kirkwood-88f6281", "marvell,kirkwood";
> +
> + memory {
> + device_type = "memory";
> + reg = <0x00000000 0x8000000>;
> + };
> +
> + chosen {
> + bootargs = "console=ttyS0,115200n8 earlyprintk root=/dev/sda1 rootdelay=10";
> + stdout-path = &uart0;
> + };
> +
> + ocp@f1000000 {
> + pinctrl: pin-controller@10000 {
> + pmx_usb_power_enable: pmx-usb-power-enable {
> + marvell,pins = "mpp29";
> + marvell,function = "gpio";
> + };
> + pmx_led_white: pmx-led-white {
> + marvell,pins = "mpp40";
> + marvell,function = "gpio";
> + };
> + pmx_led_green: pmx-led_green {
> + marvell,pins = "mpp46";
> + marvell,function = "gpio";
> + };
> + pmx_led_orange: pmx-led-orange {
> + marvell,pins = "mpp47";
> + marvell,function = "gpio";
> + };
> + };
> + serial@12000 {
> + status = "ok";
> + };
> +
> + sata@80000 {
> + status = "okay";
> + nr-ports = <2>;
I think nr-ports should be set to 1. This device only allows to plug a
single HDD and there is no eSATA connectors.
> + };
> +
> + };
> + gpio-leds {
> + compatible = "gpio-leds";
> +
> + health {
> + label = "status:green:health";
> + gpios = <&gpio1 14 1>;
It would be better to use GPIO_ACTIVE_LOW instead of 1. The same comment
applies to the other LEDs.
> + linux,default-trigger = "default-on";
> + };
> + fault {
> + label = "status:orange:fault";
> + gpios = <&gpio1 15 1>;
> + };
> + misc {
> + label = "status:white:misc";
> + gpios = <&gpio1 8 1>;
> + linux,default-trigger = "ide-disk";
ide-disk ? Really ? There is no way this can be correct :)
> + };
> + };
> + regulators {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pinctrl-0 = <&pmx_usb_power_enable>;
> + pinctrl-names = "default";
> +
> + usb_power: regulator@1 {
> + compatible = "regulator-fixed";
> + reg = <1>;
> + regulator-name = "USB Power";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + enable-active-high;
> + regulator-always-on;
> + regulator-boot-on;
> + gpio = <&gpio0 29 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +};
> +
> +&nand {
> + chip-delay = <40>;
> + status = "okay";
> +
> + partition@0 {
> + label = "u-boot";
> + reg = <0x0000000 0x100000>;
> + read-only;
> + };
> +
> + partition@100000 {
> + label = "uImage";
> + reg = <0x0100000 0x400000>;
> + };
> +
> + partition@500000 {
> + label = "pogoplug";
> + reg = <0x0500000 0x2000000>;
> + };
> +
> + partition@2500000 {
> + label = "root";
> + reg = <0x02500000 0xd800000>;
> + };
> +};
> +
> +&mdio {
> + status = "okay";
> +
> + ethphy0: ethernet-phy@0 {
> + reg = <0>;
> + };
> +};
> +
> +ð0 {
> + status = "okay";
> + ethernet0-port@0 {
> + phy-handle = <ðphy0>;
> + };
> +};
Is there a power-off GPIO on this board ?
Regards,
Simon
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 3/4] ARM: dts: kirkwood: add Seagate GoFlex Home
@ 2015-11-05 9:20 ` Simon Guinot
0 siblings, 0 replies; 20+ messages in thread
From: Simon Guinot @ 2015-11-05 9:20 UTC (permalink / raw)
To: linux-arm-kernel
Hi Luka,
On Wed, Nov 04, 2015 at 10:25:08PM +0000, Luka Perkov wrote:
> Based on dts files from OpenWrt.
>
> Signed-off-by: Luka Perkov <luka.perkov@sartura.hr>
> ---
> .../devicetree/bindings/arm/marvell,kirkwood.txt | 1 +
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/kirkwood-goflexhome.dts | 127 +++++++++++++++++++++
> 3 files changed, 129 insertions(+)
> create mode 100644 arch/arm/boot/dts/kirkwood-goflexhome.dts
>
> diff --git a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
> index ed381a3..37bd190 100644
> --- a/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
> +++ b/Documentation/devicetree/bindings/arm/marvell,kirkwood.txt
> @@ -72,6 +72,7 @@ board. Currently known boards are:
> "raidsonic,ib-nas6220-b"
> "raidsonic,ib-nas62x0"
> "seagate,dockstar"
> +"seagate,goflexhome"
> "seagate,goflexnet"
> "synology,ds109"
> "synology,ds110jv10"
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index ebe5b73..1d6fb0d 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -170,6 +170,7 @@ dtb-$(CONFIG_MACH_KIRKWOOD) += \
> kirkwood-ds411slim.dtb \
> kirkwood-ea3500.dtb \
> kirkwood-ea4500.dtb \
> + kirkwood-goflexhome.dtb \
> kirkwood-goflexnet.dtb \
> kirkwood-guruplug-server-plus.dtb \
> kirkwood-ib62x0.dtb \
> diff --git a/arch/arm/boot/dts/kirkwood-goflexhome.dts b/arch/arm/boot/dts/kirkwood-goflexhome.dts
> new file mode 100644
> index 0000000..5f933d4
> --- /dev/null
> +++ b/arch/arm/boot/dts/kirkwood-goflexhome.dts
> @@ -0,0 +1,127 @@
> +/dts-v1/;
> +
> +#include "kirkwood.dtsi"
> +#include "kirkwood-6281.dtsi"
> +
> +/ {
> + model = "Seagate GoFlex Home";
> + compatible = "seagate,goflexhome", "marvell,kirkwood-88f6281", "marvell,kirkwood";
> +
> + memory {
> + device_type = "memory";
> + reg = <0x00000000 0x8000000>;
> + };
> +
> + chosen {
> + bootargs = "console=ttyS0,115200n8 earlyprintk root=/dev/sda1 rootdelay=10";
> + stdout-path = &uart0;
> + };
> +
> + ocp at f1000000 {
> + pinctrl: pin-controller at 10000 {
> + pmx_usb_power_enable: pmx-usb-power-enable {
> + marvell,pins = "mpp29";
> + marvell,function = "gpio";
> + };
> + pmx_led_white: pmx-led-white {
> + marvell,pins = "mpp40";
> + marvell,function = "gpio";
> + };
> + pmx_led_green: pmx-led_green {
> + marvell,pins = "mpp46";
> + marvell,function = "gpio";
> + };
> + pmx_led_orange: pmx-led-orange {
> + marvell,pins = "mpp47";
> + marvell,function = "gpio";
> + };
> + };
> + serial at 12000 {
> + status = "ok";
> + };
> +
> + sata at 80000 {
> + status = "okay";
> + nr-ports = <2>;
I think nr-ports should be set to 1. This device only allows to plug a
single HDD and there is no eSATA connectors.
> + };
> +
> + };
> + gpio-leds {
> + compatible = "gpio-leds";
> +
> + health {
> + label = "status:green:health";
> + gpios = <&gpio1 14 1>;
It would be better to use GPIO_ACTIVE_LOW instead of 1. The same comment
applies to the other LEDs.
> + linux,default-trigger = "default-on";
> + };
> + fault {
> + label = "status:orange:fault";
> + gpios = <&gpio1 15 1>;
> + };
> + misc {
> + label = "status:white:misc";
> + gpios = <&gpio1 8 1>;
> + linux,default-trigger = "ide-disk";
ide-disk ? Really ? There is no way this can be correct :)
> + };
> + };
> + regulators {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + pinctrl-0 = <&pmx_usb_power_enable>;
> + pinctrl-names = "default";
> +
> + usb_power: regulator at 1 {
> + compatible = "regulator-fixed";
> + reg = <1>;
> + regulator-name = "USB Power";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + enable-active-high;
> + regulator-always-on;
> + regulator-boot-on;
> + gpio = <&gpio0 29 GPIO_ACTIVE_HIGH>;
> + };
> + };
> +};
> +
> +&nand {
> + chip-delay = <40>;
> + status = "okay";
> +
> + partition at 0 {
> + label = "u-boot";
> + reg = <0x0000000 0x100000>;
> + read-only;
> + };
> +
> + partition at 100000 {
> + label = "uImage";
> + reg = <0x0100000 0x400000>;
> + };
> +
> + partition at 500000 {
> + label = "pogoplug";
> + reg = <0x0500000 0x2000000>;
> + };
> +
> + partition at 2500000 {
> + label = "root";
> + reg = <0x02500000 0xd800000>;
> + };
> +};
> +
> +&mdio {
> + status = "okay";
> +
> + ethphy0: ethernet-phy at 0 {
> + reg = <0>;
> + };
> +};
> +
> +ð0 {
> + status = "okay";
> + ethernet0-port at 0 {
> + phy-handle = <ðphy0>;
> + };
> +};
Is there a power-off GPIO on this board ?
Regards,
Simon
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151105/08cee255/attachment-0001.sig>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 2/4] ARM: dts: kirkwood: add Linksys EA3500
2015-11-04 22:25 ` Luka Perkov
@ 2015-11-05 11:00 ` Imre Kaloz
-1 siblings, 0 replies; 20+ messages in thread
From: Imre Kaloz @ 2015-11-05 11:00 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA, Luka Perkov
Cc: gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
andrew-g2DYL2Zd6BY, jason-NLaQJdtUoK4Be96aLqz0jA
On Wed, 04 Nov 2015 23:25:07 +0100, Luka Perkov <luka.perkov-RnoqsreqS2Fd2+I6+x7OVA@public.gmane.org>
wrote:
> Based on dts files from OpenWrt.
>
> Signed-off-by: Luka Perkov <luka.perkov-RnoqsreqS2Fd2+I6+x7OVA@public.gmane.org>
Same comments as for the EA4500 patch. The engineering name of the ea3500
is "audi". Please use that and the factory partition table.
Imre
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 2/4] ARM: dts: kirkwood: add Linksys EA3500
@ 2015-11-05 11:00 ` Imre Kaloz
0 siblings, 0 replies; 20+ messages in thread
From: Imre Kaloz @ 2015-11-05 11:00 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 04 Nov 2015 23:25:07 +0100, Luka Perkov <luka.perkov@sartura.hr>
wrote:
> Based on dts files from OpenWrt.
>
> Signed-off-by: Luka Perkov <luka.perkov@sartura.hr>
Same comments as for the EA4500 patch. The engineering name of the ea3500
is "audi". Please use that and the factory partition table.
Imre
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 3/4] ARM: dts: kirkwood: add Seagate GoFlex Home
2015-11-04 22:25 ` Luka Perkov
@ 2015-11-06 16:05 ` Yoann Sculo
-1 siblings, 0 replies; 20+ messages in thread
From: Yoann Sculo @ 2015-11-06 16:05 UTC (permalink / raw)
To: Luka Perkov, linux-arm-kernel, devicetree; +Cc: gregory.clement, andrew, jason
Hi Luka,
I tested your patch on the GoFlex Home.
> + gpio-leds {
> + compatible = "gpio-leds";
> +
> + health {
> + label = "status:green:health";
> + gpios = <&gpio1 14 1>;
> + linux,default-trigger = "default-on";
> + };
> + fault {
> + label = "status:orange:fault";
> + gpios = <&gpio1 15 1>;
> + };
> + misc {
> + label = "status:white:misc";
> + gpios = <&gpio1 8 1>;
> + linux,default-trigger = "ide-disk";
> + };
> + };
I noticed green and orange leds were working fine (0 == off, 1 == on).
But white led polarity is inverted (1 == off, 0 == on).
> + partition@500000 {
> + label = "pogoplug";
> + reg = <0x0500000 0x2000000>;
> + };
I don't think pogoplug is the proper label for this partition. It seems
duplicated from "kirkwood-goflexnet.dts" I guess you could label it
"data" for instance.
Tested-by: Yoann Sculo <yoann@printk.fr>
Yoann
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 3/4] ARM: dts: kirkwood: add Seagate GoFlex Home
@ 2015-11-06 16:05 ` Yoann Sculo
0 siblings, 0 replies; 20+ messages in thread
From: Yoann Sculo @ 2015-11-06 16:05 UTC (permalink / raw)
To: linux-arm-kernel
Hi Luka,
I tested your patch on the GoFlex Home.
> + gpio-leds {
> + compatible = "gpio-leds";
> +
> + health {
> + label = "status:green:health";
> + gpios = <&gpio1 14 1>;
> + linux,default-trigger = "default-on";
> + };
> + fault {
> + label = "status:orange:fault";
> + gpios = <&gpio1 15 1>;
> + };
> + misc {
> + label = "status:white:misc";
> + gpios = <&gpio1 8 1>;
> + linux,default-trigger = "ide-disk";
> + };
> + };
I noticed green and orange leds were working fine (0 == off, 1 == on).
But white led polarity is inverted (1 == off, 0 == on).
> + partition at 500000 {
> + label = "pogoplug";
> + reg = <0x0500000 0x2000000>;
> + };
I don't think pogoplug is the proper label for this partition. It seems
duplicated from "kirkwood-goflexnet.dts" I guess you could label it
"data" for instance.
Tested-by: Yoann Sculo <yoann@printk.fr>
Yoann
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 3/4] ARM: dts: kirkwood: add Seagate GoFlex Home
2015-11-06 16:05 ` Yoann Sculo
@ 2015-12-18 9:32 ` Yoann Sculo
-1 siblings, 0 replies; 20+ messages in thread
From: Yoann Sculo @ 2015-12-18 9:32 UTC (permalink / raw)
To: Luka Perkov, linux-arm-kernel, devicetree; +Cc: gregory.clement, andrew, jason
Hi Luka,
Did you have the time to look at those issues ?
Yoann
Le 06/11/2015 17:05, Yoann Sculo a écrit :
> Hi Luka,
>
> I tested your patch on the GoFlex Home.
>
>> + gpio-leds {
>> + compatible = "gpio-leds";
>> +
>> + health {
>> + label = "status:green:health";
>> + gpios = <&gpio1 14 1>;
>> + linux,default-trigger = "default-on";
>> + };
>> + fault {
>> + label = "status:orange:fault";
>> + gpios = <&gpio1 15 1>;
>> + };
>> + misc {
>> + label = "status:white:misc";
>> + gpios = <&gpio1 8 1>;
>> + linux,default-trigger = "ide-disk";
>> + };
>> + };
>
> I noticed green and orange leds were working fine (0 == off, 1 == on).
> But white led polarity is inverted (1 == off, 0 == on).
>
>> + partition@500000 {
>> + label = "pogoplug";
>> + reg = <0x0500000 0x2000000>;
>> + };
>
> I don't think pogoplug is the proper label for this partition. It seems
> duplicated from "kirkwood-goflexnet.dts" I guess you could label it
> "data" for instance.
>
> Tested-by: Yoann Sculo <yoann@printk.fr>
>
> Yoann
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 3/4] ARM: dts: kirkwood: add Seagate GoFlex Home
@ 2015-12-18 9:32 ` Yoann Sculo
0 siblings, 0 replies; 20+ messages in thread
From: Yoann Sculo @ 2015-12-18 9:32 UTC (permalink / raw)
To: linux-arm-kernel
Hi Luka,
Did you have the time to look at those issues ?
Yoann
Le 06/11/2015 17:05, Yoann Sculo a ?crit :
> Hi Luka,
>
> I tested your patch on the GoFlex Home.
>
>> + gpio-leds {
>> + compatible = "gpio-leds";
>> +
>> + health {
>> + label = "status:green:health";
>> + gpios = <&gpio1 14 1>;
>> + linux,default-trigger = "default-on";
>> + };
>> + fault {
>> + label = "status:orange:fault";
>> + gpios = <&gpio1 15 1>;
>> + };
>> + misc {
>> + label = "status:white:misc";
>> + gpios = <&gpio1 8 1>;
>> + linux,default-trigger = "ide-disk";
>> + };
>> + };
>
> I noticed green and orange leds were working fine (0 == off, 1 == on).
> But white led polarity is inverted (1 == off, 0 == on).
>
>> + partition at 500000 {
>> + label = "pogoplug";
>> + reg = <0x0500000 0x2000000>;
>> + };
>
> I don't think pogoplug is the proper label for this partition. It seems
> duplicated from "kirkwood-goflexnet.dts" I guess you could label it
> "data" for instance.
>
> Tested-by: Yoann Sculo <yoann@printk.fr>
>
> Yoann
^ permalink raw reply [flat|nested] 20+ messages in thread
end of thread, other threads:[~2015-12-18 9:32 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1446675888-24495-1-git-send-email-luka.perkov@sartura.hr>
2015-11-04 22:25 ` [PATCH 2/4] ARM: dts: kirkwood: add Linksys EA3500 Luka Perkov
2015-11-04 22:25 ` Luka Perkov
[not found] ` <00000150d49a832c-f77d66d7-8f66-4b36-ac2c-df85deee46b6-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
2015-11-04 23:38 ` Andrew Lunn
2015-11-04 23:38 ` Andrew Lunn
2015-11-05 0:27 ` Andrew Lunn
2015-11-05 0:27 ` Andrew Lunn
2015-11-05 11:00 ` Imre Kaloz
2015-11-05 11:00 ` Imre Kaloz
2015-11-04 22:25 ` [PATCH 3/4] ARM: dts: kirkwood: add Seagate GoFlex Home Luka Perkov
2015-11-04 22:25 ` Luka Perkov
[not found] ` <00000150d49a8745-1c2bc8d4-1333-46bb-bf0e-5508ef988c73-000000-p/GC64/jrecnJqMo6gzdpkEOCMrvLtNR@public.gmane.org>
2015-11-05 0:23 ` Andrew Lunn
2015-11-05 0:23 ` Andrew Lunn
2015-11-05 9:20 ` Simon Guinot
2015-11-05 9:20 ` Simon Guinot
2015-11-06 16:05 ` Yoann Sculo
2015-11-06 16:05 ` Yoann Sculo
2015-12-18 9:32 ` Yoann Sculo
2015-12-18 9:32 ` Yoann Sculo
2015-11-04 22:25 ` [PATCH 4/4] ARM: dts: kirkwood: add ZyXEL NSA310s Luka Perkov
2015-11-04 22:25 ` Luka Perkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.