From: Sinan Kaya <okaya@codeaurora.org> To: Andy Shevchenko <andy.shevchenko@gmail.com> Cc: dmaengine <dmaengine@vger.kernel.org>, timur@codeaurora.org, cov@codeaurora.org, jcm@redhat.com, Andy Gross <agross@codeaurora.org>, linux-arm-msm@vger.kernel.org, linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, Vinod Koul <vinod.koul@intel.com>, Dan Williams <dan.j.williams@intel.com>, devicetree <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH V3 4/4] dma: add Qualcomm Technologies HIDMA channel driver Date: Sun, 8 Nov 2015 19:31:35 -0500 [thread overview] Message-ID: <563FE967.6080705@codeaurora.org> (raw) In-Reply-To: <CAHp75VebMdGRkgddoaCH_d_7hzXJt9QXqWc4yvSY=PJ-FcsRLA@mail.gmail.com> On 11/8/2015 3:47 PM, Andy Shevchenko wrote: > On Sun, Nov 8, 2015 at 6:53 AM, Sinan Kaya <okaya@codeaurora.org> wrote: >> This patch adds support for hidma engine. The driver >> consists of two logical blocks. The DMA engine interface >> and the low-level interface. The hardware only supports >> memcpy/memset and this driver only support memcpy >> interface. HW and driver doesn't support slave interface. > > Make lines a bit longer. > OK >> + pm_runtime_set_autosuspend_delay(&pdev->dev, AUTOSUSPEND_TIMEOUT); >> + pm_runtime_use_autosuspend(&pdev->dev); >> + pm_runtime_set_active(&pdev->dev); >> + pm_runtime_enable(&pdev->dev); >> + >> + trca_resource = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >> + if (!trca_resource) { >> + rc = -ENODEV; >> + goto bailout; >> + } > > Why did you ignore my comment about this block? > Remove that condition entirely. > Removed these four lines above. >> + >> + trca = devm_ioremap_resource(&pdev->dev, trca_resource); >> + if (IS_ERR(trca)) { >> + rc = -ENOMEM; >> + goto bailout; >> + } >> + >> + evca_resource = platform_get_resource(pdev, IORESOURCE_MEM, 1); >> + if (!evca_resource) { >> + rc = -ENODEV; >> + goto bailout; >> + } > > Ditto. > done >> +uninit: >> + hidma_debug_uninit(dmadev); >> + hidma_ll_uninit(dmadev->lldev); >> +dmafree: >> + if (dmadev) >> + hidma_free(dmadev); >> +bailout: >> + pm_runtime_disable(&pdev->dev); >> + pm_runtime_put_sync_suspend(&pdev->dev); > > Are you sure this is appropriate sequence? > > I think > > pm_runtime_put(); > pm_runtime_disable(); > corrected, reordered and used pm_runtime_put_sync() instead. > will do the job. > >> + return rc; >> +} >> + >> +static int hidma_remove(struct platform_device *pdev) >> +{ >> + struct hidma_dev *dmadev = platform_get_drvdata(pdev); >> + >> + dev_dbg(&pdev->dev, "removing\n"); > > Useless message. > Removed. >> + pm_runtime_get_sync(dmadev->ddev.dev); >> + >> + dma_async_device_unregister(&dmadev->ddev); >> + hidma_debug_uninit(dmadev); >> + hidma_ll_uninit(dmadev->lldev); >> + hidma_free(dmadev); >> + >> + dev_info(&pdev->dev, "HI-DMA engine removed\n"); >> + pm_runtime_put_sync_suspend(&pdev->dev); >> + pm_runtime_disable(&pdev->dev); >> + >> + return 0; >> +} -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V3 4/4] dma: add Qualcomm Technologies HIDMA channel driver Date: Sun, 8 Nov 2015 19:31:35 -0500 [thread overview] Message-ID: <563FE967.6080705@codeaurora.org> (raw) In-Reply-To: <CAHp75VebMdGRkgddoaCH_d_7hzXJt9QXqWc4yvSY=PJ-FcsRLA@mail.gmail.com> On 11/8/2015 3:47 PM, Andy Shevchenko wrote: > On Sun, Nov 8, 2015 at 6:53 AM, Sinan Kaya <okaya@codeaurora.org> wrote: >> This patch adds support for hidma engine. The driver >> consists of two logical blocks. The DMA engine interface >> and the low-level interface. The hardware only supports >> memcpy/memset and this driver only support memcpy >> interface. HW and driver doesn't support slave interface. > > Make lines a bit longer. > OK >> + pm_runtime_set_autosuspend_delay(&pdev->dev, AUTOSUSPEND_TIMEOUT); >> + pm_runtime_use_autosuspend(&pdev->dev); >> + pm_runtime_set_active(&pdev->dev); >> + pm_runtime_enable(&pdev->dev); >> + >> + trca_resource = platform_get_resource(pdev, IORESOURCE_MEM, 0); > >> + if (!trca_resource) { >> + rc = -ENODEV; >> + goto bailout; >> + } > > Why did you ignore my comment about this block? > Remove that condition entirely. > Removed these four lines above. >> + >> + trca = devm_ioremap_resource(&pdev->dev, trca_resource); >> + if (IS_ERR(trca)) { >> + rc = -ENOMEM; >> + goto bailout; >> + } >> + >> + evca_resource = platform_get_resource(pdev, IORESOURCE_MEM, 1); >> + if (!evca_resource) { >> + rc = -ENODEV; >> + goto bailout; >> + } > > Ditto. > done >> +uninit: >> + hidma_debug_uninit(dmadev); >> + hidma_ll_uninit(dmadev->lldev); >> +dmafree: >> + if (dmadev) >> + hidma_free(dmadev); >> +bailout: >> + pm_runtime_disable(&pdev->dev); >> + pm_runtime_put_sync_suspend(&pdev->dev); > > Are you sure this is appropriate sequence? > > I think > > pm_runtime_put(); > pm_runtime_disable(); > corrected, reordered and used pm_runtime_put_sync() instead. > will do the job. > >> + return rc; >> +} >> + >> +static int hidma_remove(struct platform_device *pdev) >> +{ >> + struct hidma_dev *dmadev = platform_get_drvdata(pdev); >> + >> + dev_dbg(&pdev->dev, "removing\n"); > > Useless message. > Removed. >> + pm_runtime_get_sync(dmadev->ddev.dev); >> + >> + dma_async_device_unregister(&dmadev->ddev); >> + hidma_debug_uninit(dmadev); >> + hidma_ll_uninit(dmadev->lldev); >> + hidma_free(dmadev); >> + >> + dev_info(&pdev->dev, "HI-DMA engine removed\n"); >> + pm_runtime_put_sync_suspend(&pdev->dev); >> + pm_runtime_disable(&pdev->dev); >> + >> + return 0; >> +} -- Sinan Kaya Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-11-09 0:31 UTC|newest] Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-08 4:52 [PATCH V3 0/4] *ma: add Qualcomm Technologies HIDMA driver Sinan Kaya 2015-11-08 4:52 ` Sinan Kaya 2015-11-08 4:52 ` [PATCH V3 1/4] dma: qcom_bam_dma: move to qcom directory Sinan Kaya 2015-11-08 4:52 ` Sinan Kaya 2015-11-08 5:02 ` Timur Tabi 2015-11-08 5:02 ` Timur Tabi [not found] ` <1446958380-23298-1-git-send-email-okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2015-11-08 4:52 ` [PATCH V3 2/4] dma: add Qualcomm Technologies HIDMA management driver Sinan Kaya 2015-11-08 4:52 ` Sinan Kaya 2015-11-08 4:52 ` Sinan Kaya 2015-11-08 5:08 ` Timur Tabi 2015-11-08 5:08 ` Timur Tabi 2015-11-09 2:17 ` Sinan Kaya 2015-11-09 2:17 ` Sinan Kaya 2015-11-09 18:25 ` Rob Herring 2015-11-09 18:25 ` Rob Herring 2015-11-10 4:57 ` Sinan Kaya 2015-11-10 4:57 ` Sinan Kaya 2015-11-08 9:32 ` kbuild test robot 2015-11-08 9:32 ` kbuild test robot 2015-11-08 9:32 ` kbuild test robot 2015-11-08 4:52 ` [PATCH V3 3/4] dmaselftest: add memcpy selftest support functions Sinan Kaya 2015-11-08 4:52 ` Sinan Kaya 2015-11-08 5:13 ` Timur Tabi 2015-11-08 5:13 ` Timur Tabi 2015-11-09 2:46 ` Sinan Kaya 2015-11-09 2:46 ` Sinan Kaya 2015-11-09 13:48 ` Timur Tabi 2015-11-09 13:48 ` Timur Tabi 2015-11-10 4:49 ` Sinan Kaya 2015-11-10 4:49 ` Sinan Kaya 2015-11-10 10:13 ` Arnd Bergmann 2015-11-10 10:13 ` Arnd Bergmann 2015-11-08 20:09 ` Andy Shevchenko 2015-11-08 20:09 ` Andy Shevchenko 2015-11-09 3:07 ` Sinan Kaya 2015-11-09 3:07 ` Sinan Kaya 2015-11-09 9:26 ` Andy Shevchenko 2015-11-09 9:26 ` Andy Shevchenko 2015-11-10 4:55 ` Sinan Kaya 2015-11-10 4:55 ` Sinan Kaya 2015-11-10 4:59 ` Timur Tabi 2015-11-10 4:59 ` Timur Tabi 2015-11-08 4:53 ` [PATCH V3 4/4] dma: add Qualcomm Technologies HIDMA channel driver Sinan Kaya 2015-11-08 4:53 ` Sinan Kaya [not found] ` <1446958380-23298-5-git-send-email-okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2015-11-08 19:13 ` kbuild test robot 2015-11-08 19:13 ` kbuild test robot 2015-11-08 19:13 ` kbuild test robot 2015-11-09 0:43 ` Sinan Kaya 2015-11-09 0:43 ` Sinan Kaya 2015-11-11 2:21 ` [kbuild-all] " Fengguang Wu 2015-11-11 2:21 ` Fengguang Wu [not found] ` <20151111022103.GA29459-q6ZYBFIlbFFi0tQiZxhdj1DQ4js95KgL@public.gmane.org> 2015-11-11 8:42 ` Arnd Bergmann 2015-11-11 8:42 ` Arnd Bergmann 2015-11-11 8:42 ` Arnd Bergmann 2015-11-12 8:20 ` Fengguang Wu 2015-11-12 8:20 ` Fengguang Wu 2015-11-12 13:49 ` Arnd Bergmann 2015-11-12 13:49 ` Arnd Bergmann 2015-11-08 20:47 ` Andy Shevchenko 2015-11-08 20:47 ` Andy Shevchenko 2015-11-08 20:47 ` Andy Shevchenko 2015-11-08 21:51 ` Sinan Kaya 2015-11-08 21:51 ` Sinan Kaya 2015-11-08 22:00 ` Andy Shevchenko 2015-11-08 22:00 ` Andy Shevchenko 2015-11-09 0:31 ` Sinan Kaya [this message] 2015-11-09 0:31 ` Sinan Kaya 2015-11-09 18:19 ` Rob Herring 2015-11-09 18:19 ` Rob Herring 2015-11-10 4:44 ` Sinan Kaya 2015-11-10 4:44 ` Sinan Kaya
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=563FE967.6080705@codeaurora.org \ --to=okaya@codeaurora.org \ --cc=agross@codeaurora.org \ --cc=andy.shevchenko@gmail.com \ --cc=cov@codeaurora.org \ --cc=dan.j.williams@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=galak@codeaurora.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=jcm@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ --cc=timur@codeaurora.org \ --cc=vinod.koul@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.