* [PATCH] media: adv7180: increase delay after reset to 5ms
@ 2015-11-10 13:39 ` Ulrich Hecht
0 siblings, 0 replies; 8+ messages in thread
From: Ulrich Hecht @ 2015-11-10 13:39 UTC (permalink / raw)
To: linux-media; +Cc: linux-sh, magnus.damm, laurent.pinchart, Ulrich Hecht
Initialization of the ADV7180 chip fails on the Renesas R8A7790-based
Lager board about 50% of the time. This patch resolves the issue by
increasing the minimum delay after reset from 2 ms to 5 ms, following the
recommendation in the ADV7180 datasheet:
"Executing a software reset takes approximately 2 ms. However, it is
recommended to wait 5 ms before any further I2C writes are performed."
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
drivers/media/i2c/adv7180.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
index f82c8aa..3c3c4bf 100644
--- a/drivers/media/i2c/adv7180.c
+++ b/drivers/media/i2c/adv7180.c
@@ -1112,7 +1112,7 @@ static int init_device(struct adv7180_state *state)
mutex_lock(&state->mutex);
adv7180_write(state, ADV7180_REG_PWR_MAN, ADV7180_PWR_MAN_RES);
- usleep_range(2000, 10000);
+ usleep_range(5000, 10000);
ret = state->chip_info->init(state);
if (ret)
--
2.6.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] media: adv7180: increase delay after reset to 5ms
@ 2015-11-10 13:39 ` Ulrich Hecht
0 siblings, 0 replies; 8+ messages in thread
From: Ulrich Hecht @ 2015-11-10 13:39 UTC (permalink / raw)
To: linux-media; +Cc: linux-sh, magnus.damm, laurent.pinchart, Ulrich Hecht
Initialization of the ADV7180 chip fails on the Renesas R8A7790-based
Lager board about 50% of the time. This patch resolves the issue by
increasing the minimum delay after reset from 2 ms to 5 ms, following the
recommendation in the ADV7180 datasheet:
"Executing a software reset takes approximately 2 ms. However, it is
recommended to wait 5 ms before any further I2C writes are performed."
Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
---
drivers/media/i2c/adv7180.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
index f82c8aa..3c3c4bf 100644
--- a/drivers/media/i2c/adv7180.c
+++ b/drivers/media/i2c/adv7180.c
@@ -1112,7 +1112,7 @@ static int init_device(struct adv7180_state *state)
mutex_lock(&state->mutex);
adv7180_write(state, ADV7180_REG_PWR_MAN, ADV7180_PWR_MAN_RES);
- usleep_range(2000, 10000);
+ usleep_range(5000, 10000);
ret = state->chip_info->init(state);
if (ret)
--
2.6.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] media: adv7180: increase delay after reset to 5ms
2015-11-10 13:39 ` Ulrich Hecht
@ 2015-11-11 23:10 ` Laurent Pinchart
-1 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2015-11-11 23:10 UTC (permalink / raw)
To: Ulrich Hecht; +Cc: linux-media, linux-sh, magnus.damm, Lars-Peter Clausen
Hi Ulrich,
(CC'ing Lars-Peter Clausen)
Thank you for the patch.
On Tuesday 10 November 2015 14:39:00 Ulrich Hecht wrote:
> Initialization of the ADV7180 chip fails on the Renesas R8A7790-based
> Lager board about 50% of the time. This patch resolves the issue by
> increasing the minimum delay after reset from 2 ms to 5 ms, following the
> recommendation in the ADV7180 datasheet:
>
> "Executing a software reset takes approximately 2 ms. However, it is
> recommended to wait 5 ms before any further I2C writes are performed."
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Lars, would you like to take this in your tree with other Analog Devices
patches, or should I take it ?
> ---
> drivers/media/i2c/adv7180.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
> index f82c8aa..3c3c4bf 100644
> --- a/drivers/media/i2c/adv7180.c
> +++ b/drivers/media/i2c/adv7180.c
> @@ -1112,7 +1112,7 @@ static int init_device(struct adv7180_state *state)
> mutex_lock(&state->mutex);
>
> adv7180_write(state, ADV7180_REG_PWR_MAN, ADV7180_PWR_MAN_RES);
> - usleep_range(2000, 10000);
> + usleep_range(5000, 10000);
>
> ret = state->chip_info->init(state);
> if (ret)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: adv7180: increase delay after reset to 5ms
@ 2015-11-11 23:10 ` Laurent Pinchart
0 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2015-11-11 23:10 UTC (permalink / raw)
To: Ulrich Hecht; +Cc: linux-media, linux-sh, magnus.damm, Lars-Peter Clausen
Hi Ulrich,
(CC'ing Lars-Peter Clausen)
Thank you for the patch.
On Tuesday 10 November 2015 14:39:00 Ulrich Hecht wrote:
> Initialization of the ADV7180 chip fails on the Renesas R8A7790-based
> Lager board about 50% of the time. This patch resolves the issue by
> increasing the minimum delay after reset from 2 ms to 5 ms, following the
> recommendation in the ADV7180 datasheet:
>
> "Executing a software reset takes approximately 2 ms. However, it is
> recommended to wait 5 ms before any further I2C writes are performed."
>
> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Lars, would you like to take this in your tree with other Analog Devices
patches, or should I take it ?
> ---
> drivers/media/i2c/adv7180.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
> index f82c8aa..3c3c4bf 100644
> --- a/drivers/media/i2c/adv7180.c
> +++ b/drivers/media/i2c/adv7180.c
> @@ -1112,7 +1112,7 @@ static int init_device(struct adv7180_state *state)
> mutex_lock(&state->mutex);
>
> adv7180_write(state, ADV7180_REG_PWR_MAN, ADV7180_PWR_MAN_RES);
> - usleep_range(2000, 10000);
> + usleep_range(5000, 10000);
>
> ret = state->chip_info->init(state);
> if (ret)
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: adv7180: increase delay after reset to 5ms
2015-11-11 23:10 ` Laurent Pinchart
@ 2015-11-12 10:13 ` Geert Uytterhoeven
-1 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2015-11-12 10:13 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Ulrich Hecht, Linux Media Mailing List, Linux-sh list,
Magnus Damm, Lars-Peter Clausen
On Thu, Nov 12, 2015 at 12:10 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> (CC'ing Lars-Peter Clausen)
>
> Thank you for the patch.
>
> On Tuesday 10 November 2015 14:39:00 Ulrich Hecht wrote:
>> Initialization of the ADV7180 chip fails on the Renesas R8A7790-based
>> Lager board about 50% of the time. This patch resolves the issue by
>> increasing the minimum delay after reset from 2 ms to 5 ms, following the
>> recommendation in the ADV7180 datasheet:
>>
>> "Executing a software reset takes approximately 2 ms. However, it is
>> recommended to wait 5 ms before any further I2C writes are performed."
>>
>> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Lars, would you like to take this in your tree with other Analog Devices
> patches, or should I take it ?
Which tree is this? Should I include it in renesas-drivers?
Does it contain more fixes?
During the s2ram suspend phase, the lockdep_assert_held() in adv7180_write()
is triggered on r8a7791/koelsch.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: adv7180: increase delay after reset to 5ms
@ 2015-11-12 10:13 ` Geert Uytterhoeven
0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2015-11-12 10:13 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Ulrich Hecht, Linux Media Mailing List, Linux-sh list,
Magnus Damm, Lars-Peter Clausen
On Thu, Nov 12, 2015 at 12:10 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> (CC'ing Lars-Peter Clausen)
>
> Thank you for the patch.
>
> On Tuesday 10 November 2015 14:39:00 Ulrich Hecht wrote:
>> Initialization of the ADV7180 chip fails on the Renesas R8A7790-based
>> Lager board about 50% of the time. This patch resolves the issue by
>> increasing the minimum delay after reset from 2 ms to 5 ms, following the
>> recommendation in the ADV7180 datasheet:
>>
>> "Executing a software reset takes approximately 2 ms. However, it is
>> recommended to wait 5 ms before any further I2C writes are performed."
>>
>> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Lars, would you like to take this in your tree with other Analog Devices
> patches, or should I take it ?
Which tree is this? Should I include it in renesas-drivers?
Does it contain more fixes?
During the s2ram suspend phase, the lockdep_assert_held() in adv7180_write()
is triggered on r8a7791/koelsch.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: adv7180: increase delay after reset to 5ms
2015-11-11 23:10 ` Laurent Pinchart
@ 2015-11-12 10:21 ` Lars-Peter Clausen
-1 siblings, 0 replies; 8+ messages in thread
From: Lars-Peter Clausen @ 2015-11-12 10:21 UTC (permalink / raw)
To: Laurent Pinchart, Ulrich Hecht
Cc: linux-media, linux-sh, magnus.damm, Hans Verkuil
On 11/12/2015 12:10 AM, Laurent Pinchart wrote:
> Hi Ulrich,
>
> (CC'ing Lars-Peter Clausen)
>
> Thank you for the patch.
>
> On Tuesday 10 November 2015 14:39:00 Ulrich Hecht wrote:
>> Initialization of the ADV7180 chip fails on the Renesas R8A7790-based
>> Lager board about 50% of the time. This patch resolves the issue by
>> increasing the minimum delay after reset from 2 ms to 5 ms, following the
>> recommendation in the ADV7180 datasheet:
>>
>> "Executing a software reset takes approximately 2 ms. However, it is
>> recommended to wait 5 ms before any further I2C writes are performed."
>>
>> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Lars, would you like to take this in your tree with other Analog Devices
> patches, or should I take it ?
I don't have a tree, usually Hans applies the patches directly.
Patch looks good, thanks.
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>
>> ---
>> drivers/media/i2c/adv7180.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
>> index f82c8aa..3c3c4bf 100644
>> --- a/drivers/media/i2c/adv7180.c
>> +++ b/drivers/media/i2c/adv7180.c
>> @@ -1112,7 +1112,7 @@ static int init_device(struct adv7180_state *state)
>> mutex_lock(&state->mutex);
>>
>> adv7180_write(state, ADV7180_REG_PWR_MAN, ADV7180_PWR_MAN_RES);
>> - usleep_range(2000, 10000);
>> + usleep_range(5000, 10000);
>>
>> ret = state->chip_info->init(state);
>> if (ret)
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] media: adv7180: increase delay after reset to 5ms
@ 2015-11-12 10:21 ` Lars-Peter Clausen
0 siblings, 0 replies; 8+ messages in thread
From: Lars-Peter Clausen @ 2015-11-12 10:21 UTC (permalink / raw)
To: Laurent Pinchart, Ulrich Hecht
Cc: linux-media, linux-sh, magnus.damm, Hans Verkuil
On 11/12/2015 12:10 AM, Laurent Pinchart wrote:
> Hi Ulrich,
>
> (CC'ing Lars-Peter Clausen)
>
> Thank you for the patch.
>
> On Tuesday 10 November 2015 14:39:00 Ulrich Hecht wrote:
>> Initialization of the ADV7180 chip fails on the Renesas R8A7790-based
>> Lager board about 50% of the time. This patch resolves the issue by
>> increasing the minimum delay after reset from 2 ms to 5 ms, following the
>> recommendation in the ADV7180 datasheet:
>>
>> "Executing a software reset takes approximately 2 ms. However, it is
>> recommended to wait 5 ms before any further I2C writes are performed."
>>
>> Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Lars, would you like to take this in your tree with other Analog Devices
> patches, or should I take it ?
I don't have a tree, usually Hans applies the patches directly.
Patch looks good, thanks.
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
>
>> ---
>> drivers/media/i2c/adv7180.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
>> index f82c8aa..3c3c4bf 100644
>> --- a/drivers/media/i2c/adv7180.c
>> +++ b/drivers/media/i2c/adv7180.c
>> @@ -1112,7 +1112,7 @@ static int init_device(struct adv7180_state *state)
>> mutex_lock(&state->mutex);
>>
>> adv7180_write(state, ADV7180_REG_PWR_MAN, ADV7180_PWR_MAN_RES);
>> - usleep_range(2000, 10000);
>> + usleep_range(5000, 10000);
>>
>> ret = state->chip_info->init(state);
>> if (ret)
>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-11-12 10:40 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-10 13:39 [PATCH] media: adv7180: increase delay after reset to 5ms Ulrich Hecht
2015-11-10 13:39 ` Ulrich Hecht
2015-11-11 23:10 ` Laurent Pinchart
2015-11-11 23:10 ` Laurent Pinchart
2015-11-12 10:13 ` Geert Uytterhoeven
2015-11-12 10:13 ` Geert Uytterhoeven
2015-11-12 10:21 ` Lars-Peter Clausen
2015-11-12 10:21 ` Lars-Peter Clausen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.