* adv7511: fix incorrect bit offset
@ 2015-11-12 15:30 Hans Verkuil
0 siblings, 0 replies; only message in thread
From: Hans Verkuil @ 2015-11-12 15:30 UTC (permalink / raw)
To: linux-media
The quantization bits are in bits 7-6, not 7-4, so shift by 6 instead of 4.
This bug is caused by a typo in the adv7511 datasheet.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
diff --git a/drivers/media/i2c/adv7511.c b/drivers/media/i2c/adv7511.c
index e4900df..b8de64c 100644
--- a/drivers/media/i2c/adv7511.c
+++ b/drivers/media/i2c/adv7511.c
@@ -1116,7 +1116,7 @@ static int adv7511_set_fmt(struct v4l2_subdev *sd,
adv7511_wr_and_or(sd, 0x55, 0x9f, y << 5);
adv7511_wr_and_or(sd, 0x56, 0x3f, c << 6);
adv7511_wr_and_or(sd, 0x57, 0x83, (ec << 4) | (q << 2));
- adv7511_wr_and_or(sd, 0x59, 0x0f, yq << 4);
+ adv7511_wr_and_or(sd, 0x59, 0x3f, yq << 6);
adv7511_wr_and_or(sd, 0x4a, 0xff, 1);
return 0;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-11-12 15:30 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-12 15:30 adv7511: fix incorrect bit offset Hans Verkuil
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.