* [patch] hpsa: logical vs bitwise AND typo
@ 2015-11-12 9:43 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2015-11-12 9:43 UTC (permalink / raw)
To: Don Brace, Scott Teel
Cc: James E.J. Bottomley, iss_storagedev, storagedev, linux-scsi,
kernel-janitors
HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was
intended here instead of logical &&. This bug is essentially harmless,
it means that sometimes we don't print a warning message which we wanted
to print.
Fixes: c2adae44e916 ('hpsa: disable report lun data caching')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 6a8f958..a386036 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -8671,7 +8671,7 @@ static void hpsa_disable_rld_caching(struct ctlr_info *h)
if ((rc != 0) || (c->err_info->CommandStatus != 0))
goto errout;
- if (*options && HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
+ if (*options & HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
goto out;
errout:
^ permalink raw reply related [flat|nested] 8+ messages in thread* [patch] hpsa: logical vs bitwise AND typo
@ 2015-11-12 9:43 ` Dan Carpenter
0 siblings, 0 replies; 8+ messages in thread
From: Dan Carpenter @ 2015-11-12 9:43 UTC (permalink / raw)
To: Don Brace, Scott Teel
Cc: James E.J. Bottomley, iss_storagedev, storagedev, linux-scsi,
kernel-janitors
HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was
intended here instead of logical &&. This bug is essentially harmless,
it means that sometimes we don't print a warning message which we wanted
to print.
Fixes: c2adae44e916 ('hpsa: disable report lun data caching')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 6a8f958..a386036 100644
--- a/drivers/scsi/hpsa.c
+++ b/drivers/scsi/hpsa.c
@@ -8671,7 +8671,7 @@ static void hpsa_disable_rld_caching(struct ctlr_info *h)
if ((rc != 0) || (c->err_info->CommandStatus != 0))
goto errout;
- if (*options && HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
+ if (*options & HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
goto out;
errout:
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [patch] hpsa: logical vs bitwise AND typo
2015-11-12 9:43 ` Dan Carpenter
@ 2015-11-12 9:59 ` Johannes Thumshirn
-1 siblings, 0 replies; 8+ messages in thread
From: Johannes Thumshirn @ 2015-11-12 9:59 UTC (permalink / raw)
To: Dan Carpenter, Don Brace, Scott Teel
Cc: James E.J. Bottomley, iss_storagedev, storagedev, linux-scsi,
kernel-janitors
On Thu, 2015-11-12 at 12:43 +0300, Dan Carpenter wrote:
> HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was
> intended here instead of logical &&. This bug is essentially
> harmless,
> it means that sometimes we don't print a warning message which we
> wanted
> to print.
>
> Fixes: c2adae44e916 ('hpsa: disable report lun data caching')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 6a8f958..a386036 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -8671,7 +8671,7 @@ static void hpsa_disable_rld_caching(struct
> ctlr_info *h)
> if ((rc != 0) || (c->err_info->CommandStatus != 0))
> goto errout;
>
> - if (*options && HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
> + if (*options & HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
> goto out;
>
> errout:
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch] hpsa: logical vs bitwise AND typo
@ 2015-11-12 9:59 ` Johannes Thumshirn
0 siblings, 0 replies; 8+ messages in thread
From: Johannes Thumshirn @ 2015-11-12 9:59 UTC (permalink / raw)
To: Dan Carpenter, Don Brace, Scott Teel
Cc: James E.J. Bottomley, iss_storagedev, storagedev, linux-scsi,
kernel-janitors
On Thu, 2015-11-12 at 12:43 +0300, Dan Carpenter wrote:
> HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was
> intended here instead of logical &&. This bug is essentially
> harmless,
> it means that sometimes we don't print a warning message which we
> wanted
> to print.
>
> Fixes: c2adae44e916 ('hpsa: disable report lun data caching')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 6a8f958..a386036 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -8671,7 +8671,7 @@ static void hpsa_disable_rld_caching(struct
> ctlr_info *h)
> if ((rc != 0) || (c->err_info->CommandStatus != 0))
> goto errout;
>
> - if (*options && HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
> + if (*options & HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
> goto out;
>
> errout:
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch] hpsa: logical vs bitwise AND typo
2015-11-12 9:59 ` Johannes Thumshirn
@ 2015-11-12 15:33 ` Don Brace
-1 siblings, 0 replies; 8+ messages in thread
From: Don Brace @ 2015-11-12 15:33 UTC (permalink / raw)
To: Johannes Thumshirn, Dan Carpenter, Scott Teel
Cc: James E.J. Bottomley, iss_storagedev, storagedev, linux-scsi,
kernel-janitors
On 11/12/2015 03:59 AM, Johannes Thumshirn wrote:
> On Thu, 2015-11-12 at 12:43 +0300, Dan Carpenter wrote:
>> HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was
>> intended here instead of logical &&. This bug is essentially
>> harmless,
>> it means that sometimes we don't print a warning message which we
>> wanted
>> to print.
>>
>> Fixes: c2adae44e916 ('hpsa: disable report lun data caching')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
>> index 6a8f958..a386036 100644
>> --- a/drivers/scsi/hpsa.c
>> +++ b/drivers/scsi/hpsa.c
>> @@ -8671,7 +8671,7 @@ static void hpsa_disable_rld_caching(struct
>> ctlr_info *h)
>> if ((rc != 0) || (c->err_info->CommandStatus != 0))
>> goto errout;
>>
>> - if (*options && HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
>> + if (*options & HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
>> goto out;
>>
>> errout:
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi"
>> in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Signed-off-by: Don Brace <don.brace@pmcs.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [patch] hpsa: logical vs bitwise AND typo
@ 2015-11-12 15:33 ` Don Brace
0 siblings, 0 replies; 8+ messages in thread
From: Don Brace @ 2015-11-12 15:33 UTC (permalink / raw)
To: Johannes Thumshirn, Dan Carpenter, Scott Teel
Cc: James E.J. Bottomley, iss_storagedev, storagedev, linux-scsi,
kernel-janitors
On 11/12/2015 03:59 AM, Johannes Thumshirn wrote:
> On Thu, 2015-11-12 at 12:43 +0300, Dan Carpenter wrote:
>> HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was
>> intended here instead of logical &&. This bug is essentially
>> harmless,
>> it means that sometimes we don't print a warning message which we
>> wanted
>> to print.
>>
>> Fixes: c2adae44e916 ('hpsa: disable report lun data caching')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
>> index 6a8f958..a386036 100644
>> --- a/drivers/scsi/hpsa.c
>> +++ b/drivers/scsi/hpsa.c
>> @@ -8671,7 +8671,7 @@ static void hpsa_disable_rld_caching(struct
>> ctlr_info *h)
>> if ((rc != 0) || (c->err_info->CommandStatus != 0))
>> goto errout;
>>
>> - if (*options && HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
>> + if (*options & HPSA_DIAG_OPTS_DISABLE_RLD_CACHING)
>> goto out;
>>
>> errout:
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-scsi"
>> in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Signed-off-by: Don Brace <don.brace@pmcs.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] hpsa: logical vs bitwise AND typo
2015-11-12 9:43 ` Dan Carpenter
@ 2015-11-13 21:50 ` Martin K. Petersen
-1 siblings, 0 replies; 8+ messages in thread
From: Martin K. Petersen @ 2015-11-13 21:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: Don Brace, Scott Teel, James E.J. Bottomley, iss_storagedev,
storagedev, linux-scsi, kernel-janitors
>>>>> "Dan" = Dan Carpenter <dan.carpenter@oracle.com> writes:
Dan> HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was
Dan> intended here instead of logical &&. This bug is essentially
Dan> harmless, it means that sometimes we don't print a warning message
Dan> which we wanted to print.
Applied.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [patch] hpsa: logical vs bitwise AND typo
@ 2015-11-13 21:50 ` Martin K. Petersen
0 siblings, 0 replies; 8+ messages in thread
From: Martin K. Petersen @ 2015-11-13 21:50 UTC (permalink / raw)
To: Dan Carpenter
Cc: Don Brace, Scott Teel, James E.J. Bottomley, iss_storagedev,
storagedev, linux-scsi, kernel-janitors
>>>>> "Dan" == Dan Carpenter <dan.carpenter@oracle.com> writes:
Dan> HPSA_DIAG_OPTS_DISABLE_RLD_CACHING is a mask and bitwise AND was
Dan> intended here instead of logical &&. This bug is essentially
Dan> harmless, it means that sometimes we don't print a warning message
Dan> which we wanted to print.
Applied.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-11-13 21:50 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-12 9:43 [patch] hpsa: logical vs bitwise AND typo Dan Carpenter
2015-11-12 9:43 ` Dan Carpenter
2015-11-12 9:59 ` Johannes Thumshirn
2015-11-12 9:59 ` Johannes Thumshirn
2015-11-12 15:33 ` Don Brace
2015-11-12 15:33 ` Don Brace
2015-11-13 21:50 ` Martin K. Petersen
2015-11-13 21:50 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.