* [U-Boot] [PATCH] arm: imx: Switch mx6cuboxi to use config_distro_bootcmd.h.
@ 2015-10-27 20:18 Vagrant Cascadian
2015-11-12 16:24 ` Stefano Babic
2015-11-12 17:16 ` Stefano Babic
0 siblings, 2 replies; 4+ messages in thread
From: Vagrant Cascadian @ 2015-10-27 20:18 UTC (permalink / raw)
To: u-boot
This allows for more flexible and standardized boot across multiple
platforms.
Remove redundant legacy boot environment.
Cc: Otavio Salvador <otavio@ossystems.com.br>
Signed-off-by: Vagrant Cascadian <vagrant@debian.org>
---
include/configs/mx6cuboxi.h | 88 +++++++++++++--------------------------------
1 file changed, 24 insertions(+), 64 deletions(-)
diff --git a/include/configs/mx6cuboxi.h b/include/configs/mx6cuboxi.h
index 6e89dd1..0f3b992 100644
--- a/include/configs/mx6cuboxi.h
+++ b/include/configs/mx6cuboxi.h
@@ -81,23 +81,26 @@
#define CONFIG_MXC_UART_BASE UART1_BASE
#define CONFIG_CONSOLE_DEV "ttymxc0"
-#define CONFIG_MMCROOT "/dev/mmcblk0p2"
#define CONFIG_SYS_FSL_USDHC_NUM 1
#define CONFIG_SYS_MMC_ENV_DEV 0 /* SDHC2 */
#define CONFIG_ENV_VARS_UBOOT_RUNTIME_CONFIG
+#ifndef CONFIG_SPL_BUILD
#define CONFIG_EXTRA_ENV_SETTINGS \
- "script=boot.scr\0" \
- "image=zImage\0" \
"fdtfile=undefined\0" \
"fdt_addr_r=0x18000000\0" \
- "boot_fdt=try\0" \
+ "fdt_addr=0x18000000\0" \
+ "kernel_addr_r=" __stringify(CONFIG_LOADADDR) "\0" \
+ "pxefile_addr_r=" __stringify(CONFIG_LOADADDR) "\0" \
+ "scriptaddr=" __stringify(CONFIG_LOADADDR) "\0" \
+ "ramdisk_addr_r=0x13000000\0" \
+ "ramdiskaddr=0x13000000\0" \
+ "initrd_high=0xffffffff\0" \
+ "fdt_high=0xffffffff\0" \
"ip_dyn=yes\0" \
"console=" CONFIG_CONSOLE_DEV "\0" \
"bootm_size=0x10000000\0" \
"mmcdev=" __stringify(CONFIG_SYS_MMC_ENV_DEV) "\0" \
- "mmcpart=1\0" \
- "mmcroot=" CONFIG_MMCROOT " rootwait rw\0" \
"update_sd_firmware=" \
"if test ${ip_dyn} = yes; then " \
"setenv get_cmd dhcp; " \
@@ -111,53 +114,6 @@
"mmc write ${loadaddr} 0x2 ${fw_sz}; " \
"fi; " \
"fi\0" \
- "mmcargs=setenv bootargs console=${console},${baudrate} " \
- "root=${mmcroot}\0" \
- "loadbootscript=" \
- "fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${script};\0" \
- "bootscript=echo Running bootscript from mmc ...; " \
- "source\0" \
- "loadimage=fatload mmc ${mmcdev}:${mmcpart} ${loadaddr} ${image}\0" \
- "loadfdt=fatload mmc ${mmcdev}:${mmcpart} ${fdt_addr_r} ${fdtfile}\0" \
- "mmcboot=echo Booting from mmc ...; " \
- "run mmcargs; " \
- "if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \
- "if run loadfdt; then " \
- "bootz ${loadaddr} - ${fdt_addr_r}; " \
- "else " \
- "if test ${boot_fdt} = try; then " \
- "bootz; " \
- "else " \
- "echo WARN: Cannot load the DT; " \
- "fi; " \
- "fi; " \
- "else " \
- "bootz; " \
- "fi;\0" \
- "netargs=setenv bootargs console=${console},${baudrate} " \
- "root=/dev/nfs " \
- "ip=dhcp nfsroot=${serverip}:${nfsroot},v3,tcp\0" \
- "netboot=echo Booting from net ...; " \
- "run netargs; " \
- "if test ${ip_dyn} = yes; then " \
- "setenv get_cmd dhcp; " \
- "else " \
- "setenv get_cmd tftp; " \
- "fi; " \
- "${get_cmd} ${image}; " \
- "if test ${boot_fdt} = yes || test ${boot_fdt} = try; then " \
- "if ${get_cmd} ${fdt_addr_r} ${fdtfile}; then " \
- "bootz ${loadaddr} - ${fdt_addr_r}; " \
- "else " \
- "if test ${boot_fdt} = try; then " \
- "bootz; " \
- "else " \
- "echo WARN: Cannot load the DT; " \
- "fi; " \
- "fi; " \
- "else " \
- "bootz; " \
- "fi;\0" \
"findfdt="\
"if test $board_name = HUMMINGBOARD && test $board_rev = MX6Q ; then " \
"setenv fdtfile imx6q-hummingboard.dtb; fi; " \
@@ -169,20 +125,24 @@
"setenv fdtfile imx6dl-cubox-i.dtb; fi; " \
"if test $fdtfile = undefined; then " \
"echo WARNING: Could not determine dtb to use; fi; \0" \
+ BOOTENV
#define CONFIG_BOOTCOMMAND \
"run findfdt; " \
- "mmc dev ${mmcdev};" \
- "if mmc rescan; then " \
- "if run loadbootscript; then " \
- "run bootscript; " \
- "else " \
- "if run loadimage; then " \
- "run mmcboot; " \
- "else run netboot; " \
- "fi; " \
- "fi; " \
- "else run netboot; fi"
+ "run distro_bootcmd"
+
+#define BOOT_TARGET_DEVICES(func) \
+ func(MMC, mmc, 0) \
+ func(USB, usb, 0) \
+ func(PXE, pxe, na) \
+ func(DHCP, dhcp, na)
+
+#include <config_distro_defaults.h>
+#include <config_distro_bootcmd.h>
+
+#else
+#define CONFIG_EXTRA_ENV_SETTINGS
+#endif /* CONFIG_SPL_BUILD */
/* Physical Memory Map */
#define CONFIG_NR_DRAM_BANKS 1
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] arm: imx: Switch mx6cuboxi to use config_distro_bootcmd.h.
2015-10-27 20:18 [U-Boot] [PATCH] arm: imx: Switch mx6cuboxi to use config_distro_bootcmd.h Vagrant Cascadian
@ 2015-11-12 16:24 ` Stefano Babic
2015-11-12 17:16 ` Stefano Babic
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2015-11-12 16:24 UTC (permalink / raw)
To: u-boot
On 27/10/2015 21:18, Vagrant Cascadian wrote:
> This allows for more flexible and standardized boot across multiple
> platforms.
>
> Remove redundant legacy boot environment.
>
> Cc: Otavio Salvador <otavio@ossystems.com.br>
> Signed-off-by: Vagrant Cascadian <vagrant@debian.org>
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] arm: imx: Switch mx6cuboxi to use config_distro_bootcmd.h.
2015-10-27 20:18 [U-Boot] [PATCH] arm: imx: Switch mx6cuboxi to use config_distro_bootcmd.h Vagrant Cascadian
2015-11-12 16:24 ` Stefano Babic
@ 2015-11-12 17:16 ` Stefano Babic
2015-11-12 17:39 ` Vagrant Cascadian
1 sibling, 1 reply; 4+ messages in thread
From: Stefano Babic @ 2015-11-12 17:16 UTC (permalink / raw)
To: u-boot
Hi Vagrant,
On 27/10/2015 21:18, Vagrant Cascadian wrote:
> This allows for more flexible and standardized boot across multiple
> platforms.
>
> Remove redundant legacy boot environment.
>
I have applied it. However, the patch generates a warning due to
CONFIG_BOOT_DELAY, that is defined twice. Firstly, it is defined in
mx6_common.h (anyway, in this file is protected) and then in distro_default
> Cc: Otavio Salvador <otavio@ossystems.com.br>
> Signed-off-by: Vagrant Cascadian <vagrant@debian.org>
> +#define BOOT_TARGET_DEVICES(func) \
> + func(MMC, mmc, 0) \
> + func(USB, usb, 0) \
> + func(PXE, pxe, na) \
> + func(DHCP, dhcp, na)
> +
> +#include <config_distro_defaults.h>
> +#include <config_distro_bootcmd.h>
Maybe just #undef CONFIG_BOOT_DELAY before including distro files ?
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] arm: imx: Switch mx6cuboxi to use config_distro_bootcmd.h.
2015-11-12 17:16 ` Stefano Babic
@ 2015-11-12 17:39 ` Vagrant Cascadian
0 siblings, 0 replies; 4+ messages in thread
From: Vagrant Cascadian @ 2015-11-12 17:39 UTC (permalink / raw)
To: u-boot
On 2015-11-12, Stefano Babic wrote:
> On 27/10/2015 21:18, Vagrant Cascadian wrote:
>> This allows for more flexible and standardized boot across multiple
>> platforms.
>>
>> Remove redundant legacy boot environment.
>>
>
> I have applied it.
Thanks!
> However, the patch generates a warning due to
> CONFIG_BOOT_DELAY, that is defined twice. Firstly, it is defined in
> mx6_common.h (anyway, in this file is protected) and then in distro_default
Oops, forgot to file an updated patch to fix that...
>> +#define BOOT_TARGET_DEVICES(func) \
>> + func(MMC, mmc, 0) \
>> + func(USB, usb, 0) \
>> + func(PXE, pxe, na) \
>> + func(DHCP, dhcp, na)
>> +
>
>> +#include <config_distro_defaults.h>
>> +#include <config_distro_bootcmd.h>
>
> Maybe just #undef CONFIG_BOOT_DELAY before including distro files ?
Alternately, including config_distro_defaults.h could be moved before
including mx6_common.h. Either way works fine by me.
Same applies for the wandboard patch.
I just realized that the console setting for mx6cuboxi should also
include the baudrate, just like for the wandboard.
live well,
vagrant
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20151112/b04e2616/attachment.sig>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-12 17:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-27 20:18 [U-Boot] [PATCH] arm: imx: Switch mx6cuboxi to use config_distro_bootcmd.h Vagrant Cascadian
2015-11-12 16:24 ` Stefano Babic
2015-11-12 17:16 ` Stefano Babic
2015-11-12 17:39 ` Vagrant Cascadian
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.