From: David Vrabel <david.vrabel@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
<xen-devel@lists.xensource.com>
Cc: <Ian.Campbell@citrix.com>, <linux-kernel@vger.kernel.org>,
<david.vrabel@citrix.com>, <boris.ostrovsky@oracle.com>,
<linux-arm-kernel@lists.infradead.org>,
John Stultz <john.stultz@linaro.org>
Subject: Re: [Xen-devel] [PATCH v4 7/7] xen/x86: support XENPF_settime64
Date: Fri, 13 Nov 2015 10:42:20 +0000 [thread overview]
Message-ID: <5645BE8C.6050109@citrix.com> (raw)
In-Reply-To: <1447349448-22610-7-git-send-email-stefano.stabellini@eu.citrix.com>
On 12/11/15 17:30, Stefano Stabellini wrote:
> Try XENPF_settime64 first, if it is not available fall back to
> XENPF_settime32.
>
> No need to call __current_kernel_time() when all the info needed are
> already passed via the struct timekeeper * argument.
>
> Return NOTIFY_BAD in case of errors.
[...]
> @@ -123,9 +124,13 @@ static int xen_pvclock_gtod_notify(struct notifier_block *nb,
> static struct timespec next_sync;
>
> struct xen_platform_op op;
> - struct timespec now;
> + struct timespec64 now;
> + struct timekeeper *tk = priv;
> + static bool settime64_supported = true;
> + int ret;
>
> - now = __current_kernel_time();
> + now.tv_sec = tk->xtime_sec;
> + now.tv_nsec = (long)(tk->tkr_mono.xtime_nsec >> tk->tkr_mono.shift);
I think you should introduce __current_kernel_time64() or make
tk_xtime() available.
John, what do you think?
David
WARNING: multiple messages have this Message-ID (diff)
From: david.vrabel@citrix.com (David Vrabel)
To: linux-arm-kernel@lists.infradead.org
Subject: [Xen-devel] [PATCH v4 7/7] xen/x86: support XENPF_settime64
Date: Fri, 13 Nov 2015 10:42:20 +0000 [thread overview]
Message-ID: <5645BE8C.6050109@citrix.com> (raw)
In-Reply-To: <1447349448-22610-7-git-send-email-stefano.stabellini@eu.citrix.com>
On 12/11/15 17:30, Stefano Stabellini wrote:
> Try XENPF_settime64 first, if it is not available fall back to
> XENPF_settime32.
>
> No need to call __current_kernel_time() when all the info needed are
> already passed via the struct timekeeper * argument.
>
> Return NOTIFY_BAD in case of errors.
[...]
> @@ -123,9 +124,13 @@ static int xen_pvclock_gtod_notify(struct notifier_block *nb,
> static struct timespec next_sync;
>
> struct xen_platform_op op;
> - struct timespec now;
> + struct timespec64 now;
> + struct timekeeper *tk = priv;
> + static bool settime64_supported = true;
> + int ret;
>
> - now = __current_kernel_time();
> + now.tv_sec = tk->xtime_sec;
> + now.tv_nsec = (long)(tk->tkr_mono.xtime_nsec >> tk->tkr_mono.shift);
I think you should introduce __current_kernel_time64() or make
tk_xtime() available.
John, what do you think?
David
WARNING: multiple messages have this Message-ID (diff)
From: David Vrabel <david.vrabel@citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xensource.com
Cc: Ian.Campbell@citrix.com, linux-kernel@vger.kernel.org,
david.vrabel@citrix.com, boris.ostrovsky@oracle.com,
linux-arm-kernel@lists.infradead.org,
John Stultz <john.stultz@linaro.org>
Subject: Re: [Xen-devel] [PATCH v4 7/7] xen/x86: support XENPF_settime64
Date: Fri, 13 Nov 2015 10:42:20 +0000 [thread overview]
Message-ID: <5645BE8C.6050109@citrix.com> (raw)
In-Reply-To: <1447349448-22610-7-git-send-email-stefano.stabellini@eu.citrix.com>
On 12/11/15 17:30, Stefano Stabellini wrote:
> Try XENPF_settime64 first, if it is not available fall back to
> XENPF_settime32.
>
> No need to call __current_kernel_time() when all the info needed are
> already passed via the struct timekeeper * argument.
>
> Return NOTIFY_BAD in case of errors.
[...]
> @@ -123,9 +124,13 @@ static int xen_pvclock_gtod_notify(struct notifier_block *nb,
> static struct timespec next_sync;
>
> struct xen_platform_op op;
> - struct timespec now;
> + struct timespec64 now;
> + struct timekeeper *tk = priv;
> + static bool settime64_supported = true;
> + int ret;
>
> - now = __current_kernel_time();
> + now.tv_sec = tk->xtime_sec;
> + now.tv_nsec = (long)(tk->tkr_mono.xtime_nsec >> tk->tkr_mono.shift);
I think you should introduce __current_kernel_time64() or make
tk_xtime() available.
John, what do you think?
David
next prev parent reply other threads:[~2015-11-13 10:42 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 17:29 [PATCH v4 0/7] Xen wallclock on arm and arm64 Stefano Stabellini
2015-11-12 17:29 ` Stefano Stabellini
2015-11-12 17:29 ` Stefano Stabellini
2015-11-12 17:30 ` [PATCH v4 1/7] xen: rename dom0_op to platform_op Stefano Stabellini
2015-11-12 17:30 ` Stefano Stabellini
2015-11-12 17:30 ` Stefano Stabellini
2015-11-12 17:30 ` [PATCH v4 2/7] xen/arm: introduce HYPERVISOR_platform_op on arm and arm64 Stefano Stabellini
2015-11-12 17:30 ` Stefano Stabellini
2015-11-12 17:30 ` Stefano Stabellini
2015-11-13 13:40 ` [Xen-devel] " Julien Grall
2015-11-13 13:40 ` Julien Grall
2015-11-13 13:40 ` Julien Grall
2015-11-13 18:10 ` Stefano Stabellini
2015-11-13 18:10 ` Stefano Stabellini
2015-11-13 18:10 ` Stefano Stabellini
2015-11-13 18:31 ` Julien Grall
2015-11-13 18:31 ` Julien Grall
2015-11-13 18:31 ` Julien Grall
2015-11-16 9:42 ` Ian Campbell
2015-11-16 9:42 ` Ian Campbell
2015-11-16 9:42 ` Ian Campbell
2015-11-20 11:58 ` Stefano Stabellini
2015-11-20 11:58 ` Stefano Stabellini
2015-11-20 11:58 ` Stefano Stabellini
2015-11-20 12:18 ` Ian Campbell
2015-11-20 12:18 ` Ian Campbell
2015-11-20 12:18 ` Ian Campbell
2015-11-12 17:30 ` [PATCH v4 3/7] xen: introduce XENPF_settime64 Stefano Stabellini
2015-11-12 17:30 ` Stefano Stabellini
2015-11-12 17:30 ` Stefano Stabellini
2015-11-12 17:30 ` [PATCH v4 4/7] arm: extend pvclock_wall_clock with sec_hi Stefano Stabellini
2015-11-12 17:30 ` Stefano Stabellini
2015-11-12 17:30 ` Stefano Stabellini
2015-11-13 13:43 ` [Xen-devel] " Julien Grall
2015-11-13 13:43 ` Julien Grall
2015-11-13 13:43 ` Julien Grall
2015-11-12 17:30 ` [PATCH v4 5/7] xen/arm: introduce xen_read_wallclock Stefano Stabellini
2015-11-12 17:30 ` Stefano Stabellini
2015-11-12 17:30 ` Stefano Stabellini
2015-11-12 19:12 ` Arnd Bergmann
2015-11-12 19:12 ` Arnd Bergmann
2015-11-12 17:30 ` [PATCH v4 6/7] xen/arm: set the system time in Xen via the XENPF_settime64 hypercall Stefano Stabellini
2015-11-12 17:30 ` Stefano Stabellini
2015-11-12 17:30 ` Stefano Stabellini
2015-11-13 13:56 ` [Xen-devel] " Julien Grall
2015-11-13 13:56 ` Julien Grall
2015-11-13 13:56 ` Julien Grall
2015-11-12 17:30 ` [PATCH v4 7/7] xen/x86: support XENPF_settime64 Stefano Stabellini
2015-11-12 17:30 ` Stefano Stabellini
2015-11-12 17:30 ` Stefano Stabellini
2015-11-12 19:14 ` Arnd Bergmann
2015-11-12 19:14 ` Arnd Bergmann
2015-11-13 10:42 ` David Vrabel [this message]
2015-11-13 10:42 ` [Xen-devel] " David Vrabel
2015-11-13 10:42 ` David Vrabel
2015-11-13 10:45 ` Stefano Stabellini
2015-11-13 10:45 ` Stefano Stabellini
2015-11-13 10:45 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5645BE8C.6050109@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Campbell@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.