From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org,
"moderated list:ARM/Allwinner A1X..."
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2] clocksource/drivers/timer_sun5i: Replace code by clocksource_mmio_init
Date: Fri, 13 Nov 2015 15:27:39 +0100 [thread overview]
Message-ID: <5645F35B.7090503@linaro.org> (raw)
In-Reply-To: <20151112233129.GH32142@lukather>
On 11/13/2015 12:31 AM, Maxime Ripard wrote:
> On Thu, Nov 12, 2015 at 07:40:13PM +0100, Daniel Lezcano wrote:
>> The current code to initialize, register and read the clocksource is
>> already factored out in mmio.c via the clocksource_mmio_init function.
>>
>> The only difference is the readl vs readl_relaxed.
>>
>> Factor out the code with the clocksource_mmio_init function.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks for the review. I applied the patch with a fix:
ret = clocksource_mmio_init(base + TIMER_CNTVAL_LO_REG(1),
node->name,
rate, 340, UINT_MAX,
clocksource_mmio_readl_down);
Replaced UINT_MAX by '32'.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: daniel.lezcano@linaro.org (Daniel Lezcano)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] clocksource/drivers/timer_sun5i: Replace code by clocksource_mmio_init
Date: Fri, 13 Nov 2015 15:27:39 +0100 [thread overview]
Message-ID: <5645F35B.7090503@linaro.org> (raw)
In-Reply-To: <20151112233129.GH32142@lukather>
On 11/13/2015 12:31 AM, Maxime Ripard wrote:
> On Thu, Nov 12, 2015 at 07:40:13PM +0100, Daniel Lezcano wrote:
>> The current code to initialize, register and read the clocksource is
>> already factored out in mmio.c via the clocksource_mmio_init function.
>>
>> The only difference is the readl vs readl_relaxed.
>>
>> Factor out the code with the clocksource_mmio_init function.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks for the review. I applied the patch with a fix:
ret = clocksource_mmio_init(base + TIMER_CNTVAL_LO_REG(1),
node->name,
rate, 340, UINT_MAX,
clocksource_mmio_readl_down);
Replaced UINT_MAX by '32'.
-- Daniel
--
<http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-11-13 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 18:40 [PATCH V2] clocksource/drivers/timer_sun5i: Replace code by clocksource_mmio_init Daniel Lezcano
2015-11-12 18:40 ` Daniel Lezcano
2015-11-12 23:31 ` Maxime Ripard
2015-11-12 23:31 ` Maxime Ripard
2015-11-13 14:27 ` Daniel Lezcano [this message]
2015-11-13 14:27 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5645F35B.7090503@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.