* [PATCH] clocksource: fsl: avoid harmless 64-bit warnings
@ 2015-11-16 16:34 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2015-11-16 16:34 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Thomas Gleixner, linux-kernel, linux-arm-kernel, Xiubo Li,
Shawn Guo, Sascha Hauer, Stefan Agner
The ftm_clockevent_init passes the value of "~0UL" into a function
that takes a 32-bit argument, which drops the upper 32 bits, as
gcc warns about on ARM64:
clocksource/fsl_ftm_timer.c: In function 'ftm_clockevent_init':
clocksource/fsl_ftm_timer.c:206:13: warning: large integer implicitly truncated to unsigned type [-Woverflow]
This was obviously unintended behavior, and is easily avoided by
using '~0u' as the integer literal, because that is 32-bit wide
on all architectures.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/clocksource/fsl_ftm_timer.c b/drivers/clocksource/fsl_ftm_timer.c
index 10202f1fdfd7..517e1c7624d4 100644
--- a/drivers/clocksource/fsl_ftm_timer.c
+++ b/drivers/clocksource/fsl_ftm_timer.c
@@ -203,7 +203,7 @@ static int __init ftm_clockevent_init(unsigned long freq, int irq)
int err;
ftm_writel(0x00, priv->clkevt_base + FTM_CNTIN);
- ftm_writel(~0UL, priv->clkevt_base + FTM_MOD);
+ ftm_writel(~0u, priv->clkevt_base + FTM_MOD);
ftm_reset_counter(priv->clkevt_base);
@@ -230,7 +230,7 @@ static int __init ftm_clocksource_init(unsigned long freq)
int err;
ftm_writel(0x00, priv->clksrc_base + FTM_CNTIN);
- ftm_writel(~0UL, priv->clksrc_base + FTM_MOD);
+ ftm_writel(~0u, priv->clksrc_base + FTM_MOD);
ftm_reset_counter(priv->clksrc_base);
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] clocksource: fsl: avoid harmless 64-bit warnings
@ 2015-11-16 16:34 ` Arnd Bergmann
0 siblings, 0 replies; 9+ messages in thread
From: Arnd Bergmann @ 2015-11-16 16:34 UTC (permalink / raw)
To: linux-arm-kernel
The ftm_clockevent_init passes the value of "~0UL" into a function
that takes a 32-bit argument, which drops the upper 32 bits, as
gcc warns about on ARM64:
clocksource/fsl_ftm_timer.c: In function 'ftm_clockevent_init':
clocksource/fsl_ftm_timer.c:206:13: warning: large integer implicitly truncated to unsigned type [-Woverflow]
This was obviously unintended behavior, and is easily avoided by
using '~0u' as the integer literal, because that is 32-bit wide
on all architectures.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/clocksource/fsl_ftm_timer.c b/drivers/clocksource/fsl_ftm_timer.c
index 10202f1fdfd7..517e1c7624d4 100644
--- a/drivers/clocksource/fsl_ftm_timer.c
+++ b/drivers/clocksource/fsl_ftm_timer.c
@@ -203,7 +203,7 @@ static int __init ftm_clockevent_init(unsigned long freq, int irq)
int err;
ftm_writel(0x00, priv->clkevt_base + FTM_CNTIN);
- ftm_writel(~0UL, priv->clkevt_base + FTM_MOD);
+ ftm_writel(~0u, priv->clkevt_base + FTM_MOD);
ftm_reset_counter(priv->clkevt_base);
@@ -230,7 +230,7 @@ static int __init ftm_clocksource_init(unsigned long freq)
int err;
ftm_writel(0x00, priv->clksrc_base + FTM_CNTIN);
- ftm_writel(~0UL, priv->clksrc_base + FTM_MOD);
+ ftm_writel(~0u, priv->clksrc_base + FTM_MOD);
ftm_reset_counter(priv->clksrc_base);
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] clocksource: fsl: avoid harmless 64-bit warnings
2015-11-16 16:34 ` Arnd Bergmann
@ 2015-11-17 9:37 ` Daniel Lezcano
-1 siblings, 0 replies; 9+ messages in thread
From: Daniel Lezcano @ 2015-11-17 9:37 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Thomas Gleixner, linux-kernel, linux-arm-kernel, Xiubo Li,
Shawn Guo, Sascha Hauer, Stefan Agner
On 11/16/2015 05:34 PM, Arnd Bergmann wrote:
> The ftm_clockevent_init passes the value of "~0UL" into a function
> that takes a 32-bit argument, which drops the upper 32 bits, as
> gcc warns about on ARM64:
>
> clocksource/fsl_ftm_timer.c: In function 'ftm_clockevent_init':
> clocksource/fsl_ftm_timer.c:206:13: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>
> This was obviously unintended behavior, and is easily avoided by
> using '~0u' as the integer literal, because that is 32-bit wide
> on all architectures.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks Arnd for the fix. I will apply it on top of branch.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] clocksource: fsl: avoid harmless 64-bit warnings
@ 2015-11-17 9:37 ` Daniel Lezcano
0 siblings, 0 replies; 9+ messages in thread
From: Daniel Lezcano @ 2015-11-17 9:37 UTC (permalink / raw)
To: linux-arm-kernel
On 11/16/2015 05:34 PM, Arnd Bergmann wrote:
> The ftm_clockevent_init passes the value of "~0UL" into a function
> that takes a 32-bit argument, which drops the upper 32 bits, as
> gcc warns about on ARM64:
>
> clocksource/fsl_ftm_timer.c: In function 'ftm_clockevent_init':
> clocksource/fsl_ftm_timer.c:206:13: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>
> This was obviously unintended behavior, and is easily avoided by
> using '~0u' as the integer literal, because that is 32-bit wide
> on all architectures.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Thanks Arnd for the fix. I will apply it on top of branch.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [tip:timers/urgent] clocksource/fsl: Avoid harmless 64-bit warnings
2015-11-16 16:34 ` Arnd Bergmann
(?)
(?)
@ 2015-11-17 10:36 ` tip-bot for Arnd Bergmann
2015-11-17 11:25 ` Daniel Lezcano
-1 siblings, 1 reply; 9+ messages in thread
From: tip-bot for Arnd Bergmann @ 2015-11-17 10:36 UTC (permalink / raw)
To: linux-tip-commits
Cc: linux-kernel, tglx, mingo, kernel, stefan, arnd, hpa,
daniel.lezcano, shawnguo, Li.Xiubo
Commit-ID: dde7632ed02382e4bac2b57c66ee2285764f2cd7
Gitweb: http://git.kernel.org/tip/dde7632ed02382e4bac2b57c66ee2285764f2cd7
Author: Arnd Bergmann <arnd@arndb.de>
AuthorDate: Mon, 16 Nov 2015 17:34:50 +0100
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Mon, 16 Nov 2015 19:07:08 +0100
clocksource/fsl: Avoid harmless 64-bit warnings
The ftm_clockevent_init passes the value of "~0UL" into a function
that takes a 32-bit argument, which drops the upper 32 bits, as
gcc warns about on ARM64:
clocksource/fsl_ftm_timer.c: In function 'ftm_clockevent_init':
clocksource/fsl_ftm_timer.c:206:13: warning: large integer implicitly truncated to unsigned type [-Woverflow]
This was obviously unintended behavior, and is easily avoided by
using '~0u' as the integer literal, because that is 32-bit wide
on all architectures.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org
Cc: Xiubo Li <Li.Xiubo@freescale.com>
Cc: Shawn Guo <shawnguo@kernel.org>
Cc: Sascha Hauer <kernel@pengutronix.de>
Cc: Stefan Agner <stefan@agner.ch>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: http://lkml.kernel.org/r/3990834.xnjhm37Grs@wuerfel
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
drivers/clocksource/fsl_ftm_timer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clocksource/fsl_ftm_timer.c b/drivers/clocksource/fsl_ftm_timer.c
index 10202f1..517e1c7 100644
--- a/drivers/clocksource/fsl_ftm_timer.c
+++ b/drivers/clocksource/fsl_ftm_timer.c
@@ -203,7 +203,7 @@ static int __init ftm_clockevent_init(unsigned long freq, int irq)
int err;
ftm_writel(0x00, priv->clkevt_base + FTM_CNTIN);
- ftm_writel(~0UL, priv->clkevt_base + FTM_MOD);
+ ftm_writel(~0u, priv->clkevt_base + FTM_MOD);
ftm_reset_counter(priv->clkevt_base);
@@ -230,7 +230,7 @@ static int __init ftm_clocksource_init(unsigned long freq)
int err;
ftm_writel(0x00, priv->clksrc_base + FTM_CNTIN);
- ftm_writel(~0UL, priv->clksrc_base + FTM_MOD);
+ ftm_writel(~0u, priv->clksrc_base + FTM_MOD);
ftm_reset_counter(priv->clksrc_base);
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [tip:timers/urgent] clocksource/fsl: Avoid harmless 64-bit warnings
2015-11-17 10:36 ` [tip:timers/urgent] clocksource/fsl: Avoid " tip-bot for Arnd Bergmann
@ 2015-11-17 11:25 ` Daniel Lezcano
2015-11-17 11:36 ` Thomas Gleixner
0 siblings, 1 reply; 9+ messages in thread
From: Daniel Lezcano @ 2015-11-17 11:25 UTC (permalink / raw)
To: kernel, mingo, tglx, linux-kernel, Li.Xiubo, shawnguo, hpa, arnd,
stefan, linux-tip-commits
On 11/17/2015 11:36 AM, tip-bot for Arnd Bergmann wrote:
> Commit-ID: dde7632ed02382e4bac2b57c66ee2285764f2cd7
> Gitweb: http://git.kernel.org/tip/dde7632ed02382e4bac2b57c66ee2285764f2cd7
> Author: Arnd Bergmann <arnd@arndb.de>
> AuthorDate: Mon, 16 Nov 2015 17:34:50 +0100
> Committer: Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Mon, 16 Nov 2015 19:07:08 +0100
>
> clocksource/fsl: Avoid harmless 64-bit warnings
>
> The ftm_clockevent_init passes the value of "~0UL" into a function
> that takes a 32-bit argument, which drops the upper 32 bits, as
> gcc warns about on ARM64:
>
> clocksource/fsl_ftm_timer.c: In function 'ftm_clockevent_init':
> clocksource/fsl_ftm_timer.c:206:13: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>
> This was obviously unintended behavior, and is easily avoided by
> using '~0u' as the integer literal, because that is 32-bit wide
> on all architectures.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: Xiubo Li <Li.Xiubo@freescale.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Stefan Agner <stefan@agner.ch>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Link: http://lkml.kernel.org/r/3990834.xnjhm37Grs@wuerfel
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
> ---
Ok, I dropped the patch from my tree.
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [tip:timers/urgent] clocksource/fsl: Avoid harmless 64-bit warnings
2015-11-17 11:25 ` Daniel Lezcano
@ 2015-11-17 11:36 ` Thomas Gleixner
2015-11-17 11:43 ` Daniel Lezcano
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Gleixner @ 2015-11-17 11:36 UTC (permalink / raw)
To: Daniel Lezcano
Cc: kernel, mingo, linux-kernel, Li.Xiubo, shawnguo, hpa, arnd,
stefan, linux-tip-commits
On Tue, 17 Nov 2015, Daniel Lezcano wrote:
>
> Ok, I dropped the patch from my tree.
Had it already pushed when I saw your reply.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [tip:timers/urgent] clocksource/fsl: Avoid harmless 64-bit warnings
2015-11-17 11:36 ` Thomas Gleixner
@ 2015-11-17 11:43 ` Daniel Lezcano
2015-11-17 11:45 ` Daniel Lezcano
0 siblings, 1 reply; 9+ messages in thread
From: Daniel Lezcano @ 2015-11-17 11:43 UTC (permalink / raw)
To: Thomas Gleixner
Cc: kernel, mingo, linux-kernel, Li.Xiubo, shawnguo, hpa, arnd,
stefan, linux-tip-commits
On 11/17/2015 12:36 PM, Thomas Gleixner wrote:
> On Tue, 17 Nov 2015, Daniel Lezcano wrote:
>>
>> Ok, I dropped the patch from my tree.
>
> Had it already pushed when I saw your reply.
>
No problem. Better more than less :)
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [tip:timers/urgent] clocksource/fsl: Avoid harmless 64-bit warnings
2015-11-17 11:43 ` Daniel Lezcano
@ 2015-11-17 11:45 ` Daniel Lezcano
0 siblings, 0 replies; 9+ messages in thread
From: Daniel Lezcano @ 2015-11-17 11:45 UTC (permalink / raw)
To: Thomas Gleixner
Cc: kernel, mingo, linux-kernel, shawnguo, hpa, arnd, stefan,
linux-tip-commits
On 11/17/2015 12:43 PM, Daniel Lezcano wrote:
> On 11/17/2015 12:36 PM, Thomas Gleixner wrote:
>> On Tue, 17 Nov 2015, Daniel Lezcano wrote:
>>>
>>> Ok, I dropped the patch from my tree.
>>
>> Had it already pushed when I saw your reply.
>>
>
> No problem. Better more than less :)
Hum, I meant "Better to have too much than not enough".
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-11-17 11:45 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-16 16:34 [PATCH] clocksource: fsl: avoid harmless 64-bit warnings Arnd Bergmann
2015-11-16 16:34 ` Arnd Bergmann
2015-11-17 9:37 ` Daniel Lezcano
2015-11-17 9:37 ` Daniel Lezcano
2015-11-17 10:36 ` [tip:timers/urgent] clocksource/fsl: Avoid " tip-bot for Arnd Bergmann
2015-11-17 11:25 ` Daniel Lezcano
2015-11-17 11:36 ` Thomas Gleixner
2015-11-17 11:43 ` Daniel Lezcano
2015-11-17 11:45 ` Daniel Lezcano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.