All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm/tegra: Enable watchdog support for tegra114 and tegra124.
@ 2015-11-17 10:15 Maarten Lankhorst
       [not found] ` <564AFE51.6060601-FcfepWsj2zOByvU0x3ry2g@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Maarten Lankhorst @ 2015-11-17 10:15 UTC (permalink / raw)
  To: linux-tegra-u79uwXL29TY76Z2rM5mHXA; +Cc: devicetree-u79uwXL29TY76Z2rM5mHXA

This allows the watchdog timer to work on my tegra124.

tegra_wdt specifies: compatible = "nvidia,tegra30-timer";

But the dtsi was only setting tegra20-timer, fix this
by adding tegra30-timer explicitly. This allows
the watchdog to work on my Jetson TK1.

Signed-off-by: Maarten Lankhorst <dev-FcfepWsj2zOByvU0x3ry2g@public.gmane.org>
---
XXX: Should this be Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org to add the missing device on older kernels?

diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
index d845bd1448b5..4e05623acc1e 100644
--- a/arch/arm/boot/dts/tegra114.dtsi
+++ b/arch/arm/boot/dts/tegra114.dtsi
@@ -150,7 +150,7 @@
 	};
 
 	timer@60005000 {
-		compatible = "nvidia,tegra114-timer", "nvidia,tegra20-timer";
+		compatible = "nvidia,tegra114-timer", "nvidia,tegra30-timer", "nvidia,tegra20-timer";
 		reg = <0x60005000 0x400>;
 		interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>,
diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
index 68669f791c8b..1d84b8986807 100644
--- a/arch/arm/boot/dts/tegra124.dtsi
+++ b/arch/arm/boot/dts/tegra124.dtsi
@@ -208,7 +208,7 @@
 	};
 
 	timer@0,60005000 {
-		compatible = "nvidia,tegra124-timer", "nvidia,tegra20-timer";
+		compatible = "nvidia,tegra124-timer", "nvidia,tegra30-timer", "nvidia,tegra20-timer";
 		reg = <0x0 0x60005000 0x0 0x400>;
 		interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
 			     <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>,

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm/tegra: Enable watchdog support for tegra114 and tegra124.
       [not found] ` <564AFE51.6060601-FcfepWsj2zOByvU0x3ry2g@public.gmane.org>
@ 2016-02-12 17:28   ` Thierry Reding
  0 siblings, 0 replies; 2+ messages in thread
From: Thierry Reding @ 2016-02-12 17:28 UTC (permalink / raw)
  To: Maarten Lankhorst
  Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA, devicetree-u79uwXL29TY76Z2rM5mHXA

[-- Attachment #1: Type: text/plain, Size: 918 bytes --]

On Tue, Nov 17, 2015 at 11:15:45AM +0100, Maarten Lankhorst wrote:
> This allows the watchdog timer to work on my tegra124.
> 
> tegra_wdt specifies: compatible = "nvidia,tegra30-timer";
> 
> But the dtsi was only setting tegra20-timer, fix this
> by adding tegra30-timer explicitly. This allows
> the watchdog to work on my Jetson TK1.
> 
> Signed-off-by: Maarten Lankhorst <dev-FcfepWsj2zOByvU0x3ry2g@public.gmane.org>
> ---
> XXX: Should this be Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org to add the missing device on older kernels?

I've applied this with a slightly reworded commit message. I haven't
added a Cc: stable because I don't think this qualifies. There is no
regression that this fixes, or any bugs. It enables a feature, which
is useful, but doesn't need to go to stable in my opinion.

If you or anyone else feels strongly I can be convinced to add it,
though.

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-02-12 17:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-17 10:15 [PATCH] arm/tegra: Enable watchdog support for tegra114 and tegra124 Maarten Lankhorst
     [not found] ` <564AFE51.6060601-FcfepWsj2zOByvU0x3ry2g@public.gmane.org>
2016-02-12 17:28   ` Thierry Reding

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.