From: Ian Abbott <abbotti@mev.co.uk>
To: Ranjith Thangavel <ranjithece24@gmail.com>, gregkh@linuxfoundation.org
Cc: hsweeten@visionengravers.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] comedi: ni_6527: Fix coding style - use BIT macro
Date: Wed, 18 Nov 2015 16:36:17 +0000 [thread overview]
Message-ID: <564CA901.4040104@mev.co.uk> (raw)
In-Reply-To: <1447692975-6515-1-git-send-email-ranjithece24@gmail.com>
On 16/11/15 16:56, Ranjith Thangavel wrote:
> BIT macro is used for defining BIT location instead of
> shifting operator - coding style issue
>
> Signed-off-by: Ranjith Thangavel <ranjithece24@gmail.com>
> ---
> drivers/staging/comedi/drivers/ni_6527.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/ni_6527.c b/drivers/staging/comedi/drivers/ni_6527.c
> index 62a817e..84c62e2 100644
> --- a/drivers/staging/comedi/drivers/ni_6527.c
> +++ b/drivers/staging/comedi/drivers/ni_6527.c
> @@ -42,24 +42,24 @@
> #define NI6527_DO_REG(x) (0x03 + (x))
> #define NI6527_ID_REG 0x06
> #define NI6527_CLR_REG 0x07
> -#define NI6527_CLR_EDGE (1 << 3)
> -#define NI6527_CLR_OVERFLOW (1 << 2)
> -#define NI6527_CLR_FILT (1 << 1)
> -#define NI6527_CLR_INTERVAL (1 << 0)
> +#define NI6527_CLR_EDGE BIT(3)
> +#define NI6527_CLR_OVERFLOW BIT(2)
> +#define NI6527_CLR_FILT BIT(1)
> +#define NI6527_CLR_INTERVAL BIT(0)
> #define NI6527_CLR_IRQS (NI6527_CLR_EDGE | NI6527_CLR_OVERFLOW)
> #define NI6527_CLR_RESET_FILT (NI6527_CLR_FILT | NI6527_CLR_INTERVAL)
> #define NI6527_FILT_INTERVAL_REG(x) (0x08 + (x))
> #define NI6527_FILT_ENA_REG(x) (0x0c + (x))
> #define NI6527_STATUS_REG 0x14
> -#define NI6527_STATUS_IRQ (1 << 2)
> -#define NI6527_STATUS_OVERFLOW (1 << 1)
> -#define NI6527_STATUS_EDGE (1 << 0)
> +#define NI6527_STATUS_IRQ BIT(2)
> +#define NI6527_STATUS_OVERFLOW BIT(1)
> +#define NI6527_STATUS_EDGE BIT(0)
> #define NI6527_CTRL_REG 0x15
> -#define NI6527_CTRL_FALLING (1 << 4)
> -#define NI6527_CTRL_RISING (1 << 3)
> -#define NI6527_CTRL_IRQ (1 << 2)
> -#define NI6527_CTRL_OVERFLOW (1 << 1)
> -#define NI6527_CTRL_EDGE (1 << 0)
> +#define NI6527_CTRL_FALLING BIT(4)
> +#define NI6527_CTRL_RISING BIT(3)
> +#define NI6527_CTRL_IRQ BIT(2)
> +#define NI6527_CTRL_OVERFLOW BIT(1)
> +#define NI6527_CTRL_EDGE BIT(0)
> #define NI6527_CTRL_DISABLE_IRQS 0
> #define NI6527_CTRL_ENABLE_IRQS (NI6527_CTRL_FALLING | \
> NI6527_CTRL_RISING | \
>
Thanks!
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2015-11-18 16:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 16:56 [PATCH] comedi: ni_6527: Fix coding style - use BIT macro Ranjith Thangavel
2015-11-18 16:36 ` Ian Abbott [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-11-14 13:13 Ranjith Thangavel
2015-11-16 14:33 ` Dan Carpenter
2015-11-18 16:02 ` Ian Abbott
2015-11-11 16:14 Ranjith Thangavel
2015-11-12 17:59 ` Ian Abbott
2015-11-09 17:57 Ranjith T
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564CA901.4040104@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ranjithece24@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.