* [PATCH] net: cpsw: Fix ethernet regression for dm814x
@ 2015-11-19 1:27 Tony Lindgren
2015-11-19 7:12 ` Mugunthan V N
2015-11-20 15:47 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Tony Lindgren @ 2015-11-19 1:27 UTC (permalink / raw)
To: David Miller; +Cc: netdev, linux-omap, Mugunthan V N
Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
id to common file") started using of_machine_is_compatible for detecting
type but missed at dm8148 causing Ethernet to stop working.
Let's fix the issue by adding handling for dm814x.
Cc: Mugunthan V N <mugunthanvnm@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
drivers/net/ethernet/ti/cpsw-common.c | 3 +++
1 file changed, 3 insertions(+)
--- a/drivers/net/ethernet/ti/cpsw-common.c
+++ b/drivers/net/ethernet/ti/cpsw-common.c
@@ -78,6 +78,9 @@ static int cpsw_am33xx_cm_get_macid(struct device *dev, u16 offset, int slave,
int ti_cm_get_macid(struct device *dev, int slave, u8 *mac_addr)
{
+ if (of_machine_is_compatible("ti,dm8148"))
+ return cpsw_am33xx_cm_get_macid(dev, 0x630, slave, mac_addr);
+
if (of_machine_is_compatible("ti,am33xx"))
return cpsw_am33xx_cm_get_macid(dev, 0x630, slave, mac_addr);
--
2.6.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: cpsw: Fix ethernet regression for dm814x
2015-11-19 1:27 [PATCH] net: cpsw: Fix ethernet regression for dm814x Tony Lindgren
@ 2015-11-19 7:12 ` Mugunthan V N
2015-11-20 15:47 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: Mugunthan V N @ 2015-11-19 7:12 UTC (permalink / raw)
To: Tony Lindgren, David Miller; +Cc: netdev, linux-omap
On Thursday 19 November 2015 06:57 AM, Tony Lindgren wrote:
> Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
> id to common file") started using of_machine_is_compatible for detecting
> type but missed at dm8148 causing Ethernet to stop working.
>
> Let's fix the issue by adding handling for dm814x.
>
> Cc: Mugunthan V N <mugunthanvnm@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Mugunthnan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: cpsw: Fix ethernet regression for dm814x
@ 2015-11-19 7:12 ` Mugunthan V N
0 siblings, 0 replies; 4+ messages in thread
From: Mugunthan V N @ 2015-11-19 7:12 UTC (permalink / raw)
To: Tony Lindgren, David Miller; +Cc: netdev, linux-omap
On Thursday 19 November 2015 06:57 AM, Tony Lindgren wrote:
> Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
> id to common file") started using of_machine_is_compatible for detecting
> type but missed at dm8148 causing Ethernet to stop working.
>
> Let's fix the issue by adding handling for dm814x.
>
> Cc: Mugunthan V N <mugunthanvnm@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Acked-by: Mugunthnan V N <mugunthanvnm@ti.com>
Regards
Mugunthan V N
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: cpsw: Fix ethernet regression for dm814x
2015-11-19 1:27 [PATCH] net: cpsw: Fix ethernet regression for dm814x Tony Lindgren
2015-11-19 7:12 ` Mugunthan V N
@ 2015-11-20 15:47 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2015-11-20 15:47 UTC (permalink / raw)
To: tony; +Cc: netdev, linux-omap, mugunthanvnm
From: Tony Lindgren <tony@atomide.com>
Date: Wed, 18 Nov 2015 17:27:25 -0800
> Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac
> id to common file") started using of_machine_is_compatible for detecting
> type but missed at dm8148 causing Ethernet to stop working.
>
> Let's fix the issue by adding handling for dm814x.
>
> Cc: Mugunthan V N <mugunthanvnm@ti.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Applied, thank you.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-20 15:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-19 1:27 [PATCH] net: cpsw: Fix ethernet regression for dm814x Tony Lindgren
2015-11-19 7:12 ` Mugunthan V N
2015-11-19 7:12 ` Mugunthan V N
2015-11-20 15:47 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.