All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-fsl-arm] gstreamer1.0-plugins-bad failure
@ 2015-11-18 14:50 Gary Thomas
  2015-11-18 22:40 ` Ann Thornton
  2015-11-23 15:49 ` [meta-fsl-arm] gstreamer1.0-plugins-bad failure Otavio Salvador
  0 siblings, 2 replies; 7+ messages in thread
From: Gary Thomas @ 2015-11-18 14:50 UTC (permalink / raw)
  To: meta-freescale

[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]

The platform specific patch for gstreamer1.0-plugins-bad no
longer applies with the current OE-core master (after update
to gstreamer-1.6.1).
   ERROR: Command Error: exit status: 1  Output:
   Applying patch 0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h.patch
   patching file gst-libs/gst/base/Makefile.am
   patching file gst-libs/gst/video/Makefile.am
   Hunk #1 FAILED at 19.
   1 out of 1 hunk FAILED -- rejects in file gst-libs/gst/video/Makefile.am
   Patch 0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h.patch does not apply (enforce with -f)
   ERROR: Function failed: patch_do_patch
   ERROR: Logfile of failure stored in: 
/local/p0382-cutting-edge_2014-11-21/tmp/work/cortexa9hf-vfp-neon-mx6qdl-amltd-linux-gnueabi/gstreamer1.0-plugins-bad/1.6.1-r0/temp/log.do_patch.24379
   ERROR: Task 1 (/local/poky-cutting-edge/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.6.1.bb, do_patch) failed with exit code '1'

I adjusted the patch but I'm not comfortable replacing the
boilerplate as it's attributed to Mingke Wang <mingke.wang@freescale.com>
Perhaps someone at Freescale can fix this properly?

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

[-- Attachment #2: 0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h.patch --]
[-- Type: text/x-patch, Size: 1580 bytes --]

Index: gst-plugins-bad-1.6.1/gst-libs/gst/base/Makefile.am
===================================================================
--- gst-plugins-bad-1.6.1.orig/gst-libs/gst/base/Makefile.am
+++ gst-plugins-bad-1.6.1/gst-libs/gst/base/Makefile.am
@@ -6,11 +6,12 @@ libgstbadbase_@GST_API_VERSION@_la_SOURC
 libgstbadbase_@GST_API_VERSION@_la_CFLAGS = $(GST_CFLAGS) \
 	-DGST_USE_UNSTABLE_API
 
+libgstbadbase_@GST_API_VERSION@includedir = $(includedir)/gstreamer-@GST_API_VERSION@/gst/base
+libgstbadbase_@GST_API_VERSION@include_HEADERS = \
+        gstaggregator.h
+
 libgstbadbase_@GST_API_VERSION@_la_LIBADD = $(GST_LIBS)
 libgstbadbase_@GST_API_VERSION@_la_LDFLAGS = $(GST_LIB_LDFLAGS) $(GST_ALL_LDFLAGS) $(GST_LT_LDFLAGS)
 
-noinst_HEADERS =	\
-	gstaggregator.h
-
 EXTRA_DIST = 
 
Index: gst-plugins-bad-1.6.1/gst-libs/gst/video/Makefile.am
===================================================================
--- gst-plugins-bad-1.6.1.orig/gst-libs/gst/video/Makefile.am
+++ gst-plugins-bad-1.6.1/gst-libs/gst/video/Makefile.am
@@ -16,6 +16,11 @@ libgstbadvideo_@GST_API_VERSION@_la_CFLA
 	$(GST_PLUGINS_BASE_CFLAGS) \
 	$(GST_BASE_CFLAGS)
 
+libgstbadvideo_@GST_API_VERSION@includedir = $(includedir)/gstreamer-@GST_API_VERSION@/gst/video
+libgstbadvideo_@GST_API_VERSION@include_HEADERS = \
+        gstvideoaggregatorpad.h \
+        gstvideoaggregator.h
+
 libgstbadvideo_@GST_API_VERSION@_la_LIBADD = \
 	$(top_builddir)/gst-libs/gst/base/libgstbadbase-$(GST_API_VERSION).la \
 	$(GST_PLUGINS_BASE_LIBS) -lgstvideo-$(GST_API_VERSION) \

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [meta-fsl-arm] gstreamer1.0-plugins-bad failure
  2015-11-18 14:50 [meta-fsl-arm] gstreamer1.0-plugins-bad failure Gary Thomas
@ 2015-11-18 22:40 ` Ann Thornton
  2015-11-19  9:17   ` Carlos Rafael Giani
  2015-11-23 15:49 ` [meta-fsl-arm] gstreamer1.0-plugins-bad failure Otavio Salvador
  1 sibling, 1 reply; 7+ messages in thread
From: Ann Thornton @ 2015-11-18 22:40 UTC (permalink / raw)
  To: meta-freescale

[-- Attachment #1: Type: text/plain, Size: 1739 bytes --]


The problem is the 
0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h.patch in 
meta-fsl-arm/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend 
You can edit that file or BBMASK it out to get around the problem.  It 
happens because that patch is already in gstreamer1.0-plugins-bad 
version 1.6.

Ann Thornton

On 11/18/2015 8:50 AM, Gary Thomas wrote:
> The platform specific patch for gstreamer1.0-plugins-bad no
> longer applies with the current OE-core master (after update
> to gstreamer-1.6.1).
>   ERROR: Command Error: exit status: 1  Output:
>   Applying patch 
> 0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h.patch
>   patching file gst-libs/gst/base/Makefile.am
>   patching file gst-libs/gst/video/Makefile.am
>   Hunk #1 FAILED at 19.
>   1 out of 1 hunk FAILED -- rejects in file 
> gst-libs/gst/video/Makefile.am
>   Patch 
> 0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h.patch does 
> not apply (enforce with -f)
>   ERROR: Function failed: patch_do_patch
>   ERROR: Logfile of failure stored in: 
> /local/p0382-cutting-edge_2014-11-21/tmp/work/cortexa9hf-vfp-neon-mx6qdl-amltd-linux-gnueabi/gstreamer1.0-plugins-bad/1.6.1-r0/temp/log.do_patch.24379
>   ERROR: Task 1 
> (/local/poky-cutting-edge/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.6.1.bb, 
> do_patch) failed with exit code '1'
>
> I adjusted the patch but I'm not comfortable replacing the
> boilerplate as it's attributed to Mingke Wang <mingke.wang@freescale.com>
> Perhaps someone at Freescale can fix this properly?
>
>
>


-- 
Ann Thornton

/Microcontrollers Software and Applications
Freescale Semiconductors
email: Ann.Thornton@freescale.com/

[-- Attachment #2: Type: text/html, Size: 2780 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [meta-fsl-arm] gstreamer1.0-plugins-bad failure
  2015-11-18 22:40 ` Ann Thornton
@ 2015-11-19  9:17   ` Carlos Rafael Giani
  2015-11-19 12:17     ` Otavio Salvador
  0 siblings, 1 reply; 7+ messages in thread
From: Carlos Rafael Giani @ 2015-11-19  9:17 UTC (permalink / raw)
  To: meta-freescale

[-- Attachment #1: Type: text/plain, Size: 2056 bytes --]

Actually, it isn't. The whole point of this patch is that the 
gst1.0-fsl-plugin package needs headers from -bad which aren't public 
(yet), so they aren't installed. The patch makes sure they are.

On 2015-11-18 23:40, Ann Thornton wrote:
>
> The problem is the 
> 0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h.patch in 
> meta-fsl-arm/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_%.bbappend 
> You can edit that file or BBMASK it out to get around the problem.  It 
> happens because that patch is already in gstreamer1.0-plugins-bad 
> version 1.6.
>
> Ann Thornton
>
> On 11/18/2015 8:50 AM, Gary Thomas wrote:
>> The platform specific patch for gstreamer1.0-plugins-bad no
>> longer applies with the current OE-core master (after update
>> to gstreamer-1.6.1).
>>   ERROR: Command Error: exit status: 1  Output:
>>   Applying patch 
>> 0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h.patch
>>   patching file gst-libs/gst/base/Makefile.am
>>   patching file gst-libs/gst/video/Makefile.am
>>   Hunk #1 FAILED at 19.
>>   1 out of 1 hunk FAILED -- rejects in file 
>> gst-libs/gst/video/Makefile.am
>>   Patch 
>> 0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h.patch does 
>> not apply (enforce with -f)
>>   ERROR: Function failed: patch_do_patch
>>   ERROR: Logfile of failure stored in: 
>> /local/p0382-cutting-edge_2014-11-21/tmp/work/cortexa9hf-vfp-neon-mx6qdl-amltd-linux-gnueabi/gstreamer1.0-plugins-bad/1.6.1-r0/temp/log.do_patch.24379
>>   ERROR: Task 1 
>> (/local/poky-cutting-edge/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.6.1.bb, 
>> do_patch) failed with exit code '1'
>>
>> I adjusted the patch but I'm not comfortable replacing the
>> boilerplate as it's attributed to Mingke Wang 
>> <mingke.wang@freescale.com>
>> Perhaps someone at Freescale can fix this properly?
>>
>>
>>
>
>
> -- 
> Ann Thornton
>
> /Microcontrollers Software and Applications
> Freescale Semiconductors
> email: Ann.Thornton@freescale.com/
>
>


[-- Attachment #2: Type: text/html, Size: 3563 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [meta-fsl-arm] gstreamer1.0-plugins-bad failure
  2015-11-19  9:17   ` Carlos Rafael Giani
@ 2015-11-19 12:17     ` Otavio Salvador
  2015-11-24 11:11       ` Otavio Salvador
  0 siblings, 1 reply; 7+ messages in thread
From: Otavio Salvador @ 2015-11-19 12:17 UTC (permalink / raw)
  To: Carlos Rafael Giani; +Cc: meta-freescale

On Thu, Nov 19, 2015 at 7:17 AM, Carlos Rafael Giani
<dv@pseudoterminal.org> wrote:
> Actually, it isn't. The whole point of this patch is that the
> gst1.0-fsl-plugin package needs headers from -bad which aren't public (yet),
> so they aren't installed. The patch makes sure they are.

Agreed; can someone send a formal patch to fix it?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [meta-fsl-arm] gstreamer1.0-plugins-bad failure
  2015-11-18 14:50 [meta-fsl-arm] gstreamer1.0-plugins-bad failure Gary Thomas
  2015-11-18 22:40 ` Ann Thornton
@ 2015-11-23 15:49 ` Otavio Salvador
  1 sibling, 0 replies; 7+ messages in thread
From: Otavio Salvador @ 2015-11-23 15:49 UTC (permalink / raw)
  To: Gary Thomas; +Cc: meta-freescale

On Wed, Nov 18, 2015 at 12:50 PM, Gary Thomas <gary@mlbassoc.com> wrote:
> The platform specific patch for gstreamer1.0-plugins-bad no
> longer applies with the current OE-core master (after update
> to gstreamer-1.6.1).
>   ERROR: Command Error: exit status: 1  Output:
>   Applying patch
> 0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h.patch
>   patching file gst-libs/gst/base/Makefile.am
>   patching file gst-libs/gst/video/Makefile.am
>   Hunk #1 FAILED at 19.
>   1 out of 1 hunk FAILED -- rejects in file gst-libs/gst/video/Makefile.am
>   Patch 0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h.patch does
> not apply (enforce with -f)
>   ERROR: Function failed: patch_do_patch
>   ERROR: Logfile of failure stored in:
> /local/p0382-cutting-edge_2014-11-21/tmp/work/cortexa9hf-vfp-neon-mx6qdl-amltd-linux-gnueabi/gstreamer1.0-plugins-bad/1.6.1-r0/temp/log.do_patch.24379
>   ERROR: Task 1
> (/local/poky-cutting-edge/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.6.1.bb,
> do_patch) failed with exit code '1'
>
> I adjusted the patch but I'm not comfortable replacing the
> boilerplate as it's attributed to Mingke Wang <mingke.wang@freescale.com>
> Perhaps someone at Freescale can fix this properly?

Can you prepare a formal patch for this?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [meta-fsl-arm] gstreamer1.0-plugins-bad failure
  2015-11-19 12:17     ` Otavio Salvador
@ 2015-11-24 11:11       ` Otavio Salvador
  2015-11-24 11:33         ` [meta-fsl-arm][PATCH] gstreamer1.0-plugins-bad: Fix patch for GStreamer 1.6 Carlos Rafael Giani
  0 siblings, 1 reply; 7+ messages in thread
From: Otavio Salvador @ 2015-11-24 11:11 UTC (permalink / raw)
  To: Otavio Salvador; +Cc: meta-freescale

On Thu, Nov 19, 2015 at 10:17 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> On Thu, Nov 19, 2015 at 7:17 AM, Carlos Rafael Giani
> <dv@pseudoterminal.org> wrote:
>> Actually, it isn't. The whole point of this patch is that the
>> gst1.0-fsl-plugin package needs headers from -bad which aren't public (yet),
>> so they aren't installed. The patch makes sure they are.
>
> Agreed; can someone send a formal patch to fix it?

Ping? I will end removing the patch and all recipes which depends on
it. master is broken for a week and we need this fixed ASAP.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [meta-fsl-arm][PATCH] gstreamer1.0-plugins-bad: Fix patch for GStreamer 1.6
  2015-11-24 11:11       ` Otavio Salvador
@ 2015-11-24 11:33         ` Carlos Rafael Giani
  0 siblings, 0 replies; 7+ messages in thread
From: Carlos Rafael Giani @ 2015-11-24 11:33 UTC (permalink / raw)
  To: meta-freescale

Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
---
 ...CH-install-gstaggregator-and-gstvideoaggregator-h.patch | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h.patch b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h.patch
index 018826f..52e2d9a 100755
--- a/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h.patch
+++ b/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad/0001-PATCH-install-gstaggregator-and-gstvideoaggregator-h.patch
@@ -39,7 +39,7 @@ new mode 100755
 index 4f0f09f..3c5da6b
 --- a/gst-libs/gst/video/Makefile.am
 +++ b/gst-libs/gst/video/Makefile.am
-@@ -19,8 +19,13 @@ libgstbadvideo_@GST_API_VERSION@_la_CFLAGS = \
+@@ -16,11 +16,14 @@ libgstbadvideo_@GST_API_VERSION@_la_CFLAGS = \
  	$(GST_PLUGINS_BASE_CFLAGS) \
  	$(GST_BASE_CFLAGS)
  
@@ -48,12 +48,14 @@ index 4f0f09f..3c5da6b
 +        gstvideoaggregatorpad.h \
 +        gstvideoaggregator.h
 +
- libgstbadvideo_@GST_API_VERSION@_la_LIBADD = $(GST_BASE_LIBS) $(GST_LIBS) $(ORC_LIBS) -lgstvideo-$(GST_API_VERSION)\
- 	$(top_builddir)/gst-libs/gst/base/libgstbadbase-$(GST_API_VERSION).la $(LIBM)
- libgstbadvideo_@GST_API_VERSION@_la_LDFLAGS = $(GST_LIB_LDFLAGS) $(GST_ALL_LDFLAGS) $(GST_LT_LDFLAGS)
+ libgstbadvideo_@GST_API_VERSION@_la_LIBADD = \
+ 	$(top_builddir)/gst-libs/gst/base/libgstbadbase-$(GST_API_VERSION).la \
+ 	$(GST_PLUGINS_BASE_LIBS) -lgstvideo-$(GST_API_VERSION) \
+ 	$(GST_BASE_LIBS) $(GST_LIBS) $(ORC_LIBS) $(LIBM)
  
--noinst_HEADERS = gstcms.h videoconvert.h gstvideoaggregatorpad.h gstvideoaggregator.h
-+noinst_HEADERS = gstcms.h videoconvert.h 
+ libgstbadvideo_@GST_API_VERSION@_la_LDFLAGS = $(GST_LIB_LDFLAGS) $(GST_ALL_LDFLAGS) $(GST_LT_LDFLAGS)
+-
+-noinst_HEADERS = gstvideoaggregatorpad.h gstvideoaggregator.h
 -- 
 1.7.9.5
 
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2015-11-24 11:33 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-18 14:50 [meta-fsl-arm] gstreamer1.0-plugins-bad failure Gary Thomas
2015-11-18 22:40 ` Ann Thornton
2015-11-19  9:17   ` Carlos Rafael Giani
2015-11-19 12:17     ` Otavio Salvador
2015-11-24 11:11       ` Otavio Salvador
2015-11-24 11:33         ` [meta-fsl-arm][PATCH] gstreamer1.0-plugins-bad: Fix patch for GStreamer 1.6 Carlos Rafael Giani
2015-11-23 15:49 ` [meta-fsl-arm] gstreamer1.0-plugins-bad failure Otavio Salvador

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.