All of lore.kernel.org
 help / color / mirror / Atom feed
* [RESEND PATCH] char: ipmi: Drop owner assignment from i2c_driver
@ 2015-11-19  3:56 Krzysztof Kozlowski
  2015-11-19 13:26 ` [Openipmi-developer] " Corey Minyard
  0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2015-11-19  3:56 UTC (permalink / raw)
  To: Corey Minyard, openipmi-developer, linux-kernel; +Cc: Krzysztof Kozlowski

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

---

The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
 drivers/char/ipmi/ipmi_ssif.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
index 90e624662257..5f1c3d08ba65 100644
--- a/drivers/char/ipmi/ipmi_ssif.c
+++ b/drivers/char/ipmi/ipmi_ssif.c
@@ -1959,7 +1959,6 @@ MODULE_DEVICE_TABLE(i2c, ssif_id);
 static struct i2c_driver ssif_i2c_driver = {
 	.class		= I2C_CLASS_HWMON,
 	.driver		= {
-		.owner			= THIS_MODULE,
 		.name			= DEVICE_NAME
 	},
 	.probe		= ssif_probe,
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Openipmi-developer] [RESEND PATCH] char: ipmi: Drop owner assignment from i2c_driver
  2015-11-19  3:56 [RESEND PATCH] char: ipmi: Drop owner assignment from i2c_driver Krzysztof Kozlowski
@ 2015-11-19 13:26 ` Corey Minyard
  0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2015-11-19 13:26 UTC (permalink / raw)
  To: Krzysztof Kozlowski, openipmi-developer, linux-kernel

Ok, got it this time, queued for 4.5.

Thanks,

-corey

On 11/18/2015 09:56 PM, Krzysztof Kozlowski wrote:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
>  drivers/char/ipmi/ipmi_ssif.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index 90e624662257..5f1c3d08ba65 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -1959,7 +1959,6 @@ MODULE_DEVICE_TABLE(i2c, ssif_id);
>  static struct i2c_driver ssif_i2c_driver = {
>  	.class		= I2C_CLASS_HWMON,
>  	.driver		= {
> -		.owner			= THIS_MODULE,
>  		.name			= DEVICE_NAME
>  	},
>  	.probe		= ssif_probe,


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-11-19 13:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-19  3:56 [RESEND PATCH] char: ipmi: Drop owner assignment from i2c_driver Krzysztof Kozlowski
2015-11-19 13:26 ` [Openipmi-developer] " Corey Minyard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.