From: Chanwoo Choi <cw00.choi@samsung.com>
To: Felipe Balbi <balbi@ti.com>, Tony Lindgren <tony@atomide.com>,
Rob Herring <robh+dt@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] arm: boot: beaglex15: pass correct interrupt
Date: Fri, 20 Nov 2015 14:39:33 +0900 [thread overview]
Message-ID: <564EB215.5080209@samsung.com> (raw)
In-Reply-To: <1447350781-20649-3-git-send-email-balbi@ti.com>
Hi,
On 2015년 11월 13일 02:53, Felipe Balbi wrote:
> According to latest schematics [1], GPIO_1/VBUSDET
> on TPS659038 is tied to AM57x GPIO4_21. We can use
> that as a VBUS interrupt, instead of relying on
> PMIC's VBUS interrupts which don't seem to be firing
> on x15 at all.
>
> A follow up patch will add support for using this
> GPIO-based interrupt mechanism for notifying about
> VBUS.
>
> [1] https://github.com/beagleboard/beagleboard-x15/blob/master/BeagleBoard-X15_RevA2.pdf
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/boot/dts/am57xx-beagle-x15.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> index 6f3a1a7ec5f9..5e47162f7883 100644
> --- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
> +++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> @@ -560,6 +560,7 @@
> extcon_usb2: tps659038_usb {
> compatible = "ti,palmas-usb-vid";
> ti,enable-vbus-detection;
> + interrupts-extended = <&gpio4 21 IRQ_TYPE_EDGE_RISING>;
> };
>
> };
>
I check the schematic file. The GPIO4_21 pin is connected as following:
- GPIO_1/VBUSDET -> PMIC_VBUS_DET -> VBUS_DET -> AM5728 GPIO4_21 pin
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
WARNING: multiple messages have this Message-ID (diff)
From: cw00.choi@samsung.com (Chanwoo Choi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm: boot: beaglex15: pass correct interrupt
Date: Fri, 20 Nov 2015 14:39:33 +0900 [thread overview]
Message-ID: <564EB215.5080209@samsung.com> (raw)
In-Reply-To: <1447350781-20649-3-git-send-email-balbi@ti.com>
Hi,
On 2015? 11? 13? 02:53, Felipe Balbi wrote:
> According to latest schematics [1], GPIO_1/VBUSDET
> on TPS659038 is tied to AM57x GPIO4_21. We can use
> that as a VBUS interrupt, instead of relying on
> PMIC's VBUS interrupts which don't seem to be firing
> on x15 at all.
>
> A follow up patch will add support for using this
> GPIO-based interrupt mechanism for notifying about
> VBUS.
>
> [1] https://github.com/beagleboard/beagleboard-x15/blob/master/BeagleBoard-X15_RevA2.pdf
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
> arch/arm/boot/dts/am57xx-beagle-x15.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/am57xx-beagle-x15.dts b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> index 6f3a1a7ec5f9..5e47162f7883 100644
> --- a/arch/arm/boot/dts/am57xx-beagle-x15.dts
> +++ b/arch/arm/boot/dts/am57xx-beagle-x15.dts
> @@ -560,6 +560,7 @@
> extcon_usb2: tps659038_usb {
> compatible = "ti,palmas-usb-vid";
> ti,enable-vbus-detection;
> + interrupts-extended = <&gpio4 21 IRQ_TYPE_EDGE_RISING>;
> };
>
> };
>
I check the schematic file. The GPIO4_21 pin is connected as following:
- GPIO_1/VBUSDET -> PMIC_VBUS_DET -> VBUS_DET -> AM5728 GPIO4_21 pin
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
next prev parent reply other threads:[~2015-11-20 5:39 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 17:52 [PATCH 0/2] arm: beaglex15: fix USB Gadget Felipe Balbi
2015-11-12 17:52 ` Felipe Balbi
2015-11-12 17:52 ` Felipe Balbi
2015-11-12 17:53 ` [PATCH 1/2] arm: boot: dts: beaglex15: Remove ID GPIO Felipe Balbi
2015-11-12 17:53 ` Felipe Balbi
2015-11-12 17:53 ` Felipe Balbi
2015-11-12 17:53 ` [PATCH 2/2] arm: boot: beaglex15: pass correct interrupt Felipe Balbi
2015-11-12 17:53 ` Felipe Balbi
2015-11-12 17:53 ` Felipe Balbi
2015-11-20 5:39 ` Chanwoo Choi [this message]
2015-11-20 5:39 ` Chanwoo Choi
2015-11-20 5:39 ` Chanwoo Choi
[not found] ` <564F4D90.4050305@gmail.com>
2015-11-20 16:55 ` Chanwoo Choi
2015-11-20 16:55 ` Chanwoo Choi
2015-11-20 16:55 ` Chanwoo Choi
2015-11-25 19:01 ` Tony Lindgren
2015-11-25 19:01 ` Tony Lindgren
2015-11-25 19:01 ` Tony Lindgren
2015-11-12 17:54 ` [PATCH 0/2] arm: beaglex15: fix USB Gadget Felipe Balbi
2015-11-12 17:54 ` Felipe Balbi
2015-11-12 17:54 ` Felipe Balbi
2015-11-12 17:57 ` [PATCH] extcon: palmas: add support for using VBUSDET output Felipe Balbi
2015-11-12 17:57 ` Felipe Balbi
2015-11-12 17:57 ` Felipe Balbi
2015-11-20 5:33 ` Chanwoo Choi
2015-11-20 5:33 ` Chanwoo Choi
2015-11-20 5:33 ` Chanwoo Choi
2015-11-20 5:44 ` Chanwoo Choi
2015-11-20 5:44 ` Chanwoo Choi
2015-11-20 5:44 ` Chanwoo Choi
2015-11-20 14:37 ` Felipe Balbi
2015-11-20 14:37 ` Felipe Balbi
2015-11-20 14:37 ` Felipe Balbi
2015-11-20 15:05 ` Chanwoo Choi
2015-11-20 15:05 ` Chanwoo Choi
2015-11-20 15:05 ` Chanwoo Choi
2015-11-20 16:37 ` Chanwoo Choi
2015-11-20 16:37 ` Chanwoo Choi
2015-11-20 16:37 ` Chanwoo Choi
2015-11-20 16:34 ` Chanwoo Choi
2015-11-20 16:34 ` Chanwoo Choi
2015-11-20 16:34 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564EB215.5080209@samsung.com \
--to=cw00.choi@samsung.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.