All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
@ 2015-11-19 22:29 Vinay Belgaumkar
  2015-11-20 16:20 ` Tvrtko Ursulin
  0 siblings, 1 reply; 19+ messages in thread
From: Vinay Belgaumkar @ 2015-11-19 22:29 UTC (permalink / raw)
  To: intel-gfx; +Cc: Vinay Belgaumkar

These tests exercise the userptr ioctl to create shared buffers
between CPU and GPU. They contain error and normal usage scenarios.
They also contain a couple of stress tests which copy buffers between
CPU and GPU. These tests rely on the softpin patch in order to pin buffers
to a certain VA.

Caveat: These tests were designed to run on 64-bit system. Future work
includes adding logic to ensure these tests can run on 32-bit systems with
PPGTT support. Some tests are currently disabled for 32-bit systems for that
reason.

v2: Added cc and signed-off-by fields

v3: Fixed review comments, added helper functions. Removed userptr error
scenarios covered by existing userptr tests. Modified stress test to have
100K buffers, it now runs for ~30 mins, checks every element has been written
to correctly, and pins buffers at different VMAs.

v4: Changed name to gem_softpin

Cc: Michel Thierry <michel.thierry@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
 tests/.gitignore       |    1 +
 tests/Makefile.sources |    1 +
 tests/gem_softpin.c    | 1252 ++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 1254 insertions(+)
 create mode 100644 tests/gem_softpin.c

diff --git a/tests/.gitignore b/tests/.gitignore
index 80af9a7..424870b 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -21,6 +21,7 @@ gem_bad_blit
 gem_bad_length
 gem_bad_reloc
 gem_basic
+gem_softpin
 gem_caching
 gem_close_race
 gem_concurrent_all
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 8fb2de8..2008d4a 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -11,6 +11,7 @@ TESTS_progs_M = \
 	drv_hangman \
 	gem_bad_reloc \
 	gem_basic \
+	gem_softpin \
 	gem_caching \
 	gem_close_race \
 	gem_concurrent_blit \
diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
new file mode 100644
index 0000000..aed607c
--- /dev/null
+++ b/tests/gem_softpin.c
@@ -0,0 +1,1252 @@
+/*
+ * Copyright © 2015 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ * Authors:
+ *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
+      Thomas Daniel <thomas.daniel@intel.com>
+ *
+ */
+
+#include <unistd.h>
+#include <stdlib.h>
+#include <stdint.h>
+#include <stdio.h>
+#include <string.h>
+#include <fcntl.h>
+#include <inttypes.h>
+#include <errno.h>
+#include <sys/stat.h>
+#include <sys/ioctl.h>
+#include <sys/time.h>
+#include <malloc.h>
+#include "drm.h"
+#include "ioctl_wrappers.h"
+#include "drmtest.h"
+#include "intel_chipset.h"
+#include "intel_io.h"
+#include "i915_drm.h"
+#include <assert.h>
+#include <sys/wait.h>
+#include <sys/ipc.h>
+#include <sys/shm.h>
+#include "igt_kms.h"
+#include <inttypes.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+
+#define OBJECT_SIZE 16384
+#define BO_SIZE 4 * 4096
+#define MULTIPAGE_BO_SIZE 4 * BO_SIZE
+#define STORE_BATCH_BUFFER_SIZE 6
+#define STRESS_BATCH_BUFFER_SIZE 5
+#define EXEC_OBJECT_PINNED	(1<<4)
+#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
+#define SHARED_BUFFER_SIZE 4096
+#define NUM_EXEC_OBJECTS 2
+
+typedef struct drm_i915_gem_userptr i915_gem_userptr;
+
+static void gem_create_userptr_struct(i915_gem_userptr*, void* ptr, __u64 size, bool read_only);
+static void *create_mem_buffer(__u64 size);
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
+static void gem_basic_test(void);
+static void gem_pin_invalid_vma_test(void);
+static void gem_pin_overlap_test(void);
+static void gem_shmem_test(void);
+static void gem_pin_high_address_test(void);
+static void gem_pin_mmap_anonymous_test(void);
+static void gem_pin_mmap_file_test(void);
+
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr* userptr)
+{
+	int ret;
+
+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
+
+	if (ret)
+		ret = errno;
+
+	return ret;
+}
+
+static void gem_create_userptr_struct(i915_gem_userptr *userptr, void* ptr, __u64 size, bool read_only)
+{
+	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
+
+	userptr->user_ptr = (uintptr_t)ptr;
+	userptr->user_size = size;
+	userptr->flags = I915_USERPTR_UNSYNCHRONIZED;
+
+	if (read_only)
+		userptr->flags |= I915_USERPTR_READ_ONLY;
+}
+
+/*  Creates a 4K aligned CPU buffer 
+ *  @size - size of buffer
+ *  RETURNS pointer to buffer of @size
+*/
+
+static void* create_mem_buffer(__u64 size)
+{
+	void* addr;
+	int ret;
+
+	ret = posix_memalign(&addr, 4096, size);
+	igt_assert(ret == 0);
+
+	return addr;
+}
+
+/*  setup_exec_obj - populate exec object
+ * @exec - exec object
+ * @handle - handle to gem buffer
+ * flags - any flags
+ * offset - requested VMA
+ */
+static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec, __u32 handle, __u32 flags, __u64 offset)
+{
+	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
+	exec->handle = handle;
+	exec->flags = flags;
+	exec->offset = offset;
+}
+
+/*  
+ * gem_store_data_svm - populate batch buffer with MI_STORE_DWORD_IMM command
+ * @fd: drm file descriptor
+ * @buf: batch buffer
+ * @buffer_size: size of buffer
+ * @addr: destination Virtual address
+ * @data: data to be store at destination
+ * @end: whether to end batch buffer or not
+ */
+static int gem_store_data_svm(int fd, uint32_t* cmd_buf, uint64_t vaddr,
+			      uint32_t data, bool end)
+{
+	int i = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
+	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
+
+	cmd_buf[i++] = data;
+	if (end){ 
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	return (i * sizeof(uint32_t));
+}
+
+/*  
+ * gem_store_data - populate batch buffer with MI_STORE_DWORD_IMM command
+ * This one fills up reloc buffer as well 
+ * @fd: drm file descriptor
+ * @buf: batch buffer
+ * @buffer_size: size of buffer
+ * @addr: destination Virtual address
+ * @data: data to be store at destination
+ * @reloc - relocation entry
+ * @end: whether to end batch buffer or not
+ */
+
+static int gem_store_data(int fd, uint32_t* cmd_buf,
+			      uint32_t handle, uint32_t data,
+			      struct drm_i915_gem_relocation_entry *reloc,
+			      bool end)
+{
+	int i = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 because reloc is needed */
+	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 because reloc is needed */
+	reloc->offset = 1 * sizeof(uint32_t);
+	reloc->delta = 0;
+	reloc->target_handle = handle;
+	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
+	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
+	reloc->presumed_offset = 0;
+	reloc++;
+	cmd_buf[i++] = data;
+	if (end){ 
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	return (i * sizeof(uint32_t));
+}
+
+/* Helper function for filling execbuffer struct */
+static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf, struct drm_i915_gem_exec_object2 *exec_object, 
+					int ring, int buffer_count, int batch_length) 
+{
+	execbuf->buffers_ptr = (uintptr_t)exec_object;
+	execbuf->buffer_count = buffer_count;
+	execbuf->batch_start_offset = 0;
+	execbuf->batch_len = batch_length;
+	execbuf->cliprects_ptr = 0;
+	execbuf->num_cliprects = 0;
+	execbuf->DR1 = 0;
+	execbuf->DR4 = 0;
+	execbuf->flags = ring;
+	i915_execbuffer2_set_context_id(*execbuf, 0);
+	execbuf->rsvd2 = 0;
+}
+
+/* Helper function for exec and sync functions */
+static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf, uint32_t batch_buf_handle)
+{
+	gem_execbuf(fd, execbuf);
+	gem_sync(fd, batch_buf_handle); 
+}
+
+/*  gem_basic_test - This test will create a shared buffer, and create a command
+ *  for GPU to write data in it
+ *  CPU will read and make sure expected value is obtained
+ *  @valid_shared_buffer - whether test with valid malloc'd buffer or not
+
+   if (valid_shared_buffer == true)
+   Malloc a 4K buffer
+   Share buffer with with GPU by using userptr ioctl
+   Create batch buffer to write DATA to first dword of buffer
+   Use 0x1000 address as destination address in batch buffer
+   Set EXEC_OBJECT_PINNED flag in exec object
+   Set 'offset' in exec object to 0x1000
+   Submit execbuffer
+   Verify value of first DWORD in shared buffer matches DATA
+
+   if (valid_shared_buffer == false)
+   Declare null buffer
+   Call Userptr ioctl with null buffer
+   Run Basic Test
+   Test should fail at submit execbuffer
+*/
+static void gem_basic_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t* shared_buffer = NULL;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	
+	/* share with GPU */
+	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
+	ret = gem_call_userptr_ioctl(fd, &userptr);
+	igt_assert_eq(ret, 0);
+
+	/* Get handle for shared buffer */
+	shared_buf_handle = userptr.handle;
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	igt_assert_lte(len, STORE_BATCH_BUFFER_SIZE * 4);
+
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = 0;
+	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
+		ring = I915_EXEC_BLT;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		      "\nCPU read does not match GPU write, expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+}
+
+/*  gem_multiple_process_test - Run basic test simultaneously with multiple processes
+*   This will test pinning same VA separately in each process
+
+    fork();
+    Execute basic test in parent/child processes
+
+*/
+
+#define MAX_NUM_PROCESSES 10
+
+static void gem_multiple_process_test(void)
+{
+	igt_fork(child, MAX_NUM_PROCESSES) {
+		gem_basic_test();
+	}
+	igt_waitchildren();
+}
+
+
+/* gem_repin_test
+ * This test tries to repin a buffer at a previously pinned vma 
+ * from a different execbuf. 
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000 VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+
+ * Create second shared buffer
+ * Follow all steps above
+ * Execpt, for offset, use VMA of first buffer above 
+ * Submit execbuffer
+ * Verify value of first DWORD in second shared buffer matches DATA
+*/
+
+static void gem_repin_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd, ret;
+	uint32_t* shared_buffer = NULL;
+	uint32_t* shared_buffer1 = NULL;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	/* Create gem object */
+	fd = drm_open_driver(DRIVER_INTEL);
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE);
+	shared_buffer[0] = 0x0;
+	shared_buffer1[0] = 0x0;
+
+	/* share with GPU */
+	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
+	ret = gem_call_userptr_ioctl(fd, &userptr);
+	igt_assert_eq(ret, 0);
+
+	//gem_create_userptr_struct(&userptr1, shared_buffer1, BO_SIZE * 2, false); 
+	gem_create_userptr_struct(&userptr1, shared_buffer1, BO_SIZE, false);
+	ret = gem_call_userptr_ioctl(fd, &userptr1);
+	igt_assert_eq(ret, 0);
+
+	/* Get handle for shared buffer */
+	shared_buf_handle = userptr.handle;
+	shared_buf_handle1 = userptr1.handle;
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = 0;
+	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
+		ring = I915_EXEC_BLT;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	igt_assert(*shared_buffer == data);
+
+	/* Second buffer */
+	/* create command buffer with write command */
+	pinning_offset = exec_object2[0].offset;
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	/* Pin at shared_buffer, not shared_buffer1 */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle1, EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = 0;
+	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
+		ring = I915_EXEC_BLT;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	igt_assert(*shared_buffer1 == data);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+
+/** gem_repin_overlap_test
+ *  This test will attempt to pin two buffers at the same VMA as part of the same
+    execbuffer object
+
+@code
+   Malloc a 4K buffer
+   Share buffer with with GPU by using userptr ioctl
+   Create second shared buffer
+   Create batch buffer to write DATA to first dword of each buffer
+   Use same virtual address as destination addresses in batch buffer
+   Set EXEC_OBJECT_PINNED flag in both exec objects
+   Set 'offset' in both exec objects to same VMA
+   Submit execbuffer
+   Command should return EINVAL, since we are trying to pin to same VMA
+@endcode
+**/
+static void gem_pin_overlap_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd, ret;
+	uint32_t* shared_buffer = NULL;
+	uint32_t* shared_buffer1 = NULL;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS + 1];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
+
+	/* share with GPU */
+	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
+	ret = gem_call_userptr_ioctl(fd, &userptr);
+	igt_assert_eq(ret, 0);
+
+	gem_create_userptr_struct(&userptr1, shared_buffer1, BO_SIZE * 2, false);
+	ret = gem_call_userptr_ioctl(fd, &userptr1);
+	igt_assert_eq(ret, 0);
+
+	shared_buf_handle = userptr.handle;
+	shared_buf_handle1 = userptr1.handle;
+
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, false);
+	len += gem_store_data_svm(fd, (batch_buffer + len/4), pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], shared_buf_handle1, EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[2], batch_buf_handle, 0, 0);
+
+	ring = 0;
+	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
+		ring = I915_EXEC_BLT;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS+1, len);
+
+	ret = drmIoctl(fd,
+	      DRM_IOCTL_I915_GEM_EXECBUFFER2,
+	      &execbuf);
+
+	/* expect to fail */
+	igt_assert_neq(ret, 0);
+	igt_assert(errno == 22);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+
+/*  gem_evict_test
+ *  create shared buffer, pin it
+ *  create normal buffer
+ *  try and relocate to shared location
+ *  Opens: How to detect eviction occured? 
+ *  i915_gem_gtt - debugfs api - grep it for the page? 
+
+    Create a gem buffer of 4K
+    Malloc a 4K buffer
+    Share buffer with GPU using userptr ioctl
+    Create a batch buffer to write 0x11111111 and 0x22222222 in above 2 buffers
+    Pin Shared buffer to offset '0' in GTT
+    Create reloc buffer to ensure gem buffer is relocated to GTT
+    Submit execbuffer
+    Verify shared buffer has 0x22222222 as expected
+    Obtain offset of where gem object has been placed from exec object field
+    Try to pin shared buffer at that address using 'offset' field in exec object
+    Prevent relocation by setting relocation_count = 0
+    Submit execbuffer
+    Shared buffer will be pinned to previous address of gem object
+    Unshared buffer will be evicted, since relocation is not allowed
+    Second batch buffer will write 0x11111111 to shared buffer instead of unshared
+    Verify shared buffer contains 0x11111111
+    Reverse order of instructions in batch buffer to write to unshared first
+*/
+
+static void gem_evict_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t* shared_buffer = NULL;
+	struct drm_i915_gem_relocation_entry reloc[4];
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS + 1];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE * 2];
+	uint32_t batch_buf_handle, shared_buf_handle, unshared_buf_handle;
+	int ring, len;
+	uint32_t data1, data2;
+	uint32_t value;
+	uint64_t pinning_offset = 0;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+	unshared_buf_handle = gem_create(fd, BO_SIZE);
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
+	ret = gem_call_userptr_ioctl(fd, &userptr);
+	igt_assert_eq(ret, 0);
+
+	/* Get handle for shared buffer */
+	shared_buf_handle = userptr.handle;
+
+	/* create command buffer with write commands */
+	data1 = 0x11111111;
+	data2 = 0x22222222;
+	len = gem_store_data(fd, batch_buffer, unshared_buf_handle, data1, reloc, false);
+	len += gem_store_data_svm(fd, batch_buffer + (len/4), pinning_offset, data2, true);
+	igt_assert_lte(len, STORE_BATCH_BUFFER_SIZE * 2 * 4);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], unshared_buf_handle, 0, 0);
+	setup_exec_obj(&exec_object2[2], batch_buf_handle, 0, 0);
+
+	exec_object2[2].relocation_count = 1;
+	exec_object2[2].relocs_ptr = (uintptr_t)reloc;
+	ring = 0;
+	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
+		ring = I915_EXEC_BLT;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS+1, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	igt_assert(*shared_buffer == data2);
+	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
+	igt_assert(value == data1);
+
+
+	*shared_buffer = 0xffffffff;
+	/* Now cause eviction of unshared buffer by pinning shared buffer there */
+	exec_object2[0].offset = exec_object2[1].offset;
+	/* Prevent relocation */
+	exec_object2[2].relocation_count = 0;
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	igt_assert(*shared_buffer == data1);
+	igt_assert(exec_object2[0].offset != exec_object2[1].offset);
+	/* Unshared buffer gets evicted, and retains its value, since no batch buffer writes to it */
+	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
+	igt_assert(value == data1);
+
+	/* Now lets do it again with the objects listed in reverse order... */
+	*shared_buffer = 0xffffffff;
+	setup_exec_obj(&exec_object2[0], unshared_buf_handle, 0, 0);
+	setup_exec_obj(&exec_object2[1], shared_buf_handle, EXEC_OBJECT_PINNED, 0);
+
+	exec_object2[2].relocation_count = 1;
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	igt_assert(*shared_buffer == data2);
+	*shared_buffer = 0xffffffff;
+	/* Now cause eviction of unshared buffer by pinning shared buffer there */
+	exec_object2[1].offset = exec_object2[0].offset;
+	/* Prevent relocation */
+	exec_object2[2].relocation_count = 0;
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	igt_assert(*shared_buffer == data1);
+	igt_assert(exec_object2[0].offset != exec_object2[1].offset);
+	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
+	igt_assert(value == data1);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+}
+
+/** gem_softpin_stress_test - Stress test which creates 10K buffers and shares with GPU 
+   Create 100K uint32 buffers of size 4K each
+   Share with GPU using userptr ioctl
+   Create batch buffer to write DATA in first element of each buffer
+   Pin each buffer to varying addresses starting from 0x800000000000 going below
+   Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
+   Validate every buffer has DATA in first element
+   Rinse and Repeat on Render ring
+**/
+#define STRESS_NUM_BUFFERS 100240
+#define STRESS_NUM_LOOPS 1
+#define STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
+
+static void gem_softpin_stress_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t* shared_buffer[STRESS_NUM_BUFFERS];
+	uint32_t shared_handle[STRESS_NUM_BUFFERS];
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[STRESS_NUM_BUFFERS + 1];
+	uint32_t batch_buffer[STORE_COMMANDS + 2]; /* 4 dwords per buffer + 2 for the end of batchbuffer */
+	uint32_t batch_buf_handle;
+	int ring, len, i, j;
+	uint64_t pinning_offset = 0x800000000000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
+
+	/* create command buffer with write commands */
+	len = 0;
+	for(i = 0; i < STRESS_NUM_BUFFERS; i++) 
+	{
+		shared_buffer[i] = create_mem_buffer(BO_SIZE);
+		*shared_buffer[i] = 0xFFFFFFFF;
+
+		/* share with GPU */
+		gem_create_userptr_struct(&userptr, shared_buffer[i], BO_SIZE, false);
+		ret = gem_call_userptr_ioctl(fd, &userptr);
+		igt_assert_eq(ret, 0);
+
+		/* Get handle for shared buffer */
+		shared_handle[i] = userptr.handle;
+
+		setup_exec_obj(&exec_object2[i], shared_handle[i], EXEC_OBJECT_PINNED, pinning_offset);
+		len += gem_store_data_svm(fd, batch_buffer + (len/4), pinning_offset, i , (i == STRESS_NUM_BUFFERS-1) ? true:false);
+		
+		pinning_offset -= 0x200000; /* incremental 4K aligned address */
+	}
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle, 0, 0);
+
+	ring = 0;
+	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
+		ring = I915_EXEC_BLT;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, STRESS_NUM_BUFFERS + 1, len);
+
+	for (i = 0; i < STRESS_NUM_LOOPS; i++){
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		for(j = 0; j < STRESS_NUM_BUFFERS; j++){
+			igt_fail_on_f(*shared_buffer[j] != j,
+				      "Mismatch in buffer %d, iteration %d: 0x%08X\n", j, i, *shared_buffer[j]);
+		}
+	}
+
+	// Now Render Ring
+	ring = I915_EXEC_RENDER;
+	execbuf.flags = ring;
+	for (i = 0; i < STRESS_NUM_LOOPS; i++){
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		for(j = 0; j < STRESS_NUM_BUFFERS; j++){
+			igt_fail_on_f(*shared_buffer[j] != j,
+				      "Mismatch in buffer %d, iteration %d: 0x%08X\n", j, i, *shared_buffer[j]);
+		}
+	}
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	for(i = 0; i < STRESS_NUM_BUFFERS; i++) 
+	{
+		free(shared_buffer[i]);
+	}
+}
+
+/*  gem_write_multipage_buffer - Create a buffer spanning multiple
+    pages, and share with GPU. Write to every element of the buffer
+    and verify correct contents.
+
+   Create 16K uint32 buffer
+   Share with GPU using userptr ioctl
+   Create batch buffer to write DATA in all elements of buffer
+   Execute Batch Buffer
+   Validate every element has DATA
+ */
+static void gem_write_multipage_buffer_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t* shared_buffer;
+	uint32_t shared_handle;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
+	uint32_t batch_buffer[(4 * BO_SIZE) + 2];
+	uint32_t batch_buf_handle;
+	int ring, len, j;
+	uint64_t pinning_offset=0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
+
+	/* create command buffer with write commands */
+	len = 0;
+	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
+	memset(batch_buffer, 0, sizeof(batch_buffer));
+
+	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
+
+	/* share with GPU */
+	gem_create_userptr_struct(&userptr, shared_buffer, MULTIPAGE_BO_SIZE, false);
+	ret = gem_call_userptr_ioctl(fd, &userptr);
+	igt_assert_eq(ret, 0);
+
+	/* Get handle for shared buffer */
+	shared_handle = userptr.handle;
+
+	setup_exec_obj(&exec_object2[0], shared_handle, EXEC_OBJECT_PINNED, pinning_offset);
+
+	/* Every element of buffer */
+	for(j=0; j< (BO_SIZE); j++) /* BO_SIZE because it is 16K 4 byte entries */
+	{
+		len += gem_store_data_svm(fd, batch_buffer + (len/4), pinning_offset, j, (j == ((BO_SIZE)-1)) ? true:false);
+		pinning_offset += sizeof(shared_buffer[0]);  /* 4 bytes */
+	}
+	
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	// submit command buffer
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = 0;
+	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
+		ring = I915_EXEC_BLT;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	for(j = 0; j < (BO_SIZE); j++) 
+	{
+		igt_fail_on_f(shared_buffer[j] != j,
+			      "Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+}
+
+/** This test will request to pin a shared buffer to an invalid
+    VMA  > 48-bit address
+
+   Create shared buffer of size 4K
+   Try and Pin object to address 0x9000000000000
+**/
+static void gem_pin_invalid_vma_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t* shared_buffer = NULL;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t invalid_address = 0x9000000000000; /* 52 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+	
+	// share with GPU
+	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
+	ret = gem_call_userptr_ioctl(fd, &userptr);
+	igt_assert_eq(ret, 0);
+
+	shared_buf_handle = userptr.handle;
+
+	len = gem_store_data_svm(fd, batch_buffer, invalid_address, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED, invalid_address);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = 0;
+	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
+		ring = I915_EXEC_BLT;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
+
+	/* Expect execbuf to fail */
+	ret = drmIoctl(fd,
+	       DRM_IOCTL_I915_GEM_EXECBUFFER2,
+	       &execbuf);
+
+	igt_assert_neq(ret, 0);
+	
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+}
+
+#define SHM_KEY 56789
+#define SHMEM_SIZE 4096
+/*  gem_shmem_svm_test - Test userptr ioctl with shared memory
+ * This test creates a sysV IPC buffer and shares with GPU. 
+ * It will send GPU commands to write DATA in the buffer and 
+ * validate it on the CPU side when the command completes.
+
+ * Create arbitrary shmem id
+ * Use shmat to attach a 4K uint32 buffer to above id
+ * Share buffer with GPU using userptr ioctl
+ * Create Batch buffer to write DATA in the first element
+ * submit execbuffer
+ * Validate on CPU side that DATA was indeed written
+ */
+static void gem_shmem_test(void)
+{
+	int shmid;
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t* shared_buffer = NULL;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	shmid = shmget(SHM_KEY, SHMEM_SIZE, IPC_CREAT);
+	igt_assert_neq(shmid, -1);
+
+	shared_buffer = shmat(shmid, NULL, 0);	      
+	igt_assert(shared_buffer != (void*)-1);
+
+	memset(shared_buffer, 0, SHMEM_SIZE);
+	shared_buffer[0] = 0xFFFFFFFF;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	gem_create_userptr_struct(&userptr, shared_buffer, SHMEM_SIZE, false);
+	ret = gem_call_userptr_ioctl(fd, &userptr);
+	igt_assert_eq(ret, 0);
+
+	shared_buf_handle = userptr.handle;
+	
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = 0;
+	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
+		ring = I915_EXEC_BLT;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+			"\nCPU read does not match GPU write, expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
+
+	ret = shmdt(shared_buffer);
+	igt_assert_eq(ret, 0);
+}
+
+/*  gem_pin_high_address_test - This test will create a shared buffer, and create a command
+ *  for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
+ *  CPU will read and make sure expected value is obtained
+
+   Malloc a 4K buffer
+   Share buffer with with GPU by using userptr ioctl
+   Create batch buffer to write DATA to first dword of buffer
+   Use virtual address of buffer as 0x1100000000 (> 32 bit)
+   Set EXEC_OBJECT_PINNED flag in exec object
+   Set 'offset' in exec object to shared buffer VMA
+   Submit execbuffer
+   Verify value of first DWORD in shared buffer matches DATA
+*/
+
+static void gem_pin_high_address_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t* shared_buffer = NULL;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
+	ret = gem_call_userptr_ioctl(fd, &userptr);
+	igt_assert_eq(ret, 0);
+
+	/* Get handle for shared buffer */
+	shared_buf_handle = userptr.handle;
+ 
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = 0;
+	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
+		ring = I915_EXEC_BLT;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/*  gem_pin_near_48Bit_test - This test will create a shared buffer, and create a command
+ *  for GPU to write data in it. It will attempt to pin the buffer at address > 47 bits <= 48-bit.
+ *  CPU will read and make sure expected value is obtained
+
+   Malloc a 4K buffer
+   Share buffer with with GPU by using userptr ioctl
+   Create batch buffer to write DATA to first dword of buffer
+   Use virtual address of buffer as range between 47-bit and 48-bit
+   Set EXEC_OBJECT_PINNED flag in exec object
+   Set 'offset' in exec object to shared buffer VMA
+   Submit execbuffer
+   Verify value of first DWORD in shared buffer matches DATA
+*/
+#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000 
+#define END_HIGH_ADDRESS 0xFFFFFFFFC000
+#define ADDRESS_INCREMENT 0x2000000000
+static void gem_pin_near_48Bit_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t* shared_buffer = NULL;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
+	ret = gem_call_userptr_ioctl(fd, &userptr);
+	igt_assert_eq(ret, 0);
+
+	/* Get handle for shared buffer */
+	shared_buf_handle = userptr.handle;
+
+	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS; 
+						high_address+=ADDRESS_INCREMENT){
+		/* create command buffer with write command */
+		len = gem_store_data_svm(fd, batch_buffer, high_address, 
+					data, true);
+		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+		/* submit command buffer */
+		setup_exec_obj(&exec_object2[0], shared_buf_handle, 
+				EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, 
+				high_address);
+		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+		ring = 0;
+		if (HAS_BLT_RING(intel_get_drm_devid(fd)))
+			ring = I915_EXEC_BLT;
+
+
+		setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+		/* check on CPU to see if value changes */
+		igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, expected: 0x%x, got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/*  gem_pin_mmap_anonymous_test - This test will create a mmap anonymous buffer and
+ *  share with GPU. It will run basic test on this buffer. 
+
+   Create a anonymous mmap buffer
+   Share buffer with with GPU by using userptr ioctl
+   Create batch buffer to write DATA to first dword of buffer
+   Set EXEC_OBJECT_PINNED flag in exec object
+   Set 'offset' in exec object to pinning_offset VMA
+   Submit execbuffer
+   Verify value of first DWORD in shared buffer matches DATA
+*/
+void gem_pin_mmap_anonymous_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t* shared_buffer = NULL;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create anonymus mmap buffer, set to all 0xF's */
+	shared_buffer = mmap(NULL, BO_SIZE, PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
+	igt_fail_on_f(shared_buffer == (void *)-1,
+		      "mmap call failed with %s\n", strerror(errno));
+
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
+	ret = gem_call_userptr_ioctl(fd, &userptr);
+	igt_assert_eq(ret, 0);
+
+	/* Get handle for shared buffer */
+	shared_buf_handle = userptr.handle;
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = 0;
+	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
+		ring = I915_EXEC_BLT;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	// check on CPU to see if value changes
+	igt_fail_on_f(shared_buffer[0] != data,
+		      "\nCPU read does not match GPU write, expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+	igt_fail_on_f(munmap(shared_buffer, BO_SIZE) != 0,
+		      "munmap failed with: %s", strerror(errno));
+}
+
+/*  gem_pin_mmap_file_test - This test will use mmap command to map
+ *  a file in memory. It will then attempt to share the buffer with GPU
+ *  using the userptr ioctl. It will verify if CPU/GPU writes are consistent
+
+   open/create a file
+   lseek into the file and write some arbitrary data
+   this allows the mmap'd page to become resident
+   use mmap command to map the file into memory
+   Share buffer with with GPU by using userptr ioctl
+   Create batch buffer to write DATA to first dword of buffer
+   Set EXEC_OBJECT_PINNED flag in exec object
+   Set 'offset' in exec object to pinning_offest VMA
+   Submit execbuffer
+   Verify value of first DWORD in shared buffer matches DATA
+   Close file
+*/
+void gem_pin_mmap_file_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, dest_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+        int fdout;
+	uint32_t *dest;
+	const char filename[] = "/tmp/svm_mmap.txt";
+	uint64_t pinning_offset = 0x1000;
+
+	fdout = open(filename, O_RDWR | O_CREAT | O_TRUNC, 0640);
+	igt_fail_on_f(fdout < 0, "Cannot open output file\n");
+
+	/* Do this to ensure backing physical memory for the file */
+	/* go to the location corresponding to the last byte */
+	if (lseek (fdout, BO_SIZE, SEEK_SET) == -1)
+		igt_info("lseek error");
+
+	/* write a dummy byte at the last location */
+	if (write (fdout, "", 1) != 1)
+		igt_info("write error");
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create anonymus mmap buffer, set to all 0xF's */
+	dest = mmap(0, BO_SIZE, PROT_WRITE, MAP_SHARED, fdout, 0);
+	igt_fail_on_f(dest == (void *)-1,
+		      "mmap call failed with %s\n", strerror(errno));
+	*dest = 0x11111111;
+
+	gem_create_userptr_struct(&userptr, dest, BO_SIZE, false);
+	ret = gem_call_userptr_ioctl(fd, &userptr);
+	igt_assert_eq(ret, 0);
+	dest_buf_handle = userptr.handle;
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], dest_buf_handle, EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = 0;
+	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
+		ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(*dest != data,
+		      "\nCPU read does not match GPU write, expected: 0x%x, got: 0x%x\n", data, dest[0]);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+	igt_fail_on_f(munmap(dest, BO_SIZE) != 0,
+		      "munmap failed with: %s", strerror(errno));
+	close(fdout);
+}
+
+
+int main(int argc, char* argv[])
+{
+	igt_subtest_init(argc, argv);
+	igt_skip_on_simulation();
+
+	igt_subtest("gem_basic"){
+		gem_basic_test();
+	}
+	igt_subtest("gem_multiple_process"){
+		gem_multiple_process_test();
+	}
+	igt_subtest("gem_repin"){
+		gem_repin_test();
+	}
+	igt_subtest("gem_evict"){
+		gem_evict_test();
+	}
+	igt_subtest("gem_softpin_stress"){
+		gem_softpin_stress_test();
+	}
+	igt_subtest("gem_pin_overlap"){
+		gem_pin_overlap_test();
+	}
+	igt_subtest("gem_shmem"){
+		gem_shmem_test();
+	}
+	igt_subtest("gem_write_multipage_buffer"){
+		gem_write_multipage_buffer_test();
+	}
+	igt_subtest("gem_pin_high_address"){
+		gem_pin_high_address_test();
+	}
+	igt_subtest("gem_pin_near_48Bit"){
+		gem_pin_near_48Bit_test();
+	}
+	igt_subtest("gem_pin_invalid_vma"){
+		gem_pin_invalid_vma_test();
+	}
+	igt_subtest("gem_pin_mmap_anon"){
+		gem_pin_mmap_anonymous_test();
+	}
+	igt_subtest("gem_pin_mmap_file"){
+		gem_pin_mmap_file_test();
+	}
+
+	igt_exit();
+}
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
  2015-11-19 22:29 [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature Vinay Belgaumkar
@ 2015-11-20 16:20 ` Tvrtko Ursulin
  0 siblings, 0 replies; 19+ messages in thread
From: Tvrtko Ursulin @ 2015-11-20 16:20 UTC (permalink / raw)
  To: Vinay Belgaumkar, intel-gfx


Hi,

On 19/11/15 22:29, Vinay Belgaumkar wrote:
> These tests exercise the userptr ioctl to create shared buffers
> between CPU and GPU. They contain error and normal usage scenarios.
> They also contain a couple of stress tests which copy buffers between
> CPU and GPU. These tests rely on the softpin patch in order to pin buffers
> to a certain VA.
>
> Caveat: These tests were designed to run on 64-bit system. Future work
> includes adding logic to ensure these tests can run on 32-bit systems with
> PPGTT support. Some tests are currently disabled for 32-bit systems for that
> reason.
>
> v2: Added cc and signed-off-by fields
>
> v3: Fixed review comments, added helper functions. Removed userptr error
> scenarios covered by existing userptr tests. Modified stress test to have
> 100K buffers, it now runs for ~30 mins, checks every element has been written
> to correctly, and pins buffers at different VMAs.
>
> v4: Changed name to gem_softpin
>
> Cc: Michel Thierry <michel.thierry@intel.com>

Copy your reviewers as well please. :)

> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
>   tests/.gitignore       |    1 +
>   tests/Makefile.sources |    1 +
>   tests/gem_softpin.c    | 1252 ++++++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 1254 insertions(+)
>   create mode 100644 tests/gem_softpin.c
>
> diff --git a/tests/.gitignore b/tests/.gitignore
> index 80af9a7..424870b 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -21,6 +21,7 @@ gem_bad_blit
>   gem_bad_length
>   gem_bad_reloc
>   gem_basic
> +gem_softpin
>   gem_caching
>   gem_close_race
>   gem_concurrent_all
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 8fb2de8..2008d4a 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -11,6 +11,7 @@ TESTS_progs_M = \
>   	drv_hangman \
>   	gem_bad_reloc \
>   	gem_basic \
> +	gem_softpin \
>   	gem_caching \
>   	gem_close_race \
>   	gem_concurrent_blit \
> diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
> new file mode 100644
> index 0000000..aed607c
> --- /dev/null
> +++ b/tests/gem_softpin.c
> @@ -0,0 +1,1252 @@
> +/*
> + * Copyright © 2015 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + *
> + * Authors:
> + *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> +      Thomas Daniel <thomas.daniel@intel.com>
> + *
> + */
> +
> +#include <unistd.h>
> +#include <stdlib.h>
> +#include <stdint.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include <fcntl.h>
> +#include <inttypes.h>
> +#include <errno.h>
> +#include <sys/stat.h>
> +#include <sys/ioctl.h>
> +#include <sys/time.h>
> +#include <malloc.h>
> +#include "drm.h"
> +#include "ioctl_wrappers.h"
> +#include "drmtest.h"
> +#include "intel_chipset.h"
> +#include "intel_io.h"
> +#include "i915_drm.h"
> +#include <assert.h>
> +#include <sys/wait.h>
> +#include <sys/ipc.h>
> +#include <sys/shm.h>
> +#include "igt_kms.h"
> +#include <inttypes.h>
> +#include <sys/types.h>
> +#include <sys/stat.h>
> +
> +#define OBJECT_SIZE 16384

Unused.

> +#define BO_SIZE 4 * 4096

Could it be just one page to save resources?

> +#define MULTIPAGE_BO_SIZE 4 * BO_SIZE

Need more than two pages?

> +#define STORE_BATCH_BUFFER_SIZE 6
> +#define STRESS_BATCH_BUFFER_SIZE 5
> +#define EXEC_OBJECT_PINNED	(1<<4)
> +#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
> +#define SHARED_BUFFER_SIZE 4096
> +#define NUM_EXEC_OBJECTS 2
> +
> +typedef struct drm_i915_gem_userptr i915_gem_userptr;
> +
> +static void gem_create_userptr_struct(i915_gem_userptr*, void* ptr, __u64 size, bool read_only);

Okay I commented on mixing of __u and stdint types and now you have 
opted for the former which is slightly unusual for userspace. I would 
recommend you use stdint, should be easy with search & replace in any 
editor.

Hm actually on a closer look you still use both. I would really 
recommend to stick with one for readability.

> +static void *create_mem_buffer(__u64 size);
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
> +static void gem_basic_test(void);
> +static void gem_pin_invalid_vma_test(void);
> +static void gem_pin_overlap_test(void);
> +static void gem_shmem_test(void);
> +static void gem_pin_high_address_test(void);
> +static void gem_pin_mmap_anonymous_test(void);
> +static void gem_pin_mmap_file_test(void);
> +
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr* userptr)

Coding style, i915_gem_userptr *userptr, probably some more of this around.

> +{
> +	int ret;
> +
> +	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
> +
> +	if (ret)
> +		ret = errno;
> +
> +	return ret;
> +}
> +
> +static void gem_create_userptr_struct(i915_gem_userptr *userptr, void* ptr, __u64 size, bool read_only)

a) looks by the eye to be over 80 char long. But I am not sure if IGT 
allows this, probably better to take care of those.

b) maybe change the name somehow so it does't have create in the name 
since it is not creating the struct any more.

Actually.. on a closer look all calls to this are immediately followed 
by gem_call_userptr_ioctl so It may be best for readability of test 
cases to merge the two.

> +{
> +	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
> +
> +	userptr->user_ptr = (uintptr_t)ptr;

Bad cast and not even needed.

> +	userptr->user_size = size;
> +	userptr->flags = I915_USERPTR_UNSYNCHRONIZED;
> +
> +	if (read_only)
> +		userptr->flags |= I915_USERPTR_READ_ONLY;
> +}
> +
> +/*  Creates a 4K aligned CPU buffer
> + *  @size - size of buffer
> + *  RETURNS pointer to buffer of @size
> +*/

Unusual comment formatting.

> +
> +static void* create_mem_buffer(__u64 size)
> +{
> +	void* addr;
> +	int ret;
> +
> +	ret = posix_memalign(&addr, 4096, size);
> +	igt_assert(ret == 0);
> +
> +	return addr;
> +}
> +
> +/*  setup_exec_obj - populate exec object
> + * @exec - exec object
> + * @handle - handle to gem buffer
> + * flags - any flags
> + * offset - requested VMA
> + */
> +static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec, __u32 handle, __u32 flags, __u64 offset)
> +{
> +	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
> +	exec->handle = handle;
> +	exec->flags = flags;
> +	exec->offset = offset;
> +}
> +
> +/*
> + * gem_store_data_svm - populate batch buffer with MI_STORE_DWORD_IMM command
> + * @fd: drm file descriptor
> + * @buf: batch buffer
> + * @buffer_size: size of buffer
> + * @addr: destination Virtual address
> + * @data: data to be store at destination
> + * @end: whether to end batch buffer or not
> + */
> +static int gem_store_data_svm(int fd, uint32_t* cmd_buf, uint64_t vaddr,
> +			      uint32_t data, bool end)
> +{
> +	int i = 0;
> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
> +	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
> +
> +	cmd_buf[i++] = data;
> +	if (end){
> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	return (i * sizeof(uint32_t));
> +}
> +
> +/*
> + * gem_store_data - populate batch buffer with MI_STORE_DWORD_IMM command
> + * This one fills up reloc buffer as well
> + * @fd: drm file descriptor
> + * @buf: batch buffer
> + * @buffer_size: size of buffer
> + * @addr: destination Virtual address
> + * @data: data to be store at destination
> + * @reloc - relocation entry
> + * @end: whether to end batch buffer or not
> + */
> +
> +static int gem_store_data(int fd, uint32_t* cmd_buf,
> +			      uint32_t handle, uint32_t data,
> +			      struct drm_i915_gem_relocation_entry *reloc,
> +			      bool end)
> +{
> +	int i = 0;
> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 because reloc is needed */
> +	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 because reloc is needed */
> +	reloc->offset = 1 * sizeof(uint32_t);
> +	reloc->delta = 0;
> +	reloc->target_handle = handle;
> +	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
> +	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
> +	reloc->presumed_offset = 0;
> +	reloc++;

Pointless line.

> +	cmd_buf[i++] = data;
> +	if (end){
> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	return (i * sizeof(uint32_t));
> +}
> +
> +/* Helper function for filling execbuffer struct */
> +static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf, struct drm_i915_gem_exec_object2 *exec_object,
> +					int ring, int buffer_count, int batch_length)
> +{
> +	execbuf->buffers_ptr = (uintptr_t)exec_object;
> +	execbuf->buffer_count = buffer_count;
> +	execbuf->batch_start_offset = 0;
> +	execbuf->batch_len = batch_length;
> +	execbuf->cliprects_ptr = 0;
> +	execbuf->num_cliprects = 0;
> +	execbuf->DR1 = 0;
> +	execbuf->DR4 = 0;
> +	execbuf->flags = ring;
> +	i915_execbuffer2_set_context_id(*execbuf, 0);
> +	execbuf->rsvd2 = 0;
> +}
> +
> +/* Helper function for exec and sync functions */
> +static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf, uint32_t batch_buf_handle)
> +{
> +	gem_execbuf(fd, execbuf);
> +	gem_sync(fd, batch_buf_handle);
> +}
> +
> +/*  gem_basic_test - This test will create a shared buffer, and create a command
> + *  for GPU to write data in it
> + *  CPU will read and make sure expected value is obtained
> + *  @valid_shared_buffer - whether test with valid malloc'd buffer or not
> +
> +   if (valid_shared_buffer == true)
> +   Malloc a 4K buffer
> +   Share buffer with with GPU by using userptr ioctl
> +   Create batch buffer to write DATA to first dword of buffer
> +   Use 0x1000 address as destination address in batch buffer
> +   Set EXEC_OBJECT_PINNED flag in exec object
> +   Set 'offset' in exec object to 0x1000
> +   Submit execbuffer
> +   Verify value of first DWORD in shared buffer matches DATA
> +
> +   if (valid_shared_buffer == false)
> +   Declare null buffer
> +   Call Userptr ioctl with null buffer
> +   Run Basic Test
> +   Test should fail at submit execbuffer
> +*/
> +static void gem_basic_test(void)
> +{

It would be better in my opinion if the basic tests didn't use userptr 
but a normal bo.

Not saying you can't have both, on the contrary, I even think we need both.

> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t* shared_buffer = NULL;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);

Comment seems wrong, or something, I don't see setting to 0xFs.

> +	
> +	/* share with GPU */
> +	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
> +	ret = gem_call_userptr_ioctl(fd, &userptr);
> +	igt_assert_eq(ret, 0);

I recommend moving this assert into the userptr helper and at the same 
time...

> +
> +	/* Get handle for shared buffer */
> +	shared_buf_handle = userptr.handle;

... make the helper return the handle. Save some lines of code and make 
the test cases more readable.

> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	igt_assert_lte(len, STORE_BATCH_BUFFER_SIZE * 4);

Range checking should happen in gem_store_data_svm since it is pretty 
weird to do it after the fact.

> +
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = 0;
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
> +		ring = I915_EXEC_BLT;

I've asked about this in the previous round - why it is interesting to 
use the blitter ring if available and not always the render ring?

> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);

In the previous round I suggested that you check the offset and I stand 
by that. It is stronger to check the offset as returned by the kernel 
and not just the written data.

> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		      "\nCPU read does not match GPU write, expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);

Why don't you need to move the shared_buf_handle to the CPU domain 
before accessing it? I thought that is required to ensure GPU as 
finished writing to it and you don't hit cache coherency issues?

> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +}
> +
> +/*  gem_multiple_process_test - Run basic test simultaneously with multiple processes
> +*   This will test pinning same VA separately in each process
> +
> +    fork();
> +    Execute basic test in parent/child processes
> +
> +*/
> +
> +#define MAX_NUM_PROCESSES 10
> +
> +static void gem_multiple_process_test(void)
> +{
> +	igt_fork(child, MAX_NUM_PROCESSES) {
> +		gem_basic_test();
> +	}
> +	igt_waitchildren();
> +}
> +
> +
> +/* gem_repin_test
> + * This test tries to repin a buffer at a previously pinned vma
> + * from a different execbuf.
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000 VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +
> + * Create second shared buffer
> + * Follow all steps above
> + * Execpt, for offset, use VMA of first buffer above
> + * Submit execbuffer
> + * Verify value of first DWORD in second shared buffer matches DATA
> +*/

I hate it how you have all possible comment styles in one file.

/**
  * Blah

/* Blah

/*
  * blah

/*
@code
description of steps

/*
  * description of steps

/*
  description of steps

...

It is just too much..

> +static void gem_repin_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd, ret;
> +	uint32_t* shared_buffer = NULL;
> +	uint32_t* shared_buffer1 = NULL;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	/* Create gem object */
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE);
> +	shared_buffer[0] = 0x0;
> +	shared_buffer1[0] = 0x0;

Oops.

> +
> +	/* share with GPU */
> +	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
> +	ret = gem_call_userptr_ioctl(fd, &userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	//gem_create_userptr_struct(&userptr1, shared_buffer1, BO_SIZE * 2, false);

Remove?

> +	gem_create_userptr_struct(&userptr1, shared_buffer1, BO_SIZE, false);
> +	ret = gem_call_userptr_ioctl(fd, &userptr1);
> +	igt_assert_eq(ret, 0);
> +
> +	/* Get handle for shared buffer */
> +	shared_buf_handle = userptr.handle;
> +	shared_buf_handle1 = userptr1.handle;
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = 0;
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
> +		ring = I915_EXEC_BLT;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	igt_assert(*shared_buffer == data);
> +
> +	/* Second buffer */
> +	/* create command buffer with write command */
> +	pinning_offset = exec_object2[0].offset;
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	/* Pin at shared_buffer, not shared_buffer1 */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle1, EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = 0;
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
> +		ring = I915_EXEC_BLT;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	igt_assert(*shared_buffer1 == data);
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +
> +/** gem_repin_overlap_test
> + *  This test will attempt to pin two buffers at the same VMA as part of the same
> +    execbuffer object
> +
> +@code
> +   Malloc a 4K buffer
> +   Share buffer with with GPU by using userptr ioctl
> +   Create second shared buffer
> +   Create batch buffer to write DATA to first dword of each buffer
> +   Use same virtual address as destination addresses in batch buffer
> +   Set EXEC_OBJECT_PINNED flag in both exec objects
> +   Set 'offset' in both exec objects to same VMA
> +   Submit execbuffer
> +   Command should return EINVAL, since we are trying to pin to same VMA
> +@endcode
> +**/
> +static void gem_pin_overlap_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd, ret;
> +	uint32_t* shared_buffer = NULL;
> +	uint32_t* shared_buffer1 = NULL;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS + 1];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
> +
> +	/* share with GPU */
> +	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
> +	ret = gem_call_userptr_ioctl(fd, &userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	gem_create_userptr_struct(&userptr1, shared_buffer1, BO_SIZE * 2, false);
> +	ret = gem_call_userptr_ioctl(fd, &userptr1);
> +	igt_assert_eq(ret, 0);
> +
> +	shared_buf_handle = userptr.handle;
> +	shared_buf_handle1 = userptr1.handle;
> +
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, false);
> +	len += gem_store_data_svm(fd, (batch_buffer + len/4), pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], shared_buf_handle1, EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[2], batch_buf_handle, 0, 0);
> +
> +	ring = 0;
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
> +		ring = I915_EXEC_BLT;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS+1, len);
> +
> +	ret = drmIoctl(fd,
> +	      DRM_IOCTL_I915_GEM_EXECBUFFER2,
> +	      &execbuf);
> +
> +	/* expect to fail */
> +	igt_assert_neq(ret, 0);
> +	igt_assert(errno == 22);
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +
> +/*  gem_evict_test
> + *  create shared buffer, pin it
> + *  create normal buffer
> + *  try and relocate to shared location
> + *  Opens: How to detect eviction occured?
> + *  i915_gem_gtt - debugfs api - grep it for the page?
> +
> +    Create a gem buffer of 4K
> +    Malloc a 4K buffer
> +    Share buffer with GPU using userptr ioctl
> +    Create a batch buffer to write 0x11111111 and 0x22222222 in above 2 buffers
> +    Pin Shared buffer to offset '0' in GTT

Why at zero?

> +    Create reloc buffer to ensure gem buffer is relocated to GTT
> +    Submit execbuffer
> +    Verify shared buffer has 0x22222222 as expected
> +    Obtain offset of where gem object has been placed from exec object field
> +    Try to pin shared buffer at that address using 'offset' field in exec object
> +    Prevent relocation by setting relocation_count = 0
> +    Submit execbuffer
> +    Shared buffer will be pinned to previous address of gem object
> +    Unshared buffer will be evicted, since relocation is not allowed
> +    Second batch buffer will write 0x11111111 to shared buffer instead of unshared
> +    Verify shared buffer contains 0x11111111
> +    Reverse order of instructions in batch buffer to write to unshared first
> +*/
> +
> +static void gem_evict_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t* shared_buffer = NULL;
> +	struct drm_i915_gem_relocation_entry reloc[4];
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS + 1];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE * 2];
> +	uint32_t batch_buf_handle, shared_buf_handle, unshared_buf_handle;
> +	int ring, len;
> +	uint32_t data1, data2;
> +	uint32_t value;
> +	uint64_t pinning_offset = 0;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +	unshared_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;

Here is some setting to ffffs! But this time no comment. I am not saying 
it needs a comment just that it is funny. :)

> +
> +	/* share with GPU */
> +	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
> +	ret = gem_call_userptr_ioctl(fd, &userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	/* Get handle for shared buffer */
> +	shared_buf_handle = userptr.handle;
> +
> +	/* create command buffer with write commands */
> +	data1 = 0x11111111;
> +	data2 = 0x22222222;
> +	len = gem_store_data(fd, batch_buffer, unshared_buf_handle, data1, reloc, false);
> +	len += gem_store_data_svm(fd, batch_buffer + (len/4), pinning_offset, data2, true);
> +	igt_assert_lte(len, STORE_BATCH_BUFFER_SIZE * 2 * 4);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], unshared_buf_handle, 0, 0);
> +	setup_exec_obj(&exec_object2[2], batch_buf_handle, 0, 0);
> +
> +	exec_object2[2].relocation_count = 1;
> +	exec_object2[2].relocs_ptr = (uintptr_t)reloc;
> +	ring = 0;
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
> +		ring = I915_EXEC_BLT;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS+1, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	igt_assert(*shared_buffer == data2);
> +	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
> +	igt_assert(value == data1);
> +
> +
> +	*shared_buffer = 0xffffffff;
> +	/* Now cause eviction of unshared buffer by pinning shared buffer there */
> +	exec_object2[0].offset = exec_object2[1].offset;
> +	/* Prevent relocation */
> +	exec_object2[2].relocation_count = 0;
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);

First MI_STORE_DATA_IMM now writes to where? To the previously resolved 
address, where unshared buffer was? This is now shared so it writes 
data1 there.

Second MI_STORE_DATA_IMM writes data2 to the pinning_offset. And what is 
at that address now? Shared is not any more since it has been moved. I 
don't get it.

I've asked this in the last round...

> +	igt_assert(*shared_buffer == data1);
 >
> +	igt_assert(exec_object2[0].offset != exec_object2[1].offset);
> +	/* Unshared buffer gets evicted, and retains its value, since no batch buffer writes to it */
> +	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
> +	igt_assert(value == data1);
> +
> +	/* Now lets do it again with the objects listed in reverse order... */
> +	*shared_buffer = 0xffffffff;
> +	setup_exec_obj(&exec_object2[0], unshared_buf_handle, 0, 0);
> +	setup_exec_obj(&exec_object2[1], shared_buf_handle, EXEC_OBJECT_PINNED, 0);
> +
> +	exec_object2[2].relocation_count = 1;
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	igt_assert(*shared_buffer == data2);
> +	*shared_buffer = 0xffffffff;
> +	/* Now cause eviction of unshared buffer by pinning shared buffer there */
> +	exec_object2[1].offset = exec_object2[0].offset;
> +	/* Prevent relocation */
> +	exec_object2[2].relocation_count = 0;
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	igt_assert(*shared_buffer == data1);
> +	igt_assert(exec_object2[0].offset != exec_object2[1].offset);
> +	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
> +	igt_assert(value == data1);
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +}
> +
> +/** gem_softpin_stress_test - Stress test which creates 10K buffers and shares with GPU
> +   Create 100K uint32 buffers of size 4K each
> +   Share with GPU using userptr ioctl
> +   Create batch buffer to write DATA in first element of each buffer
> +   Pin each buffer to varying addresses starting from 0x800000000000 going below
> +   Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
> +   Validate every buffer has DATA in first element
> +   Rinse and Repeat on Render ring
> +**/
> +#define STRESS_NUM_BUFFERS 100240
> +#define STRESS_NUM_LOOPS 1
> +#define STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
> +
> +static void gem_softpin_stress_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t* shared_buffer[STRESS_NUM_BUFFERS];
> +	uint32_t shared_handle[STRESS_NUM_BUFFERS];
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[STRESS_NUM_BUFFERS + 1];
> +	uint32_t batch_buffer[STORE_COMMANDS + 2]; /* 4 dwords per buffer + 2 for the end of batchbuffer */

This test will allocate 1.5GiB of buffers which will fit in GTT on all 
GENs and all mem config? Like some Android tablet reference design?

Maybe you need to auto-tune the numbers?

And it will use quite a lot of stack - some people complained when I 
allocated 48k of it. :)

Lets see.. you'll need 400k + 400k + 1.6MiB + 5.3Mib = 7.3MiB of stack, 
did I get that right?

Easy fix is to allocate blobs for each. For example:


struct drm_i915_gem_exec_object2 *exec_object2 = calloc( 
STRESS_NUM_BUFFERS + 1, sizeof(struct ...exec_object2));

Etc for the rest.

Even for share_buffer, you don't need separate pointers but could also 
allocate the huge blob.

> +	uint32_t batch_buf_handle;
> +	int ring, len, i, j;
> +	uint64_t pinning_offset = 0x800000000000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
> +
> +	/* create command buffer with write commands */
> +	len = 0;
> +	for(i = 0; i < STRESS_NUM_BUFFERS; i++)
> +	{
> +		shared_buffer[i] = create_mem_buffer(BO_SIZE);
> +		*shared_buffer[i] = 0xFFFFFFFF;
> +
> +		/* share with GPU */
> +		gem_create_userptr_struct(&userptr, shared_buffer[i], BO_SIZE, false);
> +		ret = gem_call_userptr_ioctl(fd, &userptr);
> +		igt_assert_eq(ret, 0);
> +
> +		/* Get handle for shared buffer */
> +		shared_handle[i] = userptr.handle;
> +
> +		setup_exec_obj(&exec_object2[i], shared_handle[i], EXEC_OBJECT_PINNED, pinning_offset);
> +		len += gem_store_data_svm(fd, batch_buffer + (len/4), pinning_offset, i , (i == STRESS_NUM_BUFFERS-1) ? true:false);
> +		
> +		pinning_offset -= 0x200000; /* incremental 4K aligned address */

ALIGN(BO_SIZE, 4096) instead of hardcoded number?

> +	}
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle, 0, 0);
> +
> +	ring = 0;
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
> +		ring = I915_EXEC_BLT;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, STRESS_NUM_BUFFERS + 1, len);
> +
> +	for (i = 0; i < STRESS_NUM_LOOPS; i++){
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		for(j = 0; j < STRESS_NUM_BUFFERS; j++){
> +			igt_fail_on_f(*shared_buffer[j] != j,
> +				      "Mismatch in buffer %d, iteration %d: 0x%08X\n", j, i, *shared_buffer[j]);
> +		}
> +	}
> +
> +	// Now Render Ring
> +	ring = I915_EXEC_RENDER;
> +	execbuf.flags = ring;
> +	for (i = 0; i < STRESS_NUM_LOOPS; i++){
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		for(j = 0; j < STRESS_NUM_BUFFERS; j++){
> +			igt_fail_on_f(*shared_buffer[j] != j,
> +				      "Mismatch in buffer %d, iteration %d: 0x%08X\n", j, i, *shared_buffer[j]);
> +		}
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	for(i = 0; i < STRESS_NUM_BUFFERS; i++)
> +	{
> +		free(shared_buffer[i]);
> +	}

Coding style.. or you can just remove the braces.

> +}
> +
> +/*  gem_write_multipage_buffer - Create a buffer spanning multiple
> +    pages, and share with GPU. Write to every element of the buffer
> +    and verify correct contents.
> +
> +   Create 16K uint32 buffer
> +   Share with GPU using userptr ioctl
> +   Create batch buffer to write DATA in all elements of buffer
> +   Execute Batch Buffer
> +   Validate every element has DATA
> + */
> +static void gem_write_multipage_buffer_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t* shared_buffer;
> +	uint32_t shared_handle;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
> +	uint32_t batch_buffer[(4 * BO_SIZE) + 2];

It is hard to figure out why that many elements. You have a store bb 
size defined somewhere already no? And then you need BO_SIZE / 
sizeof(uint32_t) of those plus 2, right?

> +	uint32_t batch_buf_handle;
> +	int ring, len, j;
> +	uint64_t pinning_offset=0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
> +
> +	/* create command buffer with write commands */
> +	len = 0;
> +	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
> +	memset(batch_buffer, 0, sizeof(batch_buffer));
> +
> +	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);

Maybe group the buffers or logical operations more clearly.

> +
> +	/* share with GPU */
> +	gem_create_userptr_struct(&userptr, shared_buffer, MULTIPAGE_BO_SIZE, false);
> +	ret = gem_call_userptr_ioctl(fd, &userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	/* Get handle for shared buffer */
> +	shared_handle = userptr.handle;
> +
> +	setup_exec_obj(&exec_object2[0], shared_handle, EXEC_OBJECT_PINNED, pinning_offset);
> +
> +	/* Every element of buffer */
> +	for(j=0; j< (BO_SIZE); j++) /* BO_SIZE because it is 16K 4 byte entries */

MULTIPAGE_BO_SIZE / sizeof(uint32_t) for clarity ?

> +	{
> +		len += gem_store_data_svm(fd, batch_buffer + (len/4), pinning_offset, j, (j == ((BO_SIZE)-1)) ? true:false);

This is confusing since it doesn't use SVM, I mean doesn't attempt to 
pin the buffer to share_buffer address.

> +		pinning_offset += sizeof(shared_buffer[0]);  /* 4 bytes */
> +	}
> +	
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	// submit command buffer

C++ comment.

> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = 0;
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
> +		ring = I915_EXEC_BLT;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	for(j = 0; j < (BO_SIZE); j++)
> +	{
> +		igt_fail_on_f(shared_buffer[j] != j,
> +			      "Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +}
> +
> +/** This test will request to pin a shared buffer to an invalid
> +    VMA  > 48-bit address
> +
> +   Create shared buffer of size 4K
> +   Try and Pin object to address 0x9000000000000
> +**/
> +static void gem_pin_invalid_vma_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t* shared_buffer = NULL;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t invalid_address = 0x9000000000000; /* 52 bit address */
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +	
> +	// share with GPU
> +	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
> +	ret = gem_call_userptr_ioctl(fd, &userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	shared_buf_handle = userptr.handle;
> +
> +	len = gem_store_data_svm(fd, batch_buffer, invalid_address, data, true);

You don't even need anything in the batch in this test so could further 
simplify it.

> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED, invalid_address);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = 0;
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
> +		ring = I915_EXEC_BLT;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
> +
> +	/* Expect execbuf to fail */
> +	ret = drmIoctl(fd,
> +	       DRM_IOCTL_I915_GEM_EXECBUFFER2,
> +	       &execbuf);
> +
> +	igt_assert_neq(ret, 0);
> +	
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +}
> +
> +#define SHM_KEY 56789
> +#define SHMEM_SIZE 4096
> +/*  gem_shmem_svm_test - Test userptr ioctl with shared memory
> + * This test creates a sysV IPC buffer and shares with GPU.
> + * It will send GPU commands to write DATA in the buffer and
> + * validate it on the CPU side when the command completes.
> +
> + * Create arbitrary shmem id
> + * Use shmat to attach a 4K uint32 buffer to above id
> + * Share buffer with GPU using userptr ioctl
> + * Create Batch buffer to write DATA in the first element
> + * submit execbuffer
> + * Validate on CPU side that DATA was indeed written
> + */
> +static void gem_shmem_test(void)

Move to gem_userptr_blits, without the softpin part.

> +{
> +	int shmid;
> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t* shared_buffer = NULL;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	shmid = shmget(SHM_KEY, SHMEM_SIZE, IPC_CREAT);
> +	igt_assert_neq(shmid, -1);
> +
> +	shared_buffer = shmat(shmid, NULL, 0);	
> +	igt_assert(shared_buffer != (void*)-1);
> +
> +	memset(shared_buffer, 0, SHMEM_SIZE);
> +	shared_buffer[0] = 0xFFFFFFFF;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	gem_create_userptr_struct(&userptr, shared_buffer, SHMEM_SIZE, false);
> +	ret = gem_call_userptr_ioctl(fd, &userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	shared_buf_handle = userptr.handle;
> +	
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = 0;
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
> +		ring = I915_EXEC_BLT;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +			"\nCPU read does not match GPU write, expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
> +
> +	ret = shmdt(shared_buffer);
> +	igt_assert_eq(ret, 0);
> +}
> +
> +/*  gem_pin_high_address_test - This test will create a shared buffer, and create a command
> + *  for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
> + *  CPU will read and make sure expected value is obtained
> +
> +   Malloc a 4K buffer
> +   Share buffer with with GPU by using userptr ioctl
> +   Create batch buffer to write DATA to first dword of buffer
> +   Use virtual address of buffer as 0x1100000000 (> 32 bit)
> +   Set EXEC_OBJECT_PINNED flag in exec object
> +   Set 'offset' in exec object to shared buffer VMA
> +   Submit execbuffer
> +   Verify value of first DWORD in shared buffer matches DATA
> +*/
> +
> +static void gem_pin_high_address_test(void)
> +{

You also need a variant of this test with a normal BO, not userptr.

> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t* shared_buffer = NULL;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
> +	ret = gem_call_userptr_ioctl(fd, &userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	/* Get handle for shared buffer */
> +	shared_buf_handle = userptr.handle;
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = 0;
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
> +		ring = I915_EXEC_BLT;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +/*  gem_pin_near_48Bit_test - This test will create a shared buffer, and create a command
> + *  for GPU to write data in it. It will attempt to pin the buffer at address > 47 bits <= 48-bit.
> + *  CPU will read and make sure expected value is obtained
> +
> +   Malloc a 4K buffer
> +   Share buffer with with GPU by using userptr ioctl
> +   Create batch buffer to write DATA to first dword of buffer
> +   Use virtual address of buffer as range between 47-bit and 48-bit
> +   Set EXEC_OBJECT_PINNED flag in exec object
> +   Set 'offset' in exec object to shared buffer VMA
> +   Submit execbuffer
> +   Verify value of first DWORD in shared buffer matches DATA
> +*/
> +#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000
> +#define END_HIGH_ADDRESS 0xFFFFFFFFC000
> +#define ADDRESS_INCREMENT 0x2000000000
> +static void gem_pin_near_48Bit_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t* shared_buffer = NULL;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
> +	ret = gem_call_userptr_ioctl(fd, &userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	/* Get handle for shared buffer */
> +	shared_buf_handle = userptr.handle;
> +
> +	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS;
> +						high_address+=ADDRESS_INCREMENT){
> +		/* create command buffer with write command */
> +		len = gem_store_data_svm(fd, batch_buffer, high_address,
> +					data, true);
> +		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +		/* submit command buffer */
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +				EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
> +				high_address);
> +		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +		ring = 0;
> +		if (HAS_BLT_RING(intel_get_drm_devid(fd)))
> +			ring = I915_EXEC_BLT;
> +
> +
> +		setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +		/* check on CPU to see if value changes */
> +		igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, expected: 0x%x, got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +/*  gem_pin_mmap_anonymous_test - This test will create a mmap anonymous buffer and
> + *  share with GPU. It will run basic test on this buffer.
> +
> +   Create a anonymous mmap buffer
> +   Share buffer with with GPU by using userptr ioctl
> +   Create batch buffer to write DATA to first dword of buffer
> +   Set EXEC_OBJECT_PINNED flag in exec object
> +   Set 'offset' in exec object to pinning_offset VMA
> +   Submit execbuffer
> +   Verify value of first DWORD in shared buffer matches DATA
> +*/
> +void gem_pin_mmap_anonymous_test(void)
> +{

Please move to gem_userptr_blits, without the softpin parts.

> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t* shared_buffer = NULL;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create anonymus mmap buffer, set to all 0xF's */
> +	shared_buffer = mmap(NULL, BO_SIZE, PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, -1, 0);
> +	igt_fail_on_f(shared_buffer == (void *)-1,
> +		      "mmap call failed with %s\n", strerror(errno));

MAP_FAILED, not -1.

> +
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	gem_create_userptr_struct(&userptr, shared_buffer, BO_SIZE, false);
> +	ret = gem_call_userptr_ioctl(fd, &userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	/* Get handle for shared buffer */
> +	shared_buf_handle = userptr.handle;
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle, EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = 0;
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
> +		ring = I915_EXEC_BLT;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	// check on CPU to see if value changes
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		      "\nCPU read does not match GPU write, expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +	igt_fail_on_f(munmap(shared_buffer, BO_SIZE) != 0,
> +		      "munmap failed with: %s", strerror(errno));
> +}
> +
> +/*  gem_pin_mmap_file_test - This test will use mmap command to map
> + *  a file in memory. It will then attempt to share the buffer with GPU
> + *  using the userptr ioctl. It will verify if CPU/GPU writes are consistent
> +
> +   open/create a file
> +   lseek into the file and write some arbitrary data
> +   this allows the mmap'd page to become resident
> +   use mmap command to map the file into memory
> +   Share buffer with with GPU by using userptr ioctl
> +   Create batch buffer to write DATA to first dword of buffer
> +   Set EXEC_OBJECT_PINNED flag in exec object
> +   Set 'offset' in exec object to pinning_offest VMA
> +   Submit execbuffer
> +   Verify value of first DWORD in shared buffer matches DATA
> +   Close file
> +*/
> +void gem_pin_mmap_file_test(void)
> +{

Please move to gem_userptr_blits, without the softpin parts.

> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, dest_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +        int fdout;
> +	uint32_t *dest;
> +	const char filename[] = "/tmp/svm_mmap.txt";
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fdout = open(filename, O_RDWR | O_CREAT | O_TRUNC, 0640);
> +	igt_fail_on_f(fdout < 0, "Cannot open output file\n");
> +
> +	/* Do this to ensure backing physical memory for the file */
> +	/* go to the location corresponding to the last byte */
> +	if (lseek (fdout, BO_SIZE, SEEK_SET) == -1)
> +		igt_info("lseek error");
> +
> +	/* write a dummy byte at the last location */
> +	if (write (fdout, "", 1) != 1)
> +		igt_info("write error");
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create anonymus mmap buffer, set to all 0xF's */
> +	dest = mmap(0, BO_SIZE, PROT_WRITE, MAP_SHARED, fdout, 0);
> +	igt_fail_on_f(dest == (void *)-1,
> +		      "mmap call failed with %s\n", strerror(errno));
> +	*dest = 0x11111111;
> +
> +	gem_create_userptr_struct(&userptr, dest, BO_SIZE, false);
> +	ret = gem_call_userptr_ioctl(fd, &userptr);
> +	igt_assert_eq(ret, 0);
> +	dest_buf_handle = userptr.handle;
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], dest_buf_handle, EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = 0;
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd)))
> +		ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(*dest != data,
> +		      "\nCPU read does not match GPU write, expected: 0x%x, got: 0x%x\n", data, dest[0]);
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +	igt_fail_on_f(munmap(dest, BO_SIZE) != 0,
> +		      "munmap failed with: %s", strerror(errno));
> +	close(fdout);
> +}
> +
> +
> +int main(int argc, char* argv[])
> +{
> +	igt_subtest_init(argc, argv);
> +	igt_skip_on_simulation();
> +
> +	igt_subtest("gem_basic"){
> +		gem_basic_test();
> +	}
> +	igt_subtest("gem_multiple_process"){
> +		gem_multiple_process_test();
> +	}
> +	igt_subtest("gem_repin"){
> +		gem_repin_test();
> +	}
> +	igt_subtest("gem_evict"){
> +		gem_evict_test();
> +	}
> +	igt_subtest("gem_softpin_stress"){
> +		gem_softpin_stress_test();
> +	}
> +	igt_subtest("gem_pin_overlap"){
> +		gem_pin_overlap_test();
> +	}
> +	igt_subtest("gem_shmem"){
> +		gem_shmem_test();
> +	}
> +	igt_subtest("gem_write_multipage_buffer"){
> +		gem_write_multipage_buffer_test();
> +	}
> +	igt_subtest("gem_pin_high_address"){
> +		gem_pin_high_address_test();
> +	}
> +	igt_subtest("gem_pin_near_48Bit"){
> +		gem_pin_near_48Bit_test();
> +	}
> +	igt_subtest("gem_pin_invalid_vma"){
> +		gem_pin_invalid_vma_test();
> +	}
> +	igt_subtest("gem_pin_mmap_anon"){
> +		gem_pin_mmap_anonymous_test();
> +	}
> +	igt_subtest("gem_pin_mmap_file"){
> +		gem_pin_mmap_file_test();
> +	}
> +
> +	igt_exit();
> +}

Same comments as before :(

1. More coding style cleanup (including comment styles).

2. More tests on normal BOs, no need to use userptr for everything.

3. Move "can we create an userptr from this backing store" tests to 
gem_userptr_blits.

4. And probably some more intersting negative tests can be added about 
when softpin can/will fail. Need to brainstorm it a bit.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
  2015-12-08 12:16   ` Tvrtko Ursulin
@ 2015-12-09 10:32     ` Tvrtko Ursulin
  0 siblings, 0 replies; 19+ messages in thread
From: Tvrtko Ursulin @ 2015-12-09 10:32 UTC (permalink / raw)
  To: Michel Thierry, intel-gfx, Vinay Belgaumkar

On 08/12/15 12:16, Tvrtko Ursulin wrote:
>
> On 08/12/15 11:57, Michel Thierry wrote:
>> From: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>>
>> These tests exercise the userptr ioctl to create shared buffers
>> between CPU and GPU. They contain error and normal usage scenarios.
>> They also contain a couple of stress tests which copy buffers between
>> CPU and GPU. These tests rely on the softpin patch in order to pin
>> buffers
>> to a certain VA.
>>
>> Caveat: These tests were designed to run on 64-bit system. Future work
>> includes adding logic to ensure these tests can run on 32-bit systems
>> with
>> PPGTT support. Some tests are currently disabled for 32-bit systems
>> for that
>> reason.
>>
>> v2: Added cc and signed-off-by fields
>>
>> v3: Fixed review comments, added helper functions. Removed userptr error
>> scenarios covered by existing userptr tests. Modified stress test to have
>> 100K buffers, it now runs for ~30 mins, checks every element has been
>> written
>> to correctly, and pins buffers at different VMAs.
>>
>> v4: Changed name to gem_softpin
>>
>> v5: More fixes. Removed the file based tests, will move them to
>> userptr tests.
>> Added a function that validates appropriate PPGTT support before
>> running tests.
>> Optimized stack space and memory footprint in stress test. Removed the
>> eviction
>> test, will add it back after verifying proper functionality.
>>
>> v6: Split basic test into userptr and bo
>> Fixed some coding style issues.
>>
>> v7: Enhanced invalid vma pinning test to verify 32-bit PPGTT
>> functionality.
>> Enabled the test for 32-bit PPGTT systems, and verify pinning fails above
>> 32-bit addresses. Enhanced the high adress pinning test to ensure pinning
>> fails when EXEC_OBJECT_PINNED flag is not used. Some more cosmetic
>> fixes to
>> close buffer handles. Changed userptr function to used synchronized
>> operations.
>>
>> v8: Minor change to high address pinning test as per comment.
>>
>> v9: Skip the tests if softpin support is not present.
>>
>> v10: Removed trailing white spaces.
>>
>> v11: Keep alphabetical order in Makefile and gitignore; update error code
>> returned while trying to pin above the max vm size (EINVAL); test attempt
>> to pin above 4GB without the support 48b flag.
>>
>> Cc: Michel Thierry <michel.thierry@intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> (v10)
>> Signed-off-by: Michel Thierry <michel.thierry@intel.com> (v11)
>> ---
>>   tests/.gitignore       |    1 +
>>   tests/Makefile.sources |    1 +
>>   tests/gem_softpin.c    | 1084
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 1086 insertions(+)
>>   create mode 100644 tests/gem_softpin.c
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

I pushed this one since the kernel part got merged.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
  2015-12-08 11:57 ` Michel Thierry
@ 2015-12-08 12:16   ` Tvrtko Ursulin
  2015-12-09 10:32     ` Tvrtko Ursulin
  0 siblings, 1 reply; 19+ messages in thread
From: Tvrtko Ursulin @ 2015-12-08 12:16 UTC (permalink / raw)
  To: Michel Thierry, intel-gfx


On 08/12/15 11:57, Michel Thierry wrote:
> From: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>
> These tests exercise the userptr ioctl to create shared buffers
> between CPU and GPU. They contain error and normal usage scenarios.
> They also contain a couple of stress tests which copy buffers between
> CPU and GPU. These tests rely on the softpin patch in order to pin buffers
> to a certain VA.
>
> Caveat: These tests were designed to run on 64-bit system. Future work
> includes adding logic to ensure these tests can run on 32-bit systems with
> PPGTT support. Some tests are currently disabled for 32-bit systems for that
> reason.
>
> v2: Added cc and signed-off-by fields
>
> v3: Fixed review comments, added helper functions. Removed userptr error
> scenarios covered by existing userptr tests. Modified stress test to have
> 100K buffers, it now runs for ~30 mins, checks every element has been written
> to correctly, and pins buffers at different VMAs.
>
> v4: Changed name to gem_softpin
>
> v5: More fixes. Removed the file based tests, will move them to userptr tests.
> Added a function that validates appropriate PPGTT support before running tests.
> Optimized stack space and memory footprint in stress test. Removed the eviction
> test, will add it back after verifying proper functionality.
>
> v6: Split basic test into userptr and bo
> Fixed some coding style issues.
>
> v7: Enhanced invalid vma pinning test to verify 32-bit PPGTT functionality.
> Enabled the test for 32-bit PPGTT systems, and verify pinning fails above
> 32-bit addresses. Enhanced the high adress pinning test to ensure pinning
> fails when EXEC_OBJECT_PINNED flag is not used. Some more cosmetic fixes to
> close buffer handles. Changed userptr function to used synchronized operations.
>
> v8: Minor change to high address pinning test as per comment.
>
> v9: Skip the tests if softpin support is not present.
>
> v10: Removed trailing white spaces.
>
> v11: Keep alphabetical order in Makefile and gitignore; update error code
> returned while trying to pin above the max vm size (EINVAL); test attempt
> to pin above 4GB without the support 48b flag.
>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> (v10)
> Signed-off-by: Michel Thierry <michel.thierry@intel.com> (v11)
> ---
>   tests/.gitignore       |    1 +
>   tests/Makefile.sources |    1 +
>   tests/gem_softpin.c    | 1084 ++++++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 1086 insertions(+)
>   create mode 100644 tests/gem_softpin.c

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko

> diff --git a/tests/.gitignore b/tests/.gitignore
> index 6377007..7f20f2b 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -101,6 +101,7 @@ gem_seqno_wrap
>   gem_set_tiling_vs_blt
>   gem_set_tiling_vs_gtt
>   gem_set_tiling_vs_pwrite
> +gem_softpin
>   gem_storedw_batches_loop
>   gem_streaming_writes
>   gem_stress
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index ef4154f..d594038 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -58,6 +58,7 @@ TESTS_progs_M = \
>   	gem_reset_stats \
>   	gem_ringfill \
>   	gem_set_tiling_vs_blt \
> +	gem_softpin \
>   	gem_stolen \
>   	gem_storedw_batches_loop \
>   	gem_streaming_writes \
> diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
> new file mode 100644
> index 0000000..7bee16b
> --- /dev/null
> +++ b/tests/gem_softpin.c
> @@ -0,0 +1,1084 @@
> +/*
> + * Copyright © 2015 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + *
> + * Authors:
> + *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> + *    Thomas Daniel <thomas.daniel@intel.com>
> + *
> + */
> +
> +#include <unistd.h>
> +#include <stdlib.h>
> +#include <stdint.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include <fcntl.h>
> +#include <inttypes.h>
> +#include <errno.h>
> +#include <sys/stat.h>
> +#include <sys/ioctl.h>
> +#include <sys/time.h>
> +#include <malloc.h>
> +#include "drm.h"
> +#include "ioctl_wrappers.h"
> +#include "drmtest.h"
> +#include "intel_chipset.h"
> +#include "intel_io.h"
> +#include "i915_drm.h"
> +#include <assert.h>
> +#include <sys/wait.h>
> +#include <sys/ipc.h>
> +#include <sys/shm.h>
> +#include "igt_kms.h"
> +#include <inttypes.h>
> +#include <sys/types.h>
> +#include <sys/stat.h>
> +
> +#define BO_SIZE 4096
> +#define MULTIPAGE_BO_SIZE 2 * BO_SIZE
> +#define STORE_BATCH_BUFFER_SIZE 4
> +#define EXEC_OBJECT_PINNED	(1<<4)
> +#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
> +#define SHARED_BUFFER_SIZE 4096
> +
> +typedef struct drm_i915_gem_userptr i915_gem_userptr;
> +
> +static uint32_t init_userptr(int fd, i915_gem_userptr *, void *ptr, uint64_t size);
> +static void *create_mem_buffer(uint64_t size);
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
> +static void gem_pin_userptr_test(void);
> +static void gem_pin_bo_test(void);
> +static void gem_pin_invalid_vma_test(bool test_decouple_flags);
> +static void gem_pin_overlap_test(void);
> +static void gem_pin_high_address_test(void);
> +
> +#define NO_PPGTT 0
> +#define ALIASING_PPGTT 1
> +#define FULL_32_BIT_PPGTT 2
> +#define FULL_48_BIT_PPGTT 3
> +/* uses_full_ppgtt
> + * Finds supported PPGTT details.
> + * @fd DRM fd
> + * @min can be
> + * 0 - No PPGTT
> + * 1 - Aliasing PPGTT
> + * 2 - Full PPGTT (32b)
> + * 3 - Full PPGTT (48b)
> + * RETURNS true/false if min support is present
> +*/
> +static bool uses_full_ppgtt(int fd, int min)
> +{
> +	struct drm_i915_getparam gp;
> +	int val = 0;
> +
> +	memset(&gp, 0, sizeof(gp));
> +	gp.param = 18; /* HAS_ALIASING_PPGTT */
> +	gp.value = &val;
> +
> +	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
> +		return 0;
> +
> +	errno = 0;
> +	return val >= min;
> +}
> +
> +/* has_softpin_support
> + * Finds if softpin feature is supported
> + * @fd DRM fd
> +*/
> +static bool has_softpin_support(int fd)
> +{
> +	struct drm_i915_getparam gp;
> +	int val = 0;
> +
> +	memset(&gp, 0, sizeof(gp));
> +	gp.param = 37; /* I915_PARAM_HAS_EXEC_SOFTPIN */
> +	gp.value = &val;
> +
> +	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
> +		return 0;
> +
> +	errno = 0;
> +	return (val == 1);
> +}
> +
> +/* gem_call_userptr_ioctl
> + * Helper to call ioctl - TODO: move to lib
> + * @fd - drm fd
> + * @userptr - pointer to initialised userptr
> + * RETURNS status of ioctl call
> +*/
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr)
> +{
> +	int ret;
> +
> +	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
> +
> +	if (ret)
> +		ret = errno;
> +
> +	return ret;
> +}
> +
> +/* init_userptr
> + * Helper that inits userptr an returns handle
> + * @fd - drm fd
> + * @userptr - pointer to empty userptr
> + * @ptr - buffer to be shared
> + * @size - size of buffer
> + * @ro - read only flag
> + * RETURNS handle to shared buffer
> +*/
> +static uint32_t init_userptr(int fd, i915_gem_userptr *userptr, void *ptr,
> +			     uint64_t size)
> +{
> +	int ret;
> +
> +	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
> +
> +	userptr->user_ptr = (uint64_t)ptr; /* Need the cast to overcome compiler warning */
> +	userptr->user_size = size;
> +	userptr->flags = 0; /* use synchronized operation */
> +
> +	ret = gem_call_userptr_ioctl(fd, userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	return userptr->handle;
> +}
> +
> +/* create_mem_buffer
> + * Creates a 4K aligned CPU buffer
> + * @size - size of buffer
> + * RETURNS pointer to buffer of @size
> +*/
> +static void *create_mem_buffer(uint64_t size)
> +{
> +	void *addr;
> +	int ret;
> +
> +	ret = posix_memalign(&addr, 4096, size);
> +	igt_assert(ret == 0);
> +
> +	return addr;
> +}
> +
> +/* setup_exec_obj
> + * populate exec object
> + * @exec - exec object
> + * @handle - handle to gem buffer
> + * @flags - any flags
> + * @offset - requested VMA
> +*/
> +static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec,
> +			   uint32_t handle, uint32_t flags,
> +			   uint64_t offset)
> +{
> +	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
> +	exec->handle = handle;
> +	exec->flags = flags;
> +	exec->offset = offset;
> +}
> +
> +/* gem_store_data_svm
> + * populate batch buffer with MI_STORE_DWORD_IMM command
> + * @fd: drm file descriptor
> + * @cmd_buf: batch buffer
> + * @vaddr: destination Virtual address
> + * @data: data to be store at destination
> + * @end: whether to end batch buffer or not
> +*/
> +static int gem_store_data_svm(int fd, uint32_t *cmd_buf, uint64_t vaddr,
> +			      uint32_t data, bool end)
> +{
> +	int i = 0;
> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
> +	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
> +
> +	cmd_buf[i++] = data;
> +	if (end) {
> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	return(i * sizeof(uint32_t));
> +}
> +
> +/* gem_store_data
> + * populate batch buffer with MI_STORE_DWORD_IMM command
> + * This one fills up reloc buffer as well
> + * @fd: drm file descriptor
> + * @cmd_buf: batch buffer
> + * @data: data to be store at destination
> + * @reloc - relocation entry
> + * @end: whether to end batch buffer or not
> +*/
> +static int gem_store_data(int fd, uint32_t *cmd_buf,
> +			  uint32_t handle, uint32_t data,
> +			  struct drm_i915_gem_relocation_entry *reloc,
> +			  bool end)
> +{
> +	int i = 0;
> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 reloc needed */
> +	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 reloc needed */
> +	reloc->offset = 1 * sizeof(uint32_t);
> +	reloc->delta = 0;
> +	reloc->target_handle = handle;
> +	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
> +	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
> +	reloc->presumed_offset = 0;
> +	cmd_buf[i++] = data;
> +	if (end) {
> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	return (i * sizeof(uint32_t));
> +}
> +
> +/* setup_execbuffer
> + * helper for buffer execution
> + * @execbuf - pointer to execbuffer
> + * @exec_object - pointer to exec object2 struct
> + * @ring - ring to be used
> + * @buffer_count - how manu buffers to submit
> + * @batch_length - length of batch buffer
> +*/
> +static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf,
> +			     struct drm_i915_gem_exec_object2 *exec_object,
> +			     int ring, int buffer_count, int batch_length)
> +{
> +	execbuf->buffers_ptr = (uint64_t)exec_object;
> +	execbuf->buffer_count = buffer_count;
> +	execbuf->batch_start_offset = 0;
> +	execbuf->batch_len = batch_length;
> +	execbuf->cliprects_ptr = 0;
> +	execbuf->num_cliprects = 0;
> +	execbuf->DR1 = 0;
> +	execbuf->DR4 = 0;
> +	execbuf->flags = ring;
> +	i915_execbuffer2_set_context_id(*execbuf, 0);
> +	execbuf->rsvd2 = 0;
> +}
> +
> +/* submit_and_sync
> + * Helper function for exec and sync functions
> + * @fd - drm fd
> + * @execbuf - pointer to execbuffer
> + * @batch_buf_handle - batch buffer handle
> +*/
> +static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf,
> +			    uint32_t batch_buf_handle)
> +{
> +	gem_execbuf(fd, execbuf);
> +	gem_sync(fd, batch_buf_handle);
> +}
> +
> +/* gem_userptr_sync
> + * helper for syncing to CPU domain - copy/paste from userblit
> + * @fd - drm fd
> + * @handle - buffer handle to sync
> +*/
> +static void gem_userptr_sync(int fd, uint32_t handle)
> +{
> +	gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
> +}
> +
> +
> +/* gem_pin_userptr_test
> + * This test will create a shared buffer, and create a command
> + * for GPU to write data in it
> + * CPU will read and make sure expected value is obtained
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +static void gem_pin_userptr_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	/* Check if driver pinned the buffer as requested */
> +	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
> +			"\nFailed to pin at requested offset");
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		      "\nCPU read does not match GPU write,\
> +			expected: 0x%x, got: 0x%x\n",
> +			data, shared_buffer[0]);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_bo
> + * This test will test softpinning of a gem buffer object
> + * Malloc a 4K buffer
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000
> + * Submit execbuffer
> + * Verify value pinned offset matches the request
> +*/
> +static void gem_pin_bo_test(void)
> +{
> +	int fd;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, unshared_buf_handle;
> +	struct drm_i915_gem_relocation_entry reloc[4];
> +	int ring, len;
> +	uint32_t value;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create gem buffer */
> +	unshared_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data(fd, batch_buffer, unshared_buf_handle, data,
> +				reloc, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], unshared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +	exec_object2[1].relocation_count = 1;
> +	exec_object2[1].relocs_ptr = (uint64_t)reloc;
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	/* Check if driver pinned the buffer as requested */
> +	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
> +			"\nFailed to pin at requested offset");
> +	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
> +	igt_assert(value == data);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, unshared_buf_handle);
> +	close(fd);
> +}
> +
> +
> +/* gem_multiple_process_test
> + * Run basic test simultaneously with multiple processes
> + * This will test pinning same VA separately in each process
> +
> + * fork();
> + * Execute basic test in parent/child processes
> +*/
> +#define MAX_NUM_PROCESSES 10
> +
> +static void gem_multiple_process_test(void)
> +{
> +	int fd;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	igt_fork(child, MAX_NUM_PROCESSES) {
> +		gem_pin_userptr_test();
> +	}
> +	igt_waitchildren();
> +
> +	close(fd);
> +}
> +
> +
> +/* gem_repin_test
> + * This test tries to repin a buffer at a previously pinned vma
> + * from a different execbuf.
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000 VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +
> + * Create second shared buffer
> + * Follow all steps above
> + * Execpt, for offset, use VMA of first buffer above
> + * Submit execbuffer
> + * Verify value of first DWORD in second shared buffer matches DATA
> +*/
> +static void gem_repin_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	uint32_t *shared_buffer1;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	/* Create gem object */
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set first elements to 0x0 */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE);
> +	shared_buffer[0] = 0x0;
> +	shared_buffer1[0] = 0x0;
> +
> +	/* share with GPU and get handles */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> +					  BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	igt_assert(*shared_buffer == data);
> +
> +	/* Second buffer */
> +	/* create command buffer with write command */
> +	pinning_offset = exec_object2[0].offset;
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	/* Pin at shared_buffer, not shared_buffer1 */
> +	/* We are requesting address where another buffer was pinned previously */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle1,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle1);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	igt_assert(*shared_buffer1 == data);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +
> +/* gem_repin_overlap_test
> + * This test will attempt to pin two buffers at the same VMA as part of the same
> +   execbuffer object
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create second shared buffer
> + * Create batch buffer to write DATA to first dword of each buffer
> + * Use same virtual address as destination addresses in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in both exec objects
> + * Set 'offset' in both exec objects to same VMA
> + * Submit execbuffer
> + * Command should return EINVAL, since we are trying to pin to same VMA
> +*/
> +static void gem_pin_overlap_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd, ret;
> +	uint32_t *shared_buffer;
> +	uint32_t *shared_buffer1;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[3];
> +	uint32_t shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> +					  BO_SIZE * 2);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], shared_buf_handle1,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +
> +	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, &execbuf);
> +
> +	/* expect to fail */
> +	igt_assert_neq(ret, 0);
> +	igt_assert(errno == EINVAL);
> +
> +	close(fd);
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +/* gem_softpin_stress_test
> + * Stress test which creates 10K buffers and shares with GPU
> + * Create 100K uint32 buffers of size 4K each
> + * Share with GPU using userptr ioctl
> + * Create batch buffer to write DATA in first element of each buffer
> + * Pin each buffer to varying addresses starting from 0x800000000000 going below
> + * Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
> + * Validate every buffer has DATA in first element
> + * Rinse and Repeat on Render ring
> +*/
> +#define STRESS_NUM_BUFFERS 100000
> +#define STRESS_NUM_LOOPS 100
> +#define STRESS_STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
> +
> +static void gem_softpin_stress_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t **shared_buffer;
> +	uint32_t *shared_handle;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 *exec_object2;
> +	uint32_t *batch_buffer;
> +	uint32_t batch_buf_handle;
> +	int ring, len;
> +	int buf, loop;
> +	uint64_t pinning_offset = 0x800000000000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +
> +	/* Allocate blobs for all data structures */
> +	shared_handle = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t));
> +	shared_buffer = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t *));
> +	exec_object2 = calloc(STRESS_NUM_BUFFERS + 1,
> +				sizeof(struct drm_i915_gem_exec_object2));
> +	/* 4 dwords per buffer + 2 for the end of batchbuffer */
> +	batch_buffer = calloc(STRESS_STORE_COMMANDS + 2, sizeof(uint32_t));
> +	batch_buf_handle = gem_create(fd, (STRESS_STORE_COMMANDS + 2)*4);
> +
> +	/* create command buffer with write commands */
> +	len = 0;
> +	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +		shared_buffer[buf] = create_mem_buffer(BO_SIZE);
> +		*shared_buffer[buf] = 0xFFFFFFFF;
> +
> +		/* share with GPU */
> +		shared_handle[buf] = init_userptr(fd, &userptr,
> +						  shared_buffer[buf],
> +						  BO_SIZE);
> +
> +		setup_exec_obj(&exec_object2[buf], shared_handle[buf],
> +			       EXEC_OBJECT_PINNED |
> +			       EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
> +			       pinning_offset);
> +		len += gem_store_data_svm(fd, batch_buffer + (len/4),
> +					  pinning_offset, buf,
> +					  (buf == STRESS_NUM_BUFFERS-1)? \
> +					  true:false);
> +
> +		/* decremental 4K aligned address */
> +		pinning_offset -= ALIGN(BO_SIZE, 4096);
> +	}
> +
> +	/* setup command buffer */
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle,
> +		       0, 0);
> +
> +	/* We want to run this on BLT ring if possible */
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd))) {
> +		ring = I915_EXEC_BLT;
> +
> +		setup_execbuffer(&execbuf, exec_object2, ring,
> +				 STRESS_NUM_BUFFERS + 1, len);
> +
> +		for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
> +			submit_and_sync(fd, &execbuf, batch_buf_handle);
> +			/* Set pinning offset back to original value */
> +			pinning_offset = 0x800000000000;
> +			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +				gem_userptr_sync(fd, shared_handle[buf]);
> +				igt_assert(exec_object2[buf].offset == pinning_offset);
> +				igt_fail_on_f(*shared_buffer[buf] != buf, \
> +				"Mismatch in buffer %d, iteration %d: 0x%08X\n", \
> +				buf, loop, *shared_buffer[buf]);
> +				pinning_offset -= ALIGN(BO_SIZE, 4096);
> +			}
> +			/* Reset the buffer entries for next iteration */
> +			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +				*shared_buffer[buf] = 0xFFFFFFFF;
> +			}
> +		}
> +	}
> +
> +	/* Now Render Ring */
> +	ring = I915_EXEC_RENDER;
> +	setup_execbuffer(&execbuf, exec_object2, ring,
> +			 STRESS_NUM_BUFFERS + 1, len);
> +	for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		pinning_offset = 0x800000000000;
> +		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +			gem_userptr_sync(fd, shared_handle[buf]);
> +			igt_assert(exec_object2[buf].offset == pinning_offset);
> +			igt_fail_on_f(*shared_buffer[buf] != buf, \
> +			"Mismatch in buffer %d, \
> +			iteration %d: 0x%08X\n", buf, loop, *shared_buffer[buf]);
> +			pinning_offset -= ALIGN(BO_SIZE, 4096);
> +		}
> +		/* Reset the buffer entries for next iteration */
> +		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +			*shared_buffer[buf] = 0xFFFFFFFF;
> +		}
> +	}
> +
> +	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +		gem_close(fd, shared_handle[buf]);
> +		free(shared_buffer[buf]);
> +	}
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_handle);
> +	free(shared_buffer);
> +	free(exec_object2);
> +	free(batch_buffer);
> +}
> +
> +/* gem_write_multipage_buffer
> + * Create a buffer spanning multiple pages, and share with GPU.
> + * Write to every element of the buffer
> + * and verify correct contents.
> +
> + * Create 8K buffer
> + * Share with GPU using userptr ioctl
> + * Create batch buffer to write DATA in all elements of buffer
> + * Execute Batch Buffer
> + * Validate every element has DATA
> +*/
> +
> +#define DWORD_SIZE sizeof(uint32_t)
> +#define BB_SIZE ((MULTIPAGE_BO_SIZE / DWORD_SIZE) * STORE_BATCH_BUFFER_SIZE) + 2
> +#define NUM_DWORDS (MULTIPAGE_BO_SIZE/sizeof(uint32_t))
> +static void gem_write_multipage_buffer_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	uint32_t shared_handle;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[BB_SIZE];
> +	uint32_t batch_buf_handle;
> +	int ring, len, j;
> +	uint64_t pinning_offset=0x1000;
> +	uint64_t vaddr;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
> +	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
> +
> +	len = 0;
> +	memset(batch_buffer, 0, sizeof(batch_buffer));
> +	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
> +
> +	/* share with GPU */
> +	shared_handle = init_userptr(fd, &userptr, shared_buffer,
> +				     MULTIPAGE_BO_SIZE);
> +	setup_exec_obj(&exec_object2[0], shared_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +
> +	/* create command buffer with write commands */
> +	vaddr = pinning_offset;
> +	for(j=0; j< NUM_DWORDS; j++) {
> +		len += gem_store_data_svm(fd, batch_buffer + (len/4), vaddr,
> +					  j,
> +					  (j == NUM_DWORDS - 1) ? true:false);
> +		vaddr += sizeof(shared_buffer[0]);  /* 4 bytes */
> +	}
> +
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_handle);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	for(j = 0; j < (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++) {
> +		igt_fail_on_f(shared_buffer[j] != j,
> +		"Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_invalid_vma_test
> + * This test will request to pin a shared buffer to an invalid
> + * VMA  > 48-bit address if system supports 48B PPGTT; it also
> + * will test that any attempt of using a 48-bit address requires
> + * the SUPPORTS_48B_ADDRESS flag.
> + * If system supports 32B PPGTT, it will test the equivalent invalid VMA
> + * Create shared buffer of size 4K
> + * Try and Pin object to invalid address
> +*/
> +static void gem_pin_invalid_vma_test(bool test_decouple_flags)
> +{
> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[1];
> +	uint32_t shared_buf_handle;
> +	int ring;
> +	uint64_t invalid_address_for_48b = 0x9000000000000; /* 52 bit address */
> +	uint64_t invalid_address_for_32b = 0x900000000; /* 36 bit address */
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT) ||
> +		    uses_full_ppgtt(fd, FULL_32_BIT_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	if (uses_full_ppgtt(fd, FULL_48_BIT_PPGTT) && !test_decouple_flags) {
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
> +			       invalid_address_for_48b);
> +	} else {
> +		/* This also fails in 48b without 48B_ADDRESS support flag */
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED, invalid_address_for_32b);
> +	}
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 1, 0);
> +
> +	/* Expect execbuf to fail */
> +	ret = drmIoctl(fd,
> +		       DRM_IOCTL_I915_GEM_EXECBUFFER2,
> +		       &execbuf);
> +
> +	igt_assert(errno == EINVAL);
> +	igt_assert_neq(ret, 0);
> +
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +
> +/* gem_pin_high_address_test
> + * This test will create a shared buffer, and create a command
> + * for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
> + * CPU will read and make sure expected value is obtained
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use virtual address of buffer as 0x1100000000 (> 32 bit)
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to shared buffer VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +
> +static void gem_pin_high_address_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	igt_assert(exec_object2[0].offset == high_address);
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, \
> +		expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_near_48Bit_test
> + * This test will create a shared buffer,
> + * and create a command for GPU to write data in it. It will attempt
> + * to pin the buffer at address > 47 bits <= 48-bit.
> + * CPU will read and make sure expected value is obtained
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use virtual address of buffer as range between 47-bit and 48-bit
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to shared buffer VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000
> +#define END_HIGH_ADDRESS 0xFFFFFFFFC000
> +#define ADDRESS_INCREMENT 0x2000000000
> +static void gem_pin_near_48Bit_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS;
> +						high_address+=ADDRESS_INCREMENT) {
> +		/* create command buffer with write command */
> +		len = gem_store_data_svm(fd, batch_buffer, high_address,
> +					data, true);
> +		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +		/* submit command buffer */
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
> +			       high_address);
> +		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +		ring = I915_EXEC_RENDER;
> +		setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		gem_userptr_sync(fd, shared_buf_handle);
> +
> +		igt_assert(exec_object2[0].offset == high_address);
> +		/* check on CPU to see if value changes */
> +		igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, expected: 0x%x, \
> +		got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +
> +int main(int argc, char* argv[])
> +{
> +	igt_subtest_init(argc, argv);
> +	igt_skip_on_simulation();
> +
> +	/* All tests need PPGTT support */
> +	igt_subtest("gem_pin_userptr") {
> +		gem_pin_userptr_test();
> +	}
> +	igt_subtest("gem_pin_bo") {
> +		gem_pin_bo_test();
> +	}
> +	igt_subtest("gem_multiple_process") {
> +		gem_multiple_process_test();
> +	}
> +	igt_subtest("gem_repin") {
> +		gem_repin_test();
> +	}
> +	igt_subtest("gem_pin_overlap") {
> +		gem_pin_overlap_test();
> +	}
> +	igt_subtest("gem_write_multipage_buffer") {
> +		gem_write_multipage_buffer_test();
> +	}
> +
> +	/* Following tests need 32/48 Bit PPGTT support */
> +	igt_subtest("gem_pin_invalid_vma") {
> +		gem_pin_invalid_vma_test(false);
> +	}
> +
> +	/* Following tests need 48 Bit PPGTT support */
> +	igt_subtest("gem_pin_high_address_without_correct_flag") {
> +		gem_pin_invalid_vma_test(true);
> +	}
> +	igt_subtest("gem_softpin_stress") {
> +		gem_softpin_stress_test();
> +	}
> +	igt_subtest("gem_pin_high_address") {
> +		gem_pin_high_address_test();
> +	}
> +	igt_subtest("gem_pin_near_48Bit") {
> +		gem_pin_near_48Bit_test();
> +	}
> +
> +	igt_exit();
> +}
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
  2015-12-03  8:36 Vinay Belgaumkar
  2015-12-03 16:42 ` Tvrtko Ursulin
@ 2015-12-08 11:57 ` Michel Thierry
  2015-12-08 12:16   ` Tvrtko Ursulin
  1 sibling, 1 reply; 19+ messages in thread
From: Michel Thierry @ 2015-12-08 11:57 UTC (permalink / raw)
  To: intel-gfx

From: Vinay Belgaumkar <vinay.belgaumkar@intel.com>

These tests exercise the userptr ioctl to create shared buffers
between CPU and GPU. They contain error and normal usage scenarios.
They also contain a couple of stress tests which copy buffers between
CPU and GPU. These tests rely on the softpin patch in order to pin buffers
to a certain VA.

Caveat: These tests were designed to run on 64-bit system. Future work
includes adding logic to ensure these tests can run on 32-bit systems with
PPGTT support. Some tests are currently disabled for 32-bit systems for that
reason.

v2: Added cc and signed-off-by fields

v3: Fixed review comments, added helper functions. Removed userptr error
scenarios covered by existing userptr tests. Modified stress test to have
100K buffers, it now runs for ~30 mins, checks every element has been written
to correctly, and pins buffers at different VMAs.

v4: Changed name to gem_softpin

v5: More fixes. Removed the file based tests, will move them to userptr tests.
Added a function that validates appropriate PPGTT support before running tests.
Optimized stack space and memory footprint in stress test. Removed the eviction
test, will add it back after verifying proper functionality.

v6: Split basic test into userptr and bo
Fixed some coding style issues.

v7: Enhanced invalid vma pinning test to verify 32-bit PPGTT functionality.
Enabled the test for 32-bit PPGTT systems, and verify pinning fails above
32-bit addresses. Enhanced the high adress pinning test to ensure pinning
fails when EXEC_OBJECT_PINNED flag is not used. Some more cosmetic fixes to
close buffer handles. Changed userptr function to used synchronized operations.

v8: Minor change to high address pinning test as per comment.

v9: Skip the tests if softpin support is not present.

v10: Removed trailing white spaces.

v11: Keep alphabetical order in Makefile and gitignore; update error code
returned while trying to pin above the max vm size (EINVAL); test attempt
to pin above 4GB without the support 48b flag.

Cc: Michel Thierry <michel.thierry@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com> (v10)
Signed-off-by: Michel Thierry <michel.thierry@intel.com> (v11)
---
 tests/.gitignore       |    1 +
 tests/Makefile.sources |    1 +
 tests/gem_softpin.c    | 1084 ++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 1086 insertions(+)
 create mode 100644 tests/gem_softpin.c

diff --git a/tests/.gitignore b/tests/.gitignore
index 6377007..7f20f2b 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -101,6 +101,7 @@ gem_seqno_wrap
 gem_set_tiling_vs_blt
 gem_set_tiling_vs_gtt
 gem_set_tiling_vs_pwrite
+gem_softpin
 gem_storedw_batches_loop
 gem_streaming_writes
 gem_stress
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index ef4154f..d594038 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -58,6 +58,7 @@ TESTS_progs_M = \
 	gem_reset_stats \
 	gem_ringfill \
 	gem_set_tiling_vs_blt \
+	gem_softpin \
 	gem_stolen \
 	gem_storedw_batches_loop \
 	gem_streaming_writes \
diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
new file mode 100644
index 0000000..7bee16b
--- /dev/null
+++ b/tests/gem_softpin.c
@@ -0,0 +1,1084 @@
+/*
+ * Copyright © 2015 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ * Authors:
+ *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
+ *    Thomas Daniel <thomas.daniel@intel.com>
+ *
+ */
+
+#include <unistd.h>
+#include <stdlib.h>
+#include <stdint.h>
+#include <stdio.h>
+#include <string.h>
+#include <fcntl.h>
+#include <inttypes.h>
+#include <errno.h>
+#include <sys/stat.h>
+#include <sys/ioctl.h>
+#include <sys/time.h>
+#include <malloc.h>
+#include "drm.h"
+#include "ioctl_wrappers.h"
+#include "drmtest.h"
+#include "intel_chipset.h"
+#include "intel_io.h"
+#include "i915_drm.h"
+#include <assert.h>
+#include <sys/wait.h>
+#include <sys/ipc.h>
+#include <sys/shm.h>
+#include "igt_kms.h"
+#include <inttypes.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+
+#define BO_SIZE 4096
+#define MULTIPAGE_BO_SIZE 2 * BO_SIZE
+#define STORE_BATCH_BUFFER_SIZE 4
+#define EXEC_OBJECT_PINNED	(1<<4)
+#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
+#define SHARED_BUFFER_SIZE 4096
+
+typedef struct drm_i915_gem_userptr i915_gem_userptr;
+
+static uint32_t init_userptr(int fd, i915_gem_userptr *, void *ptr, uint64_t size);
+static void *create_mem_buffer(uint64_t size);
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
+static void gem_pin_userptr_test(void);
+static void gem_pin_bo_test(void);
+static void gem_pin_invalid_vma_test(bool test_decouple_flags);
+static void gem_pin_overlap_test(void);
+static void gem_pin_high_address_test(void);
+
+#define NO_PPGTT 0
+#define ALIASING_PPGTT 1
+#define FULL_32_BIT_PPGTT 2
+#define FULL_48_BIT_PPGTT 3
+/* uses_full_ppgtt
+ * Finds supported PPGTT details.
+ * @fd DRM fd
+ * @min can be
+ * 0 - No PPGTT
+ * 1 - Aliasing PPGTT
+ * 2 - Full PPGTT (32b)
+ * 3 - Full PPGTT (48b)
+ * RETURNS true/false if min support is present
+*/
+static bool uses_full_ppgtt(int fd, int min)
+{
+	struct drm_i915_getparam gp;
+	int val = 0;
+
+	memset(&gp, 0, sizeof(gp));
+	gp.param = 18; /* HAS_ALIASING_PPGTT */
+	gp.value = &val;
+
+	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
+		return 0;
+
+	errno = 0;
+	return val >= min;
+}
+
+/* has_softpin_support
+ * Finds if softpin feature is supported
+ * @fd DRM fd
+*/
+static bool has_softpin_support(int fd)
+{
+	struct drm_i915_getparam gp;
+	int val = 0;
+
+	memset(&gp, 0, sizeof(gp));
+	gp.param = 37; /* I915_PARAM_HAS_EXEC_SOFTPIN */
+	gp.value = &val;
+
+	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
+		return 0;
+
+	errno = 0;
+	return (val == 1);
+}
+
+/* gem_call_userptr_ioctl
+ * Helper to call ioctl - TODO: move to lib
+ * @fd - drm fd
+ * @userptr - pointer to initialised userptr
+ * RETURNS status of ioctl call
+*/
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr)
+{
+	int ret;
+
+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
+
+	if (ret)
+		ret = errno;
+
+	return ret;
+}
+
+/* init_userptr
+ * Helper that inits userptr an returns handle
+ * @fd - drm fd
+ * @userptr - pointer to empty userptr
+ * @ptr - buffer to be shared
+ * @size - size of buffer
+ * @ro - read only flag
+ * RETURNS handle to shared buffer
+*/
+static uint32_t init_userptr(int fd, i915_gem_userptr *userptr, void *ptr,
+			     uint64_t size)
+{
+	int ret;
+
+	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
+
+	userptr->user_ptr = (uint64_t)ptr; /* Need the cast to overcome compiler warning */
+	userptr->user_size = size;
+	userptr->flags = 0; /* use synchronized operation */
+
+	ret = gem_call_userptr_ioctl(fd, userptr);
+	igt_assert_eq(ret, 0);
+
+	return userptr->handle;
+}
+
+/* create_mem_buffer
+ * Creates a 4K aligned CPU buffer
+ * @size - size of buffer
+ * RETURNS pointer to buffer of @size
+*/
+static void *create_mem_buffer(uint64_t size)
+{
+	void *addr;
+	int ret;
+
+	ret = posix_memalign(&addr, 4096, size);
+	igt_assert(ret == 0);
+
+	return addr;
+}
+
+/* setup_exec_obj
+ * populate exec object
+ * @exec - exec object
+ * @handle - handle to gem buffer
+ * @flags - any flags
+ * @offset - requested VMA
+*/
+static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec,
+			   uint32_t handle, uint32_t flags,
+			   uint64_t offset)
+{
+	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
+	exec->handle = handle;
+	exec->flags = flags;
+	exec->offset = offset;
+}
+
+/* gem_store_data_svm
+ * populate batch buffer with MI_STORE_DWORD_IMM command
+ * @fd: drm file descriptor
+ * @cmd_buf: batch buffer
+ * @vaddr: destination Virtual address
+ * @data: data to be store at destination
+ * @end: whether to end batch buffer or not
+*/
+static int gem_store_data_svm(int fd, uint32_t *cmd_buf, uint64_t vaddr,
+			      uint32_t data, bool end)
+{
+	int i = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
+	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
+
+	cmd_buf[i++] = data;
+	if (end) {
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	return(i * sizeof(uint32_t));
+}
+
+/* gem_store_data
+ * populate batch buffer with MI_STORE_DWORD_IMM command
+ * This one fills up reloc buffer as well
+ * @fd: drm file descriptor
+ * @cmd_buf: batch buffer
+ * @data: data to be store at destination
+ * @reloc - relocation entry
+ * @end: whether to end batch buffer or not
+*/
+static int gem_store_data(int fd, uint32_t *cmd_buf,
+			  uint32_t handle, uint32_t data,
+			  struct drm_i915_gem_relocation_entry *reloc,
+			  bool end)
+{
+	int i = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 reloc needed */
+	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 reloc needed */
+	reloc->offset = 1 * sizeof(uint32_t);
+	reloc->delta = 0;
+	reloc->target_handle = handle;
+	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
+	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
+	reloc->presumed_offset = 0;
+	cmd_buf[i++] = data;
+	if (end) {
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	return (i * sizeof(uint32_t));
+}
+
+/* setup_execbuffer
+ * helper for buffer execution
+ * @execbuf - pointer to execbuffer
+ * @exec_object - pointer to exec object2 struct
+ * @ring - ring to be used
+ * @buffer_count - how manu buffers to submit
+ * @batch_length - length of batch buffer
+*/
+static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf,
+			     struct drm_i915_gem_exec_object2 *exec_object,
+			     int ring, int buffer_count, int batch_length)
+{
+	execbuf->buffers_ptr = (uint64_t)exec_object;
+	execbuf->buffer_count = buffer_count;
+	execbuf->batch_start_offset = 0;
+	execbuf->batch_len = batch_length;
+	execbuf->cliprects_ptr = 0;
+	execbuf->num_cliprects = 0;
+	execbuf->DR1 = 0;
+	execbuf->DR4 = 0;
+	execbuf->flags = ring;
+	i915_execbuffer2_set_context_id(*execbuf, 0);
+	execbuf->rsvd2 = 0;
+}
+
+/* submit_and_sync
+ * Helper function for exec and sync functions
+ * @fd - drm fd
+ * @execbuf - pointer to execbuffer
+ * @batch_buf_handle - batch buffer handle
+*/
+static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf,
+			    uint32_t batch_buf_handle)
+{
+	gem_execbuf(fd, execbuf);
+	gem_sync(fd, batch_buf_handle);
+}
+
+/* gem_userptr_sync
+ * helper for syncing to CPU domain - copy/paste from userblit
+ * @fd - drm fd
+ * @handle - buffer handle to sync
+*/
+static void gem_userptr_sync(int fd, uint32_t handle)
+{
+	gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
+}
+
+
+/* gem_pin_userptr_test
+ * This test will create a shared buffer, and create a command
+ * for GPU to write data in it
+ * CPU will read and make sure expected value is obtained
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+static void gem_pin_userptr_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	/* Check if driver pinned the buffer as requested */
+	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
+			"\nFailed to pin at requested offset");
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		      "\nCPU read does not match GPU write,\
+			expected: 0x%x, got: 0x%x\n",
+			data, shared_buffer[0]);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/* gem_pin_bo
+ * This test will test softpinning of a gem buffer object
+ * Malloc a 4K buffer
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000
+ * Submit execbuffer
+ * Verify value pinned offset matches the request
+*/
+static void gem_pin_bo_test(void)
+{
+	int fd;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, unshared_buf_handle;
+	struct drm_i915_gem_relocation_entry reloc[4];
+	int ring, len;
+	uint32_t value;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create gem buffer */
+	unshared_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data(fd, batch_buffer, unshared_buf_handle, data,
+				reloc, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], unshared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+	exec_object2[1].relocation_count = 1;
+	exec_object2[1].relocs_ptr = (uint64_t)reloc;
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	/* Check if driver pinned the buffer as requested */
+	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
+			"\nFailed to pin at requested offset");
+	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
+	igt_assert(value == data);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, unshared_buf_handle);
+	close(fd);
+}
+
+
+/* gem_multiple_process_test
+ * Run basic test simultaneously with multiple processes
+ * This will test pinning same VA separately in each process
+
+ * fork();
+ * Execute basic test in parent/child processes
+*/
+#define MAX_NUM_PROCESSES 10
+
+static void gem_multiple_process_test(void)
+{
+	int fd;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	igt_fork(child, MAX_NUM_PROCESSES) {
+		gem_pin_userptr_test();
+	}
+	igt_waitchildren();
+
+	close(fd);
+}
+
+
+/* gem_repin_test
+ * This test tries to repin a buffer at a previously pinned vma
+ * from a different execbuf.
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000 VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+
+ * Create second shared buffer
+ * Follow all steps above
+ * Execpt, for offset, use VMA of first buffer above
+ * Submit execbuffer
+ * Verify value of first DWORD in second shared buffer matches DATA
+*/
+static void gem_repin_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd;
+	uint32_t *shared_buffer;
+	uint32_t *shared_buffer1;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	/* Create gem object */
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set first elements to 0x0 */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE);
+	shared_buffer[0] = 0x0;
+	shared_buffer1[0] = 0x0;
+
+	/* share with GPU and get handles */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
+					  BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	igt_assert(*shared_buffer == data);
+
+	/* Second buffer */
+	/* create command buffer with write command */
+	pinning_offset = exec_object2[0].offset;
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	/* Pin at shared_buffer, not shared_buffer1 */
+	/* We are requesting address where another buffer was pinned previously */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle1,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle1);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	igt_assert(*shared_buffer1 == data);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+
+/* gem_repin_overlap_test
+ * This test will attempt to pin two buffers at the same VMA as part of the same
+   execbuffer object
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create second shared buffer
+ * Create batch buffer to write DATA to first dword of each buffer
+ * Use same virtual address as destination addresses in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in both exec objects
+ * Set 'offset' in both exec objects to same VMA
+ * Submit execbuffer
+ * Command should return EINVAL, since we are trying to pin to same VMA
+*/
+static void gem_pin_overlap_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd, ret;
+	uint32_t *shared_buffer;
+	uint32_t *shared_buffer1;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[3];
+	uint32_t shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
+					  BO_SIZE * 2);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], shared_buf_handle1,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+
+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, &execbuf);
+
+	/* expect to fail */
+	igt_assert_neq(ret, 0);
+	igt_assert(errno == EINVAL);
+
+	close(fd);
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+/* gem_softpin_stress_test
+ * Stress test which creates 10K buffers and shares with GPU
+ * Create 100K uint32 buffers of size 4K each
+ * Share with GPU using userptr ioctl
+ * Create batch buffer to write DATA in first element of each buffer
+ * Pin each buffer to varying addresses starting from 0x800000000000 going below
+ * Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
+ * Validate every buffer has DATA in first element
+ * Rinse and Repeat on Render ring
+*/
+#define STRESS_NUM_BUFFERS 100000
+#define STRESS_NUM_LOOPS 100
+#define STRESS_STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
+
+static void gem_softpin_stress_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t **shared_buffer;
+	uint32_t *shared_handle;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 *exec_object2;
+	uint32_t *batch_buffer;
+	uint32_t batch_buf_handle;
+	int ring, len;
+	int buf, loop;
+	uint64_t pinning_offset = 0x800000000000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+
+	/* Allocate blobs for all data structures */
+	shared_handle = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t));
+	shared_buffer = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t *));
+	exec_object2 = calloc(STRESS_NUM_BUFFERS + 1,
+				sizeof(struct drm_i915_gem_exec_object2));
+	/* 4 dwords per buffer + 2 for the end of batchbuffer */
+	batch_buffer = calloc(STRESS_STORE_COMMANDS + 2, sizeof(uint32_t));
+	batch_buf_handle = gem_create(fd, (STRESS_STORE_COMMANDS + 2)*4);
+
+	/* create command buffer with write commands */
+	len = 0;
+	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+		shared_buffer[buf] = create_mem_buffer(BO_SIZE);
+		*shared_buffer[buf] = 0xFFFFFFFF;
+
+		/* share with GPU */
+		shared_handle[buf] = init_userptr(fd, &userptr,
+						  shared_buffer[buf],
+						  BO_SIZE);
+
+		setup_exec_obj(&exec_object2[buf], shared_handle[buf],
+			       EXEC_OBJECT_PINNED |
+			       EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
+			       pinning_offset);
+		len += gem_store_data_svm(fd, batch_buffer + (len/4),
+					  pinning_offset, buf,
+					  (buf == STRESS_NUM_BUFFERS-1)? \
+					  true:false);
+
+		/* decremental 4K aligned address */
+		pinning_offset -= ALIGN(BO_SIZE, 4096);
+	}
+
+	/* setup command buffer */
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle,
+		       0, 0);
+
+	/* We want to run this on BLT ring if possible */
+	if (HAS_BLT_RING(intel_get_drm_devid(fd))) {
+		ring = I915_EXEC_BLT;
+
+		setup_execbuffer(&execbuf, exec_object2, ring,
+				 STRESS_NUM_BUFFERS + 1, len);
+
+		for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
+			submit_and_sync(fd, &execbuf, batch_buf_handle);
+			/* Set pinning offset back to original value */
+			pinning_offset = 0x800000000000;
+			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+				gem_userptr_sync(fd, shared_handle[buf]);
+				igt_assert(exec_object2[buf].offset == pinning_offset);
+				igt_fail_on_f(*shared_buffer[buf] != buf, \
+				"Mismatch in buffer %d, iteration %d: 0x%08X\n", \
+				buf, loop, *shared_buffer[buf]);
+				pinning_offset -= ALIGN(BO_SIZE, 4096);
+			}
+			/* Reset the buffer entries for next iteration */
+			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+				*shared_buffer[buf] = 0xFFFFFFFF;
+			}
+		}
+	}
+
+	/* Now Render Ring */
+	ring = I915_EXEC_RENDER;
+	setup_execbuffer(&execbuf, exec_object2, ring,
+			 STRESS_NUM_BUFFERS + 1, len);
+	for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		pinning_offset = 0x800000000000;
+		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+			gem_userptr_sync(fd, shared_handle[buf]);
+			igt_assert(exec_object2[buf].offset == pinning_offset);
+			igt_fail_on_f(*shared_buffer[buf] != buf, \
+			"Mismatch in buffer %d, \
+			iteration %d: 0x%08X\n", buf, loop, *shared_buffer[buf]);
+			pinning_offset -= ALIGN(BO_SIZE, 4096);
+		}
+		/* Reset the buffer entries for next iteration */
+		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+			*shared_buffer[buf] = 0xFFFFFFFF;
+		}
+	}
+
+	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+		gem_close(fd, shared_handle[buf]);
+		free(shared_buffer[buf]);
+	}
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_handle);
+	free(shared_buffer);
+	free(exec_object2);
+	free(batch_buffer);
+}
+
+/* gem_write_multipage_buffer
+ * Create a buffer spanning multiple pages, and share with GPU.
+ * Write to every element of the buffer
+ * and verify correct contents.
+
+ * Create 8K buffer
+ * Share with GPU using userptr ioctl
+ * Create batch buffer to write DATA in all elements of buffer
+ * Execute Batch Buffer
+ * Validate every element has DATA
+*/
+
+#define DWORD_SIZE sizeof(uint32_t)
+#define BB_SIZE ((MULTIPAGE_BO_SIZE / DWORD_SIZE) * STORE_BATCH_BUFFER_SIZE) + 2
+#define NUM_DWORDS (MULTIPAGE_BO_SIZE/sizeof(uint32_t))
+static void gem_write_multipage_buffer_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	uint32_t shared_handle;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[BB_SIZE];
+	uint32_t batch_buf_handle;
+	int ring, len, j;
+	uint64_t pinning_offset=0x1000;
+	uint64_t vaddr;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
+	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
+
+	len = 0;
+	memset(batch_buffer, 0, sizeof(batch_buffer));
+	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
+
+	/* share with GPU */
+	shared_handle = init_userptr(fd, &userptr, shared_buffer,
+				     MULTIPAGE_BO_SIZE);
+	setup_exec_obj(&exec_object2[0], shared_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+
+	/* create command buffer with write commands */
+	vaddr = pinning_offset;
+	for(j=0; j< NUM_DWORDS; j++) {
+		len += gem_store_data_svm(fd, batch_buffer + (len/4), vaddr,
+					  j,
+					  (j == NUM_DWORDS - 1) ? true:false);
+		vaddr += sizeof(shared_buffer[0]);  /* 4 bytes */
+	}
+
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_handle);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	for(j = 0; j < (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++) {
+		igt_fail_on_f(shared_buffer[j] != j,
+		"Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_handle);
+	close(fd);
+
+	free(shared_buffer);
+}
+
+/* gem_pin_invalid_vma_test
+ * This test will request to pin a shared buffer to an invalid
+ * VMA  > 48-bit address if system supports 48B PPGTT; it also
+ * will test that any attempt of using a 48-bit address requires
+ * the SUPPORTS_48B_ADDRESS flag.
+ * If system supports 32B PPGTT, it will test the equivalent invalid VMA
+ * Create shared buffer of size 4K
+ * Try and Pin object to invalid address
+*/
+static void gem_pin_invalid_vma_test(bool test_decouple_flags)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[1];
+	uint32_t shared_buf_handle;
+	int ring;
+	uint64_t invalid_address_for_48b = 0x9000000000000; /* 52 bit address */
+	uint64_t invalid_address_for_32b = 0x900000000; /* 36 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT) ||
+		    uses_full_ppgtt(fd, FULL_32_BIT_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+
+	if (uses_full_ppgtt(fd, FULL_48_BIT_PPGTT) && !test_decouple_flags) {
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
+			       invalid_address_for_48b);
+	} else {
+		/* This also fails in 48b without 48B_ADDRESS support flag */
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED, invalid_address_for_32b);
+	}
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 1, 0);
+
+	/* Expect execbuf to fail */
+	ret = drmIoctl(fd,
+		       DRM_IOCTL_I915_GEM_EXECBUFFER2,
+		       &execbuf);
+
+	igt_assert(errno == EINVAL);
+	igt_assert_neq(ret, 0);
+
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+
+/* gem_pin_high_address_test
+ * This test will create a shared buffer, and create a command
+ * for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
+ * CPU will read and make sure expected value is obtained
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use virtual address of buffer as 0x1100000000 (> 32 bit)
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to shared buffer VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+
+static void gem_pin_high_address_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	igt_assert(exec_object2[0].offset == high_address);
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, \
+		expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/* gem_pin_near_48Bit_test
+ * This test will create a shared buffer,
+ * and create a command for GPU to write data in it. It will attempt
+ * to pin the buffer at address > 47 bits <= 48-bit.
+ * CPU will read and make sure expected value is obtained
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use virtual address of buffer as range between 47-bit and 48-bit
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to shared buffer VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000
+#define END_HIGH_ADDRESS 0xFFFFFFFFC000
+#define ADDRESS_INCREMENT 0x2000000000
+static void gem_pin_near_48Bit_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+
+	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS;
+						high_address+=ADDRESS_INCREMENT) {
+		/* create command buffer with write command */
+		len = gem_store_data_svm(fd, batch_buffer, high_address,
+					data, true);
+		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+		/* submit command buffer */
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
+			       high_address);
+		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+		ring = I915_EXEC_RENDER;
+		setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		gem_userptr_sync(fd, shared_buf_handle);
+
+		igt_assert(exec_object2[0].offset == high_address);
+		/* check on CPU to see if value changes */
+		igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, expected: 0x%x, \
+		got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+
+int main(int argc, char* argv[])
+{
+	igt_subtest_init(argc, argv);
+	igt_skip_on_simulation();
+
+	/* All tests need PPGTT support */
+	igt_subtest("gem_pin_userptr") {
+		gem_pin_userptr_test();
+	}
+	igt_subtest("gem_pin_bo") {
+		gem_pin_bo_test();
+	}
+	igt_subtest("gem_multiple_process") {
+		gem_multiple_process_test();
+	}
+	igt_subtest("gem_repin") {
+		gem_repin_test();
+	}
+	igt_subtest("gem_pin_overlap") {
+		gem_pin_overlap_test();
+	}
+	igt_subtest("gem_write_multipage_buffer") {
+		gem_write_multipage_buffer_test();
+	}
+
+	/* Following tests need 32/48 Bit PPGTT support */
+	igt_subtest("gem_pin_invalid_vma") {
+		gem_pin_invalid_vma_test(false);
+	}
+
+	/* Following tests need 48 Bit PPGTT support */
+	igt_subtest("gem_pin_high_address_without_correct_flag") {
+		gem_pin_invalid_vma_test(true);
+	}
+	igt_subtest("gem_softpin_stress") {
+		gem_softpin_stress_test();
+	}
+	igt_subtest("gem_pin_high_address") {
+		gem_pin_high_address_test();
+	}
+	igt_subtest("gem_pin_near_48Bit") {
+		gem_pin_near_48Bit_test();
+	}
+
+	igt_exit();
+}
-- 
2.6.3

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
  2015-12-01 10:35 ` Tvrtko Ursulin
@ 2015-12-04  9:45   ` Daniel Vetter
  0 siblings, 0 replies; 19+ messages in thread
From: Daniel Vetter @ 2015-12-04  9:45 UTC (permalink / raw)
  To: Tvrtko Ursulin; +Cc: Vinay Belgaumkar, intel-gfx

On Tue, Dec 01, 2015 at 10:35:59AM +0000, Tvrtko Ursulin wrote:
> 
> Hi,
> 
> Just one comment deep down.
> 
> On 30/11/15 18:22, Vinay Belgaumkar wrote:
> >These tests exercise the userptr ioctl to create shared buffers
> >between CPU and GPU. They contain error and normal usage scenarios.
> >They also contain a couple of stress tests which copy buffers between
> >CPU and GPU. These tests rely on the softpin patch in order to pin buffers
> >to a certain VA.
> >
> >Caveat: These tests were designed to run on 64-bit system. Future work
> >includes adding logic to ensure these tests can run on 32-bit systems with
> >PPGTT support. Some tests are currently disabled for 32-bit systems for that
> >reason.
> >
> >v2: Added cc and signed-off-by fields
> >
> >v3: Fixed review comments, added helper functions. Removed userptr error
> >scenarios covered by existing userptr tests. Modified stress test to have
> >100K buffers, it now runs for ~30 mins, checks every element has been written
> >to correctly, and pins buffers at different VMAs.
> >
> >v4: Changed name to gem_softpin
> >
> >v5: More fixes. Removed the file based tests, will move them to userptr tests.
> >Added a function that validates appropriate PPGTT support before running tests.
> >Optimized stack space and memory footprint in stress test. Removed the eviction
> >test, will add it back after verifying proper functionality.
> >
> >v6: Split basic test into userptr and bo
> >Fixed some coding style issues.
> >
> >v7: Enhanced invalid vma pinning test to verify 32-bit PPGTT functionality.
> >Enabled the test for 32-bit PPGTT systems, and verify pinning fails above
> >32-bit addresses. Enhanced the high adress pinning test to ensure pinning
> >fails when EXEC_OBJECT_PINNED flag is not used. Some more cosmetic fixes to
> >close buffer handles. Changed userptr function to used synchronized operations.
> >
> >Cc: Michel Thierry <michel.thierry@intel.com>
> >Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> >---
> >  tests/.gitignore       |    1 +
> >  tests/Makefile.sources |    1 +
> >  tests/gem_softpin.c    | 1050 ++++++++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 1052 insertions(+)
> >  create mode 100644 tests/gem_softpin.c
> >
> >diff --git a/tests/.gitignore b/tests/.gitignore
> >index 80af9a7..424870b 100644
> >--- a/tests/.gitignore
> >+++ b/tests/.gitignore
> >@@ -21,6 +21,7 @@ gem_bad_blit
> >  gem_bad_length
> >  gem_bad_reloc
> >  gem_basic
> >+gem_softpin
> >  gem_caching
> >  gem_close_race
> >  gem_concurrent_all
> >diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> >index 8fb2de8..2008d4a 100644
> >--- a/tests/Makefile.sources
> >+++ b/tests/Makefile.sources
> >@@ -11,6 +11,7 @@ TESTS_progs_M = \
> >  	drv_hangman \
> >  	gem_bad_reloc \
> >  	gem_basic \
> >+	gem_softpin \
> >  	gem_caching \
> >  	gem_close_race \
> >  	gem_concurrent_blit \
> >diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
> >new file mode 100644
> >index 0000000..86cfaf8
> >--- /dev/null
> >+++ b/tests/gem_softpin.c
> >@@ -0,0 +1,1050 @@
> >+/*
> >+ * Copyright © 2015 Intel Corporation
> >+ *
> >+ * Permission is hereby granted, free of charge, to any person obtaining a
> >+ * copy of this software and associated documentation files (the "Software"),
> >+ * to deal in the Software without restriction, including without limitation
> >+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> >+ * and/or sell copies of the Software, and to permit persons to whom the
> >+ * Software is furnished to do so, subject to the following conditions:
> >+ *
> >+ * The above copyright notice and this permission notice (including the next
> >+ * paragraph) shall be included in all copies or substantial portions of the
> >+ * Software.
> >+ *
> >+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> >+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> >+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> >+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> >+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> >+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> >+ * IN THE SOFTWARE.
> >+ *
> >+ * Authors:
> >+ *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> >+ *    Thomas Daniel <thomas.daniel@intel.com>
> >+ *
> >+ */
> >+
> >+#include <unistd.h>
> >+#include <stdlib.h>
> >+#include <stdint.h>
> >+#include <stdio.h>
> >+#include <string.h>
> >+#include <fcntl.h>
> >+#include <inttypes.h>
> >+#include <errno.h>
> >+#include <sys/stat.h>
> >+#include <sys/ioctl.h>
> >+#include <sys/time.h>
> >+#include <malloc.h>
> >+#include "drm.h"
> >+#include "ioctl_wrappers.h"
> >+#include "drmtest.h"
> >+#include "intel_chipset.h"
> >+#include "intel_io.h"
> >+#include "i915_drm.h"
> >+#include <assert.h>
> >+#include <sys/wait.h>
> >+#include <sys/ipc.h>
> >+#include <sys/shm.h>
> >+#include "igt_kms.h"
> >+#include <inttypes.h>
> >+#include <sys/types.h>
> >+#include <sys/stat.h>
> >+
> >+#define BO_SIZE 4096
> >+#define MULTIPAGE_BO_SIZE 2 * BO_SIZE
> >+#define STORE_BATCH_BUFFER_SIZE 4
> >+#define EXEC_OBJECT_PINNED	(1<<4)
> >+#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
> >+#define SHARED_BUFFER_SIZE 4096
> >+
> >+typedef struct drm_i915_gem_userptr i915_gem_userptr;
> >+
> >+static uint32_t init_userptr(int fd, i915_gem_userptr *, void *ptr, uint64_t size);
> >+static void *create_mem_buffer(uint64_t size);
> >+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
> >+static void gem_pin_userptr_test(void);
> >+static void gem_pin_bo_test(void);
> >+static void gem_pin_invalid_vma_test(void);
> >+static void gem_pin_overlap_test(void);
> >+static void gem_pin_high_address_test(void);
> >+
> >+#define NO_PPGTT 0
> >+#define ALIASING_PPGTT 1
> >+#define FULL_32_BIT_PPGTT 2
> >+#define FULL_48_BIT_PPGTT 3
> >+/* uses_full_ppgtt
> >+ * Finds supported PPGTT details.
> >+ * @fd DRM fd
> >+ * @min can be
> >+ * 0 - No PPGTT
> >+ * 1 - Aliasing PPGTT
> >+ * 2 - Full PPGTT (32b)
> >+ * 3 - Full PPGTT (48b)
> >+ * RETURNS true/false if min support is present
> >+*/
> >+static bool uses_full_ppgtt(int fd, int min)
> >+{
> >+	struct drm_i915_getparam gp;
> >+	int val = 0;
> >+
> >+	memset(&gp, 0, sizeof(gp));
> >+	gp.param = 18; /* HAS_ALIASING_PPGTT */
> >+	gp.value = &val;
> >+
> >+	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
> >+		return 0;
> >+
> >+	errno = 0;
> >+	return val >= min;
> >+}
> >+
> >+
> >+/* gem_call_userptr_ioctl
> >+ * Helper to call ioctl - TODO: move to lib
> >+ * @fd - drm fd
> >+ * @userptr - pointer to initialised userptr
> >+ * RETURNS status of ioctl call
> >+*/
> >+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr)
> >+{
> >+	int ret;
> >+
> >+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
> >+
> >+	if (ret)
> >+		ret = errno;
> >+
> >+	return ret;
> >+}
> >+
> >+/* init_userptr
> >+ * Helper that inits userptr an returns handle
> >+ * @fd - drm fd
> >+ * @userptr - pointer to empty userptr
> >+ * @ptr - buffer to be shared
> >+ * @size - size of buffer
> >+ * @ro - read only flag
> >+ * RETURNS handle to shared buffer
> >+*/
> >+static uint32_t init_userptr(int fd, i915_gem_userptr *userptr, void *ptr,
> >+			     uint64_t size)
> >+{
> >+	int ret;
> >+
> >+	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
> >+
> >+	userptr->user_ptr = (uint64_t)ptr; /* Need the cast to overcome compiler warning */
> >+	userptr->user_size = size;
> >+	userptr->flags = 0; /* use synchronized operation */
> >+
> >+	ret = gem_call_userptr_ioctl(fd, userptr);
> >+	igt_assert_eq(ret, 0);
> >+
> >+	return userptr->handle;
> >+}
> >+
> >+/* create_mem_buffer
> >+ * Creates a 4K aligned CPU buffer
> >+ * @size - size of buffer
> >+ * RETURNS pointer to buffer of @size
> >+*/
> >+static void *create_mem_buffer(uint64_t size)
> >+{
> >+	void *addr;
> >+	int ret;
> >+
> >+	ret = posix_memalign(&addr, 4096, size);
> >+	igt_assert(ret == 0);
> >+
> >+	return addr;
> >+}
> >+
> >+/* setup_exec_obj
> >+ * populate exec object
> >+ * @exec - exec object
> >+ * @handle - handle to gem buffer
> >+ * @flags - any flags
> >+ * @offset - requested VMA
> >+*/
> >+static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec,
> >+			   uint32_t handle, uint32_t flags,
> >+			   uint64_t offset)
> >+{
> >+	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
> >+	exec->handle = handle;
> >+	exec->flags = flags;
> >+	exec->offset = offset;
> >+}
> >+
> >+/* gem_store_data_svm
> >+ * populate batch buffer with MI_STORE_DWORD_IMM command
> >+ * @fd: drm file descriptor
> >+ * @cmd_buf: batch buffer
> >+ * @vaddr: destination Virtual address
> >+ * @data: data to be store at destination
> >+ * @end: whether to end batch buffer or not
> >+*/
> >+static int gem_store_data_svm(int fd, uint32_t *cmd_buf, uint64_t vaddr,
> >+			      uint32_t data, bool end)
> >+{
> >+	int i = 0;
> >+
> >+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> >+	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
> >+	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
> >+
> >+	cmd_buf[i++] = data;
> >+	if (end) {
> >+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> >+		cmd_buf[i++] = 0;
> >+	}
> >+
> >+	return(i * sizeof(uint32_t));
> >+}
> >+
> >+/* gem_store_data
> >+ * populate batch buffer with MI_STORE_DWORD_IMM command
> >+ * This one fills up reloc buffer as well
> >+ * @fd: drm file descriptor
> >+ * @cmd_buf: batch buffer
> >+ * @data: data to be store at destination
> >+ * @reloc - relocation entry
> >+ * @end: whether to end batch buffer or not
> >+*/
> >+static int gem_store_data(int fd, uint32_t *cmd_buf,
> >+			  uint32_t handle, uint32_t data,
> >+			  struct drm_i915_gem_relocation_entry *reloc,
> >+			  bool end)
> >+{
> >+	int i = 0;
> >+
> >+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> >+	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 reloc needed */
> >+	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 reloc needed */
> >+	reloc->offset = 1 * sizeof(uint32_t);
> >+	reloc->delta = 0;
> >+	reloc->target_handle = handle;
> >+	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
> >+	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
> >+	reloc->presumed_offset = 0;
> >+	cmd_buf[i++] = data;
> >+	if (end) {
> >+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> >+		cmd_buf[i++] = 0;
> >+	}
> >+
> >+	return (i * sizeof(uint32_t));
> >+}
> >+
> >+/* setup_execbuffer
> >+ * helper for buffer execution
> >+ * @execbuf - pointer to execbuffer
> >+ * @exec_object - pointer to exec object2 struct
> >+ * @ring - ring to be used
> >+ * @buffer_count - how manu buffers to submit
> >+ * @batch_length - length of batch buffer
> >+*/
> >+static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf,
> >+			     struct drm_i915_gem_exec_object2 *exec_object,
> >+			     int ring, int buffer_count, int batch_length)
> >+{
> >+	execbuf->buffers_ptr = (uint64_t)exec_object;
> >+	execbuf->buffer_count = buffer_count;
> >+	execbuf->batch_start_offset = 0;
> >+	execbuf->batch_len = batch_length;
> >+	execbuf->cliprects_ptr = 0;
> >+	execbuf->num_cliprects = 0;
> >+	execbuf->DR1 = 0;
> >+	execbuf->DR4 = 0;
> >+	execbuf->flags = ring;
> >+	i915_execbuffer2_set_context_id(*execbuf, 0);
> >+	execbuf->rsvd2 = 0;
> >+}
> >+
> >+/* submit_and_sync
> >+ * Helper function for exec and sync functions
> >+ * @fd - drm fd
> >+ * @execbuf - pointer to execbuffer
> >+ * @batch_buf_handle - batch buffer handle
> >+*/
> >+static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf,
> >+			    uint32_t batch_buf_handle)
> >+{
> >+	gem_execbuf(fd, execbuf);
> >+	gem_sync(fd, batch_buf_handle);
> >+}
> >+
> >+/* gem_userptr_sync
> >+ * helper for syncing to CPU domain - copy/paste from userblit
> >+ * @fd - drm fd
> >+ * @handle - buffer handle to sync
> >+*/
> >+static void gem_userptr_sync(int fd, uint32_t handle)
> >+{
> >+	gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
> >+}
> >+
> >+
> >+/* gem_pin_userptr_test
> >+ * This test will create a shared buffer, and create a command
> >+ * for GPU to write data in it
> >+ * CPU will read and make sure expected value is obtained
> >+ * Malloc a 4K buffer
> >+ * Share buffer with with GPU by using userptr ioctl
> >+ * Create batch buffer to write DATA to first dword of buffer
> >+ * Use 0x1000 address as destination address in batch buffer
> >+ * Set EXEC_OBJECT_PINNED flag in exec object
> >+ * Set 'offset' in exec object to 0x1000
> >+ * Submit execbuffer
> >+ * Verify value of first DWORD in shared buffer matches DATA
> >+*/
> >+static void gem_pin_userptr_test(void)
> >+{
> >+	i915_gem_userptr userptr;
> >+	int fd;
> >+	uint32_t *shared_buffer;
> >+	struct drm_i915_gem_execbuffer2 execbuf;
> >+	struct drm_i915_gem_exec_object2 exec_object2[2];
> >+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> >+	uint32_t batch_buf_handle, shared_buf_handle;
> >+	int ring, len;
> >+	const uint32_t data = 0x12345678;
> >+	uint64_t pinning_offset = 0x1000;
> >+
> >+	fd = drm_open_driver(DRIVER_INTEL);
> >+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> >+	batch_buf_handle = gem_create(fd, BO_SIZE);
> >+
> >+	/* create cpu buffer */
> >+	shared_buffer = create_mem_buffer(BO_SIZE);
> >+	
> >+	/* share with GPU */
> >+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> >+					 BO_SIZE);
> >+
> >+	/* create command buffer with write command */
> >+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> >+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> >+
> >+	/* submit command buffer */
> >+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> >+		       EXEC_OBJECT_PINNED, pinning_offset);
> >+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> >+
> >+	ring = I915_EXEC_RENDER;
> >+
> >+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> >+	submit_and_sync(fd, &execbuf, batch_buf_handle);
> >+	gem_userptr_sync(fd, shared_buf_handle);
> >+
> >+	/* Check if driver pinned the buffer as requested */
> >+	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
> >+			"\nFailed to pin at requested offset");
> >+	/* check on CPU to see if value changes */
> >+	igt_fail_on_f(shared_buffer[0] != data,
> >+		      "\nCPU read does not match GPU write,\
> >+			expected: 0x%x, got: 0x%x\n",
> >+			data, shared_buffer[0]);
> >+
> >+	gem_close(fd, batch_buf_handle);
> >+	gem_close(fd, shared_buf_handle);
> >+	close(fd);
> >+	free(shared_buffer);
> >+}
> >+
> >+/* gem_pin_bo
> >+ * This test will test softpinning of a gem buffer object
> >+ * Malloc a 4K buffer
> >+ * Create batch buffer to write DATA to first dword of buffer
> >+ * Use 0x1000 address as destination address in batch buffer
> >+ * Set EXEC_OBJECT_PINNED flag in exec object
> >+ * Set 'offset' in exec object to 0x1000
> >+ * Submit execbuffer
> >+ * Verify value pinned offset matches the request
> >+*/
> >+static void gem_pin_bo_test(void)
> >+{
> >+	int fd;
> >+	struct drm_i915_gem_execbuffer2 execbuf;
> >+	struct drm_i915_gem_exec_object2 exec_object2[2];
> >+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> >+	uint32_t batch_buf_handle, unshared_buf_handle;
> >+	struct drm_i915_gem_relocation_entry reloc[4];
> >+	int ring, len;
> >+	uint32_t value;
> >+	const uint32_t data = 0x12345678;
> >+	uint64_t pinning_offset = 0x1000;
> >+
> >+	fd = drm_open_driver(DRIVER_INTEL);
> >+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> >+	batch_buf_handle = gem_create(fd, BO_SIZE);
> >+
> >+	/* create gem buffer */
> >+	unshared_buf_handle = gem_create(fd, BO_SIZE);
> >+	
> >+	/* create command buffer with write command */
> >+	len = gem_store_data(fd, batch_buffer, unshared_buf_handle, data,
> >+				reloc, true);
> >+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> >+
> >+	/* submit command buffer */
> >+	setup_exec_obj(&exec_object2[0], unshared_buf_handle,
> >+		       EXEC_OBJECT_PINNED, pinning_offset);
> >+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> >+	exec_object2[1].relocation_count = 1;
> >+	exec_object2[1].relocs_ptr = (uint64_t)reloc;
> >+
> >+	ring = I915_EXEC_RENDER;
> >+
> >+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> >+	submit_and_sync(fd, &execbuf, batch_buf_handle);
> >+
> >+	/* Check if driver pinned the buffer as requested */
> >+	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
> >+			"\nFailed to pin at requested offset");
> >+	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
> >+	igt_assert(value == data);
> >+
> >+	gem_close(fd, batch_buf_handle);
> >+	gem_close(fd, unshared_buf_handle);
> >+	close(fd);
> >+}
> >+
> >+
> >+/* gem_multiple_process_test
> >+ * Run basic test simultaneously with multiple processes
> >+ * This will test pinning same VA separately in each process
> >+
> >+ * fork();
> >+ * Execute basic test in parent/child processes
> >+*/
> >+#define MAX_NUM_PROCESSES 10
> >+
> >+static void gem_multiple_process_test(void)
> >+{
> >+	igt_fork(child, MAX_NUM_PROCESSES) {
> >+		gem_pin_userptr_test();
> >+	}
> >+	igt_waitchildren();
> >+}
> >+
> >+
> >+/* gem_repin_test
> >+ * This test tries to repin a buffer at a previously pinned vma
> >+ * from a different execbuf.
> >+ * Malloc a 4K buffer
> >+ * Share buffer with with GPU by using userptr ioctl
> >+ * Create batch buffer to write DATA to first dword of buffer
> >+ * Use 0x1000 address as destination address in batch buffer
> >+ * Set EXEC_OBJECT_PINNED flag in exec object
> >+ * Set 'offset' in exec object to 0x1000 VMA
> >+ * Submit execbuffer
> >+ * Verify value of first DWORD in shared buffer matches DATA
> >+
> >+ * Create second shared buffer
> >+ * Follow all steps above
> >+ * Execpt, for offset, use VMA of first buffer above
> >+ * Submit execbuffer
> >+ * Verify value of first DWORD in second shared buffer matches DATA
> >+*/
> >+static void gem_repin_test(void)
> >+{
> >+	i915_gem_userptr userptr;
> >+	i915_gem_userptr userptr1;
> >+	int fd;
> >+	uint32_t *shared_buffer;
> >+	uint32_t *shared_buffer1;
> >+	struct drm_i915_gem_execbuffer2 execbuf;
> >+	struct drm_i915_gem_exec_object2 exec_object2[2];
> >+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> >+	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
> >+	int ring, len;
> >+	const uint32_t data = 0x12345678;
> >+	uint64_t pinning_offset = 0x1000;
> >+
> >+	/* Create gem object */
> >+	fd = drm_open_driver(DRIVER_INTEL);
> >+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> >+
> >+	batch_buf_handle = gem_create(fd, BO_SIZE);
> >+
> >+	/* create cpu buffer, set first elements to 0x0 */
> >+	shared_buffer = create_mem_buffer(BO_SIZE);
> >+	shared_buffer1 = create_mem_buffer(BO_SIZE);
> >+	shared_buffer[0] = 0x0;
> >+	shared_buffer1[0] = 0x0;
> >+
> >+	/* share with GPU and get handles */
> >+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> >+					 BO_SIZE);
> >+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> >+					  BO_SIZE);
> >+
> >+	/* create command buffer with write command */
> >+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> >+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> >+
> >+	/* submit command buffer */
> >+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> >+		       EXEC_OBJECT_PINNED, pinning_offset);
> >+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> >+
> >+	ring = I915_EXEC_RENDER;
> >+
> >+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> >+	submit_and_sync(fd, &execbuf, batch_buf_handle);
> >+	gem_userptr_sync(fd, shared_buf_handle);
> >+
> >+	igt_assert(exec_object2[0].offset == pinning_offset);
> >+	igt_assert(*shared_buffer == data);
> >+
> >+	/* Second buffer */
> >+	/* create command buffer with write command */
> >+	pinning_offset = exec_object2[0].offset;
> >+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> >+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> >+
> >+	/* submit command buffer */
> >+	/* Pin at shared_buffer, not shared_buffer1 */
> >+	/* We are requesting address where another buffer was pinned previously */
> >+	setup_exec_obj(&exec_object2[0], shared_buf_handle1,
> >+		       EXEC_OBJECT_PINNED, pinning_offset);
> >+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> >+
> >+	ring = I915_EXEC_RENDER;
> >+
> >+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> >+	submit_and_sync(fd, &execbuf, batch_buf_handle);
> >+	gem_userptr_sync(fd, shared_buf_handle1);
> >+
> >+	igt_assert(exec_object2[0].offset == pinning_offset);
> >+	igt_assert(*shared_buffer1 == data);
> >+
> >+	gem_close(fd, batch_buf_handle);
> >+	gem_close(fd, shared_buf_handle);
> >+	close(fd);
> >+
> >+	free(shared_buffer);
> >+	free(shared_buffer1);
> >+}
> >+
> >+
> >+/* gem_repin_overlap_test
> >+ * This test will attempt to pin two buffers at the same VMA as part of the same
> >+   execbuffer object
> >+
> >+ * Malloc a 4K buffer
> >+ * Share buffer with with GPU by using userptr ioctl
> >+ * Create second shared buffer
> >+ * Create batch buffer to write DATA to first dword of each buffer
> >+ * Use same virtual address as destination addresses in batch buffer
> >+ * Set EXEC_OBJECT_PINNED flag in both exec objects
> >+ * Set 'offset' in both exec objects to same VMA
> >+ * Submit execbuffer
> >+ * Command should return EINVAL, since we are trying to pin to same VMA
> >+*/
> >+static void gem_pin_overlap_test(void)
> >+{
> >+	i915_gem_userptr userptr;
> >+	i915_gem_userptr userptr1;
> >+	int fd, ret;
> >+	uint32_t *shared_buffer;
> >+	uint32_t *shared_buffer1;
> >+	struct drm_i915_gem_execbuffer2 execbuf;
> >+	struct drm_i915_gem_exec_object2 exec_object2[3];
> >+	uint32_t shared_buf_handle, shared_buf_handle1;
> >+	int ring, len;
> >+	uint64_t pinning_offset = 0x1000;
> >+
> >+	fd = drm_open_driver(DRIVER_INTEL);
> >+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> >+
> >+	shared_buffer = create_mem_buffer(BO_SIZE);
> >+	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
> >+
> >+	/* share with GPU */
> >+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> >+					 BO_SIZE);
> >+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> >+					  BO_SIZE * 2);
> >+
> >+	/* submit command buffer */
> >+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> >+		       EXEC_OBJECT_PINNED, pinning_offset);
> >+	setup_exec_obj(&exec_object2[1], shared_buf_handle1,
> >+		       EXEC_OBJECT_PINNED, pinning_offset);
> >+
> >+	ring = I915_EXEC_RENDER;
> >+
> >+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> >+
> >+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, &execbuf);
> >+
> >+	/* expect to fail */
> >+	igt_assert_neq(ret, 0);
> >+	igt_assert(errno == EINVAL);
> >+
> >+	close(fd);
> >+	free(shared_buffer);
> >+	free(shared_buffer1);
> >+}
> >+
> >+/* gem_softpin_stress_test
> >+ * Stress test which creates 10K buffers and shares with GPU
> >+ * Create 100K uint32 buffers of size 4K each
> >+ * Share with GPU using userptr ioctl
> >+ * Create batch buffer to write DATA in first element of each buffer
> >+ * Pin each buffer to varying addresses starting from 0x800000000000 going below
> >+ * Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
> >+ * Validate every buffer has DATA in first element
> >+ * Rinse and Repeat on Render ring
> >+*/
> >+#define STRESS_NUM_BUFFERS 100000
> >+#define STRESS_NUM_LOOPS 100
> >+#define STRESS_STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
> >+
> >+static void gem_softpin_stress_test(void)
> >+{
> >+	i915_gem_userptr userptr;
> >+	int fd;
> >+	uint32_t **shared_buffer;
> >+	uint32_t *shared_handle;
> >+	struct drm_i915_gem_execbuffer2 execbuf;
> >+	struct drm_i915_gem_exec_object2 *exec_object2;
> >+	uint32_t *batch_buffer;
> >+	uint32_t batch_buf_handle;
> >+	int ring, len;
> >+	int buf, loop;
> >+	uint64_t pinning_offset = 0x800000000000;
> >+
> >+	fd = drm_open_driver(DRIVER_INTEL);
> >+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> >+
> >+
> >+	/* Allocate blobs for all data structures */
> >+	shared_handle = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t));
> >+	shared_buffer = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t *));
> >+	exec_object2 = calloc(STRESS_NUM_BUFFERS + 1,
> >+				sizeof(struct drm_i915_gem_exec_object2));
> >+	/* 4 dwords per buffer + 2 for the end of batchbuffer */
> >+	batch_buffer = calloc(STRESS_STORE_COMMANDS + 2, sizeof(uint32_t));
> >+	batch_buf_handle = gem_create(fd, (STRESS_STORE_COMMANDS + 2)*4);
> >+
> >+	/* create command buffer with write commands */
> >+	len = 0;
> >+	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> >+		shared_buffer[buf] = create_mem_buffer(BO_SIZE);
> >+		*shared_buffer[buf] = 0xFFFFFFFF;
> >+
> >+		/* share with GPU */
> >+		shared_handle[buf] = init_userptr(fd, &userptr,
> >+						  shared_buffer[buf],
> >+						  BO_SIZE);
> >+
> >+		setup_exec_obj(&exec_object2[buf], shared_handle[buf],
> >+			       EXEC_OBJECT_PINNED, pinning_offset);
> >+		len += gem_store_data_svm(fd, batch_buffer + (len/4),
> >+					  pinning_offset, buf,
> >+					  (buf == STRESS_NUM_BUFFERS-1)? \
> >+					  true:false);
> >+		
> >+		/* decremental 4K aligned address */
> >+		pinning_offset -= ALIGN(BO_SIZE, 4096);
> >+	}
> >+
> >+	/* setup command buffer */
> >+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> >+	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle,
> >+		       0, 0);
> >+
> >+	/* We want to run this on BLT ring if possible */
> >+	if (HAS_BLT_RING(intel_get_drm_devid(fd))) {
> >+		ring = I915_EXEC_BLT;
> >+
> >+		setup_execbuffer(&execbuf, exec_object2, ring,
> >+				 STRESS_NUM_BUFFERS + 1, len);
> >+
> >+		for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
> >+			submit_and_sync(fd, &execbuf, batch_buf_handle);
> >+			/* Set pinning offset back to original value */
> >+			pinning_offset = 0x800000000000;
> >+			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> >+				gem_userptr_sync(fd, shared_handle[buf]);
> >+				igt_assert(exec_object2[buf].offset == pinning_offset);
> >+				igt_fail_on_f(*shared_buffer[buf] != buf, \
> >+				"Mismatch in buffer %d, iteration %d: 0x%08X\n", \
> >+				buf, loop, *shared_buffer[buf]);
> >+				pinning_offset -= ALIGN(BO_SIZE, 4096);
> >+			}
> >+			/* Reset the buffer entries for next iteration */
> >+			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> >+				*shared_buffer[buf] = 0xFFFFFFFF;
> >+			}
> >+		}
> >+	}
> >+
> >+	/* Now Render Ring */
> >+	ring = I915_EXEC_RENDER;
> >+	setup_execbuffer(&execbuf, exec_object2, ring,
> >+			 STRESS_NUM_BUFFERS + 1, len);
> >+	for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
> >+		submit_and_sync(fd, &execbuf, batch_buf_handle);
> >+		pinning_offset = 0x800000000000;
> >+		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> >+			gem_userptr_sync(fd, shared_handle[buf]);
> >+			igt_assert(exec_object2[buf].offset == pinning_offset);
> >+			igt_fail_on_f(*shared_buffer[buf] != buf, \
> >+			"Mismatch in buffer %d, \
> >+			iteration %d: 0x%08X\n", buf, loop, *shared_buffer[buf]);
> >+			pinning_offset -= ALIGN(BO_SIZE, 4096);
> >+		}
> >+		/* Reset the buffer entries for next iteration */
> >+		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> >+			*shared_buffer[buf] = 0xFFFFFFFF;
> >+		}
> >+	}
> >+
> >+	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> >+		gem_close(fd, shared_handle[buf]);
> >+		free(shared_buffer[buf]);
> >+	}
> >+	gem_close(fd, batch_buf_handle);
> >+	close(fd);
> >+
> >+	free(shared_handle);
> >+	free(shared_buffer);
> >+	free(exec_object2);
> >+	free(batch_buffer);
> >+}
> >+
> >+/* gem_write_multipage_buffer
> >+ * Create a buffer spanning multiple pages, and share with GPU.
> >+ * Write to every element of the buffer
> >+ * and verify correct contents.
> >+
> >+ * Create 8K buffer
> >+ * Share with GPU using userptr ioctl
> >+ * Create batch buffer to write DATA in all elements of buffer
> >+ * Execute Batch Buffer
> >+ * Validate every element has DATA
> >+*/
> >+
> >+#define DWORD_SIZE sizeof(uint32_t)
> >+#define BB_SIZE ((MULTIPAGE_BO_SIZE / DWORD_SIZE) * STORE_BATCH_BUFFER_SIZE) + 2
> >+#define NUM_DWORDS (MULTIPAGE_BO_SIZE/sizeof(uint32_t))
> >+static void gem_write_multipage_buffer_test(void)
> >+{
> >+	i915_gem_userptr userptr;
> >+	int fd;
> >+	uint32_t *shared_buffer;
> >+	uint32_t shared_handle;
> >+	struct drm_i915_gem_execbuffer2 execbuf;
> >+	struct drm_i915_gem_exec_object2 exec_object2[2];
> >+	uint32_t batch_buffer[BB_SIZE];
> >+	uint32_t batch_buf_handle;
> >+	int ring, len, j;
> >+	uint64_t pinning_offset=0x1000;
> >+	uint64_t vaddr;
> >+
> >+	fd = drm_open_driver(DRIVER_INTEL);
> >+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> >+
> >+	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
> >+	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
> >+
> >+	len = 0;
> >+	memset(batch_buffer, 0, sizeof(batch_buffer));
> >+	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
> >+
> >+	/* share with GPU */
> >+	shared_handle = init_userptr(fd, &userptr, shared_buffer,
> >+				     MULTIPAGE_BO_SIZE);
> >+	setup_exec_obj(&exec_object2[0], shared_handle,
> >+		       EXEC_OBJECT_PINNED, pinning_offset);
> >+
> >+	/* create command buffer with write commands */
> >+	vaddr = pinning_offset;
> >+	for(j=0; j< NUM_DWORDS; j++) {
> >+		len += gem_store_data_svm(fd, batch_buffer + (len/4), vaddr,
> >+					  j,
> >+					  (j == NUM_DWORDS - 1) ? true:false);
> >+		vaddr += sizeof(shared_buffer[0]);  /* 4 bytes */
> >+	}
> >+
> >+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> >+
> >+	/* submit command buffer */
> >+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> >+
> >+	ring = I915_EXEC_RENDER;
> >+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> >+	submit_and_sync(fd, &execbuf, batch_buf_handle);
> >+	gem_userptr_sync(fd, shared_handle);
> >+
> >+	igt_assert(exec_object2[0].offset == pinning_offset);
> >+	for(j = 0; j < (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++) {
> >+		igt_fail_on_f(shared_buffer[j] != j,
> >+		"Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
> >+	}
> >+
> >+	gem_close(fd, batch_buf_handle);
> >+	gem_close(fd, shared_handle);
> >+	close(fd);
> >+
> >+	free(shared_buffer);
> >+}
> >+
> >+/* gem_pin_invalid_vma_test
> >+ * This test will request to pin a shared buffer to an invalid
> >+ * VMA  > 48-bit address if system supports 48B PPGTT
> >+ * If system supports 32B PPGTT, it will test the equivalent invalid VMA
> >+ * Create shared buffer of size 4K
> >+ * Try and Pin object to invalid address
> >+*/
> >+static void gem_pin_invalid_vma_test(void)
> >+{
> >+	i915_gem_userptr userptr;
> >+	int fd, ret;
> >+	uint32_t *shared_buffer;
> >+	struct drm_i915_gem_execbuffer2 execbuf;
> >+	struct drm_i915_gem_exec_object2 exec_object2[1];
> >+	uint32_t shared_buf_handle;
> >+	int ring;
> >+	uint64_t invalid_address_for_48b = 0x9000000000000; /* 52 bit address */
> >+	uint64_t invalid_address_for_32b = 0x900000000; /* 36 bit address */
> >+
> >+	fd = drm_open_driver(DRIVER_INTEL);
> >+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT) ||
> >+		    uses_full_ppgtt(fd, FULL_32_BIT_PPGTT));
> >+
> >+	shared_buffer = create_mem_buffer(BO_SIZE);
> >+	*shared_buffer = 0xFFFFFFFF;
> >+	
> >+	/* share with GPU */
> >+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> >+
> >+	if (uses_full_ppgtt(fd, FULL_48_BIT_PPGTT)) {
> >+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> >+			       EXEC_OBJECT_PINNED, invalid_address_for_48b);
> >+	} else {
> >+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> >+			       EXEC_OBJECT_PINNED, invalid_address_for_32b);
> >+	}
> >+
> >+	ring = I915_EXEC_RENDER;
> >+
> >+	setup_execbuffer(&execbuf, exec_object2, ring, 1, 0);
> >+
> >+	/* Expect execbuf to fail */
> >+	ret = drmIoctl(fd,
> >+		       DRM_IOCTL_I915_GEM_EXECBUFFER2,
> >+		       &execbuf);
> >+
> >+	igt_assert(errno == ENOSPC);
> >+	igt_assert_neq(ret, 0);
> >+	
> >+	gem_close(fd, shared_buf_handle);
> >+	close(fd);
> >+	free(shared_buffer);
> >+}
> >+
> >+
> >+/* gem_pin_high_address_test
> >+ * This test will create a shared buffer, and create a command
> >+ * for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
> >+ * CPU will read and make sure expected value is obtained
> >+
> >+ * Malloc a 4K buffer
> >+ * Share buffer with with GPU by using userptr ioctl
> >+ * Create batch buffer to write DATA to first dword of buffer
> >+ * Use virtual address of buffer as 0x1100000000 (> 32 bit)
> >+ * Set EXEC_OBJECT_PINNED flag in exec object
> >+ * Set 'offset' in exec object to shared buffer VMA
> >+ * Submit execbuffer
> >+ * Verify value of first DWORD in shared buffer matches DATA
> >+ * Now try same test without using EXEC_OBJECT_PINNED flag
> >+ * test should fail pinned offset check
> >+*/
> >+
> >+static void gem_pin_high_address_test(void)
> >+{
> >+	i915_gem_userptr userptr;
> >+	int fd;
> >+	uint32_t *shared_buffer;
> >+	struct drm_i915_gem_execbuffer2 execbuf;
> >+	struct drm_i915_gem_exec_object2 exec_object2[2];
> >+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> >+	uint32_t batch_buf_handle, shared_buf_handle;
> >+	int ring, len;
> >+	const uint32_t data = 0x12345678;
> >+	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
> >+
> >+	fd = drm_open_driver(DRIVER_INTEL);
> >+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> >+
> >+	batch_buf_handle = gem_create(fd, BO_SIZE);
> >+
> >+	/* create cpu buffer, set to all 0xF's */
> >+	shared_buffer = create_mem_buffer(BO_SIZE);
> >+	*shared_buffer = 0xFFFFFFFF;
> >+
> >+	/* share with GPU */
> >+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> >+
> >+	/* create command buffer with write command */
> >+	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
> >+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> >+
> >+	/* submit command buffer */
> >+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> >+		       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
> >+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> >+
> >+	ring = I915_EXEC_RENDER;
> >+
> >+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> >+	submit_and_sync(fd, &execbuf, batch_buf_handle);
> >+	gem_userptr_sync(fd, shared_buf_handle);
> >+
> >+	igt_assert(exec_object2[0].offset == high_address);
> >+	/* check on CPU to see if value changes */
> >+	igt_fail_on_f(shared_buffer[0] != data,
> >+		"\nCPU read does not match GPU write, \
> >+		expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
> >+
> >+	/* Now try pinning to high address without EXEC_OBJECT_PINNED flag */
> 
> I thought here EXEC_OBJECT_PINNED without EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
> to verify that the former really implies the latter.
> 
> If you change that you can add my r-b.

I think Chris replied on the kernel patch already, but please don't create
such depencies in flags.
-Daniel

> 
> Regards,
> 
> Tvrtko
> 
> >+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> >+		       0, high_address);
> >+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> >+	submit_and_sync(fd, &execbuf, batch_buf_handle);
> >+	gem_userptr_sync(fd, shared_buf_handle);
> >+
> >+	/* Since we did not request 48B addressing using EXEC_OBJECT_PINNED */
> >+	igt_assert(exec_object2[0].offset != high_address);
> >+
> >+	gem_close(fd, batch_buf_handle);
> >+	gem_close(fd, shared_buf_handle);
> >+	close(fd);
> >+	free(shared_buffer);
> >+}
> >+
> >+/* gem_pin_near_48Bit_test
> >+ * This test will create a shared buffer,
> >+ * and create a command for GPU to write data in it. It will attempt
> >+ * to pin the buffer at address > 47 bits <= 48-bit.
> >+ * CPU will read and make sure expected value is obtained
> >+
> >+ * Malloc a 4K buffer
> >+ * Share buffer with with GPU by using userptr ioctl
> >+ * Create batch buffer to write DATA to first dword of buffer
> >+ * Use virtual address of buffer as range between 47-bit and 48-bit
> >+ * Set EXEC_OBJECT_PINNED flag in exec object
> >+ * Set 'offset' in exec object to shared buffer VMA
> >+ * Submit execbuffer
> >+ * Verify value of first DWORD in shared buffer matches DATA
> >+*/
> >+#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000
> >+#define END_HIGH_ADDRESS 0xFFFFFFFFC000
> >+#define ADDRESS_INCREMENT 0x2000000000
> >+static void gem_pin_near_48Bit_test(void)
> >+{
> >+	i915_gem_userptr userptr;
> >+	int fd;
> >+	uint32_t *shared_buffer;
> >+	struct drm_i915_gem_execbuffer2 execbuf;
> >+	struct drm_i915_gem_exec_object2 exec_object2[2];
> >+	uint32_t batch_buffer[BO_SIZE];
> >+	uint32_t batch_buf_handle, shared_buf_handle;
> >+	int ring, len;
> >+	const uint32_t data = 0x12345678;
> >+	uint64_t high_address;
> >+
> >+	fd = drm_open_driver(DRIVER_INTEL);
> >+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> >+
> >+	batch_buf_handle = gem_create(fd, BO_SIZE);
> >+
> >+	/* create cpu buffer, set to all 0xF's */
> >+	shared_buffer = create_mem_buffer(BO_SIZE);
> >+	*shared_buffer = 0xFFFFFFFF;
> >+
> >+	/* share with GPU */
> >+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> >+
> >+	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS;
> >+						high_address+=ADDRESS_INCREMENT) {
> >+		/* create command buffer with write command */
> >+		len = gem_store_data_svm(fd, batch_buffer, high_address,
> >+					data, true);
> >+		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> >+		/* submit command buffer */
> >+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> >+			       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
> >+			       high_address);
> >+		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> >+
> >+		ring = I915_EXEC_RENDER;
> >+		setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> >+		submit_and_sync(fd, &execbuf, batch_buf_handle);
> >+		gem_userptr_sync(fd, shared_buf_handle);
> >+
> >+		igt_assert(exec_object2[0].offset == high_address);
> >+		/* check on CPU to see if value changes */
> >+		igt_fail_on_f(shared_buffer[0] != data,
> >+		"\nCPU read does not match GPU write, expected: 0x%x, \
> >+		got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
> >+	}
> >+
> >+	gem_close(fd, batch_buf_handle);
> >+	gem_close(fd, shared_buf_handle);
> >+	close(fd);
> >+	free(shared_buffer);
> >+}
> >+
> >+
> >+int main(int argc, char* argv[])
> >+{
> >+	igt_subtest_init(argc, argv);
> >+	igt_skip_on_simulation();
> >+
> >+	/* All tests need PPGTT support */
> >+	igt_subtest("gem_pin_userptr") {
> >+		gem_pin_userptr_test();
> >+	}
> >+	igt_subtest("gem_pin_bo") {
> >+		gem_pin_bo_test();
> >+	}
> >+	igt_subtest("gem_multiple_process") {
> >+		gem_multiple_process_test();
> >+	}
> >+	igt_subtest("gem_repin") {
> >+		gem_repin_test();
> >+	}
> >+	igt_subtest("gem_pin_overlap") {
> >+		gem_pin_overlap_test();
> >+	}
> >+	igt_subtest("gem_write_multipage_buffer") {
> >+		gem_write_multipage_buffer_test();
> >+	}
> >+
> >+	/* Following tests need 32/48 Bit PPGTT support */
> >+	igt_subtest("gem_pin_invalid_vma") {
> >+		gem_pin_invalid_vma_test();
> >+	}
> >+
> >+	/* Following tests need 48 Bit PPGTT support */
> >+	igt_subtest("gem_softpin_stress") {
> >+		gem_softpin_stress_test();
> >+	}
> >+	igt_subtest("gem_pin_high_address") {
> >+		gem_pin_high_address_test();
> >+	}
> >+	igt_subtest("gem_pin_near_48Bit") {
> >+		gem_pin_near_48Bit_test();
> >+	}
> >+
> >+	igt_exit();
> >+}
> >
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
  2015-12-03  8:36 Vinay Belgaumkar
@ 2015-12-03 16:42 ` Tvrtko Ursulin
  2015-12-08 11:57 ` Michel Thierry
  1 sibling, 0 replies; 19+ messages in thread
From: Tvrtko Ursulin @ 2015-12-03 16:42 UTC (permalink / raw)
  To: Vinay Belgaumkar, intel-gfx


Hi,

On 03/12/15 08:36, Vinay Belgaumkar wrote:
> These tests exercise the userptr ioctl to create shared buffers
> between CPU and GPU. They contain error and normal usage scenarios.
> They also contain a couple of stress tests which copy buffers between
> CPU and GPU. These tests rely on the softpin patch in order to pin buffers
> to a certain VA.
>
> Caveat: These tests were designed to run on 64-bit system. Future work
> includes adding logic to ensure these tests can run on 32-bit systems with
> PPGTT support. Some tests are currently disabled for 32-bit systems for that
> reason.
>
> v2: Added cc and signed-off-by fields
>
> v3: Fixed review comments, added helper functions. Removed userptr error
> scenarios covered by existing userptr tests. Modified stress test to have
> 100K buffers, it now runs for ~30 mins, checks every element has been written
> to correctly, and pins buffers at different VMAs.
>
> v4: Changed name to gem_softpin
>
> v5: More fixes. Removed the file based tests, will move them to userptr tests.
> Added a function that validates appropriate PPGTT support before running tests.
> Optimized stack space and memory footprint in stress test. Removed the eviction
> test, will add it back after verifying proper functionality.
>
> v6: Split basic test into userptr and bo
> Fixed some coding style issues.
>
> v7: Enhanced invalid vma pinning test to verify 32-bit PPGTT functionality.
> Enabled the test for 32-bit PPGTT systems, and verify pinning fails above
> 32-bit addresses. Enhanced the high adress pinning test to ensure pinning
> fails when EXEC_OBJECT_PINNED flag is not used. Some more cosmetic fixes to
> close buffer handles. Changed userptr function to used synchronized operations.
>
> v8: Minor change to high address pinning test as per comment.
>
> v9: Skip the tests if softpin support is not present.
>
> v10: Removed trailing white spaces.
>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
>   tests/.gitignore       |    1 +
>   tests/Makefile.sources |    1 +
>   tests/gem_softpin.c    | 1086 ++++++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 1088 insertions(+)
>   create mode 100644 tests/gem_softpin.c

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko

> diff --git a/tests/.gitignore b/tests/.gitignore
> index 80af9a7..424870b 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -21,6 +21,7 @@ gem_bad_blit
>   gem_bad_length
>   gem_bad_reloc
>   gem_basic
> +gem_softpin
>   gem_caching
>   gem_close_race
>   gem_concurrent_all
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 8fb2de8..2008d4a 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -11,6 +11,7 @@ TESTS_progs_M = \
>   	drv_hangman \
>   	gem_bad_reloc \
>   	gem_basic \
> +	gem_softpin \
>   	gem_caching \
>   	gem_close_race \
>   	gem_concurrent_blit \
> diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
> new file mode 100644
> index 0000000..a5d3694
> --- /dev/null
> +++ b/tests/gem_softpin.c
> @@ -0,0 +1,1086 @@
> +/*
> + * Copyright © 2015 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + *
> + * Authors:
> + *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> + *    Thomas Daniel <thomas.daniel@intel.com>
> + *
> + */
> +
> +#include <unistd.h>
> +#include <stdlib.h>
> +#include <stdint.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include <fcntl.h>
> +#include <inttypes.h>
> +#include <errno.h>
> +#include <sys/stat.h>
> +#include <sys/ioctl.h>
> +#include <sys/time.h>
> +#include <malloc.h>
> +#include "drm.h"
> +#include "ioctl_wrappers.h"
> +#include "drmtest.h"
> +#include "intel_chipset.h"
> +#include "intel_io.h"
> +#include "i915_drm.h"
> +#include <assert.h>
> +#include <sys/wait.h>
> +#include <sys/ipc.h>
> +#include <sys/shm.h>
> +#include "igt_kms.h"
> +#include <inttypes.h>
> +#include <sys/types.h>
> +#include <sys/stat.h>
> +
> +#define BO_SIZE 4096
> +#define MULTIPAGE_BO_SIZE 2 * BO_SIZE
> +#define STORE_BATCH_BUFFER_SIZE 4
> +#define EXEC_OBJECT_PINNED	(1<<4)
> +#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
> +#define SHARED_BUFFER_SIZE 4096
> +
> +typedef struct drm_i915_gem_userptr i915_gem_userptr;
> +
> +static uint32_t init_userptr(int fd, i915_gem_userptr *, void *ptr, uint64_t size);
> +static void *create_mem_buffer(uint64_t size);
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
> +static void gem_pin_userptr_test(void);
> +static void gem_pin_bo_test(void);
> +static void gem_pin_invalid_vma_test(void);
> +static void gem_pin_overlap_test(void);
> +static void gem_pin_high_address_test(void);
> +
> +#define NO_PPGTT 0
> +#define ALIASING_PPGTT 1
> +#define FULL_32_BIT_PPGTT 2
> +#define FULL_48_BIT_PPGTT 3
> +/* uses_full_ppgtt
> + * Finds supported PPGTT details.
> + * @fd DRM fd
> + * @min can be
> + * 0 - No PPGTT
> + * 1 - Aliasing PPGTT
> + * 2 - Full PPGTT (32b)
> + * 3 - Full PPGTT (48b)
> + * RETURNS true/false if min support is present
> +*/
> +static bool uses_full_ppgtt(int fd, int min)
> +{
> +	struct drm_i915_getparam gp;
> +	int val = 0;
> +
> +	memset(&gp, 0, sizeof(gp));
> +	gp.param = 18; /* HAS_ALIASING_PPGTT */
> +	gp.value = &val;
> +
> +	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
> +		return 0;
> +
> +	errno = 0;
> +	return val >= min;
> +}
> +
> +/* has_softpin_support
> + * Finds if softpin feature is supported
> + * @fd DRM fd
> +*/
> +static bool has_softpin_support(int fd)
> +{
> +	struct drm_i915_getparam gp;
> +	int val = 0;
> +
> +	memset(&gp, 0, sizeof(gp));
> +	gp.param = 37; /* I915_PARAM_HAS_EXEC_SOFTPIN */
> +	gp.value = &val;
> +
> +	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
> +		return 0;
> +
> +	errno = 0;
> +	return (val == 1);
> +}
> +
> +/* gem_call_userptr_ioctl
> + * Helper to call ioctl - TODO: move to lib
> + * @fd - drm fd
> + * @userptr - pointer to initialised userptr
> + * RETURNS status of ioctl call
> +*/
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr)
> +{
> +	int ret;
> +
> +	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
> +
> +	if (ret)
> +		ret = errno;
> +
> +	return ret;
> +}
> +
> +/* init_userptr
> + * Helper that inits userptr an returns handle
> + * @fd - drm fd
> + * @userptr - pointer to empty userptr
> + * @ptr - buffer to be shared
> + * @size - size of buffer
> + * @ro - read only flag
> + * RETURNS handle to shared buffer
> +*/
> +static uint32_t init_userptr(int fd, i915_gem_userptr *userptr, void *ptr,
> +			     uint64_t size)
> +{
> +	int ret;
> +
> +	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
> +
> +	userptr->user_ptr = (uint64_t)ptr; /* Need the cast to overcome compiler warning */
> +	userptr->user_size = size;
> +	userptr->flags = 0; /* use synchronized operation */
> +
> +	ret = gem_call_userptr_ioctl(fd, userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	return userptr->handle;
> +}
> +
> +/* create_mem_buffer
> + * Creates a 4K aligned CPU buffer
> + * @size - size of buffer
> + * RETURNS pointer to buffer of @size
> +*/
> +static void *create_mem_buffer(uint64_t size)
> +{
> +	void *addr;
> +	int ret;
> +
> +	ret = posix_memalign(&addr, 4096, size);
> +	igt_assert(ret == 0);
> +
> +	return addr;
> +}
> +
> +/* setup_exec_obj
> + * populate exec object
> + * @exec - exec object
> + * @handle - handle to gem buffer
> + * @flags - any flags
> + * @offset - requested VMA
> +*/
> +static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec,
> +			   uint32_t handle, uint32_t flags,
> +			   uint64_t offset)
> +{
> +	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
> +	exec->handle = handle;
> +	exec->flags = flags;
> +	exec->offset = offset;
> +}
> +
> +/* gem_store_data_svm
> + * populate batch buffer with MI_STORE_DWORD_IMM command
> + * @fd: drm file descriptor
> + * @cmd_buf: batch buffer
> + * @vaddr: destination Virtual address
> + * @data: data to be store at destination
> + * @end: whether to end batch buffer or not
> +*/
> +static int gem_store_data_svm(int fd, uint32_t *cmd_buf, uint64_t vaddr,
> +			      uint32_t data, bool end)
> +{
> +	int i = 0;
> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
> +	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
> +
> +	cmd_buf[i++] = data;
> +	if (end) {
> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	return(i * sizeof(uint32_t));
> +}
> +
> +/* gem_store_data
> + * populate batch buffer with MI_STORE_DWORD_IMM command
> + * This one fills up reloc buffer as well
> + * @fd: drm file descriptor
> + * @cmd_buf: batch buffer
> + * @data: data to be store at destination
> + * @reloc - relocation entry
> + * @end: whether to end batch buffer or not
> +*/
> +static int gem_store_data(int fd, uint32_t *cmd_buf,
> +			  uint32_t handle, uint32_t data,
> +			  struct drm_i915_gem_relocation_entry *reloc,
> +			  bool end)
> +{
> +	int i = 0;
> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 reloc needed */
> +	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 reloc needed */
> +	reloc->offset = 1 * sizeof(uint32_t);
> +	reloc->delta = 0;
> +	reloc->target_handle = handle;
> +	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
> +	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
> +	reloc->presumed_offset = 0;
> +	cmd_buf[i++] = data;
> +	if (end) {
> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	return (i * sizeof(uint32_t));
> +}
> +
> +/* setup_execbuffer
> + * helper for buffer execution
> + * @execbuf - pointer to execbuffer
> + * @exec_object - pointer to exec object2 struct
> + * @ring - ring to be used
> + * @buffer_count - how manu buffers to submit
> + * @batch_length - length of batch buffer
> +*/
> +static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf,
> +			     struct drm_i915_gem_exec_object2 *exec_object,
> +			     int ring, int buffer_count, int batch_length)
> +{
> +	execbuf->buffers_ptr = (uint64_t)exec_object;
> +	execbuf->buffer_count = buffer_count;
> +	execbuf->batch_start_offset = 0;
> +	execbuf->batch_len = batch_length;
> +	execbuf->cliprects_ptr = 0;
> +	execbuf->num_cliprects = 0;
> +	execbuf->DR1 = 0;
> +	execbuf->DR4 = 0;
> +	execbuf->flags = ring;
> +	i915_execbuffer2_set_context_id(*execbuf, 0);
> +	execbuf->rsvd2 = 0;
> +}
> +
> +/* submit_and_sync
> + * Helper function for exec and sync functions
> + * @fd - drm fd
> + * @execbuf - pointer to execbuffer
> + * @batch_buf_handle - batch buffer handle
> +*/
> +static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf,
> +			    uint32_t batch_buf_handle)
> +{
> +	gem_execbuf(fd, execbuf);
> +	gem_sync(fd, batch_buf_handle);
> +}
> +
> +/* gem_userptr_sync
> + * helper for syncing to CPU domain - copy/paste from userblit
> + * @fd - drm fd
> + * @handle - buffer handle to sync
> +*/
> +static void gem_userptr_sync(int fd, uint32_t handle)
> +{
> +	gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
> +}
> +
> +
> +/* gem_pin_userptr_test
> + * This test will create a shared buffer, and create a command
> + * for GPU to write data in it
> + * CPU will read and make sure expected value is obtained
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +static void gem_pin_userptr_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	/* Check if driver pinned the buffer as requested */
> +	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
> +			"\nFailed to pin at requested offset");
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		      "\nCPU read does not match GPU write,\
> +			expected: 0x%x, got: 0x%x\n",
> +			data, shared_buffer[0]);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_bo
> + * This test will test softpinning of a gem buffer object
> + * Malloc a 4K buffer
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000
> + * Submit execbuffer
> + * Verify value pinned offset matches the request
> +*/
> +static void gem_pin_bo_test(void)
> +{
> +	int fd;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, unshared_buf_handle;
> +	struct drm_i915_gem_relocation_entry reloc[4];
> +	int ring, len;
> +	uint32_t value;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create gem buffer */
> +	unshared_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data(fd, batch_buffer, unshared_buf_handle, data,
> +				reloc, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], unshared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +	exec_object2[1].relocation_count = 1;
> +	exec_object2[1].relocs_ptr = (uint64_t)reloc;
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	/* Check if driver pinned the buffer as requested */
> +	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
> +			"\nFailed to pin at requested offset");
> +	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
> +	igt_assert(value == data);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, unshared_buf_handle);
> +	close(fd);
> +}
> +
> +
> +/* gem_multiple_process_test
> + * Run basic test simultaneously with multiple processes
> + * This will test pinning same VA separately in each process
> +
> + * fork();
> + * Execute basic test in parent/child processes
> +*/
> +#define MAX_NUM_PROCESSES 10
> +
> +static void gem_multiple_process_test(void)
> +{
> +	int fd;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	igt_fork(child, MAX_NUM_PROCESSES) {
> +		gem_pin_userptr_test();
> +	}
> +	igt_waitchildren();
> +
> +	close(fd);
> +}
> +
> +
> +/* gem_repin_test
> + * This test tries to repin a buffer at a previously pinned vma
> + * from a different execbuf.
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000 VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +
> + * Create second shared buffer
> + * Follow all steps above
> + * Execpt, for offset, use VMA of first buffer above
> + * Submit execbuffer
> + * Verify value of first DWORD in second shared buffer matches DATA
> +*/
> +static void gem_repin_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	uint32_t *shared_buffer1;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	/* Create gem object */
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set first elements to 0x0 */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE);
> +	shared_buffer[0] = 0x0;
> +	shared_buffer1[0] = 0x0;
> +
> +	/* share with GPU and get handles */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> +					  BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	igt_assert(*shared_buffer == data);
> +
> +	/* Second buffer */
> +	/* create command buffer with write command */
> +	pinning_offset = exec_object2[0].offset;
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	/* Pin at shared_buffer, not shared_buffer1 */
> +	/* We are requesting address where another buffer was pinned previously */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle1,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle1);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	igt_assert(*shared_buffer1 == data);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +
> +/* gem_repin_overlap_test
> + * This test will attempt to pin two buffers at the same VMA as part of the same
> +   execbuffer object
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create second shared buffer
> + * Create batch buffer to write DATA to first dword of each buffer
> + * Use same virtual address as destination addresses in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in both exec objects
> + * Set 'offset' in both exec objects to same VMA
> + * Submit execbuffer
> + * Command should return EINVAL, since we are trying to pin to same VMA
> +*/
> +static void gem_pin_overlap_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd, ret;
> +	uint32_t *shared_buffer;
> +	uint32_t *shared_buffer1;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[3];
> +	uint32_t shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> +					  BO_SIZE * 2);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], shared_buf_handle1,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +
> +	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, &execbuf);
> +
> +	/* expect to fail */
> +	igt_assert_neq(ret, 0);
> +	igt_assert(errno == EINVAL);
> +
> +	close(fd);
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +/* gem_softpin_stress_test
> + * Stress test which creates 10K buffers and shares with GPU
> + * Create 100K uint32 buffers of size 4K each
> + * Share with GPU using userptr ioctl
> + * Create batch buffer to write DATA in first element of each buffer
> + * Pin each buffer to varying addresses starting from 0x800000000000 going below
> + * Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
> + * Validate every buffer has DATA in first element
> + * Rinse and Repeat on Render ring
> +*/
> +#define STRESS_NUM_BUFFERS 100000
> +#define STRESS_NUM_LOOPS 100
> +#define STRESS_STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
> +
> +static void gem_softpin_stress_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t **shared_buffer;
> +	uint32_t *shared_handle;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 *exec_object2;
> +	uint32_t *batch_buffer;
> +	uint32_t batch_buf_handle;
> +	int ring, len;
> +	int buf, loop;
> +	uint64_t pinning_offset = 0x800000000000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +
> +	/* Allocate blobs for all data structures */
> +	shared_handle = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t));
> +	shared_buffer = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t *));
> +	exec_object2 = calloc(STRESS_NUM_BUFFERS + 1,
> +				sizeof(struct drm_i915_gem_exec_object2));
> +	/* 4 dwords per buffer + 2 for the end of batchbuffer */
> +	batch_buffer = calloc(STRESS_STORE_COMMANDS + 2, sizeof(uint32_t));
> +	batch_buf_handle = gem_create(fd, (STRESS_STORE_COMMANDS + 2)*4);
> +
> +	/* create command buffer with write commands */
> +	len = 0;
> +	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +		shared_buffer[buf] = create_mem_buffer(BO_SIZE);
> +		*shared_buffer[buf] = 0xFFFFFFFF;
> +
> +		/* share with GPU */
> +		shared_handle[buf] = init_userptr(fd, &userptr,
> +						  shared_buffer[buf],
> +						  BO_SIZE);
> +
> +		setup_exec_obj(&exec_object2[buf], shared_handle[buf],
> +			       EXEC_OBJECT_PINNED, pinning_offset);
> +		len += gem_store_data_svm(fd, batch_buffer + (len/4),
> +					  pinning_offset, buf,
> +					  (buf == STRESS_NUM_BUFFERS-1)? \
> +					  true:false);
> +
> +		/* decremental 4K aligned address */
> +		pinning_offset -= ALIGN(BO_SIZE, 4096);
> +	}
> +
> +	/* setup command buffer */
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle,
> +		       0, 0);
> +
> +	/* We want to run this on BLT ring if possible */
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd))) {
> +		ring = I915_EXEC_BLT;
> +
> +		setup_execbuffer(&execbuf, exec_object2, ring,
> +				 STRESS_NUM_BUFFERS + 1, len);
> +
> +		for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
> +			submit_and_sync(fd, &execbuf, batch_buf_handle);
> +			/* Set pinning offset back to original value */
> +			pinning_offset = 0x800000000000;
> +			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +				gem_userptr_sync(fd, shared_handle[buf]);
> +				igt_assert(exec_object2[buf].offset == pinning_offset);
> +				igt_fail_on_f(*shared_buffer[buf] != buf, \
> +				"Mismatch in buffer %d, iteration %d: 0x%08X\n", \
> +				buf, loop, *shared_buffer[buf]);
> +				pinning_offset -= ALIGN(BO_SIZE, 4096);
> +			}
> +			/* Reset the buffer entries for next iteration */
> +			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +				*shared_buffer[buf] = 0xFFFFFFFF;
> +			}
> +		}
> +	}
> +
> +	/* Now Render Ring */
> +	ring = I915_EXEC_RENDER;
> +	setup_execbuffer(&execbuf, exec_object2, ring,
> +			 STRESS_NUM_BUFFERS + 1, len);
> +	for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		pinning_offset = 0x800000000000;
> +		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +			gem_userptr_sync(fd, shared_handle[buf]);
> +			igt_assert(exec_object2[buf].offset == pinning_offset);
> +			igt_fail_on_f(*shared_buffer[buf] != buf, \
> +			"Mismatch in buffer %d, \
> +			iteration %d: 0x%08X\n", buf, loop, *shared_buffer[buf]);
> +			pinning_offset -= ALIGN(BO_SIZE, 4096);
> +		}
> +		/* Reset the buffer entries for next iteration */
> +		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +			*shared_buffer[buf] = 0xFFFFFFFF;
> +		}
> +	}
> +
> +	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +		gem_close(fd, shared_handle[buf]);
> +		free(shared_buffer[buf]);
> +	}
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_handle);
> +	free(shared_buffer);
> +	free(exec_object2);
> +	free(batch_buffer);
> +}
> +
> +/* gem_write_multipage_buffer
> + * Create a buffer spanning multiple pages, and share with GPU.
> + * Write to every element of the buffer
> + * and verify correct contents.
> +
> + * Create 8K buffer
> + * Share with GPU using userptr ioctl
> + * Create batch buffer to write DATA in all elements of buffer
> + * Execute Batch Buffer
> + * Validate every element has DATA
> +*/
> +
> +#define DWORD_SIZE sizeof(uint32_t)
> +#define BB_SIZE ((MULTIPAGE_BO_SIZE / DWORD_SIZE) * STORE_BATCH_BUFFER_SIZE) + 2
> +#define NUM_DWORDS (MULTIPAGE_BO_SIZE/sizeof(uint32_t))
> +static void gem_write_multipage_buffer_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	uint32_t shared_handle;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[BB_SIZE];
> +	uint32_t batch_buf_handle;
> +	int ring, len, j;
> +	uint64_t pinning_offset=0x1000;
> +	uint64_t vaddr;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
> +	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
> +
> +	len = 0;
> +	memset(batch_buffer, 0, sizeof(batch_buffer));
> +	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
> +
> +	/* share with GPU */
> +	shared_handle = init_userptr(fd, &userptr, shared_buffer,
> +				     MULTIPAGE_BO_SIZE);
> +	setup_exec_obj(&exec_object2[0], shared_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +
> +	/* create command buffer with write commands */
> +	vaddr = pinning_offset;
> +	for(j=0; j< NUM_DWORDS; j++) {
> +		len += gem_store_data_svm(fd, batch_buffer + (len/4), vaddr,
> +					  j,
> +					  (j == NUM_DWORDS - 1) ? true:false);
> +		vaddr += sizeof(shared_buffer[0]);  /* 4 bytes */
> +	}
> +
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_handle);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	for(j = 0; j < (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++) {
> +		igt_fail_on_f(shared_buffer[j] != j,
> +		"Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_invalid_vma_test
> + * This test will request to pin a shared buffer to an invalid
> + * VMA  > 48-bit address if system supports 48B PPGTT
> + * If system supports 32B PPGTT, it will test the equivalent invalid VMA
> + * Create shared buffer of size 4K
> + * Try and Pin object to invalid address
> +*/
> +static void gem_pin_invalid_vma_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[1];
> +	uint32_t shared_buf_handle;
> +	int ring;
> +	uint64_t invalid_address_for_48b = 0x9000000000000; /* 52 bit address */
> +	uint64_t invalid_address_for_32b = 0x900000000; /* 36 bit address */
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT) ||
> +		    uses_full_ppgtt(fd, FULL_32_BIT_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	if (uses_full_ppgtt(fd, FULL_48_BIT_PPGTT)) {
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED, invalid_address_for_48b);
> +	} else {
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED, invalid_address_for_32b);
> +	}
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 1, 0);
> +
> +	/* Expect execbuf to fail */
> +	ret = drmIoctl(fd,
> +		       DRM_IOCTL_I915_GEM_EXECBUFFER2,
> +		       &execbuf);
> +
> +	igt_assert(errno == ENOSPC);
> +	igt_assert_neq(ret, 0);
> +
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +
> +/* gem_pin_high_address_test
> + * This test will create a shared buffer, and create a command
> + * for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
> + * CPU will read and make sure expected value is obtained
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use virtual address of buffer as 0x1100000000 (> 32 bit)
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to shared buffer VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> + * Now try same test without using 48BIT flag
> + * test should pass with requested pinning address
> +*/
> +
> +static void gem_pin_high_address_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	igt_assert(exec_object2[0].offset == high_address);
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, \
> +		expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
> +
> +	/* Now try pinning to high address without 48BIT flag */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, high_address);
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	igt_assert(exec_object2[0].offset == high_address);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_near_48Bit_test
> + * This test will create a shared buffer,
> + * and create a command for GPU to write data in it. It will attempt
> + * to pin the buffer at address > 47 bits <= 48-bit.
> + * CPU will read and make sure expected value is obtained
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use virtual address of buffer as range between 47-bit and 48-bit
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to shared buffer VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000
> +#define END_HIGH_ADDRESS 0xFFFFFFFFC000
> +#define ADDRESS_INCREMENT 0x2000000000
> +static void gem_pin_near_48Bit_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS;
> +						high_address+=ADDRESS_INCREMENT) {
> +		/* create command buffer with write command */
> +		len = gem_store_data_svm(fd, batch_buffer, high_address,
> +					data, true);
> +		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +		/* submit command buffer */
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
> +			       high_address);
> +		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +		ring = I915_EXEC_RENDER;
> +		setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		gem_userptr_sync(fd, shared_buf_handle);
> +
> +		igt_assert(exec_object2[0].offset == high_address);
> +		/* check on CPU to see if value changes */
> +		igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, expected: 0x%x, \
> +		got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +
> +int main(int argc, char* argv[])
> +{
> +	igt_subtest_init(argc, argv);
> +	igt_skip_on_simulation();
> +
> +	/* All tests need PPGTT support */
> +	igt_subtest("gem_pin_userptr") {
> +		gem_pin_userptr_test();
> +	}
> +	igt_subtest("gem_pin_bo") {
> +		gem_pin_bo_test();
> +	}
> +	igt_subtest("gem_multiple_process") {
> +		gem_multiple_process_test();
> +	}
> +	igt_subtest("gem_repin") {
> +		gem_repin_test();
> +	}
> +	igt_subtest("gem_pin_overlap") {
> +		gem_pin_overlap_test();
> +	}
> +	igt_subtest("gem_write_multipage_buffer") {
> +		gem_write_multipage_buffer_test();
> +	}
> +
> +	/* Following tests need 32/48 Bit PPGTT support */
> +	igt_subtest("gem_pin_invalid_vma") {
> +		gem_pin_invalid_vma_test();
> +	}
> +
> +	/* Following tests need 48 Bit PPGTT support */
> +	igt_subtest("gem_softpin_stress") {
> +		gem_softpin_stress_test();
> +	}
> +	igt_subtest("gem_pin_high_address") {
> +		gem_pin_high_address_test();
> +	}
> +	igt_subtest("gem_pin_near_48Bit") {
> +		gem_pin_near_48Bit_test();
> +	}
> +
> +	igt_exit();
> +}
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
  2015-12-02 12:24 Vinay Belgaumkar
@ 2015-12-03 11:42 ` Tvrtko Ursulin
  0 siblings, 0 replies; 19+ messages in thread
From: Tvrtko Ursulin @ 2015-12-03 11:42 UTC (permalink / raw)
  To: Vinay Belgaumkar, intel-gfx


Hi,

On 02/12/15 12:24, Vinay Belgaumkar wrote:
> These tests exercise the userptr ioctl to create shared buffers
> between CPU and GPU. They contain error and normal usage scenarios.
> They also contain a couple of stress tests which copy buffers between
> CPU and GPU. These tests rely on the softpin patch in order to pin buffers
> to a certain VA.
>
> Caveat: These tests were designed to run on 64-bit system. Future work
> includes adding logic to ensure these tests can run on 32-bit systems with
> PPGTT support. Some tests are currently disabled for 32-bit systems for that
> reason.
>
> v2: Added cc and signed-off-by fields
>
> v3: Fixed review comments, added helper functions. Removed userptr error
> scenarios covered by existing userptr tests. Modified stress test to have
> 100K buffers, it now runs for ~30 mins, checks every element has been written
> to correctly, and pins buffers at different VMAs.
>
> v4: Changed name to gem_softpin
>
> v5: More fixes. Removed the file based tests, will move them to userptr tests.
> Added a function that validates appropriate PPGTT support before running tests.
> Optimized stack space and memory footprint in stress test. Removed the eviction
> test, will add it back after verifying proper functionality.
>
> v6: Split basic test into userptr and bo
> Fixed some coding style issues.
>
> v7: Enhanced invalid vma pinning test to verify 32-bit PPGTT functionality.
> Enabled the test for 32-bit PPGTT systems, and verify pinning fails above
> 32-bit addresses. Enhanced the high adress pinning test to ensure pinning
> fails when EXEC_OBJECT_PINNED flag is not used. Some more cosmetic fixes to
> close buffer handles. Changed userptr function to used synchronized operations.
>
> v8: Minor change to high address pinning test as per comment.
>
> v9: Skip the tests if softpin support is not present.
>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
>   tests/.gitignore       |    1 +
>   tests/Makefile.sources |    1 +
>   tests/gem_softpin.c    | 1086 ++++++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 1088 insertions(+)
>   create mode 100644 tests/gem_softpin.c

Git am complained (a lot) about trailing whitespace when I applied the 
patch locally. If you fix that you can add:

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko

>
> diff --git a/tests/.gitignore b/tests/.gitignore
> index 80af9a7..424870b 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -21,6 +21,7 @@ gem_bad_blit
>   gem_bad_length
>   gem_bad_reloc
>   gem_basic
> +gem_softpin
>   gem_caching
>   gem_close_race
>   gem_concurrent_all
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 8fb2de8..2008d4a 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -11,6 +11,7 @@ TESTS_progs_M = \
>   	drv_hangman \
>   	gem_bad_reloc \
>   	gem_basic \
> +	gem_softpin \
>   	gem_caching \
>   	gem_close_race \
>   	gem_concurrent_blit \
> diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
> new file mode 100644
> index 0000000..fac83a1
> --- /dev/null
> +++ b/tests/gem_softpin.c
> @@ -0,0 +1,1086 @@
> +/*
> + * Copyright © 2015 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + *
> + * Authors:
> + *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> + *    Thomas Daniel <thomas.daniel@intel.com>
> + *
> + */
> +
> +#include <unistd.h>
> +#include <stdlib.h>
> +#include <stdint.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include <fcntl.h>
> +#include <inttypes.h>
> +#include <errno.h>
> +#include <sys/stat.h>
> +#include <sys/ioctl.h>
> +#include <sys/time.h>
> +#include <malloc.h>
> +#include "drm.h"
> +#include "ioctl_wrappers.h"
> +#include "drmtest.h"
> +#include "intel_chipset.h"
> +#include "intel_io.h"
> +#include "i915_drm.h"
> +#include <assert.h>
> +#include <sys/wait.h>
> +#include <sys/ipc.h>
> +#include <sys/shm.h>
> +#include "igt_kms.h"
> +#include <inttypes.h>
> +#include <sys/types.h>
> +#include <sys/stat.h>
> +
> +#define BO_SIZE 4096
> +#define MULTIPAGE_BO_SIZE 2 * BO_SIZE
> +#define STORE_BATCH_BUFFER_SIZE 4
> +#define EXEC_OBJECT_PINNED	(1<<4)
> +#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
> +#define SHARED_BUFFER_SIZE 4096
> +
> +typedef struct drm_i915_gem_userptr i915_gem_userptr;
> +
> +static uint32_t init_userptr(int fd, i915_gem_userptr *, void *ptr, uint64_t size);
> +static void *create_mem_buffer(uint64_t size);
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
> +static void gem_pin_userptr_test(void);
> +static void gem_pin_bo_test(void);
> +static void gem_pin_invalid_vma_test(void);
> +static void gem_pin_overlap_test(void);
> +static void gem_pin_high_address_test(void);
> +
> +#define NO_PPGTT 0
> +#define ALIASING_PPGTT 1
> +#define FULL_32_BIT_PPGTT 2
> +#define FULL_48_BIT_PPGTT 3
> +/* uses_full_ppgtt
> + * Finds supported PPGTT details.
> + * @fd DRM fd
> + * @min can be
> + * 0 - No PPGTT
> + * 1 - Aliasing PPGTT
> + * 2 - Full PPGTT (32b)
> + * 3 - Full PPGTT (48b)
> + * RETURNS true/false if min support is present
> +*/
> +static bool uses_full_ppgtt(int fd, int min)
> +{
> +	struct drm_i915_getparam gp;
> +	int val = 0;
> +
> +	memset(&gp, 0, sizeof(gp));
> +	gp.param = 18; /* HAS_ALIASING_PPGTT */
> +	gp.value = &val;
> +
> +	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
> +		return 0;
> +
> +	errno = 0;
> +	return val >= min;
> +}
> +
> +/* has_softpin_support
> + * Finds if softpin feature is supported
> + * @fd DRM fd
> +*/
> +static bool has_softpin_support(int fd)
> +{
> +	struct drm_i915_getparam gp;
> +	int val = 0;
> +
> +	memset(&gp, 0, sizeof(gp));
> +	gp.param = 37; /* I915_PARAM_HAS_EXEC_SOFTPIN */
> +	gp.value = &val;
> +
> +	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
> +		return 0;
> +
> +	errno = 0;
> +	return (val == 1);
> +}
> +
> +/* gem_call_userptr_ioctl
> + * Helper to call ioctl - TODO: move to lib
> + * @fd - drm fd
> + * @userptr - pointer to initialised userptr
> + * RETURNS status of ioctl call
> +*/
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr)
> +{
> +	int ret;
> +
> +	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
> +
> +	if (ret)
> +		ret = errno;
> +
> +	return ret;
> +}
> +
> +/* init_userptr
> + * Helper that inits userptr an returns handle
> + * @fd - drm fd
> + * @userptr - pointer to empty userptr
> + * @ptr - buffer to be shared
> + * @size - size of buffer
> + * @ro - read only flag
> + * RETURNS handle to shared buffer
> +*/
> +static uint32_t init_userptr(int fd, i915_gem_userptr *userptr, void *ptr,
> +			     uint64_t size)
> +{
> +	int ret;
> +
> +	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
> +
> +	userptr->user_ptr = (uint64_t)ptr; /* Need the cast to overcome compiler warning */
> +	userptr->user_size = size;
> +	userptr->flags = 0; /* use synchronized operation */
> +
> +	ret = gem_call_userptr_ioctl(fd, userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	return userptr->handle;
> +}
> +
> +/* create_mem_buffer
> + * Creates a 4K aligned CPU buffer
> + * @size - size of buffer
> + * RETURNS pointer to buffer of @size
> +*/
> +static void *create_mem_buffer(uint64_t size)
> +{
> +	void *addr;
> +	int ret;
> +
> +	ret = posix_memalign(&addr, 4096, size);
> +	igt_assert(ret == 0);
> +
> +	return addr;
> +}
> +
> +/* setup_exec_obj
> + * populate exec object
> + * @exec - exec object
> + * @handle - handle to gem buffer
> + * @flags - any flags
> + * @offset - requested VMA
> +*/
> +static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec,
> +			   uint32_t handle, uint32_t flags,
> +			   uint64_t offset)
> +{
> +	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
> +	exec->handle = handle;
> +	exec->flags = flags;
> +	exec->offset = offset;
> +}
> +
> +/* gem_store_data_svm
> + * populate batch buffer with MI_STORE_DWORD_IMM command
> + * @fd: drm file descriptor
> + * @cmd_buf: batch buffer
> + * @vaddr: destination Virtual address
> + * @data: data to be store at destination
> + * @end: whether to end batch buffer or not
> +*/
> +static int gem_store_data_svm(int fd, uint32_t *cmd_buf, uint64_t vaddr,
> +			      uint32_t data, bool end)
> +{
> +	int i = 0;
> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
> +	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
> +
> +	cmd_buf[i++] = data;
> +	if (end) {
> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	return(i * sizeof(uint32_t));
> +}
> +
> +/* gem_store_data
> + * populate batch buffer with MI_STORE_DWORD_IMM command
> + * This one fills up reloc buffer as well
> + * @fd: drm file descriptor
> + * @cmd_buf: batch buffer
> + * @data: data to be store at destination
> + * @reloc - relocation entry
> + * @end: whether to end batch buffer or not
> +*/
> +static int gem_store_data(int fd, uint32_t *cmd_buf,
> +			  uint32_t handle, uint32_t data,
> +			  struct drm_i915_gem_relocation_entry *reloc,
> +			  bool end)
> +{
> +	int i = 0;
> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 reloc needed */
> +	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 reloc needed */
> +	reloc->offset = 1 * sizeof(uint32_t);
> +	reloc->delta = 0;
> +	reloc->target_handle = handle;
> +	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
> +	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
> +	reloc->presumed_offset = 0;
> +	cmd_buf[i++] = data;
> +	if (end) {
> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	return (i * sizeof(uint32_t));
> +}
> +
> +/* setup_execbuffer
> + * helper for buffer execution
> + * @execbuf - pointer to execbuffer
> + * @exec_object - pointer to exec object2 struct
> + * @ring - ring to be used
> + * @buffer_count - how manu buffers to submit
> + * @batch_length - length of batch buffer
> +*/
> +static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf,
> +			     struct drm_i915_gem_exec_object2 *exec_object,
> +			     int ring, int buffer_count, int batch_length)
> +{
> +	execbuf->buffers_ptr = (uint64_t)exec_object;
> +	execbuf->buffer_count = buffer_count;
> +	execbuf->batch_start_offset = 0;
> +	execbuf->batch_len = batch_length;
> +	execbuf->cliprects_ptr = 0;
> +	execbuf->num_cliprects = 0;
> +	execbuf->DR1 = 0;
> +	execbuf->DR4 = 0;
> +	execbuf->flags = ring;
> +	i915_execbuffer2_set_context_id(*execbuf, 0);
> +	execbuf->rsvd2 = 0;
> +}
> +
> +/* submit_and_sync
> + * Helper function for exec and sync functions
> + * @fd - drm fd
> + * @execbuf - pointer to execbuffer
> + * @batch_buf_handle - batch buffer handle
> +*/
> +static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf,
> +			    uint32_t batch_buf_handle)
> +{
> +	gem_execbuf(fd, execbuf);
> +	gem_sync(fd, batch_buf_handle);
> +}
> +
> +/* gem_userptr_sync
> + * helper for syncing to CPU domain - copy/paste from userblit
> + * @fd - drm fd
> + * @handle - buffer handle to sync
> +*/
> +static void gem_userptr_sync(int fd, uint32_t handle)
> +{
> +	gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
> +}
> +
> +
> +/* gem_pin_userptr_test
> + * This test will create a shared buffer, and create a command
> + * for GPU to write data in it
> + * CPU will read and make sure expected value is obtained
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +static void gem_pin_userptr_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	/* Check if driver pinned the buffer as requested */
> +	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
> +			"\nFailed to pin at requested offset");
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		      "\nCPU read does not match GPU write,\
> +			expected: 0x%x, got: 0x%x\n",
> +			data, shared_buffer[0]);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_bo
> + * This test will test softpinning of a gem buffer object
> + * Malloc a 4K buffer
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000
> + * Submit execbuffer
> + * Verify value pinned offset matches the request
> +*/
> +static void gem_pin_bo_test(void)
> +{
> +	int fd;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, unshared_buf_handle;
> +	struct drm_i915_gem_relocation_entry reloc[4];
> +	int ring, len;
> +	uint32_t value;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create gem buffer */
> +	unshared_buf_handle = gem_create(fd, BO_SIZE);
> +	
> +	/* create command buffer with write command */
> +	len = gem_store_data(fd, batch_buffer, unshared_buf_handle, data,
> +				reloc, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], unshared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +	exec_object2[1].relocation_count = 1;
> +	exec_object2[1].relocs_ptr = (uint64_t)reloc;
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	/* Check if driver pinned the buffer as requested */
> +	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
> +			"\nFailed to pin at requested offset");
> +	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
> +	igt_assert(value == data);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, unshared_buf_handle);
> +	close(fd);
> +}
> +
> +
> +/* gem_multiple_process_test
> + * Run basic test simultaneously with multiple processes
> + * This will test pinning same VA separately in each process
> +
> + * fork();
> + * Execute basic test in parent/child processes
> +*/
> +#define MAX_NUM_PROCESSES 10
> +
> +static void gem_multiple_process_test(void)
> +{
> +	int fd;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	igt_fork(child, MAX_NUM_PROCESSES) {
> +		gem_pin_userptr_test();
> +	}
> +	igt_waitchildren();
> +
> +	close(fd);
> +}
> +
> +
> +/* gem_repin_test
> + * This test tries to repin a buffer at a previously pinned vma
> + * from a different execbuf.
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000 VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +
> + * Create second shared buffer
> + * Follow all steps above
> + * Execpt, for offset, use VMA of first buffer above
> + * Submit execbuffer
> + * Verify value of first DWORD in second shared buffer matches DATA
> +*/
> +static void gem_repin_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	uint32_t *shared_buffer1;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	/* Create gem object */
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set first elements to 0x0 */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE);
> +	shared_buffer[0] = 0x0;
> +	shared_buffer1[0] = 0x0;
> +
> +	/* share with GPU and get handles */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> +					  BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	igt_assert(*shared_buffer == data);
> +
> +	/* Second buffer */
> +	/* create command buffer with write command */
> +	pinning_offset = exec_object2[0].offset;
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	/* Pin at shared_buffer, not shared_buffer1 */
> +	/* We are requesting address where another buffer was pinned previously */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle1,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle1);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	igt_assert(*shared_buffer1 == data);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +
> +/* gem_repin_overlap_test
> + * This test will attempt to pin two buffers at the same VMA as part of the same
> +   execbuffer object
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create second shared buffer
> + * Create batch buffer to write DATA to first dword of each buffer
> + * Use same virtual address as destination addresses in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in both exec objects
> + * Set 'offset' in both exec objects to same VMA
> + * Submit execbuffer
> + * Command should return EINVAL, since we are trying to pin to same VMA
> +*/
> +static void gem_pin_overlap_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd, ret;
> +	uint32_t *shared_buffer;
> +	uint32_t *shared_buffer1;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[3];
> +	uint32_t shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> +					  BO_SIZE * 2);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], shared_buf_handle1,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +
> +	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, &execbuf);
> +
> +	/* expect to fail */
> +	igt_assert_neq(ret, 0);
> +	igt_assert(errno == EINVAL);
> +
> +	close(fd);
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +/* gem_softpin_stress_test
> + * Stress test which creates 10K buffers and shares with GPU
> + * Create 100K uint32 buffers of size 4K each
> + * Share with GPU using userptr ioctl
> + * Create batch buffer to write DATA in first element of each buffer
> + * Pin each buffer to varying addresses starting from 0x800000000000 going below
> + * Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
> + * Validate every buffer has DATA in first element
> + * Rinse and Repeat on Render ring
> +*/
> +#define STRESS_NUM_BUFFERS 100000
> +#define STRESS_NUM_LOOPS 100
> +#define STRESS_STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
> +
> +static void gem_softpin_stress_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t **shared_buffer;
> +	uint32_t *shared_handle;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 *exec_object2;
> +	uint32_t *batch_buffer;
> +	uint32_t batch_buf_handle;
> +	int ring, len;
> +	int buf, loop;
> +	uint64_t pinning_offset = 0x800000000000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +
> +	/* Allocate blobs for all data structures */
> +	shared_handle = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t));
> +	shared_buffer = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t *));
> +	exec_object2 = calloc(STRESS_NUM_BUFFERS + 1,
> +				sizeof(struct drm_i915_gem_exec_object2));
> +	/* 4 dwords per buffer + 2 for the end of batchbuffer */
> +	batch_buffer = calloc(STRESS_STORE_COMMANDS + 2, sizeof(uint32_t));
> +	batch_buf_handle = gem_create(fd, (STRESS_STORE_COMMANDS + 2)*4);
> +
> +	/* create command buffer with write commands */
> +	len = 0;
> +	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +		shared_buffer[buf] = create_mem_buffer(BO_SIZE);
> +		*shared_buffer[buf] = 0xFFFFFFFF;
> +
> +		/* share with GPU */
> +		shared_handle[buf] = init_userptr(fd, &userptr,
> +						  shared_buffer[buf],
> +						  BO_SIZE);
> +
> +		setup_exec_obj(&exec_object2[buf], shared_handle[buf],
> +			       EXEC_OBJECT_PINNED, pinning_offset);
> +		len += gem_store_data_svm(fd, batch_buffer + (len/4),
> +					  pinning_offset, buf,
> +					  (buf == STRESS_NUM_BUFFERS-1)? \
> +					  true:false);
> +		
> +		/* decremental 4K aligned address */
> +		pinning_offset -= ALIGN(BO_SIZE, 4096);
> +	}
> +
> +	/* setup command buffer */
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle,
> +		       0, 0);
> +
> +	/* We want to run this on BLT ring if possible */
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd))) {
> +		ring = I915_EXEC_BLT;
> +
> +		setup_execbuffer(&execbuf, exec_object2, ring,
> +				 STRESS_NUM_BUFFERS + 1, len);
> +
> +		for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
> +			submit_and_sync(fd, &execbuf, batch_buf_handle);
> +			/* Set pinning offset back to original value */
> +			pinning_offset = 0x800000000000;
> +			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +				gem_userptr_sync(fd, shared_handle[buf]);
> +				igt_assert(exec_object2[buf].offset == pinning_offset);
> +				igt_fail_on_f(*shared_buffer[buf] != buf, \
> +				"Mismatch in buffer %d, iteration %d: 0x%08X\n", \
> +				buf, loop, *shared_buffer[buf]);
> +				pinning_offset -= ALIGN(BO_SIZE, 4096);
> +			}
> +			/* Reset the buffer entries for next iteration */
> +			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +				*shared_buffer[buf] = 0xFFFFFFFF;
> +			}
> +		}
> +	}
> +
> +	/* Now Render Ring */
> +	ring = I915_EXEC_RENDER;
> +	setup_execbuffer(&execbuf, exec_object2, ring,
> +			 STRESS_NUM_BUFFERS + 1, len);
> +	for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		pinning_offset = 0x800000000000;
> +		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +			gem_userptr_sync(fd, shared_handle[buf]);
> +			igt_assert(exec_object2[buf].offset == pinning_offset);
> +			igt_fail_on_f(*shared_buffer[buf] != buf, \
> +			"Mismatch in buffer %d, \
> +			iteration %d: 0x%08X\n", buf, loop, *shared_buffer[buf]);
> +			pinning_offset -= ALIGN(BO_SIZE, 4096);
> +		}
> +		/* Reset the buffer entries for next iteration */
> +		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +			*shared_buffer[buf] = 0xFFFFFFFF;
> +		}
> +	}
> +
> +	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +		gem_close(fd, shared_handle[buf]);
> +		free(shared_buffer[buf]);
> +	}
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_handle);
> +	free(shared_buffer);
> +	free(exec_object2);
> +	free(batch_buffer);
> +}
> +
> +/* gem_write_multipage_buffer
> + * Create a buffer spanning multiple pages, and share with GPU.
> + * Write to every element of the buffer
> + * and verify correct contents.
> +
> + * Create 8K buffer
> + * Share with GPU using userptr ioctl
> + * Create batch buffer to write DATA in all elements of buffer
> + * Execute Batch Buffer
> + * Validate every element has DATA
> +*/
> +
> +#define DWORD_SIZE sizeof(uint32_t)
> +#define BB_SIZE ((MULTIPAGE_BO_SIZE / DWORD_SIZE) * STORE_BATCH_BUFFER_SIZE) + 2
> +#define NUM_DWORDS (MULTIPAGE_BO_SIZE/sizeof(uint32_t))
> +static void gem_write_multipage_buffer_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	uint32_t shared_handle;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[BB_SIZE];
> +	uint32_t batch_buf_handle;
> +	int ring, len, j;
> +	uint64_t pinning_offset=0x1000;
> +	uint64_t vaddr;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
> +	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
> +
> +	len = 0;
> +	memset(batch_buffer, 0, sizeof(batch_buffer));
> +	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
> +
> +	/* share with GPU */
> +	shared_handle = init_userptr(fd, &userptr, shared_buffer,
> +				     MULTIPAGE_BO_SIZE);
> +	setup_exec_obj(&exec_object2[0], shared_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +
> +	/* create command buffer with write commands */
> +	vaddr = pinning_offset;
> +	for(j=0; j< NUM_DWORDS; j++) {
> +		len += gem_store_data_svm(fd, batch_buffer + (len/4), vaddr,
> +					  j,
> +					  (j == NUM_DWORDS - 1) ? true:false);
> +		vaddr += sizeof(shared_buffer[0]);  /* 4 bytes */
> +	}
> +
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_handle);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	for(j = 0; j < (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++) {
> +		igt_fail_on_f(shared_buffer[j] != j,
> +		"Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_invalid_vma_test
> + * This test will request to pin a shared buffer to an invalid
> + * VMA  > 48-bit address if system supports 48B PPGTT
> + * If system supports 32B PPGTT, it will test the equivalent invalid VMA
> + * Create shared buffer of size 4K
> + * Try and Pin object to invalid address
> +*/
> +static void gem_pin_invalid_vma_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[1];
> +	uint32_t shared_buf_handle;
> +	int ring;
> +	uint64_t invalid_address_for_48b = 0x9000000000000; /* 52 bit address */
> +	uint64_t invalid_address_for_32b = 0x900000000; /* 36 bit address */
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT) ||
> +		    uses_full_ppgtt(fd, FULL_32_BIT_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +	
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	if (uses_full_ppgtt(fd, FULL_48_BIT_PPGTT)) {
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED, invalid_address_for_48b);
> +	} else {
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED, invalid_address_for_32b);
> +	}
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 1, 0);
> +
> +	/* Expect execbuf to fail */
> +	ret = drmIoctl(fd,
> +		       DRM_IOCTL_I915_GEM_EXECBUFFER2,
> +		       &execbuf);
> +
> +	igt_assert(errno == ENOSPC);
> +	igt_assert_neq(ret, 0);
> +	
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +
> +/* gem_pin_high_address_test
> + * This test will create a shared buffer, and create a command
> + * for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
> + * CPU will read and make sure expected value is obtained
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use virtual address of buffer as 0x1100000000 (> 32 bit)
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to shared buffer VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> + * Now try same test without using 48BIT flag
> + * test should pass with requested pinning address
> +*/
> +
> +static void gem_pin_high_address_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	igt_assert(exec_object2[0].offset == high_address);
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, \
> +		expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
> +
> +	/* Now try pinning to high address without 48BIT flag */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, high_address);
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	igt_assert(exec_object2[0].offset == high_address);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_near_48Bit_test
> + * This test will create a shared buffer,
> + * and create a command for GPU to write data in it. It will attempt
> + * to pin the buffer at address > 47 bits <= 48-bit.
> + * CPU will read and make sure expected value is obtained
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use virtual address of buffer as range between 47-bit and 48-bit
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to shared buffer VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000
> +#define END_HIGH_ADDRESS 0xFFFFFFFFC000
> +#define ADDRESS_INCREMENT 0x2000000000
> +static void gem_pin_near_48Bit_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +	igt_require(has_softpin_support(fd));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS;
> +						high_address+=ADDRESS_INCREMENT) {
> +		/* create command buffer with write command */
> +		len = gem_store_data_svm(fd, batch_buffer, high_address,
> +					data, true);
> +		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +		/* submit command buffer */
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
> +			       high_address);
> +		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +		ring = I915_EXEC_RENDER;
> +		setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		gem_userptr_sync(fd, shared_buf_handle);
> +
> +		igt_assert(exec_object2[0].offset == high_address);
> +		/* check on CPU to see if value changes */
> +		igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, expected: 0x%x, \
> +		got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +
> +int main(int argc, char* argv[])
> +{
> +	igt_subtest_init(argc, argv);
> +	igt_skip_on_simulation();
> +
> +	/* All tests need PPGTT support */
> +	igt_subtest("gem_pin_userptr") {
> +		gem_pin_userptr_test();
> +	}
> +	igt_subtest("gem_pin_bo") {
> +		gem_pin_bo_test();
> +	}
> +	igt_subtest("gem_multiple_process") {
> +		gem_multiple_process_test();
> +	}
> +	igt_subtest("gem_repin") {
> +		gem_repin_test();
> +	}
> +	igt_subtest("gem_pin_overlap") {
> +		gem_pin_overlap_test();
> +	}
> +	igt_subtest("gem_write_multipage_buffer") {
> +		gem_write_multipage_buffer_test();
> +	}
> +
> +	/* Following tests need 32/48 Bit PPGTT support */
> +	igt_subtest("gem_pin_invalid_vma") {
> +		gem_pin_invalid_vma_test();
> +	}
> +
> +	/* Following tests need 48 Bit PPGTT support */
> +	igt_subtest("gem_softpin_stress") {
> +		gem_softpin_stress_test();
> +	}
> +	igt_subtest("gem_pin_high_address") {
> +		gem_pin_high_address_test();
> +	}
> +	igt_subtest("gem_pin_near_48Bit") {
> +		gem_pin_near_48Bit_test();
> +	}
> +
> +	igt_exit();
> +}
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
@ 2015-12-03  8:36 Vinay Belgaumkar
  2015-12-03 16:42 ` Tvrtko Ursulin
  2015-12-08 11:57 ` Michel Thierry
  0 siblings, 2 replies; 19+ messages in thread
From: Vinay Belgaumkar @ 2015-12-03  8:36 UTC (permalink / raw)
  To: intel-gfx; +Cc: Vinay Belgaumkar

These tests exercise the userptr ioctl to create shared buffers
between CPU and GPU. They contain error and normal usage scenarios.
They also contain a couple of stress tests which copy buffers between
CPU and GPU. These tests rely on the softpin patch in order to pin buffers
to a certain VA.

Caveat: These tests were designed to run on 64-bit system. Future work
includes adding logic to ensure these tests can run on 32-bit systems with
PPGTT support. Some tests are currently disabled for 32-bit systems for that
reason.

v2: Added cc and signed-off-by fields

v3: Fixed review comments, added helper functions. Removed userptr error
scenarios covered by existing userptr tests. Modified stress test to have
100K buffers, it now runs for ~30 mins, checks every element has been written
to correctly, and pins buffers at different VMAs.

v4: Changed name to gem_softpin

v5: More fixes. Removed the file based tests, will move them to userptr tests.
Added a function that validates appropriate PPGTT support before running tests.
Optimized stack space and memory footprint in stress test. Removed the eviction
test, will add it back after verifying proper functionality.

v6: Split basic test into userptr and bo
Fixed some coding style issues.

v7: Enhanced invalid vma pinning test to verify 32-bit PPGTT functionality.
Enabled the test for 32-bit PPGTT systems, and verify pinning fails above
32-bit addresses. Enhanced the high adress pinning test to ensure pinning
fails when EXEC_OBJECT_PINNED flag is not used. Some more cosmetic fixes to
close buffer handles. Changed userptr function to used synchronized operations.

v8: Minor change to high address pinning test as per comment.

v9: Skip the tests if softpin support is not present.

v10: Removed trailing white spaces.

Cc: Michel Thierry <michel.thierry@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
 tests/.gitignore       |    1 +
 tests/Makefile.sources |    1 +
 tests/gem_softpin.c    | 1086 ++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 1088 insertions(+)
 create mode 100644 tests/gem_softpin.c

diff --git a/tests/.gitignore b/tests/.gitignore
index 80af9a7..424870b 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -21,6 +21,7 @@ gem_bad_blit
 gem_bad_length
 gem_bad_reloc
 gem_basic
+gem_softpin
 gem_caching
 gem_close_race
 gem_concurrent_all
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 8fb2de8..2008d4a 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -11,6 +11,7 @@ TESTS_progs_M = \
 	drv_hangman \
 	gem_bad_reloc \
 	gem_basic \
+	gem_softpin \
 	gem_caching \
 	gem_close_race \
 	gem_concurrent_blit \
diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
new file mode 100644
index 0000000..a5d3694
--- /dev/null
+++ b/tests/gem_softpin.c
@@ -0,0 +1,1086 @@
+/*
+ * Copyright © 2015 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ * Authors:
+ *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
+ *    Thomas Daniel <thomas.daniel@intel.com>
+ *
+ */
+
+#include <unistd.h>
+#include <stdlib.h>
+#include <stdint.h>
+#include <stdio.h>
+#include <string.h>
+#include <fcntl.h>
+#include <inttypes.h>
+#include <errno.h>
+#include <sys/stat.h>
+#include <sys/ioctl.h>
+#include <sys/time.h>
+#include <malloc.h>
+#include "drm.h"
+#include "ioctl_wrappers.h"
+#include "drmtest.h"
+#include "intel_chipset.h"
+#include "intel_io.h"
+#include "i915_drm.h"
+#include <assert.h>
+#include <sys/wait.h>
+#include <sys/ipc.h>
+#include <sys/shm.h>
+#include "igt_kms.h"
+#include <inttypes.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+
+#define BO_SIZE 4096
+#define MULTIPAGE_BO_SIZE 2 * BO_SIZE
+#define STORE_BATCH_BUFFER_SIZE 4
+#define EXEC_OBJECT_PINNED	(1<<4)
+#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
+#define SHARED_BUFFER_SIZE 4096
+
+typedef struct drm_i915_gem_userptr i915_gem_userptr;
+
+static uint32_t init_userptr(int fd, i915_gem_userptr *, void *ptr, uint64_t size);
+static void *create_mem_buffer(uint64_t size);
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
+static void gem_pin_userptr_test(void);
+static void gem_pin_bo_test(void);
+static void gem_pin_invalid_vma_test(void);
+static void gem_pin_overlap_test(void);
+static void gem_pin_high_address_test(void);
+
+#define NO_PPGTT 0
+#define ALIASING_PPGTT 1
+#define FULL_32_BIT_PPGTT 2
+#define FULL_48_BIT_PPGTT 3
+/* uses_full_ppgtt
+ * Finds supported PPGTT details.
+ * @fd DRM fd
+ * @min can be
+ * 0 - No PPGTT
+ * 1 - Aliasing PPGTT
+ * 2 - Full PPGTT (32b)
+ * 3 - Full PPGTT (48b)
+ * RETURNS true/false if min support is present
+*/
+static bool uses_full_ppgtt(int fd, int min)
+{
+	struct drm_i915_getparam gp;
+	int val = 0;
+
+	memset(&gp, 0, sizeof(gp));
+	gp.param = 18; /* HAS_ALIASING_PPGTT */
+	gp.value = &val;
+
+	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
+		return 0;
+
+	errno = 0;
+	return val >= min;
+}
+
+/* has_softpin_support
+ * Finds if softpin feature is supported
+ * @fd DRM fd
+*/
+static bool has_softpin_support(int fd)
+{
+	struct drm_i915_getparam gp;
+	int val = 0;
+
+	memset(&gp, 0, sizeof(gp));
+	gp.param = 37; /* I915_PARAM_HAS_EXEC_SOFTPIN */
+	gp.value = &val;
+
+	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
+		return 0;
+
+	errno = 0;
+	return (val == 1);
+}
+
+/* gem_call_userptr_ioctl
+ * Helper to call ioctl - TODO: move to lib
+ * @fd - drm fd
+ * @userptr - pointer to initialised userptr
+ * RETURNS status of ioctl call
+*/
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr)
+{
+	int ret;
+
+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
+
+	if (ret)
+		ret = errno;
+
+	return ret;
+}
+
+/* init_userptr
+ * Helper that inits userptr an returns handle
+ * @fd - drm fd
+ * @userptr - pointer to empty userptr
+ * @ptr - buffer to be shared
+ * @size - size of buffer
+ * @ro - read only flag
+ * RETURNS handle to shared buffer
+*/
+static uint32_t init_userptr(int fd, i915_gem_userptr *userptr, void *ptr,
+			     uint64_t size)
+{
+	int ret;
+
+	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
+
+	userptr->user_ptr = (uint64_t)ptr; /* Need the cast to overcome compiler warning */
+	userptr->user_size = size;
+	userptr->flags = 0; /* use synchronized operation */
+
+	ret = gem_call_userptr_ioctl(fd, userptr);
+	igt_assert_eq(ret, 0);
+
+	return userptr->handle;
+}
+
+/* create_mem_buffer
+ * Creates a 4K aligned CPU buffer
+ * @size - size of buffer
+ * RETURNS pointer to buffer of @size
+*/
+static void *create_mem_buffer(uint64_t size)
+{
+	void *addr;
+	int ret;
+
+	ret = posix_memalign(&addr, 4096, size);
+	igt_assert(ret == 0);
+
+	return addr;
+}
+
+/* setup_exec_obj
+ * populate exec object
+ * @exec - exec object
+ * @handle - handle to gem buffer
+ * @flags - any flags
+ * @offset - requested VMA
+*/
+static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec,
+			   uint32_t handle, uint32_t flags,
+			   uint64_t offset)
+{
+	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
+	exec->handle = handle;
+	exec->flags = flags;
+	exec->offset = offset;
+}
+
+/* gem_store_data_svm
+ * populate batch buffer with MI_STORE_DWORD_IMM command
+ * @fd: drm file descriptor
+ * @cmd_buf: batch buffer
+ * @vaddr: destination Virtual address
+ * @data: data to be store at destination
+ * @end: whether to end batch buffer or not
+*/
+static int gem_store_data_svm(int fd, uint32_t *cmd_buf, uint64_t vaddr,
+			      uint32_t data, bool end)
+{
+	int i = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
+	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
+
+	cmd_buf[i++] = data;
+	if (end) {
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	return(i * sizeof(uint32_t));
+}
+
+/* gem_store_data
+ * populate batch buffer with MI_STORE_DWORD_IMM command
+ * This one fills up reloc buffer as well
+ * @fd: drm file descriptor
+ * @cmd_buf: batch buffer
+ * @data: data to be store at destination
+ * @reloc - relocation entry
+ * @end: whether to end batch buffer or not
+*/
+static int gem_store_data(int fd, uint32_t *cmd_buf,
+			  uint32_t handle, uint32_t data,
+			  struct drm_i915_gem_relocation_entry *reloc,
+			  bool end)
+{
+	int i = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 reloc needed */
+	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 reloc needed */
+	reloc->offset = 1 * sizeof(uint32_t);
+	reloc->delta = 0;
+	reloc->target_handle = handle;
+	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
+	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
+	reloc->presumed_offset = 0;
+	cmd_buf[i++] = data;
+	if (end) {
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	return (i * sizeof(uint32_t));
+}
+
+/* setup_execbuffer
+ * helper for buffer execution
+ * @execbuf - pointer to execbuffer
+ * @exec_object - pointer to exec object2 struct
+ * @ring - ring to be used
+ * @buffer_count - how manu buffers to submit
+ * @batch_length - length of batch buffer
+*/
+static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf,
+			     struct drm_i915_gem_exec_object2 *exec_object,
+			     int ring, int buffer_count, int batch_length)
+{
+	execbuf->buffers_ptr = (uint64_t)exec_object;
+	execbuf->buffer_count = buffer_count;
+	execbuf->batch_start_offset = 0;
+	execbuf->batch_len = batch_length;
+	execbuf->cliprects_ptr = 0;
+	execbuf->num_cliprects = 0;
+	execbuf->DR1 = 0;
+	execbuf->DR4 = 0;
+	execbuf->flags = ring;
+	i915_execbuffer2_set_context_id(*execbuf, 0);
+	execbuf->rsvd2 = 0;
+}
+
+/* submit_and_sync
+ * Helper function for exec and sync functions
+ * @fd - drm fd
+ * @execbuf - pointer to execbuffer
+ * @batch_buf_handle - batch buffer handle
+*/
+static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf,
+			    uint32_t batch_buf_handle)
+{
+	gem_execbuf(fd, execbuf);
+	gem_sync(fd, batch_buf_handle);
+}
+
+/* gem_userptr_sync
+ * helper for syncing to CPU domain - copy/paste from userblit
+ * @fd - drm fd
+ * @handle - buffer handle to sync
+*/
+static void gem_userptr_sync(int fd, uint32_t handle)
+{
+	gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
+}
+
+
+/* gem_pin_userptr_test
+ * This test will create a shared buffer, and create a command
+ * for GPU to write data in it
+ * CPU will read and make sure expected value is obtained
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+static void gem_pin_userptr_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	/* Check if driver pinned the buffer as requested */
+	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
+			"\nFailed to pin at requested offset");
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		      "\nCPU read does not match GPU write,\
+			expected: 0x%x, got: 0x%x\n",
+			data, shared_buffer[0]);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/* gem_pin_bo
+ * This test will test softpinning of a gem buffer object
+ * Malloc a 4K buffer
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000
+ * Submit execbuffer
+ * Verify value pinned offset matches the request
+*/
+static void gem_pin_bo_test(void)
+{
+	int fd;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, unshared_buf_handle;
+	struct drm_i915_gem_relocation_entry reloc[4];
+	int ring, len;
+	uint32_t value;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create gem buffer */
+	unshared_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data(fd, batch_buffer, unshared_buf_handle, data,
+				reloc, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], unshared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+	exec_object2[1].relocation_count = 1;
+	exec_object2[1].relocs_ptr = (uint64_t)reloc;
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	/* Check if driver pinned the buffer as requested */
+	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
+			"\nFailed to pin at requested offset");
+	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
+	igt_assert(value == data);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, unshared_buf_handle);
+	close(fd);
+}
+
+
+/* gem_multiple_process_test
+ * Run basic test simultaneously with multiple processes
+ * This will test pinning same VA separately in each process
+
+ * fork();
+ * Execute basic test in parent/child processes
+*/
+#define MAX_NUM_PROCESSES 10
+
+static void gem_multiple_process_test(void)
+{
+	int fd;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	igt_fork(child, MAX_NUM_PROCESSES) {
+		gem_pin_userptr_test();
+	}
+	igt_waitchildren();
+
+	close(fd);
+}
+
+
+/* gem_repin_test
+ * This test tries to repin a buffer at a previously pinned vma
+ * from a different execbuf.
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000 VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+
+ * Create second shared buffer
+ * Follow all steps above
+ * Execpt, for offset, use VMA of first buffer above
+ * Submit execbuffer
+ * Verify value of first DWORD in second shared buffer matches DATA
+*/
+static void gem_repin_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd;
+	uint32_t *shared_buffer;
+	uint32_t *shared_buffer1;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	/* Create gem object */
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set first elements to 0x0 */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE);
+	shared_buffer[0] = 0x0;
+	shared_buffer1[0] = 0x0;
+
+	/* share with GPU and get handles */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
+					  BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	igt_assert(*shared_buffer == data);
+
+	/* Second buffer */
+	/* create command buffer with write command */
+	pinning_offset = exec_object2[0].offset;
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	/* Pin at shared_buffer, not shared_buffer1 */
+	/* We are requesting address where another buffer was pinned previously */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle1,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle1);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	igt_assert(*shared_buffer1 == data);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+
+/* gem_repin_overlap_test
+ * This test will attempt to pin two buffers at the same VMA as part of the same
+   execbuffer object
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create second shared buffer
+ * Create batch buffer to write DATA to first dword of each buffer
+ * Use same virtual address as destination addresses in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in both exec objects
+ * Set 'offset' in both exec objects to same VMA
+ * Submit execbuffer
+ * Command should return EINVAL, since we are trying to pin to same VMA
+*/
+static void gem_pin_overlap_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd, ret;
+	uint32_t *shared_buffer;
+	uint32_t *shared_buffer1;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[3];
+	uint32_t shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
+					  BO_SIZE * 2);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], shared_buf_handle1,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+
+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, &execbuf);
+
+	/* expect to fail */
+	igt_assert_neq(ret, 0);
+	igt_assert(errno == EINVAL);
+
+	close(fd);
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+/* gem_softpin_stress_test
+ * Stress test which creates 10K buffers and shares with GPU
+ * Create 100K uint32 buffers of size 4K each
+ * Share with GPU using userptr ioctl
+ * Create batch buffer to write DATA in first element of each buffer
+ * Pin each buffer to varying addresses starting from 0x800000000000 going below
+ * Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
+ * Validate every buffer has DATA in first element
+ * Rinse and Repeat on Render ring
+*/
+#define STRESS_NUM_BUFFERS 100000
+#define STRESS_NUM_LOOPS 100
+#define STRESS_STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
+
+static void gem_softpin_stress_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t **shared_buffer;
+	uint32_t *shared_handle;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 *exec_object2;
+	uint32_t *batch_buffer;
+	uint32_t batch_buf_handle;
+	int ring, len;
+	int buf, loop;
+	uint64_t pinning_offset = 0x800000000000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+
+	/* Allocate blobs for all data structures */
+	shared_handle = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t));
+	shared_buffer = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t *));
+	exec_object2 = calloc(STRESS_NUM_BUFFERS + 1,
+				sizeof(struct drm_i915_gem_exec_object2));
+	/* 4 dwords per buffer + 2 for the end of batchbuffer */
+	batch_buffer = calloc(STRESS_STORE_COMMANDS + 2, sizeof(uint32_t));
+	batch_buf_handle = gem_create(fd, (STRESS_STORE_COMMANDS + 2)*4);
+
+	/* create command buffer with write commands */
+	len = 0;
+	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+		shared_buffer[buf] = create_mem_buffer(BO_SIZE);
+		*shared_buffer[buf] = 0xFFFFFFFF;
+
+		/* share with GPU */
+		shared_handle[buf] = init_userptr(fd, &userptr,
+						  shared_buffer[buf],
+						  BO_SIZE);
+
+		setup_exec_obj(&exec_object2[buf], shared_handle[buf],
+			       EXEC_OBJECT_PINNED, pinning_offset);
+		len += gem_store_data_svm(fd, batch_buffer + (len/4),
+					  pinning_offset, buf,
+					  (buf == STRESS_NUM_BUFFERS-1)? \
+					  true:false);
+
+		/* decremental 4K aligned address */
+		pinning_offset -= ALIGN(BO_SIZE, 4096);
+	}
+
+	/* setup command buffer */
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle,
+		       0, 0);
+
+	/* We want to run this on BLT ring if possible */
+	if (HAS_BLT_RING(intel_get_drm_devid(fd))) {
+		ring = I915_EXEC_BLT;
+
+		setup_execbuffer(&execbuf, exec_object2, ring,
+				 STRESS_NUM_BUFFERS + 1, len);
+
+		for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
+			submit_and_sync(fd, &execbuf, batch_buf_handle);
+			/* Set pinning offset back to original value */
+			pinning_offset = 0x800000000000;
+			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+				gem_userptr_sync(fd, shared_handle[buf]);
+				igt_assert(exec_object2[buf].offset == pinning_offset);
+				igt_fail_on_f(*shared_buffer[buf] != buf, \
+				"Mismatch in buffer %d, iteration %d: 0x%08X\n", \
+				buf, loop, *shared_buffer[buf]);
+				pinning_offset -= ALIGN(BO_SIZE, 4096);
+			}
+			/* Reset the buffer entries for next iteration */
+			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+				*shared_buffer[buf] = 0xFFFFFFFF;
+			}
+		}
+	}
+
+	/* Now Render Ring */
+	ring = I915_EXEC_RENDER;
+	setup_execbuffer(&execbuf, exec_object2, ring,
+			 STRESS_NUM_BUFFERS + 1, len);
+	for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		pinning_offset = 0x800000000000;
+		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+			gem_userptr_sync(fd, shared_handle[buf]);
+			igt_assert(exec_object2[buf].offset == pinning_offset);
+			igt_fail_on_f(*shared_buffer[buf] != buf, \
+			"Mismatch in buffer %d, \
+			iteration %d: 0x%08X\n", buf, loop, *shared_buffer[buf]);
+			pinning_offset -= ALIGN(BO_SIZE, 4096);
+		}
+		/* Reset the buffer entries for next iteration */
+		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+			*shared_buffer[buf] = 0xFFFFFFFF;
+		}
+	}
+
+	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+		gem_close(fd, shared_handle[buf]);
+		free(shared_buffer[buf]);
+	}
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_handle);
+	free(shared_buffer);
+	free(exec_object2);
+	free(batch_buffer);
+}
+
+/* gem_write_multipage_buffer
+ * Create a buffer spanning multiple pages, and share with GPU.
+ * Write to every element of the buffer
+ * and verify correct contents.
+
+ * Create 8K buffer
+ * Share with GPU using userptr ioctl
+ * Create batch buffer to write DATA in all elements of buffer
+ * Execute Batch Buffer
+ * Validate every element has DATA
+*/
+
+#define DWORD_SIZE sizeof(uint32_t)
+#define BB_SIZE ((MULTIPAGE_BO_SIZE / DWORD_SIZE) * STORE_BATCH_BUFFER_SIZE) + 2
+#define NUM_DWORDS (MULTIPAGE_BO_SIZE/sizeof(uint32_t))
+static void gem_write_multipage_buffer_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	uint32_t shared_handle;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[BB_SIZE];
+	uint32_t batch_buf_handle;
+	int ring, len, j;
+	uint64_t pinning_offset=0x1000;
+	uint64_t vaddr;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
+	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
+
+	len = 0;
+	memset(batch_buffer, 0, sizeof(batch_buffer));
+	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
+
+	/* share with GPU */
+	shared_handle = init_userptr(fd, &userptr, shared_buffer,
+				     MULTIPAGE_BO_SIZE);
+	setup_exec_obj(&exec_object2[0], shared_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+
+	/* create command buffer with write commands */
+	vaddr = pinning_offset;
+	for(j=0; j< NUM_DWORDS; j++) {
+		len += gem_store_data_svm(fd, batch_buffer + (len/4), vaddr,
+					  j,
+					  (j == NUM_DWORDS - 1) ? true:false);
+		vaddr += sizeof(shared_buffer[0]);  /* 4 bytes */
+	}
+
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_handle);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	for(j = 0; j < (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++) {
+		igt_fail_on_f(shared_buffer[j] != j,
+		"Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_handle);
+	close(fd);
+
+	free(shared_buffer);
+}
+
+/* gem_pin_invalid_vma_test
+ * This test will request to pin a shared buffer to an invalid
+ * VMA  > 48-bit address if system supports 48B PPGTT
+ * If system supports 32B PPGTT, it will test the equivalent invalid VMA
+ * Create shared buffer of size 4K
+ * Try and Pin object to invalid address
+*/
+static void gem_pin_invalid_vma_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[1];
+	uint32_t shared_buf_handle;
+	int ring;
+	uint64_t invalid_address_for_48b = 0x9000000000000; /* 52 bit address */
+	uint64_t invalid_address_for_32b = 0x900000000; /* 36 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT) ||
+		    uses_full_ppgtt(fd, FULL_32_BIT_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+
+	if (uses_full_ppgtt(fd, FULL_48_BIT_PPGTT)) {
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED, invalid_address_for_48b);
+	} else {
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED, invalid_address_for_32b);
+	}
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 1, 0);
+
+	/* Expect execbuf to fail */
+	ret = drmIoctl(fd,
+		       DRM_IOCTL_I915_GEM_EXECBUFFER2,
+		       &execbuf);
+
+	igt_assert(errno == ENOSPC);
+	igt_assert_neq(ret, 0);
+
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+
+/* gem_pin_high_address_test
+ * This test will create a shared buffer, and create a command
+ * for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
+ * CPU will read and make sure expected value is obtained
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use virtual address of buffer as 0x1100000000 (> 32 bit)
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to shared buffer VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+ * Now try same test without using 48BIT flag
+ * test should pass with requested pinning address
+*/
+
+static void gem_pin_high_address_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	igt_assert(exec_object2[0].offset == high_address);
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, \
+		expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
+
+	/* Now try pinning to high address without 48BIT flag */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, high_address);
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	igt_assert(exec_object2[0].offset == high_address);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/* gem_pin_near_48Bit_test
+ * This test will create a shared buffer,
+ * and create a command for GPU to write data in it. It will attempt
+ * to pin the buffer at address > 47 bits <= 48-bit.
+ * CPU will read and make sure expected value is obtained
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use virtual address of buffer as range between 47-bit and 48-bit
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to shared buffer VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000
+#define END_HIGH_ADDRESS 0xFFFFFFFFC000
+#define ADDRESS_INCREMENT 0x2000000000
+static void gem_pin_near_48Bit_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+
+	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS;
+						high_address+=ADDRESS_INCREMENT) {
+		/* create command buffer with write command */
+		len = gem_store_data_svm(fd, batch_buffer, high_address,
+					data, true);
+		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+		/* submit command buffer */
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
+			       high_address);
+		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+		ring = I915_EXEC_RENDER;
+		setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		gem_userptr_sync(fd, shared_buf_handle);
+
+		igt_assert(exec_object2[0].offset == high_address);
+		/* check on CPU to see if value changes */
+		igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, expected: 0x%x, \
+		got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+
+int main(int argc, char* argv[])
+{
+	igt_subtest_init(argc, argv);
+	igt_skip_on_simulation();
+
+	/* All tests need PPGTT support */
+	igt_subtest("gem_pin_userptr") {
+		gem_pin_userptr_test();
+	}
+	igt_subtest("gem_pin_bo") {
+		gem_pin_bo_test();
+	}
+	igt_subtest("gem_multiple_process") {
+		gem_multiple_process_test();
+	}
+	igt_subtest("gem_repin") {
+		gem_repin_test();
+	}
+	igt_subtest("gem_pin_overlap") {
+		gem_pin_overlap_test();
+	}
+	igt_subtest("gem_write_multipage_buffer") {
+		gem_write_multipage_buffer_test();
+	}
+
+	/* Following tests need 32/48 Bit PPGTT support */
+	igt_subtest("gem_pin_invalid_vma") {
+		gem_pin_invalid_vma_test();
+	}
+
+	/* Following tests need 48 Bit PPGTT support */
+	igt_subtest("gem_softpin_stress") {
+		gem_softpin_stress_test();
+	}
+	igt_subtest("gem_pin_high_address") {
+		gem_pin_high_address_test();
+	}
+	igt_subtest("gem_pin_near_48Bit") {
+		gem_pin_near_48Bit_test();
+	}
+
+	igt_exit();
+}
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
@ 2015-12-02 12:24 Vinay Belgaumkar
  2015-12-03 11:42 ` Tvrtko Ursulin
  0 siblings, 1 reply; 19+ messages in thread
From: Vinay Belgaumkar @ 2015-12-02 12:24 UTC (permalink / raw)
  To: intel-gfx; +Cc: Vinay Belgaumkar

These tests exercise the userptr ioctl to create shared buffers
between CPU and GPU. They contain error and normal usage scenarios.
They also contain a couple of stress tests which copy buffers between
CPU and GPU. These tests rely on the softpin patch in order to pin buffers
to a certain VA.

Caveat: These tests were designed to run on 64-bit system. Future work
includes adding logic to ensure these tests can run on 32-bit systems with
PPGTT support. Some tests are currently disabled for 32-bit systems for that
reason.

v2: Added cc and signed-off-by fields

v3: Fixed review comments, added helper functions. Removed userptr error
scenarios covered by existing userptr tests. Modified stress test to have
100K buffers, it now runs for ~30 mins, checks every element has been written
to correctly, and pins buffers at different VMAs.

v4: Changed name to gem_softpin

v5: More fixes. Removed the file based tests, will move them to userptr tests.
Added a function that validates appropriate PPGTT support before running tests.
Optimized stack space and memory footprint in stress test. Removed the eviction
test, will add it back after verifying proper functionality.

v6: Split basic test into userptr and bo
Fixed some coding style issues.

v7: Enhanced invalid vma pinning test to verify 32-bit PPGTT functionality.
Enabled the test for 32-bit PPGTT systems, and verify pinning fails above
32-bit addresses. Enhanced the high adress pinning test to ensure pinning
fails when EXEC_OBJECT_PINNED flag is not used. Some more cosmetic fixes to
close buffer handles. Changed userptr function to used synchronized operations.

v8: Minor change to high address pinning test as per comment.

v9: Skip the tests if softpin support is not present.

Cc: Michel Thierry <michel.thierry@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
 tests/.gitignore       |    1 +
 tests/Makefile.sources |    1 +
 tests/gem_softpin.c    | 1086 ++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 1088 insertions(+)
 create mode 100644 tests/gem_softpin.c

diff --git a/tests/.gitignore b/tests/.gitignore
index 80af9a7..424870b 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -21,6 +21,7 @@ gem_bad_blit
 gem_bad_length
 gem_bad_reloc
 gem_basic
+gem_softpin
 gem_caching
 gem_close_race
 gem_concurrent_all
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 8fb2de8..2008d4a 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -11,6 +11,7 @@ TESTS_progs_M = \
 	drv_hangman \
 	gem_bad_reloc \
 	gem_basic \
+	gem_softpin \
 	gem_caching \
 	gem_close_race \
 	gem_concurrent_blit \
diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
new file mode 100644
index 0000000..fac83a1
--- /dev/null
+++ b/tests/gem_softpin.c
@@ -0,0 +1,1086 @@
+/*
+ * Copyright © 2015 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ * Authors:
+ *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
+ *    Thomas Daniel <thomas.daniel@intel.com>
+ *
+ */
+
+#include <unistd.h>
+#include <stdlib.h>
+#include <stdint.h>
+#include <stdio.h>
+#include <string.h>
+#include <fcntl.h>
+#include <inttypes.h>
+#include <errno.h>
+#include <sys/stat.h>
+#include <sys/ioctl.h>
+#include <sys/time.h>
+#include <malloc.h>
+#include "drm.h"
+#include "ioctl_wrappers.h"
+#include "drmtest.h"
+#include "intel_chipset.h"
+#include "intel_io.h"
+#include "i915_drm.h"
+#include <assert.h>
+#include <sys/wait.h>
+#include <sys/ipc.h>
+#include <sys/shm.h>
+#include "igt_kms.h"
+#include <inttypes.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+
+#define BO_SIZE 4096
+#define MULTIPAGE_BO_SIZE 2 * BO_SIZE
+#define STORE_BATCH_BUFFER_SIZE 4
+#define EXEC_OBJECT_PINNED	(1<<4)
+#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
+#define SHARED_BUFFER_SIZE 4096
+
+typedef struct drm_i915_gem_userptr i915_gem_userptr;
+
+static uint32_t init_userptr(int fd, i915_gem_userptr *, void *ptr, uint64_t size);
+static void *create_mem_buffer(uint64_t size);
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
+static void gem_pin_userptr_test(void);
+static void gem_pin_bo_test(void);
+static void gem_pin_invalid_vma_test(void);
+static void gem_pin_overlap_test(void);
+static void gem_pin_high_address_test(void);
+
+#define NO_PPGTT 0
+#define ALIASING_PPGTT 1
+#define FULL_32_BIT_PPGTT 2
+#define FULL_48_BIT_PPGTT 3
+/* uses_full_ppgtt
+ * Finds supported PPGTT details. 
+ * @fd DRM fd
+ * @min can be
+ * 0 - No PPGTT
+ * 1 - Aliasing PPGTT
+ * 2 - Full PPGTT (32b)
+ * 3 - Full PPGTT (48b)
+ * RETURNS true/false if min support is present
+*/
+static bool uses_full_ppgtt(int fd, int min)
+{
+	struct drm_i915_getparam gp;
+	int val = 0;
+
+	memset(&gp, 0, sizeof(gp));
+	gp.param = 18; /* HAS_ALIASING_PPGTT */
+	gp.value = &val;
+
+	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
+		return 0;
+
+	errno = 0;
+	return val >= min;
+}
+
+/* has_softpin_support
+ * Finds if softpin feature is supported
+ * @fd DRM fd
+*/
+static bool has_softpin_support(int fd)
+{
+	struct drm_i915_getparam gp;
+	int val = 0;
+
+	memset(&gp, 0, sizeof(gp));
+	gp.param = 37; /* I915_PARAM_HAS_EXEC_SOFTPIN */
+	gp.value = &val;
+
+	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
+		return 0;
+
+	errno = 0;
+	return (val == 1);
+}
+
+/* gem_call_userptr_ioctl
+ * Helper to call ioctl - TODO: move to lib
+ * @fd - drm fd
+ * @userptr - pointer to initialised userptr
+ * RETURNS status of ioctl call
+*/
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr)
+{
+	int ret;
+
+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
+
+	if (ret)
+		ret = errno;
+
+	return ret;
+}
+
+/* init_userptr
+ * Helper that inits userptr an returns handle
+ * @fd - drm fd
+ * @userptr - pointer to empty userptr
+ * @ptr - buffer to be shared
+ * @size - size of buffer
+ * @ro - read only flag
+ * RETURNS handle to shared buffer
+*/
+static uint32_t init_userptr(int fd, i915_gem_userptr *userptr, void *ptr,
+			     uint64_t size)
+{
+	int ret;
+
+	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
+
+	userptr->user_ptr = (uint64_t)ptr; /* Need the cast to overcome compiler warning */
+	userptr->user_size = size;
+	userptr->flags = 0; /* use synchronized operation */
+
+	ret = gem_call_userptr_ioctl(fd, userptr);
+	igt_assert_eq(ret, 0);
+
+	return userptr->handle;
+}
+
+/* create_mem_buffer 
+ * Creates a 4K aligned CPU buffer 
+ * @size - size of buffer
+ * RETURNS pointer to buffer of @size
+*/
+static void *create_mem_buffer(uint64_t size)
+{
+	void *addr;
+	int ret;
+
+	ret = posix_memalign(&addr, 4096, size);
+	igt_assert(ret == 0);
+
+	return addr;
+}
+
+/* setup_exec_obj 
+ * populate exec object
+ * @exec - exec object
+ * @handle - handle to gem buffer
+ * @flags - any flags
+ * @offset - requested VMA
+*/
+static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec,
+			   uint32_t handle, uint32_t flags,
+			   uint64_t offset)
+{
+	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
+	exec->handle = handle;
+	exec->flags = flags;
+	exec->offset = offset;
+}
+
+/* gem_store_data_svm 
+ * populate batch buffer with MI_STORE_DWORD_IMM command
+ * @fd: drm file descriptor
+ * @cmd_buf: batch buffer
+ * @vaddr: destination Virtual address
+ * @data: data to be store at destination
+ * @end: whether to end batch buffer or not
+*/
+static int gem_store_data_svm(int fd, uint32_t *cmd_buf, uint64_t vaddr,
+			      uint32_t data, bool end)
+{
+	int i = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
+	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
+
+	cmd_buf[i++] = data;
+	if (end) { 
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	return(i * sizeof(uint32_t));
+}
+
+/* gem_store_data 
+ * populate batch buffer with MI_STORE_DWORD_IMM command
+ * This one fills up reloc buffer as well 
+ * @fd: drm file descriptor
+ * @cmd_buf: batch buffer
+ * @data: data to be store at destination
+ * @reloc - relocation entry
+ * @end: whether to end batch buffer or not
+*/
+static int gem_store_data(int fd, uint32_t *cmd_buf,
+			  uint32_t handle, uint32_t data,
+			  struct drm_i915_gem_relocation_entry *reloc,
+			  bool end)
+{
+	int i = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 reloc needed */
+	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 reloc needed */
+	reloc->offset = 1 * sizeof(uint32_t);
+	reloc->delta = 0;
+	reloc->target_handle = handle;
+	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
+	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
+	reloc->presumed_offset = 0;
+	cmd_buf[i++] = data;
+	if (end) { 
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	return (i * sizeof(uint32_t));
+}
+
+/* setup_execbuffer 
+ * helper for buffer execution
+ * @execbuf - pointer to execbuffer
+ * @exec_object - pointer to exec object2 struct
+ * @ring - ring to be used
+ * @buffer_count - how manu buffers to submit
+ * @batch_length - length of batch buffer 
+*/
+static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf,
+			     struct drm_i915_gem_exec_object2 *exec_object,
+			     int ring, int buffer_count, int batch_length)
+{
+	execbuf->buffers_ptr = (uint64_t)exec_object;
+	execbuf->buffer_count = buffer_count;
+	execbuf->batch_start_offset = 0;
+	execbuf->batch_len = batch_length;
+	execbuf->cliprects_ptr = 0;
+	execbuf->num_cliprects = 0;
+	execbuf->DR1 = 0;
+	execbuf->DR4 = 0;
+	execbuf->flags = ring;
+	i915_execbuffer2_set_context_id(*execbuf, 0);
+	execbuf->rsvd2 = 0;
+}
+
+/* submit_and_sync 
+ * Helper function for exec and sync functions 
+ * @fd - drm fd
+ * @execbuf - pointer to execbuffer
+ * @batch_buf_handle - batch buffer handle
+*/
+static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf,
+			    uint32_t batch_buf_handle)
+{
+	gem_execbuf(fd, execbuf);
+	gem_sync(fd, batch_buf_handle); 
+}
+
+/* gem_userptr_sync
+ * helper for syncing to CPU domain - copy/paste from userblit
+ * @fd - drm fd
+ * @handle - buffer handle to sync
+*/
+static void gem_userptr_sync(int fd, uint32_t handle)
+{
+	gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
+}
+
+
+/* gem_pin_userptr_test 
+ * This test will create a shared buffer, and create a command
+ * for GPU to write data in it
+ * CPU will read and make sure expected value is obtained
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+static void gem_pin_userptr_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	/* Check if driver pinned the buffer as requested */
+	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
+			"\nFailed to pin at requested offset");
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		      "\nCPU read does not match GPU write,\
+			expected: 0x%x, got: 0x%x\n", 
+			data, shared_buffer[0]);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/* gem_pin_bo 
+ * This test will test softpinning of a gem buffer object
+ * Malloc a 4K buffer
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000
+ * Submit execbuffer
+ * Verify value pinned offset matches the request
+*/
+static void gem_pin_bo_test(void)
+{
+	int fd;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, unshared_buf_handle;
+	struct drm_i915_gem_relocation_entry reloc[4];
+	int ring, len;
+	uint32_t value;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create gem buffer */
+	unshared_buf_handle = gem_create(fd, BO_SIZE);
+	
+	/* create command buffer with write command */
+	len = gem_store_data(fd, batch_buffer, unshared_buf_handle, data,
+				reloc, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], unshared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+	exec_object2[1].relocation_count = 1;
+	exec_object2[1].relocs_ptr = (uint64_t)reloc;
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	/* Check if driver pinned the buffer as requested */
+	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
+			"\nFailed to pin at requested offset");
+	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
+	igt_assert(value == data);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, unshared_buf_handle);
+	close(fd);
+}
+
+
+/* gem_multiple_process_test 
+ * Run basic test simultaneously with multiple processes
+ * This will test pinning same VA separately in each process
+
+ * fork();
+ * Execute basic test in parent/child processes
+*/
+#define MAX_NUM_PROCESSES 10
+
+static void gem_multiple_process_test(void)
+{
+	int fd;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	igt_fork(child, MAX_NUM_PROCESSES) {
+		gem_pin_userptr_test();
+	}
+	igt_waitchildren();
+
+	close(fd);
+}
+
+
+/* gem_repin_test 
+ * This test tries to repin a buffer at a previously pinned vma 
+ * from a different execbuf. 
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000 VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+
+ * Create second shared buffer
+ * Follow all steps above
+ * Execpt, for offset, use VMA of first buffer above 
+ * Submit execbuffer
+ * Verify value of first DWORD in second shared buffer matches DATA
+*/
+static void gem_repin_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd;
+	uint32_t *shared_buffer;
+	uint32_t *shared_buffer1;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	/* Create gem object */
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set first elements to 0x0 */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE);
+	shared_buffer[0] = 0x0;
+	shared_buffer1[0] = 0x0;
+
+	/* share with GPU and get handles */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
+					  BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	igt_assert(*shared_buffer == data);
+
+	/* Second buffer */
+	/* create command buffer with write command */
+	pinning_offset = exec_object2[0].offset;
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	/* Pin at shared_buffer, not shared_buffer1 */
+	/* We are requesting address where another buffer was pinned previously */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle1,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle1);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	igt_assert(*shared_buffer1 == data);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+
+/* gem_repin_overlap_test
+ * This test will attempt to pin two buffers at the same VMA as part of the same
+   execbuffer object
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create second shared buffer
+ * Create batch buffer to write DATA to first dword of each buffer
+ * Use same virtual address as destination addresses in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in both exec objects
+ * Set 'offset' in both exec objects to same VMA
+ * Submit execbuffer
+ * Command should return EINVAL, since we are trying to pin to same VMA
+*/
+static void gem_pin_overlap_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd, ret;
+	uint32_t *shared_buffer;
+	uint32_t *shared_buffer1;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[3];
+	uint32_t shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
+					  BO_SIZE * 2);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], shared_buf_handle1,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+
+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, &execbuf);
+
+	/* expect to fail */
+	igt_assert_neq(ret, 0);
+	igt_assert(errno == EINVAL);
+
+	close(fd);
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+/* gem_softpin_stress_test 
+ * Stress test which creates 10K buffers and shares with GPU 
+ * Create 100K uint32 buffers of size 4K each
+ * Share with GPU using userptr ioctl
+ * Create batch buffer to write DATA in first element of each buffer
+ * Pin each buffer to varying addresses starting from 0x800000000000 going below
+ * Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
+ * Validate every buffer has DATA in first element
+ * Rinse and Repeat on Render ring
+*/
+#define STRESS_NUM_BUFFERS 100000
+#define STRESS_NUM_LOOPS 100
+#define STRESS_STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
+
+static void gem_softpin_stress_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t **shared_buffer;
+	uint32_t *shared_handle;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 *exec_object2;
+	uint32_t *batch_buffer; 
+	uint32_t batch_buf_handle;
+	int ring, len;
+	int buf, loop;
+	uint64_t pinning_offset = 0x800000000000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+
+	/* Allocate blobs for all data structures */
+	shared_handle = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t));
+	shared_buffer = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t *));
+	exec_object2 = calloc(STRESS_NUM_BUFFERS + 1, 
+				sizeof(struct drm_i915_gem_exec_object2));
+	/* 4 dwords per buffer + 2 for the end of batchbuffer */
+	batch_buffer = calloc(STRESS_STORE_COMMANDS + 2, sizeof(uint32_t));
+	batch_buf_handle = gem_create(fd, (STRESS_STORE_COMMANDS + 2)*4);
+
+	/* create command buffer with write commands */
+	len = 0;
+	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+		shared_buffer[buf] = create_mem_buffer(BO_SIZE);
+		*shared_buffer[buf] = 0xFFFFFFFF;
+
+		/* share with GPU */
+		shared_handle[buf] = init_userptr(fd, &userptr,
+						  shared_buffer[buf],
+						  BO_SIZE);
+
+		setup_exec_obj(&exec_object2[buf], shared_handle[buf],
+			       EXEC_OBJECT_PINNED, pinning_offset);
+		len += gem_store_data_svm(fd, batch_buffer + (len/4),
+					  pinning_offset, buf,
+					  (buf == STRESS_NUM_BUFFERS-1)? \
+					  true:false);
+		
+		/* decremental 4K aligned address */
+		pinning_offset -= ALIGN(BO_SIZE, 4096);
+	}
+
+	/* setup command buffer */
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle,
+		       0, 0);
+
+	/* We want to run this on BLT ring if possible */
+	if (HAS_BLT_RING(intel_get_drm_devid(fd))) {
+		ring = I915_EXEC_BLT;
+
+		setup_execbuffer(&execbuf, exec_object2, ring,
+				 STRESS_NUM_BUFFERS + 1, len);
+
+		for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
+			submit_and_sync(fd, &execbuf, batch_buf_handle);
+			/* Set pinning offset back to original value */
+			pinning_offset = 0x800000000000;
+			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+				gem_userptr_sync(fd, shared_handle[buf]);
+				igt_assert(exec_object2[buf].offset == pinning_offset);
+				igt_fail_on_f(*shared_buffer[buf] != buf, \
+				"Mismatch in buffer %d, iteration %d: 0x%08X\n", \
+				buf, loop, *shared_buffer[buf]);
+				pinning_offset -= ALIGN(BO_SIZE, 4096);
+			}
+			/* Reset the buffer entries for next iteration */
+			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+				*shared_buffer[buf] = 0xFFFFFFFF;
+			}
+		}
+	}
+
+	/* Now Render Ring */
+	ring = I915_EXEC_RENDER;
+	setup_execbuffer(&execbuf, exec_object2, ring,
+			 STRESS_NUM_BUFFERS + 1, len);
+	for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		pinning_offset = 0x800000000000;
+		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+			gem_userptr_sync(fd, shared_handle[buf]);
+			igt_assert(exec_object2[buf].offset == pinning_offset);
+			igt_fail_on_f(*shared_buffer[buf] != buf, \
+			"Mismatch in buffer %d, \
+			iteration %d: 0x%08X\n", buf, loop, *shared_buffer[buf]);
+			pinning_offset -= ALIGN(BO_SIZE, 4096);
+		}
+		/* Reset the buffer entries for next iteration */
+		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+			*shared_buffer[buf] = 0xFFFFFFFF;
+		}
+	}
+
+	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+		gem_close(fd, shared_handle[buf]);
+		free(shared_buffer[buf]);
+	}
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_handle);
+	free(shared_buffer);
+	free(exec_object2);
+	free(batch_buffer);
+}
+
+/* gem_write_multipage_buffer 
+ * Create a buffer spanning multiple pages, and share with GPU. 
+ * Write to every element of the buffer
+ * and verify correct contents.
+
+ * Create 8K buffer
+ * Share with GPU using userptr ioctl
+ * Create batch buffer to write DATA in all elements of buffer
+ * Execute Batch Buffer
+ * Validate every element has DATA
+*/
+
+#define DWORD_SIZE sizeof(uint32_t)
+#define BB_SIZE ((MULTIPAGE_BO_SIZE / DWORD_SIZE) * STORE_BATCH_BUFFER_SIZE) + 2
+#define NUM_DWORDS (MULTIPAGE_BO_SIZE/sizeof(uint32_t))
+static void gem_write_multipage_buffer_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	uint32_t shared_handle;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[BB_SIZE];
+	uint32_t batch_buf_handle;
+	int ring, len, j;
+	uint64_t pinning_offset=0x1000;
+	uint64_t vaddr;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
+	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
+
+	len = 0;
+	memset(batch_buffer, 0, sizeof(batch_buffer));
+	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
+
+	/* share with GPU */
+	shared_handle = init_userptr(fd, &userptr, shared_buffer,
+				     MULTIPAGE_BO_SIZE);
+	setup_exec_obj(&exec_object2[0], shared_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+
+	/* create command buffer with write commands */
+	vaddr = pinning_offset;
+	for(j=0; j< NUM_DWORDS; j++) { 
+		len += gem_store_data_svm(fd, batch_buffer + (len/4), vaddr,
+					  j,
+					  (j == NUM_DWORDS - 1) ? true:false);
+		vaddr += sizeof(shared_buffer[0]);  /* 4 bytes */
+	}
+
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_handle);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	for(j = 0; j < (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++) {
+		igt_fail_on_f(shared_buffer[j] != j,
+		"Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_handle);
+	close(fd);
+
+	free(shared_buffer);
+}
+
+/* gem_pin_invalid_vma_test 
+ * This test will request to pin a shared buffer to an invalid
+ * VMA  > 48-bit address if system supports 48B PPGTT
+ * If system supports 32B PPGTT, it will test the equivalent invalid VMA
+ * Create shared buffer of size 4K
+ * Try and Pin object to invalid address
+*/
+static void gem_pin_invalid_vma_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[1];
+	uint32_t shared_buf_handle;
+	int ring;
+	uint64_t invalid_address_for_48b = 0x9000000000000; /* 52 bit address */
+	uint64_t invalid_address_for_32b = 0x900000000; /* 36 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT) ||
+		    uses_full_ppgtt(fd, FULL_32_BIT_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+	
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+
+	if (uses_full_ppgtt(fd, FULL_48_BIT_PPGTT)) {
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED, invalid_address_for_48b);
+	} else {
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED, invalid_address_for_32b);
+	}
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 1, 0);
+
+	/* Expect execbuf to fail */
+	ret = drmIoctl(fd,
+		       DRM_IOCTL_I915_GEM_EXECBUFFER2,
+		       &execbuf);
+
+	igt_assert(errno == ENOSPC);
+	igt_assert_neq(ret, 0);
+	
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+
+/* gem_pin_high_address_test 
+ * This test will create a shared buffer, and create a command
+ * for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
+ * CPU will read and make sure expected value is obtained
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use virtual address of buffer as 0x1100000000 (> 32 bit)
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to shared buffer VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+ * Now try same test without using 48BIT flag
+ * test should pass with requested pinning address
+*/
+
+static void gem_pin_high_address_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+ 
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	igt_assert(exec_object2[0].offset == high_address);
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, \
+		expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
+
+	/* Now try pinning to high address without 48BIT flag */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, high_address);
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	igt_assert(exec_object2[0].offset == high_address);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/* gem_pin_near_48Bit_test 
+ * This test will create a shared buffer, 
+ * and create a command for GPU to write data in it. It will attempt 
+ * to pin the buffer at address > 47 bits <= 48-bit.
+ * CPU will read and make sure expected value is obtained
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use virtual address of buffer as range between 47-bit and 48-bit
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to shared buffer VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000 
+#define END_HIGH_ADDRESS 0xFFFFFFFFC000
+#define ADDRESS_INCREMENT 0x2000000000
+static void gem_pin_near_48Bit_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+	igt_require(has_softpin_support(fd));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+
+	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS;
+						high_address+=ADDRESS_INCREMENT) {
+		/* create command buffer with write command */
+		len = gem_store_data_svm(fd, batch_buffer, high_address,
+					data, true);
+		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+		/* submit command buffer */
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
+			       high_address);
+		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+		ring = I915_EXEC_RENDER;
+		setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		gem_userptr_sync(fd, shared_buf_handle);
+
+		igt_assert(exec_object2[0].offset == high_address);
+		/* check on CPU to see if value changes */
+		igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, expected: 0x%x, \
+		got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+
+int main(int argc, char* argv[])
+{
+	igt_subtest_init(argc, argv);
+	igt_skip_on_simulation();
+
+	/* All tests need PPGTT support */
+	igt_subtest("gem_pin_userptr") {
+		gem_pin_userptr_test();
+	}
+	igt_subtest("gem_pin_bo") {
+		gem_pin_bo_test();
+	}
+	igt_subtest("gem_multiple_process") {
+		gem_multiple_process_test();
+	}
+	igt_subtest("gem_repin") {
+		gem_repin_test();
+	}
+	igt_subtest("gem_pin_overlap") {
+		gem_pin_overlap_test();
+	}
+	igt_subtest("gem_write_multipage_buffer") {
+		gem_write_multipage_buffer_test();
+	}
+
+	/* Following tests need 32/48 Bit PPGTT support */
+	igt_subtest("gem_pin_invalid_vma") {
+		gem_pin_invalid_vma_test();
+	}
+
+	/* Following tests need 48 Bit PPGTT support */
+	igt_subtest("gem_softpin_stress") {
+		gem_softpin_stress_test();
+	}
+	igt_subtest("gem_pin_high_address") {
+		gem_pin_high_address_test();
+	}
+	igt_subtest("gem_pin_near_48Bit") {
+		gem_pin_near_48Bit_test();
+	}
+
+	igt_exit();
+}
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
  2015-12-02 10:24 ` Tvrtko Ursulin
@ 2015-12-02 10:45   ` Tvrtko Ursulin
  0 siblings, 0 replies; 19+ messages in thread
From: Tvrtko Ursulin @ 2015-12-02 10:45 UTC (permalink / raw)
  To: Vinay Belgaumkar, intel-gfx


Hi,

On 02/12/15 10:24, Tvrtko Ursulin wrote:
> On 01/12/15 11:20, Vinay Belgaumkar wrote:
>> These tests exercise the userptr ioctl to create shared buffers
>> between CPU and GPU. They contain error and normal usage scenarios.
>> They also contain a couple of stress tests which copy buffers between
>> CPU and GPU. These tests rely on the softpin patch in order to pin
>> buffers
>> to a certain VA.
>>
>> Caveat: These tests were designed to run on 64-bit system. Future work
>> includes adding logic to ensure these tests can run on 32-bit systems
>> with
>> PPGTT support. Some tests are currently disabled for 32-bit systems
>> for that
>> reason.
>>
>> v2: Added cc and signed-off-by fields
>>
>> v3: Fixed review comments, added helper functions. Removed userptr error
>> scenarios covered by existing userptr tests. Modified stress test to have
>> 100K buffers, it now runs for ~30 mins, checks every element has been
>> written
>> to correctly, and pins buffers at different VMAs.
>>
>> v4: Changed name to gem_softpin
>>
>> v5: More fixes. Removed the file based tests, will move them to
>> userptr tests.
>> Added a function that validates appropriate PPGTT support before
>> running tests.
>> Optimized stack space and memory footprint in stress test. Removed the
>> eviction
>> test, will add it back after verifying proper functionality.
>>
>> v6: Split basic test into userptr and bo
>> Fixed some coding style issues.
>>
>> v7: Enhanced invalid vma pinning test to verify 32-bit PPGTT
>> functionality.
>> Enabled the test for 32-bit PPGTT systems, and verify pinning fails above
>> 32-bit addresses. Enhanced the high adress pinning test to ensure pinning
>> fails when EXEC_OBJECT_PINNED flag is not used. Some more cosmetic
>> fixes to
>> close buffer handles. Changed userptr function to used synchronized
>> operations.
>>
>> v8: Minor change to high address pinning test as per comment.
>>
>> Cc: Michel Thierry <michel.thierry@intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
>> ---
>>   tests/.gitignore       |    1 +
>>   tests/Makefile.sources |    1 +
>>   tests/gem_softpin.c    | 1049
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>   3 files changed, 1051 insertions(+)
>>   create mode 100644 tests/gem_softpin.c
>
> I could find some more style issues but it looks functionally reasonable
> for the basic coverage. So:
>
>    Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Now comes the hard part - following up on the promise to extend with
> more test cases here and elsewhere. :)

I take it back! :)

One thing is, you are not using I915_PARAM_HAS_EXEC_SOFTPIN to 
gracefully skip tests when kernel does not have the softpin feature.

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* Re: [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
  2015-12-01 11:20 Vinay Belgaumkar
@ 2015-12-02 10:24 ` Tvrtko Ursulin
  2015-12-02 10:45   ` Tvrtko Ursulin
  0 siblings, 1 reply; 19+ messages in thread
From: Tvrtko Ursulin @ 2015-12-02 10:24 UTC (permalink / raw)
  To: Vinay Belgaumkar, intel-gfx

On 01/12/15 11:20, Vinay Belgaumkar wrote:
> These tests exercise the userptr ioctl to create shared buffers
> between CPU and GPU. They contain error and normal usage scenarios.
> They also contain a couple of stress tests which copy buffers between
> CPU and GPU. These tests rely on the softpin patch in order to pin buffers
> to a certain VA.
>
> Caveat: These tests were designed to run on 64-bit system. Future work
> includes adding logic to ensure these tests can run on 32-bit systems with
> PPGTT support. Some tests are currently disabled for 32-bit systems for that
> reason.
>
> v2: Added cc and signed-off-by fields
>
> v3: Fixed review comments, added helper functions. Removed userptr error
> scenarios covered by existing userptr tests. Modified stress test to have
> 100K buffers, it now runs for ~30 mins, checks every element has been written
> to correctly, and pins buffers at different VMAs.
>
> v4: Changed name to gem_softpin
>
> v5: More fixes. Removed the file based tests, will move them to userptr tests.
> Added a function that validates appropriate PPGTT support before running tests.
> Optimized stack space and memory footprint in stress test. Removed the eviction
> test, will add it back after verifying proper functionality.
>
> v6: Split basic test into userptr and bo
> Fixed some coding style issues.
>
> v7: Enhanced invalid vma pinning test to verify 32-bit PPGTT functionality.
> Enabled the test for 32-bit PPGTT systems, and verify pinning fails above
> 32-bit addresses. Enhanced the high adress pinning test to ensure pinning
> fails when EXEC_OBJECT_PINNED flag is not used. Some more cosmetic fixes to
> close buffer handles. Changed userptr function to used synchronized operations.
>
> v8: Minor change to high address pinning test as per comment.
>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
>   tests/.gitignore       |    1 +
>   tests/Makefile.sources |    1 +
>   tests/gem_softpin.c    | 1049 ++++++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 1051 insertions(+)
>   create mode 100644 tests/gem_softpin.c

I could find some more style issues but it looks functionally reasonable 
for the basic coverage. So:

   Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Now comes the hard part - following up on the promise to extend with 
more test cases here and elsewhere. :)

Regards,

Tvrtko

> diff --git a/tests/.gitignore b/tests/.gitignore
> index 80af9a7..424870b 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -21,6 +21,7 @@ gem_bad_blit
>   gem_bad_length
>   gem_bad_reloc
>   gem_basic
> +gem_softpin
>   gem_caching
>   gem_close_race
>   gem_concurrent_all
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 8fb2de8..2008d4a 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -11,6 +11,7 @@ TESTS_progs_M = \
>   	drv_hangman \
>   	gem_bad_reloc \
>   	gem_basic \
> +	gem_softpin \
>   	gem_caching \
>   	gem_close_race \
>   	gem_concurrent_blit \
> diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
> new file mode 100644
> index 0000000..8265643
> --- /dev/null
> +++ b/tests/gem_softpin.c
> @@ -0,0 +1,1049 @@
> +/*
> + * Copyright © 2015 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + *
> + * Authors:
> + *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> + *    Thomas Daniel <thomas.daniel@intel.com>
> + *
> + */
> +
> +#include <unistd.h>
> +#include <stdlib.h>
> +#include <stdint.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include <fcntl.h>
> +#include <inttypes.h>
> +#include <errno.h>
> +#include <sys/stat.h>
> +#include <sys/ioctl.h>
> +#include <sys/time.h>
> +#include <malloc.h>
> +#include "drm.h"
> +#include "ioctl_wrappers.h"
> +#include "drmtest.h"
> +#include "intel_chipset.h"
> +#include "intel_io.h"
> +#include "i915_drm.h"
> +#include <assert.h>
> +#include <sys/wait.h>
> +#include <sys/ipc.h>
> +#include <sys/shm.h>
> +#include "igt_kms.h"
> +#include <inttypes.h>
> +#include <sys/types.h>
> +#include <sys/stat.h>
> +
> +#define BO_SIZE 4096
> +#define MULTIPAGE_BO_SIZE 2 * BO_SIZE
> +#define STORE_BATCH_BUFFER_SIZE 4
> +#define EXEC_OBJECT_PINNED	(1<<4)
> +#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
> +#define SHARED_BUFFER_SIZE 4096
> +
> +typedef struct drm_i915_gem_userptr i915_gem_userptr;
> +
> +static uint32_t init_userptr(int fd, i915_gem_userptr *, void *ptr, uint64_t size);
> +static void *create_mem_buffer(uint64_t size);
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
> +static void gem_pin_userptr_test(void);
> +static void gem_pin_bo_test(void);
> +static void gem_pin_invalid_vma_test(void);
> +static void gem_pin_overlap_test(void);
> +static void gem_pin_high_address_test(void);
> +
> +#define NO_PPGTT 0
> +#define ALIASING_PPGTT 1
> +#define FULL_32_BIT_PPGTT 2
> +#define FULL_48_BIT_PPGTT 3
> +/* uses_full_ppgtt
> + * Finds supported PPGTT details.
> + * @fd DRM fd
> + * @min can be
> + * 0 - No PPGTT
> + * 1 - Aliasing PPGTT
> + * 2 - Full PPGTT (32b)
> + * 3 - Full PPGTT (48b)
> + * RETURNS true/false if min support is present
> +*/
> +static bool uses_full_ppgtt(int fd, int min)
> +{
> +	struct drm_i915_getparam gp;
> +	int val = 0;
> +
> +	memset(&gp, 0, sizeof(gp));
> +	gp.param = 18; /* HAS_ALIASING_PPGTT */
> +	gp.value = &val;
> +
> +	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
> +		return 0;
> +
> +	errno = 0;
> +	return val >= min;
> +}
> +
> +
> +/* gem_call_userptr_ioctl
> + * Helper to call ioctl - TODO: move to lib
> + * @fd - drm fd
> + * @userptr - pointer to initialised userptr
> + * RETURNS status of ioctl call
> +*/
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr)
> +{
> +	int ret;
> +
> +	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
> +
> +	if (ret)
> +		ret = errno;
> +
> +	return ret;
> +}
> +
> +/* init_userptr
> + * Helper that inits userptr an returns handle
> + * @fd - drm fd
> + * @userptr - pointer to empty userptr
> + * @ptr - buffer to be shared
> + * @size - size of buffer
> + * @ro - read only flag
> + * RETURNS handle to shared buffer
> +*/
> +static uint32_t init_userptr(int fd, i915_gem_userptr *userptr, void *ptr,
> +			     uint64_t size)
> +{
> +	int ret;
> +
> +	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
> +
> +	userptr->user_ptr = (uint64_t)ptr; /* Need the cast to overcome compiler warning */
> +	userptr->user_size = size;
> +	userptr->flags = 0; /* use synchronized operation */
> +
> +	ret = gem_call_userptr_ioctl(fd, userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	return userptr->handle;
> +}
> +
> +/* create_mem_buffer
> + * Creates a 4K aligned CPU buffer
> + * @size - size of buffer
> + * RETURNS pointer to buffer of @size
> +*/
> +static void *create_mem_buffer(uint64_t size)
> +{
> +	void *addr;
> +	int ret;
> +
> +	ret = posix_memalign(&addr, 4096, size);
> +	igt_assert(ret == 0);
> +
> +	return addr;
> +}
> +
> +/* setup_exec_obj
> + * populate exec object
> + * @exec - exec object
> + * @handle - handle to gem buffer
> + * @flags - any flags
> + * @offset - requested VMA
> +*/
> +static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec,
> +			   uint32_t handle, uint32_t flags,
> +			   uint64_t offset)
> +{
> +	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
> +	exec->handle = handle;
> +	exec->flags = flags;
> +	exec->offset = offset;
> +}
> +
> +/* gem_store_data_svm
> + * populate batch buffer with MI_STORE_DWORD_IMM command
> + * @fd: drm file descriptor
> + * @cmd_buf: batch buffer
> + * @vaddr: destination Virtual address
> + * @data: data to be store at destination
> + * @end: whether to end batch buffer or not
> +*/
> +static int gem_store_data_svm(int fd, uint32_t *cmd_buf, uint64_t vaddr,
> +			      uint32_t data, bool end)
> +{
> +	int i = 0;
> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
> +	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
> +
> +	cmd_buf[i++] = data;
> +	if (end) {
> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	return(i * sizeof(uint32_t));
> +}
> +
> +/* gem_store_data
> + * populate batch buffer with MI_STORE_DWORD_IMM command
> + * This one fills up reloc buffer as well
> + * @fd: drm file descriptor
> + * @cmd_buf: batch buffer
> + * @data: data to be store at destination
> + * @reloc - relocation entry
> + * @end: whether to end batch buffer or not
> +*/
> +static int gem_store_data(int fd, uint32_t *cmd_buf,
> +			  uint32_t handle, uint32_t data,
> +			  struct drm_i915_gem_relocation_entry *reloc,
> +			  bool end)
> +{
> +	int i = 0;
> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 reloc needed */
> +	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 reloc needed */
> +	reloc->offset = 1 * sizeof(uint32_t);
> +	reloc->delta = 0;
> +	reloc->target_handle = handle;
> +	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
> +	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
> +	reloc->presumed_offset = 0;
> +	cmd_buf[i++] = data;
> +	if (end) {
> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	return (i * sizeof(uint32_t));
> +}
> +
> +/* setup_execbuffer
> + * helper for buffer execution
> + * @execbuf - pointer to execbuffer
> + * @exec_object - pointer to exec object2 struct
> + * @ring - ring to be used
> + * @buffer_count - how manu buffers to submit
> + * @batch_length - length of batch buffer
> +*/
> +static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf,
> +			     struct drm_i915_gem_exec_object2 *exec_object,
> +			     int ring, int buffer_count, int batch_length)
> +{
> +	execbuf->buffers_ptr = (uint64_t)exec_object;
> +	execbuf->buffer_count = buffer_count;
> +	execbuf->batch_start_offset = 0;
> +	execbuf->batch_len = batch_length;
> +	execbuf->cliprects_ptr = 0;
> +	execbuf->num_cliprects = 0;
> +	execbuf->DR1 = 0;
> +	execbuf->DR4 = 0;
> +	execbuf->flags = ring;
> +	i915_execbuffer2_set_context_id(*execbuf, 0);
> +	execbuf->rsvd2 = 0;
> +}
> +
> +/* submit_and_sync
> + * Helper function for exec and sync functions
> + * @fd - drm fd
> + * @execbuf - pointer to execbuffer
> + * @batch_buf_handle - batch buffer handle
> +*/
> +static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf,
> +			    uint32_t batch_buf_handle)
> +{
> +	gem_execbuf(fd, execbuf);
> +	gem_sync(fd, batch_buf_handle);
> +}
> +
> +/* gem_userptr_sync
> + * helper for syncing to CPU domain - copy/paste from userblit
> + * @fd - drm fd
> + * @handle - buffer handle to sync
> +*/
> +static void gem_userptr_sync(int fd, uint32_t handle)
> +{
> +	gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
> +}
> +
> +
> +/* gem_pin_userptr_test
> + * This test will create a shared buffer, and create a command
> + * for GPU to write data in it
> + * CPU will read and make sure expected value is obtained
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +static void gem_pin_userptr_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	/* Check if driver pinned the buffer as requested */
> +	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
> +			"\nFailed to pin at requested offset");
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		      "\nCPU read does not match GPU write,\
> +			expected: 0x%x, got: 0x%x\n",
> +			data, shared_buffer[0]);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_bo
> + * This test will test softpinning of a gem buffer object
> + * Malloc a 4K buffer
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000
> + * Submit execbuffer
> + * Verify value pinned offset matches the request
> +*/
> +static void gem_pin_bo_test(void)
> +{
> +	int fd;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, unshared_buf_handle;
> +	struct drm_i915_gem_relocation_entry reloc[4];
> +	int ring, len;
> +	uint32_t value;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create gem buffer */
> +	unshared_buf_handle = gem_create(fd, BO_SIZE);
> +	
> +	/* create command buffer with write command */
> +	len = gem_store_data(fd, batch_buffer, unshared_buf_handle, data,
> +				reloc, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], unshared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +	exec_object2[1].relocation_count = 1;
> +	exec_object2[1].relocs_ptr = (uint64_t)reloc;
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	/* Check if driver pinned the buffer as requested */
> +	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
> +			"\nFailed to pin at requested offset");
> +	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
> +	igt_assert(value == data);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, unshared_buf_handle);
> +	close(fd);
> +}
> +
> +
> +/* gem_multiple_process_test
> + * Run basic test simultaneously with multiple processes
> + * This will test pinning same VA separately in each process
> +
> + * fork();
> + * Execute basic test in parent/child processes
> +*/
> +#define MAX_NUM_PROCESSES 10
> +
> +static void gem_multiple_process_test(void)
> +{
> +	igt_fork(child, MAX_NUM_PROCESSES) {
> +		gem_pin_userptr_test();
> +	}
> +	igt_waitchildren();
> +}
> +
> +
> +/* gem_repin_test
> + * This test tries to repin a buffer at a previously pinned vma
> + * from a different execbuf.
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000 VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +
> + * Create second shared buffer
> + * Follow all steps above
> + * Execpt, for offset, use VMA of first buffer above
> + * Submit execbuffer
> + * Verify value of first DWORD in second shared buffer matches DATA
> +*/
> +static void gem_repin_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	uint32_t *shared_buffer1;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	/* Create gem object */
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set first elements to 0x0 */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE);
> +	shared_buffer[0] = 0x0;
> +	shared_buffer1[0] = 0x0;
> +
> +	/* share with GPU and get handles */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> +					  BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	igt_assert(*shared_buffer == data);
> +
> +	/* Second buffer */
> +	/* create command buffer with write command */
> +	pinning_offset = exec_object2[0].offset;
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	/* Pin at shared_buffer, not shared_buffer1 */
> +	/* We are requesting address where another buffer was pinned previously */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle1,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle1);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	igt_assert(*shared_buffer1 == data);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +
> +/* gem_repin_overlap_test
> + * This test will attempt to pin two buffers at the same VMA as part of the same
> +   execbuffer object
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create second shared buffer
> + * Create batch buffer to write DATA to first dword of each buffer
> + * Use same virtual address as destination addresses in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in both exec objects
> + * Set 'offset' in both exec objects to same VMA
> + * Submit execbuffer
> + * Command should return EINVAL, since we are trying to pin to same VMA
> +*/
> +static void gem_pin_overlap_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd, ret;
> +	uint32_t *shared_buffer;
> +	uint32_t *shared_buffer1;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[3];
> +	uint32_t shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> +					  BO_SIZE * 2);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], shared_buf_handle1,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +
> +	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, &execbuf);
> +
> +	/* expect to fail */
> +	igt_assert_neq(ret, 0);
> +	igt_assert(errno == EINVAL);
> +
> +	close(fd);
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +/* gem_softpin_stress_test
> + * Stress test which creates 10K buffers and shares with GPU
> + * Create 100K uint32 buffers of size 4K each
> + * Share with GPU using userptr ioctl
> + * Create batch buffer to write DATA in first element of each buffer
> + * Pin each buffer to varying addresses starting from 0x800000000000 going below
> + * Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
> + * Validate every buffer has DATA in first element
> + * Rinse and Repeat on Render ring
> +*/
> +#define STRESS_NUM_BUFFERS 100000
> +#define STRESS_NUM_LOOPS 100
> +#define STRESS_STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
> +
> +static void gem_softpin_stress_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t **shared_buffer;
> +	uint32_t *shared_handle;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 *exec_object2;
> +	uint32_t *batch_buffer;
> +	uint32_t batch_buf_handle;
> +	int ring, len;
> +	int buf, loop;
> +	uint64_t pinning_offset = 0x800000000000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +
> +
> +	/* Allocate blobs for all data structures */
> +	shared_handle = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t));
> +	shared_buffer = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t *));
> +	exec_object2 = calloc(STRESS_NUM_BUFFERS + 1,
> +				sizeof(struct drm_i915_gem_exec_object2));
> +	/* 4 dwords per buffer + 2 for the end of batchbuffer */
> +	batch_buffer = calloc(STRESS_STORE_COMMANDS + 2, sizeof(uint32_t));
> +	batch_buf_handle = gem_create(fd, (STRESS_STORE_COMMANDS + 2)*4);
> +
> +	/* create command buffer with write commands */
> +	len = 0;
> +	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +		shared_buffer[buf] = create_mem_buffer(BO_SIZE);
> +		*shared_buffer[buf] = 0xFFFFFFFF;
> +
> +		/* share with GPU */
> +		shared_handle[buf] = init_userptr(fd, &userptr,
> +						  shared_buffer[buf],
> +						  BO_SIZE);
> +
> +		setup_exec_obj(&exec_object2[buf], shared_handle[buf],
> +			       EXEC_OBJECT_PINNED, pinning_offset);
> +		len += gem_store_data_svm(fd, batch_buffer + (len/4),
> +					  pinning_offset, buf,
> +					  (buf == STRESS_NUM_BUFFERS-1)? \
> +					  true:false);
> +		
> +		/* decremental 4K aligned address */
> +		pinning_offset -= ALIGN(BO_SIZE, 4096);
> +	}
> +
> +	/* setup command buffer */
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle,
> +		       0, 0);
> +
> +	/* We want to run this on BLT ring if possible */
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd))) {
> +		ring = I915_EXEC_BLT;
> +
> +		setup_execbuffer(&execbuf, exec_object2, ring,
> +				 STRESS_NUM_BUFFERS + 1, len);
> +
> +		for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
> +			submit_and_sync(fd, &execbuf, batch_buf_handle);
> +			/* Set pinning offset back to original value */
> +			pinning_offset = 0x800000000000;
> +			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +				gem_userptr_sync(fd, shared_handle[buf]);
> +				igt_assert(exec_object2[buf].offset == pinning_offset);
> +				igt_fail_on_f(*shared_buffer[buf] != buf, \
> +				"Mismatch in buffer %d, iteration %d: 0x%08X\n", \
> +				buf, loop, *shared_buffer[buf]);
> +				pinning_offset -= ALIGN(BO_SIZE, 4096);
> +			}
> +			/* Reset the buffer entries for next iteration */
> +			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +				*shared_buffer[buf] = 0xFFFFFFFF;
> +			}
> +		}
> +	}
> +
> +	/* Now Render Ring */
> +	ring = I915_EXEC_RENDER;
> +	setup_execbuffer(&execbuf, exec_object2, ring,
> +			 STRESS_NUM_BUFFERS + 1, len);
> +	for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		pinning_offset = 0x800000000000;
> +		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +			gem_userptr_sync(fd, shared_handle[buf]);
> +			igt_assert(exec_object2[buf].offset == pinning_offset);
> +			igt_fail_on_f(*shared_buffer[buf] != buf, \
> +			"Mismatch in buffer %d, \
> +			iteration %d: 0x%08X\n", buf, loop, *shared_buffer[buf]);
> +			pinning_offset -= ALIGN(BO_SIZE, 4096);
> +		}
> +		/* Reset the buffer entries for next iteration */
> +		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +			*shared_buffer[buf] = 0xFFFFFFFF;
> +		}
> +	}
> +
> +	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +		gem_close(fd, shared_handle[buf]);
> +		free(shared_buffer[buf]);
> +	}
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_handle);
> +	free(shared_buffer);
> +	free(exec_object2);
> +	free(batch_buffer);
> +}
> +
> +/* gem_write_multipage_buffer
> + * Create a buffer spanning multiple pages, and share with GPU.
> + * Write to every element of the buffer
> + * and verify correct contents.
> +
> + * Create 8K buffer
> + * Share with GPU using userptr ioctl
> + * Create batch buffer to write DATA in all elements of buffer
> + * Execute Batch Buffer
> + * Validate every element has DATA
> +*/
> +
> +#define DWORD_SIZE sizeof(uint32_t)
> +#define BB_SIZE ((MULTIPAGE_BO_SIZE / DWORD_SIZE) * STORE_BATCH_BUFFER_SIZE) + 2
> +#define NUM_DWORDS (MULTIPAGE_BO_SIZE/sizeof(uint32_t))
> +static void gem_write_multipage_buffer_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	uint32_t shared_handle;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[BB_SIZE];
> +	uint32_t batch_buf_handle;
> +	int ring, len, j;
> +	uint64_t pinning_offset=0x1000;
> +	uint64_t vaddr;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
> +	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
> +
> +	len = 0;
> +	memset(batch_buffer, 0, sizeof(batch_buffer));
> +	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
> +
> +	/* share with GPU */
> +	shared_handle = init_userptr(fd, &userptr, shared_buffer,
> +				     MULTIPAGE_BO_SIZE);
> +	setup_exec_obj(&exec_object2[0], shared_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +
> +	/* create command buffer with write commands */
> +	vaddr = pinning_offset;
> +	for(j=0; j< NUM_DWORDS; j++) {
> +		len += gem_store_data_svm(fd, batch_buffer + (len/4), vaddr,
> +					  j,
> +					  (j == NUM_DWORDS - 1) ? true:false);
> +		vaddr += sizeof(shared_buffer[0]);  /* 4 bytes */
> +	}
> +
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_handle);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	for(j = 0; j < (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++) {
> +		igt_fail_on_f(shared_buffer[j] != j,
> +		"Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_invalid_vma_test
> + * This test will request to pin a shared buffer to an invalid
> + * VMA  > 48-bit address if system supports 48B PPGTT
> + * If system supports 32B PPGTT, it will test the equivalent invalid VMA
> + * Create shared buffer of size 4K
> + * Try and Pin object to invalid address
> +*/
> +static void gem_pin_invalid_vma_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[1];
> +	uint32_t shared_buf_handle;
> +	int ring;
> +	uint64_t invalid_address_for_48b = 0x9000000000000; /* 52 bit address */
> +	uint64_t invalid_address_for_32b = 0x900000000; /* 36 bit address */
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT) ||
> +		    uses_full_ppgtt(fd, FULL_32_BIT_PPGTT));
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +	
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	if (uses_full_ppgtt(fd, FULL_48_BIT_PPGTT)) {
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED, invalid_address_for_48b);
> +	} else {
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED, invalid_address_for_32b);
> +	}
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 1, 0);
> +
> +	/* Expect execbuf to fail */
> +	ret = drmIoctl(fd,
> +		       DRM_IOCTL_I915_GEM_EXECBUFFER2,
> +		       &execbuf);
> +
> +	igt_assert(errno == ENOSPC);
> +	igt_assert_neq(ret, 0);
> +	
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +
> +/* gem_pin_high_address_test
> + * This test will create a shared buffer, and create a command
> + * for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
> + * CPU will read and make sure expected value is obtained
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use virtual address of buffer as 0x1100000000 (> 32 bit)
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to shared buffer VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> + * Now try same test without using 48BIT flag
> + * test should pass with requested pinning address
> +*/
> +
> +static void gem_pin_high_address_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	igt_assert(exec_object2[0].offset == high_address);
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, \
> +		expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
> +
> +	/* Now try pinning to high address without 48BIT flag */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, high_address);
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	igt_assert(exec_object2[0].offset == high_address);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_near_48Bit_test
> + * This test will create a shared buffer,
> + * and create a command for GPU to write data in it. It will attempt
> + * to pin the buffer at address > 47 bits <= 48-bit.
> + * CPU will read and make sure expected value is obtained
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use virtual address of buffer as range between 47-bit and 48-bit
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to shared buffer VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000
> +#define END_HIGH_ADDRESS 0xFFFFFFFFC000
> +#define ADDRESS_INCREMENT 0x2000000000
> +static void gem_pin_near_48Bit_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS;
> +						high_address+=ADDRESS_INCREMENT) {
> +		/* create command buffer with write command */
> +		len = gem_store_data_svm(fd, batch_buffer, high_address,
> +					data, true);
> +		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +		/* submit command buffer */
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
> +			       high_address);
> +		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +		ring = I915_EXEC_RENDER;
> +		setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		gem_userptr_sync(fd, shared_buf_handle);
> +
> +		igt_assert(exec_object2[0].offset == high_address);
> +		/* check on CPU to see if value changes */
> +		igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, expected: 0x%x, \
> +		got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +
> +int main(int argc, char* argv[])
> +{
> +	igt_subtest_init(argc, argv);
> +	igt_skip_on_simulation();
> +
> +	/* All tests need PPGTT support */
> +	igt_subtest("gem_pin_userptr") {
> +		gem_pin_userptr_test();
> +	}
> +	igt_subtest("gem_pin_bo") {
> +		gem_pin_bo_test();
> +	}
> +	igt_subtest("gem_multiple_process") {
> +		gem_multiple_process_test();
> +	}
> +	igt_subtest("gem_repin") {
> +		gem_repin_test();
> +	}
> +	igt_subtest("gem_pin_overlap") {
> +		gem_pin_overlap_test();
> +	}
> +	igt_subtest("gem_write_multipage_buffer") {
> +		gem_write_multipage_buffer_test();
> +	}
> +
> +	/* Following tests need 32/48 Bit PPGTT support */
> +	igt_subtest("gem_pin_invalid_vma") {
> +		gem_pin_invalid_vma_test();
> +	}
> +
> +	/* Following tests need 48 Bit PPGTT support */
> +	igt_subtest("gem_softpin_stress") {
> +		gem_softpin_stress_test();
> +	}
> +	igt_subtest("gem_pin_high_address") {
> +		gem_pin_high_address_test();
> +	}
> +	igt_subtest("gem_pin_near_48Bit") {
> +		gem_pin_near_48Bit_test();
> +	}
> +
> +	igt_exit();
> +}
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
@ 2015-12-01 11:20 Vinay Belgaumkar
  2015-12-02 10:24 ` Tvrtko Ursulin
  0 siblings, 1 reply; 19+ messages in thread
From: Vinay Belgaumkar @ 2015-12-01 11:20 UTC (permalink / raw)
  To: intel-gfx; +Cc: Vinay Belgaumkar

These tests exercise the userptr ioctl to create shared buffers
between CPU and GPU. They contain error and normal usage scenarios.
They also contain a couple of stress tests which copy buffers between
CPU and GPU. These tests rely on the softpin patch in order to pin buffers
to a certain VA.

Caveat: These tests were designed to run on 64-bit system. Future work
includes adding logic to ensure these tests can run on 32-bit systems with
PPGTT support. Some tests are currently disabled for 32-bit systems for that
reason.

v2: Added cc and signed-off-by fields

v3: Fixed review comments, added helper functions. Removed userptr error
scenarios covered by existing userptr tests. Modified stress test to have
100K buffers, it now runs for ~30 mins, checks every element has been written
to correctly, and pins buffers at different VMAs.

v4: Changed name to gem_softpin

v5: More fixes. Removed the file based tests, will move them to userptr tests.
Added a function that validates appropriate PPGTT support before running tests.
Optimized stack space and memory footprint in stress test. Removed the eviction
test, will add it back after verifying proper functionality.

v6: Split basic test into userptr and bo
Fixed some coding style issues.

v7: Enhanced invalid vma pinning test to verify 32-bit PPGTT functionality.
Enabled the test for 32-bit PPGTT systems, and verify pinning fails above
32-bit addresses. Enhanced the high adress pinning test to ensure pinning
fails when EXEC_OBJECT_PINNED flag is not used. Some more cosmetic fixes to
close buffer handles. Changed userptr function to used synchronized operations.

v8: Minor change to high address pinning test as per comment.

Cc: Michel Thierry <michel.thierry@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
 tests/.gitignore       |    1 +
 tests/Makefile.sources |    1 +
 tests/gem_softpin.c    | 1049 ++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 1051 insertions(+)
 create mode 100644 tests/gem_softpin.c

diff --git a/tests/.gitignore b/tests/.gitignore
index 80af9a7..424870b 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -21,6 +21,7 @@ gem_bad_blit
 gem_bad_length
 gem_bad_reloc
 gem_basic
+gem_softpin
 gem_caching
 gem_close_race
 gem_concurrent_all
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 8fb2de8..2008d4a 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -11,6 +11,7 @@ TESTS_progs_M = \
 	drv_hangman \
 	gem_bad_reloc \
 	gem_basic \
+	gem_softpin \
 	gem_caching \
 	gem_close_race \
 	gem_concurrent_blit \
diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
new file mode 100644
index 0000000..8265643
--- /dev/null
+++ b/tests/gem_softpin.c
@@ -0,0 +1,1049 @@
+/*
+ * Copyright © 2015 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ * Authors:
+ *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
+ *    Thomas Daniel <thomas.daniel@intel.com>
+ *
+ */
+
+#include <unistd.h>
+#include <stdlib.h>
+#include <stdint.h>
+#include <stdio.h>
+#include <string.h>
+#include <fcntl.h>
+#include <inttypes.h>
+#include <errno.h>
+#include <sys/stat.h>
+#include <sys/ioctl.h>
+#include <sys/time.h>
+#include <malloc.h>
+#include "drm.h"
+#include "ioctl_wrappers.h"
+#include "drmtest.h"
+#include "intel_chipset.h"
+#include "intel_io.h"
+#include "i915_drm.h"
+#include <assert.h>
+#include <sys/wait.h>
+#include <sys/ipc.h>
+#include <sys/shm.h>
+#include "igt_kms.h"
+#include <inttypes.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+
+#define BO_SIZE 4096
+#define MULTIPAGE_BO_SIZE 2 * BO_SIZE
+#define STORE_BATCH_BUFFER_SIZE 4
+#define EXEC_OBJECT_PINNED	(1<<4)
+#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
+#define SHARED_BUFFER_SIZE 4096
+
+typedef struct drm_i915_gem_userptr i915_gem_userptr;
+
+static uint32_t init_userptr(int fd, i915_gem_userptr *, void *ptr, uint64_t size);
+static void *create_mem_buffer(uint64_t size);
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
+static void gem_pin_userptr_test(void);
+static void gem_pin_bo_test(void);
+static void gem_pin_invalid_vma_test(void);
+static void gem_pin_overlap_test(void);
+static void gem_pin_high_address_test(void);
+
+#define NO_PPGTT 0
+#define ALIASING_PPGTT 1
+#define FULL_32_BIT_PPGTT 2
+#define FULL_48_BIT_PPGTT 3
+/* uses_full_ppgtt
+ * Finds supported PPGTT details. 
+ * @fd DRM fd
+ * @min can be
+ * 0 - No PPGTT
+ * 1 - Aliasing PPGTT
+ * 2 - Full PPGTT (32b)
+ * 3 - Full PPGTT (48b)
+ * RETURNS true/false if min support is present
+*/
+static bool uses_full_ppgtt(int fd, int min)
+{
+	struct drm_i915_getparam gp;
+	int val = 0;
+
+	memset(&gp, 0, sizeof(gp));
+	gp.param = 18; /* HAS_ALIASING_PPGTT */
+	gp.value = &val;
+
+	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
+		return 0;
+
+	errno = 0;
+	return val >= min;
+}
+
+
+/* gem_call_userptr_ioctl
+ * Helper to call ioctl - TODO: move to lib
+ * @fd - drm fd
+ * @userptr - pointer to initialised userptr
+ * RETURNS status of ioctl call
+*/
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr)
+{
+	int ret;
+
+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
+
+	if (ret)
+		ret = errno;
+
+	return ret;
+}
+
+/* init_userptr
+ * Helper that inits userptr an returns handle
+ * @fd - drm fd
+ * @userptr - pointer to empty userptr
+ * @ptr - buffer to be shared
+ * @size - size of buffer
+ * @ro - read only flag
+ * RETURNS handle to shared buffer
+*/
+static uint32_t init_userptr(int fd, i915_gem_userptr *userptr, void *ptr,
+			     uint64_t size)
+{
+	int ret;
+
+	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
+
+	userptr->user_ptr = (uint64_t)ptr; /* Need the cast to overcome compiler warning */
+	userptr->user_size = size;
+	userptr->flags = 0; /* use synchronized operation */
+
+	ret = gem_call_userptr_ioctl(fd, userptr);
+	igt_assert_eq(ret, 0);
+
+	return userptr->handle;
+}
+
+/* create_mem_buffer 
+ * Creates a 4K aligned CPU buffer 
+ * @size - size of buffer
+ * RETURNS pointer to buffer of @size
+*/
+static void *create_mem_buffer(uint64_t size)
+{
+	void *addr;
+	int ret;
+
+	ret = posix_memalign(&addr, 4096, size);
+	igt_assert(ret == 0);
+
+	return addr;
+}
+
+/* setup_exec_obj 
+ * populate exec object
+ * @exec - exec object
+ * @handle - handle to gem buffer
+ * @flags - any flags
+ * @offset - requested VMA
+*/
+static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec,
+			   uint32_t handle, uint32_t flags,
+			   uint64_t offset)
+{
+	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
+	exec->handle = handle;
+	exec->flags = flags;
+	exec->offset = offset;
+}
+
+/* gem_store_data_svm 
+ * populate batch buffer with MI_STORE_DWORD_IMM command
+ * @fd: drm file descriptor
+ * @cmd_buf: batch buffer
+ * @vaddr: destination Virtual address
+ * @data: data to be store at destination
+ * @end: whether to end batch buffer or not
+*/
+static int gem_store_data_svm(int fd, uint32_t *cmd_buf, uint64_t vaddr,
+			      uint32_t data, bool end)
+{
+	int i = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
+	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
+
+	cmd_buf[i++] = data;
+	if (end) { 
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	return(i * sizeof(uint32_t));
+}
+
+/* gem_store_data 
+ * populate batch buffer with MI_STORE_DWORD_IMM command
+ * This one fills up reloc buffer as well 
+ * @fd: drm file descriptor
+ * @cmd_buf: batch buffer
+ * @data: data to be store at destination
+ * @reloc - relocation entry
+ * @end: whether to end batch buffer or not
+*/
+static int gem_store_data(int fd, uint32_t *cmd_buf,
+			  uint32_t handle, uint32_t data,
+			  struct drm_i915_gem_relocation_entry *reloc,
+			  bool end)
+{
+	int i = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 reloc needed */
+	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 reloc needed */
+	reloc->offset = 1 * sizeof(uint32_t);
+	reloc->delta = 0;
+	reloc->target_handle = handle;
+	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
+	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
+	reloc->presumed_offset = 0;
+	cmd_buf[i++] = data;
+	if (end) { 
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	return (i * sizeof(uint32_t));
+}
+
+/* setup_execbuffer 
+ * helper for buffer execution
+ * @execbuf - pointer to execbuffer
+ * @exec_object - pointer to exec object2 struct
+ * @ring - ring to be used
+ * @buffer_count - how manu buffers to submit
+ * @batch_length - length of batch buffer 
+*/
+static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf,
+			     struct drm_i915_gem_exec_object2 *exec_object,
+			     int ring, int buffer_count, int batch_length)
+{
+	execbuf->buffers_ptr = (uint64_t)exec_object;
+	execbuf->buffer_count = buffer_count;
+	execbuf->batch_start_offset = 0;
+	execbuf->batch_len = batch_length;
+	execbuf->cliprects_ptr = 0;
+	execbuf->num_cliprects = 0;
+	execbuf->DR1 = 0;
+	execbuf->DR4 = 0;
+	execbuf->flags = ring;
+	i915_execbuffer2_set_context_id(*execbuf, 0);
+	execbuf->rsvd2 = 0;
+}
+
+/* submit_and_sync 
+ * Helper function for exec and sync functions 
+ * @fd - drm fd
+ * @execbuf - pointer to execbuffer
+ * @batch_buf_handle - batch buffer handle
+*/
+static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf,
+			    uint32_t batch_buf_handle)
+{
+	gem_execbuf(fd, execbuf);
+	gem_sync(fd, batch_buf_handle); 
+}
+
+/* gem_userptr_sync
+ * helper for syncing to CPU domain - copy/paste from userblit
+ * @fd - drm fd
+ * @handle - buffer handle to sync
+*/
+static void gem_userptr_sync(int fd, uint32_t handle)
+{
+	gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
+}
+
+
+/* gem_pin_userptr_test 
+ * This test will create a shared buffer, and create a command
+ * for GPU to write data in it
+ * CPU will read and make sure expected value is obtained
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+static void gem_pin_userptr_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	/* Check if driver pinned the buffer as requested */
+	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
+			"\nFailed to pin at requested offset");
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		      "\nCPU read does not match GPU write,\
+			expected: 0x%x, got: 0x%x\n", 
+			data, shared_buffer[0]);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/* gem_pin_bo 
+ * This test will test softpinning of a gem buffer object
+ * Malloc a 4K buffer
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000
+ * Submit execbuffer
+ * Verify value pinned offset matches the request
+*/
+static void gem_pin_bo_test(void)
+{
+	int fd;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, unshared_buf_handle;
+	struct drm_i915_gem_relocation_entry reloc[4];
+	int ring, len;
+	uint32_t value;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create gem buffer */
+	unshared_buf_handle = gem_create(fd, BO_SIZE);
+	
+	/* create command buffer with write command */
+	len = gem_store_data(fd, batch_buffer, unshared_buf_handle, data,
+				reloc, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], unshared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+	exec_object2[1].relocation_count = 1;
+	exec_object2[1].relocs_ptr = (uint64_t)reloc;
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	/* Check if driver pinned the buffer as requested */
+	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
+			"\nFailed to pin at requested offset");
+	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
+	igt_assert(value == data);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, unshared_buf_handle);
+	close(fd);
+}
+
+
+/* gem_multiple_process_test 
+ * Run basic test simultaneously with multiple processes
+ * This will test pinning same VA separately in each process
+
+ * fork();
+ * Execute basic test in parent/child processes
+*/
+#define MAX_NUM_PROCESSES 10
+
+static void gem_multiple_process_test(void)
+{
+	igt_fork(child, MAX_NUM_PROCESSES) {
+		gem_pin_userptr_test();
+	}
+	igt_waitchildren();
+}
+
+
+/* gem_repin_test 
+ * This test tries to repin a buffer at a previously pinned vma 
+ * from a different execbuf. 
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000 VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+
+ * Create second shared buffer
+ * Follow all steps above
+ * Execpt, for offset, use VMA of first buffer above 
+ * Submit execbuffer
+ * Verify value of first DWORD in second shared buffer matches DATA
+*/
+static void gem_repin_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd;
+	uint32_t *shared_buffer;
+	uint32_t *shared_buffer1;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	/* Create gem object */
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set first elements to 0x0 */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE);
+	shared_buffer[0] = 0x0;
+	shared_buffer1[0] = 0x0;
+
+	/* share with GPU and get handles */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
+					  BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	igt_assert(*shared_buffer == data);
+
+	/* Second buffer */
+	/* create command buffer with write command */
+	pinning_offset = exec_object2[0].offset;
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	/* Pin at shared_buffer, not shared_buffer1 */
+	/* We are requesting address where another buffer was pinned previously */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle1,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle1);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	igt_assert(*shared_buffer1 == data);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+
+/* gem_repin_overlap_test
+ * This test will attempt to pin two buffers at the same VMA as part of the same
+   execbuffer object
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create second shared buffer
+ * Create batch buffer to write DATA to first dword of each buffer
+ * Use same virtual address as destination addresses in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in both exec objects
+ * Set 'offset' in both exec objects to same VMA
+ * Submit execbuffer
+ * Command should return EINVAL, since we are trying to pin to same VMA
+*/
+static void gem_pin_overlap_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd, ret;
+	uint32_t *shared_buffer;
+	uint32_t *shared_buffer1;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[3];
+	uint32_t shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
+					  BO_SIZE * 2);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], shared_buf_handle1,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+
+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, &execbuf);
+
+	/* expect to fail */
+	igt_assert_neq(ret, 0);
+	igt_assert(errno == EINVAL);
+
+	close(fd);
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+/* gem_softpin_stress_test 
+ * Stress test which creates 10K buffers and shares with GPU 
+ * Create 100K uint32 buffers of size 4K each
+ * Share with GPU using userptr ioctl
+ * Create batch buffer to write DATA in first element of each buffer
+ * Pin each buffer to varying addresses starting from 0x800000000000 going below
+ * Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
+ * Validate every buffer has DATA in first element
+ * Rinse and Repeat on Render ring
+*/
+#define STRESS_NUM_BUFFERS 100000
+#define STRESS_NUM_LOOPS 100
+#define STRESS_STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
+
+static void gem_softpin_stress_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t **shared_buffer;
+	uint32_t *shared_handle;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 *exec_object2;
+	uint32_t *batch_buffer; 
+	uint32_t batch_buf_handle;
+	int ring, len;
+	int buf, loop;
+	uint64_t pinning_offset = 0x800000000000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+
+
+	/* Allocate blobs for all data structures */
+	shared_handle = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t));
+	shared_buffer = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t *));
+	exec_object2 = calloc(STRESS_NUM_BUFFERS + 1, 
+				sizeof(struct drm_i915_gem_exec_object2));
+	/* 4 dwords per buffer + 2 for the end of batchbuffer */
+	batch_buffer = calloc(STRESS_STORE_COMMANDS + 2, sizeof(uint32_t));
+	batch_buf_handle = gem_create(fd, (STRESS_STORE_COMMANDS + 2)*4);
+
+	/* create command buffer with write commands */
+	len = 0;
+	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+		shared_buffer[buf] = create_mem_buffer(BO_SIZE);
+		*shared_buffer[buf] = 0xFFFFFFFF;
+
+		/* share with GPU */
+		shared_handle[buf] = init_userptr(fd, &userptr,
+						  shared_buffer[buf],
+						  BO_SIZE);
+
+		setup_exec_obj(&exec_object2[buf], shared_handle[buf],
+			       EXEC_OBJECT_PINNED, pinning_offset);
+		len += gem_store_data_svm(fd, batch_buffer + (len/4),
+					  pinning_offset, buf,
+					  (buf == STRESS_NUM_BUFFERS-1)? \
+					  true:false);
+		
+		/* decremental 4K aligned address */
+		pinning_offset -= ALIGN(BO_SIZE, 4096);
+	}
+
+	/* setup command buffer */
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle,
+		       0, 0);
+
+	/* We want to run this on BLT ring if possible */
+	if (HAS_BLT_RING(intel_get_drm_devid(fd))) {
+		ring = I915_EXEC_BLT;
+
+		setup_execbuffer(&execbuf, exec_object2, ring,
+				 STRESS_NUM_BUFFERS + 1, len);
+
+		for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
+			submit_and_sync(fd, &execbuf, batch_buf_handle);
+			/* Set pinning offset back to original value */
+			pinning_offset = 0x800000000000;
+			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+				gem_userptr_sync(fd, shared_handle[buf]);
+				igt_assert(exec_object2[buf].offset == pinning_offset);
+				igt_fail_on_f(*shared_buffer[buf] != buf, \
+				"Mismatch in buffer %d, iteration %d: 0x%08X\n", \
+				buf, loop, *shared_buffer[buf]);
+				pinning_offset -= ALIGN(BO_SIZE, 4096);
+			}
+			/* Reset the buffer entries for next iteration */
+			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+				*shared_buffer[buf] = 0xFFFFFFFF;
+			}
+		}
+	}
+
+	/* Now Render Ring */
+	ring = I915_EXEC_RENDER;
+	setup_execbuffer(&execbuf, exec_object2, ring,
+			 STRESS_NUM_BUFFERS + 1, len);
+	for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		pinning_offset = 0x800000000000;
+		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+			gem_userptr_sync(fd, shared_handle[buf]);
+			igt_assert(exec_object2[buf].offset == pinning_offset);
+			igt_fail_on_f(*shared_buffer[buf] != buf, \
+			"Mismatch in buffer %d, \
+			iteration %d: 0x%08X\n", buf, loop, *shared_buffer[buf]);
+			pinning_offset -= ALIGN(BO_SIZE, 4096);
+		}
+		/* Reset the buffer entries for next iteration */
+		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+			*shared_buffer[buf] = 0xFFFFFFFF;
+		}
+	}
+
+	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+		gem_close(fd, shared_handle[buf]);
+		free(shared_buffer[buf]);
+	}
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_handle);
+	free(shared_buffer);
+	free(exec_object2);
+	free(batch_buffer);
+}
+
+/* gem_write_multipage_buffer 
+ * Create a buffer spanning multiple pages, and share with GPU. 
+ * Write to every element of the buffer
+ * and verify correct contents.
+
+ * Create 8K buffer
+ * Share with GPU using userptr ioctl
+ * Create batch buffer to write DATA in all elements of buffer
+ * Execute Batch Buffer
+ * Validate every element has DATA
+*/
+
+#define DWORD_SIZE sizeof(uint32_t)
+#define BB_SIZE ((MULTIPAGE_BO_SIZE / DWORD_SIZE) * STORE_BATCH_BUFFER_SIZE) + 2
+#define NUM_DWORDS (MULTIPAGE_BO_SIZE/sizeof(uint32_t))
+static void gem_write_multipage_buffer_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	uint32_t shared_handle;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[BB_SIZE];
+	uint32_t batch_buf_handle;
+	int ring, len, j;
+	uint64_t pinning_offset=0x1000;
+	uint64_t vaddr;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+
+	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
+	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
+
+	len = 0;
+	memset(batch_buffer, 0, sizeof(batch_buffer));
+	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
+
+	/* share with GPU */
+	shared_handle = init_userptr(fd, &userptr, shared_buffer,
+				     MULTIPAGE_BO_SIZE);
+	setup_exec_obj(&exec_object2[0], shared_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+
+	/* create command buffer with write commands */
+	vaddr = pinning_offset;
+	for(j=0; j< NUM_DWORDS; j++) { 
+		len += gem_store_data_svm(fd, batch_buffer + (len/4), vaddr,
+					  j,
+					  (j == NUM_DWORDS - 1) ? true:false);
+		vaddr += sizeof(shared_buffer[0]);  /* 4 bytes */
+	}
+
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_handle);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	for(j = 0; j < (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++) {
+		igt_fail_on_f(shared_buffer[j] != j,
+		"Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_handle);
+	close(fd);
+
+	free(shared_buffer);
+}
+
+/* gem_pin_invalid_vma_test 
+ * This test will request to pin a shared buffer to an invalid
+ * VMA  > 48-bit address if system supports 48B PPGTT
+ * If system supports 32B PPGTT, it will test the equivalent invalid VMA
+ * Create shared buffer of size 4K
+ * Try and Pin object to invalid address
+*/
+static void gem_pin_invalid_vma_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[1];
+	uint32_t shared_buf_handle;
+	int ring;
+	uint64_t invalid_address_for_48b = 0x9000000000000; /* 52 bit address */
+	uint64_t invalid_address_for_32b = 0x900000000; /* 36 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT) ||
+		    uses_full_ppgtt(fd, FULL_32_BIT_PPGTT));
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+	
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+
+	if (uses_full_ppgtt(fd, FULL_48_BIT_PPGTT)) {
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED, invalid_address_for_48b);
+	} else {
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED, invalid_address_for_32b);
+	}
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 1, 0);
+
+	/* Expect execbuf to fail */
+	ret = drmIoctl(fd,
+		       DRM_IOCTL_I915_GEM_EXECBUFFER2,
+		       &execbuf);
+
+	igt_assert(errno == ENOSPC);
+	igt_assert_neq(ret, 0);
+	
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+
+/* gem_pin_high_address_test 
+ * This test will create a shared buffer, and create a command
+ * for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
+ * CPU will read and make sure expected value is obtained
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use virtual address of buffer as 0x1100000000 (> 32 bit)
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to shared buffer VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+ * Now try same test without using 48BIT flag
+ * test should pass with requested pinning address
+*/
+
+static void gem_pin_high_address_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+ 
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	igt_assert(exec_object2[0].offset == high_address);
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, \
+		expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
+
+	/* Now try pinning to high address without 48BIT flag */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, high_address);
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	igt_assert(exec_object2[0].offset == high_address);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/* gem_pin_near_48Bit_test 
+ * This test will create a shared buffer, 
+ * and create a command for GPU to write data in it. It will attempt 
+ * to pin the buffer at address > 47 bits <= 48-bit.
+ * CPU will read and make sure expected value is obtained
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use virtual address of buffer as range between 47-bit and 48-bit
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to shared buffer VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000 
+#define END_HIGH_ADDRESS 0xFFFFFFFFC000
+#define ADDRESS_INCREMENT 0x2000000000
+static void gem_pin_near_48Bit_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+
+	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS;
+						high_address+=ADDRESS_INCREMENT) {
+		/* create command buffer with write command */
+		len = gem_store_data_svm(fd, batch_buffer, high_address,
+					data, true);
+		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+		/* submit command buffer */
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
+			       high_address);
+		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+		ring = I915_EXEC_RENDER;
+		setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		gem_userptr_sync(fd, shared_buf_handle);
+
+		igt_assert(exec_object2[0].offset == high_address);
+		/* check on CPU to see if value changes */
+		igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, expected: 0x%x, \
+		got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+
+int main(int argc, char* argv[])
+{
+	igt_subtest_init(argc, argv);
+	igt_skip_on_simulation();
+
+	/* All tests need PPGTT support */
+	igt_subtest("gem_pin_userptr") {
+		gem_pin_userptr_test();
+	}
+	igt_subtest("gem_pin_bo") {
+		gem_pin_bo_test();
+	}
+	igt_subtest("gem_multiple_process") {
+		gem_multiple_process_test();
+	}
+	igt_subtest("gem_repin") {
+		gem_repin_test();
+	}
+	igt_subtest("gem_pin_overlap") {
+		gem_pin_overlap_test();
+	}
+	igt_subtest("gem_write_multipage_buffer") {
+		gem_write_multipage_buffer_test();
+	}
+
+	/* Following tests need 32/48 Bit PPGTT support */
+	igt_subtest("gem_pin_invalid_vma") {
+		gem_pin_invalid_vma_test();
+	}
+
+	/* Following tests need 48 Bit PPGTT support */
+	igt_subtest("gem_softpin_stress") {
+		gem_softpin_stress_test();
+	}
+	igt_subtest("gem_pin_high_address") {
+		gem_pin_high_address_test();
+	}
+	igt_subtest("gem_pin_near_48Bit") {
+		gem_pin_near_48Bit_test();
+	}
+
+	igt_exit();
+}
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
  2015-11-30 18:22 Vinay Belgaumkar
@ 2015-12-01 10:35 ` Tvrtko Ursulin
  2015-12-04  9:45   ` Daniel Vetter
  0 siblings, 1 reply; 19+ messages in thread
From: Tvrtko Ursulin @ 2015-12-01 10:35 UTC (permalink / raw)
  To: Vinay Belgaumkar, intel-gfx


Hi,

Just one comment deep down.

On 30/11/15 18:22, Vinay Belgaumkar wrote:
> These tests exercise the userptr ioctl to create shared buffers
> between CPU and GPU. They contain error and normal usage scenarios.
> They also contain a couple of stress tests which copy buffers between
> CPU and GPU. These tests rely on the softpin patch in order to pin buffers
> to a certain VA.
>
> Caveat: These tests were designed to run on 64-bit system. Future work
> includes adding logic to ensure these tests can run on 32-bit systems with
> PPGTT support. Some tests are currently disabled for 32-bit systems for that
> reason.
>
> v2: Added cc and signed-off-by fields
>
> v3: Fixed review comments, added helper functions. Removed userptr error
> scenarios covered by existing userptr tests. Modified stress test to have
> 100K buffers, it now runs for ~30 mins, checks every element has been written
> to correctly, and pins buffers at different VMAs.
>
> v4: Changed name to gem_softpin
>
> v5: More fixes. Removed the file based tests, will move them to userptr tests.
> Added a function that validates appropriate PPGTT support before running tests.
> Optimized stack space and memory footprint in stress test. Removed the eviction
> test, will add it back after verifying proper functionality.
>
> v6: Split basic test into userptr and bo
> Fixed some coding style issues.
>
> v7: Enhanced invalid vma pinning test to verify 32-bit PPGTT functionality.
> Enabled the test for 32-bit PPGTT systems, and verify pinning fails above
> 32-bit addresses. Enhanced the high adress pinning test to ensure pinning
> fails when EXEC_OBJECT_PINNED flag is not used. Some more cosmetic fixes to
> close buffer handles. Changed userptr function to used synchronized operations.
>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
>   tests/.gitignore       |    1 +
>   tests/Makefile.sources |    1 +
>   tests/gem_softpin.c    | 1050 ++++++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 1052 insertions(+)
>   create mode 100644 tests/gem_softpin.c
>
> diff --git a/tests/.gitignore b/tests/.gitignore
> index 80af9a7..424870b 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -21,6 +21,7 @@ gem_bad_blit
>   gem_bad_length
>   gem_bad_reloc
>   gem_basic
> +gem_softpin
>   gem_caching
>   gem_close_race
>   gem_concurrent_all
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 8fb2de8..2008d4a 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -11,6 +11,7 @@ TESTS_progs_M = \
>   	drv_hangman \
>   	gem_bad_reloc \
>   	gem_basic \
> +	gem_softpin \
>   	gem_caching \
>   	gem_close_race \
>   	gem_concurrent_blit \
> diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
> new file mode 100644
> index 0000000..86cfaf8
> --- /dev/null
> +++ b/tests/gem_softpin.c
> @@ -0,0 +1,1050 @@
> +/*
> + * Copyright © 2015 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + *
> + * Authors:
> + *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> + *    Thomas Daniel <thomas.daniel@intel.com>
> + *
> + */
> +
> +#include <unistd.h>
> +#include <stdlib.h>
> +#include <stdint.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include <fcntl.h>
> +#include <inttypes.h>
> +#include <errno.h>
> +#include <sys/stat.h>
> +#include <sys/ioctl.h>
> +#include <sys/time.h>
> +#include <malloc.h>
> +#include "drm.h"
> +#include "ioctl_wrappers.h"
> +#include "drmtest.h"
> +#include "intel_chipset.h"
> +#include "intel_io.h"
> +#include "i915_drm.h"
> +#include <assert.h>
> +#include <sys/wait.h>
> +#include <sys/ipc.h>
> +#include <sys/shm.h>
> +#include "igt_kms.h"
> +#include <inttypes.h>
> +#include <sys/types.h>
> +#include <sys/stat.h>
> +
> +#define BO_SIZE 4096
> +#define MULTIPAGE_BO_SIZE 2 * BO_SIZE
> +#define STORE_BATCH_BUFFER_SIZE 4
> +#define EXEC_OBJECT_PINNED	(1<<4)
> +#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
> +#define SHARED_BUFFER_SIZE 4096
> +
> +typedef struct drm_i915_gem_userptr i915_gem_userptr;
> +
> +static uint32_t init_userptr(int fd, i915_gem_userptr *, void *ptr, uint64_t size);
> +static void *create_mem_buffer(uint64_t size);
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
> +static void gem_pin_userptr_test(void);
> +static void gem_pin_bo_test(void);
> +static void gem_pin_invalid_vma_test(void);
> +static void gem_pin_overlap_test(void);
> +static void gem_pin_high_address_test(void);
> +
> +#define NO_PPGTT 0
> +#define ALIASING_PPGTT 1
> +#define FULL_32_BIT_PPGTT 2
> +#define FULL_48_BIT_PPGTT 3
> +/* uses_full_ppgtt
> + * Finds supported PPGTT details.
> + * @fd DRM fd
> + * @min can be
> + * 0 - No PPGTT
> + * 1 - Aliasing PPGTT
> + * 2 - Full PPGTT (32b)
> + * 3 - Full PPGTT (48b)
> + * RETURNS true/false if min support is present
> +*/
> +static bool uses_full_ppgtt(int fd, int min)
> +{
> +	struct drm_i915_getparam gp;
> +	int val = 0;
> +
> +	memset(&gp, 0, sizeof(gp));
> +	gp.param = 18; /* HAS_ALIASING_PPGTT */
> +	gp.value = &val;
> +
> +	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
> +		return 0;
> +
> +	errno = 0;
> +	return val >= min;
> +}
> +
> +
> +/* gem_call_userptr_ioctl
> + * Helper to call ioctl - TODO: move to lib
> + * @fd - drm fd
> + * @userptr - pointer to initialised userptr
> + * RETURNS status of ioctl call
> +*/
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr)
> +{
> +	int ret;
> +
> +	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
> +
> +	if (ret)
> +		ret = errno;
> +
> +	return ret;
> +}
> +
> +/* init_userptr
> + * Helper that inits userptr an returns handle
> + * @fd - drm fd
> + * @userptr - pointer to empty userptr
> + * @ptr - buffer to be shared
> + * @size - size of buffer
> + * @ro - read only flag
> + * RETURNS handle to shared buffer
> +*/
> +static uint32_t init_userptr(int fd, i915_gem_userptr *userptr, void *ptr,
> +			     uint64_t size)
> +{
> +	int ret;
> +
> +	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
> +
> +	userptr->user_ptr = (uint64_t)ptr; /* Need the cast to overcome compiler warning */
> +	userptr->user_size = size;
> +	userptr->flags = 0; /* use synchronized operation */
> +
> +	ret = gem_call_userptr_ioctl(fd, userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	return userptr->handle;
> +}
> +
> +/* create_mem_buffer
> + * Creates a 4K aligned CPU buffer
> + * @size - size of buffer
> + * RETURNS pointer to buffer of @size
> +*/
> +static void *create_mem_buffer(uint64_t size)
> +{
> +	void *addr;
> +	int ret;
> +
> +	ret = posix_memalign(&addr, 4096, size);
> +	igt_assert(ret == 0);
> +
> +	return addr;
> +}
> +
> +/* setup_exec_obj
> + * populate exec object
> + * @exec - exec object
> + * @handle - handle to gem buffer
> + * @flags - any flags
> + * @offset - requested VMA
> +*/
> +static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec,
> +			   uint32_t handle, uint32_t flags,
> +			   uint64_t offset)
> +{
> +	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
> +	exec->handle = handle;
> +	exec->flags = flags;
> +	exec->offset = offset;
> +}
> +
> +/* gem_store_data_svm
> + * populate batch buffer with MI_STORE_DWORD_IMM command
> + * @fd: drm file descriptor
> + * @cmd_buf: batch buffer
> + * @vaddr: destination Virtual address
> + * @data: data to be store at destination
> + * @end: whether to end batch buffer or not
> +*/
> +static int gem_store_data_svm(int fd, uint32_t *cmd_buf, uint64_t vaddr,
> +			      uint32_t data, bool end)
> +{
> +	int i = 0;
> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
> +	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
> +
> +	cmd_buf[i++] = data;
> +	if (end) {
> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	return(i * sizeof(uint32_t));
> +}
> +
> +/* gem_store_data
> + * populate batch buffer with MI_STORE_DWORD_IMM command
> + * This one fills up reloc buffer as well
> + * @fd: drm file descriptor
> + * @cmd_buf: batch buffer
> + * @data: data to be store at destination
> + * @reloc - relocation entry
> + * @end: whether to end batch buffer or not
> +*/
> +static int gem_store_data(int fd, uint32_t *cmd_buf,
> +			  uint32_t handle, uint32_t data,
> +			  struct drm_i915_gem_relocation_entry *reloc,
> +			  bool end)
> +{
> +	int i = 0;
> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 reloc needed */
> +	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 reloc needed */
> +	reloc->offset = 1 * sizeof(uint32_t);
> +	reloc->delta = 0;
> +	reloc->target_handle = handle;
> +	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
> +	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
> +	reloc->presumed_offset = 0;
> +	cmd_buf[i++] = data;
> +	if (end) {
> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	return (i * sizeof(uint32_t));
> +}
> +
> +/* setup_execbuffer
> + * helper for buffer execution
> + * @execbuf - pointer to execbuffer
> + * @exec_object - pointer to exec object2 struct
> + * @ring - ring to be used
> + * @buffer_count - how manu buffers to submit
> + * @batch_length - length of batch buffer
> +*/
> +static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf,
> +			     struct drm_i915_gem_exec_object2 *exec_object,
> +			     int ring, int buffer_count, int batch_length)
> +{
> +	execbuf->buffers_ptr = (uint64_t)exec_object;
> +	execbuf->buffer_count = buffer_count;
> +	execbuf->batch_start_offset = 0;
> +	execbuf->batch_len = batch_length;
> +	execbuf->cliprects_ptr = 0;
> +	execbuf->num_cliprects = 0;
> +	execbuf->DR1 = 0;
> +	execbuf->DR4 = 0;
> +	execbuf->flags = ring;
> +	i915_execbuffer2_set_context_id(*execbuf, 0);
> +	execbuf->rsvd2 = 0;
> +}
> +
> +/* submit_and_sync
> + * Helper function for exec and sync functions
> + * @fd - drm fd
> + * @execbuf - pointer to execbuffer
> + * @batch_buf_handle - batch buffer handle
> +*/
> +static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf,
> +			    uint32_t batch_buf_handle)
> +{
> +	gem_execbuf(fd, execbuf);
> +	gem_sync(fd, batch_buf_handle);
> +}
> +
> +/* gem_userptr_sync
> + * helper for syncing to CPU domain - copy/paste from userblit
> + * @fd - drm fd
> + * @handle - buffer handle to sync
> +*/
> +static void gem_userptr_sync(int fd, uint32_t handle)
> +{
> +	gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
> +}
> +
> +
> +/* gem_pin_userptr_test
> + * This test will create a shared buffer, and create a command
> + * for GPU to write data in it
> + * CPU will read and make sure expected value is obtained
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +static void gem_pin_userptr_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	/* Check if driver pinned the buffer as requested */
> +	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
> +			"\nFailed to pin at requested offset");
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		      "\nCPU read does not match GPU write,\
> +			expected: 0x%x, got: 0x%x\n",
> +			data, shared_buffer[0]);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_bo
> + * This test will test softpinning of a gem buffer object
> + * Malloc a 4K buffer
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000
> + * Submit execbuffer
> + * Verify value pinned offset matches the request
> +*/
> +static void gem_pin_bo_test(void)
> +{
> +	int fd;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, unshared_buf_handle;
> +	struct drm_i915_gem_relocation_entry reloc[4];
> +	int ring, len;
> +	uint32_t value;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create gem buffer */
> +	unshared_buf_handle = gem_create(fd, BO_SIZE);
> +	
> +	/* create command buffer with write command */
> +	len = gem_store_data(fd, batch_buffer, unshared_buf_handle, data,
> +				reloc, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], unshared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +	exec_object2[1].relocation_count = 1;
> +	exec_object2[1].relocs_ptr = (uint64_t)reloc;
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	/* Check if driver pinned the buffer as requested */
> +	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
> +			"\nFailed to pin at requested offset");
> +	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
> +	igt_assert(value == data);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, unshared_buf_handle);
> +	close(fd);
> +}
> +
> +
> +/* gem_multiple_process_test
> + * Run basic test simultaneously with multiple processes
> + * This will test pinning same VA separately in each process
> +
> + * fork();
> + * Execute basic test in parent/child processes
> +*/
> +#define MAX_NUM_PROCESSES 10
> +
> +static void gem_multiple_process_test(void)
> +{
> +	igt_fork(child, MAX_NUM_PROCESSES) {
> +		gem_pin_userptr_test();
> +	}
> +	igt_waitchildren();
> +}
> +
> +
> +/* gem_repin_test
> + * This test tries to repin a buffer at a previously pinned vma
> + * from a different execbuf.
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000 VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +
> + * Create second shared buffer
> + * Follow all steps above
> + * Execpt, for offset, use VMA of first buffer above
> + * Submit execbuffer
> + * Verify value of first DWORD in second shared buffer matches DATA
> +*/
> +static void gem_repin_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	uint32_t *shared_buffer1;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	/* Create gem object */
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set first elements to 0x0 */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE);
> +	shared_buffer[0] = 0x0;
> +	shared_buffer1[0] = 0x0;
> +
> +	/* share with GPU and get handles */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> +					  BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	igt_assert(*shared_buffer == data);
> +
> +	/* Second buffer */
> +	/* create command buffer with write command */
> +	pinning_offset = exec_object2[0].offset;
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	/* Pin at shared_buffer, not shared_buffer1 */
> +	/* We are requesting address where another buffer was pinned previously */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle1,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle1);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	igt_assert(*shared_buffer1 == data);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +
> +/* gem_repin_overlap_test
> + * This test will attempt to pin two buffers at the same VMA as part of the same
> +   execbuffer object
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create second shared buffer
> + * Create batch buffer to write DATA to first dword of each buffer
> + * Use same virtual address as destination addresses in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in both exec objects
> + * Set 'offset' in both exec objects to same VMA
> + * Submit execbuffer
> + * Command should return EINVAL, since we are trying to pin to same VMA
> +*/
> +static void gem_pin_overlap_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd, ret;
> +	uint32_t *shared_buffer;
> +	uint32_t *shared_buffer1;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[3];
> +	uint32_t shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> +					  BO_SIZE * 2);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], shared_buf_handle1,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +
> +	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, &execbuf);
> +
> +	/* expect to fail */
> +	igt_assert_neq(ret, 0);
> +	igt_assert(errno == EINVAL);
> +
> +	close(fd);
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +/* gem_softpin_stress_test
> + * Stress test which creates 10K buffers and shares with GPU
> + * Create 100K uint32 buffers of size 4K each
> + * Share with GPU using userptr ioctl
> + * Create batch buffer to write DATA in first element of each buffer
> + * Pin each buffer to varying addresses starting from 0x800000000000 going below
> + * Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
> + * Validate every buffer has DATA in first element
> + * Rinse and Repeat on Render ring
> +*/
> +#define STRESS_NUM_BUFFERS 100000
> +#define STRESS_NUM_LOOPS 100
> +#define STRESS_STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
> +
> +static void gem_softpin_stress_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t **shared_buffer;
> +	uint32_t *shared_handle;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 *exec_object2;
> +	uint32_t *batch_buffer;
> +	uint32_t batch_buf_handle;
> +	int ring, len;
> +	int buf, loop;
> +	uint64_t pinning_offset = 0x800000000000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +
> +
> +	/* Allocate blobs for all data structures */
> +	shared_handle = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t));
> +	shared_buffer = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t *));
> +	exec_object2 = calloc(STRESS_NUM_BUFFERS + 1,
> +				sizeof(struct drm_i915_gem_exec_object2));
> +	/* 4 dwords per buffer + 2 for the end of batchbuffer */
> +	batch_buffer = calloc(STRESS_STORE_COMMANDS + 2, sizeof(uint32_t));
> +	batch_buf_handle = gem_create(fd, (STRESS_STORE_COMMANDS + 2)*4);
> +
> +	/* create command buffer with write commands */
> +	len = 0;
> +	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +		shared_buffer[buf] = create_mem_buffer(BO_SIZE);
> +		*shared_buffer[buf] = 0xFFFFFFFF;
> +
> +		/* share with GPU */
> +		shared_handle[buf] = init_userptr(fd, &userptr,
> +						  shared_buffer[buf],
> +						  BO_SIZE);
> +
> +		setup_exec_obj(&exec_object2[buf], shared_handle[buf],
> +			       EXEC_OBJECT_PINNED, pinning_offset);
> +		len += gem_store_data_svm(fd, batch_buffer + (len/4),
> +					  pinning_offset, buf,
> +					  (buf == STRESS_NUM_BUFFERS-1)? \
> +					  true:false);
> +		
> +		/* decremental 4K aligned address */
> +		pinning_offset -= ALIGN(BO_SIZE, 4096);
> +	}
> +
> +	/* setup command buffer */
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle,
> +		       0, 0);
> +
> +	/* We want to run this on BLT ring if possible */
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd))) {
> +		ring = I915_EXEC_BLT;
> +
> +		setup_execbuffer(&execbuf, exec_object2, ring,
> +				 STRESS_NUM_BUFFERS + 1, len);
> +
> +		for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
> +			submit_and_sync(fd, &execbuf, batch_buf_handle);
> +			/* Set pinning offset back to original value */
> +			pinning_offset = 0x800000000000;
> +			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +				gem_userptr_sync(fd, shared_handle[buf]);
> +				igt_assert(exec_object2[buf].offset == pinning_offset);
> +				igt_fail_on_f(*shared_buffer[buf] != buf, \
> +				"Mismatch in buffer %d, iteration %d: 0x%08X\n", \
> +				buf, loop, *shared_buffer[buf]);
> +				pinning_offset -= ALIGN(BO_SIZE, 4096);
> +			}
> +			/* Reset the buffer entries for next iteration */
> +			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +				*shared_buffer[buf] = 0xFFFFFFFF;
> +			}
> +		}
> +	}
> +
> +	/* Now Render Ring */
> +	ring = I915_EXEC_RENDER;
> +	setup_execbuffer(&execbuf, exec_object2, ring,
> +			 STRESS_NUM_BUFFERS + 1, len);
> +	for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		pinning_offset = 0x800000000000;
> +		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +			gem_userptr_sync(fd, shared_handle[buf]);
> +			igt_assert(exec_object2[buf].offset == pinning_offset);
> +			igt_fail_on_f(*shared_buffer[buf] != buf, \
> +			"Mismatch in buffer %d, \
> +			iteration %d: 0x%08X\n", buf, loop, *shared_buffer[buf]);
> +			pinning_offset -= ALIGN(BO_SIZE, 4096);
> +		}
> +		/* Reset the buffer entries for next iteration */
> +		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +			*shared_buffer[buf] = 0xFFFFFFFF;
> +		}
> +	}
> +
> +	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +		gem_close(fd, shared_handle[buf]);
> +		free(shared_buffer[buf]);
> +	}
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_handle);
> +	free(shared_buffer);
> +	free(exec_object2);
> +	free(batch_buffer);
> +}
> +
> +/* gem_write_multipage_buffer
> + * Create a buffer spanning multiple pages, and share with GPU.
> + * Write to every element of the buffer
> + * and verify correct contents.
> +
> + * Create 8K buffer
> + * Share with GPU using userptr ioctl
> + * Create batch buffer to write DATA in all elements of buffer
> + * Execute Batch Buffer
> + * Validate every element has DATA
> +*/
> +
> +#define DWORD_SIZE sizeof(uint32_t)
> +#define BB_SIZE ((MULTIPAGE_BO_SIZE / DWORD_SIZE) * STORE_BATCH_BUFFER_SIZE) + 2
> +#define NUM_DWORDS (MULTIPAGE_BO_SIZE/sizeof(uint32_t))
> +static void gem_write_multipage_buffer_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	uint32_t shared_handle;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[BB_SIZE];
> +	uint32_t batch_buf_handle;
> +	int ring, len, j;
> +	uint64_t pinning_offset=0x1000;
> +	uint64_t vaddr;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
> +	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
> +
> +	len = 0;
> +	memset(batch_buffer, 0, sizeof(batch_buffer));
> +	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
> +
> +	/* share with GPU */
> +	shared_handle = init_userptr(fd, &userptr, shared_buffer,
> +				     MULTIPAGE_BO_SIZE);
> +	setup_exec_obj(&exec_object2[0], shared_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +
> +	/* create command buffer with write commands */
> +	vaddr = pinning_offset;
> +	for(j=0; j< NUM_DWORDS; j++) {
> +		len += gem_store_data_svm(fd, batch_buffer + (len/4), vaddr,
> +					  j,
> +					  (j == NUM_DWORDS - 1) ? true:false);
> +		vaddr += sizeof(shared_buffer[0]);  /* 4 bytes */
> +	}
> +
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_handle);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	for(j = 0; j < (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++) {
> +		igt_fail_on_f(shared_buffer[j] != j,
> +		"Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_invalid_vma_test
> + * This test will request to pin a shared buffer to an invalid
> + * VMA  > 48-bit address if system supports 48B PPGTT
> + * If system supports 32B PPGTT, it will test the equivalent invalid VMA
> + * Create shared buffer of size 4K
> + * Try and Pin object to invalid address
> +*/
> +static void gem_pin_invalid_vma_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[1];
> +	uint32_t shared_buf_handle;
> +	int ring;
> +	uint64_t invalid_address_for_48b = 0x9000000000000; /* 52 bit address */
> +	uint64_t invalid_address_for_32b = 0x900000000; /* 36 bit address */
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT) ||
> +		    uses_full_ppgtt(fd, FULL_32_BIT_PPGTT));
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +	
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	if (uses_full_ppgtt(fd, FULL_48_BIT_PPGTT)) {
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED, invalid_address_for_48b);
> +	} else {
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED, invalid_address_for_32b);
> +	}
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 1, 0);
> +
> +	/* Expect execbuf to fail */
> +	ret = drmIoctl(fd,
> +		       DRM_IOCTL_I915_GEM_EXECBUFFER2,
> +		       &execbuf);
> +
> +	igt_assert(errno == ENOSPC);
> +	igt_assert_neq(ret, 0);
> +	
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +
> +/* gem_pin_high_address_test
> + * This test will create a shared buffer, and create a command
> + * for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
> + * CPU will read and make sure expected value is obtained
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use virtual address of buffer as 0x1100000000 (> 32 bit)
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to shared buffer VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> + * Now try same test without using EXEC_OBJECT_PINNED flag
> + * test should fail pinned offset check
> +*/
> +
> +static void gem_pin_high_address_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	igt_assert(exec_object2[0].offset == high_address);
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, \
> +		expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
> +
> +	/* Now try pinning to high address without EXEC_OBJECT_PINNED flag */

I thought here EXEC_OBJECT_PINNED without 
EXEC_OBJECT_SUPPORTS_48B_ADDRESS, to verify that the former really 
implies the latter.

If you change that you can add my r-b.

Regards,

Tvrtko

> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       0, high_address);
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	/* Since we did not request 48B addressing using EXEC_OBJECT_PINNED */
> +	igt_assert(exec_object2[0].offset != high_address);
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_near_48Bit_test
> + * This test will create a shared buffer,
> + * and create a command for GPU to write data in it. It will attempt
> + * to pin the buffer at address > 47 bits <= 48-bit.
> + * CPU will read and make sure expected value is obtained
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use virtual address of buffer as range between 47-bit and 48-bit
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to shared buffer VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000
> +#define END_HIGH_ADDRESS 0xFFFFFFFFC000
> +#define ADDRESS_INCREMENT 0x2000000000
> +static void gem_pin_near_48Bit_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS;
> +						high_address+=ADDRESS_INCREMENT) {
> +		/* create command buffer with write command */
> +		len = gem_store_data_svm(fd, batch_buffer, high_address,
> +					data, true);
> +		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +		/* submit command buffer */
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
> +			       high_address);
> +		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +		ring = I915_EXEC_RENDER;
> +		setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		gem_userptr_sync(fd, shared_buf_handle);
> +
> +		igt_assert(exec_object2[0].offset == high_address);
> +		/* check on CPU to see if value changes */
> +		igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, expected: 0x%x, \
> +		got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	gem_close(fd, shared_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +
> +int main(int argc, char* argv[])
> +{
> +	igt_subtest_init(argc, argv);
> +	igt_skip_on_simulation();
> +
> +	/* All tests need PPGTT support */
> +	igt_subtest("gem_pin_userptr") {
> +		gem_pin_userptr_test();
> +	}
> +	igt_subtest("gem_pin_bo") {
> +		gem_pin_bo_test();
> +	}
> +	igt_subtest("gem_multiple_process") {
> +		gem_multiple_process_test();
> +	}
> +	igt_subtest("gem_repin") {
> +		gem_repin_test();
> +	}
> +	igt_subtest("gem_pin_overlap") {
> +		gem_pin_overlap_test();
> +	}
> +	igt_subtest("gem_write_multipage_buffer") {
> +		gem_write_multipage_buffer_test();
> +	}
> +
> +	/* Following tests need 32/48 Bit PPGTT support */
> +	igt_subtest("gem_pin_invalid_vma") {
> +		gem_pin_invalid_vma_test();
> +	}
> +
> +	/* Following tests need 48 Bit PPGTT support */
> +	igt_subtest("gem_softpin_stress") {
> +		gem_softpin_stress_test();
> +	}
> +	igt_subtest("gem_pin_high_address") {
> +		gem_pin_high_address_test();
> +	}
> +	igt_subtest("gem_pin_near_48Bit") {
> +		gem_pin_near_48Bit_test();
> +	}
> +
> +	igt_exit();
> +}
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
@ 2015-11-30 18:22 Vinay Belgaumkar
  2015-12-01 10:35 ` Tvrtko Ursulin
  0 siblings, 1 reply; 19+ messages in thread
From: Vinay Belgaumkar @ 2015-11-30 18:22 UTC (permalink / raw)
  To: intel-gfx; +Cc: Vinay Belgaumkar

These tests exercise the userptr ioctl to create shared buffers
between CPU and GPU. They contain error and normal usage scenarios.
They also contain a couple of stress tests which copy buffers between
CPU and GPU. These tests rely on the softpin patch in order to pin buffers
to a certain VA.

Caveat: These tests were designed to run on 64-bit system. Future work
includes adding logic to ensure these tests can run on 32-bit systems with
PPGTT support. Some tests are currently disabled for 32-bit systems for that
reason.

v2: Added cc and signed-off-by fields

v3: Fixed review comments, added helper functions. Removed userptr error
scenarios covered by existing userptr tests. Modified stress test to have
100K buffers, it now runs for ~30 mins, checks every element has been written
to correctly, and pins buffers at different VMAs.

v4: Changed name to gem_softpin

v5: More fixes. Removed the file based tests, will move them to userptr tests.
Added a function that validates appropriate PPGTT support before running tests.
Optimized stack space and memory footprint in stress test. Removed the eviction
test, will add it back after verifying proper functionality.

v6: Split basic test into userptr and bo
Fixed some coding style issues.

v7: Enhanced invalid vma pinning test to verify 32-bit PPGTT functionality.
Enabled the test for 32-bit PPGTT systems, and verify pinning fails above
32-bit addresses. Enhanced the high adress pinning test to ensure pinning
fails when EXEC_OBJECT_PINNED flag is not used. Some more cosmetic fixes to
close buffer handles. Changed userptr function to used synchronized operations.

Cc: Michel Thierry <michel.thierry@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
 tests/.gitignore       |    1 +
 tests/Makefile.sources |    1 +
 tests/gem_softpin.c    | 1050 ++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 1052 insertions(+)
 create mode 100644 tests/gem_softpin.c

diff --git a/tests/.gitignore b/tests/.gitignore
index 80af9a7..424870b 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -21,6 +21,7 @@ gem_bad_blit
 gem_bad_length
 gem_bad_reloc
 gem_basic
+gem_softpin
 gem_caching
 gem_close_race
 gem_concurrent_all
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 8fb2de8..2008d4a 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -11,6 +11,7 @@ TESTS_progs_M = \
 	drv_hangman \
 	gem_bad_reloc \
 	gem_basic \
+	gem_softpin \
 	gem_caching \
 	gem_close_race \
 	gem_concurrent_blit \
diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
new file mode 100644
index 0000000..86cfaf8
--- /dev/null
+++ b/tests/gem_softpin.c
@@ -0,0 +1,1050 @@
+/*
+ * Copyright © 2015 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ * Authors:
+ *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
+ *    Thomas Daniel <thomas.daniel@intel.com>
+ *
+ */
+
+#include <unistd.h>
+#include <stdlib.h>
+#include <stdint.h>
+#include <stdio.h>
+#include <string.h>
+#include <fcntl.h>
+#include <inttypes.h>
+#include <errno.h>
+#include <sys/stat.h>
+#include <sys/ioctl.h>
+#include <sys/time.h>
+#include <malloc.h>
+#include "drm.h"
+#include "ioctl_wrappers.h"
+#include "drmtest.h"
+#include "intel_chipset.h"
+#include "intel_io.h"
+#include "i915_drm.h"
+#include <assert.h>
+#include <sys/wait.h>
+#include <sys/ipc.h>
+#include <sys/shm.h>
+#include "igt_kms.h"
+#include <inttypes.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+
+#define BO_SIZE 4096
+#define MULTIPAGE_BO_SIZE 2 * BO_SIZE
+#define STORE_BATCH_BUFFER_SIZE 4
+#define EXEC_OBJECT_PINNED	(1<<4)
+#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
+#define SHARED_BUFFER_SIZE 4096
+
+typedef struct drm_i915_gem_userptr i915_gem_userptr;
+
+static uint32_t init_userptr(int fd, i915_gem_userptr *, void *ptr, uint64_t size);
+static void *create_mem_buffer(uint64_t size);
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
+static void gem_pin_userptr_test(void);
+static void gem_pin_bo_test(void);
+static void gem_pin_invalid_vma_test(void);
+static void gem_pin_overlap_test(void);
+static void gem_pin_high_address_test(void);
+
+#define NO_PPGTT 0
+#define ALIASING_PPGTT 1
+#define FULL_32_BIT_PPGTT 2
+#define FULL_48_BIT_PPGTT 3
+/* uses_full_ppgtt
+ * Finds supported PPGTT details. 
+ * @fd DRM fd
+ * @min can be
+ * 0 - No PPGTT
+ * 1 - Aliasing PPGTT
+ * 2 - Full PPGTT (32b)
+ * 3 - Full PPGTT (48b)
+ * RETURNS true/false if min support is present
+*/
+static bool uses_full_ppgtt(int fd, int min)
+{
+	struct drm_i915_getparam gp;
+	int val = 0;
+
+	memset(&gp, 0, sizeof(gp));
+	gp.param = 18; /* HAS_ALIASING_PPGTT */
+	gp.value = &val;
+
+	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
+		return 0;
+
+	errno = 0;
+	return val >= min;
+}
+
+
+/* gem_call_userptr_ioctl
+ * Helper to call ioctl - TODO: move to lib
+ * @fd - drm fd
+ * @userptr - pointer to initialised userptr
+ * RETURNS status of ioctl call
+*/
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr)
+{
+	int ret;
+
+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
+
+	if (ret)
+		ret = errno;
+
+	return ret;
+}
+
+/* init_userptr
+ * Helper that inits userptr an returns handle
+ * @fd - drm fd
+ * @userptr - pointer to empty userptr
+ * @ptr - buffer to be shared
+ * @size - size of buffer
+ * @ro - read only flag
+ * RETURNS handle to shared buffer
+*/
+static uint32_t init_userptr(int fd, i915_gem_userptr *userptr, void *ptr,
+			     uint64_t size)
+{
+	int ret;
+
+	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
+
+	userptr->user_ptr = (uint64_t)ptr; /* Need the cast to overcome compiler warning */
+	userptr->user_size = size;
+	userptr->flags = 0; /* use synchronized operation */
+
+	ret = gem_call_userptr_ioctl(fd, userptr);
+	igt_assert_eq(ret, 0);
+
+	return userptr->handle;
+}
+
+/* create_mem_buffer 
+ * Creates a 4K aligned CPU buffer 
+ * @size - size of buffer
+ * RETURNS pointer to buffer of @size
+*/
+static void *create_mem_buffer(uint64_t size)
+{
+	void *addr;
+	int ret;
+
+	ret = posix_memalign(&addr, 4096, size);
+	igt_assert(ret == 0);
+
+	return addr;
+}
+
+/* setup_exec_obj 
+ * populate exec object
+ * @exec - exec object
+ * @handle - handle to gem buffer
+ * @flags - any flags
+ * @offset - requested VMA
+*/
+static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec,
+			   uint32_t handle, uint32_t flags,
+			   uint64_t offset)
+{
+	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
+	exec->handle = handle;
+	exec->flags = flags;
+	exec->offset = offset;
+}
+
+/* gem_store_data_svm 
+ * populate batch buffer with MI_STORE_DWORD_IMM command
+ * @fd: drm file descriptor
+ * @cmd_buf: batch buffer
+ * @vaddr: destination Virtual address
+ * @data: data to be store at destination
+ * @end: whether to end batch buffer or not
+*/
+static int gem_store_data_svm(int fd, uint32_t *cmd_buf, uint64_t vaddr,
+			      uint32_t data, bool end)
+{
+	int i = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
+	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
+
+	cmd_buf[i++] = data;
+	if (end) { 
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	return(i * sizeof(uint32_t));
+}
+
+/* gem_store_data 
+ * populate batch buffer with MI_STORE_DWORD_IMM command
+ * This one fills up reloc buffer as well 
+ * @fd: drm file descriptor
+ * @cmd_buf: batch buffer
+ * @data: data to be store at destination
+ * @reloc - relocation entry
+ * @end: whether to end batch buffer or not
+*/
+static int gem_store_data(int fd, uint32_t *cmd_buf,
+			  uint32_t handle, uint32_t data,
+			  struct drm_i915_gem_relocation_entry *reloc,
+			  bool end)
+{
+	int i = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 reloc needed */
+	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 reloc needed */
+	reloc->offset = 1 * sizeof(uint32_t);
+	reloc->delta = 0;
+	reloc->target_handle = handle;
+	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
+	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
+	reloc->presumed_offset = 0;
+	cmd_buf[i++] = data;
+	if (end) { 
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	return (i * sizeof(uint32_t));
+}
+
+/* setup_execbuffer 
+ * helper for buffer execution
+ * @execbuf - pointer to execbuffer
+ * @exec_object - pointer to exec object2 struct
+ * @ring - ring to be used
+ * @buffer_count - how manu buffers to submit
+ * @batch_length - length of batch buffer 
+*/
+static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf,
+			     struct drm_i915_gem_exec_object2 *exec_object,
+			     int ring, int buffer_count, int batch_length)
+{
+	execbuf->buffers_ptr = (uint64_t)exec_object;
+	execbuf->buffer_count = buffer_count;
+	execbuf->batch_start_offset = 0;
+	execbuf->batch_len = batch_length;
+	execbuf->cliprects_ptr = 0;
+	execbuf->num_cliprects = 0;
+	execbuf->DR1 = 0;
+	execbuf->DR4 = 0;
+	execbuf->flags = ring;
+	i915_execbuffer2_set_context_id(*execbuf, 0);
+	execbuf->rsvd2 = 0;
+}
+
+/* submit_and_sync 
+ * Helper function for exec and sync functions 
+ * @fd - drm fd
+ * @execbuf - pointer to execbuffer
+ * @batch_buf_handle - batch buffer handle
+*/
+static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf,
+			    uint32_t batch_buf_handle)
+{
+	gem_execbuf(fd, execbuf);
+	gem_sync(fd, batch_buf_handle); 
+}
+
+/* gem_userptr_sync
+ * helper for syncing to CPU domain - copy/paste from userblit
+ * @fd - drm fd
+ * @handle - buffer handle to sync
+*/
+static void gem_userptr_sync(int fd, uint32_t handle)
+{
+	gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
+}
+
+
+/* gem_pin_userptr_test 
+ * This test will create a shared buffer, and create a command
+ * for GPU to write data in it
+ * CPU will read and make sure expected value is obtained
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+static void gem_pin_userptr_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	/* Check if driver pinned the buffer as requested */
+	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
+			"\nFailed to pin at requested offset");
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		      "\nCPU read does not match GPU write,\
+			expected: 0x%x, got: 0x%x\n", 
+			data, shared_buffer[0]);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/* gem_pin_bo 
+ * This test will test softpinning of a gem buffer object
+ * Malloc a 4K buffer
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000
+ * Submit execbuffer
+ * Verify value pinned offset matches the request
+*/
+static void gem_pin_bo_test(void)
+{
+	int fd;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, unshared_buf_handle;
+	struct drm_i915_gem_relocation_entry reloc[4];
+	int ring, len;
+	uint32_t value;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create gem buffer */
+	unshared_buf_handle = gem_create(fd, BO_SIZE);
+	
+	/* create command buffer with write command */
+	len = gem_store_data(fd, batch_buffer, unshared_buf_handle, data,
+				reloc, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], unshared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+	exec_object2[1].relocation_count = 1;
+	exec_object2[1].relocs_ptr = (uint64_t)reloc;
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	/* Check if driver pinned the buffer as requested */
+	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
+			"\nFailed to pin at requested offset");
+	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
+	igt_assert(value == data);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, unshared_buf_handle);
+	close(fd);
+}
+
+
+/* gem_multiple_process_test 
+ * Run basic test simultaneously with multiple processes
+ * This will test pinning same VA separately in each process
+
+ * fork();
+ * Execute basic test in parent/child processes
+*/
+#define MAX_NUM_PROCESSES 10
+
+static void gem_multiple_process_test(void)
+{
+	igt_fork(child, MAX_NUM_PROCESSES) {
+		gem_pin_userptr_test();
+	}
+	igt_waitchildren();
+}
+
+
+/* gem_repin_test 
+ * This test tries to repin a buffer at a previously pinned vma 
+ * from a different execbuf. 
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000 VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+
+ * Create second shared buffer
+ * Follow all steps above
+ * Execpt, for offset, use VMA of first buffer above 
+ * Submit execbuffer
+ * Verify value of first DWORD in second shared buffer matches DATA
+*/
+static void gem_repin_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd;
+	uint32_t *shared_buffer;
+	uint32_t *shared_buffer1;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	/* Create gem object */
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set first elements to 0x0 */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE);
+	shared_buffer[0] = 0x0;
+	shared_buffer1[0] = 0x0;
+
+	/* share with GPU and get handles */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
+					  BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	igt_assert(*shared_buffer == data);
+
+	/* Second buffer */
+	/* create command buffer with write command */
+	pinning_offset = exec_object2[0].offset;
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	/* Pin at shared_buffer, not shared_buffer1 */
+	/* We are requesting address where another buffer was pinned previously */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle1,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle1);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	igt_assert(*shared_buffer1 == data);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+
+/* gem_repin_overlap_test
+ * This test will attempt to pin two buffers at the same VMA as part of the same
+   execbuffer object
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create second shared buffer
+ * Create batch buffer to write DATA to first dword of each buffer
+ * Use same virtual address as destination addresses in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in both exec objects
+ * Set 'offset' in both exec objects to same VMA
+ * Submit execbuffer
+ * Command should return EINVAL, since we are trying to pin to same VMA
+*/
+static void gem_pin_overlap_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd, ret;
+	uint32_t *shared_buffer;
+	uint32_t *shared_buffer1;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[3];
+	uint32_t shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
+					  BO_SIZE * 2);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], shared_buf_handle1,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+
+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, &execbuf);
+
+	/* expect to fail */
+	igt_assert_neq(ret, 0);
+	igt_assert(errno == EINVAL);
+
+	close(fd);
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+/* gem_softpin_stress_test 
+ * Stress test which creates 10K buffers and shares with GPU 
+ * Create 100K uint32 buffers of size 4K each
+ * Share with GPU using userptr ioctl
+ * Create batch buffer to write DATA in first element of each buffer
+ * Pin each buffer to varying addresses starting from 0x800000000000 going below
+ * Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
+ * Validate every buffer has DATA in first element
+ * Rinse and Repeat on Render ring
+*/
+#define STRESS_NUM_BUFFERS 100000
+#define STRESS_NUM_LOOPS 100
+#define STRESS_STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
+
+static void gem_softpin_stress_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t **shared_buffer;
+	uint32_t *shared_handle;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 *exec_object2;
+	uint32_t *batch_buffer; 
+	uint32_t batch_buf_handle;
+	int ring, len;
+	int buf, loop;
+	uint64_t pinning_offset = 0x800000000000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+
+
+	/* Allocate blobs for all data structures */
+	shared_handle = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t));
+	shared_buffer = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t *));
+	exec_object2 = calloc(STRESS_NUM_BUFFERS + 1, 
+				sizeof(struct drm_i915_gem_exec_object2));
+	/* 4 dwords per buffer + 2 for the end of batchbuffer */
+	batch_buffer = calloc(STRESS_STORE_COMMANDS + 2, sizeof(uint32_t));
+	batch_buf_handle = gem_create(fd, (STRESS_STORE_COMMANDS + 2)*4);
+
+	/* create command buffer with write commands */
+	len = 0;
+	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+		shared_buffer[buf] = create_mem_buffer(BO_SIZE);
+		*shared_buffer[buf] = 0xFFFFFFFF;
+
+		/* share with GPU */
+		shared_handle[buf] = init_userptr(fd, &userptr,
+						  shared_buffer[buf],
+						  BO_SIZE);
+
+		setup_exec_obj(&exec_object2[buf], shared_handle[buf],
+			       EXEC_OBJECT_PINNED, pinning_offset);
+		len += gem_store_data_svm(fd, batch_buffer + (len/4),
+					  pinning_offset, buf,
+					  (buf == STRESS_NUM_BUFFERS-1)? \
+					  true:false);
+		
+		/* decremental 4K aligned address */
+		pinning_offset -= ALIGN(BO_SIZE, 4096);
+	}
+
+	/* setup command buffer */
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle,
+		       0, 0);
+
+	/* We want to run this on BLT ring if possible */
+	if (HAS_BLT_RING(intel_get_drm_devid(fd))) {
+		ring = I915_EXEC_BLT;
+
+		setup_execbuffer(&execbuf, exec_object2, ring,
+				 STRESS_NUM_BUFFERS + 1, len);
+
+		for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
+			submit_and_sync(fd, &execbuf, batch_buf_handle);
+			/* Set pinning offset back to original value */
+			pinning_offset = 0x800000000000;
+			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+				gem_userptr_sync(fd, shared_handle[buf]);
+				igt_assert(exec_object2[buf].offset == pinning_offset);
+				igt_fail_on_f(*shared_buffer[buf] != buf, \
+				"Mismatch in buffer %d, iteration %d: 0x%08X\n", \
+				buf, loop, *shared_buffer[buf]);
+				pinning_offset -= ALIGN(BO_SIZE, 4096);
+			}
+			/* Reset the buffer entries for next iteration */
+			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+				*shared_buffer[buf] = 0xFFFFFFFF;
+			}
+		}
+	}
+
+	/* Now Render Ring */
+	ring = I915_EXEC_RENDER;
+	setup_execbuffer(&execbuf, exec_object2, ring,
+			 STRESS_NUM_BUFFERS + 1, len);
+	for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		pinning_offset = 0x800000000000;
+		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+			gem_userptr_sync(fd, shared_handle[buf]);
+			igt_assert(exec_object2[buf].offset == pinning_offset);
+			igt_fail_on_f(*shared_buffer[buf] != buf, \
+			"Mismatch in buffer %d, \
+			iteration %d: 0x%08X\n", buf, loop, *shared_buffer[buf]);
+			pinning_offset -= ALIGN(BO_SIZE, 4096);
+		}
+		/* Reset the buffer entries for next iteration */
+		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+			*shared_buffer[buf] = 0xFFFFFFFF;
+		}
+	}
+
+	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+		gem_close(fd, shared_handle[buf]);
+		free(shared_buffer[buf]);
+	}
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_handle);
+	free(shared_buffer);
+	free(exec_object2);
+	free(batch_buffer);
+}
+
+/* gem_write_multipage_buffer 
+ * Create a buffer spanning multiple pages, and share with GPU. 
+ * Write to every element of the buffer
+ * and verify correct contents.
+
+ * Create 8K buffer
+ * Share with GPU using userptr ioctl
+ * Create batch buffer to write DATA in all elements of buffer
+ * Execute Batch Buffer
+ * Validate every element has DATA
+*/
+
+#define DWORD_SIZE sizeof(uint32_t)
+#define BB_SIZE ((MULTIPAGE_BO_SIZE / DWORD_SIZE) * STORE_BATCH_BUFFER_SIZE) + 2
+#define NUM_DWORDS (MULTIPAGE_BO_SIZE/sizeof(uint32_t))
+static void gem_write_multipage_buffer_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	uint32_t shared_handle;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[BB_SIZE];
+	uint32_t batch_buf_handle;
+	int ring, len, j;
+	uint64_t pinning_offset=0x1000;
+	uint64_t vaddr;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+
+	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
+	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
+
+	len = 0;
+	memset(batch_buffer, 0, sizeof(batch_buffer));
+	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
+
+	/* share with GPU */
+	shared_handle = init_userptr(fd, &userptr, shared_buffer,
+				     MULTIPAGE_BO_SIZE);
+	setup_exec_obj(&exec_object2[0], shared_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+
+	/* create command buffer with write commands */
+	vaddr = pinning_offset;
+	for(j=0; j< NUM_DWORDS; j++) { 
+		len += gem_store_data_svm(fd, batch_buffer + (len/4), vaddr,
+					  j,
+					  (j == NUM_DWORDS - 1) ? true:false);
+		vaddr += sizeof(shared_buffer[0]);  /* 4 bytes */
+	}
+
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_handle);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	for(j = 0; j < (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++) {
+		igt_fail_on_f(shared_buffer[j] != j,
+		"Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_handle);
+	close(fd);
+
+	free(shared_buffer);
+}
+
+/* gem_pin_invalid_vma_test 
+ * This test will request to pin a shared buffer to an invalid
+ * VMA  > 48-bit address if system supports 48B PPGTT
+ * If system supports 32B PPGTT, it will test the equivalent invalid VMA
+ * Create shared buffer of size 4K
+ * Try and Pin object to invalid address
+*/
+static void gem_pin_invalid_vma_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[1];
+	uint32_t shared_buf_handle;
+	int ring;
+	uint64_t invalid_address_for_48b = 0x9000000000000; /* 52 bit address */
+	uint64_t invalid_address_for_32b = 0x900000000; /* 36 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT) ||
+		    uses_full_ppgtt(fd, FULL_32_BIT_PPGTT));
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+	
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+
+	if (uses_full_ppgtt(fd, FULL_48_BIT_PPGTT)) {
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED, invalid_address_for_48b);
+	} else {
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED, invalid_address_for_32b);
+	}
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 1, 0);
+
+	/* Expect execbuf to fail */
+	ret = drmIoctl(fd,
+		       DRM_IOCTL_I915_GEM_EXECBUFFER2,
+		       &execbuf);
+
+	igt_assert(errno == ENOSPC);
+	igt_assert_neq(ret, 0);
+	
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+
+/* gem_pin_high_address_test 
+ * This test will create a shared buffer, and create a command
+ * for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
+ * CPU will read and make sure expected value is obtained
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use virtual address of buffer as 0x1100000000 (> 32 bit)
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to shared buffer VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+ * Now try same test without using EXEC_OBJECT_PINNED flag
+ * test should fail pinned offset check
+*/
+
+static void gem_pin_high_address_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+ 
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	igt_assert(exec_object2[0].offset == high_address);
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, \
+		expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
+
+	/* Now try pinning to high address without EXEC_OBJECT_PINNED flag */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       0, high_address);
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	/* Since we did not request 48B addressing using EXEC_OBJECT_PINNED */
+	igt_assert(exec_object2[0].offset != high_address);
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/* gem_pin_near_48Bit_test 
+ * This test will create a shared buffer, 
+ * and create a command for GPU to write data in it. It will attempt 
+ * to pin the buffer at address > 47 bits <= 48-bit.
+ * CPU will read and make sure expected value is obtained
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use virtual address of buffer as range between 47-bit and 48-bit
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to shared buffer VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000 
+#define END_HIGH_ADDRESS 0xFFFFFFFFC000
+#define ADDRESS_INCREMENT 0x2000000000
+static void gem_pin_near_48Bit_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+
+	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS;
+						high_address+=ADDRESS_INCREMENT) {
+		/* create command buffer with write command */
+		len = gem_store_data_svm(fd, batch_buffer, high_address,
+					data, true);
+		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+		/* submit command buffer */
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
+			       high_address);
+		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+		ring = I915_EXEC_RENDER;
+		setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		gem_userptr_sync(fd, shared_buf_handle);
+
+		igt_assert(exec_object2[0].offset == high_address);
+		/* check on CPU to see if value changes */
+		igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, expected: 0x%x, \
+		got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	gem_close(fd, shared_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+
+int main(int argc, char* argv[])
+{
+	igt_subtest_init(argc, argv);
+	igt_skip_on_simulation();
+
+	/* All tests need PPGTT support */
+	igt_subtest("gem_pin_userptr") {
+		gem_pin_userptr_test();
+	}
+	igt_subtest("gem_pin_bo") {
+		gem_pin_bo_test();
+	}
+	igt_subtest("gem_multiple_process") {
+		gem_multiple_process_test();
+	}
+	igt_subtest("gem_repin") {
+		gem_repin_test();
+	}
+	igt_subtest("gem_pin_overlap") {
+		gem_pin_overlap_test();
+	}
+	igt_subtest("gem_write_multipage_buffer") {
+		gem_write_multipage_buffer_test();
+	}
+
+	/* Following tests need 32/48 Bit PPGTT support */
+	igt_subtest("gem_pin_invalid_vma") {
+		gem_pin_invalid_vma_test();
+	}
+
+	/* Following tests need 48 Bit PPGTT support */
+	igt_subtest("gem_softpin_stress") {
+		gem_softpin_stress_test();
+	}
+	igt_subtest("gem_pin_high_address") {
+		gem_pin_high_address_test();
+	}
+	igt_subtest("gem_pin_near_48Bit") {
+		gem_pin_near_48Bit_test();
+	}
+
+	igt_exit();
+}
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
  2015-11-29 12:43 Vinay Belgaumkar
@ 2015-11-30 14:16 ` Tvrtko Ursulin
  0 siblings, 0 replies; 19+ messages in thread
From: Tvrtko Ursulin @ 2015-11-30 14:16 UTC (permalink / raw)
  To: Vinay Belgaumkar, intel-gfx


Hi,

On 29/11/15 12:43, Vinay Belgaumkar wrote:
> These tests exercise the userptr ioctl to create shared buffers
> between CPU and GPU. They contain error and normal usage scenarios.
> They also contain a couple of stress tests which copy buffers between
> CPU and GPU. These tests rely on the softpin patch in order to pin buffers
> to a certain VA.
>
> Caveat: These tests were designed to run on 64-bit system. Future work
> includes adding logic to ensure these tests can run on 32-bit systems with
> PPGTT support. Some tests are currently disabled for 32-bit systems for that
> reason.
>
> v2: Added cc and signed-off-by fields
>
> v3: Fixed review comments, added helper functions. Removed userptr error
> scenarios covered by existing userptr tests. Modified stress test to have
> 100K buffers, it now runs for ~30 mins, checks every element has been written
> to correctly, and pins buffers at different VMAs.
>
> v4: Changed name to gem_softpin
>
> v5: More fixes. Removed the file based tests, will move them to userptr tests.
> Added a function that validates appropriate PPGTT support before running tests.
> Optimized stack space and memory footprint in stress test. Removed the eviction
> test, will add it back after verifying proper functionality.
>
> v6: Split basic test into userptr and bo
> Fixed some coding style issues.
>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
>   tests/.gitignore       |    1 +
>   tests/Makefile.sources |    1 +
>   tests/gem_softpin.c    | 1003 ++++++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 1005 insertions(+)
>   create mode 100644 tests/gem_softpin.c
>
> diff --git a/tests/.gitignore b/tests/.gitignore
> index 80af9a7..424870b 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -21,6 +21,7 @@ gem_bad_blit
>   gem_bad_length
>   gem_bad_reloc
>   gem_basic
> +gem_softpin
>   gem_caching
>   gem_close_race
>   gem_concurrent_all
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 8fb2de8..2008d4a 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -11,6 +11,7 @@ TESTS_progs_M = \
>   	drv_hangman \
>   	gem_bad_reloc \
>   	gem_basic \
> +	gem_softpin \
>   	gem_caching \
>   	gem_close_race \
>   	gem_concurrent_blit \
> diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
> new file mode 100644
> index 0000000..7cec732
> --- /dev/null
> +++ b/tests/gem_softpin.c
> @@ -0,0 +1,1003 @@
> +/*
> + * Copyright © 2015 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + *
> + * Authors:
> + *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> + *    Thomas Daniel <thomas.daniel@intel.com>
> + *
> + */
> +
> +#include <unistd.h>
> +#include <stdlib.h>
> +#include <stdint.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include <fcntl.h>
> +#include <inttypes.h>
> +#include <errno.h>
> +#include <sys/stat.h>
> +#include <sys/ioctl.h>
> +#include <sys/time.h>
> +#include <malloc.h>
> +#include "drm.h"
> +#include "ioctl_wrappers.h"
> +#include "drmtest.h"
> +#include "intel_chipset.h"
> +#include "intel_io.h"
> +#include "i915_drm.h"
> +#include <assert.h>
> +#include <sys/wait.h>
> +#include <sys/ipc.h>
> +#include <sys/shm.h>
> +#include "igt_kms.h"
> +#include <inttypes.h>
> +#include <sys/types.h>
> +#include <sys/stat.h>
> +
> +#define BO_SIZE 4096
> +#define MULTIPAGE_BO_SIZE 2 * BO_SIZE
> +#define STORE_BATCH_BUFFER_SIZE 4
> +#define EXEC_OBJECT_PINNED	(1<<4)
> +#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
> +#define SHARED_BUFFER_SIZE 4096
> +
> +typedef struct drm_i915_gem_userptr i915_gem_userptr;
> +
> +static uint32_t init_userptr(int fd, i915_gem_userptr *, void *ptr, uint64_t size);
> +static void *create_mem_buffer(uint64_t size);
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
> +static void gem_pin_userptr_test(void);
> +static void gem_pin_bo_test(void);
> +static void gem_pin_invalid_vma_test(void);
> +static void gem_pin_overlap_test(void);
> +static void gem_pin_high_address_test(void);
> +
> +#define NO_PPGTT 0
> +#define ALIASING_PPGTT 1
> +#define FULL_32_BIT_PPGTT 2
> +#define FULL_48_BIT_PPGTT 3
> +/* uses_full_ppgtt
> + * Finds supported PPGTT details.
> + * @fd DRM fd
> + * @min can be
> + * 0 - No PPGTT
> + * 1 - Aliasing PPGTT
> + * 2 - Full PPGTT (32b)
> + * 3 - Full PPGTT (48b)
> + * RETURNS true/false if min support is present
> +*/
> +static bool uses_full_ppgtt(int fd, int min)
> +{
> +	struct drm_i915_getparam gp;
> +	int val = 0;
> +
> +	memset(&gp, 0, sizeof(gp));
> +	gp.param = 18; /* HAS_ALIASING_PPGTT */
> +	gp.value = &val;
> +
> +	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
> +		return 0;
> +
> +	errno = 0;
> +	return val >= min;
> +}
> +
> +
> +/* gem_call_userptr_ioctl
> + * Helper to call ioctl - TODO: move to lib
> + * @fd - drm fd
> + * @userptr - pointer to initialised userptr
> + * RETURNS status of ioctl call
> +*/
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr)
> +{
> +	int ret;
> +
> +	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
> +
> +	if (ret)
> +		ret = errno;
> +
> +	return ret;
> +}
> +
> +/* init_userptr
> + * Helper that inits userptr an returns handle
> + * @fd - drm fd
> + * @userptr - pointer to empty userptr
> + * @ptr - buffer to be shared
> + * @size - size of buffer
> + * @ro - read only flag
> + * RETURNS handle to shared buffer
> +*/
> +static uint32_t init_userptr(int fd, i915_gem_userptr *userptr, void *ptr,
> +			     uint64_t size)
> +{
> +	int ret;
> +
> +	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
> +
> +	userptr->user_ptr = (uint64_t)ptr; /* Need the cast to overcome compiler warning */
> +	userptr->user_size = size;
> +	userptr->flags = I915_USERPTR_UNSYNCHRONIZED;

To continue on previous iteration, flags == 0 equals to the synchronized 
userptr. Non-root users can't use I915_USERPTR_UNSYNCHRONIZED so that is 
why I suggested synchronized might be better for test coverage.

> +
> +	ret = gem_call_userptr_ioctl(fd, userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	return userptr->handle;
> +}
> +
> +/* create_mem_buffer
> + * Creates a 4K aligned CPU buffer
> + * @size - size of buffer
> + * RETURNS pointer to buffer of @size
> +*/
> +static void *create_mem_buffer(uint64_t size)
> +{
> +	void *addr;
> +	int ret;
> +
> +	ret = posix_memalign(&addr, 4096, size);
> +	igt_assert(ret == 0);
> +
> +	return addr;
> +}
> +
> +/* setup_exec_obj
> + * populate exec object
> + * @exec - exec object
> + * @handle - handle to gem buffer
> + * @flags - any flags
> + * @offset - requested VMA
> +*/
> +static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec,
> +			   uint32_t handle, uint32_t flags,
> +			   uint64_t offset)
> +{
> +	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
> +	exec->handle = handle;
> +	exec->flags = flags;
> +	exec->offset = offset;
> +}
> +
> +/* gem_store_data_svm
> + * populate batch buffer with MI_STORE_DWORD_IMM command
> + * @fd: drm file descriptor
> + * @cmd_buf: batch buffer
> + * @vaddr: destination Virtual address
> + * @data: data to be store at destination
> + * @end: whether to end batch buffer or not
> +*/
> +static int gem_store_data_svm(int fd, uint32_t *cmd_buf, uint64_t vaddr,
> +			      uint32_t data, bool end)
> +{
> +	int i = 0;
> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
> +	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
> +
> +	cmd_buf[i++] = data;
> +	if (end) {
> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	return(i * sizeof(uint32_t));
> +}
> +
> +/* gem_store_data
> + * populate batch buffer with MI_STORE_DWORD_IMM command
> + * This one fills up reloc buffer as well
> + * @fd: drm file descriptor
> + * @cmd_buf: batch buffer
> + * @data: data to be store at destination
> + * @reloc - relocation entry
> + * @end: whether to end batch buffer or not
> +*/
> +static int gem_store_data(int fd, uint32_t *cmd_buf,
> +			  uint32_t handle, uint32_t data,
> +			  struct drm_i915_gem_relocation_entry *reloc,
> +			  bool end)
> +{
> +	int i = 0;
> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 reloc needed */
> +	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 reloc needed */
> +	reloc->offset = 1 * sizeof(uint32_t);
> +	reloc->delta = 0;
> +	reloc->target_handle = handle;
> +	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
> +	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
> +	reloc->presumed_offset = 0;
> +	cmd_buf[i++] = data;
> +	if (end) {
> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	return (i * sizeof(uint32_t));
> +}
> +
> +/* setup_execbuffer
> + * helper for buffer execution
> + * @execbuf - pointer to execbuffer
> + * @exec_object - pointer to exec object2 struct
> + * @ring - ring to be used
> + * @buffer_count - how manu buffers to submit
> + * @batch_length - length of batch buffer
> +*/
> +static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf,
> +			     struct drm_i915_gem_exec_object2 *exec_object,
> +			     int ring, int buffer_count, int batch_length)
> +{
> +	execbuf->buffers_ptr = (uint64_t)exec_object;
> +	execbuf->buffer_count = buffer_count;
> +	execbuf->batch_start_offset = 0;
> +	execbuf->batch_len = batch_length;
> +	execbuf->cliprects_ptr = 0;
> +	execbuf->num_cliprects = 0;
> +	execbuf->DR1 = 0;
> +	execbuf->DR4 = 0;
> +	execbuf->flags = ring;
> +	i915_execbuffer2_set_context_id(*execbuf, 0);
> +	execbuf->rsvd2 = 0;
> +}
> +
> +/* submit_and_sync
> + * Helper function for exec and sync functions
> + * @fd - drm fd
> + * @execbuf - pointer to execbuffer
> + * @batch_buf_handle - batch buffer handle
> +*/
> +static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf,
> +			    uint32_t batch_buf_handle)
> +{
> +	gem_execbuf(fd, execbuf);
> +	gem_sync(fd, batch_buf_handle);
> +}
> +
> +/* gem_userptr_sync
> + * helper for syncing to CPU domain - copy/paste from userblit
> + * @fd - drm fd
> + * @handle - buffer handle to sync
> +*/
> +static void gem_userptr_sync(int fd, uint32_t handle)
> +{
> +	gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
> +}
> +
> +
> +/* gem_pin_userptr_test
> + * This test will create a shared buffer, and create a command
> + * for GPU to write data in it
> + * CPU will read and make sure expected value is obtained
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +static void gem_pin_userptr_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	/* Check if driver pinned the buffer as requested */
> +	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
> +			"\nFailed to pin at requested offset");
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		      "\nCPU read does not match GPU write,\
> +			expected: 0x%x, got: 0x%x\n",
> +			data, shared_buffer[0]);
> +
> +	gem_close(fd, batch_buf_handle);

Could close the shared_buf_handle as well, although it does not matter 
hugely since you are closing the fd anyway. Just better for consistency 
of the code I suppose.

> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_bo
> + * This test will test softpinning of a gem buffer object
> + * Malloc a 4K buffer
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000
> + * Submit execbuffer
> + * Verify value pinned offset matches the request
> +*/
> +static void gem_pin_bo_test(void)
> +{
> +	int fd;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, unshared_buf_handle;
> +	struct drm_i915_gem_relocation_entry reloc[4];
> +	int ring, len;
> +	uint32_t value;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create gem buffer */
> +	unshared_buf_handle = gem_create(fd, BO_SIZE);
> +	
> +	/* create command buffer with write command */
> +	len = gem_store_data(fd, batch_buffer, unshared_buf_handle, data,
> +				reloc, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], unshared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +	exec_object2[1].relocation_count = 1;
> +	exec_object2[1].relocs_ptr = (uint64_t)reloc;
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +
> +	/* Check if driver pinned the buffer as requested */
> +	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
> +			"\nFailed to pin at requested offset");
> +	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
> +	igt_assert(value == data);
> +
> +	gem_close(fd, batch_buf_handle);

Same comment about closing the handle as above.

> +	close(fd);
> +}
> +
> +
> +/* gem_multiple_process_test
> + * Run basic test simultaneously with multiple processes
> + * This will test pinning same VA separately in each process
> +
> + * fork();
> + * Execute basic test in parent/child processes
> +*/
> +#define MAX_NUM_PROCESSES 10
> +
> +static void gem_multiple_process_test(void)
> +{
> +	igt_fork(child, MAX_NUM_PROCESSES) {
> +		gem_pin_userptr_test();
> +	}
> +	igt_waitchildren();
> +}
> +
> +
> +/* gem_repin_test
> + * This test tries to repin a buffer at a previously pinned vma
> + * from a different execbuf.
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000 VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +
> + * Create second shared buffer
> + * Follow all steps above
> + * Execpt, for offset, use VMA of first buffer above
> + * Submit execbuffer
> + * Verify value of first DWORD in second shared buffer matches DATA
> +*/
> +static void gem_repin_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	uint32_t *shared_buffer1;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	/* Create gem object */
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set first elements to 0x0 */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE);
> +	shared_buffer[0] = 0x0;
> +	shared_buffer1[0] = 0x0;
> +
> +	/* share with GPU and get handles */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> +					  BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	igt_assert(*shared_buffer == data);
> +
> +	/* Second buffer */
> +	/* create command buffer with write command */
> +	pinning_offset = exec_object2[0].offset;
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	/* Pin at shared_buffer, not shared_buffer1 */
> +	/* We are requesting address where another buffer was pinned previously */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle1,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle1);
> +
> +	igt_assert(exec_object2[0].offset == pinning_offset);
> +	igt_assert(*shared_buffer1 == data);
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +
> +/* gem_repin_overlap_test
> + * This test will attempt to pin two buffers at the same VMA as part of the same
> +   execbuffer object
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create second shared buffer
> + * Create batch buffer to write DATA to first dword of each buffer
> + * Use same virtual address as destination addresses in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in both exec objects
> + * Set 'offset' in both exec objects to same VMA
> + * Submit execbuffer
> + * Command should return EINVAL, since we are trying to pin to same VMA
> +*/
> +static void gem_pin_overlap_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd, ret;
> +	uint32_t *shared_buffer;
> +	uint32_t *shared_buffer1;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[3];
> +	uint32_t shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +					 BO_SIZE);
> +	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> +					  BO_SIZE * 2);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], shared_buf_handle1,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +
> +	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, &execbuf);
> +
> +	/* expect to fail */
> +	igt_assert_neq(ret, 0);
> +	igt_assert(errno == EINVAL);
> +
> +	close(fd);
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +/* gem_softpin_stress_test
> + * Stress test which creates 10K buffers and shares with GPU
> + * Create 100K uint32 buffers of size 4K each
> + * Share with GPU using userptr ioctl
> + * Create batch buffer to write DATA in first element of each buffer
> + * Pin each buffer to varying addresses starting from 0x800000000000 going below
> + * Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
> + * Validate every buffer has DATA in first element
> + * Rinse and Repeat on Render ring
> +*/
> +#define STRESS_NUM_BUFFERS 100000
> +#define STRESS_NUM_LOOPS 100
> +#define STRESS_STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
> +
> +static void gem_softpin_stress_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t **shared_buffer;
> +	uint32_t *shared_handle;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 *exec_object2;
> +	uint32_t *batch_buffer;
> +	uint32_t batch_buf_handle;
> +	int ring, len;
> +	int buf, loop;
> +	uint64_t pinning_offset = 0x800000000000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +
> +
> +	/* Allocate blobs for all data structures */
> +	shared_handle = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t));
> +	shared_buffer = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t *));
> +	exec_object2 = calloc(STRESS_NUM_BUFFERS + 1,
> +				sizeof(struct drm_i915_gem_exec_object2));
> +	/* 4 dwords per buffer + 2 for the end of batchbuffer */
> +	batch_buffer = calloc(STRESS_STORE_COMMANDS + 2, sizeof(uint32_t));
> +	batch_buf_handle = gem_create(fd, (STRESS_STORE_COMMANDS + 2)*4);
> +
> +	/* create command buffer with write commands */
> +	len = 0;
> +	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +		shared_buffer[buf] = create_mem_buffer(BO_SIZE);
> +		*shared_buffer[buf] = 0xFFFFFFFF;
> +
> +		/* share with GPU */
> +		shared_handle[buf] = init_userptr(fd, &userptr,
> +						  shared_buffer[buf],
> +						  BO_SIZE);
> +
> +		setup_exec_obj(&exec_object2[buf], shared_handle[buf],
> +			       EXEC_OBJECT_PINNED, pinning_offset);
> +		len += gem_store_data_svm(fd, batch_buffer + (len/4),
> +					  pinning_offset, buf,
> +					  (buf == STRESS_NUM_BUFFERS-1)? \
> +					  true:false);
> +		
> +		/* decremental 4K aligned address */
> +		pinning_offset -= ALIGN(BO_SIZE, 4096);
> +	}
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle,
> +		       0, 0);
> +
> +	/* We want to run this on BLT ring if possible */
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd))) {
> +		ring = I915_EXEC_BLT;
> +
> +		setup_execbuffer(&execbuf, exec_object2, ring,
> +				 STRESS_NUM_BUFFERS + 1, len);
> +
> +		for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
> +			submit_and_sync(fd, &execbuf, batch_buf_handle);
> +			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +				gem_userptr_sync(fd, shared_handle[buf]);

I recommend adding the offset assert here as well.

> +				igt_fail_on_f(*shared_buffer[buf] != buf, \
> +				"Mismatch in buffer %d, iteration %d: 0x%08X\n", \
> +				buf, loop, *shared_buffer[buf]);
> +			}
> +		}
> +	}
> +
> +	/* Now Render Ring */
> +	ring = I915_EXEC_RENDER;
> +	execbuf.flags = ring;
> +	setup_execbuffer(&execbuf, exec_object2, ring,
> +			 STRESS_NUM_BUFFERS + 1, len);
> +	for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +			gem_userptr_sync(fd, shared_handle[buf]);

And here.

> +			igt_fail_on_f(*shared_buffer[buf] != buf, \
> +			"Mismatch in buffer %d, \
> +			iteration %d: 0x%08X\n", buf, loop, *shared_buffer[buf]);
> +		}
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	for(loop = 0; loop < STRESS_NUM_BUFFERS; loop++) {
> +		free(shared_buffer[loop]);
> +	}
> +
> +	free(shared_handle);
> +	free(shared_buffer);
> +	free(exec_object2);
> +	free(batch_buffer);
> +}
> +
> +/* gem_write_multipage_buffer
> + * Create a buffer spanning multiple pages, and share with GPU.
> + * Write to every element of the buffer
> + * and verify correct contents.
> +
> + * Create 8K buffer
> + * Share with GPU using userptr ioctl
> + * Create batch buffer to write DATA in all elements of buffer
> + * Execute Batch Buffer
> + * Validate every element has DATA
> +*/
> +
> +#define DWORD_SIZE sizeof(uint32_t)
> +#define BB_SIZE ((MULTIPAGE_BO_SIZE / DWORD_SIZE) * STORE_BATCH_BUFFER_SIZE) + 2
> +#define NUM_DWORDS (MULTIPAGE_BO_SIZE/sizeof(uint32_t))
> +static void gem_write_multipage_buffer_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	uint32_t shared_handle;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[BB_SIZE];
> +	uint32_t batch_buf_handle;
> +	int ring, len, j;
> +	uint64_t pinning_offset=0x1000;
> +	uint64_t vaddr;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
> +	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
> +
> +	len = 0;
> +	memset(batch_buffer, 0, sizeof(batch_buffer));
> +	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
> +
> +	/* share with GPU */
> +	shared_handle = init_userptr(fd, &userptr, shared_buffer,
> +				     MULTIPAGE_BO_SIZE);
> +	setup_exec_obj(&exec_object2[0], shared_handle,
> +		       EXEC_OBJECT_PINNED, pinning_offset);
> +
> +	/* create command buffer with write commands */
> +	vaddr = pinning_offset;
> +	for(j=0; j< NUM_DWORDS; j++) {
> +		len += gem_store_data_svm(fd, batch_buffer + (len/4), vaddr,
> +					  j,
> +					  (j == NUM_DWORDS - 1) ? true:false);
> +		vaddr += sizeof(shared_buffer[0]);  /* 4 bytes */
> +	}
> +
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_handle);
> +

And offset assert here.

> +	for(j = 0; j < (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++) {
> +		igt_fail_on_f(shared_buffer[j] != j,
> +		"Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_invalid_vma_test
> + * This test will request to pin a shared buffer to an invalid
> + * VMA  > 48-bit address
> + * Create shared buffer of size 4K
> + * Try and Pin object to address 0x9000000000000
> +*/
> +static void gem_pin_invalid_vma_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[1];
> +	uint32_t shared_buf_handle;
> +	int ring;
> +	uint64_t invalid_address = 0x9000000000000; /* 52 bit address */

Ok if you say EXEC_OBJECT_PINNED turns on 48-bit support automatically 
then I think two things.

First that needs to be tested - it looks like gem_pin_high_address_test 
could be extended or duplicated to try its thing 2nd time without 
setting the EXEC_OBJECT_SUPPORTS_48B_ADDRESS flag.

Second, we need a negative test case on platforms which do not support 
48-bit PPGTT. So >32-bit && <48-bit attempted pinning and appropriate 
igt_require(uses_full_ppgtt(...)). This is like invalid_vma test but for 
32-bit ppgtt platforms.

I think we need these two in the first go, while the additional overlap 
scenarios can come later.

> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +	
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED, invalid_address);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 1, 0);
> +
> +	/* Expect execbuf to fail */
> +	ret = drmIoctl(fd,
> +		       DRM_IOCTL_I915_GEM_EXECBUFFER2,
> +		       &execbuf);
> +
> +	igt_assert(errno == ENOSPC);

Hm kernel is returning ENOSPC for unsupported offsets? Strange choice. I 
have to find the kernel patch in the mailing list and comment there. :)

> +	igt_assert_neq(ret, 0);
> +	
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +
> +/* gem_pin_high_address_test
> + * This test will create a shared buffer, and create a command
> + * for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
> + * CPU will read and make sure expected value is obtained
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use virtual address of buffer as 0x1100000000 (> 32 bit)
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to shared buffer VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +
> +static void gem_pin_high_address_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +

Offset assert please.

> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, \
> +		expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_near_48Bit_test
> + * This test will create a shared buffer,
> + * and create a command for GPU to write data in it. It will attempt
> + * to pin the buffer at address > 47 bits <= 48-bit.
> + * CPU will read and make sure expected value is obtained
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use virtual address of buffer as range between 47-bit and 48-bit
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to shared buffer VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000
> +#define END_HIGH_ADDRESS 0xFFFFFFFFC000
> +#define ADDRESS_INCREMENT 0x2000000000
> +static void gem_pin_near_48Bit_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t *shared_buffer;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[2];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
> +
> +	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS;
> +						high_address+=ADDRESS_INCREMENT) {
> +		/* create command buffer with write command */
> +		len = gem_store_data_svm(fd, batch_buffer, high_address,
> +					data, true);
> +		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +		/* submit command buffer */
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
> +			       high_address);
> +		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +		ring = I915_EXEC_RENDER;
> +		setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		gem_userptr_sync(fd, shared_buf_handle);
> +

Offset assert here as well.

> +		/* check on CPU to see if value changes */
> +		igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, expected: 0x%x, \
> +		got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +
> +int main(int argc, char* argv[])
> +{
> +	igt_subtest_init(argc, argv);
> +	igt_skip_on_simulation();
> +
> +	/* All tests need PPGTT support */
> +	igt_subtest("gem_pin_userptr") {
> +		gem_pin_userptr_test();
> +	}
> +	igt_subtest("gem_pin_bo") {
> +		gem_pin_bo_test();
> +	}
> +	igt_subtest("gem_multiple_process") {
> +		gem_multiple_process_test();
> +	}
> +	igt_subtest("gem_repin") {
> +		gem_repin_test();
> +	}
> +	igt_subtest("gem_pin_overlap") {
> +		gem_pin_overlap_test();
> +	}
> +	igt_subtest("gem_write_multipage_buffer") {
> +		gem_write_multipage_buffer_test();
> +	}
> +
> +	/* Following tests need 48 Bit PPGTT support */
> +	igt_subtest("gem_pin_invalid_vma") {
> +		gem_pin_invalid_vma_test();
> +	}
> +	igt_subtest("gem_softpin_stress") {
> +		gem_softpin_stress_test();
> +	}
> +	igt_subtest("gem_pin_high_address") {
> +		gem_pin_high_address_test();
> +	}
> +	igt_subtest("gem_pin_near_48Bit") {
> +		gem_pin_near_48Bit_test();
> +	}
> +
> +	igt_exit();
> +}
>

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
@ 2015-11-29 12:43 Vinay Belgaumkar
  2015-11-30 14:16 ` Tvrtko Ursulin
  0 siblings, 1 reply; 19+ messages in thread
From: Vinay Belgaumkar @ 2015-11-29 12:43 UTC (permalink / raw)
  To: intel-gfx; +Cc: Vinay Belgaumkar

These tests exercise the userptr ioctl to create shared buffers
between CPU and GPU. They contain error and normal usage scenarios.
They also contain a couple of stress tests which copy buffers between
CPU and GPU. These tests rely on the softpin patch in order to pin buffers
to a certain VA.

Caveat: These tests were designed to run on 64-bit system. Future work
includes adding logic to ensure these tests can run on 32-bit systems with
PPGTT support. Some tests are currently disabled for 32-bit systems for that
reason.

v2: Added cc and signed-off-by fields

v3: Fixed review comments, added helper functions. Removed userptr error
scenarios covered by existing userptr tests. Modified stress test to have
100K buffers, it now runs for ~30 mins, checks every element has been written
to correctly, and pins buffers at different VMAs.

v4: Changed name to gem_softpin

v5: More fixes. Removed the file based tests, will move them to userptr tests.
Added a function that validates appropriate PPGTT support before running tests.
Optimized stack space and memory footprint in stress test. Removed the eviction
test, will add it back after verifying proper functionality.

v6: Split basic test into userptr and bo
Fixed some coding style issues.

Cc: Michel Thierry <michel.thierry@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
 tests/.gitignore       |    1 +
 tests/Makefile.sources |    1 +
 tests/gem_softpin.c    | 1003 ++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 1005 insertions(+)
 create mode 100644 tests/gem_softpin.c

diff --git a/tests/.gitignore b/tests/.gitignore
index 80af9a7..424870b 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -21,6 +21,7 @@ gem_bad_blit
 gem_bad_length
 gem_bad_reloc
 gem_basic
+gem_softpin
 gem_caching
 gem_close_race
 gem_concurrent_all
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 8fb2de8..2008d4a 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -11,6 +11,7 @@ TESTS_progs_M = \
 	drv_hangman \
 	gem_bad_reloc \
 	gem_basic \
+	gem_softpin \
 	gem_caching \
 	gem_close_race \
 	gem_concurrent_blit \
diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
new file mode 100644
index 0000000..7cec732
--- /dev/null
+++ b/tests/gem_softpin.c
@@ -0,0 +1,1003 @@
+/*
+ * Copyright © 2015 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ * Authors:
+ *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
+ *    Thomas Daniel <thomas.daniel@intel.com>
+ *
+ */
+
+#include <unistd.h>
+#include <stdlib.h>
+#include <stdint.h>
+#include <stdio.h>
+#include <string.h>
+#include <fcntl.h>
+#include <inttypes.h>
+#include <errno.h>
+#include <sys/stat.h>
+#include <sys/ioctl.h>
+#include <sys/time.h>
+#include <malloc.h>
+#include "drm.h"
+#include "ioctl_wrappers.h"
+#include "drmtest.h"
+#include "intel_chipset.h"
+#include "intel_io.h"
+#include "i915_drm.h"
+#include <assert.h>
+#include <sys/wait.h>
+#include <sys/ipc.h>
+#include <sys/shm.h>
+#include "igt_kms.h"
+#include <inttypes.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+
+#define BO_SIZE 4096
+#define MULTIPAGE_BO_SIZE 2 * BO_SIZE
+#define STORE_BATCH_BUFFER_SIZE 4
+#define EXEC_OBJECT_PINNED	(1<<4)
+#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
+#define SHARED_BUFFER_SIZE 4096
+
+typedef struct drm_i915_gem_userptr i915_gem_userptr;
+
+static uint32_t init_userptr(int fd, i915_gem_userptr *, void *ptr, uint64_t size);
+static void *create_mem_buffer(uint64_t size);
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
+static void gem_pin_userptr_test(void);
+static void gem_pin_bo_test(void);
+static void gem_pin_invalid_vma_test(void);
+static void gem_pin_overlap_test(void);
+static void gem_pin_high_address_test(void);
+
+#define NO_PPGTT 0
+#define ALIASING_PPGTT 1
+#define FULL_32_BIT_PPGTT 2
+#define FULL_48_BIT_PPGTT 3
+/* uses_full_ppgtt
+ * Finds supported PPGTT details. 
+ * @fd DRM fd
+ * @min can be
+ * 0 - No PPGTT
+ * 1 - Aliasing PPGTT
+ * 2 - Full PPGTT (32b)
+ * 3 - Full PPGTT (48b)
+ * RETURNS true/false if min support is present
+*/
+static bool uses_full_ppgtt(int fd, int min)
+{
+	struct drm_i915_getparam gp;
+	int val = 0;
+
+	memset(&gp, 0, sizeof(gp));
+	gp.param = 18; /* HAS_ALIASING_PPGTT */
+	gp.value = &val;
+
+	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
+		return 0;
+
+	errno = 0;
+	return val >= min;
+}
+
+
+/* gem_call_userptr_ioctl
+ * Helper to call ioctl - TODO: move to lib
+ * @fd - drm fd
+ * @userptr - pointer to initialised userptr
+ * RETURNS status of ioctl call
+*/
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr)
+{
+	int ret;
+
+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
+
+	if (ret)
+		ret = errno;
+
+	return ret;
+}
+
+/* init_userptr
+ * Helper that inits userptr an returns handle
+ * @fd - drm fd
+ * @userptr - pointer to empty userptr
+ * @ptr - buffer to be shared
+ * @size - size of buffer
+ * @ro - read only flag
+ * RETURNS handle to shared buffer
+*/
+static uint32_t init_userptr(int fd, i915_gem_userptr *userptr, void *ptr,
+			     uint64_t size)
+{
+	int ret;
+
+	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
+
+	userptr->user_ptr = (uint64_t)ptr; /* Need the cast to overcome compiler warning */
+	userptr->user_size = size;
+	userptr->flags = I915_USERPTR_UNSYNCHRONIZED;
+
+	ret = gem_call_userptr_ioctl(fd, userptr);
+	igt_assert_eq(ret, 0);
+
+	return userptr->handle;
+}
+
+/* create_mem_buffer 
+ * Creates a 4K aligned CPU buffer 
+ * @size - size of buffer
+ * RETURNS pointer to buffer of @size
+*/
+static void *create_mem_buffer(uint64_t size)
+{
+	void *addr;
+	int ret;
+
+	ret = posix_memalign(&addr, 4096, size);
+	igt_assert(ret == 0);
+
+	return addr;
+}
+
+/* setup_exec_obj 
+ * populate exec object
+ * @exec - exec object
+ * @handle - handle to gem buffer
+ * @flags - any flags
+ * @offset - requested VMA
+*/
+static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec,
+			   uint32_t handle, uint32_t flags,
+			   uint64_t offset)
+{
+	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
+	exec->handle = handle;
+	exec->flags = flags;
+	exec->offset = offset;
+}
+
+/* gem_store_data_svm 
+ * populate batch buffer with MI_STORE_DWORD_IMM command
+ * @fd: drm file descriptor
+ * @cmd_buf: batch buffer
+ * @vaddr: destination Virtual address
+ * @data: data to be store at destination
+ * @end: whether to end batch buffer or not
+*/
+static int gem_store_data_svm(int fd, uint32_t *cmd_buf, uint64_t vaddr,
+			      uint32_t data, bool end)
+{
+	int i = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
+	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
+
+	cmd_buf[i++] = data;
+	if (end) { 
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	return(i * sizeof(uint32_t));
+}
+
+/* gem_store_data 
+ * populate batch buffer with MI_STORE_DWORD_IMM command
+ * This one fills up reloc buffer as well 
+ * @fd: drm file descriptor
+ * @cmd_buf: batch buffer
+ * @data: data to be store at destination
+ * @reloc - relocation entry
+ * @end: whether to end batch buffer or not
+*/
+static int gem_store_data(int fd, uint32_t *cmd_buf,
+			  uint32_t handle, uint32_t data,
+			  struct drm_i915_gem_relocation_entry *reloc,
+			  bool end)
+{
+	int i = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 reloc needed */
+	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 reloc needed */
+	reloc->offset = 1 * sizeof(uint32_t);
+	reloc->delta = 0;
+	reloc->target_handle = handle;
+	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
+	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
+	reloc->presumed_offset = 0;
+	cmd_buf[i++] = data;
+	if (end) { 
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	return (i * sizeof(uint32_t));
+}
+
+/* setup_execbuffer 
+ * helper for buffer execution
+ * @execbuf - pointer to execbuffer
+ * @exec_object - pointer to exec object2 struct
+ * @ring - ring to be used
+ * @buffer_count - how manu buffers to submit
+ * @batch_length - length of batch buffer 
+*/
+static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf,
+			     struct drm_i915_gem_exec_object2 *exec_object,
+			     int ring, int buffer_count, int batch_length)
+{
+	execbuf->buffers_ptr = (uint64_t)exec_object;
+	execbuf->buffer_count = buffer_count;
+	execbuf->batch_start_offset = 0;
+	execbuf->batch_len = batch_length;
+	execbuf->cliprects_ptr = 0;
+	execbuf->num_cliprects = 0;
+	execbuf->DR1 = 0;
+	execbuf->DR4 = 0;
+	execbuf->flags = ring;
+	i915_execbuffer2_set_context_id(*execbuf, 0);
+	execbuf->rsvd2 = 0;
+}
+
+/* submit_and_sync 
+ * Helper function for exec and sync functions 
+ * @fd - drm fd
+ * @execbuf - pointer to execbuffer
+ * @batch_buf_handle - batch buffer handle
+*/
+static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf,
+			    uint32_t batch_buf_handle)
+{
+	gem_execbuf(fd, execbuf);
+	gem_sync(fd, batch_buf_handle); 
+}
+
+/* gem_userptr_sync
+ * helper for syncing to CPU domain - copy/paste from userblit
+ * @fd - drm fd
+ * @handle - buffer handle to sync
+*/
+static void gem_userptr_sync(int fd, uint32_t handle)
+{
+	gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
+}
+
+
+/* gem_pin_userptr_test 
+ * This test will create a shared buffer, and create a command
+ * for GPU to write data in it
+ * CPU will read and make sure expected value is obtained
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+static void gem_pin_userptr_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	/* Check if driver pinned the buffer as requested */
+	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
+			"\nFailed to pin at requested offset");
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		      "\nCPU read does not match GPU write,\
+			expected: 0x%x, got: 0x%x\n", 
+			data, shared_buffer[0]);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/* gem_pin_bo 
+ * This test will test softpinning of a gem buffer object
+ * Malloc a 4K buffer
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000
+ * Submit execbuffer
+ * Verify value pinned offset matches the request
+*/
+static void gem_pin_bo_test(void)
+{
+	int fd;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, unshared_buf_handle;
+	struct drm_i915_gem_relocation_entry reloc[4];
+	int ring, len;
+	uint32_t value;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create gem buffer */
+	unshared_buf_handle = gem_create(fd, BO_SIZE);
+	
+	/* create command buffer with write command */
+	len = gem_store_data(fd, batch_buffer, unshared_buf_handle, data,
+				reloc, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], unshared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+	exec_object2[1].relocation_count = 1;
+	exec_object2[1].relocs_ptr = (uint64_t)reloc;
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+
+	/* Check if driver pinned the buffer as requested */
+	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
+			"\nFailed to pin at requested offset");
+	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
+	igt_assert(value == data);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+}
+
+
+/* gem_multiple_process_test 
+ * Run basic test simultaneously with multiple processes
+ * This will test pinning same VA separately in each process
+
+ * fork();
+ * Execute basic test in parent/child processes
+*/
+#define MAX_NUM_PROCESSES 10
+
+static void gem_multiple_process_test(void)
+{
+	igt_fork(child, MAX_NUM_PROCESSES) {
+		gem_pin_userptr_test();
+	}
+	igt_waitchildren();
+}
+
+
+/* gem_repin_test 
+ * This test tries to repin a buffer at a previously pinned vma 
+ * from a different execbuf. 
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000 VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+
+ * Create second shared buffer
+ * Follow all steps above
+ * Execpt, for offset, use VMA of first buffer above 
+ * Submit execbuffer
+ * Verify value of first DWORD in second shared buffer matches DATA
+*/
+static void gem_repin_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd;
+	uint32_t *shared_buffer;
+	uint32_t *shared_buffer1;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	/* Create gem object */
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set first elements to 0x0 */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE);
+	shared_buffer[0] = 0x0;
+	shared_buffer1[0] = 0x0;
+
+	/* share with GPU and get handles */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
+					  BO_SIZE);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	igt_assert(*shared_buffer == data);
+
+	/* Second buffer */
+	/* create command buffer with write command */
+	pinning_offset = exec_object2[0].offset;
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	/* Pin at shared_buffer, not shared_buffer1 */
+	/* We are requesting address where another buffer was pinned previously */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle1,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle1);
+
+	igt_assert(exec_object2[0].offset == pinning_offset);
+	igt_assert(*shared_buffer1 == data);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+
+/* gem_repin_overlap_test
+ * This test will attempt to pin two buffers at the same VMA as part of the same
+   execbuffer object
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create second shared buffer
+ * Create batch buffer to write DATA to first dword of each buffer
+ * Use same virtual address as destination addresses in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in both exec objects
+ * Set 'offset' in both exec objects to same VMA
+ * Submit execbuffer
+ * Command should return EINVAL, since we are trying to pin to same VMA
+*/
+static void gem_pin_overlap_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd, ret;
+	uint32_t *shared_buffer;
+	uint32_t *shared_buffer1;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[3];
+	uint32_t shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
+					 BO_SIZE);
+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
+					  BO_SIZE * 2);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], shared_buf_handle1,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+
+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, &execbuf);
+
+	/* expect to fail */
+	igt_assert_neq(ret, 0);
+	igt_assert(errno == EINVAL);
+
+	close(fd);
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+/* gem_softpin_stress_test 
+ * Stress test which creates 10K buffers and shares with GPU 
+ * Create 100K uint32 buffers of size 4K each
+ * Share with GPU using userptr ioctl
+ * Create batch buffer to write DATA in first element of each buffer
+ * Pin each buffer to varying addresses starting from 0x800000000000 going below
+ * Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
+ * Validate every buffer has DATA in first element
+ * Rinse and Repeat on Render ring
+*/
+#define STRESS_NUM_BUFFERS 100000
+#define STRESS_NUM_LOOPS 100
+#define STRESS_STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
+
+static void gem_softpin_stress_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t **shared_buffer;
+	uint32_t *shared_handle;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 *exec_object2;
+	uint32_t *batch_buffer; 
+	uint32_t batch_buf_handle;
+	int ring, len;
+	int buf, loop;
+	uint64_t pinning_offset = 0x800000000000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+
+
+	/* Allocate blobs for all data structures */
+	shared_handle = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t));
+	shared_buffer = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t *));
+	exec_object2 = calloc(STRESS_NUM_BUFFERS + 1, 
+				sizeof(struct drm_i915_gem_exec_object2));
+	/* 4 dwords per buffer + 2 for the end of batchbuffer */
+	batch_buffer = calloc(STRESS_STORE_COMMANDS + 2, sizeof(uint32_t));
+	batch_buf_handle = gem_create(fd, (STRESS_STORE_COMMANDS + 2)*4);
+
+	/* create command buffer with write commands */
+	len = 0;
+	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+		shared_buffer[buf] = create_mem_buffer(BO_SIZE);
+		*shared_buffer[buf] = 0xFFFFFFFF;
+
+		/* share with GPU */
+		shared_handle[buf] = init_userptr(fd, &userptr,
+						  shared_buffer[buf],
+						  BO_SIZE);
+
+		setup_exec_obj(&exec_object2[buf], shared_handle[buf],
+			       EXEC_OBJECT_PINNED, pinning_offset);
+		len += gem_store_data_svm(fd, batch_buffer + (len/4),
+					  pinning_offset, buf,
+					  (buf == STRESS_NUM_BUFFERS-1)? \
+					  true:false);
+		
+		/* decremental 4K aligned address */
+		pinning_offset -= ALIGN(BO_SIZE, 4096);
+	}
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle,
+		       0, 0);
+
+	/* We want to run this on BLT ring if possible */
+	if (HAS_BLT_RING(intel_get_drm_devid(fd))) {
+		ring = I915_EXEC_BLT;
+
+		setup_execbuffer(&execbuf, exec_object2, ring,
+				 STRESS_NUM_BUFFERS + 1, len);
+
+		for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
+			submit_and_sync(fd, &execbuf, batch_buf_handle);
+			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+				gem_userptr_sync(fd, shared_handle[buf]);
+				igt_fail_on_f(*shared_buffer[buf] != buf, \
+				"Mismatch in buffer %d, iteration %d: 0x%08X\n", \
+				buf, loop, *shared_buffer[buf]);
+			}
+		}
+	}
+
+	/* Now Render Ring */
+	ring = I915_EXEC_RENDER;
+	execbuf.flags = ring;
+	setup_execbuffer(&execbuf, exec_object2, ring,
+			 STRESS_NUM_BUFFERS + 1, len);
+	for (loop = 0; loop < STRESS_NUM_LOOPS; loop++) {
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+			gem_userptr_sync(fd, shared_handle[buf]);
+			igt_fail_on_f(*shared_buffer[buf] != buf, \
+			"Mismatch in buffer %d, \
+			iteration %d: 0x%08X\n", buf, loop, *shared_buffer[buf]);
+		}
+	}
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	for(loop = 0; loop < STRESS_NUM_BUFFERS; loop++) {
+		free(shared_buffer[loop]);
+	}
+
+	free(shared_handle);
+	free(shared_buffer);
+	free(exec_object2);
+	free(batch_buffer);
+}
+
+/* gem_write_multipage_buffer 
+ * Create a buffer spanning multiple pages, and share with GPU. 
+ * Write to every element of the buffer
+ * and verify correct contents.
+
+ * Create 8K buffer
+ * Share with GPU using userptr ioctl
+ * Create batch buffer to write DATA in all elements of buffer
+ * Execute Batch Buffer
+ * Validate every element has DATA
+*/
+
+#define DWORD_SIZE sizeof(uint32_t)
+#define BB_SIZE ((MULTIPAGE_BO_SIZE / DWORD_SIZE) * STORE_BATCH_BUFFER_SIZE) + 2
+#define NUM_DWORDS (MULTIPAGE_BO_SIZE/sizeof(uint32_t))
+static void gem_write_multipage_buffer_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	uint32_t shared_handle;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[BB_SIZE];
+	uint32_t batch_buf_handle;
+	int ring, len, j;
+	uint64_t pinning_offset=0x1000;
+	uint64_t vaddr;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+
+	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
+	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
+
+	len = 0;
+	memset(batch_buffer, 0, sizeof(batch_buffer));
+	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
+
+	/* share with GPU */
+	shared_handle = init_userptr(fd, &userptr, shared_buffer,
+				     MULTIPAGE_BO_SIZE);
+	setup_exec_obj(&exec_object2[0], shared_handle,
+		       EXEC_OBJECT_PINNED, pinning_offset);
+
+	/* create command buffer with write commands */
+	vaddr = pinning_offset;
+	for(j=0; j< NUM_DWORDS; j++) { 
+		len += gem_store_data_svm(fd, batch_buffer + (len/4), vaddr,
+					  j,
+					  (j == NUM_DWORDS - 1) ? true:false);
+		vaddr += sizeof(shared_buffer[0]);  /* 4 bytes */
+	}
+
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_handle);
+
+	for(j = 0; j < (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++) {
+		igt_fail_on_f(shared_buffer[j] != j,
+		"Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+}
+
+/* gem_pin_invalid_vma_test 
+ * This test will request to pin a shared buffer to an invalid
+ * VMA  > 48-bit address
+ * Create shared buffer of size 4K
+ * Try and Pin object to address 0x9000000000000
+*/
+static void gem_pin_invalid_vma_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[1];
+	uint32_t shared_buf_handle;
+	int ring;
+	uint64_t invalid_address = 0x9000000000000; /* 52 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+	
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED, invalid_address);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 1, 0);
+
+	/* Expect execbuf to fail */
+	ret = drmIoctl(fd,
+		       DRM_IOCTL_I915_GEM_EXECBUFFER2,
+		       &execbuf);
+
+	igt_assert(errno == ENOSPC);
+	igt_assert_neq(ret, 0);
+	
+	close(fd);
+	free(shared_buffer);
+}
+
+
+/* gem_pin_high_address_test 
+ * This test will create a shared buffer, and create a command
+ * for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
+ * CPU will read and make sure expected value is obtained
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use virtual address of buffer as 0x1100000000 (> 32 bit)
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to shared buffer VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+
+static void gem_pin_high_address_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+ 
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle,
+		       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, \
+		expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/* gem_pin_near_48Bit_test 
+ * This test will create a shared buffer, 
+ * and create a command for GPU to write data in it. It will attempt 
+ * to pin the buffer at address > 47 bits <= 48-bit.
+ * CPU will read and make sure expected value is obtained
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use virtual address of buffer as range between 47-bit and 48-bit
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to shared buffer VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000 
+#define END_HIGH_ADDRESS 0xFFFFFFFFC000
+#define ADDRESS_INCREMENT 0x2000000000
+static void gem_pin_near_48Bit_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t *shared_buffer;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[2];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE);
+
+	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS;
+						high_address+=ADDRESS_INCREMENT) {
+		/* create command buffer with write command */
+		len = gem_store_data_svm(fd, batch_buffer, high_address,
+					data, true);
+		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+		/* submit command buffer */
+		setup_exec_obj(&exec_object2[0], shared_buf_handle,
+			       EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
+			       high_address);
+		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+		ring = I915_EXEC_RENDER;
+		setup_execbuffer(&execbuf, exec_object2, ring, 2, len);
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		gem_userptr_sync(fd, shared_buf_handle);
+
+		/* check on CPU to see if value changes */
+		igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, expected: 0x%x, \
+		got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+
+int main(int argc, char* argv[])
+{
+	igt_subtest_init(argc, argv);
+	igt_skip_on_simulation();
+
+	/* All tests need PPGTT support */
+	igt_subtest("gem_pin_userptr") {
+		gem_pin_userptr_test();
+	}
+	igt_subtest("gem_pin_bo") {
+		gem_pin_bo_test();
+	}
+	igt_subtest("gem_multiple_process") {
+		gem_multiple_process_test();
+	}
+	igt_subtest("gem_repin") {
+		gem_repin_test();
+	}
+	igt_subtest("gem_pin_overlap") {
+		gem_pin_overlap_test();
+	}
+	igt_subtest("gem_write_multipage_buffer") {
+		gem_write_multipage_buffer_test();
+	}
+
+	/* Following tests need 48 Bit PPGTT support */
+	igt_subtest("gem_pin_invalid_vma") {
+		gem_pin_invalid_vma_test();
+	}
+	igt_subtest("gem_softpin_stress") {
+		gem_softpin_stress_test();
+	}
+	igt_subtest("gem_pin_high_address") {
+		gem_pin_high_address_test();
+	}
+	igt_subtest("gem_pin_near_48Bit") {
+		gem_pin_near_48Bit_test();
+	}
+
+	igt_exit();
+}
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread

* Re: [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
  2015-11-25 14:44 Vinay Belgaumkar
@ 2015-11-26 16:09 ` Tvrtko Ursulin
  0 siblings, 0 replies; 19+ messages in thread
From: Tvrtko Ursulin @ 2015-11-26 16:09 UTC (permalink / raw)
  To: Vinay Belgaumkar, intel-gfx


Hi,

On 25/11/15 14:44, Vinay Belgaumkar wrote:
> These tests exercise the userptr ioctl to create shared buffers
> between CPU and GPU. They contain error and normal usage scenarios.
> They also contain a couple of stress tests which copy buffers between
> CPU and GPU. These tests rely on the softpin patch in order to pin buffers
> to a certain VA.
>
> Caveat: These tests were designed to run on 64-bit system. Future work
> includes adding logic to ensure these tests can run on 32-bit systems with
> PPGTT support. Some tests are currently disabled for 32-bit systems for that
> reason.
>
> v2: Added cc and signed-off-by fields
>
> v3: Fixed review comments, added helper functions. Removed userptr error
> scenarios covered by existing userptr tests. Modified stress test to have
> 100K buffers, it now runs for ~30 mins, checks every element has been written
> to correctly, and pins buffers at different VMAs.
>
> v4: Changed name to gem_softpin
>
> v5: More fixes. Removed the file based tests, will move them to userptr tests.
> Added a function that validates appropriate PPGTT support before running tests.
> Optimized stack space and memory footprint in stress test. Removed the eviction
> test, will add it back after verifying proper functionality.
>
> Cc: Michel Thierry <michel.thierry@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
>   tests/.gitignore       |   1 +
>   tests/Makefile.sources |   1 +
>   tests/gem_softpin.c    | 972 +++++++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 974 insertions(+)
>   create mode 100644 tests/gem_softpin.c
>
> diff --git a/tests/.gitignore b/tests/.gitignore
> index 80af9a7..424870b 100644
> --- a/tests/.gitignore
> +++ b/tests/.gitignore
> @@ -21,6 +21,7 @@ gem_bad_blit
>   gem_bad_length
>   gem_bad_reloc
>   gem_basic
> +gem_softpin
>   gem_caching
>   gem_close_race
>   gem_concurrent_all
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 8fb2de8..2008d4a 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -11,6 +11,7 @@ TESTS_progs_M = \
>   	drv_hangman \
>   	gem_bad_reloc \
>   	gem_basic \
> +	gem_softpin \
>   	gem_caching \
>   	gem_close_race \
>   	gem_concurrent_blit \
> diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
> new file mode 100644
> index 0000000..95b664a
> --- /dev/null
> +++ b/tests/gem_softpin.c
> @@ -0,0 +1,972 @@
> +/*
> + * Copyright © 2015 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
> + * IN THE SOFTWARE.
> + *
> + * Authors:
> + *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> + *    Thomas Daniel <thomas.daniel@intel.com>
> + *
> + */
> +
> +#include <unistd.h>
> +#include <stdlib.h>
> +#include <stdint.h>
> +#include <stdio.h>
> +#include <string.h>
> +#include <fcntl.h>
> +#include <inttypes.h>
> +#include <errno.h>
> +#include <sys/stat.h>
> +#include <sys/ioctl.h>
> +#include <sys/time.h>
> +#include <malloc.h>
> +#include "drm.h"
> +#include "ioctl_wrappers.h"
> +#include "drmtest.h"
> +#include "intel_chipset.h"
> +#include "intel_io.h"
> +#include "i915_drm.h"
> +#include <assert.h>
> +#include <sys/wait.h>
> +#include <sys/ipc.h>
> +#include <sys/shm.h>
> +#include "igt_kms.h"
> +#include <inttypes.h>
> +#include <sys/types.h>
> +#include <sys/stat.h>
> +
> +#define BO_SIZE 4096
> +#define MULTIPAGE_BO_SIZE 2 * BO_SIZE
> +#define STORE_BATCH_BUFFER_SIZE 4
> +#define EXEC_OBJECT_PINNED	(1<<4)
> +#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
> +#define SHARED_BUFFER_SIZE 4096
> +#define NUM_EXEC_OBJECTS 2

I would just hardcode 2 or 3 (or 1) in relevant places since some tests 
use NUM_EXEC_OBJECTS + 1 anyway so it is not so useful to have a define 
with a long name for this.

> +
> +typedef struct drm_i915_gem_userptr i915_gem_userptr;
> +
> +static uint32_t init_userptr(int fd, i915_gem_userptr*, void* ptr,
> +				uint64_t size, bool read_only);

i915_gem_userptr *, void *ptr

> +static void *create_mem_buffer(uint64_t size);
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
> +static void gem_basic_test(void);
> +static void gem_pin_invalid_vma_test(void);
> +static void gem_pin_overlap_test(void);
> +static void gem_pin_high_address_test(void);
> +
> +#define NO_PPGTT 0
> +#define ALIASING_PPGTT 1
> +#define FULL_32_BIT_PPGTT 2
> +#define FULL_48_BIT_PPGTT 3
> +/* uses_full_ppgtt
> + * Finds supported PPGTT details.
> + * @fd DRM fd
> + * @min can be
> + * 0 - No PPGTT
> + * 1 - Aliasing PPGTT
> + * 2 - Full PPGTT (32b)
> + * 3 - Full PPGTT (48b)
> + * RETURNS true/false if min support is present
> +*/
> +static bool uses_full_ppgtt(int fd, int min)
> +{
> +	struct drm_i915_getparam gp;
> +	int val = 0;
> +
> +	memset(&gp, 0, sizeof(gp));
> +	gp.param = 18; /* HAS_ALIASING_PPGTT */
> +	gp.value = &val;
> +
> +	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
> +		return 0;
> +
> +	errno = 0;
 > +
> +	return val >= min;
> +}
> +
> +
> +/* gem_call_userptr_ioctl
> + * Helper to call ioctl - TODO: move to lib
> + * @fd - drm fd
> + * @userptr - pointer to initialised userptr
> + * RETURNS status of ioctl call
> +*/
> +static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr)
> +{
> +	int ret;
> +
> +	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
> +
> +	if (ret)
> +		ret = errno;
> +
> +	return ret;
> +}
> +
> +/* init_userptr
> + * Helper that inits userptr an returns handle
> + * @fd - drm fd
> + * @userptr - pointer to empty userptr
> + * @ptr - buffer to be shared
> + * @size - size of buffer
> + * @ro - read only flag
> + * RETURNS handle to shared buffer
> +*/
> +static uint32_t init_userptr(int fd, i915_gem_userptr *userptr, void *ptr,
> +				uint64_t size, bool ro)

I would lose the read-only argument if it is not interesting in this 
test, just adds verbosity.

> +{
> +	int ret;
> +
> +	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
> +
> +	userptr->user_ptr = (uint64_t)ptr; /* Need the cast to overcome compiler warning */
> +	userptr->user_size = size;
> +	userptr->flags = I915_USERPTR_UNSYNCHRONIZED;

It would be better for test coverage to try the synchronized version if 
available since that is what majority of users will use, given how 
unsync is a root only feature.

> +
> +	if (ro)
> +		userptr->flags |= I915_USERPTR_READ_ONLY;
> +
> +	ret = gem_call_userptr_ioctl(fd, userptr);
> +	igt_assert_eq(ret, 0);
> +
> +	return userptr->handle;
> +}
> +
> +/* create_mem_buffer
> + * Creates a 4K aligned CPU buffer
> + * @size - size of buffer
> + * RETURNS pointer to buffer of @size
> +*/
> +static void *create_mem_buffer(uint64_t size)
> +{
> +	void *addr;
> +	int ret;
> +
> +	ret = posix_memalign(&addr, 4096, size);
> +	igt_assert(ret == 0);
> +
> +	return addr;
> +}
> +
> +/* setup_exec_obj
> + * populate exec object
> + * @exec - exec object
> + * @handle - handle to gem buffer
> + * @flags - any flags
> + * @offset - requested VMA
> +*/
> +static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec,
> +				uint32_t handle, uint32_t flags,
> +				uint64_t offset)
> +{
> +	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
> +	exec->handle = handle;
> +	exec->flags = flags;
> +	exec->offset = offset;
> +}
> +
> +/* gem_store_data_svm
> + * populate batch buffer with MI_STORE_DWORD_IMM command
> + * @fd: drm file descriptor
> + * @cmd_buf: batch buffer
> + * @vaddr: destination Virtual address
> + * @data: data to be store at destination
> + * @end: whether to end batch buffer or not
> +*/
> +static int gem_store_data_svm(int fd, uint32_t *cmd_buf, uint64_t vaddr,
> +			      uint32_t data, bool end)
> +{
> +	int i = 0, len = 0;

Nitpick: Don't need to init len. On better look you don't even need that 
variable? But still a nitpick..

> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
> +	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
> +
> +	cmd_buf[i++] = data;
> +	if (end){

Missing space, "if (end) {", here and elsewhere.

> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	len = i * sizeof(uint32_t);
> +
> +	return len;
> +}
> +
> +/* gem_store_data
> + * populate batch buffer with MI_STORE_DWORD_IMM command
> + * This one fills up reloc buffer as well
> + * @fd: drm file descriptor
> + * @cmd_buf: batch buffer
> + * @data: data to be store at destination
> + * @reloc - relocation entry
> + * @end: whether to end batch buffer or not
> +*/
> +static int gem_store_data(int fd, uint32_t *cmd_buf,
> +			      uint32_t handle, uint32_t data,
> +			      struct drm_i915_gem_relocation_entry *reloc,
> +			      bool end)

More coding style (elsewhere in file as well) - please align parameters 
to the first line.

> +{
> +	int i = 0;
> +
> +	cmd_buf[i++] = MI_STORE_DWORD_IMM;
> +	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 reloc needed */
> +	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 reloc needed */
> +	reloc->offset = 1 * sizeof(uint32_t);
> +	reloc->delta = 0;
> +	reloc->target_handle = handle;
> +	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
> +	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
> +	reloc->presumed_offset = 0;
> +	cmd_buf[i++] = data;
> +	if (end){
> +		cmd_buf[i++] = MI_BATCH_BUFFER_END;
> +		cmd_buf[i++] = 0;
> +	}
> +
> +	return (i * sizeof(uint32_t));
> +}
> +
> +/* setup_execbuffer
> + * helper for buffer execution
> + * @execbuf - pointer to execbuffer
> + * @exec_object - pointer to exec object2 struct
> + * @ring - ring to be used
> + * @buffer_count - how manu buffers to submit
> + * @batch_length - length of batch buffer
> +*/
> +static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf,
> +				struct drm_i915_gem_exec_object2 *exec_object,
> +				int ring, int buffer_count, int batch_length)
> +{
> +	execbuf->buffers_ptr = (uintptr_t)exec_object;

Bah uintptr_t.. I see that the code base is full of that inappropriate 
thing so you are excused. :)

> +	execbuf->buffer_count = buffer_count;
> +	execbuf->batch_start_offset = 0;
> +	execbuf->batch_len = batch_length;
> +	execbuf->cliprects_ptr = 0;
> +	execbuf->num_cliprects = 0;
> +	execbuf->DR1 = 0;
> +	execbuf->DR4 = 0;
> +	execbuf->flags = ring;
> +	i915_execbuffer2_set_context_id(*execbuf, 0);
> +	execbuf->rsvd2 = 0;
> +}
> +
> +/* submit_and_sync
> + * Helper function for exec and sync functions
> + * @fd - drm fd
> + * @execbuf - pointer to execbuffer
> + * @batch_buf_handle - batch buffer handle
> +*/
> +static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf,
> +				uint32_t batch_buf_handle)
> +{
> +	gem_execbuf(fd, execbuf);
> +	gem_sync(fd, batch_buf_handle);
> +}
> +
> +/* gem_userptr_sync
> + * helper for syncing to CPU domain - copy/paste from userblit
> + * @fd - drm fd
> + * @handle - buffer handle to sync
> +*/
> +static void gem_userptr_sync(int fd, uint32_t handle)
> +{
> +	gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
> +}
> +
> +
> +/* gem_basic_test
> + * This test will create a shared buffer, and create a command
> + * for GPU to write data in it
> + * CPU will read and make sure expected value is obtained
> + * @valid_shared_buffer - whether test with valid malloc'd buffer or not

This parameter is no more, including the test description below.

> + * if (valid_shared_buffer == true)
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +
> + * if (valid_shared_buffer == false)
> + * Declare null buffer
> + * Call Userptr ioctl with null buffer
> + * Run Basic Test
> + * Test should fail at submit execbuffer
> +*/
> +static void gem_basic_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t* shared_buffer = NULL;

Coding style, plus don't need to initialise.

> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS + 1];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle, unshared_buf_handle;
> +	struct drm_i915_gem_relocation_entry reloc[4];
> +	int ring, len;
> +	uint32_t value;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	unshared_buf_handle = gem_create(fd, BO_SIZE);
> +	
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +						BO_SIZE, false);

Weird alignment. Please check throughout.

> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, false);
> +	len += gem_store_data(fd, batch_buffer + (len/4), unshared_buf_handle, data,
> +				reloc, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], unshared_buf_handle, 0, 0);
> +	setup_exec_obj(&exec_object2[2], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS + 1, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	/* Check if driver pinned the buffer as requested */
> +	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
> +			"\nFailed to pin at requested offset");
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		      "\nCPU read does not match GPU write,\
> +			expected: 0x%x, got: 0x%x\n",
> +			data, shared_buffer[0]);
> +	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
> +	igt_assert(value == data);
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}

I though we agreed to have separate basic test case for a normal bo, and 
a separate for userptr?

(And to exercise EXEC_OBJECT_PINNED in both cases.)

> +/* gem_multiple_process_test
> + * Run basic test simultaneously with multiple processes
> + * This will test pinning same VA separately in each process
> +
> + * fork();
> + * Execute basic test in parent/child processes
> +*/
> +#define MAX_NUM_PROCESSES 10
> +
> +static void gem_multiple_process_test(void)
> +{
> +	igt_fork(child, MAX_NUM_PROCESSES) {
> +		gem_basic_test();
> +	}
> +	igt_waitchildren();
> +}
> +
> +
> +/* gem_repin_test
> + * This test tries to repin a buffer at a previously pinned vma
> + * from a different execbuf.
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use 0x1000 address as destination address in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to 0x1000 VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +
> + * Create second shared buffer
> + * Follow all steps above
> + * Execpt, for offset, use VMA of first buffer above
> + * Submit execbuffer
> + * Verify value of first DWORD in second shared buffer matches DATA
> +*/
> +static void gem_repin_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd;
> +	uint32_t* shared_buffer = NULL;
> +	uint32_t* shared_buffer1 = NULL;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
> +	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
> +	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	/* Create gem object */
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set first elements to 0x0 */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE);
> +	shared_buffer[0] = 0x0;
> +	shared_buffer1[0] = 0x0;
> +
> +	/* share with GPU and get handles */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +						BO_SIZE, false);
> +	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> +						BO_SIZE, false);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	igt_assert(*shared_buffer == data);

I suggest always checking the offsets, not only data, whenever 
EXEC_OBJECT_PINNED is asked for.

> +
> +	/* Second buffer */
> +	/* create command buffer with write command */
> +	pinning_offset = exec_object2[0].offset;
> +	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	/* Pin at shared_buffer, not shared_buffer1 */
> +	/* We are requesting address where another buffer was pinned previously */
> +	/* It does not exist there anymore, since execbuf was already executed */

It could still be there and will then need to be removed to make place 
for this one.

> +	setup_exec_obj(&exec_object2[0], shared_buf_handle1,
> +			EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle1);
> +
> +	igt_assert(*shared_buffer1 == data);
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +
> +/* gem_repin_overlap_test
> + * This test will attempt to pin two buffers at the same VMA as part of the same
> +   execbuffer object
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create second shared buffer
> + * Create batch buffer to write DATA to first dword of each buffer
> + * Use same virtual address as destination addresses in batch buffer
> + * Set EXEC_OBJECT_PINNED flag in both exec objects
> + * Set 'offset' in both exec objects to same VMA
> + * Submit execbuffer
> + * Command should return EINVAL, since we are trying to pin to same VMA
> +*/
> +static void gem_pin_overlap_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	i915_gem_userptr userptr1;
> +	int fd, ret;
> +	uint32_t* shared_buffer = NULL;
> +	uint32_t* shared_buffer1 = NULL;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS + 1];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t pinning_offset = 0x1000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer,
> +						BO_SIZE, false);
> +	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1,
> +						BO_SIZE * 2, false);
> +
> +	len = gem_store_data_svm(fd, batch_buffer,
> +					pinning_offset, data, false);
> +	len += gem_store_data_svm(fd, (batch_buffer + len/4),
> +					pinning_offset, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);

You can remove store dwords since you don't expect this test to ever 
succeed. I think I suggested this in the previous round? Would make the 
test shorter and easier to read.

Also, one thing worth adding would be different overlaps. Objects before 
and after and overlap by page and vice-versa and similar.

This is really the core of the softpin functionality so it is worth 
scrutinising a bit.

And then possibly the same but with something already at the VMA in 
question, so it needs to move one and see that it cannot fit the other.

And then perhaps add an object which is immovable, like some long 
running workload on another ring and try to pin at that address from 
different ring while it is running to verify it fails.

Can add these as follow up tests cases.

> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[1], shared_buf_handle1,
> +			EXEC_OBJECT_PINNED, pinning_offset);
> +	setup_exec_obj(&exec_object2[2], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS+1, len);
> +
> +	ret = drmIoctl(fd,
> +	      DRM_IOCTL_I915_GEM_EXECBUFFER2,
> +	      &execbuf);
> +
> +	/* expect to fail */
> +	igt_assert_neq(ret, 0);
> +	igt_assert(errno == 22);
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +	free(shared_buffer1);
> +}
> +
> +/* gem_softpin_stress_test
> + * Stress test which creates 10K buffers and shares with GPU
> + * Create 100K uint32 buffers of size 4K each
> + * Share with GPU using userptr ioctl
> + * Create batch buffer to write DATA in first element of each buffer
> + * Pin each buffer to varying addresses starting from 0x800000000000 going below
> + * Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
> + * Validate every buffer has DATA in first element
> + * Rinse and Repeat on Render ring
> +*/
> +#define STRESS_NUM_BUFFERS 100000
> +#define STRESS_NUM_LOOPS 100
> +#define STRESS_STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
> +
> +static void gem_softpin_stress_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t **shared_buffer;
> +	uint32_t *shared_handle;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 *exec_object2;
> +	uint32_t *batch_buffer;
> +	uint32_t batch_buf_handle;
> +	int ring, len;
> +	int buf, loop;
> +	uint64_t pinning_offset = 0x800000000000;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +
> +	/* Allocate blobs for all data structures */
> +	shared_handle = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t));
> +	shared_buffer = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t*));
> +	exec_object2 = calloc(STRESS_NUM_BUFFERS + 1,
> +				sizeof(struct drm_i915_gem_exec_object2));
> +	/* 4 dwords per buffer + 2 for the end of batchbuffer */
> +	batch_buffer = calloc(STRESS_STORE_COMMANDS + 2, sizeof(uint32_t));
> +	batch_buf_handle = gem_create(fd, (STRESS_STORE_COMMANDS + 2)*4);
> +
> +	/* create command buffer with write commands */
> +	len = 0;
> +	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
> +		shared_buffer[buf] = create_mem_buffer(BO_SIZE);
> +		*shared_buffer[buf] = 0xFFFFFFFF;
> +
> +		/* share with GPU */
> +		shared_handle[buf] = init_userptr(fd, &userptr, shared_buffer[buf],
> +						BO_SIZE, false);
> +
> +		setup_exec_obj(&exec_object2[buf], shared_handle[buf],
> +				EXEC_OBJECT_PINNED, pinning_offset);
> +		len += gem_store_data_svm(fd, batch_buffer + (len/4), pinning_offset,
> +			buf , (buf == STRESS_NUM_BUFFERS-1) ? true:false);
> +		
> +		/* decremental 4K aligned address */
> +		pinning_offset = ALIGN(pinning_offset - 0x200000, 4096);

Oh I wasn't clear, my comment was about 0x200000, why hardcode that and 
not just use

  pinning_offset -= ALIGN(BO_SIZE, 4096)

?

> +	}
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle, 0, 0);
> +
> +	/* We want to run this on BLT ring if possible */
> +	if (HAS_BLT_RING(intel_get_drm_devid(fd))){
> +		ring = I915_EXEC_BLT;
> +
> +		setup_execbuffer(&execbuf, exec_object2, ring,
> +				STRESS_NUM_BUFFERS + 1, len);

setup_execbuffer won't be called if there is not blt ring for the render 
ring below.

> +		for (loop = 0; loop < STRESS_NUM_LOOPS; loop++){
> +			submit_and_sync(fd, &execbuf, batch_buf_handle);
> +			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++){
> +				gem_userptr_sync(fd, shared_handle[buf]);
> +				igt_fail_on_f(*shared_buffer[buf] != buf, \
> +				"Mismatch in buffer %d, iteration %d: 0x%08X\n", \
> +				buf, loop, *shared_buffer[buf]);
> +			}
> +		}
> +	}
> +
> +	/* Now Render Ring */
> +	ring = I915_EXEC_RENDER;
> +	execbuf.flags = ring;
> +	for (loop = 0; loop < STRESS_NUM_LOOPS; loop++){
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++){
> +			gem_userptr_sync(fd, shared_handle[buf]);
> +			igt_fail_on_f(*shared_buffer[buf] != buf, \
> +			"Mismatch in buffer %d, \
> +			iteration %d: 0x%08X\n", buf, loop, *shared_buffer[buf]);
> +		}
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	for(loop = 0; loop < STRESS_NUM_BUFFERS; loop++){
> +		free(shared_buffer[loop]);
> +	}
> +
> +	free(shared_handle);
> +	free(shared_buffer);
> +	free(exec_object2);
> +	free(batch_buffer);
> +}
> +
> +/* gem_write_multipage_buffer
> + * Create a buffer spanning multiple pages, and share with GPU.
> + * Write to every element of the buffer
> + * and verify correct contents.
> +
> + * Create 8K buffer
> + * Share with GPU using userptr ioctl
> + * Create batch buffer to write DATA in all elements of buffer
> + * Execute Batch Buffer
> + * Validate every element has DATA
> +*/
> +
> +#define DWORD_SIZE sizeof(uint32_t)
> +#define BB_SIZE ((MULTIPAGE_BO_SIZE / DWORD_SIZE) * STORE_BATCH_BUFFER_SIZE) + 2
> +static void gem_write_multipage_buffer_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t* shared_buffer;
> +	uint32_t shared_handle;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
> +	uint32_t batch_buffer[BB_SIZE];
> +	uint32_t batch_buf_handle;
> +	int ring, len, j;
> +	uint64_t pinning_offset=0x1000;
> +	uint64_t vaddr;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
> +	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
> +
> +	len = 0;
> +	memset(batch_buffer, 0, sizeof(batch_buffer));
> +	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
> +
> +	/* share with GPU */
> +	shared_handle = init_userptr(fd, &userptr, shared_buffer,
> +					MULTIPAGE_BO_SIZE, false);
> +	setup_exec_obj(&exec_object2[0], shared_handle,
> +			EXEC_OBJECT_PINNED, pinning_offset);
> +
> +	/* create command buffer with write commands */
> +	vaddr = pinning_offset;
> +	for(j=0; j< (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++){
> +		/* BO_SIZE because it is 16K 4 byte entries */

Stale comment?

> +		len += gem_store_data_svm(fd, batch_buffer + (len/4), vaddr,
> +			j, (j == (((MULTIPAGE_BO_SIZE/sizeof(uint32_t))-1))) ?\
> +			 true:false);
> +		vaddr += sizeof(shared_buffer[0]);  /* 4 bytes */
> +	}
> +
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_handle);
> +
> +	for(j = 0; j < (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++){
> +		igt_fail_on_f(shared_buffer[j] != j,
> +		"Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_invalid_vma_test
> + * This test will request to pin a shared buffer to an invalid
> + * VMA  > 48-bit address
> + * Create shared buffer of size 4K
> + * Try and Pin object to address 0x9000000000000
> +*/
> +static void gem_pin_invalid_vma_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd, ret;
> +	uint32_t* shared_buffer = NULL;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS - 1];
> +	uint32_t shared_buf_handle;
> +	int ring;
> +	uint64_t invalid_address = 0x9000000000000; /* 52 bit address */

Would this fail with a >32-bit address as well? I thought I spotted 
somewhere else that you need to pass in a special flag if you want to 
use 48-bit offsets? Or I am confusing something?

Hm, yes,  EXEC_OBJECT_SUPPORTS_48B_ADDRESS ?

So maybe two test cases, >32-bit offset without this flag should fail, 
and >48-bit offset with it?
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +	
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE, false);
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +			EXEC_OBJECT_PINNED, invalid_address);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS - 1, 0);
> +
> +	/* Expect execbuf to fail */
> +	ret = drmIoctl(fd,
> +	       DRM_IOCTL_I915_GEM_EXECBUFFER2,
> +	       &execbuf);
> +
> +	igt_assert_neq(ret, 0);

Do you also want to check the exact errno? Sounds like a good idea to 
me, even though execbuf returns EINVAL for a ton of reasons..

> +	
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +
> +/* gem_pin_high_address_test
> + * This test will create a shared buffer, and create a command
> + * for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
> + * CPU will read and make sure expected value is obtained
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use virtual address of buffer as 0x1100000000 (> 32 bit)
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to shared buffer VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +
> +static void gem_pin_high_address_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t* shared_buffer = NULL;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE, false);
> +
> +	/* create command buffer with write command */
> +	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
> +	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +
> +	/* submit command buffer */
> +	setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +		EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
> +	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +	ring = I915_EXEC_RENDER;
> +
> +	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
> +	submit_and_sync(fd, &execbuf, batch_buf_handle);
> +	gem_userptr_sync(fd, shared_buf_handle);
> +
> +	/* check on CPU to see if value changes */
> +	igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, \
> +		expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +/* gem_pin_near_48Bit_test
> + * This test will create a shared buffer,
> + * and create a command for GPU to write data in it. It will attempt
> + * to pin the buffer at address > 47 bits <= 48-bit.
> + * CPU will read and make sure expected value is obtained
> +
> + * Malloc a 4K buffer
> + * Share buffer with with GPU by using userptr ioctl
> + * Create batch buffer to write DATA to first dword of buffer
> + * Use virtual address of buffer as range between 47-bit and 48-bit
> + * Set EXEC_OBJECT_PINNED flag in exec object
> + * Set 'offset' in exec object to shared buffer VMA
> + * Submit execbuffer
> + * Verify value of first DWORD in shared buffer matches DATA
> +*/
> +#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000
> +#define END_HIGH_ADDRESS 0xFFFFFFFFC000
> +#define ADDRESS_INCREMENT 0x2000000000
> +static void gem_pin_near_48Bit_test(void)
> +{
> +	i915_gem_userptr userptr;
> +	int fd;
> +	uint32_t* shared_buffer = NULL;
> +	struct drm_i915_gem_execbuffer2 execbuf;
> +	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
> +	uint32_t batch_buffer[BO_SIZE];
> +	uint32_t batch_buf_handle, shared_buf_handle;
> +	int ring, len;
> +	const uint32_t data = 0x12345678;
> +	uint64_t high_address;
> +
> +	fd = drm_open_driver(DRIVER_INTEL);
> +	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
> +
> +	batch_buf_handle = gem_create(fd, BO_SIZE);
> +
> +	/* create cpu buffer, set to all 0xF's */
> +	shared_buffer = create_mem_buffer(BO_SIZE);
> +	*shared_buffer = 0xFFFFFFFF;
> +
> +	/* share with GPU */
> +	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE, false);
> +
> +	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS;
> +						high_address+=ADDRESS_INCREMENT){
> +		/* create command buffer with write command */
> +		len = gem_store_data_svm(fd, batch_buffer, high_address,
> +					data, true);
> +		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
> +		/* submit command buffer */
> +		setup_exec_obj(&exec_object2[0], shared_buf_handle,
> +				EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS,
> +				high_address);
> +		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
> +
> +		ring = I915_EXEC_RENDER;
> +		setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
> +		submit_and_sync(fd, &execbuf, batch_buf_handle);
> +		gem_userptr_sync(fd, shared_buf_handle);
> +
> +		/* check on CPU to see if value changes */
> +		igt_fail_on_f(shared_buffer[0] != data,
> +		"\nCPU read does not match GPU write, expected: 0x%x, \
> +		got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
> +	}
> +
> +	gem_close(fd, batch_buf_handle);
> +	close(fd);
> +	free(shared_buffer);
> +}
> +
> +
> +int main(int argc, char* argv[])
> +{
> +	igt_subtest_init(argc, argv);
> +	igt_skip_on_simulation();
> +
> +	/* All tests need PPGTT support */
> +	igt_subtest("gem_basic"){
> +		gem_basic_test();
> +	}
> +	igt_subtest("gem_multiple_process"){
> +		gem_multiple_process_test();
> +	}
> +	igt_subtest("gem_repin"){
> +		gem_repin_test();
> +	}
> +	igt_subtest("gem_pin_overlap"){
> +		gem_pin_overlap_test();
> +	}
> +	igt_subtest("gem_write_multipage_buffer"){
> +		gem_write_multipage_buffer_test();
> +	}
> +
> +	/* Following tests need 48 Bit PPGTT support */
> +	igt_subtest("gem_pin_invalid_vma"){
> +		gem_pin_invalid_vma_test();
> +	}
> +	igt_subtest("gem_softpin_stress"){
> +		gem_softpin_stress_test();
> +	}
> +	igt_subtest("gem_pin_high_address"){
> +		gem_pin_high_address_test();
> +	}
> +	igt_subtest("gem_pin_near_48Bit"){
> +		gem_pin_near_48Bit_test();
> +	}
> +
> +	igt_exit();
> +}
>

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 19+ messages in thread

* [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature
@ 2015-11-25 14:44 Vinay Belgaumkar
  2015-11-26 16:09 ` Tvrtko Ursulin
  0 siblings, 1 reply; 19+ messages in thread
From: Vinay Belgaumkar @ 2015-11-25 14:44 UTC (permalink / raw)
  To: intel-gfx; +Cc: Vinay Belgaumkar

These tests exercise the userptr ioctl to create shared buffers
between CPU and GPU. They contain error and normal usage scenarios.
They also contain a couple of stress tests which copy buffers between
CPU and GPU. These tests rely on the softpin patch in order to pin buffers
to a certain VA.

Caveat: These tests were designed to run on 64-bit system. Future work
includes adding logic to ensure these tests can run on 32-bit systems with
PPGTT support. Some tests are currently disabled for 32-bit systems for that
reason.

v2: Added cc and signed-off-by fields

v3: Fixed review comments, added helper functions. Removed userptr error
scenarios covered by existing userptr tests. Modified stress test to have
100K buffers, it now runs for ~30 mins, checks every element has been written
to correctly, and pins buffers at different VMAs.

v4: Changed name to gem_softpin

v5: More fixes. Removed the file based tests, will move them to userptr tests.
Added a function that validates appropriate PPGTT support before running tests.
Optimized stack space and memory footprint in stress test. Removed the eviction
test, will add it back after verifying proper functionality.

Cc: Michel Thierry <michel.thierry@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
---
 tests/.gitignore       |   1 +
 tests/Makefile.sources |   1 +
 tests/gem_softpin.c    | 972 +++++++++++++++++++++++++++++++++++++++++++++++++
 3 files changed, 974 insertions(+)
 create mode 100644 tests/gem_softpin.c

diff --git a/tests/.gitignore b/tests/.gitignore
index 80af9a7..424870b 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -21,6 +21,7 @@ gem_bad_blit
 gem_bad_length
 gem_bad_reloc
 gem_basic
+gem_softpin
 gem_caching
 gem_close_race
 gem_concurrent_all
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index 8fb2de8..2008d4a 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -11,6 +11,7 @@ TESTS_progs_M = \
 	drv_hangman \
 	gem_bad_reloc \
 	gem_basic \
+	gem_softpin \
 	gem_caching \
 	gem_close_race \
 	gem_concurrent_blit \
diff --git a/tests/gem_softpin.c b/tests/gem_softpin.c
new file mode 100644
index 0000000..95b664a
--- /dev/null
+++ b/tests/gem_softpin.c
@@ -0,0 +1,972 @@
+/*
+ * Copyright © 2015 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ * Authors:
+ *    Vinay Belgaumkar <vinay.belgaumkar@intel.com>
+ *    Thomas Daniel <thomas.daniel@intel.com>
+ *
+ */
+
+#include <unistd.h>
+#include <stdlib.h>
+#include <stdint.h>
+#include <stdio.h>
+#include <string.h>
+#include <fcntl.h>
+#include <inttypes.h>
+#include <errno.h>
+#include <sys/stat.h>
+#include <sys/ioctl.h>
+#include <sys/time.h>
+#include <malloc.h>
+#include "drm.h"
+#include "ioctl_wrappers.h"
+#include "drmtest.h"
+#include "intel_chipset.h"
+#include "intel_io.h"
+#include "i915_drm.h"
+#include <assert.h>
+#include <sys/wait.h>
+#include <sys/ipc.h>
+#include <sys/shm.h>
+#include "igt_kms.h"
+#include <inttypes.h>
+#include <sys/types.h>
+#include <sys/stat.h>
+
+#define BO_SIZE 4096
+#define MULTIPAGE_BO_SIZE 2 * BO_SIZE
+#define STORE_BATCH_BUFFER_SIZE 4
+#define EXEC_OBJECT_PINNED	(1<<4)
+#define EXEC_OBJECT_SUPPORTS_48B_ADDRESS (1<<3)
+#define SHARED_BUFFER_SIZE 4096
+#define NUM_EXEC_OBJECTS 2
+
+typedef struct drm_i915_gem_userptr i915_gem_userptr;
+
+static uint32_t init_userptr(int fd, i915_gem_userptr*, void* ptr, 
+				uint64_t size, bool read_only);
+static void *create_mem_buffer(uint64_t size);
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr);
+static void gem_basic_test(void);
+static void gem_pin_invalid_vma_test(void);
+static void gem_pin_overlap_test(void);
+static void gem_pin_high_address_test(void);
+
+#define NO_PPGTT 0
+#define ALIASING_PPGTT 1
+#define FULL_32_BIT_PPGTT 2
+#define FULL_48_BIT_PPGTT 3
+/* uses_full_ppgtt
+ * Finds supported PPGTT details. 
+ * @fd DRM fd
+ * @min can be
+ * 0 - No PPGTT
+ * 1 - Aliasing PPGTT
+ * 2 - Full PPGTT (32b)
+ * 3 - Full PPGTT (48b)
+ * RETURNS true/false if min support is present
+*/
+static bool uses_full_ppgtt(int fd, int min)
+{
+	struct drm_i915_getparam gp;
+	int val = 0;
+
+	memset(&gp, 0, sizeof(gp));
+	gp.param = 18; /* HAS_ALIASING_PPGTT */
+	gp.value = &val;
+
+	if (drmIoctl(fd, DRM_IOCTL_I915_GETPARAM, &gp))
+		return 0;
+
+	errno = 0;
+	return val >= min;
+}
+
+
+/* gem_call_userptr_ioctl
+ * Helper to call ioctl - TODO: move to lib
+ * @fd - drm fd
+ * @userptr - pointer to initialised userptr
+ * RETURNS status of ioctl call
+*/
+static int gem_call_userptr_ioctl(int fd, i915_gem_userptr *userptr)
+{
+	int ret;
+
+	ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_USERPTR, userptr);
+
+	if (ret)
+		ret = errno;
+
+	return ret;
+}
+
+/* init_userptr
+ * Helper that inits userptr an returns handle
+ * @fd - drm fd
+ * @userptr - pointer to empty userptr
+ * @ptr - buffer to be shared
+ * @size - size of buffer
+ * @ro - read only flag
+ * RETURNS handle to shared buffer
+*/
+static uint32_t init_userptr(int fd, i915_gem_userptr *userptr, void *ptr, 
+				uint64_t size, bool ro)
+{
+	int ret;
+
+	memset((void*)userptr, 0, sizeof(i915_gem_userptr));
+
+	userptr->user_ptr = (uint64_t)ptr; /* Need the cast to overcome compiler warning */
+	userptr->user_size = size;
+	userptr->flags = I915_USERPTR_UNSYNCHRONIZED;
+
+	if (ro)
+		userptr->flags |= I915_USERPTR_READ_ONLY;
+
+	ret = gem_call_userptr_ioctl(fd, userptr);
+	igt_assert_eq(ret, 0);
+
+	return userptr->handle;
+}
+
+/* create_mem_buffer 
+ * Creates a 4K aligned CPU buffer 
+ * @size - size of buffer
+ * RETURNS pointer to buffer of @size
+*/
+static void *create_mem_buffer(uint64_t size)
+{
+	void *addr;
+	int ret;
+
+	ret = posix_memalign(&addr, 4096, size);
+	igt_assert(ret == 0);
+
+	return addr;
+}
+
+/* setup_exec_obj 
+ * populate exec object
+ * @exec - exec object
+ * @handle - handle to gem buffer
+ * @flags - any flags
+ * @offset - requested VMA
+*/
+static void setup_exec_obj(struct drm_i915_gem_exec_object2 *exec, 
+				uint32_t handle, uint32_t flags, 
+				uint64_t offset)
+{
+	memset(exec, 0, sizeof(struct drm_i915_gem_exec_object2));
+	exec->handle = handle;
+	exec->flags = flags;
+	exec->offset = offset;
+}
+
+/* gem_store_data_svm 
+ * populate batch buffer with MI_STORE_DWORD_IMM command
+ * @fd: drm file descriptor
+ * @cmd_buf: batch buffer
+ * @vaddr: destination Virtual address
+ * @data: data to be store at destination
+ * @end: whether to end batch buffer or not
+*/
+static int gem_store_data_svm(int fd, uint32_t *cmd_buf, uint64_t vaddr,
+			      uint32_t data, bool end)
+{
+	int i = 0, len = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = vaddr & 0xFFFFFFFC;
+	cmd_buf[i++] = (vaddr >> 32) & 0xFFFF; /* bits 32:47 */
+
+	cmd_buf[i++] = data;
+	if (end){ 
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	len = i * sizeof(uint32_t);
+
+	return len;
+}
+
+/* gem_store_data 
+ * populate batch buffer with MI_STORE_DWORD_IMM command
+ * This one fills up reloc buffer as well 
+ * @fd: drm file descriptor
+ * @cmd_buf: batch buffer
+ * @data: data to be store at destination
+ * @reloc - relocation entry
+ * @end: whether to end batch buffer or not
+*/
+static int gem_store_data(int fd, uint32_t *cmd_buf,
+			      uint32_t handle, uint32_t data,
+			      struct drm_i915_gem_relocation_entry *reloc,
+			      bool end)
+{
+	int i = 0;
+
+	cmd_buf[i++] = MI_STORE_DWORD_IMM;
+	cmd_buf[i++] = 0; /* lower 31 bits of 48 bit address - 0 reloc needed */
+	cmd_buf[i++] = 0; /* upper 15 bits of 48 bit address - 0 reloc needed */
+	reloc->offset = 1 * sizeof(uint32_t);
+	reloc->delta = 0;
+	reloc->target_handle = handle;
+	reloc->read_domains = I915_GEM_DOMAIN_RENDER;
+	reloc->write_domain = I915_GEM_DOMAIN_RENDER;
+	reloc->presumed_offset = 0;
+	cmd_buf[i++] = data;
+	if (end){ 
+		cmd_buf[i++] = MI_BATCH_BUFFER_END;
+		cmd_buf[i++] = 0;
+	}
+
+	return (i * sizeof(uint32_t));
+}
+
+/* setup_execbuffer 
+ * helper for buffer execution
+ * @execbuf - pointer to execbuffer
+ * @exec_object - pointer to exec object2 struct
+ * @ring - ring to be used
+ * @buffer_count - how manu buffers to submit
+ * @batch_length - length of batch buffer 
+*/
+static void setup_execbuffer(struct drm_i915_gem_execbuffer2 *execbuf, 
+				struct drm_i915_gem_exec_object2 *exec_object,
+				int ring, int buffer_count, int batch_length) 
+{
+	execbuf->buffers_ptr = (uintptr_t)exec_object;
+	execbuf->buffer_count = buffer_count;
+	execbuf->batch_start_offset = 0;
+	execbuf->batch_len = batch_length;
+	execbuf->cliprects_ptr = 0;
+	execbuf->num_cliprects = 0;
+	execbuf->DR1 = 0;
+	execbuf->DR4 = 0;
+	execbuf->flags = ring;
+	i915_execbuffer2_set_context_id(*execbuf, 0);
+	execbuf->rsvd2 = 0;
+}
+
+/* submit_and_sync 
+ * Helper function for exec and sync functions 
+ * @fd - drm fd
+ * @execbuf - pointer to execbuffer
+ * @batch_buf_handle - batch buffer handle
+*/
+static void submit_and_sync(int fd, struct drm_i915_gem_execbuffer2 *execbuf, 
+				uint32_t batch_buf_handle)
+{
+	gem_execbuf(fd, execbuf);
+	gem_sync(fd, batch_buf_handle); 
+}
+
+/* gem_userptr_sync
+ * helper for syncing to CPU domain - copy/paste from userblit
+ * @fd - drm fd
+ * @handle - buffer handle to sync
+*/
+static void gem_userptr_sync(int fd, uint32_t handle)
+{
+	gem_set_domain(fd, handle, I915_GEM_DOMAIN_CPU, I915_GEM_DOMAIN_CPU);
+}
+
+
+/* gem_basic_test 
+ * This test will create a shared buffer, and create a command
+ * for GPU to write data in it
+ * CPU will read and make sure expected value is obtained
+ * @valid_shared_buffer - whether test with valid malloc'd buffer or not
+
+ * if (valid_shared_buffer == true)
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+
+ * if (valid_shared_buffer == false)
+ * Declare null buffer
+ * Call Userptr ioctl with null buffer
+ * Run Basic Test
+ * Test should fail at submit execbuffer
+*/
+static void gem_basic_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t* shared_buffer = NULL;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS + 1];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle, unshared_buf_handle;
+	struct drm_i915_gem_relocation_entry reloc[4];
+	int ring, len;
+	uint32_t value;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	unshared_buf_handle = gem_create(fd, BO_SIZE);
+	
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, 
+						BO_SIZE, false);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, false);
+	len += gem_store_data(fd, batch_buffer + (len/4), unshared_buf_handle, data, 
+				reloc, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle, 
+			EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], unshared_buf_handle, 0, 0);
+	setup_exec_obj(&exec_object2[2], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS + 1, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	/* Check if driver pinned the buffer as requested */
+	igt_fail_on_f(exec_object2[0].offset != pinning_offset,
+			"\nFailed to pin at requested offset");
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		      "\nCPU read does not match GPU write,\
+			expected: 0x%x, got: 0x%x\n", 
+			data, shared_buffer[0]);
+	gem_read(fd, unshared_buf_handle, 0, (void*)&value, 4);
+	igt_assert(value == data);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/* gem_multiple_process_test 
+ * Run basic test simultaneously with multiple processes
+ * This will test pinning same VA separately in each process
+
+ * fork();
+ * Execute basic test in parent/child processes
+*/
+#define MAX_NUM_PROCESSES 10
+
+static void gem_multiple_process_test(void)
+{
+	igt_fork(child, MAX_NUM_PROCESSES) {
+		gem_basic_test();
+	}
+	igt_waitchildren();
+}
+
+
+/* gem_repin_test 
+ * This test tries to repin a buffer at a previously pinned vma 
+ * from a different execbuf. 
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use 0x1000 address as destination address in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to 0x1000 VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+
+ * Create second shared buffer
+ * Follow all steps above
+ * Execpt, for offset, use VMA of first buffer above 
+ * Submit execbuffer
+ * Verify value of first DWORD in second shared buffer matches DATA
+*/
+static void gem_repin_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd;
+	uint32_t* shared_buffer = NULL;
+	uint32_t* shared_buffer1 = NULL;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
+	uint32_t batch_buffer[STORE_BATCH_BUFFER_SIZE + 2];
+	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	/* Create gem object */
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set first elements to 0x0 */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE);
+	shared_buffer[0] = 0x0;
+	shared_buffer1[0] = 0x0;
+
+	/* share with GPU and get handles */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, 
+						BO_SIZE, false);
+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1, 
+						BO_SIZE, false);
+
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle, 
+			EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	igt_assert(*shared_buffer == data);
+
+	/* Second buffer */
+	/* create command buffer with write command */
+	pinning_offset = exec_object2[0].offset;
+	len = gem_store_data_svm(fd, batch_buffer, pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	/* Pin at shared_buffer, not shared_buffer1 */
+	/* We are requesting address where another buffer was pinned previously */
+	/* It does not exist there anymore, since execbuf was already executed */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle1, 
+			EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle1);
+
+	igt_assert(*shared_buffer1 == data);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+
+/* gem_repin_overlap_test
+ * This test will attempt to pin two buffers at the same VMA as part of the same
+   execbuffer object
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create second shared buffer
+ * Create batch buffer to write DATA to first dword of each buffer
+ * Use same virtual address as destination addresses in batch buffer
+ * Set EXEC_OBJECT_PINNED flag in both exec objects
+ * Set 'offset' in both exec objects to same VMA
+ * Submit execbuffer
+ * Command should return EINVAL, since we are trying to pin to same VMA
+*/
+static void gem_pin_overlap_test(void)
+{
+	i915_gem_userptr userptr;
+	i915_gem_userptr userptr1;
+	int fd, ret;
+	uint32_t* shared_buffer = NULL;
+	uint32_t* shared_buffer1 = NULL;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS + 1];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle, shared_buf_handle1;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t pinning_offset = 0x1000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	shared_buffer1 = create_mem_buffer(BO_SIZE * 2);
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, 
+						BO_SIZE, false);
+	shared_buf_handle1 = init_userptr(fd, &userptr1, shared_buffer1, 
+						BO_SIZE * 2, false);
+
+	len = gem_store_data_svm(fd, batch_buffer, 
+					pinning_offset, data, false);
+	len += gem_store_data_svm(fd, (batch_buffer + len/4), 
+					pinning_offset, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle, 
+			EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[1], shared_buf_handle1, 
+			EXEC_OBJECT_PINNED, pinning_offset);
+	setup_exec_obj(&exec_object2[2], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS+1, len);
+
+	ret = drmIoctl(fd,
+	      DRM_IOCTL_I915_GEM_EXECBUFFER2,
+	      &execbuf);
+
+	/* expect to fail */
+	igt_assert_neq(ret, 0);
+	igt_assert(errno == 22);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+	free(shared_buffer1);
+}
+
+/* gem_softpin_stress_test 
+ * Stress test which creates 10K buffers and shares with GPU 
+ * Create 100K uint32 buffers of size 4K each
+ * Share with GPU using userptr ioctl
+ * Create batch buffer to write DATA in first element of each buffer
+ * Pin each buffer to varying addresses starting from 0x800000000000 going below
+ * Execute Batch Buffer on Blit ring STRESS_NUM_LOOPS times
+ * Validate every buffer has DATA in first element
+ * Rinse and Repeat on Render ring
+*/
+#define STRESS_NUM_BUFFERS 100000
+#define STRESS_NUM_LOOPS 100
+#define STRESS_STORE_COMMANDS 4 * STRESS_NUM_BUFFERS
+
+static void gem_softpin_stress_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t **shared_buffer;
+	uint32_t *shared_handle;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 *exec_object2;
+	uint32_t *batch_buffer; 
+	uint32_t batch_buf_handle;
+	int ring, len;
+	int buf, loop;
+	uint64_t pinning_offset = 0x800000000000;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+
+
+	/* Allocate blobs for all data structures */
+	shared_handle = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t));
+	shared_buffer = calloc(STRESS_NUM_BUFFERS, sizeof(uint32_t*));
+	exec_object2 = calloc(STRESS_NUM_BUFFERS + 1, 
+				sizeof(struct drm_i915_gem_exec_object2));
+	/* 4 dwords per buffer + 2 for the end of batchbuffer */
+	batch_buffer = calloc(STRESS_STORE_COMMANDS + 2, sizeof(uint32_t));
+	batch_buf_handle = gem_create(fd, (STRESS_STORE_COMMANDS + 2)*4);
+
+	/* create command buffer with write commands */
+	len = 0;
+	for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++) {
+		shared_buffer[buf] = create_mem_buffer(BO_SIZE);
+		*shared_buffer[buf] = 0xFFFFFFFF;
+
+		/* share with GPU */
+		shared_handle[buf] = init_userptr(fd, &userptr, shared_buffer[buf], 
+						BO_SIZE, false);
+
+		setup_exec_obj(&exec_object2[buf], shared_handle[buf], 
+				EXEC_OBJECT_PINNED, pinning_offset);
+		len += gem_store_data_svm(fd, batch_buffer + (len/4), pinning_offset, 
+			buf , (buf == STRESS_NUM_BUFFERS-1) ? true:false);
+		
+		/* decremental 4K aligned address */
+		pinning_offset = ALIGN(pinning_offset - 0x200000, 4096);
+	}
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[STRESS_NUM_BUFFERS], batch_buf_handle, 0, 0);
+
+	/* We want to run this on BLT ring if possible */
+	if (HAS_BLT_RING(intel_get_drm_devid(fd))){
+		ring = I915_EXEC_BLT;
+
+		setup_execbuffer(&execbuf, exec_object2, ring, 
+				STRESS_NUM_BUFFERS + 1, len);
+
+		for (loop = 0; loop < STRESS_NUM_LOOPS; loop++){
+			submit_and_sync(fd, &execbuf, batch_buf_handle);
+			for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++){
+				gem_userptr_sync(fd, shared_handle[buf]);
+				igt_fail_on_f(*shared_buffer[buf] != buf, \
+				"Mismatch in buffer %d, iteration %d: 0x%08X\n", \
+				buf, loop, *shared_buffer[buf]);
+			}
+		}
+	}
+
+	/* Now Render Ring */
+	ring = I915_EXEC_RENDER;
+	execbuf.flags = ring;
+	for (loop = 0; loop < STRESS_NUM_LOOPS; loop++){
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		for(buf = 0; buf < STRESS_NUM_BUFFERS; buf++){
+			gem_userptr_sync(fd, shared_handle[buf]);
+			igt_fail_on_f(*shared_buffer[buf] != buf, \
+			"Mismatch in buffer %d, \
+			iteration %d: 0x%08X\n", buf, loop, *shared_buffer[buf]);
+		}
+	}
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	for(loop = 0; loop < STRESS_NUM_BUFFERS; loop++){
+		free(shared_buffer[loop]);
+	}
+
+	free(shared_handle);
+	free(shared_buffer);
+	free(exec_object2);
+	free(batch_buffer);
+}
+
+/* gem_write_multipage_buffer 
+ * Create a buffer spanning multiple pages, and share with GPU. 
+ * Write to every element of the buffer
+ * and verify correct contents.
+
+ * Create 8K buffer
+ * Share with GPU using userptr ioctl
+ * Create batch buffer to write DATA in all elements of buffer
+ * Execute Batch Buffer
+ * Validate every element has DATA
+*/
+
+#define DWORD_SIZE sizeof(uint32_t)
+#define BB_SIZE ((MULTIPAGE_BO_SIZE / DWORD_SIZE) * STORE_BATCH_BUFFER_SIZE) + 2
+static void gem_write_multipage_buffer_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t* shared_buffer;
+	uint32_t shared_handle;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
+	uint32_t batch_buffer[BB_SIZE];
+	uint32_t batch_buf_handle;
+	int ring, len, j;
+	uint64_t pinning_offset=0x1000;
+	uint64_t vaddr;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, ALIASING_PPGTT));
+
+	batch_buf_handle = gem_create(fd, sizeof(batch_buffer));
+	shared_buffer = create_mem_buffer(MULTIPAGE_BO_SIZE);
+
+	len = 0;
+	memset(batch_buffer, 0, sizeof(batch_buffer));
+	memset(shared_buffer, 0, MULTIPAGE_BO_SIZE);
+
+	/* share with GPU */
+	shared_handle = init_userptr(fd, &userptr, shared_buffer, 
+					MULTIPAGE_BO_SIZE, false);
+	setup_exec_obj(&exec_object2[0], shared_handle, 
+			EXEC_OBJECT_PINNED, pinning_offset);
+
+	/* create command buffer with write commands */
+	vaddr = pinning_offset;
+	for(j=0; j< (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++){ 
+		/* BO_SIZE because it is 16K 4 byte entries */
+		len += gem_store_data_svm(fd, batch_buffer + (len/4), vaddr, 
+			j, (j == (((MULTIPAGE_BO_SIZE/sizeof(uint32_t))-1))) ?\
+			 true:false);
+		vaddr += sizeof(shared_buffer[0]);  /* 4 bytes */
+	}
+
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_handle);
+
+	for(j = 0; j < (MULTIPAGE_BO_SIZE/sizeof(uint32_t)); j++){
+		igt_fail_on_f(shared_buffer[j] != j,
+		"Mismatch in index %d: 0x%08X\n", j, shared_buffer[j]);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+
+	free(shared_buffer);
+}
+
+/* gem_pin_invalid_vma_test 
+ * This test will request to pin a shared buffer to an invalid
+ * VMA  > 48-bit address
+ * Create shared buffer of size 4K
+ * Try and Pin object to address 0x9000000000000
+*/
+static void gem_pin_invalid_vma_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd, ret;
+	uint32_t* shared_buffer = NULL;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS - 1];
+	uint32_t shared_buf_handle;
+	int ring;
+	uint64_t invalid_address = 0x9000000000000; /* 52 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+	
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE, false);
+	setup_exec_obj(&exec_object2[0], shared_buf_handle, 
+			EXEC_OBJECT_PINNED, invalid_address);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS - 1, 0);
+
+	/* Expect execbuf to fail */
+	ret = drmIoctl(fd,
+	       DRM_IOCTL_I915_GEM_EXECBUFFER2,
+	       &execbuf);
+
+	igt_assert_neq(ret, 0);
+	
+	close(fd);
+	free(shared_buffer);
+}
+
+
+/* gem_pin_high_address_test 
+ * This test will create a shared buffer, and create a command
+ * for GPU to write data in it. It will attempt to pin the buffer at address > 32 bits.
+ * CPU will read and make sure expected value is obtained
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use virtual address of buffer as 0x1100000000 (> 32 bit)
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to shared buffer VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+
+static void gem_pin_high_address_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t* shared_buffer = NULL;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address = 0x1111FFFF000; /* 44 bit address */
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE, false);
+ 
+	/* create command buffer with write command */
+	len = gem_store_data_svm(fd, batch_buffer, high_address, data, true);
+	gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+
+	/* submit command buffer */
+	setup_exec_obj(&exec_object2[0], shared_buf_handle, 
+		EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, high_address);
+	setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+	ring = I915_EXEC_RENDER;
+
+	setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
+	submit_and_sync(fd, &execbuf, batch_buf_handle);
+	gem_userptr_sync(fd, shared_buf_handle);
+
+	/* check on CPU to see if value changes */
+	igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, \
+		expected: 0x%x, got: 0x%x\n", data, shared_buffer[0]);
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+/* gem_pin_near_48Bit_test 
+ * This test will create a shared buffer, 
+ * and create a command for GPU to write data in it. It will attempt 
+ * to pin the buffer at address > 47 bits <= 48-bit.
+ * CPU will read and make sure expected value is obtained
+
+ * Malloc a 4K buffer
+ * Share buffer with with GPU by using userptr ioctl
+ * Create batch buffer to write DATA to first dword of buffer
+ * Use virtual address of buffer as range between 47-bit and 48-bit
+ * Set EXEC_OBJECT_PINNED flag in exec object
+ * Set 'offset' in exec object to shared buffer VMA
+ * Submit execbuffer
+ * Verify value of first DWORD in shared buffer matches DATA
+*/
+#define BEGIN_HIGH_ADDRESS 0x7FFFFFFFF000 
+#define END_HIGH_ADDRESS 0xFFFFFFFFC000
+#define ADDRESS_INCREMENT 0x2000000000
+static void gem_pin_near_48Bit_test(void)
+{
+	i915_gem_userptr userptr;
+	int fd;
+	uint32_t* shared_buffer = NULL;
+	struct drm_i915_gem_execbuffer2 execbuf;
+	struct drm_i915_gem_exec_object2 exec_object2[NUM_EXEC_OBJECTS];
+	uint32_t batch_buffer[BO_SIZE];
+	uint32_t batch_buf_handle, shared_buf_handle;
+	int ring, len;
+	const uint32_t data = 0x12345678;
+	uint64_t high_address;
+
+	fd = drm_open_driver(DRIVER_INTEL);
+	igt_require(uses_full_ppgtt(fd, FULL_48_BIT_PPGTT));
+
+	batch_buf_handle = gem_create(fd, BO_SIZE);
+
+	/* create cpu buffer, set to all 0xF's */
+	shared_buffer = create_mem_buffer(BO_SIZE);
+	*shared_buffer = 0xFFFFFFFF;
+
+	/* share with GPU */
+	shared_buf_handle = init_userptr(fd, &userptr, shared_buffer, BO_SIZE, false);
+
+	for (high_address = BEGIN_HIGH_ADDRESS; high_address <= END_HIGH_ADDRESS; 
+						high_address+=ADDRESS_INCREMENT){
+		/* create command buffer with write command */
+		len = gem_store_data_svm(fd, batch_buffer, high_address, 
+					data, true);
+		gem_write(fd, batch_buf_handle, 0, batch_buffer, len);
+		/* submit command buffer */
+		setup_exec_obj(&exec_object2[0], shared_buf_handle, 
+				EXEC_OBJECT_PINNED | EXEC_OBJECT_SUPPORTS_48B_ADDRESS, 
+				high_address);
+		setup_exec_obj(&exec_object2[1], batch_buf_handle, 0, 0);
+
+		ring = I915_EXEC_RENDER;
+		setup_execbuffer(&execbuf, exec_object2, ring, NUM_EXEC_OBJECTS, len);
+		submit_and_sync(fd, &execbuf, batch_buf_handle);
+		gem_userptr_sync(fd, shared_buf_handle);
+
+		/* check on CPU to see if value changes */
+		igt_fail_on_f(shared_buffer[0] != data,
+		"\nCPU read does not match GPU write, expected: 0x%x, \
+		got: 0x%x\n, 0x%"PRIx64"", data, shared_buffer[0], high_address);
+	}
+
+	gem_close(fd, batch_buf_handle);
+	close(fd);
+	free(shared_buffer);
+}
+
+
+int main(int argc, char* argv[])
+{
+	igt_subtest_init(argc, argv);
+	igt_skip_on_simulation();
+
+	/* All tests need PPGTT support */
+	igt_subtest("gem_basic"){
+		gem_basic_test();
+	}
+	igt_subtest("gem_multiple_process"){
+		gem_multiple_process_test();
+	}
+	igt_subtest("gem_repin"){
+		gem_repin_test();
+	}
+	igt_subtest("gem_pin_overlap"){
+		gem_pin_overlap_test();
+	}
+	igt_subtest("gem_write_multipage_buffer"){
+		gem_write_multipage_buffer_test();
+	}
+
+	/* Following tests need 48 Bit PPGTT support */
+	igt_subtest("gem_pin_invalid_vma"){
+		gem_pin_invalid_vma_test();
+	}
+	igt_subtest("gem_softpin_stress"){
+		gem_softpin_stress_test();
+	}
+	igt_subtest("gem_pin_high_address"){
+		gem_pin_high_address_test();
+	}
+	igt_subtest("gem_pin_near_48Bit"){
+		gem_pin_near_48Bit_test();
+	}
+
+	igt_exit();
+}
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2015-12-09 10:32 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-19 22:29 [PATCH i-g-t] tests/gem_softpin: New tests for softpin feature Vinay Belgaumkar
2015-11-20 16:20 ` Tvrtko Ursulin
2015-11-25 14:44 Vinay Belgaumkar
2015-11-26 16:09 ` Tvrtko Ursulin
2015-11-29 12:43 Vinay Belgaumkar
2015-11-30 14:16 ` Tvrtko Ursulin
2015-11-30 18:22 Vinay Belgaumkar
2015-12-01 10:35 ` Tvrtko Ursulin
2015-12-04  9:45   ` Daniel Vetter
2015-12-01 11:20 Vinay Belgaumkar
2015-12-02 10:24 ` Tvrtko Ursulin
2015-12-02 10:45   ` Tvrtko Ursulin
2015-12-02 12:24 Vinay Belgaumkar
2015-12-03 11:42 ` Tvrtko Ursulin
2015-12-03  8:36 Vinay Belgaumkar
2015-12-03 16:42 ` Tvrtko Ursulin
2015-12-08 11:57 ` Michel Thierry
2015-12-08 12:16   ` Tvrtko Ursulin
2015-12-09 10:32     ` Tvrtko Ursulin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.