[Buildroot] [PATCH 1/2] libnet: disable for musl toolchains

[Buildroot] [PATCH 1/2] libnet: disable for musl toolchains

[Joris Lijssens]

Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>
---
 package/libnet/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/libnet/Config.in b/package/libnet/Config.in
index 7186972..8a88128 100644
--- a/package/libnet/Config.in
+++ b/package/libnet/Config.in
@@ -1,7 +1,12 @@
 config BR2_PACKAGE_LIBNET
 	bool "libnet"
+	# Build with musl fails due to header issues
+	depends on !BR2_TOOLCHAIN_USES_MUSL
 	help
 	  libnet provides a portable framework for low-level network
 	  packet construction.
 
 	  http://sourceforge.net/projects/libnet-dev
+
+comment "libnet needs a (e)glibc or uClibc toolchain"
+	depends on BR2_TOOLCHAIN_USES_MUSL
-- 
1.8.3.1

[Buildroot] [PATCH 2/2] libnet: PF_PACKET is always available on Linux

[Joris Lijssens]

Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>
---
 package/libnet/libnet.mk | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/libnet/libnet.mk b/package/libnet/libnet.mk
index 3b62a79..1a5e610 100644
--- a/package/libnet/libnet.mk
+++ b/package/libnet/libnet.mk
@@ -7,7 +7,10 @@
 LIBNET_VERSION = 1.1.6
 LIBNET_SITE = http://sourceforge.net/projects/libnet-dev/files
 LIBNET_INSTALL_STAGING = YES
+# PF_PACKET is always available on Linux
+LIBNET_CONF_OPTS = libnet_cv_have_packet_socket=yes
 LIBNET_LICENSE = BSD-2c, BSD-3c
 LIBNET_LICENSE_FILES = doc/COPYING
 
+
 $(eval $(autotools-package))
-- 
1.8.3.1

[Buildroot] [PATCH 1/2] libnet: disable for musl toolchains

[Arnout Vandecappelle]

On 20-11-15 16:29, Joris Lijssens wrote:
> Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Regards,
 Arnout

> ---
>  package/libnet/Config.in | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/libnet/Config.in b/package/libnet/Config.in
> index 7186972..8a88128 100644
> --- a/package/libnet/Config.in
> +++ b/package/libnet/Config.in
> @@ -1,7 +1,12 @@
>  config BR2_PACKAGE_LIBNET
>  	bool "libnet"
> +	# Build with musl fails due to header issues
> +	depends on !BR2_TOOLCHAIN_USES_MUSL
>  	help
>  	  libnet provides a portable framework for low-level network
>  	  packet construction.
>  
>  	  http://sourceforge.net/projects/libnet-dev
> +
> +comment "libnet needs a (e)glibc or uClibc toolchain"
> +	depends on BR2_TOOLCHAIN_USES_MUSL
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 2/2] libnet: PF_PACKET is always available on Linux

[Arnout Vandecappelle]

On 20-11-15 16:29, Joris Lijssens wrote:
> Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>
> ---
>  package/libnet/libnet.mk | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/package/libnet/libnet.mk b/package/libnet/libnet.mk
> index 3b62a79..1a5e610 100644
> --- a/package/libnet/libnet.mk
> +++ b/package/libnet/libnet.mk
> @@ -7,7 +7,10 @@
>  LIBNET_VERSION = 1.1.6
>  LIBNET_SITE = http://sourceforge.net/projects/libnet-dev/files
>  LIBNET_INSTALL_STAGING = YES
> +# PF_PACKET is always available on Linux
> +LIBNET_CONF_OPTS = libnet_cv_have_packet_socket=yes
>  LIBNET_LICENSE = BSD-2c, BSD-3c
>  LIBNET_LICENSE_FILES = doc/COPYING
>  
> +

 This change is unnessary, but that can be fixed up during commit. Otherwise:
 Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

>  $(eval $(autotools-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 1/2] libnet: disable for musl toolchains

[Thomas Petazzoni]

Dear Joris Lijssens,

On Fri, 20 Nov 2015 16:29:27 +0100, Joris Lijssens wrote:
> Signed-off-by: Joris Lijssens <joris.lijssens@gmail.com>
> ---
>  package/libnet/Config.in | 5 +++++
>  1 file changed, 5 insertions(+)

Both patches applied to next, with the minor nit noticed by Arnout on
the second patch fixed.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com