All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andrew F. Davis" <afd@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>,
	devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/4] regulator: tps65086: Add regulator driver for the TPS65086 PMIC
Date: Sat, 21 Nov 2015 14:40:50 -0600	[thread overview]
Message-ID: <5650D6D2.5060108@ti.com> (raw)
In-Reply-To: <20151121133739.GG26072@sirena.org.uk>

On 11/21/2015 07:37 AM, Mark Brown wrote:
> On Thu, Nov 19, 2015 at 05:01:41PM -0600, Andrew F. Davis wrote:
>> Add support for TPS65086 PMIC regulators.
>>
>> The regulators set consists of 3 Step-down Controllers, 3 Step-down
>> Converters, 3 LDOs, 3 Load Switches, and a Sink and Source LDO. The
>> output voltages are configurable and are meant to supply power to a
>> SoC and/or other components.
>
> An earlier version of this patch has already been applied, please don't
> resend already applied patches but send incremental patches with any
> changes.
>

Odd, I didn't seem to get any message for this getting applied. Looks
like only a couple lines difference from the version in the regulators
branch, I don't imagine you are able to rebase that with these changes?

Anyway the reason that line needed changed is over a confusion in
what the 'of_node' does in 'struct regulator_config'. The description
seems to make it seem like it is the node that gets checked for
init data.

> * @of_node: OpenFirmware node to parse for device tree bindings (may be
> *           NULL).

But the 'of_node' that is actually searched is the one given in
regulator_config->dev->of_node. Is this intended behavior (drivers
assume it is so it probably has to be now) and if so, the above
description might need to be clarified as too what that 'of_node'
pointer really does?

WARNING: multiple messages have this Message-ID (diff)
From: "Andrew F. Davis" <afd@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Alexandre Courbot <gnurou@gmail.com>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Lee Jones <lee.jones@linaro.org>,
	Liam Girdwood <lgirdwood@gmail.com>, <devicetree@vger.kernel.org>,
	<linux-gpio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4 3/4] regulator: tps65086: Add regulator driver for the TPS65086 PMIC
Date: Sat, 21 Nov 2015 14:40:50 -0600	[thread overview]
Message-ID: <5650D6D2.5060108@ti.com> (raw)
In-Reply-To: <20151121133739.GG26072@sirena.org.uk>

On 11/21/2015 07:37 AM, Mark Brown wrote:
> On Thu, Nov 19, 2015 at 05:01:41PM -0600, Andrew F. Davis wrote:
>> Add support for TPS65086 PMIC regulators.
>>
>> The regulators set consists of 3 Step-down Controllers, 3 Step-down
>> Converters, 3 LDOs, 3 Load Switches, and a Sink and Source LDO. The
>> output voltages are configurable and are meant to supply power to a
>> SoC and/or other components.
>
> An earlier version of this patch has already been applied, please don't
> resend already applied patches but send incremental patches with any
> changes.
>

Odd, I didn't seem to get any message for this getting applied. Looks
like only a couple lines difference from the version in the regulators
branch, I don't imagine you are able to rebase that with these changes?

Anyway the reason that line needed changed is over a confusion in
what the 'of_node' does in 'struct regulator_config'. The description
seems to make it seem like it is the node that gets checked for
init data.

> * @of_node: OpenFirmware node to parse for device tree bindings (may be
> *           NULL).

But the 'of_node' that is actually searched is the one given in
regulator_config->dev->of_node. Is this intended behavior (drivers
assume it is so it probably has to be now) and if so, the above
description might need to be clarified as too what that 'of_node'
pointer really does?

  reply	other threads:[~2015-11-21 20:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-19 23:01 [PATCH v4 0/4] Add support for the TI TPS65086 PMIC Andrew F. Davis
2015-11-19 23:01 ` Andrew F. Davis
2015-11-19 23:01 ` [PATCH v4 1/4] Documentation: tps65086: Add DT bindings for the " Andrew F. Davis
2015-11-19 23:01   ` Andrew F. Davis
2015-11-20 16:33   ` Rob Herring
2015-11-23 16:09   ` Lee Jones
2015-11-23 16:09     ` Lee Jones
2015-11-19 23:01 ` [PATCH v4 2/4] mfd: tps65086: Add driver " Andrew F. Davis
2015-11-19 23:01   ` Andrew F. Davis
2015-11-23 16:20   ` Lee Jones
2015-11-19 23:01 ` [PATCH v4 3/4] regulator: tps65086: Add regulator " Andrew F. Davis
2015-11-19 23:01   ` Andrew F. Davis
2015-11-21 13:37   ` Mark Brown
2015-11-21 20:40     ` Andrew F. Davis [this message]
2015-11-21 20:40       ` Andrew F. Davis
2015-11-22 13:13       ` Mark Brown
2015-11-23 17:40         ` Andrew F. Davis
2015-11-23 17:40           ` Andrew F. Davis
2015-11-23 19:00           ` Mark Brown
2015-11-23 19:18             ` Andrew F. Davis
2015-11-23 19:18               ` Andrew F. Davis
2015-11-24 12:11               ` Mark Brown
2015-11-19 23:01 ` [PATCH v4 4/4] gpio: tps65086: Add GPO " Andrew F. Davis
2015-11-19 23:01   ` Andrew F. Davis
     [not found]   ` <1447974102-24938-5-git-send-email-afd-l0cyMroinI0@public.gmane.org>
2015-11-30  8:50     ` Linus Walleij
2015-11-30  8:50       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5650D6D2.5060108@ti.com \
    --to=afd@ti.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=gnurou@gmail.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.