[PATCH 1/2] ARM: dts: rockchip: update the thermal management on rk3288

[PATCH 1/2] ARM: dts: rockchip: update the thermal management on rk3288

[Heiko Stübner]

From: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>

In some cases the machine radiating is very poor,sometime the temperature
is rising very quickly on heavy loading.So we need have more frequent
polling and better granularity.

Signed-off-by: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Reviewed-by: Dmitry Torokhov <dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Signed-off-by: Heiko Stuebner <heiko.stuebner-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
---
 arch/arm/boot/dts/rk3288-thermal.dtsi | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/rk3288-thermal.dtsi b/arch/arm/boot/dts/rk3288-thermal.dtsi
index 3404066..651b962 100644
--- a/arch/arm/boot/dts/rk3288-thermal.dtsi
+++ b/arch/arm/boot/dts/rk3288-thermal.dtsi
@@ -52,7 +52,7 @@ reserve_thermal: reserve_thermal {
 };
 
 cpu_thermal: cpu_thermal {
-	polling-delay-passive = <1000>; /* milliseconds */
+	polling-delay-passive = <100>; /* milliseconds */
 	polling-delay = <5000>; /* milliseconds */
 
 	thermal-sensors = <&tsadc 1>;
@@ -63,6 +63,11 @@ cpu_thermal: cpu_thermal {
 			hysteresis = <2000>; /* millicelsius */
 			type = "passive";
 		};
+		cpu_alert1: cpu_alert1 {
+			temperature = <75000>; /* millicelsius */
+			hysteresis = <2000>; /* millicelsius */
+			type = "passive";
+		};
 		cpu_crit: cpu_crit {
 			temperature = <90000>; /* millicelsius */
 			hysteresis = <2000>; /* millicelsius */
@@ -74,13 +79,18 @@ cpu_thermal: cpu_thermal {
 		map0 {
 			trip = <&cpu_alert0>;
 			cooling-device =
+				<&cpu0 THERMAL_NO_LIMIT 6>;
+		};
+		map1 {
+			trip = <&cpu_alert1>;
+			cooling-device =
 				<&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
 		};
 	};
 };
 
 gpu_thermal: gpu_thermal {
-	polling-delay-passive = <1000>; /* milliseconds */
+	polling-delay-passive = <100>; /* milliseconds */
 	polling-delay = <5000>; /* milliseconds */
 
 	thermal-sensors = <&tsadc 2>;
-- 
2.6.1

[PATCH 1/2] ARM: dts: rockchip: update the thermal management on rk3288

[Heiko Stübner]

From: Caesar Wang <wxt@rock-chips.com>

In some cases the machine radiating is very poor,sometime the temperature
is rising very quickly on heavy loading.So we need have more frequent
polling and better granularity.

Signed-off-by: Caesar Wang <wxt@rock-chips.com>
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>
Signed-off-by: Heiko Stuebner <heiko.stuebner@collabora.com>
---
 arch/arm/boot/dts/rk3288-thermal.dtsi | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/rk3288-thermal.dtsi b/arch/arm/boot/dts/rk3288-thermal.dtsi
index 3404066..651b962 100644
--- a/arch/arm/boot/dts/rk3288-thermal.dtsi
+++ b/arch/arm/boot/dts/rk3288-thermal.dtsi
@@ -52,7 +52,7 @@ reserve_thermal: reserve_thermal {
 };
 
 cpu_thermal: cpu_thermal {
-	polling-delay-passive = <1000>; /* milliseconds */
+	polling-delay-passive = <100>; /* milliseconds */
 	polling-delay = <5000>; /* milliseconds */
 
 	thermal-sensors = <&tsadc 1>;
@@ -63,6 +63,11 @@ cpu_thermal: cpu_thermal {
 			hysteresis = <2000>; /* millicelsius */
 			type = "passive";
 		};
+		cpu_alert1: cpu_alert1 {
+			temperature = <75000>; /* millicelsius */
+			hysteresis = <2000>; /* millicelsius */
+			type = "passive";
+		};
 		cpu_crit: cpu_crit {
 			temperature = <90000>; /* millicelsius */
 			hysteresis = <2000>; /* millicelsius */
@@ -74,13 +79,18 @@ cpu_thermal: cpu_thermal {
 		map0 {
 			trip = <&cpu_alert0>;
 			cooling-device =
+				<&cpu0 THERMAL_NO_LIMIT 6>;
+		};
+		map1 {
+			trip = <&cpu_alert1>;
+			cooling-device =
 				<&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
 		};
 	};
 };
 
 gpu_thermal: gpu_thermal {
-	polling-delay-passive = <1000>; /* milliseconds */
+	polling-delay-passive = <100>; /* milliseconds */
 	polling-delay = <5000>; /* milliseconds */
 
 	thermal-sensors = <&tsadc 2>;
-- 
2.6.1

[PATCH 2/2] ARM: dts: rockchip: override thermal settings on veyron-speedy

[Heiko Stübner]

According to a commit on the ChromeOS kernel, the temperature of the Speedy
surface is over skin temperature spec. So adjust the thermal settings
to mimic the ChromeOS tree to stay within these spec limits.

Signed-off-by: Heiko Stuebner <heiko.stuebner-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>
---
 arch/arm/boot/dts/rk3288-veyron-speedy.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-veyron-speedy.dts b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
index a7ea7d0..b34a7b5 100644
--- a/arch/arm/boot/dts/rk3288-veyron-speedy.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
@@ -88,6 +88,14 @@
 	};
 };
 
+&cpu_alert0 {
+	temperature = <65000>;
+};
+
+&cpu_alert1 {
+	temperature = <70000>;
+};
+
 &rk808 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pmic_int_l>;
-- 
2.6.1

[PATCH 2/2] ARM: dts: rockchip: override thermal settings on veyron-speedy

[Heiko Stübner]

According to a commit on the ChromeOS kernel, the temperature of the Speedy
surface is over skin temperature spec. So adjust the thermal settings
to mimic the ChromeOS tree to stay within these spec limits.

Signed-off-by: Heiko Stuebner <heiko.stuebner@collabora.com>
---
 arch/arm/boot/dts/rk3288-veyron-speedy.dts | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/rk3288-veyron-speedy.dts b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
index a7ea7d0..b34a7b5 100644
--- a/arch/arm/boot/dts/rk3288-veyron-speedy.dts
+++ b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
@@ -88,6 +88,14 @@
 	};
 };
 
+&cpu_alert0 {
+	temperature = <65000>;
+};
+
+&cpu_alert1 {
+	temperature = <70000>;
+};
+
 &rk808 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pmic_int_l>;
-- 
2.6.1

Re: [PATCH 2/2] ARM: dts: rockchip: override thermal settings on veyron-speedy

[Caesar Wang]

Hi Heiko,

在 2015年11月30日 21:14, Heiko Stübner 写道:
> According to a commit on the ChromeOS kernel, the temperature of the Speedy
> surface is over skin temperature spec. So adjust the thermal settings
> to mimic the ChromeOS tree to stay within these spec limits.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@collabora.com>
> ---
>   arch/arm/boot/dts/rk3288-veyron-speedy.dts | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron-speedy.dts b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
> index a7ea7d0..b34a7b5 100644
> --- a/arch/arm/boot/dts/rk3288-veyron-speedy.dts
> +++ b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
> @@ -88,6 +88,14 @@
>   	};
>   };
>   
> +&cpu_alert0 {
> +	temperature = <65000>;
> +};
> +
> +&cpu_alert1 {
> +	temperature = <70000>;
> +};
> +


Yep, as the mass of thermal data from OEM with all kinds of testing.
The 65/70 degree is very suit for speedy. (e.g.: Power, Performance).

So,  feel free add my tag: :-)

Reviewed-by: Caesar Wang <wxt@rock-chips.com>


>   &rk808 {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&pmic_int_l>;

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

[PATCH 2/2] ARM: dts: rockchip: override thermal settings on veyron-speedy

[Caesar Wang]

Hi Heiko,

? 2015?11?30? 21:14, Heiko St?bner ??:
> According to a commit on the ChromeOS kernel, the temperature of the Speedy
> surface is over skin temperature spec. So adjust the thermal settings
> to mimic the ChromeOS tree to stay within these spec limits.
>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@collabora.com>
> ---
>   arch/arm/boot/dts/rk3288-veyron-speedy.dts | 8 ++++++++
>   1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-veyron-speedy.dts b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
> index a7ea7d0..b34a7b5 100644
> --- a/arch/arm/boot/dts/rk3288-veyron-speedy.dts
> +++ b/arch/arm/boot/dts/rk3288-veyron-speedy.dts
> @@ -88,6 +88,14 @@
>   	};
>   };
>   
> +&cpu_alert0 {
> +	temperature = <65000>;
> +};
> +
> +&cpu_alert1 {
> +	temperature = <70000>;
> +};
> +


Yep, as the mass of thermal data from OEM with all kinds of testing.
The 65/70 degree is very suit for speedy. (e.g.: Power, Performance).

So,  feel free add my tag: :-)

Reviewed-by: Caesar Wang <wxt@rock-chips.com>


>   &rk808 {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&pmic_int_l>;

Re: [PATCH 1/2] ARM: dts: rockchip: update the thermal management on rk3288

[Heiko Stübner]

Hi Dmitry,

Am Montag, 30. November 2015, 14:13:17 schrieb Heiko Stübner:
> From: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> 
> In some cases the machine radiating is very poor,sometime the temperature
> is rising very quickly on heavy loading.So we need have more frequent
> polling and better granularity.
> 
> Signed-off-by: Caesar Wang <wxt-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> Reviewed-by: Dmitry Torokhov <dtor-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> Signed-off-by: Heiko Stuebner <heiko.stuebner-ZGY8ohtN/8qB+jHODAdFcQ@public.gmane.org>

it looks like I forget to Cc you on this mail, because I'd like to keep your 
Reviewed-by tag :-) . So can I keep your tag? Otherwise I'll just drop it when 
applying.


Thanks
Heiko

> ---
>  arch/arm/boot/dts/rk3288-thermal.dtsi | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/rk3288-thermal.dtsi
> b/arch/arm/boot/dts/rk3288-thermal.dtsi index 3404066..651b962 100644
> --- a/arch/arm/boot/dts/rk3288-thermal.dtsi
> +++ b/arch/arm/boot/dts/rk3288-thermal.dtsi
> @@ -52,7 +52,7 @@ reserve_thermal: reserve_thermal {
>  };
> 
>  cpu_thermal: cpu_thermal {
> -	polling-delay-passive = <1000>; /* milliseconds */
> +	polling-delay-passive = <100>; /* milliseconds */
>  	polling-delay = <5000>; /* milliseconds */
> 
>  	thermal-sensors = <&tsadc 1>;
> @@ -63,6 +63,11 @@ cpu_thermal: cpu_thermal {
>  			hysteresis = <2000>; /* millicelsius */
>  			type = "passive";
>  		};
> +		cpu_alert1: cpu_alert1 {
> +			temperature = <75000>; /* millicelsius */
> +			hysteresis = <2000>; /* millicelsius */
> +			type = "passive";
> +		};
>  		cpu_crit: cpu_crit {
>  			temperature = <90000>; /* millicelsius */
>  			hysteresis = <2000>; /* millicelsius */
> @@ -74,13 +79,18 @@ cpu_thermal: cpu_thermal {
>  		map0 {
>  			trip = <&cpu_alert0>;
>  			cooling-device =
> +				<&cpu0 THERMAL_NO_LIMIT 6>;
> +		};
> +		map1 {
> +			trip = <&cpu_alert1>;
> +			cooling-device =
>  				<&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>  		};
>  	};
>  };
> 
>  gpu_thermal: gpu_thermal {
> -	polling-delay-passive = <1000>; /* milliseconds */
> +	polling-delay-passive = <100>; /* milliseconds */
>  	polling-delay = <5000>; /* milliseconds */
> 
>  	thermal-sensors = <&tsadc 2>;

[PATCH 1/2] ARM: dts: rockchip: update the thermal management on rk3288

[Heiko Stübner]

Hi Dmitry,

Am Montag, 30. November 2015, 14:13:17 schrieb Heiko St?bner:
> From: Caesar Wang <wxt@rock-chips.com>
> 
> In some cases the machine radiating is very poor,sometime the temperature
> is rising very quickly on heavy loading.So we need have more frequent
> polling and better granularity.
> 
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Reviewed-by: Dmitry Torokhov <dtor@chromium.org>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@collabora.com>

it looks like I forget to Cc you on this mail, because I'd like to keep your 
Reviewed-by tag :-) . So can I keep your tag? Otherwise I'll just drop it when 
applying.


Thanks
Heiko

> ---
>  arch/arm/boot/dts/rk3288-thermal.dtsi | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/rk3288-thermal.dtsi
> b/arch/arm/boot/dts/rk3288-thermal.dtsi index 3404066..651b962 100644
> --- a/arch/arm/boot/dts/rk3288-thermal.dtsi
> +++ b/arch/arm/boot/dts/rk3288-thermal.dtsi
> @@ -52,7 +52,7 @@ reserve_thermal: reserve_thermal {
>  };
> 
>  cpu_thermal: cpu_thermal {
> -	polling-delay-passive = <1000>; /* milliseconds */
> +	polling-delay-passive = <100>; /* milliseconds */
>  	polling-delay = <5000>; /* milliseconds */
> 
>  	thermal-sensors = <&tsadc 1>;
> @@ -63,6 +63,11 @@ cpu_thermal: cpu_thermal {
>  			hysteresis = <2000>; /* millicelsius */
>  			type = "passive";
>  		};
> +		cpu_alert1: cpu_alert1 {
> +			temperature = <75000>; /* millicelsius */
> +			hysteresis = <2000>; /* millicelsius */
> +			type = "passive";
> +		};
>  		cpu_crit: cpu_crit {
>  			temperature = <90000>; /* millicelsius */
>  			hysteresis = <2000>; /* millicelsius */
> @@ -74,13 +79,18 @@ cpu_thermal: cpu_thermal {
>  		map0 {
>  			trip = <&cpu_alert0>;
>  			cooling-device =
> +				<&cpu0 THERMAL_NO_LIMIT 6>;
> +		};
> +		map1 {
> +			trip = <&cpu_alert1>;
> +			cooling-device =
>  				<&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>;
>  		};
>  	};
>  };
> 
>  gpu_thermal: gpu_thermal {
> -	polling-delay-passive = <1000>; /* milliseconds */
> +	polling-delay-passive = <100>; /* milliseconds */
>  	polling-delay = <5000>; /* milliseconds */
> 
>  	thermal-sensors = <&tsadc 2>;

Re: [PATCH 1/2] ARM: dts: rockchip: update the thermal management on rk3288

[Heiko Stübner]

Am Montag, 30. November 2015, 14:13:17 schrieb Heiko Stübner:
> From: Caesar Wang <wxt@rock-chips.com>
> 
> In some cases the machine radiating is very poor,sometime the temperature
> is rising very quickly on heavy loading.So we need have more frequent
> polling and better granularity.
> 
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Reviewed-by: Dmitry Torokhov <dtor@chromium.org>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@collabora.com>

applied both patches to my dts32 branch for 4.5

[PATCH 1/2] ARM: dts: rockchip: update the thermal management on rk3288

[Heiko Stübner]

Am Montag, 30. November 2015, 14:13:17 schrieb Heiko St?bner:
> From: Caesar Wang <wxt@rock-chips.com>
> 
> In some cases the machine radiating is very poor,sometime the temperature
> is rising very quickly on heavy loading.So we need have more frequent
> polling and better granularity.
> 
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
> Reviewed-by: Dmitry Torokhov <dtor@chromium.org>
> Signed-off-by: Heiko Stuebner <heiko.stuebner@collabora.com>

applied both patches to my dts32 branch for 4.5