From: "H. Peter Anvin" <hpa@zytor.com>
To: Sinclair Yeh <syeh@vmware.com>, x86@kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Alok Kataria <akataria@vmware.com>,
linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Xavier Deguillard <xdeguillard@vmware.com>
Subject: Re: [PATCH 1/6] x86: Add VMWare Host Communication Macros
Date: Tue, 1 Dec 2015 14:49:11 -0800 [thread overview]
Message-ID: <565E23E7.5090800@zytor.com> (raw)
In-Reply-To: <1449008332-9394-1-git-send-email-syeh@vmware.com>
On 12/01/15 14:18, Sinclair Yeh wrote:
> These macros will be used by multiple VMWare modules for handling
> host communication.
> + __asm__ __volatile__ ("inl %%dx" : \
This is odd at best; the standard assembly form of this instruction is:
inl (%dx),%eax
Also, we don't need the underscored forms of asm and volatile for kernel
code.
> + __asm__ __volatile__ ("movq %13, %%rbp;" \
> + "cld; rep outsb; " \
> + "movq %%rbp, %6" : \
cld shouldn't be necessary here, DF=0 is part of the normal ABI environment.
You also don't save/restore %rbp here, but you do below? Seems very odd.
It might be better do so something like:
+#define VMW_PORT_HB_OUT(in1, in2, port_num, magic, \
+ eax, ebx, ecx, edx, si, di, bp) \
+({ \
+ __asm__ __volatile__ ("xchgq %6, %%rbp;" \
+ "cld; rep outsb; " \
+ "xchgq %%rbp, %6" : \
+ "=a"(eax), \
+ "=b"(ebx), \
+ "=c"(ecx), \
+ "=d"(edx), \
+ "+S"(si), \
+ "+D"(di), \
+ "+r"(bp) : \
+ "a"(magic), \
+ "b"(in1), \
+ "c"(in2), \
+ "d"(port_num) : \
+ "memory", "cc"); \
+})
next prev parent reply other threads:[~2015-12-01 22:49 UTC|newest]
Thread overview: 96+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1449008047-8252-1-git-send-email-syeh@vmware.com>
2015-12-01 22:18 ` [PATCH 1/6] x86: Add VMWare Host Communication Macros Sinclair Yeh
2015-12-01 22:18 ` Sinclair Yeh
2015-12-01 22:18 ` [PATCH 2/6] x86: Update vmware.c to use the common VMW_PORT macros Sinclair Yeh
2015-12-01 22:18 ` Sinclair Yeh
2015-12-01 22:18 ` [PATCH 3/6] Input: Update vmmouse.c " Sinclair Yeh
2015-12-01 22:18 ` Sinclair Yeh
2015-12-01 22:24 ` Dmitry Torokhov
2015-12-01 22:32 ` Sinclair Yeh
2015-12-01 22:45 ` Dmitry Torokhov
2015-12-01 22:45 ` Dmitry Torokhov
2015-12-01 22:45 ` Dmitry Torokhov
2015-12-01 22:54 ` Sinclair Yeh
2015-12-01 22:54 ` Sinclair Yeh
2015-12-01 23:56 ` Dmitry Torokhov
2015-12-01 23:56 ` Dmitry Torokhov
2015-12-01 23:56 ` Dmitry Torokhov
2015-12-02 0:04 ` Greg Kroah-Hartman
2015-12-02 0:04 ` Greg Kroah-Hartman
2015-12-02 2:21 ` Sinclair Yeh
2015-12-02 2:21 ` Sinclair Yeh
2015-12-02 15:31 ` Greg Kroah-Hartman
2015-12-02 15:31 ` Greg Kroah-Hartman
2015-12-02 15:57 ` Sinclair Yeh
2015-12-02 15:57 ` Sinclair Yeh
2015-12-02 15:57 ` Sinclair Yeh
2015-12-02 17:26 ` Dmitry Torokhov
2015-12-02 17:26 ` Dmitry Torokhov
2015-12-02 17:29 ` [Linux-graphics-maintainer] " Thomas Hellstrom
2015-12-02 17:29 ` Thomas Hellstrom
2015-12-02 18:45 ` Greg Kroah-Hartman
2015-12-02 18:45 ` Greg Kroah-Hartman
2015-12-02 18:58 ` Dmitry Torokhov
2015-12-02 18:58 ` Dmitry Torokhov
2015-12-02 18:58 ` Dmitry Torokhov
2015-12-02 19:02 ` Sinclair Yeh
2015-12-02 19:02 ` Sinclair Yeh
2015-12-02 2:21 ` Sinclair Yeh
2015-12-02 7:07 ` [Linux-graphics-maintainer] " Thomas Hellstrom
2015-12-02 7:07 ` Thomas Hellstrom
2015-12-02 7:07 ` Thomas Hellstrom
2015-12-01 22:32 ` Sinclair Yeh
2015-12-01 22:24 ` Dmitry Torokhov
2015-12-02 0:01 ` Greg Kroah-Hartman
2015-12-02 0:01 ` Greg Kroah-Hartman
2015-12-01 22:18 ` [PATCH 4/6] Input: Remove vmmouse port reservation Sinclair Yeh
2015-12-01 22:30 ` Dmitry Torokhov
2015-12-01 22:30 ` Dmitry Torokhov
2015-12-01 23:04 ` Sinclair Yeh
2015-12-01 23:04 ` Sinclair Yeh
2015-12-01 23:52 ` Dmitry Torokhov
2015-12-01 23:52 ` Dmitry Torokhov
2015-12-01 22:18 ` Sinclair Yeh
2015-12-01 22:18 ` [PATCH 5/6] x86: Remove address from the vmware.c header Sinclair Yeh
2015-12-01 22:18 ` [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro Sinclair Yeh
2015-12-01 22:38 ` Xavier Deguillard
2015-12-01 23:17 ` Sinclair Yeh
2015-12-01 23:17 ` Sinclair Yeh
2015-12-01 22:38 ` Xavier Deguillard
2015-12-01 22:18 ` Sinclair Yeh
2015-12-01 22:32 ` [PATCH 1/6] x86: Add VMWare Host Communication Macros Xavier Deguillard
2015-12-01 22:32 ` Xavier Deguillard
2015-12-01 22:49 ` H. Peter Anvin [this message]
2015-12-04 22:33 ` Sinclair Yeh
2015-12-04 22:33 ` Sinclair Yeh
2015-12-01 22:49 ` H. Peter Anvin
[not found] ` <1449271183-1746-1-git-send-email-syeh@vmware.com>
2015-12-04 23:19 ` Sinclair Yeh
2015-12-04 23:19 ` Sinclair Yeh
2015-12-04 23:19 ` [PATCH 2/6] x86: Update vmware.c to use the common VMW_PORT macros Sinclair Yeh
2015-12-04 23:19 ` Sinclair Yeh
2015-12-04 23:19 ` [PATCH 3/6] Input: Update vmmouse.c " Sinclair Yeh
2015-12-04 23:19 ` Sinclair Yeh
2015-12-04 23:19 ` [PATCH 4/6] Input: Remove vmmouse port reservation Sinclair Yeh
2015-12-04 23:19 ` Sinclair Yeh
2015-12-04 23:19 ` [PATCH 5/6] x86: Remove address from the vmware.c header Sinclair Yeh
2015-12-04 23:19 ` [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro Sinclair Yeh
2015-12-04 23:19 ` Sinclair Yeh
2016-01-19 21:45 ` [PATCH 0/6] Create common VMWare host port communication macros v3 Sinclair Yeh
2016-01-19 21:46 ` [PATCH 1/6] x86: Add VMWare Host Communication Macros Sinclair Yeh
2016-01-19 21:46 ` Sinclair Yeh
2016-01-19 21:46 ` [PATCH 2/6] x86: Update vmware.c to use the common VMW_PORT macros Sinclair Yeh
2016-01-19 21:46 ` Sinclair Yeh
2016-01-19 21:46 ` [PATCH 3/6] Input: Update vmmouse.c " Sinclair Yeh
2016-01-19 21:46 ` Sinclair Yeh
2016-01-19 21:46 ` [PATCH 4/6] Input: Remove vmmouse port reservation Sinclair Yeh
2016-01-19 21:46 ` Sinclair Yeh
2016-01-19 21:46 ` [PATCH 5/6] x86: Remove address from the vmware.c header Sinclair Yeh
2016-01-19 21:46 ` [PATCH 6/6] VMware balloon: Update vmw_balloon.c to use the VMW_PORT macro Sinclair Yeh
2016-01-19 21:46 ` Sinclair Yeh
2016-02-08 19:41 ` Greg KH
2016-02-08 19:41 ` Greg KH
2016-03-31 14:39 ` Sinclair Yeh
2016-03-31 14:39 ` Sinclair Yeh
2016-03-31 16:30 ` Greg KH
2016-03-31 16:30 ` Greg KH
2016-03-31 17:32 ` Sinclair Yeh
2016-03-31 17:32 ` Sinclair Yeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=565E23E7.5090800@zytor.com \
--to=hpa@zytor.com \
--cc=akataria@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=syeh@vmware.com \
--cc=tglx@linutronix.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xdeguillard@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.