From: Simon Arlott <simon@fire.lp0.eu> To: Mark Brown <broonie@kernel.org> Cc: devicetree@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Kumar Gala <galak@codeaurora.org>, linux-kernel@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>, Jonas Gorski <jogo@openwrt.org> Subject: Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree binding Date: Wed, 2 Dec 2015 20:26:36 +0000 [thread overview] Message-ID: <565F53FC.5080309@simon.arlott.org.uk> (raw) In-Reply-To: <20151202125325.GI1929@sirena.org.uk> On 02/12/15 12:53, Mark Brown wrote: > On Wed, Dec 02, 2015 at 12:45:50PM -0000, Simon Arlott wrote: >> On Tue, December 1, 2015 22:16, Mark Brown wrote: > >> > Why are these in the DT, I would expect that if this is a driver for a >> > specific SoC all these properties would be known as a result of that. > >> This is a driver for multiple SoCs with the same regulator control in >> different places on different SoCs, so the location of it within the misc >> register needs to be provided in the DT: > >> BCM6362: >> #define MISC_BASE 0xb0001800 /* Miscellaneous Registers */ >> uint32 miscIddqCtrl; /* 0x48 */ > > This is the sort of thing you can pick up from the SoC compatible > strings. As things stand there is zero content in this driver that > relates to this SoC. There's always going to be very little content in the driver that relates to this SoC, given that a single bit flip enables/disables power. All other device tree drivers allow a register address to be specified for the device, how is an offset in the regmap any different? >> The mask is used as there's one bit per regulator in the register, but >> there's more than one way to express this in the DT: > > I wouldn't expect to see it in the device tree at all for a device > specific driver. If there isn't an individual entry in DT for each regulator, how is it supposed to work? There's no #regulator-cells property. -- Simon Arlott
WARNING: multiple messages have this Message-ID (diff)
From: Simon Arlott <simon-A6De1vDTPLDsq35pWSNszA@public.gmane.org> To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>, Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, Ian Campbell <ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>, Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Florian Fainelli <f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Jonas Gorski <jogo-p3rKhJxN3npAfugRpC6u6w@public.gmane.org> Subject: Re: [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree binding Date: Wed, 2 Dec 2015 20:26:36 +0000 [thread overview] Message-ID: <565F53FC.5080309@simon.arlott.org.uk> (raw) In-Reply-To: <20151202125325.GI1929-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> On 02/12/15 12:53, Mark Brown wrote: > On Wed, Dec 02, 2015 at 12:45:50PM -0000, Simon Arlott wrote: >> On Tue, December 1, 2015 22:16, Mark Brown wrote: > >> > Why are these in the DT, I would expect that if this is a driver for a >> > specific SoC all these properties would be known as a result of that. > >> This is a driver for multiple SoCs with the same regulator control in >> different places on different SoCs, so the location of it within the misc >> register needs to be provided in the DT: > >> BCM6362: >> #define MISC_BASE 0xb0001800 /* Miscellaneous Registers */ >> uint32 miscIddqCtrl; /* 0x48 */ > > This is the sort of thing you can pick up from the SoC compatible > strings. As things stand there is zero content in this driver that > relates to this SoC. There's always going to be very little content in the driver that relates to this SoC, given that a single bit flip enables/disables power. All other device tree drivers allow a register address to be specified for the device, how is an offset in the regmap any different? >> The mask is used as there's one bit per regulator in the register, but >> there's more than one way to express this in the DT: > > I wouldn't expect to see it in the device tree at all for a device > specific driver. If there isn't an individual entry in DT for each regulator, how is it supposed to work? There's no #regulator-cells property. -- Simon Arlott -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-02 20:26 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-11-28 21:13 [PATCH 1/2] regulator: Add regmap support to regulator-fixed device tree binding Simon Arlott 2015-11-28 21:14 ` [PATCH 2/2] regulator: fixed: Add support for regmap Simon Arlott 2015-11-28 21:14 ` Simon Arlott 2015-11-30 12:10 ` [PATCH 1/2] regulator: Add regmap support to regulator-fixed device tree binding Mark Brown 2015-11-30 12:10 ` Mark Brown 2015-11-30 20:30 ` [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator " Simon Arlott 2015-11-30 20:30 ` [PATCH 2/2] regulator: bcm63xx: Add BCM63xx fixed regulator device Simon Arlott 2015-11-30 20:38 ` [PATCH (v2) " Simon Arlott 2015-12-01 15:11 ` Mark Brown 2015-12-01 15:11 ` Mark Brown 2015-12-01 22:16 ` [PATCH 1/2] regulator: Add brcm,bcm63xx-regulator device tree binding Mark Brown 2015-12-01 22:16 ` Mark Brown 2015-12-02 12:45 ` Simon Arlott 2015-12-02 12:53 ` Mark Brown 2015-12-02 20:26 ` Simon Arlott [this message] 2015-12-02 20:26 ` Simon Arlott 2015-12-03 0:06 ` Mark Brown 2015-12-03 8:14 ` Simon Arlott 2015-12-03 8:14 ` Simon Arlott 2015-12-03 15:05 ` Mark Brown 2015-12-03 15:05 ` Mark Brown 2015-12-03 23:38 ` Simon Arlott 2015-12-03 23:38 ` Simon Arlott 2015-12-03 23:45 ` Mark Brown 2015-12-03 23:51 ` Simon Arlott 2015-12-04 11:00 ` Mark Brown 2015-12-04 12:26 ` Simon Arlott 2015-12-04 14:31 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=565F53FC.5080309@simon.arlott.org.uk \ --to=simon@fire.lp0.eu \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=f.fainelli@gmail.com \ --cc=galak@codeaurora.org \ --cc=ijc+devicetree@hellion.org.uk \ --cc=jogo@openwrt.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=pawel.moll@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.