Re: [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {}

From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: peter.maydell@linaro.org, david@gibson.dropbear.id.au,
	qemu-ppc@nongnu.org, qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {}
Date: Thu, 3 Dec 2015 10:30:38 -0700	[thread overview]
Message-ID: <56607C3E.8000100@redhat.com> (raw)
In-Reply-To: <87r3j3jw0l.fsf@blackfin.pond.sub.org>

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

On 12/03/2015 10:13 AM, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
> 
>> On 12/03/2015 09:37 AM, Markus Armbruster wrote:
>>> prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't
>>> visit anything.  object_property_get_qobject() happily
>>> object_property_get_qobject().  Amazingly, the latter survives the
>>
>> Something got lost or otherwise corrupted in that sentence.  Were you
>> trying to say one function happily calls another?  If so, which of the
>> two "object_property_get_qobject()" strings should be changed, to what?
> 
> No idea what happened.  Correction: insert "calls" after "happily":
> 
>     prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't
>     visit anything.  object_property_get_qobject() happily calls
>     object_property_get_qobject().

That still reads "A() happily calls A()" - are we talking about
recursion here?  I still wonder if you meant a second function name,
and/or mention of the fact that we are calling a function with NULL
rather than a QObject?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]