Re: [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {}

From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: peter.maydell@linaro.org, agraf@suse.de, qemu-ppc@nongnu.org,
	qemu-devel@nongnu.org, david@gibson.dropbear.id.au
Subject: Re: [Qemu-devel] [PATCH for-2.5 2/3] spapr_drc: Change value of property "fdt" from null back to {}
Date: Fri, 4 Dec 2015 06:22:24 -0700	[thread overview]
Message-ID: <56619390.3000306@redhat.com> (raw)
In-Reply-To: <87r3j3fmcn.fsf@blackfin.pond.sub.org>

[-- Attachment #1: Type: text/plain, Size: 712 bytes --]

On 12/03/2015 10:55 AM, Markus Armbruster wrote:

> I'm incapable of proof-reading anything I wrote myself %-}

I know the feeling :)

> 
>     prop_get_fdt() misuses the visitor API: when fdt is null, it doesn't
>     visit anything.  object_property_get_qobject() happily calls
>     qmp_output_get_qobject() then.  Amazingly, the latter survives the
>     misuse.  Turns out we've papered over it long before prop_get_fdt()
>     existed, in commit 1d10b44.

Oh well, it got pushed to master with original confusing spelling after
all (commit ab8bf1d7).  Not the end of the world :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]