* [Buildroot] [PATCH 0/2] package/gawk: handle optional dependencies on mpfr and readline (branch yem/host-gawk)
@ 2015-12-03 22:22 Yann E. MORIN
2015-12-03 22:22 ` [Buildroot] [PATCH 1/2] package/gawk: clean the mpfr dependency Yann E. MORIN
2015-12-03 22:22 ` [Buildroot] [PATCH 2/2] package/gawk: add optional readline dependency Yann E. MORIN
0 siblings, 2 replies; 7+ messages in thread
From: Yann E. MORIN @ 2015-12-03 22:22 UTC (permalink / raw)
To: buildroot
Hello All!
This series adds better handling of the dependency on MPFR, and handles
the optional dependency on readline.
Regards,
Yann E. MORIN.
The following changes since commit ab2e5dddfc9ea4a8214f8d968b9aab9617e01998:
wireshark: add optional geoip support (2015-12-03 22:38:31 +0100)
are available in the git repository at:
git://git.busybox.net/~ymorin/git/buildroot yem/host-gawk
for you to fetch changes up to f37416a8d0f491f30efbc89ddd3a2ce82e56b65c:
package/gawk: add optional readline dependency (2015-12-03 23:20:01 +0100)
----------------------------------------------------------------
Yann E. MORIN (2):
package/gawk: clean the mpfr dependency
package/gawk: add optional readline dependency
package/gawk/gawk.mk | 16 +++++++++++++++-
1 file changed, 15 insertions(+), 1 deletion(-)
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] package/gawk: clean the mpfr dependency
2015-12-03 22:22 [Buildroot] [PATCH 0/2] package/gawk: handle optional dependencies on mpfr and readline (branch yem/host-gawk) Yann E. MORIN
@ 2015-12-03 22:22 ` Yann E. MORIN
2015-12-03 23:35 ` Arnout Vandecappelle
2015-12-03 22:22 ` [Buildroot] [PATCH 2/2] package/gawk: add optional readline dependency Yann E. MORIN
1 sibling, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2015-12-03 22:22 UTC (permalink / raw)
To: buildroot
When available, mpfr provides support for BIGNUM, which allows gawk to
work on arbitrarily-large numbers (hence the name).
Forcibly disable mpfr if the mpfr package is not enabled. Let
./configure find it automatically when it is enabled.
To be noted, the host-gawk needs not have BIGNUM to build the target
variant with support for BIGNUM.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Peter Korsgaard <jacmet@uclibc.org>
---
package/gawk/gawk.mk | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/package/gawk/gawk.mk b/package/gawk/gawk.mk
index 6702c48..74c1fe4 100644
--- a/package/gawk/gawk.mk
+++ b/package/gawk/gawk.mk
@@ -7,7 +7,7 @@
GAWK_VERSION = 4.1.3
GAWK_SOURCE = gawk-$(GAWK_VERSION).tar.xz
GAWK_SITE = $(BR2_GNU_MIRROR)/gawk
-GAWK_DEPENDENCIES = host-gawk $(if $(BR2_PACKAGE_MPFR),mpfr)
+GAWK_DEPENDENCIES = host-gawk
GAWK_LICENSE = GPLv3+
GAWK_LICENSE_FILES = COPYING
@@ -16,6 +16,13 @@ ifeq ($(BR2_PACKAGE_BUSYBOX),y)
GAWK_DEPENDENCIES += busybox
endif
+# When enabled, let ./configure find it automatically
+ifeq ($(BR2_PACKAGE_MPFR),y)
+GAWK_DEPENDENCIES += mpfr
+else
+GAWK_CONF_OPTS += --without-mpfr
+endif
+
# We don't have a host-busybox, and we don't want to use readline or mpfr
HOST_GAWK_DEPENDENCIES =
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] package/gawk: add optional readline dependency
2015-12-03 22:22 [Buildroot] [PATCH 0/2] package/gawk: handle optional dependencies on mpfr and readline (branch yem/host-gawk) Yann E. MORIN
2015-12-03 22:22 ` [Buildroot] [PATCH 1/2] package/gawk: clean the mpfr dependency Yann E. MORIN
@ 2015-12-03 22:22 ` Yann E. MORIN
2015-12-03 23:35 ` Arnout Vandecappelle
1 sibling, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2015-12-03 22:22 UTC (permalink / raw)
To: buildroot
The gawk debugger can optionally use readline for user input during
the debugging session (for the usual autocompletion and stuff).
Enable readline support when the readline package is enabled; let
./configure automatically find it. Forcibly disable readline support
when the readline package is disabled.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Peter Korsgaard <jacmet@uclibc.org>
---
package/gawk/gawk.mk | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/package/gawk/gawk.mk b/package/gawk/gawk.mk
index 74c1fe4..4145025 100644
--- a/package/gawk/gawk.mk
+++ b/package/gawk/gawk.mk
@@ -23,6 +23,13 @@ else
GAWK_CONF_OPTS += --without-mpfr
endif
+# When enabled, let ./configure find it automatically
+ifeq ($(BR2_PACKAGE_READLINE),y)
+GAWK_DEPENDENCIES += readline
+else
+GAWK_CONF_OPTS += --without-readline
+endif
+
# We don't have a host-busybox, and we don't want to use readline or mpfr
HOST_GAWK_DEPENDENCIES =
--
1.9.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] package/gawk: clean the mpfr dependency
2015-12-03 22:22 ` [Buildroot] [PATCH 1/2] package/gawk: clean the mpfr dependency Yann E. MORIN
@ 2015-12-03 23:35 ` Arnout Vandecappelle
2015-12-05 16:08 ` Yann E. MORIN
0 siblings, 1 reply; 7+ messages in thread
From: Arnout Vandecappelle @ 2015-12-03 23:35 UTC (permalink / raw)
To: buildroot
On 03-12-15 23:22, Yann E. MORIN wrote:
> When available, mpfr provides support for BIGNUM, which allows gawk to
> work on arbitrarily-large numbers (hence the name).
>
> Forcibly disable mpfr if the mpfr package is not enabled. Let
> ./configure find it automatically when it is enabled.
>
> To be noted, the host-gawk needs not have BIGNUM to build the target
^^^^^^^^^ doesn't need to have
> variant with support for BIGNUM.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Peter Korsgaard <jacmet@uclibc.org>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Just minor comments.
> ---
> package/gawk/gawk.mk | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/package/gawk/gawk.mk b/package/gawk/gawk.mk
> index 6702c48..74c1fe4 100644
> --- a/package/gawk/gawk.mk
> +++ b/package/gawk/gawk.mk
> @@ -7,7 +7,7 @@
> GAWK_VERSION = 4.1.3
> GAWK_SOURCE = gawk-$(GAWK_VERSION).tar.xz
> GAWK_SITE = $(BR2_GNU_MIRROR)/gawk
> -GAWK_DEPENDENCIES = host-gawk $(if $(BR2_PACKAGE_MPFR),mpfr)
> +GAWK_DEPENDENCIES = host-gawk
> GAWK_LICENSE = GPLv3+
> GAWK_LICENSE_FILES = COPYING
>
> @@ -16,6 +16,13 @@ ifeq ($(BR2_PACKAGE_BUSYBOX),y)
> GAWK_DEPENDENCIES += busybox
> endif
>
> +# When enabled, let ./configure find it automatically
I think a more appropriate comment would be
# --with-mpfr requires an argument so just let configure
# find it automatically.
Regards,
Arnout
> +ifeq ($(BR2_PACKAGE_MPFR),y)
> +GAWK_DEPENDENCIES += mpfr
> +else
> +GAWK_CONF_OPTS += --without-mpfr
> +endif
> +
> # We don't have a host-busybox, and we don't want to use readline or mpfr
> HOST_GAWK_DEPENDENCIES =
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 2/2] package/gawk: add optional readline dependency
2015-12-03 22:22 ` [Buildroot] [PATCH 2/2] package/gawk: add optional readline dependency Yann E. MORIN
@ 2015-12-03 23:35 ` Arnout Vandecappelle
0 siblings, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2015-12-03 23:35 UTC (permalink / raw)
To: buildroot
On 03-12-15 23:22, Yann E. MORIN wrote:
> The gawk debugger can optionally use readline for user input during
> the debugging session (for the usual autocompletion and stuff).
>
> Enable readline support when the readline package is enabled; let
> ./configure automatically find it. Forcibly disable readline support
> when the readline package is disabled.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Peter Korsgaard <jacmet@uclibc.org>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> package/gawk/gawk.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/gawk/gawk.mk b/package/gawk/gawk.mk
> index 74c1fe4..4145025 100644
> --- a/package/gawk/gawk.mk
> +++ b/package/gawk/gawk.mk
> @@ -23,6 +23,13 @@ else
> GAWK_CONF_OPTS += --without-mpfr
> endif
>
> +# When enabled, let ./configure find it automatically
Same thing about the comment.
Regards,
Arnout
> +ifeq ($(BR2_PACKAGE_READLINE),y)
> +GAWK_DEPENDENCIES += readline
> +else
> +GAWK_CONF_OPTS += --without-readline
> +endif
> +
> # We don't have a host-busybox, and we don't want to use readline or mpfr
> HOST_GAWK_DEPENDENCIES =
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] package/gawk: clean the mpfr dependency
2015-12-03 23:35 ` Arnout Vandecappelle
@ 2015-12-05 16:08 ` Yann E. MORIN
2015-12-05 17:25 ` Arnout Vandecappelle
0 siblings, 1 reply; 7+ messages in thread
From: Yann E. MORIN @ 2015-12-05 16:08 UTC (permalink / raw)
To: buildroot
Arnout, All,
On 2015-12-04 00:35 +0100, Arnout Vandecappelle spake thusly:
> On 03-12-15 23:22, Yann E. MORIN wrote:
> > When available, mpfr provides support for BIGNUM, which allows gawk to
> > work on arbitrarily-large numbers (hence the name).
> >
> > Forcibly disable mpfr if the mpfr package is not enabled. Let
> > ./configure find it automatically when it is enabled.
> >
> > To be noted, the host-gawk needs not have BIGNUM to build the target
> ^^^^^^^^^ doesn't need to have
No, sorry, this was correct english grammar:
https://dictionary.cambridge.org/grammar/british-grammar/need
We form the negative by adding not after need. Need not can be
contracted to needn?t. We don?t use don?t/doesn?t/didn?t with the
semi-modal verb need:
You need not spend a lot of money on presents. (formal) (or You
needn?t spend a lot of money on presents.)
Not: You don?t need spend a lot of money on presents.
Or:
http://www.merriam-webster.com/dictionary/need
verbal auxiliary
: be under necessity or obligation to <you need not answer>
<she need only wait>
In this case, 'need' is a verbal auxiliary, not a transitive verb (and
even less so an intransitive verb).
(yes, in case you still had a doubt, I speak british English, not
american English.)
> > variant with support for BIGNUM.
> >
> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Peter Korsgaard <jacmet@uclibc.org>
>
> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
> Just minor comments.
>
> > ---
> > package/gawk/gawk.mk | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/gawk/gawk.mk b/package/gawk/gawk.mk
> > index 6702c48..74c1fe4 100644
> > --- a/package/gawk/gawk.mk
> > +++ b/package/gawk/gawk.mk
> > @@ -7,7 +7,7 @@
> > GAWK_VERSION = 4.1.3
> > GAWK_SOURCE = gawk-$(GAWK_VERSION).tar.xz
> > GAWK_SITE = $(BR2_GNU_MIRROR)/gawk
> > -GAWK_DEPENDENCIES = host-gawk $(if $(BR2_PACKAGE_MPFR),mpfr)
> > +GAWK_DEPENDENCIES = host-gawk
> > GAWK_LICENSE = GPLv3+
> > GAWK_LICENSE_FILES = COPYING
> >
> > @@ -16,6 +16,13 @@ ifeq ($(BR2_PACKAGE_BUSYBOX),y)
> > GAWK_DEPENDENCIES += busybox
> > endif
> >
> > +# When enabled, let ./configure find it automatically
>
> I think a more appropriate comment would be
>
> # --with-mpfr requires an argument so just let configure
> # find it automatically.
OK, will fix.
Thanks!
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/2] package/gawk: clean the mpfr dependency
2015-12-05 16:08 ` Yann E. MORIN
@ 2015-12-05 17:25 ` Arnout Vandecappelle
0 siblings, 0 replies; 7+ messages in thread
From: Arnout Vandecappelle @ 2015-12-05 17:25 UTC (permalink / raw)
To: buildroot
On 05-12-15 17:08, Yann E. MORIN wrote:
> Arnout, All,
>
> On 2015-12-04 00:35 +0100, Arnout Vandecappelle spake thusly:
>> On 03-12-15 23:22, Yann E. MORIN wrote:
>>> When available, mpfr provides support for BIGNUM, which allows gawk to
>>> work on arbitrarily-large numbers (hence the name).
>>>
>>> Forcibly disable mpfr if the mpfr package is not enabled. Let
>>> ./configure find it automatically when it is enabled.
>>>
>>> To be noted, the host-gawk needs not have BIGNUM to build the target
>> ^^^^^^^^^ doesn't need to have
>
> No, sorry, this was correct english grammar:
> https://dictionary.cambridge.org/grammar/british-grammar/need
>
> We form the negative by adding not after need. Need not can be
> contracted to needn?t. We don?t use don?t/doesn?t/didn?t with the
> semi-modal verb need:
>
> You need not spend a lot of money on presents. (formal) (or You
> needn?t spend a lot of money on presents.)
>
> Not: You don?t need spend a lot of money on presents.
>
> Or:
> http://www.merriam-webster.com/dictionary/need
>
> verbal auxiliary
> : be under necessity or obligation to <you need not answer>
> <she need only wait>
>
> In this case, 'need' is a verbal auxiliary, not a transitive verb (and
> even less so an intransitive verb).
But then it's "need not", not "needs not". (Quotation marks really are needed
in this sentence :-)
Or, to avoid discussion:
The build of the target gawk doesn't require host-gawk with BIGNUM support.
:-P
Regards,
Arnout
>
> (yes, in case you still had a doubt, I speak british English, not
> american English.)
>
[snip]
--
Arnout Vandecappelle arnout dot vandecappelle at essensium dot com
Senior Embedded Software Architect . . . . . . +32-478-010353 (mobile)
Essensium, Mind division . . . . . . . . . . . . . . http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium . . . . . BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-12-05 17:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-03 22:22 [Buildroot] [PATCH 0/2] package/gawk: handle optional dependencies on mpfr and readline (branch yem/host-gawk) Yann E. MORIN
2015-12-03 22:22 ` [Buildroot] [PATCH 1/2] package/gawk: clean the mpfr dependency Yann E. MORIN
2015-12-03 23:35 ` Arnout Vandecappelle
2015-12-05 16:08 ` Yann E. MORIN
2015-12-05 17:25 ` Arnout Vandecappelle
2015-12-03 22:22 ` [Buildroot] [PATCH 2/2] package/gawk: add optional readline dependency Yann E. MORIN
2015-12-03 23:35 ` Arnout Vandecappelle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.