All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Hennerich <michael.hennerich@analog.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: Stefan Schmidt <stefan@osg.samsung.com>, <marcel@holtmann.org>,
	<linux-wpan@vger.kernel.org>, <linux-bluetooth@vger.kernel.org>,
	<chrisfriedt@gmail.com>
Subject: Re: [PATCH] drivers/net/ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154
Date: Tue, 8 Dec 2015 09:07:43 +0100	[thread overview]
Message-ID: <56668FCF.3070206@analog.com> (raw)
In-Reply-To: <20151207141239.GC20826@omega>

On 12/07/2015 03:12 PM, Alexander Aring wrote:
> On Mon, Dec 07, 2015 at 02:34:29PM +0100, Michael Hennerich wrote:
> ...
>>> Stefan, maybe you testing with the ATUSB firmware which going _not_
>>> into RX_AACK_ON. This was one of my lastest changes according to the
>>> ATUSB firmware. Please check that, otherwise the atusb doesn't send
>>> ack frames if ackrequest bit is set after receiving.
>>
>> I was wondering where can I buy the ATUSB?
>> On the pulster page I can't find it.
>>
>
> They are all out of stock, everywhere. I cc Werner maybe he will bring
> back the atusb again. He do his stuff all open source and a possible
> solution would be a Kickstarter project.
>
> Another option would be:
>
>   - Produce your own atusb
>   - I know that "Christopher Friedt" produced some, maybe he will give/sell
>     some. :-) I cc'ed him here.
>   - use the experimental firmware [1] on RZUSBStick [0] support. Basics
>     functionality only and not stable such atusb. I ported the firmware
>     to this stick, it can be used by atusb driver. The transceiver is a
>     different -> at86rf230... and this transceiver we also doesn't
>     support by the at86rf230 because it's too different and a huge
>     errata.

Would be nice to have a USB MAC8021511.
Guess I need to wait for the next lot being produced.


>
>> In general why is the framework not requesting ACKs on all non broadcast
>> DATA frames?
>>
>> There is an option if turned on - it'll also request ACks on broadcasts...
>
> I suppose you use the af802154 socket family. I didn't touched the code
> and this socket family is full of bugs. We need a replacement for that.
>
> The socket code which I was working is AF_PACKET.
>
> In case of AF_PACKET:
>
>   dgram sockets: extended address and intra_pan communciaton only. The
>                  AF_PACKET UAPI doesn't offer more address information.
> 		We do a mapping to this currently, other option would be
> 		to disable DGRAM on AF_PACKET. It's not possible to send
> 		broadcast frames with that.
> 		If you need that, something similar like af802154 should
> 		be available, but it's currently broken.
>
>   raw sockets:   You can build the mac frame inside userspace with
>                  complete control fc and address settings. We don't check
> 		this frame if it's valid. This is not a bug.
>
>
> and 6LoWPAN:
>
> 6LoWPAN doesn't do that, the check should be at [2]. If it's currently
> broken at your side?

Maybe - I still use the lowpan-tools.
And it locks like ACKs must be enabled via 
NL802154_CMD_SET_ACKREQ_DEFAULT, which lowpan-tools doesn't do.
Wondering why it's not by default enabled...
So I patched my kernel, probably in the wrong place.



>
> - Alex
>
> [0] http://www.atmel.com/tools/RZUSBSTICK.aspx
> [1] http://alex.my-webspace.org/firmwares/rzusb.bin
>      Note: This is temprorary website, I know wpan.cakelab.org is down
>      currently and I working already to a DNS solution to redirect
>      wpan.cakelab.org -> /alex.my-webspace.org . At the moment it looks
>      like the provide has bugs inside his DNS web-frontend configuration
>      page. ;-)
> [2] http://lxr.free-electrons.com/source/net/ieee802154/6lowpan/tx.c#L220
>


-- 
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif

WARNING: multiple messages have this Message-ID (diff)
From: Michael Hennerich <michael.hennerich@analog.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: Stefan Schmidt <stefan@osg.samsung.com>,
	marcel@holtmann.org, linux-wpan@vger.kernel.org,
	linux-bluetooth@vger.kernel.org, chrisfriedt@gmail.com
Subject: Re: [PATCH] drivers/net/ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154
Date: Tue, 8 Dec 2015 09:07:43 +0100	[thread overview]
Message-ID: <56668FCF.3070206@analog.com> (raw)
In-Reply-To: <20151207141239.GC20826@omega>

On 12/07/2015 03:12 PM, Alexander Aring wrote:
> On Mon, Dec 07, 2015 at 02:34:29PM +0100, Michael Hennerich wrote:
> ...
>>> Stefan, maybe you testing with the ATUSB firmware which going _not_
>>> into RX_AACK_ON. This was one of my lastest changes according to the
>>> ATUSB firmware. Please check that, otherwise the atusb doesn't send
>>> ack frames if ackrequest bit is set after receiving.
>>
>> I was wondering where can I buy the ATUSB?
>> On the pulster page I can't find it.
>>
>
> They are all out of stock, everywhere. I cc Werner maybe he will bring
> back the atusb again. He do his stuff all open source and a possible
> solution would be a Kickstarter project.
>
> Another option would be:
>
>   - Produce your own atusb
>   - I know that "Christopher Friedt" produced some, maybe he will give/sell
>     some. :-) I cc'ed him here.
>   - use the experimental firmware [1] on RZUSBStick [0] support. Basics
>     functionality only and not stable such atusb. I ported the firmware
>     to this stick, it can be used by atusb driver. The transceiver is a
>     different -> at86rf230... and this transceiver we also doesn't
>     support by the at86rf230 because it's too different and a huge
>     errata.

Would be nice to have a USB MAC8021511.
Guess I need to wait for the next lot being produced.


>
>> In general why is the framework not requesting ACKs on all non broadcast
>> DATA frames?
>>
>> There is an option if turned on - it'll also request ACks on broadcasts...
>
> I suppose you use the af802154 socket family. I didn't touched the code
> and this socket family is full of bugs. We need a replacement for that.
>
> The socket code which I was working is AF_PACKET.
>
> In case of AF_PACKET:
>
>   dgram sockets: extended address and intra_pan communciaton only. The
>                  AF_PACKET UAPI doesn't offer more address information.
> 		We do a mapping to this currently, other option would be
> 		to disable DGRAM on AF_PACKET. It's not possible to send
> 		broadcast frames with that.
> 		If you need that, something similar like af802154 should
> 		be available, but it's currently broken.
>
>   raw sockets:   You can build the mac frame inside userspace with
>                  complete control fc and address settings. We don't check
> 		this frame if it's valid. This is not a bug.
>
>
> and 6LoWPAN:
>
> 6LoWPAN doesn't do that, the check should be at [2]. If it's currently
> broken at your side?

Maybe - I still use the lowpan-tools.
And it locks like ACKs must be enabled via 
NL802154_CMD_SET_ACKREQ_DEFAULT, which lowpan-tools doesn't do.
Wondering why it's not by default enabled...
So I patched my kernel, probably in the wrong place.



>
> - Alex
>
> [0] http://www.atmel.com/tools/RZUSBSTICK.aspx
> [1] http://alex.my-webspace.org/firmwares/rzusb.bin
>      Note: This is temprorary website, I know wpan.cakelab.org is down
>      currently and I working already to a DNS solution to redirect
>      wpan.cakelab.org -> /alex.my-webspace.org . At the moment it looks
>      like the provide has bugs inside his DNS web-frontend configuration
>      page. ;-)
> [2] http://lxr.free-electrons.com/source/net/ieee802154/6lowpan/tx.c#L220
>


-- 
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif

  reply	other threads:[~2015-12-08  8:07 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04  9:09 [PATCH] drivers/net/ieee802154/adf7242: Driver for ADF7242 MAC IEEE802154 michael.hennerich
2015-12-04  9:09 ` michael.hennerich
2015-12-04 12:07 ` Stefan Schmidt
2015-12-07 12:02   ` Stefan Schmidt
2015-12-07 12:18     ` Michael Hennerich
2015-12-07 12:18       ` Michael Hennerich
2015-12-07 13:25       ` Alexander Aring
2015-12-07 13:34         ` Michael Hennerich
2015-12-07 13:34           ` Michael Hennerich
2015-12-07 14:12           ` Alexander Aring
2015-12-08  8:07             ` Michael Hennerich [this message]
2015-12-08  8:07               ` Michael Hennerich
2015-12-08 15:53               ` Alexander Aring
2015-12-08 16:02                 ` Michael Hennerich
2015-12-08 16:02                   ` Michael Hennerich
2015-12-09 10:31                   ` Alexander Aring
2015-12-10  0:04                     ` Stefan Schmidt
2015-12-07 15:08         ` Stefan Schmidt
2015-12-07 14:54       ` Stefan Schmidt
2015-12-07 12:47   ` Michael Hennerich
2015-12-07 12:47     ` Michael Hennerich
2015-12-07 13:53     ` Alexander Aring
2015-12-08  8:43       ` Michael Hennerich
2015-12-08  8:43         ` Michael Hennerich
2015-12-08 17:11         ` Alexander Aring
2015-12-09  9:53           ` Michael Hennerich
2015-12-09  9:53             ` Michael Hennerich
2015-12-09 14:55             ` Alexander Aring
2015-12-09 16:09               ` Michael Hennerich
2015-12-09 16:09                 ` Michael Hennerich
2015-12-07 15:03     ` Stefan Schmidt
2015-12-04 12:42 ` Christopher Friedt
2015-12-04 13:34 ` kbuild test robot
2015-12-04 13:34   ` kbuild test robot
2015-12-04 13:41 ` kbuild test robot
2015-12-04 13:41   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56668FCF.3070206@analog.com \
    --to=michael.hennerich@analog.com \
    --cc=alex.aring@gmail.com \
    --cc=chrisfriedt@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=stefan@osg.samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.