Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string

From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Simon Horman
	<horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
	Greg Kroah-Hartman
	<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
Cc: Yoshihiro Shimoda
	<yoshihiro.shimoda.uh-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>,
	Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] usb: renesas_usbhs: add fallback compatibility string
Date: Tue, 08 Dec 2015 14:35:28 +0000	[thread overview]
Message-ID: <5666EAB0.6000109@cogentembedded.com> (raw)
In-Reply-To: <1449553911-21412-2-git-send-email-horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>

On 12/08/2015 08:51 AM, Simon Horman wrote:

> Add fallback compatibility string.
> This is in keeping with the fallback scheme being adopted wherever
> appropriate for drivers for Renesas SoCs.
>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>   Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 4 ++--
>   drivers/usb/renesas_usbhs/common.c                      | 4 ++++
>   2 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> index 7d48f63db44e..8c50df8441c9 100644
> --- a/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> +++ b/Documentation/devicetree/bindings/usb/renesas_usbhs.txt
> @@ -1,7 +1,7 @@
>   Renesas Electronics USBHS driver
>
>   Required properties:
> -  - compatible: Must contain one of the following:
> +  - compatible: "renesas,usbhs-<soctype>", "renesas,rcar-usbhs" as fallback.
>   	- "renesas,usbhs-r8a7790"
>   	- "renesas,usbhs-r8a7791"
>   	- "renesas,usbhs-r8a7794"
[...]
> diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
> index d82fa36c3465..2a9d4f405f30 100644
> --- a/drivers/usb/renesas_usbhs/common.c
> +++ b/drivers/usb/renesas_usbhs/common.c
> @@ -481,6 +481,10 @@ static const struct of_device_id usbhs_of_match[] = {
>   		.compatible = "renesas,usbhs-r8a7795",
>   		.data = (void *)USBHS_TYPE_RCAR_GEN2,
>   	},
> +	{
> +		.compatible = "renesas,usbhs",

    You just documented "renesas,rcar-usbhs".

MBR, Sergei