* [PATCH] [media] staging/davinci_vfpe: allow modular build
@ 2015-12-10 14:29 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2015-12-10 14:29 UTC (permalink / raw)
To: mchehab, linux-media, linux-kernel
Cc: linux-arm-kernel, Sekhar Nori, Kevin Hilman
It has never been possible to actually build this driver as
a loadable module, only built-in because the Makefile attempts
to build each file into its own module and fails:
ERROR: "mbus_to_pix" [drivers/staging/media/davinci_vpfe/vpfe_video.ko] undefined!
ERROR: "vpfe_resizer_register_entities" [drivers/staging/media/davinci_vpfe/vpfe_mc_capture.ko] undefined!
ERROR: "rsz_enable" [drivers/staging/media/davinci_vpfe/dm365_resizer.ko] undefined!
ERROR: "config_ipipe_hw" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
ERROR: "ipipe_set_lutdpc_regs" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
It took a long time to catch this bug with randconfig builds
because at least 14 other Kconfig symbols have to be enabled in
order to configure this one.
The solution is really easy: this patch changes the Makefile to
link all files into one module.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
diff --git a/drivers/staging/media/davinci_vpfe/Makefile b/drivers/staging/media/davinci_vpfe/Makefile
index c64515c644cd..3019c9ecd548 100644
--- a/drivers/staging/media/davinci_vpfe/Makefile
+++ b/drivers/staging/media/davinci_vpfe/Makefile
@@ -1,3 +1,5 @@
-obj-$(CONFIG_VIDEO_DM365_VPFE) += \
+obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci-vfpe.o
+
+davinci-vfpe-objs := \
dm365_isif.o dm365_ipipe_hw.o dm365_ipipe.o \
dm365_resizer.o dm365_ipipeif.o vpfe_mc_capture.o vpfe_video.o
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] [media] staging/davinci_vfpe: allow modular build
@ 2015-12-10 14:29 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2015-12-10 14:29 UTC (permalink / raw)
To: linux-arm-kernel
It has never been possible to actually build this driver as
a loadable module, only built-in because the Makefile attempts
to build each file into its own module and fails:
ERROR: "mbus_to_pix" [drivers/staging/media/davinci_vpfe/vpfe_video.ko] undefined!
ERROR: "vpfe_resizer_register_entities" [drivers/staging/media/davinci_vpfe/vpfe_mc_capture.ko] undefined!
ERROR: "rsz_enable" [drivers/staging/media/davinci_vpfe/dm365_resizer.ko] undefined!
ERROR: "config_ipipe_hw" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
ERROR: "ipipe_set_lutdpc_regs" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
It took a long time to catch this bug with randconfig builds
because at least 14 other Kconfig symbols have to be enabled in
order to configure this one.
The solution is really easy: this patch changes the Makefile to
link all files into one module.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
diff --git a/drivers/staging/media/davinci_vpfe/Makefile b/drivers/staging/media/davinci_vpfe/Makefile
index c64515c644cd..3019c9ecd548 100644
--- a/drivers/staging/media/davinci_vpfe/Makefile
+++ b/drivers/staging/media/davinci_vpfe/Makefile
@@ -1,3 +1,5 @@
-obj-$(CONFIG_VIDEO_DM365_VPFE) += \
+obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci-vfpe.o
+
+davinci-vfpe-objs := \
dm365_isif.o dm365_ipipe_hw.o dm365_ipipe.o \
dm365_resizer.o dm365_ipipeif.o vpfe_mc_capture.o vpfe_video.o
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] [media] staging/davinci_vfpe: allow modular build
2015-12-10 14:29 ` Arnd Bergmann
@ 2015-12-10 14:40 ` Mauro Carvalho Chehab
-1 siblings, 0 replies; 8+ messages in thread
From: Mauro Carvalho Chehab @ 2015-12-10 14:40 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-media, linux-kernel, linux-arm-kernel, Sekhar Nori, Kevin Hilman
Em Thu, 10 Dec 2015 15:29:38 +0100
Arnd Bergmann <arnd@arndb.de> escreveu:
> It has never been possible to actually build this driver as
> a loadable module, only built-in because the Makefile attempts
> to build each file into its own module and fails:
>
> ERROR: "mbus_to_pix" [drivers/staging/media/davinci_vpfe/vpfe_video.ko] undefined!
> ERROR: "vpfe_resizer_register_entities" [drivers/staging/media/davinci_vpfe/vpfe_mc_capture.ko] undefined!
> ERROR: "rsz_enable" [drivers/staging/media/davinci_vpfe/dm365_resizer.ko] undefined!
> ERROR: "config_ipipe_hw" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
> ERROR: "ipipe_set_lutdpc_regs" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
>
> It took a long time to catch this bug with randconfig builds
> because at least 14 other Kconfig symbols have to be enabled in
> order to configure this one.
>
> The solution is really easy: this patch changes the Makefile to
> link all files into one module.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>
> diff --git a/drivers/staging/media/davinci_vpfe/Makefile b/drivers/staging/media/davinci_vpfe/Makefile
> index c64515c644cd..3019c9ecd548 100644
> --- a/drivers/staging/media/davinci_vpfe/Makefile
> +++ b/drivers/staging/media/davinci_vpfe/Makefile
> @@ -1,3 +1,5 @@
> -obj-$(CONFIG_VIDEO_DM365_VPFE) += \
> +obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci-vfpe.o
> +
> +davinci-vfpe-objs := \
> dm365_isif.o dm365_ipipe_hw.o dm365_ipipe.o \
> dm365_resizer.o dm365_ipipeif.o vpfe_mc_capture.o vpfe_video.o
>
That seems a bad signal to me... I guess either this driver was never
actually tested or it was tested only if compiled as built-in...
Regards,
Mauro
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] [media] staging/davinci_vfpe: allow modular build
@ 2015-12-10 14:40 ` Mauro Carvalho Chehab
0 siblings, 0 replies; 8+ messages in thread
From: Mauro Carvalho Chehab @ 2015-12-10 14:40 UTC (permalink / raw)
To: linux-arm-kernel
Em Thu, 10 Dec 2015 15:29:38 +0100
Arnd Bergmann <arnd@arndb.de> escreveu:
> It has never been possible to actually build this driver as
> a loadable module, only built-in because the Makefile attempts
> to build each file into its own module and fails:
>
> ERROR: "mbus_to_pix" [drivers/staging/media/davinci_vpfe/vpfe_video.ko] undefined!
> ERROR: "vpfe_resizer_register_entities" [drivers/staging/media/davinci_vpfe/vpfe_mc_capture.ko] undefined!
> ERROR: "rsz_enable" [drivers/staging/media/davinci_vpfe/dm365_resizer.ko] undefined!
> ERROR: "config_ipipe_hw" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
> ERROR: "ipipe_set_lutdpc_regs" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
>
> It took a long time to catch this bug with randconfig builds
> because at least 14 other Kconfig symbols have to be enabled in
> order to configure this one.
>
> The solution is really easy: this patch changes the Makefile to
> link all files into one module.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>
> diff --git a/drivers/staging/media/davinci_vpfe/Makefile b/drivers/staging/media/davinci_vpfe/Makefile
> index c64515c644cd..3019c9ecd548 100644
> --- a/drivers/staging/media/davinci_vpfe/Makefile
> +++ b/drivers/staging/media/davinci_vpfe/Makefile
> @@ -1,3 +1,5 @@
> -obj-$(CONFIG_VIDEO_DM365_VPFE) += \
> +obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci-vfpe.o
> +
> +davinci-vfpe-objs := \
> dm365_isif.o dm365_ipipe_hw.o dm365_ipipe.o \
> dm365_resizer.o dm365_ipipeif.o vpfe_mc_capture.o vpfe_video.o
>
That seems a bad signal to me... I guess either this driver was never
actually tested or it was tested only if compiled as built-in...
Regards,
Mauro
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] [media] staging/davinci_vfpe: allow modular build
2015-12-10 14:40 ` Mauro Carvalho Chehab
@ 2015-12-10 14:44 ` Sekhar Nori
-1 siblings, 0 replies; 8+ messages in thread
From: Sekhar Nori @ 2015-12-10 14:44 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Arnd Bergmann
Cc: linux-media, linux-kernel, linux-arm-kernel, Kevin Hilman, Lad,
Prabhakar
On Thursday 10 December 2015 08:10 PM, Mauro Carvalho Chehab wrote:
> Em Thu, 10 Dec 2015 15:29:38 +0100
> Arnd Bergmann <arnd@arndb.de> escreveu:
>
>> It has never been possible to actually build this driver as
>> a loadable module, only built-in because the Makefile attempts
>> to build each file into its own module and fails:
>>
>> ERROR: "mbus_to_pix" [drivers/staging/media/davinci_vpfe/vpfe_video.ko] undefined!
>> ERROR: "vpfe_resizer_register_entities" [drivers/staging/media/davinci_vpfe/vpfe_mc_capture.ko] undefined!
>> ERROR: "rsz_enable" [drivers/staging/media/davinci_vpfe/dm365_resizer.ko] undefined!
>> ERROR: "config_ipipe_hw" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
>> ERROR: "ipipe_set_lutdpc_regs" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
>>
>> It took a long time to catch this bug with randconfig builds
>> because at least 14 other Kconfig symbols have to be enabled in
>> order to configure this one.
>>
>> The solution is really easy: this patch changes the Makefile to
>> link all files into one module.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>
>> diff --git a/drivers/staging/media/davinci_vpfe/Makefile b/drivers/staging/media/davinci_vpfe/Makefile
>> index c64515c644cd..3019c9ecd548 100644
>> --- a/drivers/staging/media/davinci_vpfe/Makefile
>> +++ b/drivers/staging/media/davinci_vpfe/Makefile
>> @@ -1,3 +1,5 @@
>> -obj-$(CONFIG_VIDEO_DM365_VPFE) += \
>> +obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci-vfpe.o
>> +
>> +davinci-vfpe-objs := \
>> dm365_isif.o dm365_ipipe_hw.o dm365_ipipe.o \
>> dm365_resizer.o dm365_ipipeif.o vpfe_mc_capture.o vpfe_video.o
>>
>
> That seems a bad signal to me... I guess either this driver was never
> actually tested or it was tested only if compiled as built-in...
Most likely the later is true.
+ Prabhakar to see if he remembers.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] [media] staging/davinci_vfpe: allow modular build
@ 2015-12-10 14:44 ` Sekhar Nori
0 siblings, 0 replies; 8+ messages in thread
From: Sekhar Nori @ 2015-12-10 14:44 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 10 December 2015 08:10 PM, Mauro Carvalho Chehab wrote:
> Em Thu, 10 Dec 2015 15:29:38 +0100
> Arnd Bergmann <arnd@arndb.de> escreveu:
>
>> It has never been possible to actually build this driver as
>> a loadable module, only built-in because the Makefile attempts
>> to build each file into its own module and fails:
>>
>> ERROR: "mbus_to_pix" [drivers/staging/media/davinci_vpfe/vpfe_video.ko] undefined!
>> ERROR: "vpfe_resizer_register_entities" [drivers/staging/media/davinci_vpfe/vpfe_mc_capture.ko] undefined!
>> ERROR: "rsz_enable" [drivers/staging/media/davinci_vpfe/dm365_resizer.ko] undefined!
>> ERROR: "config_ipipe_hw" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
>> ERROR: "ipipe_set_lutdpc_regs" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
>>
>> It took a long time to catch this bug with randconfig builds
>> because at least 14 other Kconfig symbols have to be enabled in
>> order to configure this one.
>>
>> The solution is really easy: this patch changes the Makefile to
>> link all files into one module.
>>
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>> ---
>>
>> diff --git a/drivers/staging/media/davinci_vpfe/Makefile b/drivers/staging/media/davinci_vpfe/Makefile
>> index c64515c644cd..3019c9ecd548 100644
>> --- a/drivers/staging/media/davinci_vpfe/Makefile
>> +++ b/drivers/staging/media/davinci_vpfe/Makefile
>> @@ -1,3 +1,5 @@
>> -obj-$(CONFIG_VIDEO_DM365_VPFE) += \
>> +obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci-vfpe.o
>> +
>> +davinci-vfpe-objs := \
>> dm365_isif.o dm365_ipipe_hw.o dm365_ipipe.o \
>> dm365_resizer.o dm365_ipipeif.o vpfe_mc_capture.o vpfe_video.o
>>
>
> That seems a bad signal to me... I guess either this driver was never
> actually tested or it was tested only if compiled as built-in...
Most likely the later is true.
+ Prabhakar to see if he remembers.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] [media] staging/davinci_vfpe: allow modular build
@ 2016-02-26 12:27 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2016-02-26 12:27 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: linux-arm-kernel, Arnd Bergmann, linux-media, devel, linux-kernel
It has never been possible to actually build this driver as
a loadable module, only built-in because the Makefile attempts
to build each file into its own module and fails:
ERROR: "mbus_to_pix" [drivers/staging/media/davinci_vpfe/vpfe_video.ko] undefined!
ERROR: "vpfe_resizer_register_entities" [drivers/staging/media/davinci_vpfe/vpfe_mc_capture.ko] undefined!
ERROR: "rsz_enable" [drivers/staging/media/davinci_vpfe/dm365_resizer.ko] undefined!
ERROR: "config_ipipe_hw" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
ERROR: "ipipe_set_lutdpc_regs" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
It took a long time to catch this bug with randconfig builds
because at least 14 other Kconfig symbols have to be enabled in
order to configure this one, and it was clearly only ever tested
as built-in with mainline kernels, if at all.
The solution is really easy: this patch changes the Makefile to
link all files into one module.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/staging/media/davinci_vpfe/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Patch was sent originally on December 10, see
http://lkml.iu.edu/hypermail/linux/kernel/1512.1/02383.html
It still looks valid to me, and the problem persists without
the patch.
diff --git a/drivers/staging/media/davinci_vpfe/Makefile b/drivers/staging/media/davinci_vpfe/Makefile
index c64515c644cd..3019c9ecd548 100644
--- a/drivers/staging/media/davinci_vpfe/Makefile
+++ b/drivers/staging/media/davinci_vpfe/Makefile
@@ -1,3 +1,5 @@
-obj-$(CONFIG_VIDEO_DM365_VPFE) += \
+obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci-vfpe.o
+
+davinci-vfpe-objs := \
dm365_isif.o dm365_ipipe_hw.o dm365_ipipe.o \
dm365_resizer.o dm365_ipipeif.o vpfe_mc_capture.o vpfe_video.o
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] [media] staging/davinci_vfpe: allow modular build
@ 2016-02-26 12:27 ` Arnd Bergmann
0 siblings, 0 replies; 8+ messages in thread
From: Arnd Bergmann @ 2016-02-26 12:27 UTC (permalink / raw)
To: linux-arm-kernel
It has never been possible to actually build this driver as
a loadable module, only built-in because the Makefile attempts
to build each file into its own module and fails:
ERROR: "mbus_to_pix" [drivers/staging/media/davinci_vpfe/vpfe_video.ko] undefined!
ERROR: "vpfe_resizer_register_entities" [drivers/staging/media/davinci_vpfe/vpfe_mc_capture.ko] undefined!
ERROR: "rsz_enable" [drivers/staging/media/davinci_vpfe/dm365_resizer.ko] undefined!
ERROR: "config_ipipe_hw" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
ERROR: "ipipe_set_lutdpc_regs" [drivers/staging/media/davinci_vpfe/dm365_ipipe.ko] undefined!
It took a long time to catch this bug with randconfig builds
because at least 14 other Kconfig symbols have to be enabled in
order to configure this one, and it was clearly only ever tested
as built-in with mainline kernels, if at all.
The solution is really easy: this patch changes the Makefile to
link all files into one module.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/staging/media/davinci_vpfe/Makefile | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Patch was sent originally on December 10, see
http://lkml.iu.edu/hypermail/linux/kernel/1512.1/02383.html
It still looks valid to me, and the problem persists without
the patch.
diff --git a/drivers/staging/media/davinci_vpfe/Makefile b/drivers/staging/media/davinci_vpfe/Makefile
index c64515c644cd..3019c9ecd548 100644
--- a/drivers/staging/media/davinci_vpfe/Makefile
+++ b/drivers/staging/media/davinci_vpfe/Makefile
@@ -1,3 +1,5 @@
-obj-$(CONFIG_VIDEO_DM365_VPFE) += \
+obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci-vfpe.o
+
+davinci-vfpe-objs := \
dm365_isif.o dm365_ipipe_hw.o dm365_ipipe.o \
dm365_resizer.o dm365_ipipeif.o vpfe_mc_capture.o vpfe_video.o
--
2.7.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-02-26 12:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-10 14:29 [PATCH] [media] staging/davinci_vfpe: allow modular build Arnd Bergmann
2015-12-10 14:29 ` Arnd Bergmann
2015-12-10 14:40 ` Mauro Carvalho Chehab
2015-12-10 14:40 ` Mauro Carvalho Chehab
2015-12-10 14:44 ` Sekhar Nori
2015-12-10 14:44 ` Sekhar Nori
2016-02-26 12:27 Arnd Bergmann
2016-02-26 12:27 ` Arnd Bergmann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.