Re: [Qemu-devel] [PATCH v7 29/31] qapi: Simplify semantics of visit_next_list()

From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
	Alexander Graf <agraf@suse.de>,
	"open list:sPAPR pseries" <qemu-ppc@nongnu.org>,
	armbru@redhat.com, David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH v7 29/31] qapi: Simplify semantics of visit_next_list()
Date: Thu, 10 Dec 2015 21:04:52 -0700	[thread overview]
Message-ID: <566A4B64.8030904@redhat.com> (raw)
In-Reply-To: <5669B71E.80102@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 932 bytes --]

On 12/10/2015 10:32 AM, Eric Blake wrote:
> On 12/07/2015 08:55 PM, Eric Blake wrote:
> 
>> We can greatly simplify things by hoisting the special case
>> into the start() routine, and flipping the order in the loop
>> to visit before advance:
>>
>> start(head)
>> element = *head
>> while (element) {
>>     visit(element)
>>     element = next(element)
>> }
>>

> Looking at this, it is inconsistent with start_struct (where name comes
> AFTER the object); that is, I think this should probably be:
> 
> void (*start_list)(Visitor *v, GenericList **list, const char *name,
> Error **errp);
> 
> although I'll still wait for review comments before respinning.

I've also bisected this patch as causing assertion failures in
qemu-iotests 041 and 139, so I'll have to sort that out on the respin.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]