* [PATCH linux-5.9 1/1] net: netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create @ 2020-10-19 17:25 saeed.mirzamohammadi 2020-10-20 11:50 ` Pablo Neira Ayuso 0 siblings, 1 reply; 11+ messages in thread From: saeed.mirzamohammadi @ 2020-10-19 17:25 UTC (permalink / raw) To: linux-kernel Cc: pablo, kadlec, fw, davem, kuba, netfilter-devel, coreteam, netdev From: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com> This patch fixes the issue due to: BUG: KASAN: slab-out-of-bounds in nft_flow_rule_create+0x622/0x6a2 net/netfilter/nf_tables_offload.c:40 Read of size 8 at addr ffff888103910b58 by task syz-executor227/16244 The error happens when expr->ops is accessed early on before performing the boundary check and after nft_expr_next() moves the expr to go out-of-bounds. This patch checks the boundary condition before expr->ops that fixes the slab-out-of-bounds Read issue. Signed-off-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com> --- net/netfilter/nf_tables_offload.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/netfilter/nf_tables_offload.c b/net/netfilter/nf_tables_offload.c index 9ef37c1b7b3b..1273e3c0d4b8 100644 --- a/net/netfilter/nf_tables_offload.c +++ b/net/netfilter/nf_tables_offload.c @@ -37,7 +37,7 @@ struct nft_flow_rule *nft_flow_rule_create(struct net *net, struct nft_expr *expr; expr = nft_expr_first(rule); - while (expr->ops && expr != nft_expr_last(rule)) { + while (expr != nft_expr_last(rule) && expr->ops) { if (expr->ops->offload_flags & NFT_OFFLOAD_F_ACTION) num_actions++; @@ -61,7 +61,7 @@ struct nft_flow_rule *nft_flow_rule_create(struct net *net, ctx->net = net; ctx->dep.type = NFT_OFFLOAD_DEP_UNSPEC; - while (expr->ops && expr != nft_expr_last(rule)) { + while (expr != nft_expr_last(rule) && expr->ops) { if (!expr->ops->offload) { err = -EOPNOTSUPP; goto err_out; -- 2.27.0 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH linux-5.9 1/1] net: netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create 2020-10-19 17:25 [PATCH linux-5.9 1/1] net: netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create saeed.mirzamohammadi @ 2020-10-20 11:50 ` Pablo Neira Ayuso 2020-10-20 16:45 ` Saeed Mirzamohammadi 0 siblings, 1 reply; 11+ messages in thread From: Pablo Neira Ayuso @ 2020-10-20 11:50 UTC (permalink / raw) To: saeed.mirzamohammadi Cc: linux-kernel, kadlec, fw, davem, kuba, netfilter-devel, coreteam, netdev [-- Attachment #1: Type: text/plain, Size: 828 bytes --] On Mon, Oct 19, 2020 at 10:25:32AM -0700, saeed.mirzamohammadi@oracle.com wrote: > From: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com> > > This patch fixes the issue due to: > > BUG: KASAN: slab-out-of-bounds in nft_flow_rule_create+0x622/0x6a2 > net/netfilter/nf_tables_offload.c:40 > Read of size 8 at addr ffff888103910b58 by task syz-executor227/16244 > > The error happens when expr->ops is accessed early on before performing the boundary check and after nft_expr_next() moves the expr to go out-of-bounds. > > This patch checks the boundary condition before expr->ops that fixes the slab-out-of-bounds Read issue. Thanks. I made a slight variant of your patch. I'm attaching it, it is also fixing the problem but it introduced nft_expr_more() and use it everywhere. Let me know if this looks fine to you. [-- Attachment #2: 0001-netfilter-fix-KASAN-slab-out-of-bounds-Read-in-nft_f.patch --] [-- Type: text/x-diff, Size: 3700 bytes --] From 3f60e5f489ec44e8b0a7e9e622c93be4df335fb6 Mon Sep 17 00:00:00 2001 From: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com> Date: Tue, 20 Oct 2020 13:41:36 +0200 Subject: [PATCH nf] netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create This patch fixes the issue due to: BUG: KASAN: slab-out-of-bounds in nft_flow_rule_create+0x622/0x6a2 net/netfilter/nf_tables_offload.c:40 Read of size 8 at addr ffff888103910b58 by task syz-executor227/16244 The error happens when expr->ops is accessed early on before performing the boundary check and after nft_expr_next() moves the expr to go out-of-bounds. This patch checks the boundary condition before expr->ops that fixes the slab-out-of-bounds Read issue. Add nft_expr_more() and use it to fix this problem. Signed-off-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> --- include/net/netfilter/nf_tables.h | 6 ++++++ net/netfilter/nf_tables_api.c | 6 +++--- net/netfilter/nf_tables_offload.c | 4 ++-- 3 files changed, 11 insertions(+), 5 deletions(-) diff --git a/include/net/netfilter/nf_tables.h b/include/net/netfilter/nf_tables.h index 3f7e56b1171e..55b4cadf290a 100644 --- a/include/net/netfilter/nf_tables.h +++ b/include/net/netfilter/nf_tables.h @@ -891,6 +891,12 @@ static inline struct nft_expr *nft_expr_last(const struct nft_rule *rule) return (struct nft_expr *)&rule->data[rule->dlen]; } +static inline bool nft_expr_more(const struct nft_rule *rule, + const struct nft_expr *expr) +{ + return expr != nft_expr_last(rule) && expr->ops; +} + static inline struct nft_userdata *nft_userdata(const struct nft_rule *rule) { return (void *)&rule->data[rule->dlen]; diff --git a/net/netfilter/nf_tables_api.c b/net/netfilter/nf_tables_api.c index 9957e0ed8658..65cb8e3c13d9 100644 --- a/net/netfilter/nf_tables_api.c +++ b/net/netfilter/nf_tables_api.c @@ -302,7 +302,7 @@ static void nft_rule_expr_activate(const struct nft_ctx *ctx, struct nft_expr *expr; expr = nft_expr_first(rule); - while (expr != nft_expr_last(rule) && expr->ops) { + while (nft_expr_more(rule, expr)) { if (expr->ops->activate) expr->ops->activate(ctx, expr); @@ -317,7 +317,7 @@ static void nft_rule_expr_deactivate(const struct nft_ctx *ctx, struct nft_expr *expr; expr = nft_expr_first(rule); - while (expr != nft_expr_last(rule) && expr->ops) { + while (nft_expr_more(rule, expr)) { if (expr->ops->deactivate) expr->ops->deactivate(ctx, expr, phase); @@ -3080,7 +3080,7 @@ static void nf_tables_rule_destroy(const struct nft_ctx *ctx, * is called on error from nf_tables_newrule(). */ expr = nft_expr_first(rule); - while (expr != nft_expr_last(rule) && expr->ops) { + while (nft_expr_more(rule, expr)) { next = nft_expr_next(expr); nf_tables_expr_destroy(ctx, expr); expr = next; diff --git a/net/netfilter/nf_tables_offload.c b/net/netfilter/nf_tables_offload.c index 7c7e06624dc3..9f625724a20f 100644 --- a/net/netfilter/nf_tables_offload.c +++ b/net/netfilter/nf_tables_offload.c @@ -37,7 +37,7 @@ struct nft_flow_rule *nft_flow_rule_create(struct net *net, struct nft_expr *expr; expr = nft_expr_first(rule); - while (expr->ops && expr != nft_expr_last(rule)) { + while (nft_expr_more(rule, expr)) { if (expr->ops->offload_flags & NFT_OFFLOAD_F_ACTION) num_actions++; @@ -61,7 +61,7 @@ struct nft_flow_rule *nft_flow_rule_create(struct net *net, ctx->net = net; ctx->dep.type = NFT_OFFLOAD_DEP_UNSPEC; - while (expr->ops && expr != nft_expr_last(rule)) { + while (nft_expr_more(rule, expr)) { if (!expr->ops->offload) { err = -EOPNOTSUPP; goto err_out; -- 2.20.1 ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH linux-5.9 1/1] net: netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create 2020-10-20 11:50 ` Pablo Neira Ayuso @ 2020-10-20 16:45 ` Saeed Mirzamohammadi 2020-10-21 20:08 ` Saeed Mirzamohammadi 0 siblings, 1 reply; 11+ messages in thread From: Saeed Mirzamohammadi @ 2020-10-20 16:45 UTC (permalink / raw) To: Pablo Neira Ayuso Cc: linux-kernel, kadlec, fw, davem, kuba, netfilter-devel, coreteam, netdev Thanks! Yes, that looks good to me. Saeed > On Oct 20, 2020, at 4:50 AM, Pablo Neira Ayuso <pablo@netfilter.org> wrote: > > On Mon, Oct 19, 2020 at 10:25:32AM -0700, saeed.mirzamohammadi@oracle.com wrote: >> From: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com> >> >> This patch fixes the issue due to: >> >> BUG: KASAN: slab-out-of-bounds in nft_flow_rule_create+0x622/0x6a2 >> net/netfilter/nf_tables_offload.c:40 >> Read of size 8 at addr ffff888103910b58 by task syz-executor227/16244 >> >> The error happens when expr->ops is accessed early on before performing the boundary check and after nft_expr_next() moves the expr to go out-of-bounds. >> >> This patch checks the boundary condition before expr->ops that fixes the slab-out-of-bounds Read issue. > > Thanks. I made a slight variant of your patch. > > I'm attaching it, it is also fixing the problem but it introduced > nft_expr_more() and use it everywhere. > > Let me know if this looks fine to you. > <0001-netfilter-fix-KASAN-slab-out-of-bounds-Read-in-nft_f.patch> ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-5.9 1/1] net: netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create 2020-10-20 16:45 ` Saeed Mirzamohammadi @ 2020-10-21 20:08 ` Saeed Mirzamohammadi 2020-10-25 23:31 ` Saeed Mirzamohammadi 0 siblings, 1 reply; 11+ messages in thread From: Saeed Mirzamohammadi @ 2020-10-21 20:08 UTC (permalink / raw) To: Saeed Mirzamohammadi Cc: Pablo Neira Ayuso, stable, linux-kernel, kadlec, fw, davem, kuba, netfilter-devel, coreteam, netdev [-- Attachment #1: Type: text/plain, Size: 99 bytes --] Attached the syzkaller C repro. Tested-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com> [-- Attachment #2: repro.c --] [-- Type: application/octet-stream, Size: 5052 bytes --] // autogenerated by syzkaller (https://github.com/google/syzkaller) #define _GNU_SOURCE #include <endian.h> #include <stdint.h> #include <stdio.h> #include <stdlib.h> #include <string.h> #include <sys/syscall.h> #include <sys/types.h> #include <unistd.h> #define BITMASK(bf_off,bf_len) (((1ull << (bf_len)) - 1) << (bf_off)) #define STORE_BY_BITMASK(type,htobe,addr,val,bf_off,bf_len) *(type*)(addr) =htobe((htobe(*(type*)(addr)) & ~BITMASK((bf_off), (bf_len))) | (((type)(val)<< (bf_off)) & BITMASK((bf_off), (bf_len)))) uint64_t r[2] = {0xffffffffffffffff, 0xffffffffffffffff}; int main(void) { syscall(__NR_mmap, 0x1ffff000ul, 0x1000ul, 0ul, 0x32ul, -1, 0ul); syscall(__NR_mmap, 0x20000000ul, 0x1000000ul, 7ul, 0x32ul, -1, 0ul); syscall(__NR_mmap, 0x21000000ul, 0x1000ul, 0ul, 0x32ul, -1, 0ul); intptr_t res = 0; res = syscall(__NR_socket, 0x10ul, 3ul, 0xc); if (res != -1) r[0] = res; *(uint64_t*)0x20000240 = 0; *(uint32_t*)0x20000248 = 0; *(uint64_t*)0x20000250 = 0x20000100; *(uint64_t*)0x20000100 = 0x20000280; *(uint32_t*)0x20000280 = 0x14; *(uint16_t*)0x20000284 = 0x10; *(uint16_t*)0x20000286 = 1; *(uint32_t*)0x20000288 = 0; *(uint32_t*)0x2000028c = 0; *(uint8_t*)0x20000290 = 0; *(uint8_t*)0x20000291 = 0; *(uint16_t*)0x20000292 = htobe16(0xa); *(uint32_t*)0x20000294 = 0x14; *(uint8_t*)0x20000298 = 2; *(uint8_t*)0x20000299 = 0xa; *(uint16_t*)0x2000029a = 0x401; *(uint32_t*)0x2000029c = 0; *(uint32_t*)0x200002a0 = 0; *(uint8_t*)0x200002a4 = 0; *(uint8_t*)0x200002a5 = 0; *(uint16_t*)0x200002a6 = htobe16(0); *(uint32_t*)0x200002a8 = 0x20; *(uint8_t*)0x200002ac = 0; *(uint8_t*)0x200002ad = 0xa; *(uint16_t*)0x200002ae = 0x401; *(uint32_t*)0x200002b0 = 0; *(uint32_t*)0x200002b4 = 0; *(uint8_t*)0x200002b8 = 1; *(uint8_t*)0x200002b9 = 0; *(uint16_t*)0x200002ba = htobe16(0); *(uint16_t*)0x200002bc = 9; *(uint16_t*)0x200002be = 1; memcpy((void*)0x200002c0, "syz0\000", 5); *(uint32_t*)0x200002c8 = 0x48; *(uint8_t*)0x200002cc = 3; *(uint8_t*)0x200002cd = 0xa; *(uint16_t*)0x200002ce = 0x201; *(uint32_t*)0x200002d0 = 0; *(uint32_t*)0x200002d4 = 0; *(uint8_t*)0x200002d8 = 1; *(uint8_t*)0x200002d9 = 0; *(uint16_t*)0x200002da = htobe16(0); *(uint16_t*)0x200002dc = 9; *(uint16_t*)0x200002de = 3; memcpy((void*)0x200002e0, "syz0\000", 5); *(uint16_t*)0x200002e8 = 9; *(uint16_t*)0x200002ea = 1; memcpy((void*)0x200002ec, "syz0\000", 5); *(uint16_t*)0x200002f4 = 8; STORE_BY_BITMASK(uint16_t, , 0x200002f6, 0xa, 0, 14); STORE_BY_BITMASK(uint16_t, , 0x200002f7, 1, 6, 1); STORE_BY_BITMASK(uint16_t, , 0x200002f7, 0, 7, 1); *(uint32_t*)0x200002f8 = htobe32(2); *(uint16_t*)0x200002fc = 0x14; STORE_BY_BITMASK(uint16_t, , 0x200002fe, 4, 0, 14); STORE_BY_BITMASK(uint16_t, , 0x200002ff, 0, 6, 1); STORE_BY_BITMASK(uint16_t, , 0x200002ff, 1, 7, 1); *(uint16_t*)0x20000300 = 8; STORE_BY_BITMASK(uint16_t, , 0x20000302, 2, 0, 14); STORE_BY_BITMASK(uint16_t, , 0x20000303, 1, 6, 1); STORE_BY_BITMASK(uint16_t, , 0x20000303, 0, 7, 1); *(uint32_t*)0x20000304 = htobe32(2); *(uint16_t*)0x20000308 = 8; STORE_BY_BITMASK(uint16_t, , 0x2000030a, 1, 0, 14); STORE_BY_BITMASK(uint16_t, , 0x2000030b, 1, 6, 1); STORE_BY_BITMASK(uint16_t, , 0x2000030b, 0, 7, 1); *(uint32_t*)0x2000030c = htobe32(0); *(uint32_t*)0x20000310 = 0x14; *(uint16_t*)0x20000314 = 0x11; *(uint16_t*)0x20000316 = 1; *(uint32_t*)0x20000318 = 0; *(uint32_t*)0x2000031c = 0; *(uint8_t*)0x20000320 = 0; *(uint8_t*)0x20000321 = 0; *(uint16_t*)0x20000322 = htobe16(0xa); *(uint64_t*)0x20000108 = 0xa4; *(uint64_t*)0x20000258 = 1; *(uint64_t*)0x20000260 = 0; *(uint64_t*)0x20000268 = 0; *(uint32_t*)0x20000270 = 0; syscall(__NR_sendmsg, r[0], 0x20000240ul, 0ul); res = syscall(__NR_socket, 0x10ul, 3ul, 0xc); if (res != -1) r[1] = res; *(uint64_t*)0x200000c0 = 0; *(uint32_t*)0x200000c8 = 0; *(uint64_t*)0x200000d0 = 0x20000080; *(uint64_t*)0x20000080 = 0x20000500; *(uint32_t*)0x20000500 = 0x14; *(uint16_t*)0x20000504 = 0x10; *(uint16_t*)0x20000506 = 1; *(uint32_t*)0x20000508 = 0; *(uint32_t*)0x2000050c = 0; *(uint8_t*)0x20000510 = 0; *(uint8_t*)0x20000511 = 0; *(uint16_t*)0x20000512 = htobe16(0xa); *(uint32_t*)0x20000514 = 0x2c; *(uint8_t*)0x20000518 = 6; *(uint8_t*)0x20000519 = 0xa; *(uint16_t*)0x2000051a = 0x401; *(uint32_t*)0x2000051c = 0; *(uint32_t*)0x20000520 = 0; *(uint8_t*)0x20000524 = 1; *(uint8_t*)0x20000525 = 0; *(uint16_t*)0x20000526 = htobe16(0); *(uint16_t*)0x20000528 = 9; *(uint16_t*)0x2000052a = 1; memcpy((void*)0x2000052c, "syz0\000", 5); *(uint16_t*)0x20000534 = 9; *(uint16_t*)0x20000536 = 2; memcpy((void*)0x20000538, "syz0\000", 5); *(uint32_t*)0x20000540 = 0x14; *(uint16_t*)0x20000544 = 0x11; *(uint16_t*)0x20000546 = 1; *(uint32_t*)0x20000548 = 0; *(uint32_t*)0x2000054c = 0; *(uint8_t*)0x20000550 = 0; *(uint8_t*)0x20000551 = 0; *(uint16_t*)0x20000552 = htobe16(0xa); *(uint64_t*)0x20000088 = 0x54; *(uint64_t*)0x200000d8 = 1; *(uint64_t*)0x200000e0 = 0; *(uint64_t*)0x200000e8 = 0; *(uint32_t*)0x200000f0 = 0; syscall(__NR_sendmsg, r[1], 0x200000c0ul, 0ul); return 0; } [-- Attachment #3: Type: text/plain, Size: 1210 bytes --] > On Oct 20, 2020, at 9:45 AM, Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com> wrote: > > Thanks! Yes, that looks good to me. > > Saeed > >> On Oct 20, 2020, at 4:50 AM, Pablo Neira Ayuso <pablo@netfilter.org> wrote: >> >> On Mon, Oct 19, 2020 at 10:25:32AM -0700, saeed.mirzamohammadi@oracle.com wrote: >>> From: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com> >>> >>> This patch fixes the issue due to: >>> >>> BUG: KASAN: slab-out-of-bounds in nft_flow_rule_create+0x622/0x6a2 >>> net/netfilter/nf_tables_offload.c:40 >>> Read of size 8 at addr ffff888103910b58 by task syz-executor227/16244 >>> >>> The error happens when expr->ops is accessed early on before performing the boundary check and after nft_expr_next() moves the expr to go out-of-bounds. >>> >>> This patch checks the boundary condition before expr->ops that fixes the slab-out-of-bounds Read issue. >> >> Thanks. I made a slight variant of your patch. >> >> I'm attaching it, it is also fixing the problem but it introduced >> nft_expr_more() and use it everywhere. >> >> Let me know if this looks fine to you. >> <0001-netfilter-fix-KASAN-slab-out-of-bounds-Read-in-nft_f.patch> > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-5.9 1/1] net: netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create 2020-10-21 20:08 ` Saeed Mirzamohammadi @ 2020-10-25 23:31 ` Saeed Mirzamohammadi 2020-10-27 6:21 ` Greg KH 0 siblings, 1 reply; 11+ messages in thread From: Saeed Mirzamohammadi @ 2020-10-25 23:31 UTC (permalink / raw) To: Saeed Mirzamohammadi, stable Cc: Pablo Neira Ayuso, stable, linux-kernel, kadlec, fw, davem, kuba, netfilter-devel, coreteam, netdev Adding stable. > On Oct 21, 2020, at 1:08 PM, Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com> wrote: > > Attached the syzkaller C repro. > > Tested-by: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com> > <repro.c> >> On Oct 20, 2020, at 9:45 AM, Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com> wrote: >> >> Thanks! Yes, that looks good to me. >> >> Saeed >> >>> On Oct 20, 2020, at 4:50 AM, Pablo Neira Ayuso <pablo@netfilter.org> wrote: >>> >>> On Mon, Oct 19, 2020 at 10:25:32AM -0700, saeed.mirzamohammadi@oracle.com wrote: >>>> From: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com> >>>> >>>> This patch fixes the issue due to: >>>> >>>> BUG: KASAN: slab-out-of-bounds in nft_flow_rule_create+0x622/0x6a2 >>>> net/netfilter/nf_tables_offload.c:40 >>>> Read of size 8 at addr ffff888103910b58 by task syz-executor227/16244 >>>> >>>> The error happens when expr->ops is accessed early on before performing the boundary check and after nft_expr_next() moves the expr to go out-of-bounds. >>>> >>>> This patch checks the boundary condition before expr->ops that fixes the slab-out-of-bounds Read issue. >>> >>> Thanks. I made a slight variant of your patch. >>> >>> I'm attaching it, it is also fixing the problem but it introduced >>> nft_expr_more() and use it everywhere. >>> >>> Let me know if this looks fine to you. >>> <0001-netfilter-fix-KASAN-slab-out-of-bounds-Read-in-nft_f.patch> >> > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-5.9 1/1] net: netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create 2020-10-25 23:31 ` Saeed Mirzamohammadi @ 2020-10-27 6:21 ` Greg KH 2020-10-27 6:42 ` Florian Westphal 2020-10-27 8:19 ` Pablo Neira Ayuso 0 siblings, 2 replies; 11+ messages in thread From: Greg KH @ 2020-10-27 6:21 UTC (permalink / raw) To: Saeed Mirzamohammadi Cc: stable, Pablo Neira Ayuso, linux-kernel, kadlec, fw, davem, kuba, netfilter-devel, coreteam, netdev On Sun, Oct 25, 2020 at 04:31:57PM -0700, Saeed Mirzamohammadi wrote: > Adding stable. What did that do? confused, greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-5.9 1/1] net: netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create 2020-10-27 6:21 ` Greg KH @ 2020-10-27 6:42 ` Florian Westphal 2020-10-27 6:49 ` Greg KH 2020-10-27 8:19 ` Pablo Neira Ayuso 1 sibling, 1 reply; 11+ messages in thread From: Florian Westphal @ 2020-10-27 6:42 UTC (permalink / raw) To: Greg KH; +Cc: Saeed Mirzamohammadi, stable, linux-kernel, netfilter-devel Greg KH <gregkh@linuxfoundation.org> wrote: [ Trimming CC ] > On Sun, Oct 25, 2020 at 04:31:57PM -0700, Saeed Mirzamohammadi wrote: > > Adding stable. > > What did that do? Its a request to pick up commit 31cc578ae2de19c748af06d859019dced68e325d Author: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com> Date: Tue Oct 20 13:41:36 2020 +0200 netfilter: nftables_offload: KASAN slab-out-of-bounds Read in nft_flow_rule_create Which lacks a Fixes tag. Should have been: Fixes: c9626a2cbdb20e2 ("netfilter: nf_tables: add hardware offload support") (v5.3+) Hope that makes things clearer. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-5.9 1/1] net: netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create 2020-10-27 6:42 ` Florian Westphal @ 2020-10-27 6:49 ` Greg KH 0 siblings, 0 replies; 11+ messages in thread From: Greg KH @ 2020-10-27 6:49 UTC (permalink / raw) To: Florian Westphal Cc: Saeed Mirzamohammadi, stable, linux-kernel, netfilter-devel On Tue, Oct 27, 2020 at 07:42:26AM +0100, Florian Westphal wrote: > Greg KH <gregkh@linuxfoundation.org> wrote: > > [ Trimming CC ] > > > On Sun, Oct 25, 2020 at 04:31:57PM -0700, Saeed Mirzamohammadi wrote: > > > Adding stable. > > > > What did that do? > > Its a request to pick up > > commit 31cc578ae2de19c748af06d859019dced68e325d > Author: Saeed Mirzamohammadi <saeed.mirzamohammadi@oracle.com> > Date: Tue Oct 20 13:41:36 2020 +0200 > > netfilter: nftables_offload: KASAN slab-out-of-bounds Read in nft_flow_rule_create > > Which lacks a Fixes tag. Should have been: > > Fixes: c9626a2cbdb20e2 ("netfilter: nf_tables: add hardware offload support") > (v5.3+) > > Hope that makes things clearer. That makes it much more obvious and clearer, thank you. Saeed, please be more explicit in the future. thanks, greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-5.9 1/1] net: netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create 2020-10-27 6:21 ` Greg KH 2020-10-27 6:42 ` Florian Westphal @ 2020-10-27 8:19 ` Pablo Neira Ayuso 2020-10-29 11:02 ` Greg KH 1 sibling, 1 reply; 11+ messages in thread From: Pablo Neira Ayuso @ 2020-10-27 8:19 UTC (permalink / raw) To: Greg KH Cc: Saeed Mirzamohammadi, stable, linux-kernel, kadlec, fw, davem, kuba, netfilter-devel, coreteam, netdev Hi Greg, On Tue, Oct 27, 2020 at 07:21:11AM +0100, Greg KH wrote: > On Sun, Oct 25, 2020 at 04:31:57PM -0700, Saeed Mirzamohammadi wrote: > > Adding stable. > > What did that do? Saeed is requesting that stable maintainers cherry-picks this patch: 31cc578ae2de ("netfilter: nftables_offload: KASAN slab-out-of-bounds Read in nft_flow_rule_create") into stable 5.4 and 5.8. Thanks. ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-5.9 1/1] net: netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create 2020-10-27 8:19 ` Pablo Neira Ayuso @ 2020-10-29 11:02 ` Greg KH 2020-10-29 11:06 ` Pablo Neira Ayuso 0 siblings, 1 reply; 11+ messages in thread From: Greg KH @ 2020-10-29 11:02 UTC (permalink / raw) To: Pablo Neira Ayuso Cc: Saeed Mirzamohammadi, stable, linux-kernel, kadlec, fw, davem, kuba, netfilter-devel, coreteam, netdev On Tue, Oct 27, 2020 at 09:19:22AM +0100, Pablo Neira Ayuso wrote: > Hi Greg, > > On Tue, Oct 27, 2020 at 07:21:11AM +0100, Greg KH wrote: > > On Sun, Oct 25, 2020 at 04:31:57PM -0700, Saeed Mirzamohammadi wrote: > > > Adding stable. > > > > What did that do? > > Saeed is requesting that stable maintainers cherry-picks this patch: > > 31cc578ae2de ("netfilter: nftables_offload: KASAN slab-out-of-bounds > Read in nft_flow_rule_create") > > into stable 5.4 and 5.8. 5.9 is also a stable kernel :) Will go queue it up everywhere... thanks, greg k-h ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH linux-5.9 1/1] net: netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create 2020-10-29 11:02 ` Greg KH @ 2020-10-29 11:06 ` Pablo Neira Ayuso 0 siblings, 0 replies; 11+ messages in thread From: Pablo Neira Ayuso @ 2020-10-29 11:06 UTC (permalink / raw) To: Greg KH Cc: Saeed Mirzamohammadi, stable, linux-kernel, kadlec, fw, davem, kuba, netfilter-devel, coreteam, netdev On Thu, Oct 29, 2020 at 12:02:41PM +0100, Greg KH wrote: > On Tue, Oct 27, 2020 at 09:19:22AM +0100, Pablo Neira Ayuso wrote: > > Hi Greg, > > > > On Tue, Oct 27, 2020 at 07:21:11AM +0100, Greg KH wrote: > > > On Sun, Oct 25, 2020 at 04:31:57PM -0700, Saeed Mirzamohammadi wrote: > > > > Adding stable. > > > > > > What did that do? > > > > Saeed is requesting that stable maintainers cherry-picks this patch: > > > > 31cc578ae2de ("netfilter: nftables_offload: KASAN slab-out-of-bounds > > Read in nft_flow_rule_create") > > > > into stable 5.4 and 5.8. > > 5.9 is also a stable kernel :) Oh, indeed, I forgot this one :) > Will go queue it up everywhere... Thanks. ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2020-10-29 11:06 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-10-19 17:25 [PATCH linux-5.9 1/1] net: netfilter: fix KASAN: slab-out-of-bounds Read in nft_flow_rule_create saeed.mirzamohammadi 2020-10-20 11:50 ` Pablo Neira Ayuso 2020-10-20 16:45 ` Saeed Mirzamohammadi 2020-10-21 20:08 ` Saeed Mirzamohammadi 2020-10-25 23:31 ` Saeed Mirzamohammadi 2020-10-27 6:21 ` Greg KH 2020-10-27 6:42 ` Florian Westphal 2020-10-27 6:49 ` Greg KH 2020-10-27 8:19 ` Pablo Neira Ayuso 2020-10-29 11:02 ` Greg KH 2020-10-29 11:06 ` Pablo Neira Ayuso
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.