* [PATCH 2/2] leds: bcm6358: remove unneeded busy status check
@ 2015-12-16 20:13 Álvaro Fernández Rojas
2015-12-17 8:42 ` Jacek Anaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Álvaro Fernández Rojas @ 2015-12-16 20:13 UTC (permalink / raw)
To: linux-leds, j.anaszewski, jogo, f.fainelli, simon, cernekee
Cc: Álvaro Fernández Rojas
The busy status checking isn't needed while reading initial LED status.
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
drivers/leds/leds-bcm6358.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/leds/leds-bcm6358.c b/drivers/leds/leds-bcm6358.c
index 7413e3e..b2cc066 100644
--- a/drivers/leds/leds-bcm6358.c
+++ b/drivers/leds/leds-bcm6358.c
@@ -123,9 +123,6 @@ static int bcm6358_led(struct device *dev, struct device_node *nc, u32 reg,
led->cdev.brightness = LED_FULL;
} else if (!strcmp(state, "keep")) {
unsigned long val;
-
- bcm6358_led_busy(led->mem);
-
val = bcm6358_led_read(led->mem + BCM6358_REG_MODE);
val &= BIT(led->pin);
if ((led->active_low && !val) ||
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 2/2] leds: bcm6358: remove unneeded busy status check
2015-12-16 20:13 [PATCH 2/2] leds: bcm6358: remove unneeded busy status check Álvaro Fernández Rojas
@ 2015-12-17 8:42 ` Jacek Anaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Jacek Anaszewski @ 2015-12-17 8:42 UTC (permalink / raw)
To: Álvaro Fernández Rojas
Cc: linux-leds, jogo, f.fainelli, simon, cernekee
Hi Alvaro,
Thanks for the patch. Applied.
On 12/16/2015 09:13 PM, Álvaro Fernández Rojas wrote:
> The busy status checking isn't needed while reading initial LED status.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
> drivers/leds/leds-bcm6358.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/leds/leds-bcm6358.c b/drivers/leds/leds-bcm6358.c
> index 7413e3e..b2cc066 100644
> --- a/drivers/leds/leds-bcm6358.c
> +++ b/drivers/leds/leds-bcm6358.c
> @@ -123,9 +123,6 @@ static int bcm6358_led(struct device *dev, struct device_node *nc, u32 reg,
> led->cdev.brightness = LED_FULL;
> } else if (!strcmp(state, "keep")) {
> unsigned long val;
> -
> - bcm6358_led_busy(led->mem);
> -
> val = bcm6358_led_read(led->mem + BCM6358_REG_MODE);
> val &= BIT(led->pin);
> if ((led->active_low && !val) ||
>
--
Best Regards,
Jacek Anaszewski
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-17 8:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-16 20:13 [PATCH 2/2] leds: bcm6358: remove unneeded busy status check Álvaro Fernández Rojas
2015-12-17 8:42 ` Jacek Anaszewski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.