From: Peter Hurley <peter@hurleysoftware.com>
To: Timur Tabi <timur@codeaurora.org>, Greg Kroah-Hartman <greg@kroah.com>
Cc: Andre Przywara <andre.przywara@arm.com>,
Linus Walleij <linus.walleij@linaro.org>,
Andrew Jackson <Andrew.Jackson@arm.com>,
cov@codeaurora.org, linux-serial@vger.kernel.org,
jslaby@suse.com, Russell King <rmk+kernel@arm.linux.org.uk>,
Jun Nie <jun.nie@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] tty: amba-pl011: add support for 32-bit register access for earlycon
Date: Thu, 17 Dec 2015 09:06:39 -0800 [thread overview]
Message-ID: <5672EB9F.805@hurleysoftware.com> (raw)
In-Reply-To: <5672E73C.20601@codeaurora.org>
On 12/17/2015 08:47 AM, Timur Tabi wrote:
> Greg Kroah-Hartman wrote:
>>> >There was some disagreement about the usage of
>>> >access_32b vs uap->port.iotype for determining whether we need 32-bit
>>> >accessors or not.
>> There was? I missed that, please send follow-on patches to resolve the
>> issue if there is one.
>
> I can submit a patch that provides an alternative implementation, but I'm pretty sure Russell won't like it.
>
> For reference:
>
> http://www.spinics.net/lists/linux-serial/msg19710.html
>
> Russell said that UPIO_MEM is supposed to be literally only 8-bit access, but then Peter Hurley posted this:
>
> http://www.spinics.net/lists/linux-serial/msg19930.html
>
> which you applied. So my patch would remove access_32b and use UPIO_MEM32/UPIO_MEM instead. It would be a little weird having both patches in your tree, I guess.
I think it'll be ok if you just send a patch to use UPIO_MEM32
instead; I think that situation mostly had to do with inertia
and not wanting to rebase a series like that (which I can
appreciate).
The worst that happens is Russell objects, but I think there's a
good case for the simpler UPIO_MEM32 usage, which plays nice
with earlycon.
Regards,
Peter Hurley
WARNING: multiple messages have this Message-ID (diff)
From: peter@hurleysoftware.com (Peter Hurley)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] tty: amba-pl011: add support for 32-bit register access for earlycon
Date: Thu, 17 Dec 2015 09:06:39 -0800 [thread overview]
Message-ID: <5672EB9F.805@hurleysoftware.com> (raw)
In-Reply-To: <5672E73C.20601@codeaurora.org>
On 12/17/2015 08:47 AM, Timur Tabi wrote:
> Greg Kroah-Hartman wrote:
>>> >There was some disagreement about the usage of
>>> >access_32b vs uap->port.iotype for determining whether we need 32-bit
>>> >accessors or not.
>> There was? I missed that, please send follow-on patches to resolve the
>> issue if there is one.
>
> I can submit a patch that provides an alternative implementation, but I'm pretty sure Russell won't like it.
>
> For reference:
>
> http://www.spinics.net/lists/linux-serial/msg19710.html
>
> Russell said that UPIO_MEM is supposed to be literally only 8-bit access, but then Peter Hurley posted this:
>
> http://www.spinics.net/lists/linux-serial/msg19930.html
>
> which you applied. So my patch would remove access_32b and use UPIO_MEM32/UPIO_MEM instead. It would be a little weird having both patches in your tree, I guess.
I think it'll be ok if you just send a patch to use UPIO_MEM32
instead; I think that situation mostly had to do with inertia
and not wanting to rebase a series like that (which I can
appreciate).
The worst that happens is Russell objects, but I think there's a
good case for the simpler UPIO_MEM32 usage, which plays nice
with earlycon.
Regards,
Peter Hurley
next prev parent reply other threads:[~2015-12-17 17:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-07 0:18 [PATCH] tty: amba-pl011: add support for 32-bit register access for earlycon Timur Tabi
2015-11-07 0:18 ` Timur Tabi
2015-12-13 6:06 ` Greg Kroah-Hartman
2015-12-13 6:06 ` Greg Kroah-Hartman
2015-12-13 15:34 ` Timur Tabi
2015-12-13 15:34 ` Timur Tabi
2015-12-17 15:55 ` Timur Tabi
2015-12-17 15:55 ` Timur Tabi
2015-12-17 16:27 ` Greg Kroah-Hartman
2015-12-17 16:27 ` Greg Kroah-Hartman
2015-12-17 16:47 ` Timur Tabi
2015-12-17 16:47 ` Timur Tabi
2015-12-17 17:06 ` Peter Hurley [this message]
2015-12-17 17:06 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5672EB9F.805@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=Andrew.Jackson@arm.com \
--cc=andre.przywara@arm.com \
--cc=cov@codeaurora.org \
--cc=greg@kroah.com \
--cc=jslaby@suse.com \
--cc=jun.nie@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.