[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Andreas Ehmanns]

Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
---
 package/nfs-utils/S60nfs | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/package/nfs-utils/S60nfs b/package/nfs-utils/S60nfs
index ec7c909..5639b8f 100755
--- a/package/nfs-utils/S60nfs
+++ b/package/nfs-utils/S60nfs
@@ -13,6 +13,14 @@ mkdir -p /run/nfs/sm
 mkdir -p /run/nfs/sm.bak
 touch /run/nfs/rmtab
 
+CFG_FILE=/etc/default/nfsd
+
+NR_THREADS=2
+if [ -f "${CFG_FILE}" ]; then
+    . "${CFG_FILE}"
+fi
+
+
 start() {
 	# Start daemons.
 	printf "Starting NFS statd: "
@@ -25,7 +33,7 @@ start() {
 	echo "done"
 
 	printf "Starting NFS daemon: "
-	rpc.nfsd 2
+	rpc.nfsd ${NR_THREADS}
 	echo "done"
 
 	printf "Starting NFS mountd: "
@@ -40,7 +48,7 @@ stop() {
 	killall -q rpc.mountd
 	echo "done"
 
-	echo "Shutting down NFS daemon: "
+	printf "Shutting down NFS daemon: "
 	kill -9 `pidof nfsd` 2>/dev/null
 	echo "done"
 
-- 
2.1.4

[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Yann E. MORIN]

Andreas, All,

On 2015-12-17 20:45 +0100, Andreas Ehmanns spake thusly:
> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>

I forgot in my previous reply, but subject should have been:

    package/nfsd: accept config to set number of threads

This can be fixed by a maintainer when he applies, so no need to
resubmit...

Otherwise:

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Unrelated yto this change, I noticed that this script is completely
consistent with how it stops services:
  - sometimes, we killall, sometimes we kill-9
  - the order in which we kill, echo and rm pid file is not consistent

It would be nice if we stopped all the NFS services in a consistent way,
like always use killall, then remove the pid file, and eventually echo
the status. Would you like to send a follow-up patch that does that
cleanup, please? ;-)

Regards,
Yann E. MORIN.

> ---
>  package/nfs-utils/S60nfs | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/package/nfs-utils/S60nfs b/package/nfs-utils/S60nfs
> index ec7c909..5639b8f 100755
> --- a/package/nfs-utils/S60nfs
> +++ b/package/nfs-utils/S60nfs
> @@ -13,6 +13,14 @@ mkdir -p /run/nfs/sm
>  mkdir -p /run/nfs/sm.bak
>  touch /run/nfs/rmtab
>  
> +CFG_FILE=/etc/default/nfsd
> +
> +NR_THREADS=2
> +if [ -f "${CFG_FILE}" ]; then
> +    . "${CFG_FILE}"
> +fi
> +
> +
>  start() {
>  	# Start daemons.
>  	printf "Starting NFS statd: "
> @@ -25,7 +33,7 @@ start() {
>  	echo "done"
>  
>  	printf "Starting NFS daemon: "
> -	rpc.nfsd 2
> +	rpc.nfsd ${NR_THREADS}
>  	echo "done"
>  
>  	printf "Starting NFS mountd: "
> @@ -40,7 +48,7 @@ stop() {
>  	killall -q rpc.mountd
>  	echo "done"
>  
> -	echo "Shutting down NFS daemon: "
> +	printf "Shutting down NFS daemon: "
>  	kill -9 `pidof nfsd` 2>/dev/null
>  	echo "done"
>  
> -- 
> 2.1.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Andreas Ehmanns]

Yann,
Am 17.12.2015 um 21:04 schrieb Yann E. MORIN:
> Andreas, All,
>
> On 2015-12-17 20:45 +0100, Andreas Ehmanns spake thusly:
>> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
> I forgot in my previous reply, but subject should have been:
>
>      package/nfsd: accept config to set number of threads
>
> This can be fixed by a maintainer when he applies, so no need to
> resubmit...
>
> Otherwise:
>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> Unrelated yto this change, I noticed that this script is completely
> consistent with how it stops services:
>    - sometimes, we killall, sometimes we kill-9
>    - the order in which we kill, echo and rm pid file is not consistent
>
> It would be nice if we stopped all the NFS services in a consistent way,
> like always use killall, then remove the pid file, and eventually echo
> the status. Would you like to send a follow-up patch that does that
> cleanup, please? ;-)
>
> Regards,
> Yann E. MORIN.
>
>> ---
>>   package/nfs-utils/S60nfs | 12 ++++++++++--
>>   1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/nfs-utils/S60nfs b/package/nfs-utils/S60nfs
>> index ec7c909..5639b8f 100755
>> --- a/package/nfs-utils/S60nfs
>> +++ b/package/nfs-utils/S60nfs
>> @@ -13,6 +13,14 @@ mkdir -p /run/nfs/sm
>>   mkdir -p /run/nfs/sm.bak
>>   touch /run/nfs/rmtab
>>   
>> +CFG_FILE=/etc/default/nfsd
>> +
>> +NR_THREADS=2
>> +if [ -f "${CFG_FILE}" ]; then
>> +    . "${CFG_FILE}"
>> +fi
>> +
>> +
>>   start() {
>>   	# Start daemons.
>>   	printf "Starting NFS statd: "
>> @@ -25,7 +33,7 @@ start() {
>>   	echo "done"
>>   
>>   	printf "Starting NFS daemon: "
>> -	rpc.nfsd 2
>> +	rpc.nfsd ${NR_THREADS}
>>   	echo "done"
>>   
>>   	printf "Starting NFS mountd: "
>> @@ -40,7 +48,7 @@ stop() {
>>   	killall -q rpc.mountd
>>   	echo "done"
>>   
>> -	echo "Shutting down NFS daemon: "
>> +	printf "Shutting down NFS daemon: "
>>   	kill -9 `pidof nfsd` 2>/dev/null
>>   	echo "done"
>>   
>> -- 
>> 2.1.4
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
I can prepare a patch for that but I have no possibility to test the 
changes since today was my last day in office for this year and I don't 
have a target system here at home.

What do you think?

Regards,
Andreas

[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Yann E. MORIN]

Andreas, All,

On 2015-12-17 21:14 +0100, Andreas Ehmanns spake thusly:
> Am 17.12.2015 um 21:04 schrieb Yann E. MORIN:
[--SNIP--]
> >Unrelated yto this change, I noticed that this script is completely
> >consistent with how it stops services:
> >   - sometimes, we killall, sometimes we kill-9
> >   - the order in which we kill, echo and rm pid file is not consistent
> >
> >It would be nice if we stopped all the NFS services in a consistent way,
> >like always use killall, then remove the pid file, and eventually echo
> >the status. Would you like to send a follow-up patch that does that
> >cleanup, please? ;-)
> I can prepare a patch for that but I have no possibility to test the changes
> since today was my last day in office for this year and I don't have a
> target system here at home.
> 
> What do you think?

No problem at all! Just work on it when you can, it's absolutely not
time-critical.

Thanks, and happy end-of-year celebrations! ;-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Andreas Ehmanns]

Yann, All,
Am 17.12.2015 um 21:25 schrieb Yann E. MORIN:
> Andreas, All,
>
> On 2015-12-17 21:14 +0100, Andreas Ehmanns spake thusly:
>> Am 17.12.2015 um 21:04 schrieb Yann E. MORIN:
> [--SNIP--]
>>> Unrelated yto this change, I noticed that this script is completely
>>> consistent with how it stops services:
>>>    - sometimes, we killall, sometimes we kill-9
>>>    - the order in which we kill, echo and rm pid file is not consistent
>>>
>>> It would be nice if we stopped all the NFS services in a consistent way,
>>> like always use killall, then remove the pid file, and eventually echo
>>> the status. Would you like to send a follow-up patch that does that
>>> cleanup, please? ;-)
>> I can prepare a patch for that but I have no possibility to test the changes
>> since today was my last day in office for this year and I don't have a
>> target system here at home.
>>
>> What do you think?
> No problem at all! Just work on it when you can, it's absolutely not
> time-critical.
>
> Thanks, and happy end-of-year celebrations! ;-)
>
> Regards,
> Yann E. MORIN.
>
O.k. I will prepare it begin of January.

Regards,
Andreas

[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Thomas Petazzoni]

Dear Andreas Ehmanns,

On Thu, 17 Dec 2015 20:45:05 +0100, Andreas Ehmanns wrote:
> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
> ---
>  package/nfs-utils/S60nfs | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)

Applied after adjusting the commit title, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Andreas Ehmanns]

Dear Yann,
please find below the rework of the nfsd init script.
The changes are very small. Please note that a change from

kill -9 `pidof nfsd` 2>/dev/null

to killall was not possible since killall did not kill the nfsd threads. 
It simply did not work and I couldn't figure out the root cause.

Let me know what you think about. If it's o.k. for you, I re-send the 
patch using git.

Regards,
Andreas

Am 17.12.2015 um 21:25 schrieb Yann E. MORIN:
> Andreas, All,
>
> On 2015-12-17 21:14 +0100, Andreas Ehmanns spake thusly:
>> Am 17.12.2015 um 21:04 schrieb Yann E. MORIN:
> [--SNIP--]
>>> Unrelated yto this change, I noticed that this script is completely
>>> consistent with how it stops services:
>>>    - sometimes, we killall, sometimes we kill-9
>>>    - the order in which we kill, echo and rm pid file is not consistent
>>>
>>> It would be nice if we stopped all the NFS services in a consistent way,
>>> like always use killall, then remove the pid file, and eventually echo
>>> the status. Would you like to send a follow-up patch that does that
>>> cleanup, please? ;-)
>> I can prepare a patch for that but I have no possibility to test the changes
>> since today was my last day in office for this year and I don't have a
>> target system here at home.
>>
>> What do you think?
> No problem at all! Just work on it when you can, it's absolutely not
> time-critical.
>
> Thanks, and happy end-of-year celebrations! ;-)
>
> Regards,
> Yann E. MORIN.
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Reordered-kill-echo-and-pid-file-remove.patch
Type: text/x-patch
Size: 1045 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160204/baa05842/attachment.bin>

[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Yann E. MORIN]

Andreas, All,

On 2016-02-04 09:31 +0100, Andreas Ehmanns spake thusly:
> Dear Yann,
> please find below the rework of the nfsd init script.
> The changes are very small. Please note that a change from
> 
> kill -9 `pidof nfsd` 2>/dev/null
> 
> to killall was not possible since killall did not kill the nfsd threads. It
> simply did not work and I couldn't figure out the root cause.

What about using something like;
    rpc.nfsd 0
    killall -9 nfsd

From 'man rpc.nfsd':
    In particular rpc.nfsd 0 will stop all threads and thus close any
    open connections.

(maybe with a little sleep in-between the two calls to let things settle
down?)

Care to have a look, please?

> Let me know what you think about. If it's o.k. for you, I re-send the patch
> using git.

Well, it's already a nice improvement. ;-)

Please, consider the above suggestion. Adapt the script if required, and
respin with git, please.

Thanks! :-)

Regards,
Yann E. MORIN.

> From 13fa8728220cfe80b7ab3d48837183088f4094d5 Mon Sep 17 00:00:00 2001
> From: Andreas Ehmanns <universeII@gmx.de>
> Date: Thu, 4 Feb 2016 09:23:35 +0100
> Subject: [PATCH 1/1] Reordered kill, echo and pid file remove
> 
> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
> ---
>  package/nfs-utils/S60nfs | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/package/nfs-utils/S60nfs b/package/nfs-utils/S60nfs
> index 5639b8f..0bd5a44 100755
> --- a/package/nfs-utils/S60nfs
> +++ b/package/nfs-utils/S60nfs
> @@ -38,8 +38,8 @@ start() {
>  
>  	printf "Starting NFS mountd: "
>  	rpc.mountd
> -	echo "done"
>  	touch /var/lock/subsys/nfs
> +	echo "done"
>  }
>  
>  stop() {
> @@ -54,14 +54,15 @@ stop() {
>  
>  	printf "Shutting down NFS services: "
>  	/usr/sbin/exportfs -au
> -	rm -f /var/lock/subsys/nfs
>  	killall -q rpc.statd
> +	rm -f /var/lock/subsys/nfs
>  	echo "done"
>  
>  	printf "Stopping NFS statd: "
>  	killall -q rpc.statd
> -	echo "done"
> +	rm -f /var/run/rpc.statd.pid
>  	rm -f /var/lock/subsys/nfslock
> +	echo "done"
>  }
>  
>  # See how we were called.
> -- 
> 2.1.4
> 


-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Andreas Ehmanns]

Yann,
indeed a killall -9 worked. So I reworked the patch. According to 
Thomas' recommendation I added the OK/FAIL output as done in the dropbox 
init script.
Please have a look at the attached patch. If it's o.k., I'll resend it 
using git.

Regards,
Andreas

Am 04.02.2016 um 21:50 schrieb Yann E. MORIN:
> Andreas, All,
>
> On 2016-02-04 09:31 +0100, Andreas Ehmanns spake thusly:
>> Dear Yann,
>> please find below the rework of the nfsd init script.
>> The changes are very small. Please note that a change from
>>
>> kill -9 `pidof nfsd` 2>/dev/null
>>
>> to killall was not possible since killall did not kill the nfsd threads. It
>> simply did not work and I couldn't figure out the root cause.
> What about using something like;
>      rpc.nfsd 0
>      killall -9 nfsd
>
>  From 'man rpc.nfsd':
>      In particular rpc.nfsd 0 will stop all threads and thus close any
>      open connections.
>
> (maybe with a little sleep in-between the two calls to let things settle
> down?)
>
> Care to have a look, please?
>
>> Let me know what you think about. If it's o.k. for you, I re-send the patch
>> using git.
> Well, it's already a nice improvement. ;-)
>
> Please, consider the above suggestion. Adapt the script if required, and
> respin with git, please.
>
> Thanks! :-)
>
> Regards,
> Yann E. MORIN.
>
>>  From 13fa8728220cfe80b7ab3d48837183088f4094d5 Mon Sep 17 00:00:00 2001
>> From: Andreas Ehmanns <universeII@gmx.de>
>> Date: Thu, 4 Feb 2016 09:23:35 +0100
>> Subject: [PATCH 1/1] Reordered kill, echo and pid file remove
>>
>> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
>> ---
>>   package/nfs-utils/S60nfs | 7 ++++---
>>   1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/package/nfs-utils/S60nfs b/package/nfs-utils/S60nfs
>> index 5639b8f..0bd5a44 100755
>> --- a/package/nfs-utils/S60nfs
>> +++ b/package/nfs-utils/S60nfs
>> @@ -38,8 +38,8 @@ start() {
>>   
>>   	printf "Starting NFS mountd: "
>>   	rpc.mountd
>> -	echo "done"
>>   	touch /var/lock/subsys/nfs
>> +	echo "done"
>>   }
>>   
>>   stop() {
>> @@ -54,14 +54,15 @@ stop() {
>>   
>>   	printf "Shutting down NFS services: "
>>   	/usr/sbin/exportfs -au
>> -	rm -f /var/lock/subsys/nfs
>>   	killall -q rpc.statd
>> +	rm -f /var/lock/subsys/nfs
>>   	echo "done"
>>   
>>   	printf "Stopping NFS statd: "
>>   	killall -q rpc.statd
>> -	echo "done"
>> +	rm -f /var/run/rpc.statd.pid
>>   	rm -f /var/lock/subsys/nfslock
>> +	echo "done"
>>   }
>>   
>>   # See how we were called.
>> -- 
>> 2.1.4
>>
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remorked-nfsd-init-script-and-added-OK-FAIL-output.patch
Type: text/x-patch
Size: 1815 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160212/b7b7ddef/attachment.bin>

[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Andreas Ehmanns]

Yann,
is the patch o.k. for you? Shall I resend it using git?
Please let me know.

Regards,
Andreas

Am 12.02.2016 um 10:31 schrieb Andreas Ehmanns:
> Yann,
> indeed a killall -9 worked. So I reworked the patch. According to 
> Thomas' recommendation I added the OK/FAIL output as done in the 
> dropbox init script.
> Please have a look at the attached patch. If it's o.k., I'll resend it 
> using git.
>
> Regards,
> Andreas
>
> Am 04.02.2016 um 21:50 schrieb Yann E. MORIN:
>> Andreas, All,
>>
>> On 2016-02-04 09:31 +0100, Andreas Ehmanns spake thusly:
>>> Dear Yann,
>>> please find below the rework of the nfsd init script.
>>> The changes are very small. Please note that a change from
>>>
>>> kill -9 `pidof nfsd` 2>/dev/null
>>>
>>> to killall was not possible since killall did not kill the nfsd 
>>> threads. It
>>> simply did not work and I couldn't figure out the root cause.
>> What about using something like;
>>      rpc.nfsd 0
>>      killall -9 nfsd
>>
>>  From 'man rpc.nfsd':
>>      In particular rpc.nfsd 0 will stop all threads and thus close any
>>      open connections.
>>
>> (maybe with a little sleep in-between the two calls to let things settle
>> down?)
>>
>> Care to have a look, please?
>>
>>> Let me know what you think about. If it's o.k. for you, I re-send 
>>> the patch
>>> using git.
>> Well, it's already a nice improvement. ;-)
>>
>> Please, consider the above suggestion. Adapt the script if required, and
>> respin with git, please.
>>
>> Thanks! :-)
>>
>> Regards,
>> Yann E. MORIN.
>>
>>>  From 13fa8728220cfe80b7ab3d48837183088f4094d5 Mon Sep 17 00:00:00 2001
>>> From: Andreas Ehmanns <universeII@gmx.de>
>>> Date: Thu, 4 Feb 2016 09:23:35 +0100
>>> Subject: [PATCH 1/1] Reordered kill, echo and pid file remove
>>>
>>> Signed-off-by: Andreas Ehmanns <universeII@gmx.de>
>>> ---
>>>   package/nfs-utils/S60nfs | 7 ++++---
>>>   1 file changed, 4 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/package/nfs-utils/S60nfs b/package/nfs-utils/S60nfs
>>> index 5639b8f..0bd5a44 100755
>>> --- a/package/nfs-utils/S60nfs
>>> +++ b/package/nfs-utils/S60nfs
>>> @@ -38,8 +38,8 @@ start() {
>>>         printf "Starting NFS mountd: "
>>>       rpc.mountd
>>> -    echo "done"
>>>       touch /var/lock/subsys/nfs
>>> +    echo "done"
>>>   }
>>>     stop() {
>>> @@ -54,14 +54,15 @@ stop() {
>>>         printf "Shutting down NFS services: "
>>>       /usr/sbin/exportfs -au
>>> -    rm -f /var/lock/subsys/nfs
>>>       killall -q rpc.statd
>>> +    rm -f /var/lock/subsys/nfs
>>>       echo "done"
>>>         printf "Stopping NFS statd: "
>>>       killall -q rpc.statd
>>> -    echo "done"
>>> +    rm -f /var/run/rpc.statd.pid
>>>       rm -f /var/lock/subsys/nfslock
>>> +    echo "done"
>>>   }
>>>     # See how we were called.
>>> -- 
>>> 2.1.4
>>>
>>
>
>
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20160225/00c2e837/attachment.html>

[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Arnout Vandecappelle]

On 02/25/16 21:40, Andreas Ehmanns wrote:
> Yann,
> is the patch o.k. for you? Shall I resend it using git?

 Yes, please send using git. Patches sent as attachments have an even bigger
chance of being ignored than other patches.

 However, I can already say that it should be two separate patches: one changing
"done" to OK/FAIL, and a second one doing the functional changes.

 Regards,
 Arnout

> Please let me know.
> 
> Regards,
> Andreas
> 
> Am 12.02.2016 um 10:31 schrieb Andreas Ehmanns:
>> Yann,
>> indeed a killall -9 worked. So I reworked the patch. According to Thomas'
>> recommendation I added the OK/FAIL output as done in the dropbox init script.
>> Please have a look at the attached patch. If it's o.k., I'll resend it using git.
[snip]

-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Andreas Ehmanns]

Am 26.02.2016 um 00:30 schrieb Arnout Vandecappelle:
> On 02/25/16 21:40, Andreas Ehmanns wrote:
>> Yann,
>> is the patch o.k. for you? Shall I resend it using git?
>   Yes, please send using git. Patches sent as attachments have an even bigger
> chance of being ignored than other patches.
>
>   However, I can already say that it should be two separate patches: one changing
> "done" to OK/FAIL, and a second one doing the functional changes.
>
>   Regards,
>   Arnout

Yann, Arnout,
can someone of you please check what happened with this patch? It's more 
than one month and a half ago that I sent it and it seems that it is 
still not incorporated?
Is there something from my side what is missing?

Additionally I sent a set of patches for the netsnmp init script one day 
before which are also not incorporated?
Can you please have a look?

Regards,
Andreas

>
>> Please let me know.
>>
>> Regards,
>> Andreas
>>
>> Am 12.02.2016 um 10:31 schrieb Andreas Ehmanns:
>>> Yann,
>>> indeed a killall -9 worked. So I reworked the patch. According to Thomas'
>>> recommendation I added the OK/FAIL output as done in the dropbox init script.
>>> Please have a look at the attached patch. If it's o.k., I'll resend it using git.
> [snip]
>

[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Arnout Vandecappelle]

On 04/15/16 10:37, Andreas Ehmanns wrote:
> Am 26.02.2016 um 00:30 schrieb Arnout Vandecappelle:
>> On 02/25/16 21:40, Andreas Ehmanns wrote:
>>> Yann,
>>> is the patch o.k. for you? Shall I resend it using git?
>>   Yes, please send using git. Patches sent as attachments have an even bigger
>> chance of being ignored than other patches.
>>
>>   However, I can already say that it should be two separate patches: one changing
>> "done" to OK/FAIL, and a second one doing the functional changes.
>>
>>   Regards,
>>   Arnout
>
> Yann, Arnout,
> can someone of you please check what happened with this patch? It's more than
> one month and a half ago that I sent it and it seems that it is still not
> incorporated?

  We are unfortunately swamped with patches that need review, and we don't have 
enough people doing reviews. And we're not willing to forego on quality by 
accepting patches without review.

  We will get to your patches eventually, because they are tracked in patchwork. 
Note that the oldest pending patch is 9 months old, to give you an idea of what 
you can expect.


  What you can do to speed things up:

- Help out with reviewing and testing. Look at some (non-trivial) patches that 
are relevant to you (e.g. affecting a package that you use), download and test 
it, then give it your Tested-by tag. You can also go over the changes, look for 
any mistakes that you can identify, and give feedback or give it your 
Reviewed-by tag. Obviously, your reviews will not immediately carry the same 
weight as those of long-time buildroot developers, but they are really helpful.

- Reply to your patches with 'ping', so they appear on the top of the stack 
again. Note that this doesn't help that much because we're still swamped. But it 
does at least tell us that you will be paying attention if we have any feedback 
to give.


  Regards,
  Arnout

> Is there something from my side what is missing?
>
> Additionally I sent a set of patches for the netsnmp init script one day before
> which are also not incorporated?
> Can you please have a look?
>
> Regards,
> Andreas
>
>>
>>> Please let me know.
>>>
>>> Regards,
>>> Andreas
>>>
>>> Am 12.02.2016 um 10:31 schrieb Andreas Ehmanns:
>>>> Yann,
>>>> indeed a killall -9 worked. So I reworked the patch. According to Thomas'
>>>> recommendation I added the OK/FAIL output as done in the dropbox init script.
>>>> Please have a look at the attached patch. If it's o.k., I'll resend it using
>>>> git.
>> [snip]
>>
>

-- 
Arnout Vandecappelle      arnout dot vandecappelle at essensium dot com
Senior Embedded Software Architect . . . . . . +32-478-010353 (mobile)
Essensium, Mind division . . . . . . . . . . . . . . http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium . . . . . BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Andreas Ehmanns]

Am 15.04.2016 um 11:00 schrieb Arnout Vandecappelle:
>
>
> On 04/15/16 10:37, Andreas Ehmanns wrote:
>> Am 26.02.2016 um 00:30 schrieb Arnout Vandecappelle:
>>> On 02/25/16 21:40, Andreas Ehmanns wrote:
>>>> Yann,
>>>> is the patch o.k. for you? Shall I resend it using git?
>>>   Yes, please send using git. Patches sent as attachments have an 
>>> even bigger
>>> chance of being ignored than other patches.
>>>
>>>   However, I can already say that it should be two separate patches: 
>>> one changing
>>> "done" to OK/FAIL, and a second one doing the functional changes.
>>>
>>>   Regards,
>>>   Arnout
>>
>> Yann, Arnout,
>> can someone of you please check what happened with this patch? It's 
>> more than
>> one month and a half ago that I sent it and it seems that it is still 
>> not
>> incorporated?
>
>  We are unfortunately swamped with patches that need review, and we 
> don't have enough people doing reviews. And we're not willing to 
> forego on quality by accepting patches without review.
>
>  We will get to your patches eventually, because they are tracked in 
> patchwork. Note that the oldest pending patch is 9 months old, to give 
> you an idea of what you can expect.

Arnout,
I wasn't aware of that. So it seems that I was a little bit too impatient.

Thanks for the clarification and I will have a look if I can follow your 
recommendation and review some patches.

Regards,
Andreas

>
>
>  What you can do to speed things up:
>
> - Help out with reviewing and testing. Look at some (non-trivial) 
> patches that are relevant to you (e.g. affecting a package that you 
> use), download and test it, then give it your Tested-by tag. You can 
> also go over the changes, look for any mistakes that you can identify, 
> and give feedback or give it your Reviewed-by tag. Obviously, your 
> reviews will not immediately carry the same weight as those of 
> long-time buildroot developers, but they are really helpful.
>
> - Reply to your patches with 'ping', so they appear on the top of the 
> stack again. Note that this doesn't help that much because we're still 
> swamped. But it does at least tell us that you will be paying 
> attention if we have any feedback to give.
>
>
>  Regards,
>  Arnout
>
>> Is there something from my side what is missing?
>>
>> Additionally I sent a set of patches for the netsnmp init script one 
>> day before
>> which are also not incorporated?
>> Can you please have a look?
>>
>> Regards,
>> Andreas
>>
>>>
>>>> Please let me know.
>>>>
>>>> Regards,
>>>> Andreas
>>>>
>>>> Am 12.02.2016 um 10:31 schrieb Andreas Ehmanns:
>>>>> Yann,
>>>>> indeed a killall -9 worked. So I reworked the patch. According to 
>>>>> Thomas'
>>>>> recommendation I added the OK/FAIL output as done in the dropbox 
>>>>> init script.
>>>>> Please have a look at the attached patch. If it's o.k., I'll 
>>>>> resend it using
>>>>> git.
>>> [snip]
>>>
>>
>

[Buildroot] [PATCH 1/1] Add config to nfsd to set number of threads

[Arnout Vandecappelle]

On 04/15/16 11:09, Andreas Ehmanns wrote:
> Am 15.04.2016 um 11:00 schrieb Arnout Vandecappelle:
>>
>>
>> On 04/15/16 10:37, Andreas Ehmanns wrote:
>>> Am 26.02.2016 um 00:30 schrieb Arnout Vandecappelle:
>>>> On 02/25/16 21:40, Andreas Ehmanns wrote:
>>>>> Yann,
>>>>> is the patch o.k. for you? Shall I resend it using git?
>>>>   Yes, please send using git. Patches sent as attachments have an even bigger
>>>> chance of being ignored than other patches.
>>>>
>>>>   However, I can already say that it should be two separate patches: one
>>>> changing
>>>> "done" to OK/FAIL, and a second one doing the functional changes.
>>>>
>>>>   Regards,
>>>>   Arnout
>>>
>>> Yann, Arnout,
>>> can someone of you please check what happened with this patch? It's more than
>>> one month and a half ago that I sent it and it seems that it is still not
>>> incorporated?
>>
>>  We are unfortunately swamped with patches that need review, and we don't have
>> enough people doing reviews. And we're not willing to forego on quality by
>> accepting patches without review.
>>
>>  We will get to your patches eventually, because they are tracked in
>> patchwork. Note that the oldest pending patch is 9 months old, to give you an
>> idea of what you can expect.
>
> Arnout,
> I wasn't aware of that. So it seems that I was a little bit too impatient.

  I think your impatience is very reasonable. This point is discussed at about 
every buildroot developer meeting. Asking people to do more reviews is about the 
only thing we have come up with. If you have other ideas, feel free to launch them.

  Well, actually, we do have one other solution: the Buildroot Summer Camp, 
where a bunch of core developers come together for 4-5 days for a long hacking 
session. Last year we managed to get about 300 patches applied, and developed 
some important new features like the kernel-module infra, better support for 
systemd, ...



>
> Thanks for the clarification and I will have a look if I can follow your
> recommendation and review some patches.

  Thanks! That's really appreciated!

  Regards,
  Arnout

>
> Regards,
> Andreas
>
>>
>>
>>  What you can do to speed things up:
>>
>> - Help out with reviewing and testing. Look at some (non-trivial) patches that
>> are relevant to you (e.g. affecting a package that you use), download and test
>> it, then give it your Tested-by tag. You can also go over the changes, look
>> for any mistakes that you can identify, and give feedback or give it your
>> Reviewed-by tag. Obviously, your reviews will not immediately carry the same
>> weight as those of long-time buildroot developers, but they are really helpful.
>>
>> - Reply to your patches with 'ping', so they appear on the top of the stack
>> again. Note that this doesn't help that much because we're still swamped. But
>> it does at least tell us that you will be paying attention if we have any
>> feedback to give.
>>
>>
>>  Regards,
>>  Arnout
>>
>>> Is there something from my side what is missing?
>>>
>>> Additionally I sent a set of patches for the netsnmp init script one day before
>>> which are also not incorporated?
>>> Can you please have a look?
>>>
>>> Regards,
>>> Andreas
>>>
>>>>
>>>>> Please let me know.
>>>>>
>>>>> Regards,
>>>>> Andreas
>>>>>
>>>>> Am 12.02.2016 um 10:31 schrieb Andreas Ehmanns:
>>>>>> Yann,
>>>>>> indeed a killall -9 worked. So I reworked the patch. According to Thomas'
>>>>>> recommendation I added the OK/FAIL output as done in the dropbox init script.
>>>>>> Please have a look at the attached patch. If it's o.k., I'll resend it using
>>>>>> git.
>>>> [snip]
>>>>
>>>
>>
>

-- 
Arnout Vandecappelle      arnout dot vandecappelle at essensium dot com
Senior Embedded Software Architect . . . . . . +32-478-010353 (mobile)
Essensium, Mind division . . . . . . . . . . . . . . http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium . . . . . BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF