All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zefan Li <lizefan@huawei.com>
To: Johannes Weiner <hannes@cmpxchg.org>, Tejun Heo <tj@kernel.org>
Cc: <cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel-team@fb.com>
Subject: Re: [PATCH 2/2] cgroup: put controller Kconfig options in meaningful order
Date: Fri, 18 Dec 2015 10:26:05 +0800	[thread overview]
Message-ID: <56736EBD.8060302@huawei.com> (raw)
In-Reply-To: <1450390797-4748-3-git-send-email-hannes@cmpxchg.org>

On 2015/12/18 6:19, Johannes Weiner wrote:
> To make it easier to quickly find what's needed list the basic
> resource controllers of cgroup2 first - io, memory, cpu - while
> pushing the more exotic and/or legacy controllers to the bottom.
>
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Acked-by: Zefan Li <lizefan@huawei.com>

> ---
>   init/Kconfig | 214 +++++++++++++++++++++++++++++------------------------------
>   1 file changed, 107 insertions(+), 107 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index ed324f5..fdb5ecb 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -957,64 +957,6 @@ menuconfig CGROUPS
>
...
> +config CGROUP_PERF
> +	bool "Perf controller"
> +	depends on PERF_EVENTS && CGROUPS

While you are at it, remove "&& CGROUPS" ?

> +	help
> +	  This option extends the perf per-cpu mode to restrict monitoring
> +	  to threads which belong to the cgroup specified and run on the
> +	  designated cpu.
> +
> +	  Say N if unsure.
> +
> +config CGROUP_DEBUG
> +	bool "Example controller"
>   	default n
> -	---help---
> -	Enable some debugging help. Currently it exports additional stat
> -	files in a cgroup which can be useful for debugging.
> +	help
> +	  This option enables a simple controller that exports
> +	  debugging information about the cgroups framework.
>
> -config CGROUP_WRITEBACK
> -	bool
> -	depends on MEMCG && BLK_CGROUP
> -	default y
> +	  Say N.
>
>   endif # CGROUPS
>
>


WARNING: multiple messages have this Message-ID (diff)
From: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
To: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	kernel-team-b10kYP2dOMg@public.gmane.org
Subject: Re: [PATCH 2/2] cgroup: put controller Kconfig options in meaningful order
Date: Fri, 18 Dec 2015 10:26:05 +0800	[thread overview]
Message-ID: <56736EBD.8060302@huawei.com> (raw)
In-Reply-To: <1450390797-4748-3-git-send-email-hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>

On 2015/12/18 6:19, Johannes Weiner wrote:
> To make it easier to quickly find what's needed list the basic
> resource controllers of cgroup2 first - io, memory, cpu - while
> pushing the more exotic and/or legacy controllers to the bottom.
>
> Signed-off-by: Johannes Weiner <hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>

Acked-by: Zefan Li <lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>

> ---
>   init/Kconfig | 214 +++++++++++++++++++++++++++++------------------------------
>   1 file changed, 107 insertions(+), 107 deletions(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index ed324f5..fdb5ecb 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -957,64 +957,6 @@ menuconfig CGROUPS
>
...
> +config CGROUP_PERF
> +	bool "Perf controller"
> +	depends on PERF_EVENTS && CGROUPS

While you are at it, remove "&& CGROUPS" ?

> +	help
> +	  This option extends the perf per-cpu mode to restrict monitoring
> +	  to threads which belong to the cgroup specified and run on the
> +	  designated cpu.
> +
> +	  Say N if unsure.
> +
> +config CGROUP_DEBUG
> +	bool "Example controller"
>   	default n
> -	---help---
> -	Enable some debugging help. Currently it exports additional stat
> -	files in a cgroup which can be useful for debugging.
> +	help
> +	  This option enables a simple controller that exports
> +	  debugging information about the cgroups framework.
>
> -config CGROUP_WRITEBACK
> -	bool
> -	depends on MEMCG && BLK_CGROUP
> -	default y
> +	  Say N.
>
>   endif # CGROUPS
>
>

  reply	other threads:[~2015-12-18  2:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-17 22:19 [PAtCh 0/2] cgroup: prepare kernel config for cgroup2 Johannes Weiner
2015-12-17 22:19 ` Johannes Weiner
2015-12-17 22:19 ` [PATCH 1/2] cgroup: clean up the kernel configuration menu nomenclature Johannes Weiner
2015-12-18  2:23   ` Zefan Li
2015-12-18  2:23     ` Zefan Li
2015-12-18 16:19     ` Johannes Weiner
2015-12-18 16:19       ` Johannes Weiner
2015-12-18 17:39     ` Tejun Heo
2015-12-18 17:39       ` Tejun Heo
2015-12-17 22:19 ` [PATCH 2/2] cgroup: put controller Kconfig options in meaningful order Johannes Weiner
2015-12-18  2:26   ` Zefan Li [this message]
2015-12-18  2:26     ` Zefan Li
2015-12-18 17:45   ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56736EBD.8060302@huawei.com \
    --to=lizefan@huawei.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.