All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Geliang Tang <geliangtang@163.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tejun Heo <tj@kernel.org>, Jens Axboe <axboe@fb.com>,
	Michal Hocko <mhocko@suse.com>,
	Vladimir Davydov <vdavydov@virtuozzo.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/readahead.c, mm/vmscan.c: use lru_to_page instead of list_to_page
Date: Fri, 18 Dec 2015 18:25:40 +0100	[thread overview]
Message-ID: <56744194.80809@suse.cz> (raw)
In-Reply-To: <35cab720b3e69d47f03c9ce36d680db336bb5683.1449585319.git.geliangtang@163.com>

On 12/08/2015 03:40 PM, Geliang Tang wrote:
> list_to_page() in readahead.c is the same as lru_to_page() in vmscan.c.
> So I move lru_to_page to internal.h and drop list_to_page().

Looks like this would topically fit better to include/linux/mm_inline.h

Vlastimil


WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Geliang Tang <geliangtang@163.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tejun Heo <tj@kernel.org>, Jens Axboe <axboe@fb.com>,
	Michal Hocko <mhocko@suse.com>,
	Vladimir Davydov <vdavydov@virtuozzo.com>,
	Johannes Weiner <hannes@cmpxchg.org>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/readahead.c, mm/vmscan.c: use lru_to_page instead of list_to_page
Date: Fri, 18 Dec 2015 18:25:40 +0100	[thread overview]
Message-ID: <56744194.80809@suse.cz> (raw)
In-Reply-To: <35cab720b3e69d47f03c9ce36d680db336bb5683.1449585319.git.geliangtang@163.com>

On 12/08/2015 03:40 PM, Geliang Tang wrote:
> list_to_page() in readahead.c is the same as lru_to_page() in vmscan.c.
> So I move lru_to_page to internal.h and drop list_to_page().

Looks like this would topically fit better to include/linux/mm_inline.h

Vlastimil

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2015-12-18 17:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08 14:40 [PATCH] mm/readahead.c, mm/vmscan.c: use lru_to_page instead of list_to_page Geliang Tang
2015-12-18 17:25 ` Vlastimil Babka [this message]
2015-12-18 17:25   ` Vlastimil Babka
2015-12-19  9:08   ` [PATCH] mm: move lru_to_page to mm_inline.h Geliang Tang
2015-12-19  9:08     ` Geliang Tang
2015-12-21 10:14     ` Vlastimil Babka
2015-12-21 10:14       ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56744194.80809@suse.cz \
    --to=vbabka@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@fb.com \
    --cc=geliangtang@163.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=tj@kernel.org \
    --cc=vdavydov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.