* [Buildroot] [PATCH v2 1/5] package/nodejs: bump version to 5.3.0
@ 2015-12-17 23:20 Martin Bark
2015-12-17 23:20 ` [Buildroot] [PATCH v2 2/5] package/nodejs: removed version 0.12.9 Martin Bark
` (5 more replies)
0 siblings, 6 replies; 13+ messages in thread
From: Martin Bark @ 2015-12-17 23:20 UTC (permalink / raw)
To: buildroot
Replace 4.2.3 with 5.3.0. 5.3.0 is the current Stable release. See
https://nodejs.org/en/blog/release/v5.3.0 for details on the release.
Copied 4.2.3 patched to 5.3.0 with the following exceptions:
- Removed 0004-fix-arm-vfpv2.patch, committed upstream and included in
5.3.0. See https://github.com/nodejs/node/commit/84dea1bd0c
- Added 0004-Fix-va_list-not-declared.patch, fix for a new bug. This
has already been fixed upstream but is not in 5.3.0
Signed-off-by: Martin Bark <martin@barkynet.com>
---
Changes v1 -> v2
- Updated patch set from 5.2.0 to 5.3.0
---
Config.in.legacy | 9 +++++
package/nodejs/4.2.3/0004-fix-arm-vfpv2.patch | 46 ----------------------
...01-Remove-dependency-on-Python-bz2-module.patch | 0
.../0002-gyp-force-link-command-to-use-CXX.patch | 0
...hon-variable-instead-of-hardcoding-Python.patch | 0
.../5.3.0/0004-Fix-va_list-not-declared.patch | 39 ++++++++++++++++++
package/nodejs/Config.in | 12 +++---
package/nodejs/nodejs.hash | 4 +-
package/nodejs/nodejs.mk | 2 +-
9 files changed, 58 insertions(+), 54 deletions(-)
delete mode 100644 package/nodejs/4.2.3/0004-fix-arm-vfpv2.patch
rename package/nodejs/{4.2.3 => 5.3.0}/0001-Remove-dependency-on-Python-bz2-module.patch (100%)
rename package/nodejs/{4.2.3 => 5.3.0}/0002-gyp-force-link-command-to-use-CXX.patch (100%)
rename package/nodejs/{4.2.3 => 5.3.0}/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch (100%)
create mode 100644 package/nodejs/5.3.0/0004-Fix-va_list-not-declared.patch
diff --git a/Config.in.legacy b/Config.in.legacy
index e1ea06f..ee67720 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -186,6 +186,15 @@ config BR2_PACKAGE_INFOZIP
to avoid ambiguities with Info-Zip's UnZip which has been added
in the unzip package.
+config BR2_BR2_PACKAGE_NODEJS_4_X
+ bool "nodejs version 4.x has been removed"
+ select BR2_LEGACY
+ select BR2_PACKAGE_NODEJS
+ help
+ nodejs version 4.x has been removed. As an alternative,
+ the latest nodejs version has been automatically selected in
+ your configuration.
+
###############################################################################
comment "Legacy options removed in 2015.11"
diff --git a/package/nodejs/4.2.3/0004-fix-arm-vfpv2.patch b/package/nodejs/4.2.3/0004-fix-arm-vfpv2.patch
deleted file mode 100644
index 7ff280b..0000000
--- a/package/nodejs/4.2.3/0004-fix-arm-vfpv2.patch
+++ /dev/null
@@ -1,46 +0,0 @@
-From 0b07d813adcfdc13ef6a0c56f88b864eb3dc4be9 Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?J=C3=B6rg=20Krause?= <joerg.krause@embedded.rocks>
-Date: Tue, 8 Dec 2015 21:53:06 +0100
-Subject: [PATCH] configure: fix arm vfpv2
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-The gcc -mfpu flag for VFPv2 is 'vfp', not 'vfpv2' [1].
-
-Patch status: Sent upstream [2]
-
-[1] https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
-[2] https://github.com/nodejs/node/pull/4202
-
-Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
-[J?rg Krause: adapt to version 4.2.3]
-Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
----
- configure | 4 ++--
- 1 file changed, 2 insertions(+), 2 deletions(-)
-
-diff --git a/configure b/configure
-index d4aff36..c783bab 100755
---- a/configure
-+++ b/configure
-@@ -30,7 +30,7 @@ valid_os = ('win', 'mac', 'solaris', 'freebsd', 'openbsd', 'linux',
- valid_arch = ('arm', 'arm64', 'ia32', 'mips', 'mipsel', 'ppc', 'ppc64', 'x32',
- 'x64', 'x86')
- valid_arm_float_abi = ('soft', 'softfp', 'hard')
--valid_arm_fpu = ('vfp', 'vfpv2', 'vfpv3', 'vfpv3-d16', 'neon')
-+valid_arm_fpu = ('vfp', 'vfpv3', 'vfpv3-d16', 'neon')
- valid_mips_arch = ('loongson', 'r1', 'r2', 'r6', 'rx')
- valid_mips_fpu = ('fp32', 'fp64', 'fpxx')
- valid_mips_float_abi = ('soft', 'hard')
-@@ -622,7 +622,7 @@ def configure_arm(o):
- else:
- arm_float_abi = 'default'
-
-- arm_fpu = 'vfpv2'
-+ arm_fpu = 'vfp'
-
- if is_arch_armv7():
- arm_fpu = 'vfpv3'
---
-2.6.3
diff --git a/package/nodejs/4.2.3/0001-Remove-dependency-on-Python-bz2-module.patch b/package/nodejs/5.3.0/0001-Remove-dependency-on-Python-bz2-module.patch
similarity index 100%
rename from package/nodejs/4.2.3/0001-Remove-dependency-on-Python-bz2-module.patch
rename to package/nodejs/5.3.0/0001-Remove-dependency-on-Python-bz2-module.patch
diff --git a/package/nodejs/4.2.3/0002-gyp-force-link-command-to-use-CXX.patch b/package/nodejs/5.3.0/0002-gyp-force-link-command-to-use-CXX.patch
similarity index 100%
rename from package/nodejs/4.2.3/0002-gyp-force-link-command-to-use-CXX.patch
rename to package/nodejs/5.3.0/0002-gyp-force-link-command-to-use-CXX.patch
diff --git a/package/nodejs/4.2.3/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch b/package/nodejs/5.3.0/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
similarity index 100%
rename from package/nodejs/4.2.3/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
rename to package/nodejs/5.3.0/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
diff --git a/package/nodejs/5.3.0/0004-Fix-va_list-not-declared.patch b/package/nodejs/5.3.0/0004-Fix-va_list-not-declared.patch
new file mode 100644
index 0000000..aec8e12
--- /dev/null
+++ b/package/nodejs/5.3.0/0004-Fix-va_list-not-declared.patch
@@ -0,0 +1,39 @@
+From 5b3dd2599ebde1846750aaf7c79576ad45246ffa Mon Sep 17 00:00:00 2001
+From: Martin Bark <martin@barkynet.com>
+Date: Tue, 8 Dec 2015 11:41:08 +0000
+Subject: [PATCH] Fix va_list not declared
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+When compiling with uClibc-ng the following error is seen.
+
+In file included from ../deps/v8/src/log-utils.cc:5:0:
+../deps/v8/src/log-utils.h:64:39: error: ?va_list? has not been declared
+ void AppendVA(const char* format, va_list args);
+
+This patch fixes the issue by adding the missing #include <cstdarg>. Note
+that this fix has already be included upstream, see
+https://github.com/nodejs/node/blob/8a43a3d/deps/v8/src/log-utils.h
+
+Signed-off-by: Martin Bark <martin@barkynet.com>
+---
+ deps/v8/src/log-utils.h | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/deps/v8/src/log-utils.h b/deps/v8/src/log-utils.h
+index 87dab52..6714307 100644
+--- a/deps/v8/src/log-utils.h
++++ b/deps/v8/src/log-utils.h
+@@ -5,6 +5,8 @@
+ #ifndef V8_LOG_UTILS_H_
+ #define V8_LOG_UTILS_H_
+
++#include <cstdarg>
++
+ #include "src/allocation.h"
+ #include "src/base/platform/mutex.h"
+ #include "src/flags.h"
+--
+2.5.0
+
diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
index b0f4f2b..769710c 100644
--- a/package/nodejs/Config.in
+++ b/package/nodejs/Config.in
@@ -37,7 +37,7 @@ config BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
choice
prompt "Node.js version"
default BR2_BR2_PACKAGE_NODEJS_0_10_X if BR2_ARM_CPU_ARMV5
- default BR2_BR2_PACKAGE_NODEJS_4_X
+ default BR2_PACKAGE_NODEJS_5_X
help
Select the version of Node.js you wish to use.
@@ -48,14 +48,16 @@ config BR2_BR2_PACKAGE_NODEJS_0_12_X
bool "v0.12.9"
depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
-config BR2_BR2_PACKAGE_NODEJS_4_X
- bool "v4.2.3"
+config BR2_PACKAGE_NODEJS_5_X
+ bool "v5.3.0"
depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+ depends on BR2_USE_WCHAR
-comment "v4.2.3 needs a toolchain w/ gcc >= 4.8"
+comment "v5.3.0 needs a toolchain w/ gcc >= 4.8, wchar"
depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
+ depends on !BR2_USE_WCHAR
endchoice
@@ -63,7 +65,7 @@ config BR2_PACKAGE_NODEJS_VERSION_STRING
string
default "0.10.41" if BR2_BR2_PACKAGE_NODEJS_0_10_X
default "0.12.9" if BR2_BR2_PACKAGE_NODEJS_0_12_X
- default "4.2.3" if BR2_BR2_PACKAGE_NODEJS_4_X
+ default "5.3.0" if BR2_PACKAGE_NODEJS_5_X
menu "Module Selection"
diff --git a/package/nodejs/nodejs.hash b/package/nodejs/nodejs.hash
index 7d58a54..c3bdc44 100644
--- a/package/nodejs/nodejs.hash
+++ b/package/nodejs/nodejs.hash
@@ -4,5 +4,5 @@ sha256 79f694e2a5c42543b75d0c69f6860499d7593136d0f6b59e7163b9e66fb2c995 node-v0
# From upstream URL: http://nodejs.org/dist/v0.12.9/SHASUMS256.txt
sha256 35daad301191e5f8dd7e5d2fbb711d081b82d1837d59837b8ee224c256cfe5e4 node-v0.12.9.tar.gz
-# From upstream URL: http://nodejs.org/dist/v4.2.3/SHASUMS256.txt
-sha256 9e8aef1e47b317575c421c8d10a80e6c319b26969b566d3b84e49e65a92837f4 node-v4.2.3.tar.xz
+# From upstream URL: http://nodejs.org/dist/v5.3.0/SHASUMS256.txt
+sha256 e5115ee78c31ac3af0f2b3553aa84fff2f49ae59bd6e01e11d78ce86c544569e node-v5.3.0.tar.xz
diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index 7ede89d..af47b26 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -5,7 +5,7 @@
################################################################################
NODEJS_VERSION = $(call qstrip,$(BR2_PACKAGE_NODEJS_VERSION_STRING))
-ifeq ($(BR2_BR2_PACKAGE_NODEJS_4_X),y)
+ifeq ($(BR2_PACKAGE_NODEJS_5_X),y)
NODEJS_SOURCE = node-v$(NODEJS_VERSION).tar.xz
else
NODEJS_SOURCE = node-v$(NODEJS_VERSION).tar.gz
--
2.5.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 2/5] package/nodejs: removed version 0.12.9
2015-12-17 23:20 [Buildroot] [PATCH v2 1/5] package/nodejs: bump version to 5.3.0 Martin Bark
@ 2015-12-17 23:20 ` Martin Bark
2015-12-17 23:20 ` [Buildroot] [PATCH v2 3/5] package/nodejs: correct 0.10.x option name Martin Bark
` (4 subsequent siblings)
5 siblings, 0 replies; 13+ messages in thread
From: Martin Bark @ 2015-12-17 23:20 UTC (permalink / raw)
To: buildroot
Remove 0.12.9 to rationalise the number of nodejs releases supported by
buildroot. Going forward buildroot will only support the latest release
of nodejs and the 0.10.x branch for armv5 support.
Signed-off-by: Martin Bark <martin@barkynet.com>
---
Changes v1 -> v2
- New in v2
---
Config.in.legacy | 9 ++++
...01-Remove-dependency-on-Python-bz2-module.patch | 39 --------------
.../0002-gyp-force-link-command-to-use-CXX.patch | 27 ----------
...hon-variable-instead-of-hardcoding-Python.patch | 63 ----------------------
...c-fix-build-error-without-OpenSSL-support.patch | 44 ---------------
...or-arm-predefined-macro-in-atomicops_inte.patch | 30 -----------
package/nodejs/Config.in | 5 --
package/nodejs/nodejs.hash | 3 --
8 files changed, 9 insertions(+), 211 deletions(-)
delete mode 100644 package/nodejs/0.12.9/0001-Remove-dependency-on-Python-bz2-module.patch
delete mode 100644 package/nodejs/0.12.9/0002-gyp-force-link-command-to-use-CXX.patch
delete mode 100644 package/nodejs/0.12.9/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
delete mode 100644 package/nodejs/0.12.9/0004-src-fix-build-error-without-OpenSSL-support.patch
delete mode 100644 package/nodejs/0.12.9/0005-Fix-typo-for-arm-predefined-macro-in-atomicops_inte.patch
diff --git a/Config.in.legacy b/Config.in.legacy
index ee67720..db1eeae 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -186,6 +186,15 @@ config BR2_PACKAGE_INFOZIP
to avoid ambiguities with Info-Zip's UnZip which has been added
in the unzip package.
+config BR2_BR2_PACKAGE_NODEJS_0_12_X
+ bool "nodejs version 0.12.x has been removed"
+ select BR2_LEGACY
+ select BR2_PACKAGE_NODEJS
+ help
+ nodejs version 0.12.x has been removed. As an alternative,
+ the latest nodejs version has been automatically selected in
+ your configuration.
+
config BR2_BR2_PACKAGE_NODEJS_4_X
bool "nodejs version 4.x has been removed"
select BR2_LEGACY
diff --git a/package/nodejs/0.12.9/0001-Remove-dependency-on-Python-bz2-module.patch b/package/nodejs/0.12.9/0001-Remove-dependency-on-Python-bz2-module.patch
deleted file mode 100644
index 24a78a4..0000000
--- a/package/nodejs/0.12.9/0001-Remove-dependency-on-Python-bz2-module.patch
+++ /dev/null
@@ -1,39 +0,0 @@
-From 3d4817c152d6f3afddcc699949c4d1664da91e2b Mon Sep 17 00:00:00 2001
-From: Martin Bark <martin@barkynet.com>
-Date: Tue, 30 Jun 2015 09:43:11 +0100
-Subject: [PATCH 1/4] Remove dependency on Python bz2 module
-
-The Python bz2 module is only needed in certain cases, so only import
-it when needed. In the normal nodejs build, this allows to remove the
-dependency on this module.
-
-Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-[Martin: adapt to 0.12.5]
-Signed-off-by: Martin Bark <martin@barkynet.com>
----
- deps/v8/tools/js2c.py | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/deps/v8/tools/js2c.py b/deps/v8/tools/js2c.py
-index 77485f6..371caf5 100755
---- a/deps/v8/tools/js2c.py
-+++ b/deps/v8/tools/js2c.py
-@@ -34,7 +34,6 @@
- import os, re, sys, string
- import optparse
- import jsmin
--import bz2
- import textwrap
-
-
-@@ -492,6 +491,7 @@ def CompressMaybe(sources, compression_type):
- if compression_type == "off":
- return sources_bytes
- elif compression_type == "bz2":
-+ import bz2
- return bz2.compress(sources_bytes)
- else:
- raise Error("Unknown compression type %s." % compression_type)
---
-2.1.4
-
diff --git a/package/nodejs/0.12.9/0002-gyp-force-link-command-to-use-CXX.patch b/package/nodejs/0.12.9/0002-gyp-force-link-command-to-use-CXX.patch
deleted file mode 100644
index 3b007f1..0000000
--- a/package/nodejs/0.12.9/0002-gyp-force-link-command-to-use-CXX.patch
+++ /dev/null
@@ -1,27 +0,0 @@
-From 90a3c113c19ec615249ab880c45c6c0a8d369098 Mon Sep 17 00:00:00 2001
-From: Martin Bark <martin@barkynet.com>
-Date: Tue, 30 Jun 2015 09:43:47 +0100
-Subject: [PATCH 2/4] gyp: force link command to use CXX
-
-Signed-off-by: Samuel Martin <s.martin49@gmail.com>
-Signed-off-by: Martin Bark <martin@barkynet.com>
----
- tools/gyp/pylib/gyp/generator/make.py | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/tools/gyp/pylib/gyp/generator/make.py b/tools/gyp/pylib/gyp/generator/make.py
-index b88a433..0a1f2e0 100644
---- a/tools/gyp/pylib/gyp/generator/make.py
-+++ b/tools/gyp/pylib/gyp/generator/make.py
-@@ -141,7 +141,7 @@ cmd_alink_thin = rm -f $@ && $(AR.$(TOOLSET)) crsT $@ $(filter %.o,$^)
- # special "figure out circular dependencies" flags around the entire
- # input list during linking.
- quiet_cmd_link = LINK($(TOOLSET)) $@
--cmd_link = $(LINK.$(TOOLSET)) $(GYP_LDFLAGS) $(LDFLAGS.$(TOOLSET)) -o $@ -Wl,--start-group $(LD_INPUTS) -Wl,--end-group $(LIBS)
-+cmd_link = $(CXX.$(TOOLSET)) $(GYP_LDFLAGS) $(LDFLAGS.$(TOOLSET)) -o $@ -Wl,--start-group $(LD_INPUTS) -Wl,--end-group $(LIBS)
-
- # We support two kinds of shared objects (.so):
- # 1) shared_library, which is just bundling together many dependent libraries
---
-2.1.4
-
diff --git a/package/nodejs/0.12.9/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch b/package/nodejs/0.12.9/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
deleted file mode 100644
index 37ceda3..0000000
--- a/package/nodejs/0.12.9/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
+++ /dev/null
@@ -1,63 +0,0 @@
-From 4a48c65921b0f05b621aef5b902b6aa54811ad7a Mon Sep 17 00:00:00 2001
-From: Martin Bark <martin@barkynet.com>
-Date: Tue, 30 Jun 2015 09:44:33 +0100
-Subject: [PATCH 3/4] Use a python variable instead of hardcoding Python
-
-The nodejs build system uses python in a number of locations. However,
-there are some locations where it hardcodes 'python' as the Python
-interpreter. However, this causes problems when we need to use python2
-instead of just python.
-
-This patch fixes that by using the python variable already in place in
-the nodejs build system.
-
-Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
-[Martin: adapt to 0.12.5]
-Signed-off-by: Martin Bark <martin@barkynet.com>
----
- deps/v8/tools/gyp/v8.gyp | 8 ++++----
- 1 file changed, 4 insertions(+), 4 deletions(-)
-
-diff --git a/deps/v8/tools/gyp/v8.gyp b/deps/v8/tools/gyp/v8.gyp
-index c703155..06c0b2b 100644
---- a/deps/v8/tools/gyp/v8.gyp
-+++ b/deps/v8/tools/gyp/v8.gyp
-@@ -1353,7 +1353,7 @@
- 'outputs': [
- '<(PRODUCT_DIR)/natives_blob.bin',
- ],
-- 'action': ['python', '<@(_inputs)', '<@(_outputs)'],
-+ 'action': ['<(python)', '<@(_inputs)', '<@(_outputs)'],
- }],
- }],
- ['want_separate_host_toolset==1', {
-@@ -1435,7 +1435,7 @@
- '<(SHARED_INTERMEDIATE_DIR)/libraries.cc',
- ],
- 'action': [
-- 'python',
-+ '<(python)',
- '../../tools/js2c.py',
- '<(SHARED_INTERMEDIATE_DIR)/libraries.cc',
- 'CORE',
-@@ -1462,7 +1462,7 @@
- '<(SHARED_INTERMEDIATE_DIR)/experimental-libraries.cc',
- ],
- 'action': [
-- 'python',
-+ '<(python)',
- '../../tools/js2c.py',
- '<(SHARED_INTERMEDIATE_DIR)/experimental-libraries.cc',
- 'EXPERIMENTAL',
-@@ -1500,7 +1500,7 @@
- '<(SHARED_INTERMEDIATE_DIR)/debug-support.cc',
- ],
- 'action': [
-- 'python',
-+ '<(python)',
- '../../tools/gen-postmortem-metadata.py',
- '<@(_outputs)',
- '<@(heapobject_files)'
---
-2.1.4
-
diff --git a/package/nodejs/0.12.9/0004-src-fix-build-error-without-OpenSSL-support.patch b/package/nodejs/0.12.9/0004-src-fix-build-error-without-OpenSSL-support.patch
deleted file mode 100644
index 62966eb..0000000
--- a/package/nodejs/0.12.9/0004-src-fix-build-error-without-OpenSSL-support.patch
+++ /dev/null
@@ -1,44 +0,0 @@
-From ba6142dbaebe06738686da150043abbd1ef1fbf5 Mon Sep 17 00:00:00 2001
-From: =?UTF-8?q?J=C3=B6rg=20Krause?= <joerg.krause@embedded.rocks>
-Date: Tue, 8 Dec 2015 21:22:45 +0100
-Subject: [PATCH] src: fix build error without OpenSSL support
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-PR #3890 [1] introduced the variable ALLOW_INSECURE_SERVER_DHPARAM defined
-in src/node_crypto.cc. However, if nodejs is built without OpenSSL support,
-the build fails:
- error: ?ALLOW_INSECURE_SERVER_DHPARAM? was not declared in this scope
- ALLOW_INSECURE_SERVER_DHPARAM = true;
-
-Fix this by using the preprocessor macro HAVE_OPENSSL to opt-out the use of
-ALLOW_INSECURE_SERVER_DHPARAM in non-OpenSSL builds.
-
-Patch status: Sent upstream [2]
-
-[1] https://github.com/nodejs/node/pull/3890
-[2] https://github.com/nodejs/node/pull/4201
-
-Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
----
- src/node.cc | 2 ++
- 1 file changed, 2 insertions(+)
-
-diff --git a/src/node.cc b/src/node.cc
-index 1da8328..e5239ac 100644
---- a/src/node.cc
-+++ b/src/node.cc
-@@ -3042,7 +3042,9 @@ static void ParseArgs(int* argc,
- SSL3_ENABLE = true;
- #endif
- } else if (strcmp(arg, "--allow-insecure-server-dhparam") == 0) {
-+#if HAVE_OPENSSL
- ALLOW_INSECURE_SERVER_DHPARAM = true;
-+#endif
- } else if (strcmp(arg, "--help") == 0 || strcmp(arg, "-h") == 0) {
- PrintHelp();
- exit(0);
---
-2.6.3
-
diff --git a/package/nodejs/0.12.9/0005-Fix-typo-for-arm-predefined-macro-in-atomicops_inte.patch b/package/nodejs/0.12.9/0005-Fix-typo-for-arm-predefined-macro-in-atomicops_inte.patch
deleted file mode 100644
index 94d9eff..0000000
--- a/package/nodejs/0.12.9/0005-Fix-typo-for-arm-predefined-macro-in-atomicops_inte.patch
+++ /dev/null
@@ -1,30 +0,0 @@
-From b7b69cdcdb4e2d80a85e303cc3230666d565bc39 Mon Sep 17 00:00:00 2001
-From: Peter Seiderer <ps.report@gmx.net>
-Date: Sun, 11 Oct 2015 09:14:52 +0200
-Subject: [PATCH] Fix typo for arm predefined macro in
- atomicops_internals_arm_gcc.h
-
-Fix typo __ARM_ARCH_6KZ__ vs. __ARM_ARCH_6ZK__, fixes
-compile for raspberry pi.
-
-Signed-off-by: Peter Seiderer <ps.report@gmx.net>
----
- deps/v8/src/base/atomicops_internals_arm_gcc.h | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/deps/v8/src/base/atomicops_internals_arm_gcc.h b/deps/v8/src/base/atomicops_internals_arm_gcc.h
-index 069b1ff..b924981 100644
---- a/deps/v8/src/base/atomicops_internals_arm_gcc.h
-+++ b/deps/v8/src/base/atomicops_internals_arm_gcc.h
-@@ -63,7 +63,7 @@ inline void MemoryBarrier() {
- defined(__ARM_ARCH_7R__) || defined(__ARM_ARCH_7M__) || \
- defined(__ARM_ARCH_6__) || defined(__ARM_ARCH_6J__) || \
- defined(__ARM_ARCH_6K__) || defined(__ARM_ARCH_6Z__) || \
-- defined(__ARM_ARCH_6KZ__) || defined(__ARM_ARCH_6T2__)
-+ defined(__ARM_ARCH_6ZK__) || defined(__ARM_ARCH_6T2__)
-
- inline Atomic32 NoBarrier_CompareAndSwap(volatile Atomic32* ptr,
- Atomic32 old_value,
---
-2.1.4
-
diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
index 769710c..cba320c 100644
--- a/package/nodejs/Config.in
+++ b/package/nodejs/Config.in
@@ -44,10 +44,6 @@ choice
config BR2_BR2_PACKAGE_NODEJS_0_10_X
bool "v0.10.41"
-config BR2_BR2_PACKAGE_NODEJS_0_12_X
- bool "v0.12.9"
- depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
-
config BR2_PACKAGE_NODEJS_5_X
bool "v5.3.0"
depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
@@ -64,7 +60,6 @@ endchoice
config BR2_PACKAGE_NODEJS_VERSION_STRING
string
default "0.10.41" if BR2_BR2_PACKAGE_NODEJS_0_10_X
- default "0.12.9" if BR2_BR2_PACKAGE_NODEJS_0_12_X
default "5.3.0" if BR2_PACKAGE_NODEJS_5_X
menu "Module Selection"
diff --git a/package/nodejs/nodejs.hash b/package/nodejs/nodejs.hash
index c3bdc44..dc56efa 100644
--- a/package/nodejs/nodejs.hash
+++ b/package/nodejs/nodejs.hash
@@ -1,8 +1,5 @@
# From upstream URL: http://nodejs.org/dist/v0.10.41/SHASUMS256.txt
sha256 79f694e2a5c42543b75d0c69f6860499d7593136d0f6b59e7163b9e66fb2c995 node-v0.10.41.tar.gz
-# From upstream URL: http://nodejs.org/dist/v0.12.9/SHASUMS256.txt
-sha256 35daad301191e5f8dd7e5d2fbb711d081b82d1837d59837b8ee224c256cfe5e4 node-v0.12.9.tar.gz
-
# From upstream URL: http://nodejs.org/dist/v5.3.0/SHASUMS256.txt
sha256 e5115ee78c31ac3af0f2b3553aa84fff2f49ae59bd6e01e11d78ce86c544569e node-v5.3.0.tar.xz
--
2.5.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 3/5] package/nodejs: correct 0.10.x option name
2015-12-17 23:20 [Buildroot] [PATCH v2 1/5] package/nodejs: bump version to 5.3.0 Martin Bark
2015-12-17 23:20 ` [Buildroot] [PATCH v2 2/5] package/nodejs: removed version 0.12.9 Martin Bark
@ 2015-12-17 23:20 ` Martin Bark
2015-12-18 21:12 ` Yann E. MORIN
2015-12-17 23:20 ` [Buildroot] [PATCH v2 4/5] package/nodejs: fix support for uClibc-ng Martin Bark
` (3 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Martin Bark @ 2015-12-17 23:20 UTC (permalink / raw)
To: buildroot
The nodejs options incorrectly started BR2_BR2_xxx. This change corrects
the name for 0.10.x releases to BR2_PACKAGE_NODEJS_0_10_X
Signed-off-by: Martin Bark <martin@barkynet.com>
---
Changes v1 -> v2
- New in v2
---
Config.in.legacy | 8 ++++++++
package/nodejs/Config.in | 6 +++---
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/Config.in.legacy b/Config.in.legacy
index db1eeae..5d9a3ee 100644
--- a/Config.in.legacy
+++ b/Config.in.legacy
@@ -186,6 +186,14 @@ config BR2_PACKAGE_INFOZIP
to avoid ambiguities with Info-Zip's UnZip which has been added
in the unzip package.
+config BR2_BR2_PACKAGE_NODEJS_0_10_X
+ bool "nodejs 0.10.x option renamed"
+ select BR2_LEGACY
+ select BR2_PACKAGE_NODEJS_0_10_X
+ help
+ nodejs 0.10.x option was named incorrectly and been renamed
+ to BR2_PACKAGE_NODEJS_0_10_X.
+
config BR2_BR2_PACKAGE_NODEJS_0_12_X
bool "nodejs version 0.12.x has been removed"
select BR2_LEGACY
diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
index cba320c..5d776d7 100644
--- a/package/nodejs/Config.in
+++ b/package/nodejs/Config.in
@@ -36,12 +36,12 @@ config BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
choice
prompt "Node.js version"
- default BR2_BR2_PACKAGE_NODEJS_0_10_X if BR2_ARM_CPU_ARMV5
+ default BR2_PACKAGE_NODEJS_0_10_X if BR2_ARM_CPU_ARMV5
default BR2_PACKAGE_NODEJS_5_X
help
Select the version of Node.js you wish to use.
-config BR2_BR2_PACKAGE_NODEJS_0_10_X
+config BR2_PACKAGE_NODEJS_0_10_X
bool "v0.10.41"
config BR2_PACKAGE_NODEJS_5_X
@@ -59,7 +59,7 @@ endchoice
config BR2_PACKAGE_NODEJS_VERSION_STRING
string
- default "0.10.41" if BR2_BR2_PACKAGE_NODEJS_0_10_X
+ default "0.10.41" if BR2_PACKAGE_NODEJS_0_10_X
default "5.3.0" if BR2_PACKAGE_NODEJS_5_X
menu "Module Selection"
--
2.5.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 4/5] package/nodejs: fix support for uClibc-ng
2015-12-17 23:20 [Buildroot] [PATCH v2 1/5] package/nodejs: bump version to 5.3.0 Martin Bark
2015-12-17 23:20 ` [Buildroot] [PATCH v2 2/5] package/nodejs: removed version 0.12.9 Martin Bark
2015-12-17 23:20 ` [Buildroot] [PATCH v2 3/5] package/nodejs: correct 0.10.x option name Martin Bark
@ 2015-12-17 23:20 ` Martin Bark
2015-12-18 21:15 ` Yann E. MORIN
2015-12-17 23:20 ` [Buildroot] [PATCH v2 5/5] package/libuv: " Martin Bark
` (2 subsequent siblings)
5 siblings, 1 reply; 13+ messages in thread
From: Martin Bark @ 2015-12-17 23:20 UTC (permalink / raw)
To: buildroot
Fix segmentation fault in node.js when using uClibc-ng.
This patch fixes bug #8296, see
https://bugs.busybox.net/show_bug.cgi?id=8296.
Signed-off-by: Martin Bark <martin@barkynet.com>
---
Changes v1 -> v2
- Updated for node 5.3.0. removed patches for 0.12.9 and 4.2.3
---
.../0005-Fix-crash-in-GetInterfaceAddresses.patch | 37 ++++++++++++++++++++++
.../5.3.0/0006-Fix-support-for-uClibc-ng.patch | 32 +++++++++++++++++++
2 files changed, 69 insertions(+)
create mode 100644 package/nodejs/5.3.0/0005-Fix-crash-in-GetInterfaceAddresses.patch
create mode 100644 package/nodejs/5.3.0/0006-Fix-support-for-uClibc-ng.patch
diff --git a/package/nodejs/5.3.0/0005-Fix-crash-in-GetInterfaceAddresses.patch b/package/nodejs/5.3.0/0005-Fix-crash-in-GetInterfaceAddresses.patch
new file mode 100644
index 0000000..d964290
--- /dev/null
+++ b/package/nodejs/5.3.0/0005-Fix-crash-in-GetInterfaceAddresses.patch
@@ -0,0 +1,37 @@
+From 839bd9d147b2c85fe70196c86dbdbed504762caf Mon Sep 17 00:00:00 2001
+From: "Bark, Martin" <martin.bark@te.com>
+Date: Mon, 14 Dec 2015 13:27:51 +0000
+Subject: [PATCH 1/2] Fix crash in GetInterfaceAddresses
+
+If uv_interface_addresses() returns UV_ENOSYS then interfaces and count are
+uninitialised. This can cause a segmentation fault inside
+GetInterfaceAddresses when it tries to use the invalid interfaces[]. Fix
+the issue by returning from GetInterfaceAddresses on the UV_ENOSYS error.
+
+This issue was observed when using uCLibc-ng version 1.0.9 because
+uv_interface_addresses() in deps/uv/src/unix/linux-core.c incorrectly
+undefines HAVE_IFADDRS_H.
+
+Submitted upstream, see https://github.com/nodejs/node/pull/4272
+
+Signed-off-by: Martin Bark <martin@barkynet.com>
+---
+ src/node_os.cc | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/node_os.cc b/src/node_os.cc
+index a100090..92f53a9 100644
+--- a/src/node_os.cc
++++ b/src/node_os.cc
+@@ -200,7 +200,7 @@ static void GetInterfaceAddresses(const FunctionCallbackInfo<Value>& args) {
+ ret = Object::New(env->isolate());
+
+ if (err == UV_ENOSYS) {
+- args.GetReturnValue().Set(ret);
++ return args.GetReturnValue().Set(ret);
+ } else if (err) {
+ return env->ThrowUVException(err, "uv_interface_addresses");
+ }
+--
+2.6.2
+
diff --git a/package/nodejs/5.3.0/0006-Fix-support-for-uClibc-ng.patch b/package/nodejs/5.3.0/0006-Fix-support-for-uClibc-ng.patch
new file mode 100644
index 0000000..918a36a
--- /dev/null
+++ b/package/nodejs/5.3.0/0006-Fix-support-for-uClibc-ng.patch
@@ -0,0 +1,32 @@
+From 1cc08f6ceacbb0e5ba1f4638ca3a97ac002d7792 Mon Sep 17 00:00:00 2001
+From: "Bark, Martin" <martin.bark@te.com>
+Date: Mon, 14 Dec 2015 13:26:10 +0000
+Subject: [PATCH 2/2] Fix support for uClibc-ng
+
+uClibc-ng is currently at v1.0.9. The patch corrects the uClibc
+version test so that HAVE_IFADDRS_H is defined for uClibc versions
+after v0.9.32.
+
+Submitted upstream to libuv, see https://github.com/libuv/libuv/pull/653
+
+Signed-off-by: Bark, Martin <martin.bark@te.com>
+---
+ deps/uv/src/unix/linux-core.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/deps/uv/src/unix/linux-core.c b/deps/uv/src/unix/linux-core.c
+index e6e6828..6cbbb71 100644
+--- a/deps/uv/src/unix/linux-core.c
++++ b/deps/uv/src/unix/linux-core.c
+@@ -39,7 +39,7 @@
+ #define HAVE_IFADDRS_H 1
+
+ #ifdef __UCLIBC__
+-# if __UCLIBC_MAJOR__ < 0 || __UCLIBC_MINOR__ < 9 || __UCLIBC_SUBLEVEL__ < 32
++# if __UCLIBC_MAJOR__ < 0 && __UCLIBC_MINOR__ < 9 && __UCLIBC_SUBLEVEL__ < 32
+ # undef HAVE_IFADDRS_H
+ # endif
+ #endif
+--
+2.6.2
+
--
2.5.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 5/5] package/libuv: fix support for uClibc-ng
2015-12-17 23:20 [Buildroot] [PATCH v2 1/5] package/nodejs: bump version to 5.3.0 Martin Bark
` (2 preceding siblings ...)
2015-12-17 23:20 ` [Buildroot] [PATCH v2 4/5] package/nodejs: fix support for uClibc-ng Martin Bark
@ 2015-12-17 23:20 ` Martin Bark
2015-12-18 21:09 ` [Buildroot] [PATCH v2 1/5] package/nodejs: bump version to 5.3.0 Yann E. MORIN
2015-12-18 21:35 ` Yann E. MORIN
5 siblings, 0 replies; 13+ messages in thread
From: Martin Bark @ 2015-12-17 23:20 UTC (permalink / raw)
To: buildroot
See https://bugs.busybox.net/show_bug.cgi?id=8296 for further details on
the origins of this bug.
This patch has been submitted upstream. See
https://github.com/libuv/libuv/pull/653
Signed-off-by: Martin Bark <martin@barkynet.com>
---
Changes v1 -> v2
- Updated patch to be the same as in libuv/libuv/pull/653
- Reword commit message
---
.../0001-unix-fix-support-for-uClibc-ng.patch | 30 ++++++++++++++++++++++
1 file changed, 30 insertions(+)
create mode 100644 package/libuv/0001-unix-fix-support-for-uClibc-ng.patch
diff --git a/package/libuv/0001-unix-fix-support-for-uClibc-ng.patch b/package/libuv/0001-unix-fix-support-for-uClibc-ng.patch
new file mode 100644
index 0000000..6aec436
--- /dev/null
+++ b/package/libuv/0001-unix-fix-support-for-uClibc-ng.patch
@@ -0,0 +1,30 @@
+From 21dcb3a98feb3ae6ba862cfbf25fba3361bc8a9b Mon Sep 17 00:00:00 2001
+From: Martin Bark <martin@barkynet.com>
+Date: Mon, 14 Dec 2015 21:46:17 +0000
+Subject: [PATCH] unix: fix support for uClibc-ng
+
+uClibc-ng is currently at v1.0.9. The patch corrects the uClibc
+version test so that HAVE_IFADDRS_H is defined for uClibc versions
+after v0.9.32.
+
+Signed-off-by: Martin Bark <martin@barkynet.com>
+---
+ src/unix/linux-core.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/unix/linux-core.c b/src/unix/linux-core.c
+index 3ff6fb1..4735bc4 100644
+--- a/src/unix/linux-core.c
++++ b/src/unix/linux-core.c
+@@ -39,7 +39,7 @@
+ #define HAVE_IFADDRS_H 1
+
+ #ifdef __UCLIBC__
+-# if __UCLIBC_MAJOR__ < 0 || __UCLIBC_MINOR__ < 9 || __UCLIBC_SUBLEVEL__ < 32
++# if __UCLIBC_MAJOR__ < 0 && __UCLIBC_MINOR__ < 9 && __UCLIBC_SUBLEVEL__ < 32
+ # undef HAVE_IFADDRS_H
+ # endif
+ #endif
+--
+2.5.0
+
--
2.5.0
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 1/5] package/nodejs: bump version to 5.3.0
2015-12-17 23:20 [Buildroot] [PATCH v2 1/5] package/nodejs: bump version to 5.3.0 Martin Bark
` (3 preceding siblings ...)
2015-12-17 23:20 ` [Buildroot] [PATCH v2 5/5] package/libuv: " Martin Bark
@ 2015-12-18 21:09 ` Yann E. MORIN
2015-12-18 21:35 ` Yann E. MORIN
5 siblings, 0 replies; 13+ messages in thread
From: Yann E. MORIN @ 2015-12-18 21:09 UTC (permalink / raw)
To: buildroot
Martin, All,
On 2015-12-17 23:20 +0000, Martin Bark spake thusly:
> Replace 4.2.3 with 5.3.0. 5.3.0 is the current Stable release. See
> https://nodejs.org/en/blog/release/v5.3.0 for details on the release.
>
> Copied 4.2.3 patched to 5.3.0 with the following exceptions:
> - Removed 0004-fix-arm-vfpv2.patch, committed upstream and included in
> 5.3.0. See https://github.com/nodejs/node/commit/84dea1bd0c
> - Added 0004-Fix-va_list-not-declared.patch, fix for a new bug. This
> has already been fixed upstream but is not in 5.3.0
>
> Signed-off-by: Martin Bark <martin@barkynet.com>
[--SNIP--]
> diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
> index b0f4f2b..769710c 100644
> --- a/package/nodejs/Config.in
> +++ b/package/nodejs/Config.in
> @@ -48,14 +48,16 @@ config BR2_BR2_PACKAGE_NODEJS_0_12_X
> bool "v0.12.9"
> depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
>
> -config BR2_BR2_PACKAGE_NODEJS_4_X
> - bool "v4.2.3"
> +config BR2_PACKAGE_NODEJS_5_X
> + bool "v5.3.0"
> depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> + depends on BR2_USE_WCHAR
>
> -comment "v4.2.3 needs a toolchain w/ gcc >= 4.8"
> +comment "v5.3.0 needs a toolchain w/ gcc >= 4.8, wchar"
> depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
> depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> + depends on !BR2_USE_WCHAR
Wrong, this should be:
depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 || !BR2_USE_WCHAR
Otherwise OK for me...
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 3/5] package/nodejs: correct 0.10.x option name
2015-12-17 23:20 ` [Buildroot] [PATCH v2 3/5] package/nodejs: correct 0.10.x option name Martin Bark
@ 2015-12-18 21:12 ` Yann E. MORIN
2015-12-18 22:47 ` Arnout Vandecappelle
0 siblings, 1 reply; 13+ messages in thread
From: Yann E. MORIN @ 2015-12-18 21:12 UTC (permalink / raw)
To: buildroot
Martin, All,
On 2015-12-17 23:20 +0000, Martin Bark spake thusly:
> The nodejs options incorrectly started BR2_BR2_xxx. This change corrects
> the name for 0.10.x releases to BR2_PACKAGE_NODEJS_0_10_X
>
> Signed-off-by: Martin Bark <martin@barkynet.com>
>
> ---
> Changes v1 -> v2
> - New in v2
> ---
> Config.in.legacy | 8 ++++++++
> package/nodejs/Config.in | 6 +++---
> 2 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/Config.in.legacy b/Config.in.legacy
> index db1eeae..5d9a3ee 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -186,6 +186,14 @@ config BR2_PACKAGE_INFOZIP
> to avoid ambiguities with Info-Zip's UnZip which has been added
> in the unzip package.
>
> +config BR2_BR2_PACKAGE_NODEJS_0_10_X
> + bool "nodejs 0.10.x option renamed"
> + select BR2_LEGACY
> + select BR2_PACKAGE_NODEJS_0_10_X
No, you can't select an option that is in a choice. All you can do in
this case is tell the user to check his configuration, and refer him
to the version choice.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 4/5] package/nodejs: fix support for uClibc-ng
2015-12-17 23:20 ` [Buildroot] [PATCH v2 4/5] package/nodejs: fix support for uClibc-ng Martin Bark
@ 2015-12-18 21:15 ` Yann E. MORIN
2015-12-20 16:58 ` Martin Bark
0 siblings, 1 reply; 13+ messages in thread
From: Yann E. MORIN @ 2015-12-18 21:15 UTC (permalink / raw)
To: buildroot
Martin, All,
On 2015-12-17 23:20 +0000, Martin Bark spake thusly:
> Fix segmentation fault in node.js when using uClibc-ng.
>
> This patch fixes bug #8296, see
> https://bugs.busybox.net/show_bug.cgi?id=8296.
>
> Signed-off-by: Martin Bark <martin@barkynet.com>
>
> ---
[--SNIP--]
> diff --git a/package/nodejs/5.3.0/0006-Fix-support-for-uClibc-ng.patch b/package/nodejs/5.3.0/0006-Fix-support-for-uClibc-ng.patch
> new file mode 100644
> index 0000000..918a36a
> --- /dev/null
> +++ b/package/nodejs/5.3.0/0006-Fix-support-for-uClibc-ng.patch
> @@ -0,0 +1,32 @@
> +From 1cc08f6ceacbb0e5ba1f4638ca3a97ac002d7792 Mon Sep 17 00:00:00 2001
> +From: "Bark, Martin" <martin.bark@te.com>
> +Date: Mon, 14 Dec 2015 13:26:10 +0000
> +Subject: [PATCH 2/2] Fix support for uClibc-ng
> +
> +uClibc-ng is currently at v1.0.9. The patch corrects the uClibc
> +version test so that HAVE_IFADDRS_H is defined for uClibc versions
> +after v0.9.32.
> +
> +Submitted upstream to libuv, see https://github.com/libuv/libuv/pull/653
And that has since been accepted and applied:
https://github.com/libuv/libuv/commit/c8619721404c2a9f97adc34a8c3b5336317311bc
Regards,
Yann E. MORIN.
> +Signed-off-by: Bark, Martin <martin.bark@te.com>
> +---
> + deps/uv/src/unix/linux-core.c | 2 +-
> + 1 file changed, 1 insertion(+), 1 deletion(-)
> +
> +diff --git a/deps/uv/src/unix/linux-core.c b/deps/uv/src/unix/linux-core.c
> +index e6e6828..6cbbb71 100644
> +--- a/deps/uv/src/unix/linux-core.c
> ++++ b/deps/uv/src/unix/linux-core.c
> +@@ -39,7 +39,7 @@
> + #define HAVE_IFADDRS_H 1
> +
> + #ifdef __UCLIBC__
> +-# if __UCLIBC_MAJOR__ < 0 || __UCLIBC_MINOR__ < 9 || __UCLIBC_SUBLEVEL__ < 32
> ++# if __UCLIBC_MAJOR__ < 0 && __UCLIBC_MINOR__ < 9 && __UCLIBC_SUBLEVEL__ < 32
> + # undef HAVE_IFADDRS_H
> + # endif
> + #endif
> +--
> +2.6.2
> +
> --
> 2.5.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 1/5] package/nodejs: bump version to 5.3.0
2015-12-17 23:20 [Buildroot] [PATCH v2 1/5] package/nodejs: bump version to 5.3.0 Martin Bark
` (4 preceding siblings ...)
2015-12-18 21:09 ` [Buildroot] [PATCH v2 1/5] package/nodejs: bump version to 5.3.0 Yann E. MORIN
@ 2015-12-18 21:35 ` Yann E. MORIN
2015-12-20 16:59 ` Martin Bark
5 siblings, 1 reply; 13+ messages in thread
From: Yann E. MORIN @ 2015-12-18 21:35 UTC (permalink / raw)
To: buildroot
Martin, All,
On 2015-12-17 23:20 +0000, Martin Bark spake thusly:
> Replace 4.2.3 with 5.3.0. 5.3.0 is the current Stable release. See
> https://nodejs.org/en/blog/release/v5.3.0 for details on the release.
>
> Copied 4.2.3 patched to 5.3.0 with the following exceptions:
> - Removed 0004-fix-arm-vfpv2.patch, committed upstream and included in
> 5.3.0. See https://github.com/nodejs/node/commit/84dea1bd0c
> - Added 0004-Fix-va_list-not-declared.patch, fix for a new bug. This
> has already been fixed upstream but is not in 5.3.0
>
> Signed-off-by: Martin Bark <martin@barkynet.com>
We've discussed yet a bit more about the nodejs versions with Thomas on
IRC.
One idea we had was that we could just get rid of the version choice
altogether form the Config.in.
Then, in the .mk, we'd set the version to 5.3.x if all conditions are
met, or use 0.10.x otherwise.
What do you think about that?
Regards,
Yann E. MORIN.
> ---
> Changes v1 -> v2
> - Updated patch set from 5.2.0 to 5.3.0
> ---
> Config.in.legacy | 9 +++++
> package/nodejs/4.2.3/0004-fix-arm-vfpv2.patch | 46 ----------------------
> ...01-Remove-dependency-on-Python-bz2-module.patch | 0
> .../0002-gyp-force-link-command-to-use-CXX.patch | 0
> ...hon-variable-instead-of-hardcoding-Python.patch | 0
> .../5.3.0/0004-Fix-va_list-not-declared.patch | 39 ++++++++++++++++++
> package/nodejs/Config.in | 12 +++---
> package/nodejs/nodejs.hash | 4 +-
> package/nodejs/nodejs.mk | 2 +-
> 9 files changed, 58 insertions(+), 54 deletions(-)
> delete mode 100644 package/nodejs/4.2.3/0004-fix-arm-vfpv2.patch
> rename package/nodejs/{4.2.3 => 5.3.0}/0001-Remove-dependency-on-Python-bz2-module.patch (100%)
> rename package/nodejs/{4.2.3 => 5.3.0}/0002-gyp-force-link-command-to-use-CXX.patch (100%)
> rename package/nodejs/{4.2.3 => 5.3.0}/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch (100%)
> create mode 100644 package/nodejs/5.3.0/0004-Fix-va_list-not-declared.patch
>
> diff --git a/Config.in.legacy b/Config.in.legacy
> index e1ea06f..ee67720 100644
> --- a/Config.in.legacy
> +++ b/Config.in.legacy
> @@ -186,6 +186,15 @@ config BR2_PACKAGE_INFOZIP
> to avoid ambiguities with Info-Zip's UnZip which has been added
> in the unzip package.
>
> +config BR2_BR2_PACKAGE_NODEJS_4_X
> + bool "nodejs version 4.x has been removed"
> + select BR2_LEGACY
> + select BR2_PACKAGE_NODEJS
> + help
> + nodejs version 4.x has been removed. As an alternative,
> + the latest nodejs version has been automatically selected in
> + your configuration.
> +
> ###############################################################################
> comment "Legacy options removed in 2015.11"
>
> diff --git a/package/nodejs/4.2.3/0004-fix-arm-vfpv2.patch b/package/nodejs/4.2.3/0004-fix-arm-vfpv2.patch
> deleted file mode 100644
> index 7ff280b..0000000
> --- a/package/nodejs/4.2.3/0004-fix-arm-vfpv2.patch
> +++ /dev/null
> @@ -1,46 +0,0 @@
> -From 0b07d813adcfdc13ef6a0c56f88b864eb3dc4be9 Mon Sep 17 00:00:00 2001
> -From: =?UTF-8?q?J=C3=B6rg=20Krause?= <joerg.krause@embedded.rocks>
> -Date: Tue, 8 Dec 2015 21:53:06 +0100
> -Subject: [PATCH] configure: fix arm vfpv2
> -MIME-Version: 1.0
> -Content-Type: text/plain; charset=UTF-8
> -Content-Transfer-Encoding: 8bit
> -
> -The gcc -mfpu flag for VFPv2 is 'vfp', not 'vfpv2' [1].
> -
> -Patch status: Sent upstream [2]
> -
> -[1] https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
> -[2] https://github.com/nodejs/node/pull/4202
> -
> -Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> -[J?rg Krause: adapt to version 4.2.3]
> -Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> ----
> - configure | 4 ++--
> - 1 file changed, 2 insertions(+), 2 deletions(-)
> -
> -diff --git a/configure b/configure
> -index d4aff36..c783bab 100755
> ---- a/configure
> -+++ b/configure
> -@@ -30,7 +30,7 @@ valid_os = ('win', 'mac', 'solaris', 'freebsd', 'openbsd', 'linux',
> - valid_arch = ('arm', 'arm64', 'ia32', 'mips', 'mipsel', 'ppc', 'ppc64', 'x32',
> - 'x64', 'x86')
> - valid_arm_float_abi = ('soft', 'softfp', 'hard')
> --valid_arm_fpu = ('vfp', 'vfpv2', 'vfpv3', 'vfpv3-d16', 'neon')
> -+valid_arm_fpu = ('vfp', 'vfpv3', 'vfpv3-d16', 'neon')
> - valid_mips_arch = ('loongson', 'r1', 'r2', 'r6', 'rx')
> - valid_mips_fpu = ('fp32', 'fp64', 'fpxx')
> - valid_mips_float_abi = ('soft', 'hard')
> -@@ -622,7 +622,7 @@ def configure_arm(o):
> - else:
> - arm_float_abi = 'default'
> -
> -- arm_fpu = 'vfpv2'
> -+ arm_fpu = 'vfp'
> -
> - if is_arch_armv7():
> - arm_fpu = 'vfpv3'
> ---
> -2.6.3
> diff --git a/package/nodejs/4.2.3/0001-Remove-dependency-on-Python-bz2-module.patch b/package/nodejs/5.3.0/0001-Remove-dependency-on-Python-bz2-module.patch
> similarity index 100%
> rename from package/nodejs/4.2.3/0001-Remove-dependency-on-Python-bz2-module.patch
> rename to package/nodejs/5.3.0/0001-Remove-dependency-on-Python-bz2-module.patch
> diff --git a/package/nodejs/4.2.3/0002-gyp-force-link-command-to-use-CXX.patch b/package/nodejs/5.3.0/0002-gyp-force-link-command-to-use-CXX.patch
> similarity index 100%
> rename from package/nodejs/4.2.3/0002-gyp-force-link-command-to-use-CXX.patch
> rename to package/nodejs/5.3.0/0002-gyp-force-link-command-to-use-CXX.patch
> diff --git a/package/nodejs/4.2.3/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch b/package/nodejs/5.3.0/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
> similarity index 100%
> rename from package/nodejs/4.2.3/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
> rename to package/nodejs/5.3.0/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
> diff --git a/package/nodejs/5.3.0/0004-Fix-va_list-not-declared.patch b/package/nodejs/5.3.0/0004-Fix-va_list-not-declared.patch
> new file mode 100644
> index 0000000..aec8e12
> --- /dev/null
> +++ b/package/nodejs/5.3.0/0004-Fix-va_list-not-declared.patch
> @@ -0,0 +1,39 @@
> +From 5b3dd2599ebde1846750aaf7c79576ad45246ffa Mon Sep 17 00:00:00 2001
> +From: Martin Bark <martin@barkynet.com>
> +Date: Tue, 8 Dec 2015 11:41:08 +0000
> +Subject: [PATCH] Fix va_list not declared
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +When compiling with uClibc-ng the following error is seen.
> +
> +In file included from ../deps/v8/src/log-utils.cc:5:0:
> +../deps/v8/src/log-utils.h:64:39: error: ?va_list? has not been declared
> + void AppendVA(const char* format, va_list args);
> +
> +This patch fixes the issue by adding the missing #include <cstdarg>. Note
> +that this fix has already be included upstream, see
> +https://github.com/nodejs/node/blob/8a43a3d/deps/v8/src/log-utils.h
> +
> +Signed-off-by: Martin Bark <martin@barkynet.com>
> +---
> + deps/v8/src/log-utils.h | 2 ++
> + 1 file changed, 2 insertions(+)
> +
> +diff --git a/deps/v8/src/log-utils.h b/deps/v8/src/log-utils.h
> +index 87dab52..6714307 100644
> +--- a/deps/v8/src/log-utils.h
> ++++ b/deps/v8/src/log-utils.h
> +@@ -5,6 +5,8 @@
> + #ifndef V8_LOG_UTILS_H_
> + #define V8_LOG_UTILS_H_
> +
> ++#include <cstdarg>
> ++
> + #include "src/allocation.h"
> + #include "src/base/platform/mutex.h"
> + #include "src/flags.h"
> +--
> +2.5.0
> +
> diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
> index b0f4f2b..769710c 100644
> --- a/package/nodejs/Config.in
> +++ b/package/nodejs/Config.in
> @@ -37,7 +37,7 @@ config BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
> choice
> prompt "Node.js version"
> default BR2_BR2_PACKAGE_NODEJS_0_10_X if BR2_ARM_CPU_ARMV5
> - default BR2_BR2_PACKAGE_NODEJS_4_X
> + default BR2_PACKAGE_NODEJS_5_X
> help
> Select the version of Node.js you wish to use.
>
> @@ -48,14 +48,16 @@ config BR2_BR2_PACKAGE_NODEJS_0_12_X
> bool "v0.12.9"
> depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
>
> -config BR2_BR2_PACKAGE_NODEJS_4_X
> - bool "v4.2.3"
> +config BR2_PACKAGE_NODEJS_5_X
> + bool "v5.3.0"
> depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> + depends on BR2_USE_WCHAR
>
> -comment "v4.2.3 needs a toolchain w/ gcc >= 4.8"
> +comment "v5.3.0 needs a toolchain w/ gcc >= 4.8, wchar"
> depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
> depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
> + depends on !BR2_USE_WCHAR
>
> endchoice
>
> @@ -63,7 +65,7 @@ config BR2_PACKAGE_NODEJS_VERSION_STRING
> string
> default "0.10.41" if BR2_BR2_PACKAGE_NODEJS_0_10_X
> default "0.12.9" if BR2_BR2_PACKAGE_NODEJS_0_12_X
> - default "4.2.3" if BR2_BR2_PACKAGE_NODEJS_4_X
> + default "5.3.0" if BR2_PACKAGE_NODEJS_5_X
>
> menu "Module Selection"
>
> diff --git a/package/nodejs/nodejs.hash b/package/nodejs/nodejs.hash
> index 7d58a54..c3bdc44 100644
> --- a/package/nodejs/nodejs.hash
> +++ b/package/nodejs/nodejs.hash
> @@ -4,5 +4,5 @@ sha256 79f694e2a5c42543b75d0c69f6860499d7593136d0f6b59e7163b9e66fb2c995 node-v0
> # From upstream URL: http://nodejs.org/dist/v0.12.9/SHASUMS256.txt
> sha256 35daad301191e5f8dd7e5d2fbb711d081b82d1837d59837b8ee224c256cfe5e4 node-v0.12.9.tar.gz
>
> -# From upstream URL: http://nodejs.org/dist/v4.2.3/SHASUMS256.txt
> -sha256 9e8aef1e47b317575c421c8d10a80e6c319b26969b566d3b84e49e65a92837f4 node-v4.2.3.tar.xz
> +# From upstream URL: http://nodejs.org/dist/v5.3.0/SHASUMS256.txt
> +sha256 e5115ee78c31ac3af0f2b3553aa84fff2f49ae59bd6e01e11d78ce86c544569e node-v5.3.0.tar.xz
> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
> index 7ede89d..af47b26 100644
> --- a/package/nodejs/nodejs.mk
> +++ b/package/nodejs/nodejs.mk
> @@ -5,7 +5,7 @@
> ################################################################################
>
> NODEJS_VERSION = $(call qstrip,$(BR2_PACKAGE_NODEJS_VERSION_STRING))
> -ifeq ($(BR2_BR2_PACKAGE_NODEJS_4_X),y)
> +ifeq ($(BR2_PACKAGE_NODEJS_5_X),y)
> NODEJS_SOURCE = node-v$(NODEJS_VERSION).tar.xz
> else
> NODEJS_SOURCE = node-v$(NODEJS_VERSION).tar.gz
> --
> 2.5.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 3/5] package/nodejs: correct 0.10.x option name
2015-12-18 21:12 ` Yann E. MORIN
@ 2015-12-18 22:47 ` Arnout Vandecappelle
2015-12-20 17:03 ` Martin Bark
0 siblings, 1 reply; 13+ messages in thread
From: Arnout Vandecappelle @ 2015-12-18 22:47 UTC (permalink / raw)
To: buildroot
On 18-12-15 22:12, Yann E. MORIN wrote:
> Martin, All,
>
> On 2015-12-17 23:20 +0000, Martin Bark spake thusly:
>> The nodejs options incorrectly started BR2_BR2_xxx. This change corrects
>> the name for 0.10.x releases to BR2_PACKAGE_NODEJS_0_10_X
>>
>> Signed-off-by: Martin Bark <martin@barkynet.com>
>>
>> ---
>> Changes v1 -> v2
>> - New in v2
>> ---
>> Config.in.legacy | 8 ++++++++
>> package/nodejs/Config.in | 6 +++---
>> 2 files changed, 11 insertions(+), 3 deletions(-)
>>
>> diff --git a/Config.in.legacy b/Config.in.legacy
>> index db1eeae..5d9a3ee 100644
>> --- a/Config.in.legacy
>> +++ b/Config.in.legacy
>> @@ -186,6 +186,14 @@ config BR2_PACKAGE_INFOZIP
>> to avoid ambiguities with Info-Zip's UnZip which has been added
>> in the unzip package.
>>
>> +config BR2_BR2_PACKAGE_NODEJS_0_10_X
>> + bool "nodejs 0.10.x option renamed"
>> + select BR2_LEGACY
>> + select BR2_PACKAGE_NODEJS_0_10_X
>
> No, you can't select an option that is in a choice. All you can do in
> this case is tell the user to check his configuration, and refer him
> to the version choice.
Actually, you can do the same like we do for legacy string options:
config BR2_PACKAGE_NODEJS_0_10_X
bool "v0.10.41"
default y if BR2_BR2_PACKAGE_NODEJS_0_10_X
In that case you should also add a comment to Config.in.legacy to remind us to
remove it again when the legacy option is removed.
We should probably add this to the documentation at the top of Config.in.legacy.
Regards,
Arnout
>
> Regards,
> Yann E. MORIN.
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 4/5] package/nodejs: fix support for uClibc-ng
2015-12-18 21:15 ` Yann E. MORIN
@ 2015-12-20 16:58 ` Martin Bark
0 siblings, 0 replies; 13+ messages in thread
From: Martin Bark @ 2015-12-20 16:58 UTC (permalink / raw)
To: buildroot
Yann,
On 18 December 2015 at 21:15, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Martin, All,
>
> On 2015-12-17 23:20 +0000, Martin Bark spake thusly:
>> Fix segmentation fault in node.js when using uClibc-ng.
>>
>> This patch fixes bug #8296, see
>> https://bugs.busybox.net/show_bug.cgi?id=8296.
>>
>> Signed-off-by: Martin Bark <martin@barkynet.com>
>>
>> ---
> [--SNIP--]
>> diff --git a/package/nodejs/5.3.0/0006-Fix-support-for-uClibc-ng.patch b/package/nodejs/5.3.0/0006-Fix-support-for-uClibc-ng.patch
>> new file mode 100644
>> index 0000000..918a36a
>> --- /dev/null
>> +++ b/package/nodejs/5.3.0/0006-Fix-support-for-uClibc-ng.patch
>> @@ -0,0 +1,32 @@
>> +From 1cc08f6ceacbb0e5ba1f4638ca3a97ac002d7792 Mon Sep 17 00:00:00 2001
>> +From: "Bark, Martin" <martin.bark@te.com>
>> +Date: Mon, 14 Dec 2015 13:26:10 +0000
>> +Subject: [PATCH 2/2] Fix support for uClibc-ng
>> +
>> +uClibc-ng is currently at v1.0.9. The patch corrects the uClibc
>> +version test so that HAVE_IFADDRS_H is defined for uClibc versions
>> +after v0.9.32.
>> +
>> +Submitted upstream to libuv, see https://github.com/libuv/libuv/pull/653
>
> And that has since been accepted and applied:
> https://github.com/libuv/libuv/commit/c8619721404c2a9f97adc34a8c3b5336317311bc
Good point, i'll update the comment in my next patch set
>
> Regards,
> Yann E. MORIN.
>
>> +Signed-off-by: Bark, Martin <martin.bark@te.com>
>> +---
>> + deps/uv/src/unix/linux-core.c | 2 +-
>> + 1 file changed, 1 insertion(+), 1 deletion(-)
>> +
>> +diff --git a/deps/uv/src/unix/linux-core.c b/deps/uv/src/unix/linux-core.c
>> +index e6e6828..6cbbb71 100644
>> +--- a/deps/uv/src/unix/linux-core.c
>> ++++ b/deps/uv/src/unix/linux-core.c
>> +@@ -39,7 +39,7 @@
>> + #define HAVE_IFADDRS_H 1
>> +
>> + #ifdef __UCLIBC__
>> +-# if __UCLIBC_MAJOR__ < 0 || __UCLIBC_MINOR__ < 9 || __UCLIBC_SUBLEVEL__ < 32
>> ++# if __UCLIBC_MAJOR__ < 0 && __UCLIBC_MINOR__ < 9 && __UCLIBC_SUBLEVEL__ < 32
>> + # undef HAVE_IFADDRS_H
>> + # endif
>> + #endif
>> +--
>> +2.6.2
>> +
>> --
>> 2.5.0
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 1/5] package/nodejs: bump version to 5.3.0
2015-12-18 21:35 ` Yann E. MORIN
@ 2015-12-20 16:59 ` Martin Bark
0 siblings, 0 replies; 13+ messages in thread
From: Martin Bark @ 2015-12-20 16:59 UTC (permalink / raw)
To: buildroot
Yann,
On 18 December 2015 at 21:35, Yann E. MORIN <yann.morin.1998@free.fr> wrote:
> Martin, All,
>
> On 2015-12-17 23:20 +0000, Martin Bark spake thusly:
>> Replace 4.2.3 with 5.3.0. 5.3.0 is the current Stable release. See
>> https://nodejs.org/en/blog/release/v5.3.0 for details on the release.
>>
>> Copied 4.2.3 patched to 5.3.0 with the following exceptions:
>> - Removed 0004-fix-arm-vfpv2.patch, committed upstream and included in
>> 5.3.0. See https://github.com/nodejs/node/commit/84dea1bd0c
>> - Added 0004-Fix-va_list-not-declared.patch, fix for a new bug. This
>> has already been fixed upstream but is not in 5.3.0
>>
>> Signed-off-by: Martin Bark <martin@barkynet.com>
>
> We've discussed yet a bit more about the nodejs versions with Thomas on
> IRC.
>
> One idea we had was that we could just get rid of the version choice
> altogether form the Config.in.
>
> Then, in the .mk, we'd set the version to 5.3.x if all conditions are
> met, or use 0.10.x otherwise.
>
> What do you think about that?
Yes i think that's a good idea. I'll work on a new patch set and include this.
Thanks
Martin
>
> Regards,
> Yann E. MORIN.
>
>> ---
>> Changes v1 -> v2
>> - Updated patch set from 5.2.0 to 5.3.0
>> ---
>> Config.in.legacy | 9 +++++
>> package/nodejs/4.2.3/0004-fix-arm-vfpv2.patch | 46 ----------------------
>> ...01-Remove-dependency-on-Python-bz2-module.patch | 0
>> .../0002-gyp-force-link-command-to-use-CXX.patch | 0
>> ...hon-variable-instead-of-hardcoding-Python.patch | 0
>> .../5.3.0/0004-Fix-va_list-not-declared.patch | 39 ++++++++++++++++++
>> package/nodejs/Config.in | 12 +++---
>> package/nodejs/nodejs.hash | 4 +-
>> package/nodejs/nodejs.mk | 2 +-
>> 9 files changed, 58 insertions(+), 54 deletions(-)
>> delete mode 100644 package/nodejs/4.2.3/0004-fix-arm-vfpv2.patch
>> rename package/nodejs/{4.2.3 => 5.3.0}/0001-Remove-dependency-on-Python-bz2-module.patch (100%)
>> rename package/nodejs/{4.2.3 => 5.3.0}/0002-gyp-force-link-command-to-use-CXX.patch (100%)
>> rename package/nodejs/{4.2.3 => 5.3.0}/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch (100%)
>> create mode 100644 package/nodejs/5.3.0/0004-Fix-va_list-not-declared.patch
>>
>> diff --git a/Config.in.legacy b/Config.in.legacy
>> index e1ea06f..ee67720 100644
>> --- a/Config.in.legacy
>> +++ b/Config.in.legacy
>> @@ -186,6 +186,15 @@ config BR2_PACKAGE_INFOZIP
>> to avoid ambiguities with Info-Zip's UnZip which has been added
>> in the unzip package.
>>
>> +config BR2_BR2_PACKAGE_NODEJS_4_X
>> + bool "nodejs version 4.x has been removed"
>> + select BR2_LEGACY
>> + select BR2_PACKAGE_NODEJS
>> + help
>> + nodejs version 4.x has been removed. As an alternative,
>> + the latest nodejs version has been automatically selected in
>> + your configuration.
>> +
>> ###############################################################################
>> comment "Legacy options removed in 2015.11"
>>
>> diff --git a/package/nodejs/4.2.3/0004-fix-arm-vfpv2.patch b/package/nodejs/4.2.3/0004-fix-arm-vfpv2.patch
>> deleted file mode 100644
>> index 7ff280b..0000000
>> --- a/package/nodejs/4.2.3/0004-fix-arm-vfpv2.patch
>> +++ /dev/null
>> @@ -1,46 +0,0 @@
>> -From 0b07d813adcfdc13ef6a0c56f88b864eb3dc4be9 Mon Sep 17 00:00:00 2001
>> -From: =?UTF-8?q?J=C3=B6rg=20Krause?= <joerg.krause@embedded.rocks>
>> -Date: Tue, 8 Dec 2015 21:53:06 +0100
>> -Subject: [PATCH] configure: fix arm vfpv2
>> -MIME-Version: 1.0
>> -Content-Type: text/plain; charset=UTF-8
>> -Content-Transfer-Encoding: 8bit
>> -
>> -The gcc -mfpu flag for VFPv2 is 'vfp', not 'vfpv2' [1].
>> -
>> -Patch status: Sent upstream [2]
>> -
>> -[1] https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
>> -[2] https://github.com/nodejs/node/pull/4202
>> -
>> -Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>> -[J?rg Krause: adapt to version 4.2.3]
>> -Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
>> ----
>> - configure | 4 ++--
>> - 1 file changed, 2 insertions(+), 2 deletions(-)
>> -
>> -diff --git a/configure b/configure
>> -index d4aff36..c783bab 100755
>> ---- a/configure
>> -+++ b/configure
>> -@@ -30,7 +30,7 @@ valid_os = ('win', 'mac', 'solaris', 'freebsd', 'openbsd', 'linux',
>> - valid_arch = ('arm', 'arm64', 'ia32', 'mips', 'mipsel', 'ppc', 'ppc64', 'x32',
>> - 'x64', 'x86')
>> - valid_arm_float_abi = ('soft', 'softfp', 'hard')
>> --valid_arm_fpu = ('vfp', 'vfpv2', 'vfpv3', 'vfpv3-d16', 'neon')
>> -+valid_arm_fpu = ('vfp', 'vfpv3', 'vfpv3-d16', 'neon')
>> - valid_mips_arch = ('loongson', 'r1', 'r2', 'r6', 'rx')
>> - valid_mips_fpu = ('fp32', 'fp64', 'fpxx')
>> - valid_mips_float_abi = ('soft', 'hard')
>> -@@ -622,7 +622,7 @@ def configure_arm(o):
>> - else:
>> - arm_float_abi = 'default'
>> -
>> -- arm_fpu = 'vfpv2'
>> -+ arm_fpu = 'vfp'
>> -
>> - if is_arch_armv7():
>> - arm_fpu = 'vfpv3'
>> ---
>> -2.6.3
>> diff --git a/package/nodejs/4.2.3/0001-Remove-dependency-on-Python-bz2-module.patch b/package/nodejs/5.3.0/0001-Remove-dependency-on-Python-bz2-module.patch
>> similarity index 100%
>> rename from package/nodejs/4.2.3/0001-Remove-dependency-on-Python-bz2-module.patch
>> rename to package/nodejs/5.3.0/0001-Remove-dependency-on-Python-bz2-module.patch
>> diff --git a/package/nodejs/4.2.3/0002-gyp-force-link-command-to-use-CXX.patch b/package/nodejs/5.3.0/0002-gyp-force-link-command-to-use-CXX.patch
>> similarity index 100%
>> rename from package/nodejs/4.2.3/0002-gyp-force-link-command-to-use-CXX.patch
>> rename to package/nodejs/5.3.0/0002-gyp-force-link-command-to-use-CXX.patch
>> diff --git a/package/nodejs/4.2.3/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch b/package/nodejs/5.3.0/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
>> similarity index 100%
>> rename from package/nodejs/4.2.3/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
>> rename to package/nodejs/5.3.0/0003-Use-a-python-variable-instead-of-hardcoding-Python.patch
>> diff --git a/package/nodejs/5.3.0/0004-Fix-va_list-not-declared.patch b/package/nodejs/5.3.0/0004-Fix-va_list-not-declared.patch
>> new file mode 100644
>> index 0000000..aec8e12
>> --- /dev/null
>> +++ b/package/nodejs/5.3.0/0004-Fix-va_list-not-declared.patch
>> @@ -0,0 +1,39 @@
>> +From 5b3dd2599ebde1846750aaf7c79576ad45246ffa Mon Sep 17 00:00:00 2001
>> +From: Martin Bark <martin@barkynet.com>
>> +Date: Tue, 8 Dec 2015 11:41:08 +0000
>> +Subject: [PATCH] Fix va_list not declared
>> +MIME-Version: 1.0
>> +Content-Type: text/plain; charset=UTF-8
>> +Content-Transfer-Encoding: 8bit
>> +
>> +When compiling with uClibc-ng the following error is seen.
>> +
>> +In file included from ../deps/v8/src/log-utils.cc:5:0:
>> +../deps/v8/src/log-utils.h:64:39: error: ?va_list? has not been declared
>> + void AppendVA(const char* format, va_list args);
>> +
>> +This patch fixes the issue by adding the missing #include <cstdarg>. Note
>> +that this fix has already be included upstream, see
>> +https://github.com/nodejs/node/blob/8a43a3d/deps/v8/src/log-utils.h
>> +
>> +Signed-off-by: Martin Bark <martin@barkynet.com>
>> +---
>> + deps/v8/src/log-utils.h | 2 ++
>> + 1 file changed, 2 insertions(+)
>> +
>> +diff --git a/deps/v8/src/log-utils.h b/deps/v8/src/log-utils.h
>> +index 87dab52..6714307 100644
>> +--- a/deps/v8/src/log-utils.h
>> ++++ b/deps/v8/src/log-utils.h
>> +@@ -5,6 +5,8 @@
>> + #ifndef V8_LOG_UTILS_H_
>> + #define V8_LOG_UTILS_H_
>> +
>> ++#include <cstdarg>
>> ++
>> + #include "src/allocation.h"
>> + #include "src/base/platform/mutex.h"
>> + #include "src/flags.h"
>> +--
>> +2.5.0
>> +
>> diff --git a/package/nodejs/Config.in b/package/nodejs/Config.in
>> index b0f4f2b..769710c 100644
>> --- a/package/nodejs/Config.in
>> +++ b/package/nodejs/Config.in
>> @@ -37,7 +37,7 @@ config BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
>> choice
>> prompt "Node.js version"
>> default BR2_BR2_PACKAGE_NODEJS_0_10_X if BR2_ARM_CPU_ARMV5
>> - default BR2_BR2_PACKAGE_NODEJS_4_X
>> + default BR2_PACKAGE_NODEJS_5_X
>> help
>> Select the version of Node.js you wish to use.
>>
>> @@ -48,14 +48,16 @@ config BR2_BR2_PACKAGE_NODEJS_0_12_X
>> bool "v0.12.9"
>> depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
>>
>> -config BR2_BR2_PACKAGE_NODEJS_4_X
>> - bool "v4.2.3"
>> +config BR2_PACKAGE_NODEJS_5_X
>> + bool "v5.3.0"
>> depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
>> depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
>> + depends on BR2_USE_WCHAR
>>
>> -comment "v4.2.3 needs a toolchain w/ gcc >= 4.8"
>> +comment "v5.3.0 needs a toolchain w/ gcc >= 4.8, wchar"
>> depends on BR2_PACKAGE_NODEJS_V8_ARCH_SUPPORTS
>> depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_8
>> + depends on !BR2_USE_WCHAR
>>
>> endchoice
>>
>> @@ -63,7 +65,7 @@ config BR2_PACKAGE_NODEJS_VERSION_STRING
>> string
>> default "0.10.41" if BR2_BR2_PACKAGE_NODEJS_0_10_X
>> default "0.12.9" if BR2_BR2_PACKAGE_NODEJS_0_12_X
>> - default "4.2.3" if BR2_BR2_PACKAGE_NODEJS_4_X
>> + default "5.3.0" if BR2_PACKAGE_NODEJS_5_X
>>
>> menu "Module Selection"
>>
>> diff --git a/package/nodejs/nodejs.hash b/package/nodejs/nodejs.hash
>> index 7d58a54..c3bdc44 100644
>> --- a/package/nodejs/nodejs.hash
>> +++ b/package/nodejs/nodejs.hash
>> @@ -4,5 +4,5 @@ sha256 79f694e2a5c42543b75d0c69f6860499d7593136d0f6b59e7163b9e66fb2c995 node-v0
>> # From upstream URL: http://nodejs.org/dist/v0.12.9/SHASUMS256.txt
>> sha256 35daad301191e5f8dd7e5d2fbb711d081b82d1837d59837b8ee224c256cfe5e4 node-v0.12.9.tar.gz
>>
>> -# From upstream URL: http://nodejs.org/dist/v4.2.3/SHASUMS256.txt
>> -sha256 9e8aef1e47b317575c421c8d10a80e6c319b26969b566d3b84e49e65a92837f4 node-v4.2.3.tar.xz
>> +# From upstream URL: http://nodejs.org/dist/v5.3.0/SHASUMS256.txt
>> +sha256 e5115ee78c31ac3af0f2b3553aa84fff2f49ae59bd6e01e11d78ce86c544569e node-v5.3.0.tar.xz
>> diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
>> index 7ede89d..af47b26 100644
>> --- a/package/nodejs/nodejs.mk
>> +++ b/package/nodejs/nodejs.mk
>> @@ -5,7 +5,7 @@
>> ################################################################################
>>
>> NODEJS_VERSION = $(call qstrip,$(BR2_PACKAGE_NODEJS_VERSION_STRING))
>> -ifeq ($(BR2_BR2_PACKAGE_NODEJS_4_X),y)
>> +ifeq ($(BR2_PACKAGE_NODEJS_5_X),y)
>> NODEJS_SOURCE = node-v$(NODEJS_VERSION).tar.xz
>> else
>> NODEJS_SOURCE = node-v$(NODEJS_VERSION).tar.gz
>> --
>> 2.5.0
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
> | +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
> '------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH v2 3/5] package/nodejs: correct 0.10.x option name
2015-12-18 22:47 ` Arnout Vandecappelle
@ 2015-12-20 17:03 ` Martin Bark
0 siblings, 0 replies; 13+ messages in thread
From: Martin Bark @ 2015-12-20 17:03 UTC (permalink / raw)
To: buildroot
Yann, Arnout,
On 18 December 2015 at 22:47, Arnout Vandecappelle <arnout@mind.be> wrote:
> On 18-12-15 22:12, Yann E. MORIN wrote:
>> Martin, All,
>>
>> On 2015-12-17 23:20 +0000, Martin Bark spake thusly:
>>> The nodejs options incorrectly started BR2_BR2_xxx. This change corrects
>>> the name for 0.10.x releases to BR2_PACKAGE_NODEJS_0_10_X
>>>
>>> Signed-off-by: Martin Bark <martin@barkynet.com>
>>>
>>> ---
>>> Changes v1 -> v2
>>> - New in v2
>>> ---
>>> Config.in.legacy | 8 ++++++++
>>> package/nodejs/Config.in | 6 +++---
>>> 2 files changed, 11 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/Config.in.legacy b/Config.in.legacy
>>> index db1eeae..5d9a3ee 100644
>>> --- a/Config.in.legacy
>>> +++ b/Config.in.legacy
>>> @@ -186,6 +186,14 @@ config BR2_PACKAGE_INFOZIP
>>> to avoid ambiguities with Info-Zip's UnZip which has been added
>>> in the unzip package.
>>>
>>> +config BR2_BR2_PACKAGE_NODEJS_0_10_X
>>> + bool "nodejs 0.10.x option renamed"
>>> + select BR2_LEGACY
>>> + select BR2_PACKAGE_NODEJS_0_10_X
>>
>> No, you can't select an option that is in a choice. All you can do in
>> this case is tell the user to check his configuration, and refer him
>> to the version choice.
>
> Actually, you can do the same like we do for legacy string options:
>
> config BR2_PACKAGE_NODEJS_0_10_X
> bool "v0.10.41"
> default y if BR2_BR2_PACKAGE_NODEJS_0_10_X
>
> In that case you should also add a comment to Config.in.legacy to remind us to
> remove it again when the legacy option is removed.
>
> We should probably add this to the documentation at the top of Config.in.legacy.
Thanks for the info, i did not know this. I'll be sending an update
patch set soon.
Thanks
Martin
>
> Regards,
> Arnout
>
>
>>
>> Regards,
>> Yann E. MORIN.
>>
>
>
> --
> Arnout Vandecappelle arnout at mind be
> Senior Embedded Software Architect +32-16-286500
> Essensium/Mind http://www.mind.be
> G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
> LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
> GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2015-12-20 17:03 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-17 23:20 [Buildroot] [PATCH v2 1/5] package/nodejs: bump version to 5.3.0 Martin Bark
2015-12-17 23:20 ` [Buildroot] [PATCH v2 2/5] package/nodejs: removed version 0.12.9 Martin Bark
2015-12-17 23:20 ` [Buildroot] [PATCH v2 3/5] package/nodejs: correct 0.10.x option name Martin Bark
2015-12-18 21:12 ` Yann E. MORIN
2015-12-18 22:47 ` Arnout Vandecappelle
2015-12-20 17:03 ` Martin Bark
2015-12-17 23:20 ` [Buildroot] [PATCH v2 4/5] package/nodejs: fix support for uClibc-ng Martin Bark
2015-12-18 21:15 ` Yann E. MORIN
2015-12-20 16:58 ` Martin Bark
2015-12-17 23:20 ` [Buildroot] [PATCH v2 5/5] package/libuv: " Martin Bark
2015-12-18 21:09 ` [Buildroot] [PATCH v2 1/5] package/nodejs: bump version to 5.3.0 Yann E. MORIN
2015-12-18 21:35 ` Yann E. MORIN
2015-12-20 16:59 ` Martin Bark
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.