* [Buildroot] [PATCH 1/1] package/smcroute: don't override dependencies
@ 2021-10-18 21:47 Fabrice Fontaine
2021-10-25 20:16 ` Arnout Vandecappelle
2021-10-26 18:30 ` Peter Korsgaard
0 siblings, 2 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2021-10-18 21:47 UTC (permalink / raw)
To: buildroot; +Cc: Matt Weber, Fabrice Fontaine
Don't override SMCROUTE_DEPENDENCIES in a conditional
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/smcroute/smcroute.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/smcroute/smcroute.mk b/package/smcroute/smcroute.mk
index 96da0dc346..913647e7bf 100644
--- a/package/smcroute/smcroute.mk
+++ b/package/smcroute/smcroute.mk
@@ -13,7 +13,7 @@ SMCROUTE_CPE_ID_VENDOR = troglobit
SMCROUTE_CONF_OPTS = --enable-mrdisc
ifeq ($(BR2_PACKAGE_LIBCAP),y)
-SMCROUTE_DEPENDENCIES = libcap
+SMCROUTE_DEPENDENCIES += libcap
SMCROUTE_CONF_OPTS += --with-libcap
else
SMCROUTE_CONF_OPTS += --without-libcap
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/smcroute: don't override dependencies
2021-10-18 21:47 [Buildroot] [PATCH 1/1] package/smcroute: don't override dependencies Fabrice Fontaine
@ 2021-10-25 20:16 ` Arnout Vandecappelle
2021-10-27 15:21 ` Joachim Wiberg
2021-10-26 18:30 ` Peter Korsgaard
1 sibling, 1 reply; 5+ messages in thread
From: Arnout Vandecappelle @ 2021-10-25 20:16 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot; +Cc: Matt Weber
On 18/10/2021 23:47, Fabrice Fontaine wrote:
> Don't override SMCROUTE_DEPENDENCIES in a conditional
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Arnout
> ---
> package/smcroute/smcroute.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/smcroute/smcroute.mk b/package/smcroute/smcroute.mk
> index 96da0dc346..913647e7bf 100644
> --- a/package/smcroute/smcroute.mk
> +++ b/package/smcroute/smcroute.mk
> @@ -13,7 +13,7 @@ SMCROUTE_CPE_ID_VENDOR = troglobit
> SMCROUTE_CONF_OPTS = --enable-mrdisc
>
> ifeq ($(BR2_PACKAGE_LIBCAP),y)
> -SMCROUTE_DEPENDENCIES = libcap
> +SMCROUTE_DEPENDENCIES += libcap
> SMCROUTE_CONF_OPTS += --with-libcap
> else
> SMCROUTE_CONF_OPTS += --without-libcap
>
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/smcroute: don't override dependencies
2021-10-18 21:47 [Buildroot] [PATCH 1/1] package/smcroute: don't override dependencies Fabrice Fontaine
2021-10-25 20:16 ` Arnout Vandecappelle
@ 2021-10-26 18:30 ` Peter Korsgaard
1 sibling, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2021-10-26 18:30 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Matt Weber, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> Don't override SMCROUTE_DEPENDENCIES in a conditional
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x and 2021.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/smcroute: don't override dependencies
2021-10-25 20:16 ` Arnout Vandecappelle
@ 2021-10-27 15:21 ` Joachim Wiberg
0 siblings, 0 replies; 5+ messages in thread
From: Joachim Wiberg @ 2021-10-27 15:21 UTC (permalink / raw)
To: Arnout Vandecappelle, Fabrice Fontaine; +Cc: buildroot
[-- Attachment #1.1.1: Type: text/plain, Size: 332 bytes --]
On 10/25/21 10:16 PM, Arnout Vandecappelle wrote:
> On 18/10/2021 23:47, Fabrice Fontaine wrote:
>> Don't override SMCROUTE_DEPENDENCIES in a conditional
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>
> Applied to master, thanks.
Awesome, thank you Fabrice for finding this!
Regards
/Joachim
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 150 bytes --]
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/1] package/smcroute: don't override dependencies
@ 2021-10-18 21:46 Fabrice Fontaine
0 siblings, 0 replies; 5+ messages in thread
From: Fabrice Fontaine @ 2021-10-18 21:46 UTC (permalink / raw)
To: buildroot; +Cc: Matt Weber, Fabrice Fontaine
Don't override SMCROUTE_DEPENDENCIES in a conditional
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/smcroute/smcroute.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/smcroute/smcroute.mk b/package/smcroute/smcroute.mk
index 96da0dc346..913647e7bf 100644
--- a/package/smcroute/smcroute.mk
+++ b/package/smcroute/smcroute.mk
@@ -13,7 +13,7 @@ SMCROUTE_CPE_ID_VENDOR = troglobit
SMCROUTE_CONF_OPTS = --enable-mrdisc
ifeq ($(BR2_PACKAGE_LIBCAP),y)
-SMCROUTE_DEPENDENCIES = libcap
+SMCROUTE_DEPENDENCIES += libcap
SMCROUTE_CONF_OPTS += --with-libcap
else
SMCROUTE_CONF_OPTS += --without-libcap
--
2.33.0
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-10-27 15:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18 21:47 [Buildroot] [PATCH 1/1] package/smcroute: don't override dependencies Fabrice Fontaine
2021-10-25 20:16 ` Arnout Vandecappelle
2021-10-27 15:21 ` Joachim Wiberg
2021-10-26 18:30 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2021-10-18 21:46 Fabrice Fontaine
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.