All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yakir Yang <ykk@rock-chips.com>
To: Mark yao <mark.yao@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>
Cc: David Airlie <airlied@linux.ie>,
	Thierry Reding <treding@nvidia.com>,
	Rob Herring <robh+dt@kernel.org>, Ken Mixte <kmixter@google.com>,
	Ben Chan <benchan@google.com>,
	Zheng Yang <zhengyang@rock-chips.com>,
	Kumar Gala <galak@codeaurora.org>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support
Date: Mon, 21 Dec 2015 15:44:56 +0800	[thread overview]
Message-ID: <5677ADF8.60305@rock-chips.com> (raw)
In-Reply-To: <5677AAC4.1010405@rock-chips.com>

Hi Mark,

On 12/21/2015 03:31 PM, Mark yao wrote:
> On 2015年11月11日 15:46, Yakir Yang wrote:
>> +    hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD;
>> +
>> +    drm_connector_helper_add(&hdmi->connector,
>> +                 &inno_hdmi_connector_helper_funcs);
>> +    drm_connector_init(drm, &hdmi->connector, 
>> &inno_hdmi_connector_funcs,
>> +               DRM_MODE_CONNECTOR_HDMIA);
>> +
>> +    hdmi->connector.encoder = encoder;
>
> Pls remove "hdmi->connector.encoder = encoder;"
>
> It would cause a error dump on atomic drm runtime:
>
> WARNING: CPU: 3 PID: 74 at drivers/gpu/drm/drm_atomic_helper.c:682 
> drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200()
>
> This issue can be explained from following thread:
> https://lkml.org/lkml/2015/11/16/498
>

Done, thanks

- Yakir

> Thanks.
>



WARNING: multiple messages have this Message-ID (diff)
From: Yakir Yang <ykk@rock-chips.com>
To: Mark yao <mark.yao@rock-chips.com>, Heiko Stuebner <heiko@sntech.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Ben Chan <benchan@google.com>, Ken Mixte <kmixter@google.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-rockchip@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	Kumar Gala <galak@codeaurora.org>,
	Thierry Reding <treding@nvidia.com>,
	linux-arm-kernel@lists.infradead.org,
	Zheng Yang <zhengyang@rock-chips.com>
Subject: Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support
Date: Mon, 21 Dec 2015 15:44:56 +0800	[thread overview]
Message-ID: <5677ADF8.60305@rock-chips.com> (raw)
In-Reply-To: <5677AAC4.1010405@rock-chips.com>

Hi Mark,

On 12/21/2015 03:31 PM, Mark yao wrote:
> On 2015年11月11日 15:46, Yakir Yang wrote:
>> +    hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD;
>> +
>> +    drm_connector_helper_add(&hdmi->connector,
>> +                 &inno_hdmi_connector_helper_funcs);
>> +    drm_connector_init(drm, &hdmi->connector, 
>> &inno_hdmi_connector_funcs,
>> +               DRM_MODE_CONNECTOR_HDMIA);
>> +
>> +    hdmi->connector.encoder = encoder;
>
> Pls remove "hdmi->connector.encoder = encoder;"
>
> It would cause a error dump on atomic drm runtime:
>
> WARNING: CPU: 3 PID: 74 at drivers/gpu/drm/drm_atomic_helper.c:682 
> drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200()
>
> This issue can be explained from following thread:
> https://lkml.org/lkml/2015/11/16/498
>

Done, thanks

- Yakir

> Thanks.
>


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: ykk@rock-chips.com (Yakir Yang)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support
Date: Mon, 21 Dec 2015 15:44:56 +0800	[thread overview]
Message-ID: <5677ADF8.60305@rock-chips.com> (raw)
In-Reply-To: <5677AAC4.1010405@rock-chips.com>

Hi Mark,

On 12/21/2015 03:31 PM, Mark yao wrote:
> On 2015?11?11? 15:46, Yakir Yang wrote:
>> +    hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD;
>> +
>> +    drm_connector_helper_add(&hdmi->connector,
>> +                 &inno_hdmi_connector_helper_funcs);
>> +    drm_connector_init(drm, &hdmi->connector, 
>> &inno_hdmi_connector_funcs,
>> +               DRM_MODE_CONNECTOR_HDMIA);
>> +
>> +    hdmi->connector.encoder = encoder;
>
> Pls remove "hdmi->connector.encoder = encoder;"
>
> It would cause a error dump on atomic drm runtime:
>
> WARNING: CPU: 3 PID: 74 at drivers/gpu/drm/drm_atomic_helper.c:682 
> drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200()
>
> This issue can be explained from following thread:
> https://lkml.org/lkml/2015/11/16/498
>

Done, thanks

- Yakir

> Thanks.
>

  reply	other threads:[~2015-12-21  7:45 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-11  7:45 [RFC PATCH v1 0/2] Introduce Innosilicon HDMI driver on Rockchip platforms Yakir Yang
2015-11-11  7:45 ` Yakir Yang
2015-11-11  7:45 ` Yakir Yang
2015-11-11  7:46 ` [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support Yakir Yang
2015-11-11  7:46   ` Yakir Yang
2015-11-11  7:46   ` Yakir Yang
2015-12-21  7:31   ` Mark yao
2015-12-21  7:31     ` Mark yao
2015-12-21  7:31     ` Mark yao
2015-12-21  7:44     ` Yakir Yang [this message]
2015-12-21  7:44       ` Yakir Yang
2015-12-21  7:44       ` Yakir Yang
2015-11-11  7:47 ` [RFC PATCH v1 2/2] dt-bindings: add document for Innosilicon HDMI on Rockchip platform Yakir Yang
2015-11-11  7:47   ` Yakir Yang
2015-11-11  7:47   ` Yakir Yang
2015-11-11 20:22   ` Rob Herring
2015-11-11 20:22     ` Rob Herring
2015-11-11 20:22     ` Rob Herring
2015-11-12  1:07     ` Yakir Yang
2015-11-12  1:07       ` Yakir Yang
2015-11-12  1:07       ` Yakir Yang
2015-11-21 20:14   ` Heiko Stuebner
2015-11-21 20:14     ` Heiko Stuebner
2015-11-21 20:14     ` Heiko Stuebner
2015-11-23  1:26     ` Yakir Yang
2015-11-23  1:26       ` Yakir Yang
2015-11-23  1:26       ` Yakir Yang
2015-12-21  7:25 ` [RFC PATCH v1 0/2] Introduce Innosilicon HDMI driver on Rockchip platforms Mark yao
2015-12-21  7:25   ` Mark yao
2015-12-21  7:25   ` Mark yao
2015-12-21  7:44   ` Yakir Yang
2015-12-21  7:44     ` Yakir Yang
2015-12-21  7:44     ` Yakir Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5677ADF8.60305@rock-chips.com \
    --to=ykk@rock-chips.com \
    --cc=airlied@linux.ie \
    --cc=benchan@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=kmixter@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=mark.yao@rock-chips.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=treding@nvidia.com \
    --cc=zhengyang@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.