All of lore.kernel.org
 help / color / mirror / Atom feed
* [merged] proc-fix-esrch-error-when-writing-to-proc-pid-coredump_filter.patch removed from -mm tree
@ 2015-12-21 20:24 akpm
  0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2015-12-21 20:24 UTC (permalink / raw)
  To: colin.king, keescook, stable, mm-commits


The patch titled
     Subject: proc: fix -ESRCH error when writing to /proc/$pid/coredump_filter
has been removed from the -mm tree.  Its filename was
     proc-fix-esrch-error-when-writing-to-proc-pid-coredump_filter.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Colin Ian King <colin.king@canonical.com>
Subject: proc: fix -ESRCH error when writing to /proc/$pid/coredump_filter

echo 0 > /proc/self/coredump_filter
bash: echo: write error: No such process

Writing to /proc/$pid/coredump_filter always returns -ESRCH because commit
774636e19ed51 ("proc: convert to kstrto*()/kstrto*_from_user()") removed
the setting of ret after the get_proc_task call and incorrectly left it as
-ESRCH.  Instead, return 0 when successful.

Fixes: 774636e19ed51 ("proc: convert to kstrto*()/kstrto*_from_user()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Kees Cook <keescook@chromium.org>
Cc: <stable@vger.kernel.org> [4.3+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/proc/base.c |    1 +
 1 file changed, 1 insertion(+)

diff -puN fs/proc/base.c~proc-fix-esrch-error-when-writing-to-proc-pid-coredump_filter fs/proc/base.c
--- a/fs/proc/base.c~proc-fix-esrch-error-when-writing-to-proc-pid-coredump_filter
+++ a/fs/proc/base.c
@@ -2494,6 +2494,7 @@ static ssize_t proc_coredump_filter_writ
 	mm = get_task_mm(task);
 	if (!mm)
 		goto out_no_mm;
+	ret = 0;
 
 	for (i = 0, mask = 1; i < MMF_DUMP_FILTER_BITS; i++, mask <<= 1) {
 		if (val & mask)
_

Patches currently in -mm which might be from colin.king@canonical.com are



^ permalink raw reply	[flat|nested] 2+ messages in thread

* [merged] proc-fix-esrch-error-when-writing-to-proc-pid-coredump_filter.patch removed from -mm tree
@ 2015-12-21 20:24 akpm
  0 siblings, 0 replies; 2+ messages in thread
From: akpm @ 2015-12-21 20:24 UTC (permalink / raw)
  To: colin.king, keescook, stable, mm-commits


The patch titled
     Subject: proc: fix -ESRCH error when writing to /proc/$pid/coredump_filter
has been removed from the -mm tree.  Its filename was
     proc-fix-esrch-error-when-writing-to-proc-pid-coredump_filter.patch

This patch was dropped because it was merged into mainline or a subsystem tree

------------------------------------------------------
From: Colin Ian King <colin.king@canonical.com>
Subject: proc: fix -ESRCH error when writing to /proc/$pid/coredump_filter

echo 0 > /proc/self/coredump_filter
bash: echo: write error: No such process

Writing to /proc/$pid/coredump_filter always returns -ESRCH because commit
774636e19ed51 ("proc: convert to kstrto*()/kstrto*_from_user()") removed
the setting of ret after the get_proc_task call and incorrectly left it as
-ESRCH.  Instead, return 0 when successful.

Fixes: 774636e19ed51 ("proc: convert to kstrto*()/kstrto*_from_user()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Kees Cook <keescook@chromium.org>
Cc: <stable@vger.kernel.org> [4.3+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 fs/proc/base.c |    1 +
 1 file changed, 1 insertion(+)

diff -puN fs/proc/base.c~proc-fix-esrch-error-when-writing-to-proc-pid-coredump_filter fs/proc/base.c
--- a/fs/proc/base.c~proc-fix-esrch-error-when-writing-to-proc-pid-coredump_filter
+++ a/fs/proc/base.c
@@ -2494,6 +2494,7 @@ static ssize_t proc_coredump_filter_writ
 	mm = get_task_mm(task);
 	if (!mm)
 		goto out_no_mm;
+	ret = 0;
 
 	for (i = 0, mask = 1; i < MMF_DUMP_FILTER_BITS; i++, mask <<= 1) {
 		if (val & mask)
_

Patches currently in -mm which might be from colin.king@canonical.com are



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-12-21 20:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-21 20:24 [merged] proc-fix-esrch-error-when-writing-to-proc-pid-coredump_filter.patch removed from -mm tree akpm
2015-12-21 20:24 akpm

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.