[PATCH] Staging: comedi: fix block comments coding style issue in comedi.h

[PATCH] Staging: comedi: fix block comments coding style issue in comedi.h

[maomao xu]

Fix up block comments to make a trailing */ on a separate line

Signed-off-by: maomao xu <albert008.xu@gmail.com>
---
 drivers/staging/comedi/comedi.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
index 66edda1..ec5e59c 100644
--- a/drivers/staging/comedi/comedi.h
+++ b/drivers/staging/comedi/comedi.h
@@ -895,7 +895,8 @@ enum amplc_dio_ts_clock_src {
 };
 
 /* Values for setting a gate source with INSN_CONFIG_SET_GATE_SRC for
- * 8254 counter subdevices on Amplicon DIO boards (amplc_dio200 driver). */
+ * 8254 counter subdevices on Amplicon DIO boards (amplc_dio200 driver).
+ */
 enum amplc_dio_gate_source {
 	AMPLC_DIO_GAT_VCC,	/* internal high logic level */
 	AMPLC_DIO_GAT_GND,	/* internal low logic level */
-- 
1.7.9.5

Re: [PATCH] Staging: comedi: fix block comments coding style issue in comedi.h

[Ian Abbott]

On 22/12/15 05:41, maomao xu wrote:
> Fix up block comments to make a trailing */ on a separate line
>
> Signed-off-by: maomao xu <albert008.xu@gmail.com>
> ---
>   drivers/staging/comedi/comedi.h |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
> index 66edda1..ec5e59c 100644
> --- a/drivers/staging/comedi/comedi.h
> +++ b/drivers/staging/comedi/comedi.h
> @@ -895,7 +895,8 @@ enum amplc_dio_ts_clock_src {
>   };
>
>   /* Values for setting a gate source with INSN_CONFIG_SET_GATE_SRC for
> - * 8254 counter subdevices on Amplicon DIO boards (amplc_dio200 driver). */
> + * 8254 counter subdevices on Amplicon DIO boards (amplc_dio200 driver).
> + */
>   enum amplc_dio_gate_source {
>   	AMPLC_DIO_GAT_VCC,	/* internal high logic level */
>   	AMPLC_DIO_GAT_GND,	/* internal low logic level */
>

Sorry, this clashes with another patch in Greg's staging-next branch. 
Also, it doesn't use the preferred block comment style with the leading 
'/*' on a separate line.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

Re: [PATCH] Staging: comedi: fix block comments coding style issue in comedi.h

[Sudip Mukherjee]

On Wed, Dec 23, 2015 at 10:51:11AM +0800, maoma king wrote:
> Dear Greg
>   I have sent my first patch (https://lkml.org/lkml/2015/11/18/239) to
> linux-next tree.But I never received anything about it.So I sent it
> again. You say "Doesn't apply to my tree :(".but it can be apply to
> least linux-next branch .
> I make n new patch and send it.I receive
> review(https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1048115.html)
> .
> I want to know what's wrong with me?

Nothing is wrong with me. Just work with staging-testing branch of
staging tree and everything should be fine. Ofcourse, if some one else
sends another patch before you touching the same code that you have
worked on then your patch may not apply. But that is part of the game.

> how do I know that my patch is accepted?

When Greg applies any patch to his tree, one confirmation mail will be
automatically sent.

regards
sudip

Re: [PATCH] Staging: comedi: fix block comments coding style issue in comedi.h

[maoma king]

Dear Greg
  I have sent my first patch (https://lkml.org/lkml/2015/11/18/239) to
linux-next tree.But I never received anything about it.So I sent it
again. You say "Doesn't apply to my tree :(".but it can be apply to
least linux-next branch .
I make n new patch and send it.I receive
review(https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1048115.html)
.
I want to know what's wrong with me?
how do I know that my patch is accepted?

2015-12-22 8:02 GMT+08:00 Greg KH <gregkh@linuxfoundation.org>:
> On Mon, Dec 14, 2015 at 03:41:10PM +0800, maomao xu wrote:
>> Fix up block comments to make a trailing */ on a separate line
>>
>> Signed-off-by: maomao xu <albert008.xu@gmail.com>
>> ---
>>  drivers/staging/comedi/comedi.h | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> Doesn't apply to my tree :(

Re: [PATCH] Staging: comedi: fix block comments coding style issue in comedi.h

[Greg KH]

On Mon, Dec 14, 2015 at 03:41:10PM +0800, maomao xu wrote:
> Fix up block comments to make a trailing */ on a separate line
> 
> Signed-off-by: maomao xu <albert008.xu@gmail.com>
> ---
>  drivers/staging/comedi/comedi.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Doesn't apply to my tree :(

[PATCH] Staging: comedi: fix block comments coding style issue in comedi.h

[maomao xu]

Fix up block comments to make a trailing */ on a separate line

Signed-off-by: maomao xu <albert008.xu@gmail.com>
---
 drivers/staging/comedi/comedi.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
index 66edda1..ec5e59c 100644
--- a/drivers/staging/comedi/comedi.h
+++ b/drivers/staging/comedi/comedi.h
@@ -895,7 +895,8 @@ enum amplc_dio_ts_clock_src {
 };
 
 /* Values for setting a gate source with INSN_CONFIG_SET_GATE_SRC for
- * 8254 counter subdevices on Amplicon DIO boards (amplc_dio200 driver). */
+ * 8254 counter subdevices on Amplicon DIO boards (amplc_dio200 driver).
+ */
 enum amplc_dio_gate_source {
 	AMPLC_DIO_GAT_VCC,	/* internal high logic level */
 	AMPLC_DIO_GAT_GND,	/* internal low logic level */
-- 
1.9.1

[PATCH] Staging: comedi: fix block comments coding style issue in comedi.h

[maomao xu]

Fix up block comments to make a trailing */ on a separate line

Signed-off-by: maomao xu <albert008.xu@gmail.com>
---
 drivers/staging/comedi/comedi.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h
index 66edda1..ec5e59c 100644
--- a/drivers/staging/comedi/comedi.h
+++ b/drivers/staging/comedi/comedi.h
@@ -895,7 +895,8 @@ enum amplc_dio_ts_clock_src {
 };
 
 /* Values for setting a gate source with INSN_CONFIG_SET_GATE_SRC for
- * 8254 counter subdevices on Amplicon DIO boards (amplc_dio200 driver). */
+ * 8254 counter subdevices on Amplicon DIO boards (amplc_dio200 driver).
+ */
 enum amplc_dio_gate_source {
 	AMPLC_DIO_GAT_VCC,	/* internal high logic level */
 	AMPLC_DIO_GAT_GND,	/* internal low logic level */
-- 
1.9.1

Re: [PATCH] Staging: comedi: fix block comments coding style issue in comedi.h

[Greg KH]

On Mon, Nov 09, 2015 at 09:20:24PM +0800, maomao wrote:
> Fix up block comments to make a trailing */ on a separate line
> 
> Signed-off-by: maomao <albert008.xu@yahoo.com>

I need a "real" name here, and on the From: line in order to be able to
accept this.  Is this how you sign legal documents?

thanks,

greg k-h